class TwitapifriendshipsAction extends TwitterapiAction {
+ function is_readonly() {
+
+ static $write_methods = array( 'create',
+ 'destroy');
+
+ $cmdtext = explode('.', $this->arg('method'));
+
+ if (in_array($cmdtext[0], $write_methods)) {
+ return false;
+ }
+
+ return true;
+ }
+
function create($args, $apidata) {
parent::handle($args);
- $id = $this->trimmed('id');
+ $id = $apidata['api_arg'];
$other = $this->get_user($id);
if (!$other) {
- $this->client_error(_('No such user'));
- return;
+ $this->client_error(_('Could not follow user: User not found.'), 403, $apidata['content-type']);
+ exit();
}
$user = $apidata['user'];
if ($user->isSubscribed($other)) {
- $this->client_error(_('Already subscribed.'));
- return;
+ $errmsg = sprintf(_('Could not follow user: %s is already on your list.'), $other->nickname);
+ $this->client_error($errmsg, 403, $apidata['content-type']);
+ exit();
}
$sub = new Subscription();
+
+ $sub->query('BEGIN');
+
$sub->subscriber = $user->id;
$sub->subscribed = $other->id;
-
+ $sub->created = DB_DataObject_Cast::dateTime(); # current time
+
$result = $sub->insert();
if (!$result) {
- $this->server_error(_('Could not subscribe'));
- return;
+ $errmsg = sprintf(_('Could not follow user: %s is already on your list.'), $other->nickname);
+ $this->client_error($errmsg, 400, $apidata['content-type']);
+ exit();
}
+ $sub->query('COMMIT');
+
mail_subscribe_notify($other, $user);
- $this->show_profile($other);
+ $type = $apidata['content-type'];
+ $this->init_document($type);
+ $this->show_profile($other, $type);
+ $this->end_document($type);
exit();
}
function destroy($args, $apidata) {
parent::handle($args);
- $id = $this->trimmed('id');
+ $id = $apidata['api_arg'];
# We can't subscribe to a remote person, but we can unsub
$sub->subscriber = $user->id;
$sub->subscribed = $other->id;
- if ($sub->fetch(TRUE)) {
+ if ($sub->find(TRUE)) {
+ $sub->query('BEGIN');
$sub->delete();
+ $sub->query('COMMIT');
+ } else {
+ $this->client_error(_('You are not friends with the specified user.'), 403, $apidata['content-type']);
+ exit();
}
- $this->show_profile($other);
+ $type = $apidata['content-type'];
+ $this->init_document($type);
+ $this->show_profile($other, $type);
+ $this->end_document($type);
exit();
}
function exists($args, $apidata) {
parent::handle($args);
+
+
$user_a_id = $this->trimmed('user_a');
$user_b_id = $this->trimmed('user_b');
- $user_a = $this->get_profile($user_a_id);
- $user_b = $this->get_profile($user_b_id);
+
+ $user_a = $this->get_user($user_a_id);
+ $user_b = $this->get_user($user_b_id);
if (!$user_a || !$user_b) {
- $this->client_error(_('No such user'));
- return;
+ $this->client_error(_('Two user ids or screen_names must be supplied.'), 400, $apidata['content-type']);
+ exit();
}
if ($user_a->isSubscribed($user_b)) {
switch ($apidata['content-type']) {
case 'xml':
- common_start_xml();
+ $this->init_document('xml');
common_element('friends', NULL, $result);
- common_end_xml();
+ $this->end_document('xml');
break;
case 'json':
+ $this->init_document('json');
print json_encode($result);
- print "\n";
+ $this->end_document('json');
break;
default:
- print $result;
+ print $result; // Really? --Zach
break;
}
+ exit();
}
function get_profile($id) {
if (is_numeric($id)) {
return Profile::staticGet($id);
} else {
- $user = User::staticGet('nickname', $id);
+ $user = User::staticGet('nickname', $id);
if ($user) {
return $user->getProfile();
} else {