Convert use of common_server_error and common_user_error to methods on Action

[quix0rs-gnu-social.git] / actions / all.php

diff --git a/actions/all.php b/actions/all.php
index 0f8cf587cd8a27943ff1a68790a2aeedcf63dbce..4ad7f12aee3deb798bc142937dad0a97187cbc19 100644 (file)
--- a/actions/all.php
+++ b/actions/all.php
@@ -21,83 +21,78 @@ if (!defined('LACONICA')) { exit(1); }
 
 require_once(INSTALLDIR.'/actions/showstream.php');
 
-class AllAction extends StreamAction {
-
-       function handle($args) {
-
-               parent::handle($args);
-
-               $nickname = common_canonical_nickname($this->arg('nickname'));
-               $user = User::staticGet('nickname', $nickname);
-
-               if (!$user) {
-                       $this->client_error(_('No such user.'));
-                       return;
-               }
-
-               $profile = $user->getProfile();
-
-               if (!$profile) {
-                       common_server_error(_('User has no profile.'));
-                       return;
-               }
-
-               # Looks like we're good; show the header
-
-               common_show_header(sprintf(_("%s and friends"), $profile->nickname),
-                                                  array($this, 'show_header'), $user,
-                                                  array($this, 'show_top'));
-
-               $this->show_notices($user);
-
-               common_show_footer();
-       }
-
-       function show_header($user) {
-               common_element('link', array('rel' => 'alternate',
-                                                                        'href' => common_local_url('allrss', array('nickname' =>
-                                                                                                                                                          $user->nickname)),
-                                                                        'type' => 'application/rss+xml',
-                                                                        'title' => sprintf(_('Feed for friends of %s'), $user->nickname)));
-       }
-
-       function show_top($user) {
-               $cur = common_current_user();
-
-               if ($cur && $cur->id == $user->id) {
-                       common_notice_form('all');
-               }
-
-               $this->views_menu();
-       }
-
-       function show_notices($user) {
-
-               $page = $this->trimmed('page');
-               if (!$page) {
-                       $page = 1;
-               }
-               
-               $notice = $user->noticesWithFriends(($page-1)*NOTICES_PER_PAGE, NOTICES_PER_PAGE + 1);
-                                                                                       
-               # XXX: revisit constant scope
-               
-               $cnt = $notice->find();
-               
-               if ($cnt > 0) {
-                       common_element_start('ul', array('id' => 'notices'));
-                       for ($i = 0; $i < min($cnt, NOTICES_PER_PAGE); $i++) {
-                               if ($notice->fetch()) {
-                                       $this->show_notice($notice);
-                               } else {
-                                       // shouldn't happen!
-                                       break;
-                               }
-                       }
-                       common_element_end('ul');
-               }
-
-               common_pagination($page > 1, $cnt > NOTICES_PER_PAGE,
-                                                 $page, 'all', array('nickname' => $profile->nickname));
-       }
+class AllAction extends StreamAction
+{
+
+    function handle($args)
+    {
+
+        parent::handle($args);
+
+        $nickname = common_canonical_nickname($this->arg('nickname'));
+        $user = User::staticGet('nickname', $nickname);
+
+        if (!$user) {
+            $this->clientError(_('No such user.'));
+            return;
+        }
+
+        $profile = $user->getProfile();
+
+        if (!$profile) {
+            $this->serverError(_('User has no profile.'));
+            return;
+        }
+
+        # Looks like we're good; show the header
+
+        common_show_header(sprintf(_("%s and friends"), $profile->nickname),
+                           array($this, 'show_header'), $user,
+                           array($this, 'show_top'));
+
+        $this->show_notices($user);
+
+        common_show_footer();
+    }
+
+    function show_header($user)
+    {
+        $this->element('link', array('rel' => 'alternate',
+                                     'href' => common_local_url('allrss', array('nickname' =>
+                                                                               $user->nickname)),
+                                     'type' => 'application/rss+xml',
+                                     'title' => sprintf(_('Feed for friends of %s'), $user->nickname)));
+    }
+
+    function show_top($user)
+    {
+        $cur = common_current_user();
+
+        if ($cur && $cur->id == $user->id) {
+            common_notice_form('all');
+        }
+
+        $this->views_menu();
+
+        $this->show_feeds_list(array(0=>array('href'=>common_local_url('allrss', array('nickname' => $user->nickname)),
+                                              'type' => 'rss',
+                                              'version' => 'RSS 1.0',
+                                              'item' => 'allrss')));
+    }
+
+    function show_notices($user)
+    {
+
+        $page = $this->trimmed('page');
+        if (!$page) {
+            $page = 1;
+        }
+
+        $notice = $user->noticesWithFriends(($page-1)*NOTICES_PER_PAGE, NOTICES_PER_PAGE + 1);
+
+        $cnt = $this->show_notice_list($notice);
+
+        common_pagination($page > 1, $cnt > NOTICES_PER_PAGE,
+                          $page, 'all', array('nickname' => $user->nickname));
+    }
 }