/api/statuses/update.:format
@par Formats (:format)
- xml, json
+ xml, json, atom
@par HTTP Method(s)
POST
*/
class ApiStatusesUpdateAction extends ApiAuthAction
{
+ protected $needPost = true;
+
var $status = null;
var $in_reply_to_status_id = null;
var $lat = null;
var $lon = null;
+ var $media_ids = array(); // file_id in the keys
/**
* Take arguments for running
*
* @return boolean success flag
*/
- function prepare($args)
+ protected function prepare(array $args=array())
{
parent::prepare($args);
$this->status = $this->trimmed('status');
$this->lat = $this->trimmed('lat');
$this->lon = $this->trimmed('long');
+ $matches = array();
+ common_debug(get_called_class().': media_ids=='._ve($this->trimmed('media_ids')));
+ if (preg_match_all('/\d+/', $this->trimmed('media_ids'), $matches) !== false) {
+ foreach (array_unique($matches[0]) as $match) {
+ try {
+ $this->media_ids[$match] = File::getByID($match);
+ } catch (EmptyPkeyValueException $e) {
+ // got a zero from the client, at least Twidere does this on occasion
+ } catch (NoResultException $e) {
+ // File ID was not found. Do we abort and report to the client?
+ }
+ }
+ }
$this->in_reply_to_status_id
= intval($this->trimmed('in_reply_to_status_id'));
*
* Make a new notice for the update, save it, and show it
*
- * @param array $args $_REQUEST data (unused)
- *
* @return void
*/
- function handle($args)
+ protected function handle()
{
- parent::handle($args);
-
- if ($_SERVER['REQUEST_METHOD'] != 'POST') {
- $this->clientError(
- // TRANS: Client error. POST is a HTTP command. It should not be translated.
- _('This method requires a POST.'),
- 400,
- $this->format
- );
- return;
- }
+ parent::handle();
// Workaround for PHP returning empty $_POST and $_FILES when POST
// length > post_max_size in php.ini
intval($_SERVER['CONTENT_LENGTH']));
$this->clientError(sprintf($msg, $_SERVER['CONTENT_LENGTH']));
- return;
}
if (empty($this->status)) {
- $this->clientError(
- // TRANS: Client error displayed when the parameter "status" is missing.
- _('Client must provide a \'status\' parameter with a value.'),
- 400,
- $this->format
- );
- return;
+ // TRANS: Client error displayed when the parameter "status" is missing.
+ $this->clientError(_('Client must provide a \'status\' parameter with a value.'));
}
- if (empty($this->auth_user)) {
+ if (is_null($this->scoped)) {
// TRANS: Client error displayed when updating a status for a non-existing user.
- $this->clientError(_('No such user.'), 404, $this->format);
- return;
+ $this->clientError(_('No such user.'), 404);
}
- /* Do not call shortenlinks until the whole notice has been build */
+ /* Do not call shortenLinks until the whole notice has been build */
// Check for commands
if ($reply) {
$reply_to = $this->in_reply_to_status_id;
} else {
- $this->clientError(
- // TRANS: Client error displayed when replying to a non-existing notice.
- _('Parent notice not found.'),
- $code = 404,
- $this->format
- );
- return;
+ // TRANS: Client error displayed when replying to a non-existing notice.
+ $this->clientError(_('Parent notice not found.'), 404);
}
}
- $upload = null;
-
- try {
- $upload = MediaFile::fromUpload('media', $this->auth_user);
- } catch (Exception $e) {
- $this->clientError($e->getMessage(), $e->getCode(), $this->format);
- return;
+ foreach(array_keys($this->media_ids) as $media_id) {
+ // FIXME: Validation on this... Worst case is that if someone sends bad media_ids then
+ // we'll fill the notice with non-working links, so no real harm, done, but let's fix.
+ // The File objects are in the array, so we could get URLs from them directly.
+ $this->status .= ' ' . common_local_url('attachment', array('attachment' => $media_id));
}
- if (isset($upload)) {
+ $upload = null;
+ try {
+ $upload = MediaFile::fromUpload('media', $this->scoped);
$this->status .= ' ' . $upload->shortUrl();
-
- /* Do not call shortenlinks until the whole notice has been build */
+ /* Do not call shortenLinks until the whole notice has been build */
+ } catch (NoUploadedMediaException $e) {
+ // There was no uploaded media for us today.
}
/* Do call shortenlinks here & check notice length since notice is about to be saved & sent */
- $status_shortened = $this->auth_user->shortenlinks($this->status);
+ $status_shortened = $this->auth_user->shortenLinks($this->status);
if (Notice::contentTooLong($status_shortened)) {
- if (isset($upload)) {
+ if ($upload instanceof MediaFile) {
$upload->delete();
}
// TRANS: Client error displayed exceeding the maximum notice length.
/* Use HTTP 413 error code (Request Entity Too Large)
* instead of basic 400 for better understanding
*/
- $this->clientError(sprintf($msg, Notice::maxContent()),
- 413,
- $this->format);
+ $this->clientError(sprintf($msg, Notice::maxContent()), 413);
}
$options = array('reply_to' => $reply_to);
- if ($this->auth_user->shareLocation()) {
+ if ($this->scoped->shareLocation()) {
$locOptions = Notice::locationOptions($this->lat,
$this->lon,
null,
null,
- $this->auth_user->getProfile());
+ $this->scoped);
$options = array_merge($options, $locOptions);
}
try {
$this->notice = Notice::saveNew(
- $this->auth_user->id,
+ $this->scoped->id,
$content,
$this->source,
$options
);
} catch (Exception $e) {
- $this->clientError($e->getMessage(), $e->getCode(), $this->format);
- return;
+ $this->clientError($e->getMessage(), $e->getCode());
}
if (isset($upload)) {
$this->showSingleXmlStatus($this->notice);
} elseif ($this->format == 'json') {
$this->show_single_json_status($this->notice);
+ } elseif ($this->format == 'atom') {
+ $this->showSingleAtomStatus($this->notice);
}
}
}
*/
function supported($cmd)
{
- static $cmdlist = array('MessageCommand', 'SubCommand', 'UnsubCommand',
- 'FavCommand', 'OnCommand', 'OffCommand', 'JoinCommand', 'LeaveCommand');
+ static $cmdlist = array('SubCommand', 'UnsubCommand',
+ 'OnCommand', 'OffCommand', 'JoinCommand', 'LeaveCommand');
+
+ $supported = null;
- if (in_array(get_class($cmd), $cmdlist)) {
- return true;
+ if (Event::handle('CommandSupportedAPI', array($cmd, &$supported))) {
+ $supported = $supported || in_array(get_class($cmd), $cmdlist);
}
- return false;
+ return $supported;
}
}