* @category Applications
* @package StatusNet
* @author Zach Copley <zach@status.net>
- * @copyright 2008-2009 StatusNet, Inc.
+ * @copyright 2008-2011 StatusNet, Inc.
* @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0
* @link http://status.net/
*/
* @license http://www.fsf.org/licensing/licenses/agpl-3.0.html GNU Affero General Public License version 3.0
* @link http://status.net/
*/
-
-class EditApplicationAction extends OwnerDesignAction
+class EditApplicationAction extends Action
{
- var $msg = null;
-
- var $app = null;
+ var $msg = null;
+ var $owner = null;
+ var $app = null;
function title()
{
- return _('Edit Application');
+ // TRANS: Title for "Edit application" form.
+ return _('Edit application');
}
/**
* Prepare to run
*/
-
- function prepare($args)
+ function prepare(array $args=array())
{
parent::prepare($args);
if (!common_logged_in()) {
+ // TRANS: Client error displayed trying to edit an application while not logged in.
$this->clientError(_('You must be logged in to edit an application.'));
- return false;
}
$id = (int)$this->arg('id');
- $this->app = Oauth_application::staticGet($id);
+
+ $this->app = Oauth_application::getKV($id);
+ $this->owner = User::getKV($this->app->owner);
+ $cur = common_current_user();
+
+ if ($cur->id != $this->owner->id) {
+ // TRANS: Client error displayed trying to edit an application while not being its owner.
+ $this->clientError(_('You are not the owner of this application.'), 401);
+ }
if (!$this->app) {
+ // TRANS: Client error displayed trying to edit an application that does not exist.
$this->clientError(_('No such application.'));
- return false;
}
return true;
/**
* Handle the request
*
- * On GET, show the form. On POST, try to save the group.
+ * On GET, show the form. On POST, try to save the app.
*
* @param array $args unused
*
* @return void
*/
-
- function handle($args)
+ function handle(array $args=array())
{
parent::handle($args);
- if ($_SERVER['REQUEST_METHOD'] == 'POST') {
- // CSRF protection
- $token = $this->trimmed('token');
- if (!$token || $token != common_session_token()) {
- $this->clientError(_('There was a problem with your session token.'));
- return;
- }
-
- $cur = common_current_user();
-
- if ($this->arg('cancel')) {
- common_redirect(common_local_url('showapplication',
- array(
- 'nickname' => $cur->nickname,
- 'id' => $this->app->id)
- ), 303);
- } elseif ($this->arg('save')) {
- $this->trySave();
- } else {
- $this->clientError(_('Unexpected form submission.'));
- }
+ if ($_SERVER['REQUEST_METHOD'] == 'POST') {
+ $this->handlePost($args);
} else {
$this->showForm();
}
}
+ function handlePost($args)
+ {
+ // Workaround for PHP returning empty $_POST and $_FILES when POST
+ // length > post_max_size in php.ini
+
+ if (empty($_FILES)
+ && empty($_POST)
+ && ($_SERVER['CONTENT_LENGTH'] > 0)
+ ) {
+ // TRANS: Client error displayed when the number of bytes in a POST request exceeds a limit.
+ // TRANS: %s is the number of bytes of the CONTENT_LENGTH.
+ $msg = _m('The server was unable to handle that much POST data (%s byte) due to its current configuration.',
+ 'The server was unable to handle that much POST data (%s bytes) due to its current configuration.',
+ intval($_SERVER['CONTENT_LENGTH']));
+ $this->clientException(sprintf($msg, $_SERVER['CONTENT_LENGTH']));
+ return;
+ }
+
+ // CSRF protection
+ $token = $this->trimmed('token');
+ if (!$token || $token != common_session_token()) {
+ // TRANS: Client error displayed when the session token does not match or is not given.
+ $this->clientError(_('There was a problem with your session token.'));
+ }
+
+ $cur = common_current_user();
+
+ if ($this->arg('cancel')) {
+ common_redirect(common_local_url('showapplication',
+ array('id' => $this->app->id)), 303);
+ } elseif ($this->arg('save')) {
+ $this->trySave();
+ } else {
+ // TRANS: Client error displayed submitting invalid form data for edit application.
+ $this->clientError(_('Unexpected form submission.'));
+ }
+ }
+
function showForm($msg=null)
{
$this->msg = $msg;
$this->element('p', 'error', $this->msg);
} else {
$this->element('p', 'instructions',
+ // TRANS: Instructions for "Edit application" form.
_('Use this form to edit your application.'));
}
}
$homepage = $this->trimmed('homepage');
$callback_url = $this->trimmed('callback_url');
$type = $this->arg('app_type');
- $access_type = $this->arg('access_type');
+ $access_type = $this->arg('default_access_type');
if (empty($name)) {
- $this->showForm(_('Name is required.'));
- return;
+ // TRANS: Validation error shown when not providing a name in the "Edit application" form.
+ $this->showForm(_('Name is required.'));
+ return;
} elseif (mb_strlen($name) > 255) {
- $this->showForm(_('Name is too long (max 255 chars).'));
+ // TRANS: Validation error shown when providing too long a name in the "Edit application" form.
+ $this->showForm(_('Name is too long (maximum 255 characters).'));
+ return;
+ } else if ($this->nameExists($name)) {
+ // TRANS: Validation error shown when providing a name for an application that already exists in the "Edit application" form.
+ $this->showForm(_('Name already in use. Try another one.'));
return;
} elseif (empty($description)) {
+ // TRANS: Validation error shown when not providing a description in the "Edit application" form.
$this->showForm(_('Description is required.'));
return;
} elseif (Oauth_application::descriptionTooLong($description)) {
$this->showForm(sprintf(
- _('Description is too long (max %d chars).'),
- Oauth_application::maxDescription()));
+ // TRANS: Validation error shown when providing too long a description in the "Edit application" form.
+ // TRANS: %d is the maximum number of allowed characters.
+ _m('Description is too long (maximum %d character).',
+ 'Description is too long (maximum %d characters).',
+ Oauth_application::maxDesc()),
+ Oauth_application::maxDesc()));
return;
- } elseif (empty($source_url)) {
- $this->showForm(_('Source URL is required.'));
+ } elseif (mb_strlen($source_url) > 255) {
+ // TRANS: Validation error shown when providing too long a source URL in the "Edit application" form.
+ $this->showForm(_('Source URL is too long.'));
return;
- } elseif ((strlen($source_url) > 0)
- && !Validate::uri(
- $source_url,
- array('allowed_schemes' => array('http', 'https'))
- )
- )
- {
+ } elseif ((mb_strlen($source_url) > 0)
+ && !common_valid_http_url($source_url)) {
+ // TRANS: Validation error shown when providing an invalid source URL in the "Edit application" form.
$this->showForm(_('Source URL is not valid.'));
return;
} elseif (empty($organization)) {
+ // TRANS: Validation error shown when not providing an organisation in the "Edit application" form.
$this->showForm(_('Organization is required.'));
return;
} elseif (mb_strlen($organization) > 255) {
- $this->showForm(_('Organization is too long (max 255 chars).'));
+ // TRANS: Validation error shown when providing too long an arganisation name in the "Edit application" form.
+ $this->showForm(_('Organization is too long (maximum 255 characters).'));
return;
} elseif (empty($homepage)) {
+ // TRANS: Form validation error show when an organisation name has not been provided in the edit application form.
$this->showForm(_('Organization homepage is required.'));
return;
- } elseif ((strlen($homepage) > 0)
- && !Validate::uri(
- $homepage,
- array('allowed_schemes' => array('http', 'https'))
- )
- )
- {
+ } elseif ((mb_strlen($homepage) > 0)
+ && !common_valid_http_url($homepage)) {
+ // TRANS: Validation error shown when providing an invalid homepage URL in the "Edit application" form.
$this->showForm(_('Homepage is not a valid URL.'));
return;
- } elseif (empty($callback_url)) {
- $this->showForm(_('Callback is required.'));
+ } elseif (mb_strlen($callback_url) > 255) {
+ // TRANS: Validation error shown when providing too long a callback URL in the "Edit application" form.
+ $this->showForm(_('Callback is too long.'));
return;
- } elseif (strlen($callback_url) > 0
- && !Validate::uri(
- $source_url,
- array('allowed_schemes' => array('http', 'https'))
- )
- )
- {
+ } elseif (mb_strlen($callback_url) > 0
+ && !common_valid_http_url($callback_url)) {
+ // TRANS: Validation error shown when providing an invalid callback URL in the "Edit application" form.
$this->showForm(_('Callback URL is not valid.'));
return;
}
// Checked in prepare() above
assert(!is_null($cur));
+ assert(!is_null($this->app));
$orig = clone($this->app);
$this->app->callback_url = $callback_url;
$this->app->type = $type;
+ common_debug("access_type = $access_type");
+
if ($access_type == 'r') {
- $this->app->setAccessFlags(true, false);
+ $this->app->access_type = 1;
} else {
- $this->app->setAccessFlags(true, true);
+ $this->app->access_type = 3;
}
$result = $this->app->update($orig);
- if (!$result) {
- common_log_db_error($app, 'UPDATE', __FILE__);
+ // Note: 0 means no rows changed, which can happen if the only
+ // thing we changed was the icon, since it's not altered until
+ // the next step.
+ if ($result === false) {
+ common_log_db_error($this->app, 'UPDATE', __FILE__);
+ // TRANS: Server error occuring when an application could not be updated from the "Edit application" form.
$this->serverError(_('Could not update application.'));
}
- common_redirect(common_local_url('apps',
- array('nickname' => $cur->nickname)), 303);
+ $this->app->uploadLogo();
+
+ common_redirect(common_local_url('oauthappssettings'), 303);
}
+ /**
+ * Does the app name already exist?
+ *
+ * Checks the DB to see someone has already registered an app
+ * with the same name.
+ *
+ * @param string $name app name to check
+ *
+ * @return boolean true if the name already exists
+ */
+ function nameExists($name)
+ {
+ $newapp = Oauth_application::getKV('name', $name);
+ if (empty($newapp)) {
+ return false;
+ } else {
+ return $newapp->id != $this->app->id;
+ }
+ }
}
-