class ProfilesettingsAction extends SettingsAction {
- function show_form($msg=NULL, $success=false) {
- $user = common_current_user();
- $profile = $user->getProfile();
- common_show_header(_t('Profile settings'), NULL, NULL, array($this, 'settings_menu'));
-
+ function show_top($arr) {
+ $msg = $arr[0];
+ $success = $arr[1];
if ($msg) {
$this->message($msg, $success);
} else {
common_element('div', 'instructions',
_t('You can update your personal profile info here '.
- 'so people know more about you. '));
+ 'so people know more about you.'));
}
+ $this->settings_menu();
+ }
+
+ function show_form($msg=NULL, $success=false) {
+ $user = common_current_user();
+ $profile = $user->getProfile();
+ common_show_header(_t('Profile settings'), NULL, array($msg, $success),
+ array($this, 'show_top'));
+
common_element_start('form', array('method' => 'POST',
'id' => 'profilesettings',
'action' =>
# Some validation
- if (!Validate::email($email, true)) {
+ if ($email && !Validate::email($email, true)) {
$this->show_form(_t('Not a valid email address.'));
return;
} else if (!Validate::string($nickname, array('min_length' => 1,
'format' => VALIDATE_NUM . VALIDATE_ALPHA_LOWER))) {
$this->show_form(_t('Nickname must have only letters and numbers and no spaces.'));
return;
+ } else if (!User::allowed_nickname($nickname)) {
+ $this->show_form(_t('Not a valid nickname.'));
+ return;
} else if (!is_null($homepage) && (strlen($homepage) > 0) &&
!Validate::uri($homepage, array('allowed_schemes' => array('http', 'https')))) {
$this->show_form(_t('Homepage is not a valid URL.'));
}
$user = common_current_user();
- assert(!is_null($user)); # should already be checked
-
- # FIXME: transaction!
- $original = clone($user);
+ $user->query('BEGIN');
- $user->nickname = $nickname;
- $user->email = $email;
+ if ($user->nickname != $nickname) {
+
+ common_debug('Updating user nickname from ' . $user->nickname . ' to ' . $nickname,
+ __FILE__);
+
+ $original = clone($user);
+
+ $user->nickname = $nickname;
- if (!$user->update($original)) {
- common_server_error(_t('Couldnt update user.'));
- return;
+ $result = $user->updateKeys($original);
+
+ if ($result === FALSE) {
+ common_log_db_error($user, 'UPDATE', __FILE__);
+ common_server_error(_t('Couldnt update user.'));
+ return;
+ }
}
+ if ($user->email != $email) {
+
+ common_debug('Updating user email from ' . $user->email . ' to ' . $email,
+ __FILE__);
+
+ # We don't update email directly; it gets done by confirmemail
+
+ $confirm = new Confirm_address();
+
+ $confirm->code = common_confirmation_code(128);
+ $confirm->user_id = $user->id;
+ $confirm->address = $email;
+ $confirm->address_type = 'email';
+
+ $result = $confirm->insert();
+
+ if (!$result) {
+ common_log_db_error($confirm, 'INSERT', __FILE__);
+ common_server_error(_t('Couldnt confirm email.'));
+ return FALSE;
+ }
+
+ # XXX: try not to do this in the middle of a transaction
+
+ mail_confirm_address($confirm->code,
+ $profile->nickname,
+ $email);
+ }
+
$profile = $user->getProfile();
$orig_profile = clone($profile);
$profile->location = $location;
$profile->profileurl = common_profile_url($nickname);
- if (FALSE === $profile->update($orig_profile)) {
+ common_debug('Old profile: ' . common_log_objstring($orig_profile), __FILE__);
+ common_debug('New profile: ' . common_log_objstring($profile), __FILE__);
+
+ $result = $profile->update($orig_profile);
+
+ if (!$result) {
+ common_log_db_error($profile, 'UPDATE', __FILE__);
common_server_error(_t('Couldnt save profile.'));
return;
}
+ $user->query('COMMIT');
+
common_broadcast_profile($profile);
-
+
$this->show_form(_t('Settings saved.'), TRUE);
}
return $other->id != $user->id;
}
}
-}
\ No newline at end of file
+}