FormAction wants getInstructions to be protected

[quix0rs-gnu-social.git] / actions / public.php

diff --git a/actions/public.php b/actions/public.php
index 5e07a893ff645239ee4de3c0ccff7ff9d9a8c3df..06ee75b8d1c5fa9b72b52393b0554c90f1669f3a 100644 (file)
--- a/actions/public.php
+++ b/actions/public.php
@@ -45,7 +45,7 @@ define('MAX_PUBLIC_PAGE', 100);
  * @see      PublicrssAction
  * @see      PublicxrdsAction
  */
-class PublicAction extends Action
+class PublicAction extends ManagedAction
 {
     /**
      * page of the stream we're on; default = 1
@@ -53,23 +53,16 @@ class PublicAction extends Action
 
     var $page = null;
     var $notice;
-    var $userProfile = null;
+
+    protected $stream = null;
 
     function isReadOnly($args)
     {
         return true;
     }
 
-    /**
-     * Read and validate arguments
-     *
-     * @param array $args URL parameters
-     *
-     * @return boolean success value
-     */
-    function prepare($args)
+    protected function doPreparation()
     {
-        parent::prepare($args);
         $this->page = ($this->arg('page')) ? ($this->arg('page')+0) : 1;
 
         if ($this->page > MAX_PUBLIC_PAGE) {
@@ -80,17 +73,9 @@ class PublicAction extends Action
 
         common_set_returnto($this->selfUrl());
 
-        $this->userProfile = Profile::current();
-
-        $user = common_current_user();
+        $this->streamPrepare();
 
-        if (!empty($user) && $user->streamModeOnly()) {
-            $stream = new PublicNoticeStream($this->userProfile);
-        } else {
-            $stream = new ThreadingPublicNoticeStream($this->userProfile);
-        }
-
-        $this->notice = $stream->getNotices(($this->page-1)*NOTICES_PER_PAGE,
+        $this->notice = $this->stream->getNotices(($this->page-1)*NOTICES_PER_PAGE,
                                             NOTICES_PER_PAGE + 1);
 
         if (!$this->notice) {
@@ -98,28 +83,21 @@ class PublicAction extends Action
             $this->serverError(_('Could not retrieve public timeline.'));
         }
 
-        if($this->page > 1 && $this->notice->N == 0){
-            // TRANS: Server error when page not found (404).
-            $this->serverError(_('No such page.'),$code=404);
+        if ($this->page > 1 && $this->notice->N == 0){
+            // TRANS: Client error when page not found (404).
+            $this->clientError(_('No such page.'), 404);
         }
 
         return true;
     }
 
-    /**
-     * handle request
-     *
-     * Show the public stream, using recipe method showPage()
-     *
-     * @param array $args arguments, mostly unused
-     *
-     * @return void
-     */
-    function handle($args)
+    protected function streamPrepare()
     {
-        parent::handle($args);
-
-        $this->showPage();
+        if ($this->scoped instanceof Profile && $this->scoped->isLocal() && $this->scoped->getUser()->streamModeOnly()) {
+            $this->stream = new PublicNoticeStream($this->scoped);
+        } else {
+            $this->stream = new ThreadingPublicNoticeStream($this->scoped);
+        }
     }
 
     /**
@@ -217,12 +195,10 @@ class PublicAction extends Action
      */
     function showContent()
     {
-        $user = common_current_user();
-
-        if (!empty($user) && $user->streamModeOnly()) {
-            $nl = new NoticeList($this->notice, $this);
+        if ($this->scoped instanceof Profile && $this->scoped->isLocal() && $this->scoped->getUser()->streamModeOnly()) {
+            $nl = new PrimaryNoticeList($this->notice, $this, array('show_n'=>NOTICES_PER_PAGE));
         } else {
-            $nl = new ThreadedNoticeList($this->notice, $this, $this->userProfile);
+            $nl = new ThreadedNoticeList($this->notice, $this, $this->scoped);
         }
 
         $cnt = $nl->show();
@@ -232,7 +208,7 @@ class PublicAction extends Action
         }
 
         $this->pagination($this->page > 1, $cnt > NOTICES_PER_PAGE,
-                          $this->page, 'public');
+                          $this->page, $this->action);
     }
 
     function showSections()
@@ -283,11 +259,3 @@ class PublicAction extends Action
         $this->elementEnd('div');
     }
 }
-
-class ThreadingPublicNoticeStream extends ThreadingNoticeStream
-{
-    function __construct($profile)
-    {
-        parent::__construct(new PublicNoticeStream($profile));
-    }
-}