better titles in RSS

[quix0rs-gnu-social.git] / actions / public.php

diff --git a/actions/public.php b/actions/public.php
index 89b12493a3ff241fc4a77c985960b62a692f1028..270c082ba360cb279afb0752ef43f9fc50e47ed9 100644 (file)
--- a/actions/public.php
+++ b/actions/public.php
@@ -48,7 +48,9 @@ class PublicAction extends StreamAction {
 
                $notice = DB_DataObject::factory('notice');
 
-               # XXX: filter out private notifications
+               # FIXME: bad performance
+               
+               $notice->whereAdd('EXISTS (SELECT user.id from user where user.id = notice.profile_id)');
 
                $notice->orderBy('created DESC');
                
@@ -58,35 +60,21 @@ class PublicAction extends StreamAction {
 
                $cnt = $notice->find();
 
-               common_element_start('div', 'notices');
-
-               for ($i = 0; $i < min($cnt, NOTICES_PER_PAGE); $i++) {
-                       if ($notice->fetch()) {
-                               $this->show_notice($notice);
-                       } else {
-                               // shouldn't happen!
-                               break;
+               if ($cnt > 0) {
+                       common_element_start('ul', array('id' => 'notices'));
+                       for ($i = 0; $i < min($cnt, NOTICES_PER_PAGE); $i++) {
+                               if ($notice->fetch()) {
+                                       $this->show_notice($notice);
+                               } else {
+                                       // shouldn't happen!
+                                       break;
+                               }
                        }
-               }
-
-               if ($page > 1) {
-                       common_element_start('span', 'floatLeft width25');
-                       common_element('a', array('href' => common_local_url('public',
-                                                                                                                                array('page' => $page-1)),
-                                                                         'class' => 'newer'),
-                                                  _t('Newer'));
-                       common_element_end('span');
+                       common_element_end('ul');
                }
                
-               if ($cnt > NOTICES_PER_PAGE) {
-                       common_element_start('span', 'floatRight width25');
-                       common_element('a', array('href' => common_local_url('public',
-                                                                                                                                array('page' => $page+1)),
-                                                                         'class' => 'older'),
-                                                  _t('Older'));
-                       common_element_end('span');
-               }
-               common_element_end('div');
+               common_pagination($page > 1, $cnt > NOTICES_PER_PAGE,
+                                                 $page, 'public');
        }
 }