Merge branch 'master' into social-master

[quix0rs-gnu-social.git] / actions / tag.php

diff --git a/actions/tag.php b/actions/tag.php
index 33339cb8bfd153fd95976cfe684dc476ad1300ee..8631082467b44ccf71cdf1bb7599dd455fcd7a00 100644 (file)
--- a/actions/tag.php
+++ b/actions/tag.php
@@ -17,28 +17,29 @@
  * along with this program.  If not, see <http://www.gnu.org/licenses/>.
  */
 
-if (!defined('STATUSNET') && !defined('LACONICA')) { exit(1); }
+if (!defined('GNUSOCIAL')) { exit(1); }
 
 // @todo FIXME: documentation missing.
-class TagAction extends Action
+class TagAction extends ManagedAction
 {
     var $notice;
+    var $tag;
+    var $page;
 
-    function prepare($args)
+    protected function prepare(array $args=array())
     {
         parent::prepare($args);
+
         $taginput = $this->trimmed('tag');
         $this->tag = common_canonical_tag($taginput);
 
-        if (!$this->tag) {
+        if (empty($this->tag)) {
             common_redirect(common_local_url('publictagcloud'), 301);
-            return false;
         }
 
-        if ($this->tag != $taginput) {
-            common_redirect(common_local_url('tag', array('tag' => $this->tag)),
-                            301);
-            return false;
+        // after common_canonical_tag we have a lowercase, no-specials tag string
+        if ($this->tag !== $taginput) {
+            common_redirect(common_local_url('tag', array('tag' => $this->tag)), 301);
         }
 
         $this->page = ($this->arg('page')) ? ($this->arg('page')+0) : 1;
@@ -48,8 +49,8 @@ class TagAction extends Action
         $this->notice = Notice_tag::getStream($this->tag, (($this->page-1)*NOTICES_PER_PAGE), NOTICES_PER_PAGE + 1);
 
         if($this->page > 1 && $this->notice->N == 0){
-            // TRANS: Server error when page not found (404).
-            $this->serverError(_('No such page.'),$code=404);
+            // TRANS: Client error when page not found (404).
+            $this->clientError(_('No such page.'), 404);
         }
 
         return true;
@@ -70,13 +71,6 @@ class TagAction extends Action
         }
     }
 
-    function handle($args)
-    {
-        parent::handle($args);
-
-        $this->showPage();
-    }
-
     function getFeeds()
     {
         return array(new Feed(Feed::JSON,
@@ -112,11 +106,11 @@ class TagAction extends Action
                                       $this->tag)));
     }
 
-    function showContent()
+    protected function showContent()
     {
         if(Event::handle('StartTagShowContent', array($this))) {
 
-            $nl = new NoticeList($this->notice, $this);
+            $nl = new PrimaryNoticeList($this->notice, $this, array('show_n'=>NOTICES_PER_PAGE));
 
             $cnt = $nl->show();
 
@@ -127,7 +121,7 @@ class TagAction extends Action
         }
     }
 
-    function isReadOnly($args)
+    function isReadOnly(array $args=array())
     {
         return true;
     }