}
// 'update' won't write key columns, so we have to do it ourselves.
- public function updateKeys(&$orig)
+ // This also automatically calls "update" _before_ it sets the keys.
+ // FIXME: This only works with single-column primary keys so far! Beware!
+ /**
+ * @param DB_DataObject &$orig Must be "instanceof" $this
+ * @param string $pid Primary ID column (no escaping is done on column name!)
+ */
+ public function updateWithKeys(&$orig, $pid='id')
{
if (!$orig instanceof $this) {
throw new ServerException('Tried updating a DataObject with a different class than itself.');
}
- $this->_connect();
+ // do it in a transaction
+ $this->query('BEGIN');
+
$parts = array();
foreach ($this->keys() as $k) {
if (strcmp($this->$k, $orig->$k) != 0) {
}
}
if (count($parts) == 0) {
- // No changes
+ // No changes to keys, it's safe to run ->update(...)
+ if ($this->update($orig) === false) {
+ common_log_db_error($this, 'UPDATE', __FILE__);
+ // rollback as something bad occurred
+ $this->query('ROLLBACK');
+ throw new ServerException("Could not UPDATE non-keys for {$this->__table}");
+ }
+ $orig->decache();
+ $this->encache();
+
+ // commit our db transaction since we won't reach the COMMIT below
+ $this->query('COMMIT');
+ // @FIXME return true only if something changed (otherwise 0)
return true;
}
- $toupdate = implode(', ', $parts);
- $table = common_database_tablename($this->tableName());
- $qry = 'UPDATE ' . $table . ' SET ' . $toupdate .
- ' WHERE id = ' . $this->getID();
- $orig->decache();
+ $qry = sprintf('UPDATE %1$s SET %2$s WHERE %3$s = %4$s',
+ common_database_tablename($this->tableName()),
+ implode(', ', $parts),
+ $pid,
+ $this->_quote($this->$pid));
+
$result = $this->query($qry);
- if ($result !== false) {
- $this->encache();
+ if ($result === false) {
+ common_log_db_error($this, 'UPDATE', __FILE__);
+ // rollback as something bad occurred
+ $this->query('ROLLBACK');
+ throw new ServerException("Could not UPDATE key fields for {$this->__table}");
+ }
+
+ // Update non-keys too, if the previous endeavour worked.
+ // The ->update call uses "$this" values for keys, that's why we can't do this until
+ // the keys are updated (because they might differ from $orig and update the wrong entries).
+ if ($this->update($orig) === false) {
+ common_log_db_error($this, 'UPDATE', __FILE__);
+ // rollback as something bad occurred
+ $this->query('ROLLBACK');
+ throw new ServerException("Could not UPDATE non-keys for {$this->__table}");
}
+ $orig->decache();
+ $this->encache();
+
+ // commit our db transaction
+ $this->query('COMMIT');
+ // @FIXME return true only if something changed (otherwise 0)
return $result;
}
}