]> git.mxchange.org Git - quix0rs-gnu-social.git/blobdiff - classes/Notice.php
[OStatus] Wrong exception was being caught
[quix0rs-gnu-social.git] / classes / Notice.php
index a7effe4d5b6ec957a2b3154ff3db694e429351cb..b70dd97dc36f7bf8b05521607e9addc899496f17 100644 (file)
@@ -88,7 +88,7 @@ class Notice extends Managed_DataObject
                 'reply_to' => array('type' => 'int', 'description' => 'notice replied to (usually a guess)'),
                 'is_local' => array('type' => 'int', 'size' => 'tiny', 'default' => 0, 'description' => 'notice was generated by a user'),
                 'source' => array('type' => 'varchar', 'length' => 32, 'description' => 'source of comment, like "web", "im", or "clientname"'),
-                'conversation' => array('type' => 'int', 'description' => 'id of root notice in this conversation'),
+                'conversation' => array('type' => 'int', 'description' => 'the local numerical conversation id'),
                 'repeat_of' => array('type' => 'int', 'description' => 'notice this is a repeat of'),
                 'object_type' => array('type' => 'varchar', 'length' => 191, 'description' => 'URI representing activity streams object type', 'default' => null),
                 'verb' => array('type' => 'varchar', 'length' => 191, 'description' => 'URI representing activity streams verb', 'default' => 'http://activitystrea.ms/schema/1.0/post'),
@@ -110,7 +110,10 @@ class Notice extends Managed_DataObject
                 'notice_profile_id_idx' => array('profile_id', 'created', 'id'),
                 'notice_repeat_of_created_id_idx' => array('repeat_of', 'created', 'id'),
                 'notice_conversation_created_id_idx' => array('conversation', 'created', 'id'),
+                'notice_object_type_idx' => array('object_type'),
                 'notice_verb_idx' => array('verb'),
+                'notice_profile_id_verb_idx' => array('profile_id', 'verb'),
+                'notice_url_idx' => array('url'),   // Qvitter wants this
                 'notice_replyto_idx' => array('reply_to')
             )
         );
@@ -165,6 +168,18 @@ class Notice extends Managed_DataObject
             throw new AuthorizationException(_('You are not allowed to delete another user\'s notice.'));
         }
 
+        $result = null;
+        if (!$delete_event || Event::handle('DeleteNoticeAsProfile', array($this, $actor, &$result))) {
+            // If $delete_event is true, we run the event. If the Event then 
+            // returns false it is assumed everything was handled properly 
+            // and the notice was deleted.
+            $result = $this->delete();
+        }
+        return $result;
+    }
+
+    protected function deleteRelated()
+    {
         if (Event::handle('NoticeDeleteRelated', array($this))) {
             // Clear related records
             $this->clearReplies();
@@ -176,19 +191,12 @@ class Notice extends Managed_DataObject
             $this->clearAttentions();
             // NOTE: we don't clear queue items
         }
-
-        $result = null;
-        if (!$delete_event || Event::handle('DeleteNoticeAsProfile', array($this, $actor, &$result))) {
-            // If $delete_event is true, we run the event. If the Event then 
-            // returns false it is assumed everything was handled properly 
-            // and the notice was deleted.
-            $result = $this->delete();
-        }
-        return $result;
     }
 
     public function delete($useWhere=false)
     {
+        $this->deleteRelated();
+
         $result = parent::delete($useWhere);
 
         $this->blowOnDelete();
@@ -240,10 +248,10 @@ class Notice extends Managed_DataObject
         return common_local_url('shownotice', array('notice' => $this->id), null, null, false);
     }
 
-    public function getTitle()
+    public function getTitle($imply=true)
     {
         $title = null;
-        if (Event::handle('GetNoticeTitle', array($this, &$title))) {
+        if (Event::handle('GetNoticeTitle', array($this, &$title)) && $imply) {
             // TRANS: Title of a notice posted without a title value.
             // TRANS: %1$s is a user name, %2$s is the notice creation date/time.
             $title = sprintf(_('%1$s\'s status on %2$s'),
@@ -308,11 +316,25 @@ class Notice extends Managed_DataObject
             // let's generate a valid link to our locally available notice on demand
             return common_local_url('shownotice', array('notice' => $this->getID()), null, null, false);
         default:
-            common_debug('No URL available for notice: id='.$this->getID());
             throw new InvalidUrlException($this->url);
         }
     }
 
+    public function getSelfLink()
+    {
+        if ($this->isLocal()) {
+            return common_local_url('ApiStatusesShow', array('id' => $this->getID(), 'format' => 'atom'));
+        }
+
+        $selfLink = $this->getPref('ostatus', 'self');
+
+        if (!common_valid_http_url($selfLink)) {
+            throw new InvalidUrlException($selfLink);
+        }
+
+        return $selfLink;
+    }
+
     public function getObjectType($canonical=false) {
         if (is_null($this->object_type) || $this->object_type==='') {
             throw new NoObjectTypeException($this);
@@ -329,16 +351,6 @@ class Notice extends Managed_DataObject
         }
     }
 
-    public static function getByUri($uri)
-    {
-        $notice = new Notice();
-        $notice->uri = $uri;
-        if (!$notice->find(true)) {
-            throw new NoResultException($notice);
-        }
-        return $notice;
-    }
-
     /**
      * Extract #hashtags from this notice's content and save them to the database.
      */
@@ -445,6 +457,7 @@ class Notice extends Managed_DataObject
     static function saveNew($profile_id, $content, $source, array $options=null) {
         $defaults = array('uri' => null,
                           'url' => null,
+                          'self' => null,
                           'conversation' => null,   // URI of conversation
                           'reply_to' => null,       // This will override convo URI if the parent is known
                           'repeat_of' => null,      // This will override convo URI if the repeated notice is known
@@ -507,12 +520,7 @@ class Notice extends Managed_DataObject
         $notice = new Notice();
         $notice->profile_id = $profile_id;
 
-        $autosource = common_config('public', 'autosource');
-
-        // Sandboxed are non-false, but not 1, either
-
-        if (!$profile->hasRight(Right::PUBLICNOTICE) ||
-            ($source && $autosource && in_array($source, $autosource))) {
+        if ($source && in_array($source, common_config('public', 'autosource'))) {
             $notice->is_local = Notice::LOCAL_NONPUBLIC;
         } else {
             $notice->is_local = $is_local;
@@ -526,9 +534,6 @@ class Notice extends Managed_DataObject
 
         if (!$notice->isLocal()) {
             // Only do these checks for non-local notices. Local notices will generate these values later.
-            if (!common_valid_http_url($url)) {
-                common_debug('Bad notice URL: ['.$url.'], URI: ['.$uri.']. Cannot link back to original! This is normal for shared notices etc.');
-            }
             if (empty($uri)) {
                 throw new ServerException('No URI for remote notice. Cannot accept that.');
             }
@@ -635,8 +640,13 @@ class Notice extends Managed_DataObject
                 } else {
                     // Conversation entry with specified URI was not found, so we must create it.
                     common_debug('Conversation URI not found, so we will create it with the URI given in the options to Notice::saveNew: '.$options['conversation']);
+                    $convctx = new ActivityContext();
+                    $convctx->conversation = $options['conversation'];
+                    if (array_key_exists('conversation_url', $options)) {
+                        $convctx->conversation_url = $options['conversation_url'];
+                    }
                     // The insert in Conversation::create throws exception on failure
-                    $conv = Conversation::create($options['conversation'], $notice->created);
+                    $conv = Conversation::create($convctx, $notice->created);
                 }
                 $notice->conversation = $conv->getID();
                 unset($conv);
@@ -717,6 +727,10 @@ class Notice extends Managed_DataObject
             }
         }
 
+        if ($self && common_valid_http_url($self)) {
+            $notice->setPref('ostatus', 'self', $self);
+        }
+
         // Only save 'attention' and metadata stuff (URLs, tags...) stuff if
         // the activityverb is a POST (since stuff like repeat, favorite etc.
         // reasonably handle notifications themselves.
@@ -776,6 +790,9 @@ class Notice extends Managed_DataObject
             // implied object
             $options['uri'] = $act->id;
             $options['url'] = $act->link;
+            if ($act->selfLink) {
+                $options['self'] = $act->selfLink;
+            }
         } else {
             $actobj = count($act->objects)===1 ? $act->objects[0] : null;
             if (!is_null($actobj) && !empty($actobj->id)) {
@@ -786,6 +803,9 @@ class Notice extends Managed_DataObject
                     $options['url'] = $actobj->id;
                 }
             }
+            if ($actobj->selfLink) {
+                $options['self'] = $actobj->selfLink;
+            }
         }
 
         $defaults = array(
@@ -795,6 +815,7 @@ class Notice extends Managed_DataObject
                           'reply_to' => null,
                           'repeat_of' => null,
                           'scope' => null,
+                          'self' => null,
                           'source' => 'unknown',
                           'tags' => array(),
                           'uri' => null,
@@ -822,12 +843,12 @@ class Notice extends Managed_DataObject
             }
         }
 
-        $autosource = common_config('public', 'autosource');
+        // NOTE: Sandboxed users previously got all the notices _during_
+        // sandbox period set to to is_local=Notice::LOCAL_NONPUBLIC here.
+        // Since then we have started just filtering _when_ it gets shown
+        // instead of creating a mixed jumble of differently scoped notices.
 
-        // Sandboxed are non-false, but not 1, either
-        if (!$actor->hasRight(Right::PUBLICNOTICE) ||
-                ($source && $autosource && in_array($source, $autosource))) {
-            // FIXME: ...what about remote nonpublic? Hmmm. That is, if we sandbox remote profiles...
+        if ($source && in_array($source, common_config('public', 'autosource'))) {
             $stored->is_local = Notice::LOCAL_NONPUBLIC;
         } else {
             $stored->is_local = intval($is_local);
@@ -843,23 +864,25 @@ class Notice extends Managed_DataObject
             }
         }
 
-        $stored->profile_id = $actor->id;
+        $stored->profile_id = $actor->getID();
         $stored->source = $source;
         $stored->uri = $uri;
         $stored->url = $url;
         $stored->verb = $act->verb;
 
-        $content = $act->content ?: $act->summary;
-        if (is_null($content) && !is_null($actobj)) {
-            $content = $actobj->content ?: $actobj->summary;
+        // we use mb_strlen because it _might_ be that the content is just the string "0"...
+        $content = mb_strlen($act->content) ? $act->content : $act->summary;
+        if (mb_strlen($content)===0 && !is_null($actobj)) {
+            $content = mb_strlen($actobj->content) ? $actobj->content : $actobj->summary;
         }
-        // Strip out any bad HTML
-        $stored->rendered = common_purify($content);
+        // Strip out any bad HTML from $content. URI.Base is used to sort out relative URLs.
+        $stored->rendered = common_purify($content, ['URI.Base' => $stored->url ?: null]);
         $stored->content  = common_strip_html($stored->getRendered(), true, true);
         if (trim($stored->content) === '') {
             // TRANS: Error message when the plain text content of a notice has zero length.
             throw new ClientException(_('Empty notice content, will not save this.'));
         }
+        unset($content);    // garbage collect
 
         // Maybe a missing act-time should be fatal if the actor is not local?
         if (!empty($act->time)) {
@@ -868,13 +891,31 @@ class Notice extends Managed_DataObject
             $stored->created = common_sql_now();
         }
 
-        $reply = null;
+        $reply = null;  // this will store the in-reply-to Notice if found
+        $replyUris = [];    // this keeps a list of possible URIs to look up
         if ($act->context instanceof ActivityContext && !empty($act->context->replyToID)) {
-            $reply = self::getKV('uri', $act->context->replyToID);
+            $replyUris[] = $act->context->replyToID;
+        }
+        if ($act->target instanceof ActivityObject && !empty($act->target->id)) {
+            $replyUris[] = $act->target->id;
         }
-        if (!$reply instanceof Notice && $act->target instanceof ActivityObject) {
-            $reply = self::getKV('uri', $act->target->id);
+        foreach (array_unique($replyUris) as $replyUri) {
+            $reply = self::getKV('uri', $replyUri);
+            // Only do remote fetching if we're not a private site
+            if (!common_config('site', 'private') && !$reply instanceof Notice) {
+                // the URI is the object we're looking for, $actor is a
+                // Profile that surely knows of it and &$reply where it
+                // will be stored when fetched
+                Event::handle('FetchRemoteNotice', array($replyUri, $actor, &$reply));
+            }
+            // we got what we're in-reply-to now, so let's move on
+            if ($reply instanceof Notice) {
+                break;
+            }
+            // otherwise reset whatever we might've gotten from the event
+            $reply = null;
         }
+        unset($replyUris);  // garbage collect
 
         if ($reply instanceof Notice) {
             if (!$reply->inScope($actor)) {
@@ -912,12 +953,13 @@ class Notice extends Managed_DataObject
                     // Conversation entry with specified URI was not found, so we must create it.
                     common_debug('Conversation URI not found, so we will create it with the URI given in the context of the activity: '.$act->context->conversation);
                     // The insert in Conversation::create throws exception on failure
-                    $conv = Conversation::create($act->context->conversation, $stored->created);
+                    $conv = Conversation::create($act->context, $stored->created);
                 }
                 $stored->conversation = $conv->getID();
                 unset($conv);
             }
         }
+        unset($reply);  // garbage collect
 
         // If it's not part of a conversation, it's the beginning of a new conversation.
         if (empty($stored->conversation)) {
@@ -935,7 +977,13 @@ class Notice extends Managed_DataObject
             $act->context = new ActivityContext();
         }
 
-        $stored->scope = self::figureOutScope($actor, $groups, $scope);
+        if (array_key_exists(ActivityContext::ATTN_PUBLIC, $act->context->attention)) {
+            $stored->scope = Notice::PUBLIC_SCOPE;
+            // TODO: maybe we should actually keep this? if the saveAttentions thing wants to use it...
+            unset($act->context->attention[ActivityContext::ATTN_PUBLIC]);
+        } else {
+            $stored->scope = self::figureOutScope($actor, $groups, $scope);
+        }
 
         foreach ($act->categories as $cat) {
             if ($cat->term) {
@@ -982,6 +1030,7 @@ class Notice extends Managed_DataObject
                 if (empty($object)) {
                     throw new NoticeSaveException('Unsuccessful call to StoreActivityObject '._ve($stored->getUri()) . ': '._ve($act->asString()));
                 }
+                unset($object);
 
                 // If something changed in the Notice during StoreActivityObject
                 $stored->update($orig);
@@ -995,8 +1044,20 @@ class Notice extends Managed_DataObject
                 throw $e;
             }
         }
+        unset($notloc); // garbage collect
+
         if (!$stored instanceof Notice) {
-            throw new ServerException('StartNoticeSave did not give back a Notice');
+            throw new ServerException('StartNoticeSave did not give back a Notice.');
+        } elseif (empty($stored->id)) {
+            throw new ServerException('Supposedly saved Notice has no ID.');
+        }
+
+        if ($self && common_valid_http_url($self)) {
+            $stored->setPref('ostatus', 'self', $self);
+        }
+
+        if ($self && common_valid_http_url($self)) {
+            $stored->setPref('ostatus', 'self', $self);
         }
 
         // Only save 'attention' and metadata stuff (URLs, tags...) stuff if
@@ -1261,14 +1322,12 @@ class Notice extends Managed_DataObject
             $ids[] = $f2p->file_id;
         }
 
-               $files = File::multiGet('id', $ids);
-               $this->_attachments[$this->id] = $files->fetchAll();
-        return $this->_attachments[$this->id];
+        return $this->_setAttachments(File::multiGet('id', $ids)->fetchAll());
     }
 
-       function _setAttachments($attachments)
+       public function _setAttachments(array $attachments)
        {
-           $this->_attachments[$this->id] = $attachments;
+           return $this->_attachments[$this->id] = $attachments;
        }
 
     static function publicStream($offset=0, $limit=20, $since_id=null, $max_id=null)
@@ -1277,9 +1336,9 @@ class Notice extends Managed_DataObject
         return $stream->getNotices($offset, $limit, $since_id, $max_id);
     }
 
-    static function conversationStream($id, $offset=0, $limit=20, $since_id=null, $max_id=null)
+    static function conversationStream($id, $offset=0, $limit=20, $since_id=null, $max_id=null, Profile $scoped=null)
     {
-        $stream = new ConversationNoticeStream($id);
+        $stream = new ConversationNoticeStream($id, $scoped);
         return $stream->getNotices($offset, $limit, $since_id, $max_id);
     }
 
@@ -1297,8 +1356,9 @@ class Notice extends Managed_DataObject
             return false;
         }
 
-        $stream = new ConversationNoticeStream($this->conversation);
-        $notice = $stream->getNotices(/*offset*/ 1, /*limit*/ 1);
+        //FIXME: Get the Profile::current() stuff some other way
+        // to avoid confusion between queue processing and session.
+        $notice = self::conversationStream($this->conversation, 1, 1, null, null, Profile::current());
 
         // if our "offset 1, limit 1" query got a result, return true else false
         return $notice->N > 0;
@@ -1507,12 +1567,16 @@ class Notice extends Managed_DataObject
 
     function getProfileTags()
     {
-        $profile = $this->getProfile();
-        $list    = $profile->getOtherTags($profile);
         $ptags   = array();
+        try {
+            $profile = $this->getProfile();
+            $list    = $profile->getOtherTags($profile);
 
-        while($list->fetch()) {
-            $ptags[] = clone($list);
+            while($list->fetch()) {
+                $ptags[] = clone($list);
+            }
+        } catch (Exception $e) {
+            common_log(LOG_ERR, "Error during Notice->getProfileTags() for id=={$this->getID()}: {$e->getMessage()}");
         }
 
         return $ptags;
@@ -1554,12 +1618,12 @@ class Notice extends Managed_DataObject
 
                 if (common_config('group', 'addtag')) {
                     // we automatically add a tag for every group name, too
-
-                    $tag = Notice_tag::pkeyGet(array('tag' => common_canonical_tag($group->nickname),
-                                                     'notice_id' => $this->id));
+                    common_debug('Adding hashtag matching group nickname: '._ve($group->getNickname()));
+                    $tag = Notice_tag::pkeyGet(array('tag' => common_canonical_tag($group->getNickname()),
+                                                     'notice_id' => $this->getID()));
 
                     if (is_null($tag)) {
-                        $this->saveTag($group->nickname);
+                        $this->saveTag($group->getNickname());
                     }
                 }
 
@@ -1643,8 +1707,6 @@ class Notice extends Managed_DataObject
         }
 
         $att = Attention::saveNew($this, $target, $reason);
-
-        self::blow('reply:stream:%d', $target->getID());
         return true;
     }
 
@@ -1832,7 +1894,7 @@ class Notice extends Managed_DataObject
             foreach ($recipientIds as $recipientId) {
                 try {
                     $user = User::getByID($recipientId);
-                    mail_notify_attn($user, $this);
+                    mail_notify_attn($user->getProfile(), $this);
                 } catch (NoResultException $e) {
                     // No such user
                 }
@@ -1900,9 +1962,11 @@ class Notice extends Managed_DataObject
     /**
      * Convert a notice into an activity for export.
      *
-     * @param Profile $scoped   The currently logged in/scoped profile
+     * @param Profile $scoped The currently logged in/scoped profile
      *
      * @return Activity activity object representing this Notice.
+     * @throws ClientException
+     * @throws ServerException
      */
 
     function asActivity(Profile $scoped=null)
@@ -1986,6 +2050,7 @@ class Notice extends Managed_DataObject
                 $conv = Conversation::getKV('id', $this->conversation);
                 if ($conv instanceof Conversation) {
                     $ctx->conversation = $conv->uri;
+                    $ctx->conversation_url = $conv->url;
                 }
             }
 
@@ -2048,9 +2113,12 @@ class Notice extends Managed_DataObject
                 }
             }
 
+            try {
+                $act->selfLink = $this->getSelfLink();
+            } catch (InvalidUrlException $e) {
+                $act->selfLink = null;
+            }
             if ($this->isLocal()) {
-                $act->selfLink = common_local_url('ApiStatusesShow', array('id' => $this->id,
-                                                                           'format' => 'atom'));
                 $act->editLink = $act->selfLink;
             }
 
@@ -2148,8 +2216,13 @@ class Notice extends Managed_DataObject
             $object->title   = sprintf('New %1$s by %2$s', ActivityObject::canonicalType($object->type), $this->getProfile()->getNickname());
             $object->content = $this->getRendered();
             $object->link    = $this->getUrl();
+            try {
+                $object->selfLink = $this->getSelfLink();
+            } catch (InvalidUrlException $e) {
+                $object->selfLink = null;
+            }
 
-            $object->extra[] = array('status_net', array('notice_id' => $this->id));
+            $object->extra[] = array('statusnet:notice_id', null, $this->id);
 
             Event::handle('EndActivityObjectFromNotice', array($this, &$object));
         }
@@ -2601,6 +2674,13 @@ class Notice extends Managed_DataObject
         return !empty($this->repeat_of);
     }
 
+    public function isRepeated()
+    {
+        $n = new Notice();
+        $n->repeat_of = $this->getID();
+        return $n->find() && $n->N > 0;
+    }
+
     /**
      * Get the list of hash tags saved with this notice.
      *
@@ -2647,7 +2727,7 @@ class Notice extends Managed_DataObject
     public static function getAsTimestamp($id)
     {
         if (empty($id)) {
-            throw new EmptyIdException('Notice');
+            throw new EmptyPkeyValueException('Notice', 'id');
         }
 
         $timestamp = null;
@@ -2743,10 +2823,10 @@ class Notice extends Managed_DataObject
         }
     }
 
-    function isPublic()
+    public function isPublic()
     {
-        return (($this->is_local != Notice::LOCAL_NONPUBLIC) &&
-                ($this->is_local != Notice::GATEWAY));
+        $is_local = intval($this->is_local);
+        return !($is_local === Notice::LOCAL_NONPUBLIC || $is_local === Notice::GATEWAY);
     }
 
     /**
@@ -3016,6 +3096,19 @@ class Notice extends Managed_DataObject
                        $files = array();
                        $f2ps = $f2pMap[$notice->id];
                        foreach ($f2ps as $f2p) {
+                if (!isset($fileMap[$f2p->file_id])) {
+                    // We have probably deleted value from fileMap since
+                    // it as a NULL entry (see the following elseif).
+                    continue;
+                } elseif (is_null($fileMap[$f2p->file_id])) {
+                    // If the file id lookup returned a NULL value, it doesn't
+                    // exist in our file table! So this is a remnant file_to_post
+                    // entry that is no longer valid and should be removed.
+                    common_debug('ATTACHMENT deleting f2p for post_id='.$f2p->post_id.' file_id='.$f2p->file_id);
+                    $f2p->delete();
+                    unset($fileMap[$f2p->file_id]);
+                    continue;
+                }
                            $files[] = $fileMap[$f2p->file_id];
                        }
                    $notice->_setAttachments($files);
@@ -3044,42 +3137,136 @@ class Notice extends Managed_DataObject
 
         // 2015-09-04 We move Notice location data to Notice_location
         // First we see if we have to do this at all
-        if (!isset($schemadef['fields']['lat'])
-                && !isset($schemadef['fields']['lon'])
-                && !isset($schemadef['fields']['location_id'])
-                && !isset($schemadef['fields']['location_ns'])) {
-            // We have already removed the location fields, so no need to migrate.
-            return;
+        if (isset($schemadef['fields']['lat'])
+                && isset($schemadef['fields']['lon'])
+                && isset($schemadef['fields']['location_id'])
+                && isset($schemadef['fields']['location_ns'])) {
+            // Then we make sure the Notice_location table is created!
+            $schema->ensureTable('notice_location', Notice_location::schemaDef());
+
+            // Then we continue on our road to migration!
+            echo "\nFound old $table table, moving location data to 'notice_location' table... (this will probably take a LONG time, but can be aborted and continued)";
+
+            $notice = new Notice();
+            $notice->query(sprintf('SELECT id, lat, lon, location_id, location_ns FROM %1$s ' .
+                                 'WHERE lat IS NOT NULL ' .
+                                    'OR lon IS NOT NULL ' .
+                                    'OR location_id IS NOT NULL ' .
+                                    'OR location_ns IS NOT NULL',
+                                 $schema->quoteIdentifier($table)));
+            print "\nFound {$notice->N} notices with location data, inserting";
+            while ($notice->fetch()) {
+                $notloc = Notice_location::getKV('notice_id', $notice->id);
+                if ($notloc instanceof Notice_location) {
+                    print "-";
+                    continue;
+                }
+                $notloc = new Notice_location();
+                $notloc->notice_id = $notice->id;
+                $notloc->lat= $notice->lat;
+                $notloc->lon= $notice->lon;
+                $notloc->location_id= $notice->location_id;
+                $notloc->location_ns= $notice->location_ns;
+                $notloc->insert();
+                print ".";
+            }
+            print "\n";
+        }
+
+        /**
+         *  Make sure constraints are met before upgrading, if foreign keys
+         *  are not already in use.
+         *  2016-03-31
+         */
+        if (!isset($schemadef['foreign keys'])) {
+            $newschemadef = self::schemaDef();
+            printfnq("\nConstraint checking Notice table...\n");
+            /**
+             *  Improve typing and make sure no NULL values in any id-related columns are 0
+             *  2016-03-31
+             */
+            foreach (['reply_to', 'repeat_of'] as $field) {
+                $notice = new Notice(); // reset the object
+                $notice->query(sprintf('UPDATE %1$s SET %2$s=NULL WHERE %2$s=0', $notice->escapedTableName(), $field));
+                // Now we're sure that no Notice entries have repeat_of=0, only an id > 0 or NULL
+                unset($notice);
+            }
+
+            /**
+             *  This Will find foreign keys which do not fulfill the constraints and fix
+             *  where appropriate, such as delete when "repeat_of" ID not found in notice.id
+             *  or set to NULL for "reply_to" in the same case.
+             *  2016-03-31
+             *
+             *  XXX: How does this work if we would use multicolumn foreign keys?
+             */
+            foreach (['reply_to' => 'reset', 'repeat_of' => 'delete', 'profile_id' => 'delete'] as $field=>$action) {
+                $notice = new Notice();
+
+                $fkeyname = $notice->tableName().'_'.$field.'_fkey';
+                assert(isset($newschemadef['foreign keys'][$fkeyname]));
+                assert($newschemadef['foreign keys'][$fkeyname]);
+
+                $foreign_key = $newschemadef['foreign keys'][$fkeyname];
+                $fkeytable = $foreign_key[0];
+                assert(isset($foreign_key[1][$field]));
+                $fkeycol   = $foreign_key[1][$field];
+
+                printfnq("* {$fkeyname} ({$field} => {$fkeytable}.{$fkeycol})\n");
+
+                // NOTE: Above we set all repeat_of to NULL if they were 0, so this really gets them all.
+                $notice->whereAdd(sprintf('%1$s NOT IN (SELECT %2$s FROM %3$s)', $field, $fkeycol, $fkeytable));
+                if ($notice->find()) {
+                    printfnq("\tFound {$notice->N} notices with {$field} NOT IN notice.id, {$action}ing...");
+                    switch ($action) {
+                    case 'delete':  // since it's a directly dependant notice for an unknown ID we don't want it in our DB
+                        while ($notice->fetch()) {
+                            $notice->delete();
+                        }
+                        break;
+                    case 'reset':   // just set it to NULL to be compatible with our constraints, if it was related to an unknown ID
+                        $ids = [];
+                        foreach ($notice->fetchAll('id') as $id) {
+                            settype($id, 'int');
+                            $ids[] = $id;
+                        }
+                        unset($notice);
+                        $notice = new Notice();
+                        $notice->query(sprintf('UPDATE %1$s SET %2$s=NULL WHERE id IN (%3$s)',
+                                            $notice->escapedTableName(),
+                                            $field,
+                                            implode(',', $ids)));
+                        break;
+                    default:
+                        throw new ServerException('The programmer sucks, invalid action name when fixing table.');
+                    }
+                    printfnq("DONE.\n");
+                }
+                unset($notice);
+            }
         }
-        // Then we make sure the Notice_location table is created!
-        $schema->ensureTable('notice_location', Notice_location::schemaDef());
+    }
 
-        // Then we continue on our road to migration!
-        echo "\nFound old $table table, moving location data to 'notice_location' table... (this will probably take a LONG time, but can be aborted and continued)";
+    public function delPref($namespace, $topic) {
+        return Notice_prefs::setData($this, $namespace, $topic, null);
+    }
 
-        $notice = new Notice();
-        $notice->query(sprintf('SELECT id, lat, lon, location_id, location_ns FROM %1$s ' .
-                             'WHERE lat IS NOT NULL ' .
-                                'OR lon IS NOT NULL ' .
-                                'OR location_id IS NOT NULL ' .
-                                'OR location_ns IS NOT NULL',
-                             $schema->quoteIdentifier($table)));
-        print "\nFound {$notice->N} notices with location data, inserting";
-        while ($notice->fetch()) {
-            $notloc = Notice_location::getKV('notice_id', $notice->id);
-            if ($notloc instanceof Notice_location) {
-                print "-";
-                continue;
-            }
-            $notloc = new Notice_location();
-            $notloc->notice_id = $notice->id;
-            $notloc->lat= $notice->lat;
-            $notloc->lon= $notice->lon;
-            $notloc->location_id= $notice->location_id;
-            $notloc->location_ns= $notice->location_ns;
-            $notloc->insert();
-            print ".";
+    public function getPref($namespace, $topic, $default=null) {
+        // If you want an exception to be thrown, call Notice_prefs::getData directly
+        try {
+            return Notice_prefs::getData($this, $namespace, $topic, $default);
+        } catch (NoResultException $e) {
+            return null;
         }
-        print "\n";
+    }
+
+    // The same as getPref but will fall back to common_config value for the same namespace/topic
+    public function getConfigPref($namespace, $topic)
+    {
+        return Notice_prefs::getConfigData($this, $namespace, $topic);
+    }
+
+    public function setPref($namespace, $topic, $data) {
+        return Notice_prefs::setData($this, $namespace, $topic, $data);
     }
 }