]> git.mxchange.org Git - quix0rs-gnu-social.git/blobdiff - classes/Notice.php
We have to create and populate the Notice_location table before constraint checking...
[quix0rs-gnu-social.git] / classes / Notice.php
index 81c3df63360d3a061d08433a3407e84c084af8e3..b828678d87c92f338ee3538404a900f9b2324f39 100644 (file)
@@ -248,10 +248,10 @@ class Notice extends Managed_DataObject
         return common_local_url('shownotice', array('notice' => $this->id), null, null, false);
     }
 
-    public function getTitle()
+    public function getTitle($imply=true)
     {
         $title = null;
-        if (Event::handle('GetNoticeTitle', array($this, &$title))) {
+        if (Event::handle('GetNoticeTitle', array($this, &$title)) && $imply) {
             // TRANS: Title of a notice posted without a title value.
             // TRANS: %1$s is a user name, %2$s is the notice creation date/time.
             $title = sprintf(_('%1$s\'s status on %2$s'),
@@ -336,16 +336,6 @@ class Notice extends Managed_DataObject
         }
     }
 
-    public static function getByUri($uri)
-    {
-        $notice = new Notice();
-        $notice->uri = $uri;
-        if (!$notice->find(true)) {
-            throw new NoResultException($notice);
-        }
-        return $notice;
-    }
-
     /**
      * Extract #hashtags from this notice's content and save them to the database.
      */
@@ -955,10 +945,10 @@ class Notice extends Managed_DataObject
             $act->context = new ActivityContext();
         }
 
-        if (array_key_exists('http://activityschema.org/collection/public', $act->context->attention)) {
+        if (array_key_exists(ActivityContext::ATTN_PUBLIC, $act->context->attention)) {
             $stored->scope = Notice::PUBLIC_SCOPE;
             // TODO: maybe we should actually keep this? if the saveAttentions thing wants to use it...
-            unset($act->context->attention['http://activityschema.org/collection/public']);
+            unset($act->context->attention[ActivityContext::ATTN_PUBLIC]);
         } else {
             $stored->scope = self::figureOutScope($actor, $groups, $scope);
         }
@@ -1537,12 +1527,16 @@ class Notice extends Managed_DataObject
 
     function getProfileTags()
     {
-        $profile = $this->getProfile();
-        $list    = $profile->getOtherTags($profile);
         $ptags   = array();
+        try {
+            $profile = $this->getProfile();
+            $list    = $profile->getOtherTags($profile);
 
-        while($list->fetch()) {
-            $ptags[] = clone($list);
+            while($list->fetch()) {
+                $ptags[] = clone($list);
+            }
+        } catch (Exception $e) {
+            common_log(LOG_ERR, "Error during Notice->getProfileTags() for id=={$this->getID()}: {$e->getMessage()}");
         }
 
         return $ptags;
@@ -2679,7 +2673,7 @@ class Notice extends Managed_DataObject
     public static function getAsTimestamp($id)
     {
         if (empty($id)) {
-            throw new EmptyIdException('Notice');
+            throw new EmptyPkeyValueException('Notice', 'id');
         }
 
         $timestamp = null;
@@ -3087,108 +3081,115 @@ class Notice extends Managed_DataObject
         $schema = Schema::get();
         $schemadef = $schema->getTableDef($table);
 
-        printfnq("\nConstraint checking Notice table...\n");
-        /**
-         *  Improve typing and make sure no NULL values in any id-related columns are 0
-         *  2016-03-31
-         */
-        foreach (['reply_to', 'repeat_of'] as $field) {
-            $notice = new Notice(); // reset the object
-            $notice->query(sprintf('UPDATE %1$s SET %2$s=NULL WHERE %2$s=0', $notice->escapedTableName(), $field));
-            // Now we're sure that no Notice entries have repeat_of=0, only an id > 0 or NULL
-            unset($notice);
+        // 2015-09-04 We move Notice location data to Notice_location
+        // First we see if we have to do this at all
+        if (isset($schemadef['fields']['lat'])
+                && isset($schemadef['fields']['lon'])
+                && isset($schemadef['fields']['location_id'])
+                && isset($schemadef['fields']['location_ns'])) {
+            // Then we make sure the Notice_location table is created!
+            $schema->ensureTable('notice_location', Notice_location::schemaDef());
+
+            // Then we continue on our road to migration!
+            echo "\nFound old $table table, moving location data to 'notice_location' table... (this will probably take a LONG time, but can be aborted and continued)";
+
+            $notice = new Notice();
+            $notice->query(sprintf('SELECT id, lat, lon, location_id, location_ns FROM %1$s ' .
+                                 'WHERE lat IS NOT NULL ' .
+                                    'OR lon IS NOT NULL ' .
+                                    'OR location_id IS NOT NULL ' .
+                                    'OR location_ns IS NOT NULL',
+                                 $schema->quoteIdentifier($table)));
+            print "\nFound {$notice->N} notices with location data, inserting";
+            while ($notice->fetch()) {
+                $notloc = Notice_location::getKV('notice_id', $notice->id);
+                if ($notloc instanceof Notice_location) {
+                    print "-";
+                    continue;
+                }
+                $notloc = new Notice_location();
+                $notloc->notice_id = $notice->id;
+                $notloc->lat= $notice->lat;
+                $notloc->lon= $notice->lon;
+                $notloc->location_id= $notice->location_id;
+                $notloc->location_ns= $notice->location_ns;
+                $notloc->insert();
+                print ".";
+            }
+            print "\n";
         }
 
         /**
-         *  Make sure constraints are met before upgrading.
+         *  Make sure constraints are met before upgrading, if foreign keys
+         *  are not already in use.
          *  2016-03-31
-         *
-         *  Will find foreign keys which do not fulfill the constraints and fix
-         *  where appropriate, such as delete when "repeat_of" ID not found in notice.id
-         *  or set to NULL for "reply_to" in the same case.
-         *
-         *  XXX: How does this work if we would use multicolumn foreign keys?
          */
-        foreach (['reply_to' => 'reset', 'repeat_of' => 'delete', 'profile' => 'delete'] as $field=>$action) {
-            $notice = new Notice();
-
-            $fkeyname = $notice->tableName().'_'.$field.'_fkey';
-            assert(isset($schemadef['foreign keys'][$fkeyname]) && $schemadef['foreign keys'][$fkeyname]);
-            $foreign_key = $schemadef['foreign keys'][$fkeyname];
-            printfnq("\n"._ve($schemadef));
-            $fkeytable = $foreign_key[0];
-            assert(isset($foreign_key[1][$field]));
-            $fkeycol   = $foreign_key[1][$field];
-
-            // NOTE: Above we set all repeat_of to NULL if they were 0, so this really gets them all.
-            $notice->whereAdd(sprintf('%1$s NOT IN (SELECT %2$s FROM %3$s)', $field, $fkeycol, $fkeytable));
-            if ($notice->find()) {
-                printfnq("\tFound {$notice->N} notices with {$field} NOT IN notice.id, {$action}ing...");
-                switch ($action) {
-                case 'delete':  // since it's a directly dependant notice for an unknown ID we don't want it in our DB
-                    while ($notice->fetch()) {
-                        // $notice->delete();
-                        printfnq("\n deleting {$notice->id}");
-                    }
-                    break;
-                case 'reset':   // just set it to NULL to be compatible with our constraints, if it was related to an unknown ID
-                    $ids = [];
-                    foreach ($notice->fetchAll('id') as $id) {
-                        settype($id, 'int');
-                        $ids[] = $id;
+        if (!isset($schemadef['foreign keys'])) {
+            $newschemadef = self::schemaDef();
+            printfnq("\nConstraint checking Notice table...\n");
+            /**
+             *  Improve typing and make sure no NULL values in any id-related columns are 0
+             *  2016-03-31
+             */
+            foreach (['reply_to', 'repeat_of'] as $field) {
+                $notice = new Notice(); // reset the object
+                $notice->query(sprintf('UPDATE %1$s SET %2$s=NULL WHERE %2$s=0', $notice->escapedTableName(), $field));
+                // Now we're sure that no Notice entries have repeat_of=0, only an id > 0 or NULL
+                unset($notice);
+            }
+
+            /**
+             *  This Will find foreign keys which do not fulfill the constraints and fix
+             *  where appropriate, such as delete when "repeat_of" ID not found in notice.id
+             *  or set to NULL for "reply_to" in the same case.
+             *  2016-03-31
+             *
+             *  XXX: How does this work if we would use multicolumn foreign keys?
+             */
+            foreach (['reply_to' => 'reset', 'repeat_of' => 'delete', 'profile_id' => 'delete'] as $field=>$action) {
+                $notice = new Notice();
+
+                $fkeyname = $notice->tableName().'_'.$field.'_fkey';
+                assert(isset($newschemadef['foreign keys'][$fkeyname]));
+                assert($newschemadef['foreign keys'][$fkeyname]);
+
+                $foreign_key = $newschemadef['foreign keys'][$fkeyname];
+                $fkeytable = $foreign_key[0];
+                assert(isset($foreign_key[1][$field]));
+                $fkeycol   = $foreign_key[1][$field];
+
+                printfnq("* {$fkeyname} ({$field} => {$fkeytable}.{$fkeycol})\n");
+
+                // NOTE: Above we set all repeat_of to NULL if they were 0, so this really gets them all.
+                $notice->whereAdd(sprintf('%1$s NOT IN (SELECT %2$s FROM %3$s)', $field, $fkeycol, $fkeytable));
+                if ($notice->find()) {
+                    printfnq("\tFound {$notice->N} notices with {$field} NOT IN notice.id, {$action}ing...");
+                    switch ($action) {
+                    case 'delete':  // since it's a directly dependant notice for an unknown ID we don't want it in our DB
+                        while ($notice->fetch()) {
+                            $notice->delete();
+                        }
+                        break;
+                    case 'reset':   // just set it to NULL to be compatible with our constraints, if it was related to an unknown ID
+                        $ids = [];
+                        foreach ($notice->fetchAll('id') as $id) {
+                            settype($id, 'int');
+                            $ids[] = $id;
+                        }
+                        unset($notice);
+                        $notice = new Notice();
+                        $notice->query(sprintf('UPDATE %1$s SET %2$s=NULL WHERE id IN (%3$s)',
+                                            $notice->escapedTableName(),
+                                            $field,
+                                            implode(',', $ids)));
+                        break;
+                    default:
+                        throw new ServerException('The programmer sucks, invalid action name when fixing table.');
                     }
-                    $notice = new Notice();
-                    $notice->query(sprintf('UPDATE %1$s SET %2$s=NULL WHERE id IN (%3$s)',
-                                        $notice->escapedTableName(),
-                                        $field,
-                                        implode(',', $ids)));
-                    break;
-                default:
-                    throw new ServerException('The programmer sucks, invalid action name when fixing table.');
+                    printfnq("DONE.\n");
                 }
-                printfnq("DONE.\n");
-            }
-            unset($notice);
-        }
-
-        // 2015-09-04 We move Notice location data to Notice_location
-        // First we see if we have to do this at all
-        if (!isset($schemadef['fields']['lat'])
-                && !isset($schemadef['fields']['lon'])
-                && !isset($schemadef['fields']['location_id'])
-                && !isset($schemadef['fields']['location_ns'])) {
-            // We have already removed the location fields, so no need to migrate.
-            return;
-        }
-        // Then we make sure the Notice_location table is created!
-        $schema->ensureTable('notice_location', Notice_location::schemaDef());
-
-        // Then we continue on our road to migration!
-        echo "\nFound old $table table, moving location data to 'notice_location' table... (this will probably take a LONG time, but can be aborted and continued)";
-
-        $notice = new Notice();
-        $notice->query(sprintf('SELECT id, lat, lon, location_id, location_ns FROM %1$s ' .
-                             'WHERE lat IS NOT NULL ' .
-                                'OR lon IS NOT NULL ' .
-                                'OR location_id IS NOT NULL ' .
-                                'OR location_ns IS NOT NULL',
-                             $schema->quoteIdentifier($table)));
-        print "\nFound {$notice->N} notices with location data, inserting";
-        while ($notice->fetch()) {
-            $notloc = Notice_location::getKV('notice_id', $notice->id);
-            if ($notloc instanceof Notice_location) {
-                print "-";
-                continue;
+                unset($notice);
             }
-            $notloc = new Notice_location();
-            $notloc->notice_id = $notice->id;
-            $notloc->lat= $notice->lat;
-            $notloc->lon= $notice->lon;
-            $notloc->location_id= $notice->location_id;
-            $notloc->location_ns= $notice->location_ns;
-            $notloc->insert();
-            print ".";
         }
-        print "\n";
     }
 }