debug_report_bug() was to 'hard' here.

[mailer.git] / inc / modules / admin / what-refbanner.php

diff --git a/inc/modules/admin/what-refbanner.php b/inc/modules/admin/what-refbanner.php
index 2e64fa299931a217e1266b06d1bd57099d43a7d8..cab32b931155914b10d6fbf57f8fb903b488b36c 100644 (file)
--- a/inc/modules/admin/what-refbanner.php
+++ b/inc/modules/admin/what-refbanner.php
@@ -38,7 +38,7 @@
 
 // Some security stuff...
 if ((!defined('__SECURITY')) || (!IS_ADMIN())) {
-       $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), "/inc") + 4) . "/security.php";
+       $INC = substr(dirname(__FILE__), 0, strpos(dirname(__FILE__), '/inc') + 4) . '/security.php';
        require($INC);
 }
 
@@ -49,49 +49,49 @@ ADD_DESCR('admin', __FILE__);
 $SEL = 0;
 
 // Some sanity-check
-if ((!REQUEST_ISSET_POST(('url'))) || (!REQUEST_ISSET_POST(('alternate')))) {
+if ((!REQUEST_ISSET_POST('url')) || (!REQUEST_ISSET_POST(('alternate')))) {
        REQUEST_UNSET_POST('ok');
 }
 
 // Check selection count
-if (REQUEST_ISSET_POST('sel')) $SEL = SELECTION_COUNT(REQUEST_POST('sel'));
+if (REQUEST_ISSET_POST('sel')) $SEL = countPostSelection();
 
-if (IS_FORM_SENT()) {
+if (isFormSent()) {
        // Fix older calls from add-new-banner-form
-       if (!REQUEST_ISSET_GET(('mode'))) REQUEST_SET_GET('mode', 'add');
+       if (!REQUEST_ISSET_GET('mode')) REQUEST_SET_GET('mode', 'add');
        $sql = '';
        switch (REQUEST_GET('mode'))
        {
-       case 'add':
-               // Check if banner is already added
-               $result = SQL_QUERY_ESC("SELECT id FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE url='%s' LIMIT 1",
+               case 'add':
+                       // Check if banner is already added
+                       $result = SQL_QUERY_ESC("SELECT `id` FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE url='%s' LIMIT 1",
                        array(REQUEST_POST('url')), __FILE__, __LINE__);
-               if (SQL_NUMROWS($result) == 0) {
-                       // Add banner
-                       SQL_QUERY_ESC("INSERT INTO `{!_MYSQL_PREFIX!}_refbanner` (url, alternate, visible)
+                       if (SQL_NUMROWS($result) == 0) {
+                               // Add banner
+                               SQL_QUERY_ESC("INSERT INTO `{!_MYSQL_PREFIX!}_refbanner` (url, alternate, visible)
 VALUES ('%s','%s','%s')",
                                array(REQUEST_POST('url'), REQUEST_POST('alternate'), REQUEST_POST('visible')), __FILE__, __LINE__);
-               } else {
-                       // Free memory
-                       SQL_FREERESULT($result);
-               }
-               break;
-
-       case "edit": // Update banner
-               foreach (REQUEST_POST('sel') as $id => $sel) {
-                       // Secure ID
-                       $id = bigintval($id);
-
-                       // Update entry
-                       SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_refbanner` SET url='%s', alternate='%s', `visible`='%s' WHERE id=%s LIMIT 1",
+                       } else {
+                               // Free memory
+                               SQL_FREERESULT($result);
+                       }
+                       break;
+
+               case 'edit': // Update banner
+                       foreach (REQUEST_POST('sel') as $id => $sel) {
+                               // Secure ID
+                               $id = bigintval($id);
+
+                               // Update entry
+                               SQL_QUERY_ESC("UPDATE `{!_MYSQL_PREFIX!}_refbanner` SET url='%s', alternate='%s', `visible`='%s' WHERE `id`=%s LIMIT 1",
                                array(
-                                       REQUEST_POST('url', $id),
-                                       REQUEST_POST('alternate', $id),
-                                       REQUEST_POST('visible'),
-                                       $id
+                               REQUEST_POST('url', $id),
+                               REQUEST_POST('alternate', $id),
+                               REQUEST_POST('visible'),
+                               $id
                                ), __FILE__, __LINE__);
-               }
-               break;
+                       }
+                       break;
        }
 
        if (SQL_AFFECTEDROWS() == 1) {
@@ -102,11 +102,11 @@ VALUES ('%s','%s','%s')",
        LOAD_TEMPLATE('admin_settings_saved', false, $content);
 } elseif (($SEL > 0) && (REQUEST_ISSET_POST('edit'))) {
        // Edit banner
-       $SW = ''; $OUT = '';
+       $SW = 2; $OUT = '';
        foreach (REQUEST_POST('sel') as $id => $sel) {
                // Load data
-               $result = SQL_QUERY_ESC("SELECT url, alternate, visible FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE id=%s LIMIT 1",
-                       array(bigintval($id)), __FILE__, __LINE__);
+               $result = SQL_QUERY_ESC("SELECT url, alternate, visible FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE `id`=%s LIMIT 1",
+               array(bigintval($id)), __FILE__, __LINE__);
                list($url, $alt, $vis) = SQL_FETCHROW($result);
                SQL_FREERESULT($result);
 
@@ -116,11 +116,11 @@ VALUES ('%s','%s','%s')",
                        'id'  => $id,
                        'url' => $url,
                        'alt' => $alt,
-                       'vis' => ADD_SELECTION("yn", $vis   , "visible"),
+                       'vis' => ADD_SELECTION('yn', $vis   , 'visible'),
                );
 
                // Load row template and switch color
-               $OUT .= LOAD_TEMPLATE("admin_refbanner_edit_row", true, $content);
+               $OUT .= LOAD_TEMPLATE('admin_refbanner_edit_row', true, $content);
                $SW = 3 - $SW;
        }
 
@@ -128,19 +128,20 @@ VALUES ('%s','%s','%s')",
        define('__BANNER_ROWS', $OUT);
 
        // Load main template
-       LOAD_TEMPLATE("admin_refbanner_edit");
+       LOAD_TEMPLATE('admin_refbanner_edit');
 } else {
        if (($SEL > 0) && (REQUEST_ISSET_POST('del'))) {
                // Delete banner
                foreach (REQUEST_POST('sel') as $id => $sel) {
-                       SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE id=%s LIMIT 1",
-                               array(bigintval($id)), __FILE__, __LINE__);
-               }
-       }
+                       SQL_QUERY_ESC("DELETE LOW_PRIORITY FROM `{!_MYSQL_PREFIX!}_refbanner` WHERE `id`=%s LIMIT 1",
+                       array(bigintval($id)), __FILE__, __LINE__);
+               } // END - foreach
+       } // END - if
 
        // Referal levels
-       $result = SQL_QUERY("SELECT id, url, alternate, visible, counter, clicks FROM `{!_MYSQL_PREFIX!}_refbanner` ORDER BY url",
-               __FILE__, __LINE__);
+       $result = SQL_QUERY("SELECT id, url, alternate, visible, counter, clicks FROM `{!_MYSQL_PREFIX!}_refbanner` ORDER BY url", __FILE__, __LINE__);
+
+       // Entries found?
        if (SQL_NUMROWS($result) > 0) {
                // Make referal banner editable and deletable
                $OUT = ''; $SW = 2;
@@ -152,7 +153,7 @@ VALUES ('%s','%s','%s')",
                                'id'  => $content['id'],
                                'url' => $content['url'],
                                'alt' => $content['alternate'],
-                               'vis' => TRANSLATE_YESNO($content['visible']),
+                               'vis' => translateYesNo($content['visible']),
                                'cnt' => $content['counter'],
                                'clx' => $content['clicks']
                        );
@@ -169,11 +170,11 @@ VALUES ('%s','%s','%s')",
                define('__BANNER_ROWS', $OUT);
 
                // Load main template
-               LOAD_TEMPLATE("admin_refbanner");
+               LOAD_TEMPLATE('admin_refbanner');
        }
 
        // Form for adding new referal levels
-       LOAD_TEMPLATE("admin_add_banner");
+       LOAD_TEMPLATE('admin_add_banner');
 }
 
 //