Even more fixes, loading session was on wrong page (needs db link up)

[mailer.git] / inc / modules / admin / what-stats_mods.php

diff --git a/inc/modules/admin/what-stats_mods.php b/inc/modules/admin/what-stats_mods.php
index fc69db6d3e89a7710d8a5315ce00a9ba55602876..33e9536e1207b8ebff2518d2132bd8185b5e9e19 100644 (file)
--- a/inc/modules/admin/what-stats_mods.php
+++ b/inc/modules/admin/what-stats_mods.php
@@ -38,27 +38,25 @@ if ((!defined('__SECURITY')) || (!IS_ADMIN())) {
 }
 
 // Add description as navigation point
-ADD_DESCR("admin", basename(__FILE__));
+ADD_DESCR("admin", __FILE__);
 
 // If var is empty set it to empty
-if (empty($_GET['mod'])) $_GET['mod'] = "";
+if (!REQUEST_ISSET_GET(('mod'))) REQUEST_SET_GET('mod', "");
 
 // Check if module was selected
-if (($_GET['mod'] == "index") || ($_GET['mod'] == "login"))
-{
+if ((REQUEST_GET('mod') == "index") || (REQUEST_GET('mod') == "login")) {
        // Select menu system
        $mod = "";
-       switch ($_GET['mod'])
-       {
+       switch (REQUEST_GET('mod')) {
                case "index": $mod = "guest" ; break;
                case "login": $mod = "member"; break;
        }
 
        // Load module's detail statistic
-       $result = SQL_QUERY("SELECT action, title, counter FROM "._MYSQL_PREFIX."_".$mod."_menu WHERE what != '' ORDER BY counter DESC", __FILE__, __LINE__);
+       $result = SQL_QUERY_ESC("SELECT action, title, counter FROM `{!_MYSQL_PREFIX!}_%s_menu` WHERE `what` != '' AND `what` IS NOT NULL ORDER BY counter DESC",
+               array($mod), __FILE__, __LINE__);
        $SW = 2; $OUT = "";
-       while(list($act, $title, $clicks) = SQL_FETCHROW($result))
-       {
+       while (list($act, $title, $clicks) = SQL_FETCHROW($result)) {
                // Prepare array for the template
                $content = array(
                        'sw'     => $SW,
@@ -80,19 +78,16 @@ if (($_GET['mod'] == "index") || ($_GET['mod'] == "login"))
 
        // Load final template
        LOAD_TEMPLATE("admin_mods_stats2");
-}
- else
-{
+} else {
        // Load module statics
-       $result = SQL_QUERY("SELECT module, title, clicks FROM "._MYSQL_PREFIX."_mod_reg ORDER BY clicks DESC, module", __FILE__, __LINE__);
+       $result = SQL_QUERY("SELECT module, title, clicks FROM `{!_MYSQL_PREFIX!}_mod_reg` ORDER BY clicks DESC, module", __FILE__, __LINE__);
        $SW = 2; $OUT = "";
-       while(list($mod, $title, $clicks) = SQL_FETCHROW($result))
-       {
+       while (list($mod, $title, $clicks) = SQL_FETCHROW($result)) {
                if (empty($title)) $title = "---";
                if (($mod == "index") || ($mod == "login"))
                {
                        // Add link to detail statistics
-                       $mod = "<STRONG><A href=\"".URL."/modules.php?module=admin&amp;what=stats_mods&amp;mod=".$mod."\">".$mod."</A></STRONG>";
+                       $mod = "<strong><a href=\"{!URL!}/modules.php?module=admin&amp;what=stats_mods&amp;mod=".$mod."\">".$mod."</a></strong>";
                }
                // Prepare array for the template
                $content = array(
@@ -113,5 +108,6 @@ if (($_GET['mod'] == "index") || ($_GET['mod'] == "login"))
        // Load final template
        LOAD_TEMPLATE("admin_mods_stats");
 }
+
 //
 ?>