More usage of dbm::is_result($r) instead of count($r):

[friendica.git] / include / Contact.php

diff --git a/include/Contact.php b/include/Contact.php
index d0f4023447f1448962d7f1ffd0bbabfcff3e97ab..03294f04072db906d0fb59234b58d4c4a1c778d1 100644 (file)
--- a/include/Contact.php
+++ b/include/Contact.php
@@ -64,7 +64,7 @@ function contact_remove($id) {
        $r = q("select uid from contact where id = %d limit 1",
                intval($id)
        );
-       if((! count($r)) || (! intval($r[0]['uid'])))
+       if((! dbm::is_result($r)) || (! intval($r[0]['uid'])))
                return;
 
        $archive = get_pconfig($r[0]['uid'], 'system','archive_removed_contacts');
@@ -249,7 +249,7 @@ function get_contact_details_by_url($url, $uid = -1, $default = array()) {
                        FROM `gcontact` WHERE `nurl` = '%s'",
                                dbesc(normalise_link($url)));
 
-       if ($r) {
+       if (dbm::is_result($r)) {
                // If there is more than one entry we filter out the connector networks
                if (count($r) > 1) {
                        foreach ($r AS $id => $result) {
@@ -435,7 +435,7 @@ function random_profile() {
                        ORDER BY rand() LIMIT 1",
                dbesc(NETWORK_DFRN));
 
-       if(count($r))
+       if(dbm::is_result($r))
                return dirname($r[0]['url']);
        return '';
 }
@@ -666,57 +666,55 @@ function posts_from_gcontact($a, $gcontact_id) {
 
        return $o;
 }
-
 /**
- * @brief Returns posts from a given contact
+ * @brief Returns posts from a given contact url
  *
  * @param App $a argv application class
- * @param int $contact_id contact
+ * @param string $contact_url Contact URL
  *
  * @return string posts in HTML
  */
-function posts_from_contact($a, $contact_id) {
+function posts_from_contact_url($a, $contact_url) {
 
        require_once('include/conversation.php');
 
-       $r = q("SELECT `url` FROM `contact` WHERE `id` = %d", intval($contact_id));
-       if (!$r)
-               return false;
+       // There are no posts with "uid = 0" with connector networks
+       // This speeds up the query a lot
+       $r = q("SELECT `network`, `id` AS `author-id` FROM `contact`
+               WHERE `contact`.`nurl` = '%s' AND `contact`.`uid` = 0",
+               dbesc(normalise_link($contact_url)));
+       if (in_array($r[0]["network"], array(NETWORK_DFRN, NETWORK_DIASPORA, NETWORK_OSTATUS, ""))) {
+               $sql = "(`item`.`uid` = 0 OR (`item`.`uid` = %d AND `item`.`private`))";
+       } else {
+               $sql = "`item`.`uid` = %d";
+       }
 
-       $contact = $r[0];
+       $author_id = intval($r[0]["author-id"]);
 
-       if(get_config('system', 'old_pager')) {
+       if (get_config('system', 'old_pager')) {
                $r = q("SELECT COUNT(*) AS `total` FROM `item`
-                       WHERE `item`.`uid` = %d AND `author-link` IN ('%s', '%s')",
-                       intval(local_user()),
-                       dbesc(str_replace("https://", "http://", $contact["url"])),
-                       dbesc(str_replace("http://", "https://", $contact["url"])));
+                       WHERE `author-id` = %d and $sql",
+                       intval($author_id),
+                       intval(local_user()));
 
                $a->set_pager_total($r[0]['total']);
        }
 
-       $r = q("SELECT `item`.`uri`, `item`.*, `item`.`id` AS `item_id`,
-                       `author-name` AS `name`, `owner-avatar` AS `photo`,
-                       `owner-link` AS `url`, `owner-avatar` AS `thumb`
-               FROM `item` FORCE INDEX (`uid_contactid_id`)
-               WHERE `item`.`uid` = %d AND `contact-id` = %d
-                       AND `author-link` IN ('%s', '%s')
-                       AND NOT `deleted` AND NOT `moderated` AND `visible`
-               ORDER BY `item`.`id` DESC LIMIT %d, %d",
+       $r = q(item_query()." AND `item`.`author-id` = %d AND ".$sql.
+               " ORDER BY `item`.`created` DESC LIMIT %d, %d",
+               intval($author_id),
                intval(local_user()),
-               intval($contact_id),
-               dbesc(str_replace("https://", "http://", $contact["url"])),
-               dbesc(str_replace("http://", "https://", $contact["url"])),
                intval($a->pager['start']),
                intval($a->pager['itemspage'])
        );
 
-       $o .= conversation($a,$r,'community',false);
+       $o = conversation($a,$r,'community',false);
 
-       if(!get_config('system', 'old_pager'))
+       if (!get_config('system', 'old_pager')) {
                $o .= alt_pager($a,count($r));
-       else
+       } else {
                $o .= paginate($a);
+       }
 
        return $o;
 }