]> git.mxchange.org Git - friendica.git/blobdiff - include/NotificationsManager.php
Merge remote-tracking branch 'upstream/develop' into 1607-performance
[friendica.git] / include / NotificationsManager.php
index fef48d5d43f56f289d1d5c36ea07a0c9e91fc016..274f6061f11f059df7ff39d7e91bcf6aaf56e2a9 100644 (file)
@@ -7,7 +7,6 @@
 require_once('include/html2plain.php');
 require_once("include/datetime.php");
 require_once("include/bbcode.php");
-require_once("include/dbm.php");
 
 /**
  * @brief Methods for read and write notifications from/to database
@@ -82,12 +81,16 @@ class NotificationsManager {
                }
                $order_sql = implode(", ", $asOrder);
 
-               if ($limit!="") $limit = " LIMIT ".$limit;
+               if($limit!="")
+                       $limit = " LIMIT ".$limit;
 
                        $r = q("SELECT * FROM `notify` WHERE `uid` = %d $filter_sql ORDER BY $order_sql $limit",
                                intval(local_user())
                        );
-               if ($r!==false && count($r)>0) return $this->_set_extra($r);
+
+               if(dbm::is_result($r))
+                       return $this->_set_extra($r);
+
                return false;
        }
 
@@ -102,7 +105,7 @@ class NotificationsManager {
                        intval($id),
                        intval(local_user())
                );
-               if($r!==false && count($r)>0) {
+               if(dbm::is_result($r)) {
                        return $this->_set_extra($r)[0];
                }
                return null;
@@ -210,8 +213,9 @@ class NotificationsManager {
                                // Because we use different db tables for the notification query
                                // we have sometimes $it['unseen'] and sometimes $it['seen].
                                // So we will have to transform $it['unseen']
-                               if($it['unseen'])
+                               if (array_key_exists('unseen', $it)) {
                                        $it['seen'] = ($it['unseen'] > 0 ? false : true);
+                               }
 
                                // Depending on the identifier of the notification we need to use different defaults
                                switch ($ident) {
@@ -221,16 +225,14 @@ class NotificationsManager {
                                                $default_item_image = proxy_url($it['photo'], false, PROXY_SIZE_MICRO);
                                                $default_item_text = strip_tags(bbcode($it['msg']));
                                                $default_item_when = relative_date($it['date']);
-                                               $default_tpl = $tpl_notify;
                                                break;
 
                                        case 'home':
                                                $default_item_label = 'comment';
                                                $default_item_link = $this->a->get_baseurl(true).'/display/'.$it['pguid'];
                                                $default_item_image = proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO);
-                                               $default_item_text = sprintf( t("%s commented on %s's post"), $it['author-name'], $it['pname']);
+                                               $default_item_text = sprintf(t("%s commented on %s's post"), $it['author-name'], $it['pname']);
                                                $default_item_when = relative_date($it['created']);
-                                               $default_tpl = $tpl_item_comments;
                                                break;
 
                                        default:
@@ -238,21 +240,20 @@ class NotificationsManager {
                                                $default_item_link = $this->a->get_baseurl(true).'/display/'.$it['pguid'];
                                                $default_item_image = proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO);
                                                $default_item_text = (($it['id'] == $it['parent'])
-                                                                       ? sprintf( t("%s created a new post"), $it['author-name'])
-                                                                       : sprintf( t("%s commented on %s's post"), $it['author-name'], $it['pname']));
+                                                                       ? sprintf(t("%s created a new post"), $it['author-name'])
+                                                                       : sprintf(t("%s commented on %s's post"), $it['author-name'], $it['pname']));
                                                $default_item_when = relative_date($it['created']);
-                                               $default_tpl = (($it['id'] == $it['parent']) ? $tpl_item_posts : $tpl_item_comments);
 
                                }
 
                                // Transform the different types of notification in an usable array
-                               switch($it['verb']){
+                               switch ($it['verb']){
                                        case ACTIVITY_LIKE:
                                                $notif = array(
                                                        'label' => 'like',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        '$image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
-                                                       'text' => sprintf( t("%s liked %s's post"), $it['author-name'], $it['pname']),
+                                                       'text' => sprintf(t("%s liked %s's post"), $it['author-name'], $it['pname']),
                                                        'when' => relative_date($it['created']),
                                                        'seen' => $it['seen']
                                                );
@@ -263,7 +264,7 @@ class NotificationsManager {
                                                        'label' => 'dislike',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
-                                                       'text' => sprintf( t("%s disliked %s's post"), $it['author-name'], $it['pname']),
+                                                       'text' => sprintf(t("%s disliked %s's post"), $it['author-name'], $it['pname']),
                                                        'when' => relative_date($it['created']),
                                                        'seen' => $it['seen']
                                                );
@@ -274,7 +275,7 @@ class NotificationsManager {
                                                        'label' => 'attend',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
-                                                       'text' => sprintf( t("%s is attending %s's event"), $it['author-name'], $it['pname']),
+                                                       'text' => sprintf(t("%s is attending %s's event"), $it['author-name'], $it['pname']),
                                                        'when' => relative_date($it['created']),
                                                        'seen' => $it['seen']
                                                );
@@ -296,7 +297,7 @@ class NotificationsManager {
                                                        'label' => 'attendmaybe',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
-                                                       'text' => sprintf( t("%s may attend %s's event"), $it['author-name'], $it['pname']),
+                                                       'text' => sprintf(t("%s may attend %s's event"), $it['author-name'], $it['pname']),
                                                        'when' => relative_date($it['created']),
                                                        'seen' => $it['seen']
                                                );
@@ -311,7 +312,7 @@ class NotificationsManager {
                                                        'label' => 'friend',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
-                                                       'text' => sprintf( t("%s is now friends with %s"), $it['author-name'], $it['fname']),
+                                                       'text' => sprintf(t("%s is now friends with %s"), $it['author-name'], $it['fname']),
                                                        'when' => relative_date($it['created']),
                                                        'seen' => $it['seen']
                                                );
@@ -344,6 +345,8 @@ class NotificationsManager {
         * @return int Number of network notifications
         */
        private function networkTotal($seen = 0) {
+               $sql_seen = "";
+
                if($seen === 0)
                        $sql_seen = " AND `item`.`unseen` = 1 ";
 
@@ -379,6 +382,7 @@ class NotificationsManager {
                $ident = 'network';
                $total = $this->networkTotal($seen);
                $notifs = array();
+               $sql_seen = "";
 
                if($seen === 0)
                        $sql_seen = " AND `item`.`unseen` = 1 ";
@@ -417,6 +421,8 @@ class NotificationsManager {
         * @return int Number of system notifications
         */
        private function systemTotal($seen = 0) {
+               $sql_seen = "";
+
                if($seen === 0)
                        $sql_seen = " AND `seen` = 0 ";
 
@@ -430,7 +436,7 @@ class NotificationsManager {
                return 0;
        }
 
-               /**
+       /**
         * @brief Get system notifications
         * 
         * @param int|string $seen
@@ -448,6 +454,7 @@ class NotificationsManager {
                $ident = 'system';
                $total = $this->systemTotal($seen);
                $notifs = array();
+               $sql_seen = "";
 
                if($seen === 0)
                        $sql_seen = " AND `seen` = 0 ";
@@ -481,7 +488,7 @@ class NotificationsManager {
                $myurl = substr($myurl,strpos($myurl,'://')+3);
                $myurl = str_replace(array('www.','.'),array('','\\.'),$myurl);
                $diasp_url = str_replace('/profile/','/u/',$myurl);
-               $sql_extra .= sprintf(" AND ( `item`.`author-link` regexp '%s' or `item`.`tag` regexp '%s' or `item`.`tag` regexp '%s' ) ",
+               $sql_extra = sprintf(" AND ( `item`.`author-link` regexp '%s' or `item`.`tag` regexp '%s' or `item`.`tag` regexp '%s' ) ",
                        dbesc($myurl . '$'),
                        dbesc($myurl . '\\]'),
                        dbesc($diasp_url . '\\]')
@@ -498,7 +505,8 @@ class NotificationsManager {
         * @return int Number of personal notifications
         */
        private function personalTotal($seen = 0) {
-               $sql_extra .= $this->_personal_sql_extra();
+               $sql_seen = "";
+               $sql_extra = $this->_personal_sql_extra();
 
                if($seen === 0)
                        $sql_seen = " AND `item`.`unseen` = 1 ";
@@ -535,15 +543,16 @@ class NotificationsManager {
        public function personalNotifs($seen = 0, $start = 0, $limit = 80) {
                $ident = 'personal';
                $total = $this->personalTotal($seen);
-               $sql_extra .= $this->_personal_sql_extra();
+               $sql_extra = $this->_personal_sql_extra();
                $notifs = array();
+               $sql_seen = "";
 
                if($seen === 0)
                        $sql_seen = " AND `item`.`unseen` = 1 ";
 
                $r = q("SELECT `item`.`id`,`item`.`parent`, `item`.`verb`, `item`.`author-name`, `item`.`unseen`,
                                `item`.`author-link`, `item`.`author-avatar`, `item`.`created`, `item`.`object` AS `object`, 
-                               `pitem`.`author-name` AS `pname`, `pitem`.`author-link` AS `plink`, `pitem`.`guid` AS `pguid`, 
+                               `pitem`.`author-name` AS `pname`, `pitem`.`author-link` AS `plink`, `pitem`.`guid` AS `pguid` 
                        FROM `item` INNER JOIN `item` AS `pitem` ON  `pitem`.`id`=`item`.`parent`
                        WHERE `item`.`visible` = 1
                                $sql_extra
@@ -575,6 +584,8 @@ class NotificationsManager {
         * @return int Number of home notifications
         */
        private function homeTotal($seen = 0) {
+               $sql_seen = "";
+
                if($seen === 0)
                        $sql_seen = " AND `item`.`unseen` = 1 ";
 
@@ -609,6 +620,7 @@ class NotificationsManager {
                $ident = 'home';
                $total = $this->homeTotal($seen);
                $notifs = array();
+               $sql_seen = "";
 
                if($seen === 0)
                        $sql_seen = " AND `item`.`unseen` = 1 ";
@@ -640,13 +652,15 @@ class NotificationsManager {
 
        /**
         * @brief Total number of introductions 
-        * @param int $all
-        *      If 0 only include introductions into the query
+        * @param bool $all
+        *      If false only include introductions into the query
         *      which aren't marked as ignored
         * @return int Number of introductions
         */
-       private function introTotal($all) {
-               if($all === 0)
+       private function introTotal($all = false) {
+               $sql_extra = "";
+
+               if(!$all)
                        $sql_extra = " AND `ignore` = 0 ";
 
                $r = q("SELECT COUNT(*) AS `total` FROM `intro`
@@ -663,8 +677,8 @@ class NotificationsManager {
        /**
         * @brief Get introductions
         * 
-        * @param int $all
-        *      If 0 only include introductions into the query
+        * @param bool $all
+        *      If false only include introductions into the query
         *      which aren't marked as ignored
         * @param int $start Start the query at this point
         * @param int $limit Maximum number of query results
@@ -674,12 +688,13 @@ class NotificationsManager {
         *      int 'total' => Total number of available introductions
         *      array 'notifications' => Introductions
         */
-       public function introNotifs($all = 0, $start = 0, $limit = 80) {
+       public function introNotifs($all = false, $start = 0, $limit = 80) {
                $ident = 'introductions';
                $total = $this->introTotal($seen);
                $notifs = array();
+               $sql_extra = "";
 
-               if($all === 0)
+               if(!$all)
                        $sql_extra = " AND `ignore` = 0 ";
 
                /// @todo Fetch contact details by "get_contact_details_by_url" instead of queries to contact, fcontact and gcontact