]> git.mxchange.org Git - friendica.git/blobdiff - include/NotificationsManager.php
Fixed some stuff as requested by @Hypolite
[friendica.git] / include / NotificationsManager.php
index 274f6061f11f059df7ff39d7e91bcf6aaf56e2a9..57c315c9d741954b671aff04560cadbc52202e63 100644 (file)
@@ -4,9 +4,12 @@
  * @brief Methods for read and write notifications from/to database
  *  or for formatting notifications
  */
-require_once('include/html2plain.php');
-require_once("include/datetime.php");
-require_once("include/bbcode.php");
+
+require_once 'include/html2plain.php';
+require_once 'include/probe.php';
+require_once 'include/datetime.php';
+require_once 'include/bbcode.php';
+require_once 'include/Contact.php';
 
 /**
  * @brief Methods for read and write notifications from/to database
@@ -24,7 +27,7 @@ class NotificationsManager {
         *
         * @param array $notes array of note arrays from db
         * @return array Copy of input array with added properties
-        * 
+        *
         * Set some extra properties to note array from db:
         *  - timestamp as int in default TZ
         *  - date_rel : relative date string
@@ -88,7 +91,7 @@ class NotificationsManager {
                                intval(local_user())
                        );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        return $this->_set_extra($r);
 
                return false;
@@ -105,7 +108,7 @@ class NotificationsManager {
                        intval($id),
                        intval(local_user())
                );
-               if(dbm::is_result($r)) {
+               if (dbm::is_result($r)) {
                        return $this->_set_extra($r)[0];
                }
                return null;
@@ -143,8 +146,7 @@ class NotificationsManager {
 
        /**
         * @brief List of pages for the Notifications TabBar
-        * 
-        * @param app $a The 
+        *
         * @return array with with notifications TabBar data
         */
        public function getTabs() {
@@ -191,15 +193,17 @@ class NotificationsManager {
 
        /**
         * @brief Format the notification query in an usable array
-        * 
+        *
         * @param array $notifs The array from the db query
         * @param string $ident The notifications identifier (e.g. network)
         * @return array
         *      string 'label' => The type of the notification
         *      string 'link' => URL to the source
         *      string 'image' => The avatar image
+        *      string 'url' => The profile url of the contact
         *      string 'text' => The notification text
-        *      string 'when' => Relative date of the notification
+        *      string 'when' => The date of the notification
+        *      string 'ago' => T relative date of the notification
         *      bool 'seen' => Is the notification marked as "seen"
         */
        private function formatNotifs($notifs, $ident = "") {
@@ -223,26 +227,32 @@ class NotificationsManager {
                                                $default_item_label = 'notify';
                                                $default_item_link = $this->a->get_baseurl(true).'/notify/view/'. $it['id'];
                                                $default_item_image = proxy_url($it['photo'], false, PROXY_SIZE_MICRO);
+                                               $default_item_url = $it['url'];
                                                $default_item_text = strip_tags(bbcode($it['msg']));
-                                               $default_item_when = relative_date($it['date']);
+                                               $default_item_when = datetime_convert('UTC', date_default_timezone_get(), $it['date'], 'r');
+                                               $default_item_ago = relative_date($it['date']);
                                                break;
 
                                        case 'home':
                                                $default_item_label = 'comment';
                                                $default_item_link = $this->a->get_baseurl(true).'/display/'.$it['pguid'];
                                                $default_item_image = proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO);
+                                               $default_item_url = $it['author-link'];
                                                $default_item_text = sprintf(t("%s commented on %s's post"), $it['author-name'], $it['pname']);
-                                               $default_item_when = relative_date($it['created']);
+                                               $default_item_when = datetime_convert('UTC', date_default_timezone_get(), $it['created'], 'r');
+                                               $default_item_ago = relative_date($it['created']);
                                                break;
 
                                        default:
                                                $default_item_label = (($it['id'] == $it['parent']) ? 'post' : 'comment');
                                                $default_item_link = $this->a->get_baseurl(true).'/display/'.$it['pguid'];
                                                $default_item_image = proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO);
+                                               $default_item_url = $it['author-link'];
                                                $default_item_text = (($it['id'] == $it['parent'])
                                                                        ? sprintf(t("%s created a new post"), $it['author-name'])
                                                                        : sprintf(t("%s commented on %s's post"), $it['author-name'], $it['pname']));
-                                               $default_item_when = relative_date($it['created']);
+                                               $default_item_when = datetime_convert('UTC', date_default_timezone_get(), $it['created'], 'r');
+                                               $default_item_ago = relative_date($it['created']);
 
                                }
 
@@ -252,9 +262,11 @@ class NotificationsManager {
                                                $notif = array(
                                                        'label' => 'like',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
-                                                       '$image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
+                                                       'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
+                                                       'url' => $it['author-link'],
                                                        'text' => sprintf(t("%s liked %s's post"), $it['author-name'], $it['pname']),
-                                                       'when' => relative_date($it['created']),
+                                                       'when' => $default_item_when,
+                                                       'ago' => $default_item_ago,
                                                        'seen' => $it['seen']
                                                );
                                                break;
@@ -264,8 +276,10 @@ class NotificationsManager {
                                                        'label' => 'dislike',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
+                                                       'url' => $it['author-link'],
                                                        'text' => sprintf(t("%s disliked %s's post"), $it['author-name'], $it['pname']),
-                                                       'when' => relative_date($it['created']),
+                                                       'when' => $default_item_when,
+                                                       'ago' => $default_item_ago,
                                                        'seen' => $it['seen']
                                                );
                                                break;
@@ -275,8 +289,10 @@ class NotificationsManager {
                                                        'label' => 'attend',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
+                                                       'url' => $it['author-link'],
                                                        'text' => sprintf(t("%s is attending %s's event"), $it['author-name'], $it['pname']),
-                                                       'when' => relative_date($it['created']),
+                                                       'when' => $default_item_when,
+                                                       'ago' => $default_item_ago,
                                                        'seen' => $it['seen']
                                                );
                                                break;
@@ -286,8 +302,10 @@ class NotificationsManager {
                                                        'label' => 'attendno',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
+                                                       'url' => $it['author-link'],
                                                        'text' => sprintf( t("%s is not attending %s's event"), $it['author-name'], $it['pname']),
-                                                       'when' => relative_date($it['created']),
+                                                       'when' => $default_item_when,
+                                                       'ago' => $default_item_ago,
                                                        'seen' => $it['seen']
                                                );
                                                break;
@@ -297,8 +315,10 @@ class NotificationsManager {
                                                        'label' => 'attendmaybe',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
+                                                       'url' => $it['author-link'],
                                                        'text' => sprintf(t("%s may attend %s's event"), $it['author-name'], $it['pname']),
-                                                       'when' => relative_date($it['created']),
+                                                       'when' => $default_item_when,
+                                                       'ago' => $default_item_ago,
                                                        'seen' => $it['seen']
                                                );
                                                break;
@@ -312,8 +332,10 @@ class NotificationsManager {
                                                        'label' => 'friend',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
+                                                       'url' => $it['author-link'],
                                                        'text' => sprintf(t("%s is now friends with %s"), $it['author-name'], $it['fname']),
-                                                       'when' => relative_date($it['created']),
+                                                       'when' => $default_item_when,
+                                                       'ago' => $default_item_ago,
                                                        'seen' => $it['seen']
                                                );
                                                break;
@@ -323,8 +345,10 @@ class NotificationsManager {
                                                        'label' => $default_item_label,
                                                        'link' => $default_item_link,
                                                        'image' => $default_item_image,
+                                                       'url' => $default_item_url,
                                                        'text' => $default_item_text,
                                                        'when' => $default_item_when,
+                                                       'ago' => $default_item_ago,
                                                        'seen' => $it['seen']
                                                );
                                }
@@ -338,7 +362,7 @@ class NotificationsManager {
        }
 
        /**
-        * @brief Total number of network notifications 
+        * @brief Total number of network notifications
         * @param int|string $seen
         *      If 0 only include notifications into the query
         *      which aren't marked as "seen"
@@ -358,7 +382,7 @@ class NotificationsManager {
                        intval(local_user())
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        return $r[0]['total'];
 
                return 0;
@@ -366,13 +390,13 @@ class NotificationsManager {
 
        /**
         * @brief Get network notifications
-        * 
+        *
         * @param int|string $seen
         *      If 0 only include notifications into the query
         *      which aren't marked as "seen"
         * @param int $start Start the query at this point
         * @param int $limit Maximum number of query results
-        * 
+        *
         * @return array with
         *      string 'ident' => Notification identifier
         *      int 'total' => Total number of available network notifications
@@ -401,7 +425,7 @@ class NotificationsManager {
                                intval($limit)
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        $notifs = $this->formatNotifs($r, $ident);
 
                $arr = array (
@@ -414,7 +438,7 @@ class NotificationsManager {
        }
 
        /**
-        * @brief Total number of system notifications 
+        * @brief Total number of system notifications
         * @param int|string $seen
         *      If 0 only include notifications into the query
         *      which aren't marked as "seen"
@@ -430,7 +454,7 @@ class NotificationsManager {
                        intval(local_user())
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        return $r[0]['total'];
 
                return 0;
@@ -438,13 +462,13 @@ class NotificationsManager {
 
        /**
         * @brief Get system notifications
-        * 
+        *
         * @param int|string $seen
         *      If 0 only include notifications into the query
         *      which aren't marked as "seen"
         * @param int $start Start the query at this point
         * @param int $limit Maximum number of query results
-        * 
+        *
         * @return array with
         *      string 'ident' => Notification identifier
         *      int 'total' => Total number of available system notifications
@@ -459,14 +483,14 @@ class NotificationsManager {
                if($seen === 0)
                        $sql_seen = " AND `seen` = 0 ";
 
-               $r = q("SELECT `id`, `photo`, `msg`, `date`, `seen` FROM `notify`
+               $r = q("SELECT `id`, `url`, `photo`, `msg`, `date`, `seen` FROM `notify`
                                WHERE `uid` = %d $sql_seen ORDER BY `date` DESC LIMIT %d, %d ",
                        intval(local_user()),
                        intval($start),
                        intval($limit)
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        $notifs = $this->formatNotifs($r, $ident);
 
                $arr = array (
@@ -480,7 +504,7 @@ class NotificationsManager {
 
        /**
         * @brief Addional SQL query string for the personal notifications
-        * 
+        *
         * @return string The additional sql query
         */
        private function _personal_sql_extra() {
@@ -488,7 +512,7 @@ class NotificationsManager {
                $myurl = substr($myurl,strpos($myurl,'://')+3);
                $myurl = str_replace(array('www.','.'),array('','\\.'),$myurl);
                $diasp_url = str_replace('/profile/','/u/',$myurl);
-               $sql_extra = sprintf(" AND ( `item`.`author-link` regexp '%s' or `item`.`tag` regexp '%s' or `item`.`tag` regexp '%s' ) ",
+               $sql_extra = sprintf(" AND ( `item`.`author-link` regexp '%s' OR `item`.`tag` regexp '%s' OR `item`.`tag` regexp '%s' ) ",
                        dbesc($myurl . '$'),
                        dbesc($myurl . '\\]'),
                        dbesc($diasp_url . '\\]')
@@ -498,7 +522,7 @@ class NotificationsManager {
        }
 
        /**
-        * @brief Total number of personal notifications 
+        * @brief Total number of personal notifications
         * @param int|string $seen
         *      If 0 only include notifications into the query
         *      which aren't marked as "seen"
@@ -520,7 +544,7 @@ class NotificationsManager {
                        intval(local_user())
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        return $r[0]['total'];
 
                return 0;
@@ -528,13 +552,13 @@ class NotificationsManager {
 
        /**
         * @brief Get personal notifications
-        * 
+        *
         * @param int|string $seen
         *      If 0 only include notifications into the query
         *      which aren't marked as "seen"
         * @param int $start Start the query at this point
         * @param int $limit Maximum number of query results
-        * 
+        *
         * @return array with
         *      string 'ident' => Notification identifier
         *      int 'total' => Total number of available personal notifications
@@ -551,22 +575,22 @@ class NotificationsManager {
                        $sql_seen = " AND `item`.`unseen` = 1 ";
 
                $r = q("SELECT `item`.`id`,`item`.`parent`, `item`.`verb`, `item`.`author-name`, `item`.`unseen`,
-                               `item`.`author-link`, `item`.`author-avatar`, `item`.`created`, `item`.`object` AS `object`, 
-                               `pitem`.`author-name` AS `pname`, `pitem`.`author-link` AS `plink`, `pitem`.`guid` AS `pguid` 
+                               `item`.`author-link`, `item`.`author-avatar`, `item`.`created`, `item`.`object` AS `object`,
+                               `pitem`.`author-name` AS `pname`, `pitem`.`author-link` AS `plink`, `pitem`.`guid` AS `pguid`
                        FROM `item` INNER JOIN `item` AS `pitem` ON  `pitem`.`id`=`item`.`parent`
                        WHERE `item`.`visible` = 1
                                $sql_extra
                                $sql_seen
-                               AND `item`.`deleted` = 0 AND `item`.`uid` = %d AND `item`.`wall` = 0 
+                               AND `item`.`deleted` = 0 AND `item`.`uid` = %d AND `item`.`wall` = 0
                        ORDER BY `item`.`created` DESC LIMIT %d, %d " ,
                                intval(local_user()),
                                intval($start),
                                intval($limit)
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        $notifs = $this->formatNotifs($r, $ident);
-               
+
                $arr = array (
                        'notifications' => $notifs,
                        'ident' => $ident,
@@ -577,7 +601,7 @@ class NotificationsManager {
        }
 
        /**
-        * @brief Total number of home notifications 
+        * @brief Total number of home notifications
         * @param int|string $seen
         *      If 0 only include notifications into the query
         *      which aren't marked as "seen"
@@ -596,7 +620,7 @@ class NotificationsManager {
                        intval(local_user())
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        return $r[0]['total'];
 
                return 0;
@@ -604,13 +628,13 @@ class NotificationsManager {
 
        /**
         * @brief Get home notifications
-        * 
+        *
         * @param int|string $seen
         *      If 0 only include notifications into the query
         *      which aren't marked as "seen"
         * @param int $start Start the query at this point
         * @param int $limit Maximum number of query results
-        * 
+        *
         * @return array with
         *      string 'ident' => Notification identifier
         *      int 'total' => Total number of available home notifications
@@ -626,9 +650,9 @@ class NotificationsManager {
                        $sql_seen = " AND `item`.`unseen` = 1 ";
 
                $r = q("SELECT `item`.`id`,`item`.`parent`, `item`.`verb`, `item`.`author-name`, `item`.`unseen`,
-                               `item`.`author-link`, `item`.`author-avatar`, `item`.`created`, `item`.`object` as `object`,
-                               `pitem`.`author-name` as `pname`, `pitem`.`author-link` as `plink`, `pitem`.`guid` as `pguid`
-                       FROM `item` INNER JOIN `item` as `pitem` ON `pitem`.`id`=`item`.`parent`
+                               `item`.`author-link`, `item`.`author-avatar`, `item`.`created`, `item`.`object` AS `object`,
+                               `pitem`.`author-name` AS `pname`, `pitem`.`author-link` AS `plink`, `pitem`.`guid` AS `pguid`
+                       FROM `item` INNER JOIN `item` AS `pitem` ON `pitem`.`id`=`item`.`parent`
                        WHERE `item`.`visible` = 1 AND
                                 `item`.`deleted` = 0 AND `item`.`uid` = %d AND `item`.`wall` = 1
                                $sql_seen
@@ -638,7 +662,7 @@ class NotificationsManager {
                                intval($limit)
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        $notifs = $this->formatNotifs($r, $ident);
 
                $arr = array (
@@ -651,7 +675,7 @@ class NotificationsManager {
        }
 
        /**
-        * @brief Total number of introductions 
+        * @brief Total number of introductions
         * @param bool $all
         *      If false only include introductions into the query
         *      which aren't marked as ignored
@@ -668,7 +692,7 @@ class NotificationsManager {
                                intval($_SESSION['uid'])
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        return $r[0]['total'];
 
                return 0;
@@ -676,13 +700,13 @@ class NotificationsManager {
 
        /**
         * @brief Get introductions
-        * 
+        *
         * @param bool $all
         *      If false only include introductions into the query
         *      which aren't marked as ignored
         * @param int $start Start the query at this point
         * @param int $limit Maximum number of query results
-        * 
+        *
         * @return array with
         *      string 'ident' => Notification identifier
         *      int 'total' => Total number of available introductions
@@ -698,10 +722,12 @@ class NotificationsManager {
                        $sql_extra = " AND `ignore` = 0 ";
 
                /// @todo Fetch contact details by "get_contact_details_by_url" instead of queries to contact, fcontact and gcontact
-               $r = q("SELECT `intro`.`id` AS `intro_id`, `intro`.*, `contact`.*, `fcontact`.`name` AS `fname`,`fcontact`.`url` AS `furl`,`fcontact`.`photo` AS `fphoto`,`fcontact`.`request` AS `frequest`,
+               $r = q("SELECT `intro`.`id` AS `intro_id`, `intro`.*, `contact`.*,
+                               `fcontact`.`name` AS `fname`, `fcontact`.`url` AS `furl`,
+                               `fcontact`.`photo` AS `fphoto`, `fcontact`.`request` AS `frequest`,
                                `gcontact`.`location` AS `glocation`, `gcontact`.`about` AS `gabout`,
                                `gcontact`.`keywords` AS `gkeywords`, `gcontact`.`gender` AS `ggender`,
-                               `gcontact`.`network` AS `gnetwork`
+                               `gcontact`.`network` AS `gnetwork`, `gcontact`.`addr` AS `gaddr`
                        FROM `intro`
                                LEFT JOIN `contact` ON `contact`.`id` = `intro`.`contact-id`
                                LEFT JOIN `gcontact` ON `gcontact`.`nurl` = `contact`.`nurl`
@@ -713,7 +739,7 @@ class NotificationsManager {
                                intval($limit)
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        $notifs = $this->formatIntros($r);
 
                $arr = array (
@@ -727,7 +753,7 @@ class NotificationsManager {
 
        /**
         * @brief Format the notification query in an usable array
-        * 
+        *
         * @param array $intros The array from the db query
         * @return array with the introductions
         */
@@ -764,11 +790,7 @@ class NotificationsManager {
                        // Normal connection requests
                        } else {
 
-                               // Probe the contact url to get missing data
-                               $ret = probe_url($it["url"]);
-
-                               if ($it['gnetwork'] == "")
-                                       $it['gnetwork'] = $ret["network"];
+                               $it = $this->getMissingIntroData($it);
 
                                // Don't show these data until you are connected. Diaspora is doing the same.
                                if($it['gnetwork'] === NETWORK_DIASPORA) {
@@ -793,7 +815,7 @@ class NotificationsManager {
                                        'post_newfriend' => (intval(get_pconfig(local_user(),'system','post_newfriend')) ? '1' : 0),
                                        'url' => $it['url'],
                                        'zrl' => zrl($it['url']),
-                                       'addr' => $ret['addr'],
+                                       'addr' => $it['gaddr'],
                                        'network' => $it['gnetwork'],
                                        'knowyou' => $it['knowyou'],
                                        'note' => $it['note'],
@@ -805,4 +827,38 @@ class NotificationsManager {
 
                return $arr;
        }
+
+       /**
+        * @brief Check for missing contact data and try to fetch the data from
+        *     from other sources
+        *
+        * @param array $arr The input array with the intro data
+        *
+        * @return array The array with the intro data
+        */
+       private function getMissingIntroData($arr) {
+               // If the network and the addr isn't available from the gcontact
+               // table entry, take the one of the contact table entry
+               if ($arr['gnetwork'] == "") {
+                       $arr['gnetwork'] = $arr['network'];
+               }
+               if ($arr['gaddr'] == "") {
+                       $arr['gaddr'] = $arr['addr'];
+               }
+
+               // If the network and addr is still not available
+               // get the missing data data from other sources
+               if ($arr['gnetwork'] == "" || $arr['gaddr'] == "") {
+                       $ret = get_contact_details_by_url($arr['url']);
+
+                       if ($arr['gnetwork'] == "" && $ret['network'] != "") {
+                               $arr['gnetwork'] = $ret['network'];
+                       }
+                       if ($arr['gaddr'] == "" && $ret['addr'] != "") {
+                               $arr['gaddr'] = $ret['addr'];
+                       }
+               }
+
+               return $arr;
+       }
 }