]> git.mxchange.org Git - friendica.git/blobdiff - include/NotificationsManager.php
Merge pull request #3254 from Quix0r/rewrites/coding-convention-split2
[friendica.git] / include / NotificationsManager.php
index 87c72536c4a72f9c9745279c3c04dfac51b4ac4e..611860f9d08b68e9e115dc46d55d9cf6beb96230 100644 (file)
@@ -7,7 +7,6 @@
 require_once('include/html2plain.php');
 require_once("include/datetime.php");
 require_once("include/bbcode.php");
-require_once("include/dbm.php");
 
 /**
  * @brief Methods for read and write notifications from/to database
@@ -82,12 +81,16 @@ class NotificationsManager {
                }
                $order_sql = implode(", ", $asOrder);
 
-               if ($limit!="") $limit = " LIMIT ".$limit;
+               if($limit!="")
+                       $limit = " LIMIT ".$limit;
 
                        $r = q("SELECT * FROM `notify` WHERE `uid` = %d $filter_sql ORDER BY $order_sql $limit",
                                intval(local_user())
                        );
-               if ($r!==false && count($r)>0) return $this->_set_extra($r);
+
+               if (dbm::is_result($r))
+                       return $this->_set_extra($r);
+
                return false;
        }
 
@@ -102,7 +105,7 @@ class NotificationsManager {
                        intval($id),
                        intval(local_user())
                );
-               if($r!==false && count($r)>0) {
+               if (dbm::is_result($r)) {
                        return $this->_set_extra($r)[0];
                }
                return null;
@@ -195,8 +198,10 @@ class NotificationsManager {
         *      string 'label' => The type of the notification
         *      string 'link' => URL to the source
         *      string 'image' => The avatar image
+        *      string 'url' => The profile url of the contact
         *      string 'text' => The notification text
-        *      string 'when' => Relative date of the notification
+        *      string 'when' => The date of the notification
+        *      string 'ago' => T relative date of the notification
         *      bool 'seen' => Is the notification marked as "seen"
         */
        private function formatNotifs($notifs, $ident = "") {
@@ -210,8 +215,9 @@ class NotificationsManager {
                                // Because we use different db tables for the notification query
                                // we have sometimes $it['unseen'] and sometimes $it['seen].
                                // So we will have to transform $it['unseen']
-                               if($it['unseen'])
+                               if (array_key_exists('unseen', $it)) {
                                        $it['seen'] = ($it['unseen'] > 0 ? false : true);
+                               }
 
                                // Depending on the identifier of the notification we need to use different defaults
                                switch ($ident) {
@@ -219,41 +225,46 @@ class NotificationsManager {
                                                $default_item_label = 'notify';
                                                $default_item_link = $this->a->get_baseurl(true).'/notify/view/'. $it['id'];
                                                $default_item_image = proxy_url($it['photo'], false, PROXY_SIZE_MICRO);
+                                               $default_item_url = $it['url'];
                                                $default_item_text = strip_tags(bbcode($it['msg']));
-                                               $default_item_when = relative_date($it['date']);
-                                               $default_tpl = $tpl_notify;
+                                               $default_item_when = datetime_convert('UTC', date_default_timezone_get(), $it['date'], 'r');
+                                               $default_item_ago = relative_date($it['date']);
                                                break;
 
                                        case 'home':
                                                $default_item_label = 'comment';
                                                $default_item_link = $this->a->get_baseurl(true).'/display/'.$it['pguid'];
                                                $default_item_image = proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO);
-                                               $default_item_text = sprintf( t("%s commented on %s's post"), $it['author-name'], $it['pname']);
-                                               $default_item_when = relative_date($it['created']);
-                                               $default_tpl = $tpl_item_comments;
+                                               $default_item_url = $it['author-link'];
+                                               $default_item_text = sprintf(t("%s commented on %s's post"), $it['author-name'], $it['pname']);
+                                               $default_item_when = datetime_convert('UTC', date_default_timezone_get(), $it['created'], 'r');
+                                               $default_item_ago = relative_date($it['created']);
                                                break;
 
                                        default:
                                                $default_item_label = (($it['id'] == $it['parent']) ? 'post' : 'comment');
                                                $default_item_link = $this->a->get_baseurl(true).'/display/'.$it['pguid'];
                                                $default_item_image = proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO);
+                                               $default_item_url = $it['author-link'];
                                                $default_item_text = (($it['id'] == $it['parent'])
-                                                                       ? sprintf( t("%s created a new post"), $it['author-name'])
-                                                                       : sprintf( t("%s commented on %s's post"), $it['author-name'], $it['pname']));
-                                               $default_item_when = relative_date($it['created']);
-                                               $default_tpl = (($it['id'] == $it['parent']) ? $tpl_item_posts : $tpl_item_comments);
+                                                                       ? sprintf(t("%s created a new post"), $it['author-name'])
+                                                                       : sprintf(t("%s commented on %s's post"), $it['author-name'], $it['pname']));
+                                               $default_item_when = datetime_convert('UTC', date_default_timezone_get(), $it['created'], 'r');
+                                               $default_item_ago = relative_date($it['created']);
 
                                }
 
                                // Transform the different types of notification in an usable array
-                               switch($it['verb']){
+                               switch ($it['verb']){
                                        case ACTIVITY_LIKE:
                                                $notif = array(
                                                        'label' => 'like',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
-                                                       '$image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
-                                                       'text' => sprintf( t("%s liked %s's post"), $it['author-name'], $it['pname']),
-                                                       'when' => relative_date($it['created']),
+                                                       'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
+                                                       'url' => $it['author-link'],
+                                                       'text' => sprintf(t("%s liked %s's post"), $it['author-name'], $it['pname']),
+                                                       'when' => $default_item_when,
+                                                       'ago' => $default_item_ago,
                                                        'seen' => $it['seen']
                                                );
                                                break;
@@ -263,8 +274,10 @@ class NotificationsManager {
                                                        'label' => 'dislike',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
-                                                       'text' => sprintf( t("%s disliked %s's post"), $it['author-name'], $it['pname']),
-                                                       'when' => relative_date($it['created']),
+                                                       'url' => $it['author-link'],
+                                                       'text' => sprintf(t("%s disliked %s's post"), $it['author-name'], $it['pname']),
+                                                       'when' => $default_item_when,
+                                                       'ago' => $default_item_ago,
                                                        'seen' => $it['seen']
                                                );
                                                break;
@@ -274,8 +287,10 @@ class NotificationsManager {
                                                        'label' => 'attend',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
-                                                       'text' => sprintf( t("%s is attending %s's event"), $it['author-name'], $it['pname']),
-                                                       'when' => relative_date($it['created']),
+                                                       'url' => $it['author-link'],
+                                                       'text' => sprintf(t("%s is attending %s's event"), $it['author-name'], $it['pname']),
+                                                       'when' => $default_item_when,
+                                                       'ago' => $default_item_ago,
                                                        'seen' => $it['seen']
                                                );
                                                break;
@@ -285,8 +300,10 @@ class NotificationsManager {
                                                        'label' => 'attendno',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
+                                                       'url' => $it['author-link'],
                                                        'text' => sprintf( t("%s is not attending %s's event"), $it['author-name'], $it['pname']),
-                                                       'when' => relative_date($it['created']),
+                                                       'when' => $default_item_when,
+                                                       'ago' => $default_item_ago,
                                                        'seen' => $it['seen']
                                                );
                                                break;
@@ -296,8 +313,10 @@ class NotificationsManager {
                                                        'label' => 'attendmaybe',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
-                                                       'text' => sprintf( t("%s may attend %s's event"), $it['author-name'], $it['pname']),
-                                                       'when' => relative_date($it['created']),
+                                                       'url' => $it['author-link'],
+                                                       'text' => sprintf(t("%s may attend %s's event"), $it['author-name'], $it['pname']),
+                                                       'when' => $default_item_when,
+                                                       'ago' => $default_item_ago,
                                                        'seen' => $it['seen']
                                                );
                                                break;
@@ -311,8 +330,10 @@ class NotificationsManager {
                                                        'label' => 'friend',
                                                        'link' => $this->a->get_baseurl(true).'/display/'.$it['pguid'],
                                                        'image' => proxy_url($it['author-avatar'], false, PROXY_SIZE_MICRO),
-                                                       'text' => sprintf( t("%s is now friends with %s"), $it['author-name'], $it['fname']),
-                                                       'when' => relative_date($it['created']),
+                                                       'url' => $it['author-link'],
+                                                       'text' => sprintf(t("%s is now friends with %s"), $it['author-name'], $it['fname']),
+                                                       'when' => $default_item_when,
+                                                       'ago' => $default_item_ago,
                                                        'seen' => $it['seen']
                                                );
                                                break;
@@ -322,8 +343,10 @@ class NotificationsManager {
                                                        'label' => $default_item_label,
                                                        'link' => $default_item_link,
                                                        'image' => $default_item_image,
+                                                       'url' => $default_item_url,
                                                        'text' => $default_item_text,
                                                        'when' => $default_item_when,
+                                                       'ago' => $default_item_ago,
                                                        'seen' => $it['seen']
                                                );
                                }
@@ -344,6 +367,8 @@ class NotificationsManager {
         * @return int Number of network notifications
         */
        private function networkTotal($seen = 0) {
+               $sql_seen = "";
+
                if($seen === 0)
                        $sql_seen = " AND `item`.`unseen` = 1 ";
 
@@ -355,7 +380,7 @@ class NotificationsManager {
                        intval(local_user())
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        return $r[0]['total'];
 
                return 0;
@@ -379,6 +404,7 @@ class NotificationsManager {
                $ident = 'network';
                $total = $this->networkTotal($seen);
                $notifs = array();
+               $sql_seen = "";
 
                if($seen === 0)
                        $sql_seen = " AND `item`.`unseen` = 1 ";
@@ -397,7 +423,7 @@ class NotificationsManager {
                                intval($limit)
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        $notifs = $this->formatNotifs($r, $ident);
 
                $arr = array (
@@ -417,6 +443,8 @@ class NotificationsManager {
         * @return int Number of system notifications
         */
        private function systemTotal($seen = 0) {
+               $sql_seen = "";
+
                if($seen === 0)
                        $sql_seen = " AND `seen` = 0 ";
 
@@ -424,7 +452,7 @@ class NotificationsManager {
                        intval(local_user())
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        return $r[0]['total'];
 
                return 0;
@@ -448,18 +476,19 @@ class NotificationsManager {
                $ident = 'system';
                $total = $this->systemTotal($seen);
                $notifs = array();
+               $sql_seen = "";
 
                if($seen === 0)
                        $sql_seen = " AND `seen` = 0 ";
 
-               $r = q("SELECT `id`, `photo`, `msg`, `date`, `seen` FROM `notify`
+               $r = q("SELECT `id`, `url`, `photo`, `msg`, `date`, `seen` FROM `notify`
                                WHERE `uid` = %d $sql_seen ORDER BY `date` DESC LIMIT %d, %d ",
                        intval(local_user()),
                        intval($start),
                        intval($limit)
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        $notifs = $this->formatNotifs($r, $ident);
 
                $arr = array (
@@ -481,7 +510,7 @@ class NotificationsManager {
                $myurl = substr($myurl,strpos($myurl,'://')+3);
                $myurl = str_replace(array('www.','.'),array('','\\.'),$myurl);
                $diasp_url = str_replace('/profile/','/u/',$myurl);
-               $sql_extra .= sprintf(" AND ( `item`.`author-link` regexp '%s' or `item`.`tag` regexp '%s' or `item`.`tag` regexp '%s' ) ",
+               $sql_extra = sprintf(" AND ( `item`.`author-link` regexp '%s' or `item`.`tag` regexp '%s' or `item`.`tag` regexp '%s' ) ",
                        dbesc($myurl . '$'),
                        dbesc($myurl . '\\]'),
                        dbesc($diasp_url . '\\]')
@@ -498,7 +527,8 @@ class NotificationsManager {
         * @return int Number of personal notifications
         */
        private function personalTotal($seen = 0) {
-               $sql_extra .= $this->_personal_sql_extra();
+               $sql_seen = "";
+               $sql_extra = $this->_personal_sql_extra();
 
                if($seen === 0)
                        $sql_seen = " AND `item`.`unseen` = 1 ";
@@ -512,7 +542,7 @@ class NotificationsManager {
                        intval(local_user())
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        return $r[0]['total'];
 
                return 0;
@@ -535,15 +565,16 @@ class NotificationsManager {
        public function personalNotifs($seen = 0, $start = 0, $limit = 80) {
                $ident = 'personal';
                $total = $this->personalTotal($seen);
-               $sql_extra .= $this->_personal_sql_extra();
+               $sql_extra = $this->_personal_sql_extra();
                $notifs = array();
+               $sql_seen = "";
 
                if($seen === 0)
                        $sql_seen = " AND `item`.`unseen` = 1 ";
 
                $r = q("SELECT `item`.`id`,`item`.`parent`, `item`.`verb`, `item`.`author-name`, `item`.`unseen`,
                                `item`.`author-link`, `item`.`author-avatar`, `item`.`created`, `item`.`object` AS `object`, 
-                               `pitem`.`author-name` AS `pname`, `pitem`.`author-link` AS `plink`, `pitem`.`guid` AS `pguid`, 
+                               `pitem`.`author-name` AS `pname`, `pitem`.`author-link` AS `plink`, `pitem`.`guid` AS `pguid` 
                        FROM `item` INNER JOIN `item` AS `pitem` ON  `pitem`.`id`=`item`.`parent`
                        WHERE `item`.`visible` = 1
                                $sql_extra
@@ -555,7 +586,7 @@ class NotificationsManager {
                                intval($limit)
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        $notifs = $this->formatNotifs($r, $ident);
                
                $arr = array (
@@ -575,6 +606,8 @@ class NotificationsManager {
         * @return int Number of home notifications
         */
        private function homeTotal($seen = 0) {
+               $sql_seen = "";
+
                if($seen === 0)
                        $sql_seen = " AND `item`.`unseen` = 1 ";
 
@@ -585,7 +618,7 @@ class NotificationsManager {
                        intval(local_user())
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        return $r[0]['total'];
 
                return 0;
@@ -609,14 +642,15 @@ class NotificationsManager {
                $ident = 'home';
                $total = $this->homeTotal($seen);
                $notifs = array();
+               $sql_seen = "";
 
                if($seen === 0)
                        $sql_seen = " AND `item`.`unseen` = 1 ";
 
                $r = q("SELECT `item`.`id`,`item`.`parent`, `item`.`verb`, `item`.`author-name`, `item`.`unseen`,
-                               `item`.`author-link`, `item`.`author-avatar`, `item`.`created`, `item`.`object` as `object`,
-                               `pitem`.`author-name` as `pname`, `pitem`.`author-link` as `plink`, `pitem`.`guid` as `pguid`
-                       FROM `item` INNER JOIN `item` as `pitem` ON `pitem`.`id`=`item`.`parent`
+                               `item`.`author-link`, `item`.`author-avatar`, `item`.`created`, `item`.`object` AS `object`,
+                               `pitem`.`author-name` AS `pname`, `pitem`.`author-link` AS `plink`, `pitem`.`guid` AS `pguid`
+                       FROM `item` INNER JOIN `item` AS `pitem` ON `pitem`.`id`=`item`.`parent`
                        WHERE `item`.`visible` = 1 AND
                                 `item`.`deleted` = 0 AND `item`.`uid` = %d AND `item`.`wall` = 1
                                $sql_seen
@@ -626,7 +660,7 @@ class NotificationsManager {
                                intval($limit)
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        $notifs = $this->formatNotifs($r, $ident);
 
                $arr = array (
@@ -640,13 +674,15 @@ class NotificationsManager {
 
        /**
         * @brief Total number of introductions 
-        * @param int $all
-        *      If 0 only include introductions into the query
+        * @param bool $all
+        *      If false only include introductions into the query
         *      which aren't marked as ignored
         * @return int Number of introductions
         */
-       private function introTotal($all) {
-               if($all === 0)
+       private function introTotal($all = false) {
+               $sql_extra = "";
+
+               if(!$all)
                        $sql_extra = " AND `ignore` = 0 ";
 
                $r = q("SELECT COUNT(*) AS `total` FROM `intro`
@@ -654,7 +690,7 @@ class NotificationsManager {
                                intval($_SESSION['uid'])
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        return $r[0]['total'];
 
                return 0;
@@ -663,8 +699,8 @@ class NotificationsManager {
        /**
         * @brief Get introductions
         * 
-        * @param int $all
-        *      If 0 only include introductions into the query
+        * @param bool $all
+        *      If false only include introductions into the query
         *      which aren't marked as ignored
         * @param int $start Start the query at this point
         * @param int $limit Maximum number of query results
@@ -674,12 +710,13 @@ class NotificationsManager {
         *      int 'total' => Total number of available introductions
         *      array 'notifications' => Introductions
         */
-       public function introNotifs($all = 0, $start = 0, $limit = 80) {
+       public function introNotifs($all = false, $start = 0, $limit = 80) {
                $ident = 'introductions';
                $total = $this->introTotal($seen);
                $notifs = array();
+               $sql_extra = "";
 
-               if($all === 0)
+               if(!$all)
                        $sql_extra = " AND `ignore` = 0 ";
 
                /// @todo Fetch contact details by "get_contact_details_by_url" instead of queries to contact, fcontact and gcontact
@@ -698,7 +735,7 @@ class NotificationsManager {
                                intval($limit)
                );
 
-               if(dbm::is_result($r))
+               if (dbm::is_result($r))
                        $notifs = $this->formatIntros($r);
 
                $arr = array (