]> git.mxchange.org Git - friendica.git/blobdiff - include/api.php
Rename properly
[friendica.git] / include / api.php
index 58f086c012d829734b40d11bb54c5bfe41416e7d..0f7fa85bdde551dcdb0c2a4ccdfb19e3b254d3fc 100644 (file)
@@ -12,14 +12,16 @@ use Friendica\Content\Feature;
 use Friendica\Content\Text\BBCode;
 use Friendica\Content\Text\HTML;
 use Friendica\Core\Addon;
+use Friendica\Core\Authentication;
 use Friendica\Core\Config;
 use Friendica\Core\L10n;
+use Friendica\Core\Logger;
 use Friendica\Core\NotificationsManager;
 use Friendica\Core\PConfig;
 use Friendica\Core\Protocol;
 use Friendica\Core\System;
 use Friendica\Core\Worker;
-use Friendica\Database\DBM;
+use Friendica\Database\DBA;
 use Friendica\Model\Contact;
 use Friendica\Model\Group;
 use Friendica\Model\Item;
@@ -40,14 +42,13 @@ use Friendica\Object\Image;
 use Friendica\Protocol\Diaspora;
 use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
+use Friendica\Util\Proxy as ProxyUtils;
 use Friendica\Util\XML;
 
 require_once 'include/conversation.php';
 require_once 'mod/share.php';
 require_once 'mod/item.php';
-require_once 'include/security.php';
 require_once 'mod/wall_upload.php';
-require_once 'mod/proxy.php';
 
 define('API_METHOD_ANY', '*');
 define('API_METHOD_GET', 'GET');
@@ -96,9 +97,9 @@ function api_source()
                        return "Twidere";
                }
 
-               logger("Unrecognized user-agent ".$_SERVER['HTTP_USER_AGENT'], LOGGER_DEBUG);
+               Logger::log("Unrecognized user-agent ".$_SERVER['HTTP_USER_AGENT'], Logger::DEBUG);
        } else {
-               logger("Empty user-agent", LOGGER_DEBUG);
+               Logger::log("Empty user-agent", Logger::DEBUG);
        }
 
        return "api";
@@ -180,7 +181,7 @@ function api_login(App $a)
                var_dump($consumer, $token);
                die();
        } catch (Exception $e) {
-               logger($e);
+               Logger::log($e);
        }
 
        // workaround for HTTP-auth in CGI mode
@@ -194,7 +195,7 @@ function api_login(App $a)
        }
 
        if (!x($_SERVER, 'PHP_AUTH_USER')) {
-               logger('API_login: ' . print_r($_SERVER, true), LOGGER_DEBUG);
+               Logger::log('API_login: ' . print_r($_SERVER, true), Logger::DEBUG);
                header('WWW-Authenticate: Basic realm="Friendica"');
                throw new UnauthorizedException("This API requires login");
        }
@@ -230,19 +231,19 @@ function api_login(App $a)
        } else {
                $user_id = User::authenticate(trim($user), trim($password));
                if ($user_id !== false) {
-                       $record = dba::selectFirst('user', [], ['uid' => $user_id]);
+                       $record = DBA::selectFirst('user', [], ['uid' => $user_id]);
                }
        }
 
-       if (!DBM::is_result($record)) {
-               logger('API_login failure: ' . print_r($_SERVER, true), LOGGER_DEBUG);
+       if (!DBA::isResult($record)) {
+               Logger::log('API_login failure: ' . print_r($_SERVER, true), Logger::DEBUG);
                header('WWW-Authenticate: Basic realm="Friendica"');
                //header('HTTP/1.0 401 Unauthorized');
                //die('This api requires login');
                throw new UnauthorizedException("This API requires login");
        }
 
-       authenticate_success($record);
+       Authentication::setAuthenticatedSessionForUser($record);
 
        $_SESSION["allow_api"] = true;
 
@@ -308,19 +309,19 @@ function api_call(App $a)
                                        api_login($a);
                                }
 
-                               logger('API call for ' . $a->user['username'] . ': ' . $a->query_string);
-                               logger('API parameters: ' . print_r($_REQUEST, true));
+                               Logger::log('API call for ' . $a->user['username'] . ': ' . $a->query_string);
+                               Logger::log('API parameters: ' . print_r($_REQUEST, true));
 
                                $stamp =  microtime(true);
                                $return = call_user_func($info['func'], $type);
                                $duration = (float) (microtime(true) - $stamp);
-                               logger("API call duration: " . round($duration, 2) . "\t" . $a->query_string, LOGGER_DEBUG);
+                               Logger::log("API call duration: " . round($duration, 2) . "\t" . $a->query_string, Logger::DEBUG);
 
                                if (Config::get("system", "profiler")) {
                                        $duration = microtime(true)-$a->performance["start"];
 
                                        /// @TODO round() really everywhere?
-                                       logger(
+                                       Logger::log(
                                                parse_url($a->query_string, PHP_URL_PATH) . ": " . sprintf(
                                                        "Database: %s/%s, Cache %s/%s, Network: %s, I/O: %s, Other: %s, Total: %s",
                                                        round($a->performance["database"] - $a->performance["database_write"], 3),
@@ -334,7 +335,7 @@ function api_call(App $a)
                                                                + $a->performance["network"] + $a->performance["file"]), 2),
                                                        round($duration, 2)
                                                ),
-                                               LOGGER_DEBUG
+                                               Logger::DEBUG
                                        );
 
                                        if (Config::get("rendertime", "callstack")) {
@@ -375,7 +376,7 @@ function api_call(App $a)
                                                                $o .= $func . ": " . $time . "\n";
                                                        }
                                                }
-                                               logger($o, LOGGER_DEBUG);
+                                               Logger::log($o, Logger::DEBUG);
                                        }
                                }
 
@@ -412,7 +413,7 @@ function api_call(App $a)
                        }
                }
 
-               logger('API call not implemented: ' . $a->query_string);
+               Logger::log('API call not implemented: ' . $a->query_string);
                throw new NotImplementedException();
        } catch (HTTPException $e) {
                header("HTTP/1.1 {$e->httpcode} {$e->httpdesc}");
@@ -498,9 +499,9 @@ function api_rss_extra(App $a, $arr, $user_info)
  */
 function api_unique_id_to_nurl($id)
 {
-       $r = dba::selectFirst('contact', ['nurl'], ['id' => $id]);
+       $r = DBA::selectFirst('contact', ['nurl'], ['id' => $id]);
 
-       if (DBM::is_result($r)) {
+       if (DBA::isResult($r)) {
                return $r["nurl"];
        } else {
                return false;
@@ -521,11 +522,11 @@ function api_get_user(App $a, $contact_id = null)
        $extra_query = "";
        $url = "";
 
-       logger("api_get_user: Fetching user data for user ".$contact_id, LOGGER_DEBUG);
+       Logger::log("api_get_user: Fetching user data for user ".$contact_id, Logger::DEBUG);
 
        // Searching for contact URL
        if (!is_null($contact_id) && (intval($contact_id) == 0)) {
-               $user = dbesc(normalise_link($contact_id));
+               $user = DBA::escape(normalise_link($contact_id));
                $url = $user;
                $extra_query = "AND `contact`.`nurl` = '%s' ";
                if (api_user() !== false) {
@@ -535,7 +536,7 @@ function api_get_user(App $a, $contact_id = null)
 
        // Searching for contact id with uid = 0
        if (!is_null($contact_id) && (intval($contact_id) != 0)) {
-               $user = dbesc(api_unique_id_to_nurl(intval($contact_id)));
+               $user = DBA::escape(api_unique_id_to_nurl(intval($contact_id)));
 
                if ($user == "") {
                        throw new BadRequestException("User ID ".$contact_id." not found.");
@@ -549,7 +550,7 @@ function api_get_user(App $a, $contact_id = null)
        }
 
        if (is_null($user) && x($_GET, 'user_id')) {
-               $user = dbesc(api_unique_id_to_nurl($_GET['user_id']));
+               $user = DBA::escape(api_unique_id_to_nurl($_GET['user_id']));
 
                if ($user == "") {
                        throw new BadRequestException("User ID ".$_GET['user_id']." not found.");
@@ -562,7 +563,7 @@ function api_get_user(App $a, $contact_id = null)
                }
        }
        if (is_null($user) && x($_GET, 'screen_name')) {
-               $user = dbesc($_GET['screen_name']);
+               $user = DBA::escape($_GET['screen_name']);
                $extra_query = "AND `contact`.`nick` = '%s' ";
                if (api_user() !== false) {
                        $extra_query .= "AND `contact`.`uid`=".intval(api_user());
@@ -570,7 +571,7 @@ function api_get_user(App $a, $contact_id = null)
        }
 
        if (is_null($user) && x($_GET, 'profileurl')) {
-               $user = dbesc(normalise_link($_GET['profileurl']));
+               $user = DBA::escape(normalise_link($_GET['profileurl']));
                $extra_query = "AND `contact`.`nurl` = '%s' ";
                if (api_user() !== false) {
                        $extra_query .= "AND `contact`.`uid`=".intval(api_user());
@@ -581,10 +582,13 @@ function api_get_user(App $a, $contact_id = null)
        if (is_null($user) && ($a->argc > (count($called_api) - 1)) && (count($called_api) > 0)) {
                $argid = count($called_api);
                if (!empty($a->argv[$argid])) {
-                       list($user, $null) = explode(".", $a->argv[$argid]);
+                       $data = explode(".", $a->argv[$argid]);
+                       if (count($data) > 1) {
+                               list($user, $null) = $data;
+                       }
                }
                if (is_numeric($user)) {
-                       $user = dbesc(api_unique_id_to_nurl(intval($user)));
+                       $user = DBA::escape(api_unique_id_to_nurl(intval($user)));
 
                        if ($user != "") {
                                $url = $user;
@@ -594,7 +598,7 @@ function api_get_user(App $a, $contact_id = null)
                                }
                        }
                } else {
-                       $user = dbesc($user);
+                       $user = DBA::escape($user);
                        $extra_query = "AND `contact`.`nick` = '%s' ";
                        if (api_user() !== false) {
                                $extra_query .= "AND `contact`.`uid`=" . intval(api_user());
@@ -602,7 +606,7 @@ function api_get_user(App $a, $contact_id = null)
                }
        }
 
-       logger("api_get_user: user ".$user, LOGGER_DEBUG);
+       Logger::log("api_get_user: user ".$user, Logger::DEBUG);
 
        if (!$user) {
                if (api_user() === false) {
@@ -614,7 +618,7 @@ function api_get_user(App $a, $contact_id = null)
                }
        }
 
-       logger('api_user: ' . $extra_query . ', user: ' . $user);
+       Logger::log('api_user: ' . $extra_query . ', user: ' . $user);
 
        // user info
        $uinfo = q(
@@ -630,38 +634,38 @@ function api_get_user(App $a, $contact_id = null)
        }
 
        // if the contact wasn't found, fetch it from the contacts with uid = 0
-       if (!DBM::is_result($uinfo)) {
-               $r = [];
-
-               if ($url != "") {
-                       $r = q("SELECT * FROM `contact` WHERE `uid` = 0 AND `nurl` = '%s' LIMIT 1", dbesc(normalise_link($url)));
+       if (!DBA::isResult($uinfo)) {
+               if ($url == "") {
+                       throw new BadRequestException("User not found.");
                }
 
-               if (DBM::is_result($r)) {
-                       $network_name = ContactSelector::networkToName($r[0]['network'], $r[0]['url']);
+               $contact = DBA::selectFirst('contact', [], ['uid' => 0, 'nurl' => normalise_link($url)]);
+
+               if (DBA::isResult($contact)) {
+                       $network_name = ContactSelector::networkToName($contact['network'], $contact['url']);
 
                        // If no nick where given, extract it from the address
-                       if (($r[0]['nick'] == "") || ($r[0]['name'] == $r[0]['nick'])) {
-                               $r[0]['nick'] = api_get_nick($r[0]["url"]);
+                       if (($contact['nick'] == "") || ($contact['name'] == $contact['nick'])) {
+                               $contact['nick'] = api_get_nick($contact["url"]);
                        }
 
                        $ret = [
-                               'id' => $r[0]["id"],
-                               'id_str' => (string) $r[0]["id"],
-                               'name' => $r[0]["name"],
-                               'screen_name' => (($r[0]['nick']) ? $r[0]['nick'] : $r[0]['name']),
-                               'location' => ($r[0]["location"] != "") ? $r[0]["location"] : $network_name,
-                               'description' => $r[0]["about"],
-                               'profile_image_url' => $r[0]["micro"],
-                               'profile_image_url_https' => $r[0]["micro"],
-                               'profile_image_url_profile_size' => $r[0]["thumb"],
-                               'profile_image_url_large' => $r[0]["photo"],
-                               'url' => $r[0]["url"],
+                               'id' => $contact["id"],
+                               'id_str' => (string) $contact["id"],
+                               'name' => $contact["name"],
+                               'screen_name' => (($contact['nick']) ? $contact['nick'] : $contact['name']),
+                               'location' => ($contact["location"] != "") ? $contact["location"] : $network_name,
+                               'description' => $contact["about"],
+                               'profile_image_url' => $contact["micro"],
+                               'profile_image_url_https' => $contact["micro"],
+                               'profile_image_url_profile_size' => $contact["thumb"],
+                               'profile_image_url_large' => $contact["photo"],
+                               'url' => $contact["url"],
                                'protected' => false,
                                'followers_count' => 0,
                                'friends_count' => 0,
                                'listed_count' => 0,
-                               'created_at' => api_date($r[0]["created"]),
+                               'created_at' => api_date($contact["created"]),
                                'favourites_count' => 0,
                                'utc_offset' => 0,
                                'time_zone' => 'UTC',
@@ -676,12 +680,12 @@ function api_get_user(App $a, $contact_id = null)
                                'follow_request_sent' => false,
                                'statusnet_blocking' => false,
                                'notifications' => false,
-                               'statusnet_profile_url' => $r[0]["url"],
+                               'statusnet_profile_url' => $contact["url"],
                                'uid' => 0,
-                               'cid' => Contact::getIdForURL($r[0]["url"], api_user(), true),
-                               'pid' => Contact::getIdForURL($r[0]["url"], 0, true),
+                               'cid' => Contact::getIdForURL($contact["url"], api_user(), true),
+                               'pid' => Contact::getIdForURL($contact["url"], 0, true),
                                'self' => 0,
-                               'network' => $r[0]["network"],
+                               'network' => $contact["network"],
                        ];
 
                        return $ret;
@@ -692,11 +696,11 @@ function api_get_user(App $a, $contact_id = null)
 
        if ($uinfo[0]['self']) {
                if ($uinfo[0]['network'] == "") {
-                       $uinfo[0]['network'] = NETWORK_DFRN;
+                       $uinfo[0]['network'] = Protocol::DFRN;
                }
 
-               $usr = dba::selectFirst('user', ['default-location'], ['uid' => api_user()]);
-               $profile = dba::selectFirst('profile', ['about'], ['uid' => api_user(), 'is-default' => true]);
+               $usr = DBA::selectFirst('user', ['default-location'], ['uid' => api_user()]);
+               $profile = DBA::selectFirst('profile', ['about'], ['uid' => api_user(), 'is-default' => true]);
        }
        $countitems = 0;
        $countfriends = 0;
@@ -753,12 +757,12 @@ function api_get_user(App $a, $contact_id = null)
                'contributors_enabled' => false,
                'is_translator' => false,
                'is_translation_enabled' => false,
-               'following' => (($uinfo[0]['rel'] == CONTACT_IS_FOLLOWER) || ($uinfo[0]['rel'] == CONTACT_IS_FRIEND)),
+               'following' => (($uinfo[0]['rel'] == Contact::FOLLOWER) || ($uinfo[0]['rel'] == Contact::FRIEND)),
                'follow_request_sent' => false,
                'statusnet_blocking' => false,
                'notifications' => false,
                /// @TODO old way?
-               //'statusnet_profile_url' => System::baseUrl()."/contacts/".$uinfo[0]['cid'],
+               //'statusnet_profile_url' => System::baseUrl()."/contact/".$uinfo[0]['cid'],
                'statusnet_profile_url' => $uinfo[0]['url'],
                'uid' => intval($uinfo[0]['uid']),
                'cid' => intval($uinfo[0]['cid']),
@@ -769,7 +773,7 @@ function api_get_user(App $a, $contact_id = null)
 
        // If this is a local user and it uses Frio, we can get its color preferences.
        if ($ret['self']) {
-               $theme_info = dba::selectFirst('user', ['theme'], ['uid' => $ret['uid']]);
+               $theme_info = DBA::selectFirst('user', ['theme'], ['uid' => $ret['uid']]);
                if ($theme_info['theme'] === 'frio') {
                        $schema = PConfig::get($ret['uid'], 'frio', 'schema');
 
@@ -816,7 +820,7 @@ function api_item_get_user(App $a, $item)
        $status_user["protected"] = defaults($item, 'private', 0);
 
        if (defaults($item, 'thr-parent', '') == defaults($item, 'uri', '')) {
-               $owner_user = api_get_user($a, defaults($item, 'author-id', null));
+               $owner_user = api_get_user($a, defaults($item, 'owner-id', null));
        } else {
                $owner_user = $status_user;
        }
@@ -1030,12 +1034,11 @@ function api_statuses_mediap($type)
        $a = get_app();
 
        if (api_user() === false) {
-               logger('api_statuses_update: no user');
+               Logger::log('api_statuses_update: no user');
                throw new ForbiddenException();
        }
        $user_info = api_get_user($a);
 
-       $_REQUEST['type'] = 'wall';
        $_REQUEST['profile_uid'] = api_user();
        $_REQUEST['api_source'] = true;
        $txt = requestdata('status');
@@ -1043,7 +1046,7 @@ function api_statuses_mediap($type)
        //$txt = urldecode(requestdata('status'));
 
        if ((strpos($txt, '<') !== false) || (strpos($txt, '>') !== false)) {
-               $txt = html2bb_video($txt);
+               $txt = HTML::toBBCodeVideo($txt);
                $config = HTMLPurifier_Config::createDefault();
                $config->set('Cache.DefinitionImpl', null);
                $purifier = new HTMLPurifier($config);
@@ -1057,10 +1060,10 @@ function api_statuses_mediap($type)
 
        // now that we have the img url in bbcode we can add it to the status and insert the wall item.
        $_REQUEST['body'] = $txt . "\n\n" . '[url=' . $picture["albumpage"] . '][img]' . $picture["preview"] . "[/img][/url]";
-       item_post($a);
+       $item_id = item_post($a);
 
-       // this should output the last post (the one we just posted).
-       return api_status_show($type);
+       // output the post that we just posted.
+       return api_status_show($type, $item_id);
 }
 
 /// @TODO move this to top of file or somewhere better!
@@ -1076,11 +1079,10 @@ api_register_func('api/statuses/mediap', 'api_statuses_mediap', true, API_METHOD
  */
 function api_statuses_update($type)
 {
-
        $a = get_app();
 
        if (api_user() === false) {
-               logger('api_statuses_update: no user');
+               Logger::log('api_statuses_update: no user');
                throw new ForbiddenException();
        }
 
@@ -1090,7 +1092,7 @@ function api_statuses_update($type)
        if (requestdata('htmlstatus')) {
                $txt = requestdata('htmlstatus');
                if ((strpos($txt, '<') !== false) || (strpos($txt, '>') !== false)) {
-                       $txt = html2bb_video($txt);
+                       $txt = HTML::toBBCodeVideo($txt);
 
                        $config = HTMLPurifier_Config::createDefault();
                        $config->set('Cache.DefinitionImpl', null);
@@ -1124,19 +1126,17 @@ function api_statuses_update($type)
        }
        $_REQUEST['profile_uid'] = api_user();
 
-       if ($parent) {
-               $_REQUEST['type'] = 'net-comment';
-       } else {
+       if (!$parent) {
                // Check for throttling (maximum posts per day, week and month)
                $throttle_day = Config::get('system', 'throttle_limit_day');
                if ($throttle_day > 0) {
                        $datefrom = date(DateTimeFormat::MYSQL, time() - 24*60*60);
 
-                       $condition = ["`uid` = ? AND `wall` AND `created` > ? AND `id` = `parent`", api_user(), $datefrom];
-                       $posts_day = dba::count('item', $condition);
+                       $condition = ["`uid` = ? AND `wall` AND `created` > ?", api_user(), $datefrom];
+                       $posts_day = DBA::count('thread', $condition);
 
                        if ($posts_day > $throttle_day) {
-                               logger('Daily posting limit reached for user '.api_user(), LOGGER_DEBUG);
+                               Logger::log('Daily posting limit reached for user '.api_user(), Logger::DEBUG);
                                // die(api_error($type, L10n::t("Daily posting limit of %d posts reached. The post was rejected.", $throttle_day));
                                throw new TooManyRequestsException(L10n::tt("Daily posting limit of %d post reached. The post was rejected.", "Daily posting limit of %d posts reached. The post was rejected.", $throttle_day));
                        }
@@ -1146,11 +1146,11 @@ function api_statuses_update($type)
                if ($throttle_week > 0) {
                        $datefrom = date(DateTimeFormat::MYSQL, time() - 24*60*60*7);
 
-                       $condition = ["`uid` = ? AND `wall` AND `created` > ? AND `id` = `parent`", api_user(), $datefrom];
-                       $posts_week = dba::count('item', $condition);
+                       $condition = ["`uid` = ? AND `wall` AND `created` > ?", api_user(), $datefrom];
+                       $posts_week = DBA::count('thread', $condition);
 
                        if ($posts_week > $throttle_week) {
-                               logger('Weekly posting limit reached for user '.api_user(), LOGGER_DEBUG);
+                               Logger::log('Weekly posting limit reached for user '.api_user(), Logger::DEBUG);
                                // die(api_error($type, L10n::t("Weekly posting limit of %d posts reached. The post was rejected.", $throttle_week)));
                                throw new TooManyRequestsException(L10n::tt("Weekly posting limit of %d post reached. The post was rejected.", "Weekly posting limit of %d posts reached. The post was rejected.", $throttle_week));
                        }
@@ -1160,17 +1160,15 @@ function api_statuses_update($type)
                if ($throttle_month > 0) {
                        $datefrom = date(DateTimeFormat::MYSQL, time() - 24*60*60*30);
 
-                       $condition = ["`uid` = ? AND `wall` AND `created` > ? AND `id` = `parent`", api_user(), $datefrom];
-                       $posts_month = dba::count('item', $condition);
+                       $condition = ["`uid` = ? AND `wall` AND `created` > ?", api_user(), $datefrom];
+                       $posts_month = DBA::count('thread', $condition);
 
                        if ($posts_month > $throttle_month) {
-                               logger('Monthly posting limit reached for user '.api_user(), LOGGER_DEBUG);
+                               Logger::log('Monthly posting limit reached for user '.api_user(), Logger::DEBUG);
                                // die(api_error($type, L10n::t("Monthly posting limit of %d posts reached. The post was rejected.", $throttle_month));
                                throw new TooManyRequestsException(L10n::t("Monthly posting limit of %d post reached. The post was rejected.", "Monthly posting limit of %d posts reached. The post was rejected.", $throttle_month));
                        }
                }
-
-               $_REQUEST['type'] = 'wall';
        }
 
        if (x($_FILES, 'media')) {
@@ -1188,7 +1186,7 @@ function api_statuses_update($type)
                        intval(requestdata('media_ids')),
                        api_user()
                );
-               if (DBM::is_result($r)) {
+               if (DBA::isResult($r)) {
                        $phototypes = Image::supportedTypes();
                        $ext = $phototypes[$r[0]['type']];
                        $_REQUEST['body'] .= "\n\n" . '[url=' . System::baseUrl() . '/photos/' . $r[0]['nickname'] . '/image/' . $r[0]['resource-id'] . ']';
@@ -1205,10 +1203,10 @@ function api_statuses_update($type)
        }
 
        // call out normal post function
-       item_post($a);
+       $item_id = item_post($a);
 
-       // this should output the last post (the one we just posted).
-       return api_status_show($type);
+       // output the post that we just posted.
+       return api_status_show($type, $item_id);
 }
 
 /// @TODO move to top of file or somewhere better
@@ -1226,7 +1224,7 @@ function api_media_upload()
        $a = get_app();
 
        if (api_user() === false) {
-               logger('no user');
+               Logger::log('no user');
                throw new ForbiddenException();
        }
 
@@ -1251,7 +1249,7 @@ function api_media_upload()
                                        "h" => $media["height"],
                                        "image_type" => $media["type"]];
 
-       logger("Media uploaded: " . print_r($returndata, true), LOGGER_DEBUG);
+       Logger::log("Media uploaded: " . print_r($returndata, true), Logger::DEBUG);
 
        return ["media" => $returndata];
 }
@@ -1265,13 +1263,13 @@ api_register_func('api/media/upload', 'api_media_upload', true, API_METHOD_POST)
  *
  * @return array|string
  */
-function api_status_show($type)
+function api_status_show($type, $item_id = 0)
 {
        $a = get_app();
 
        $user_info = api_get_user($a);
 
-       logger('api_status_show: user_info: '.print_r($user_info, true), LOGGER_DEBUG);
+       Logger::log('api_status_show: user_info: '.print_r($user_info, true), Logger::DEBUG);
 
        if ($type == "raw") {
                $privacy_sql = "AND NOT `private`";
@@ -1279,12 +1277,17 @@ function api_status_show($type)
                $privacy_sql = "";
        }
 
-       // get last public wall message
-       $condition = ['owner-id' => $user_info['pid'], 'uid' => api_user(),
-               'gravity' => [GRAVITY_PARENT, GRAVITY_COMMENT]];
+       if (!empty($item_id)) {
+               // Get the item with the given id
+               $condition = ['id' => $item_id];
+       } else {
+               // get last public wall message
+               $condition = ['owner-id' => $user_info['pid'], 'uid' => api_user(),
+                       'gravity' => [GRAVITY_PARENT, GRAVITY_COMMENT]];
+       }
        $lastwall = Item::selectFirst(Item::ITEM_FIELDLIST, $condition, ['order' => ['id' => true]]);
 
-       if (DBM::is_result($lastwall)) {
+       if (DBA::isResult($lastwall)) {
                $in_reply_to = api_in_reply_to($lastwall);
 
                $converted = api_convert_item($lastwall);
@@ -1333,16 +1336,16 @@ function api_status_show($type)
                }
 
                if ($status_info["source"] == 'web') {
-                       $status_info["source"] = ContactSelector::networkToName($lastwall['network'], $user_info['url']);
-               } elseif (ContactSelector::networkToName($lastwall['network'], $user_info['url']) != $status_info["source"]) {
-                       $status_info["source"] = trim($status_info["source"].' ('.ContactSelector::networkToName($lastwall['network'], $user_info['url']).')');
+                       $status_info["source"] = ContactSelector::networkToName($lastwall['network'], $lastwall['author-link']);
+               } elseif (ContactSelector::networkToName($lastwall['network'], $lastwall['author-link']) != $status_info["source"]) {
+                       $status_info["source"] = trim($status_info["source"].' ('.ContactSelector::networkToName($lastwall['network'], $lastwall['author-link']).')');
                }
 
                // "uid" and "self" are only needed for some internal stuff, so remove it from here
                unset($status_info["user"]["uid"]);
                unset($status_info["user"]["self"]);
 
-               logger('status_info: '.print_r($status_info, true), LOGGER_DEBUG);
+               Logger::log('status_info: '.print_r($status_info, true), Logger::DEBUG);
 
                if ($type == "raw") {
                        return $status_info;
@@ -1369,7 +1372,7 @@ function api_users_show($type)
                'gravity' => [GRAVITY_PARENT, GRAVITY_COMMENT], 'private' => false];
        $lastwall = Item::selectFirst(Item::ITEM_FIELDLIST, $condition, ['order' => ['id' => true]]);
 
-       if (DBM::is_result($lastwall)) {
+       if (DBA::isResult($lastwall)) {
                $in_reply_to = api_in_reply_to($lastwall);
 
                $converted = api_convert_item($lastwall);
@@ -1408,11 +1411,11 @@ function api_users_show($type)
                }
 
                if ($user_info["status"]["source"] == 'web') {
-                       $user_info["status"]["source"] = ContactSelector::networkToName($lastwall['network'], $user_info['url']);
+                       $user_info["status"]["source"] = ContactSelector::networkToName($lastwall['network'], $lastwall['author-link']);
                }
 
                if (ContactSelector::networkToName($lastwall['network'], $user_info['url']) != $user_info["status"]["source"]) {
-                       $user_info["status"]["source"] = trim($user_info["status"]["source"] . ' (' . ContactSelector::networkToName($lastwall['network'], $user_info['url']) . ')');
+                       $user_info["status"]["source"] = trim($user_info["status"]["source"] . ' (' . ContactSelector::networkToName($lastwall['network'], $lastwall['author-link']) . ')');
                }
        }
 
@@ -1442,13 +1445,13 @@ function api_users_search($type)
        $userlist = [];
 
        if (x($_GET, 'q')) {
-               $r = q("SELECT id FROM `contact` WHERE `uid` = 0 AND `name` = '%s'", dbesc($_GET["q"]));
+               $r = q("SELECT id FROM `contact` WHERE `uid` = 0 AND `name` = '%s'", DBA::escape($_GET["q"]));
 
-               if (!DBM::is_result($r)) {
-                       $r = q("SELECT `id` FROM `contact` WHERE `uid` = 0 AND `nick` = '%s'", dbesc($_GET["q"]));
+               if (!DBA::isResult($r)) {
+                       $r = q("SELECT `id` FROM `contact` WHERE `uid` = 0 AND `nick` = '%s'", DBA::escape($_GET["q"]));
                }
 
-               if (DBM::is_result($r)) {
+               if (DBA::isResult($r)) {
                        $k = 0;
                        foreach ($r as $user) {
                                $user_info = api_get_user($a, $user["id"]);
@@ -1822,18 +1825,18 @@ function api_statuses_show($type)
                $id = intval(defaults($a->argv, 4, 0));
        }
 
-       logger('API: api_statuses_show: ' . $id);
+       Logger::log('API: api_statuses_show: ' . $id);
 
        $conversation = !empty($_REQUEST['conversation']);
 
        // try to fetch the item for the local user - or the public item, if there is no local one
        $uri_item = Item::selectFirst(['uri'], ['id' => $id]);
-       if (!DBM::is_result($uri_item)) {
+       if (!DBA::isResult($uri_item)) {
                throw new BadRequestException("There is no status with this id.");
        }
 
        $item = Item::selectFirst(['id'], ['uri' => $uri_item['uri'], 'uid' => [0, api_user()]], ['order' => ['uid' => true]]);
-       if (!DBM::is_result($item)) {
+       if (!DBA::isResult($item)) {
                throw new BadRequestException("There is no status with this id.");
        }
 
@@ -1850,7 +1853,7 @@ function api_statuses_show($type)
        $statuses = Item::selectForUser(api_user(), [], $condition, $params);
 
        /// @TODO How about copying this to above methods which don't check $r ?
-       if (!DBM::is_result($statuses)) {
+       if (!DBA::isResult($statuses)) {
                throw new BadRequestException("There is no status with this id.");
        }
 
@@ -1904,16 +1907,16 @@ function api_conversation_show($type)
                $id = intval(defaults($a->argv, 4, 0));
        }
 
-       logger('API: api_conversation_show: '.$id);
+       Logger::log('API: api_conversation_show: '.$id);
 
        // try to fetch the item for the local user - or the public item, if there is no local one
        $item = Item::selectFirst(['parent-uri'], ['id' => $id]);
-       if (!DBM::is_result($item)) {
+       if (!DBA::isResult($item)) {
                throw new BadRequestException("There is no status with this id.");
        }
 
        $parent = Item::selectFirst(['id'], ['uri' => $item['parent-uri'], 'uid' => [0, api_user()]], ['order' => ['uid' => true]]);
-       if (!DBM::is_result($parent)) {
+       if (!DBA::isResult($parent)) {
                throw new BadRequestException("There is no status with this id.");
        }
 
@@ -1930,7 +1933,7 @@ function api_conversation_show($type)
        $params = ['order' => ['id' => true], 'limit' => [$start, $count]];
        $statuses = Item::selectForUser(api_user(), [], $condition, $params);
 
-       if (!DBM::is_result($statuses)) {
+       if (!DBA::isResult($statuses)) {
                throw new BadRequestException("There is no status with id $id.");
        }
 
@@ -1975,12 +1978,12 @@ function api_statuses_repeat($type)
                $id = intval(defaults($a->argv, 4, 0));
        }
 
-       logger('API: api_statuses_repeat: '.$id);
+       Logger::log('API: api_statuses_repeat: '.$id);
 
        $fields = ['body', 'author-name', 'author-link', 'author-avatar', 'guid', 'created', 'plink'];
        $item = Item::selectFirst($fields, ['id' => $id, 'private' => false]);
 
-       if (DBM::is_result($item) && $item['body'] != "") {
+       if (DBA::isResult($item) && $item['body'] != "") {
                if (strpos($item['body'], "[/share]") !== false) {
                        $pos = strpos($item['body'], "[share");
                        $post = substr($item['body'], $pos);
@@ -1992,21 +1995,20 @@ function api_statuses_repeat($type)
                }
                $_REQUEST['body'] = $post;
                $_REQUEST['profile_uid'] = api_user();
-               $_REQUEST['type'] = 'wall';
                $_REQUEST['api_source'] = true;
 
                if (!x($_REQUEST, "source")) {
                        $_REQUEST["source"] = api_source();
                }
 
-               item_post($a);
+               $item_id = item_post($a);
        } else {
                throw new ForbiddenException();
        }
 
-       // this should output the last post (the one we just posted).
+       // output the post that we just posted.
        $called_api = [];
-       return api_status_show($type);
+       return api_status_show($type, $item_id);
 }
 
 /// @TODO move to top of file or somewhere better
@@ -2041,7 +2043,7 @@ function api_statuses_destroy($type)
                $id = intval(defaults($a->argv, 4, 0));
        }
 
-       logger('API: api_statuses_destroy: '.$id);
+       Logger::log('API: api_statuses_destroy: '.$id);
 
        $ret = api_statuses_show($type);
 
@@ -2136,11 +2138,11 @@ function api_statuses_user_timeline($type)
                throw new ForbiddenException();
        }
 
-       logger(
+       Logger::log(
                "api_statuses_user_timeline: api_user: ". api_user() .
                        "\nuser_info: ".print_r($user_info, true) .
                        "\n_REQUEST:  ".print_r($_REQUEST, true),
-               LOGGER_DEBUG
+               Logger::DEBUG
        );
 
        $since_id        = x($_REQUEST, 'since_id')        ? $_REQUEST['since_id']        : 0;
@@ -2231,7 +2233,7 @@ function api_favorites_create_destroy($type)
 
        $item = Item::selectFirstForUser(api_user(), [], ['id' => $itemid, 'uid' => api_user()]);
 
-       if (!DBM::is_result($item)) {
+       if (!DBA::isResult($item)) {
                throw new BadRequestException("Invalid item.");
        }
 
@@ -2293,7 +2295,7 @@ function api_favorites($type)
 
        // in friendica starred item are private
        // return favorites only for self
-       logger('api_favorites: self:' . $user_info['self']);
+       Logger::log('api_favorites: self:' . $user_info['self']);
 
        if ($user_info['self'] == 0) {
                $ret = [];
@@ -2350,7 +2352,7 @@ function api_format_messages($item, $recipient, $sender)
        // standard meta information
        $ret = [
                'id'                    => $item['id'],
-               'sender_id'             => $sender['id'] ,
+               'sender_id'             => $sender['id'],
                'text'                  => "",
                'recipient_id'          => $recipient['id'],
                'created_at'            => api_date(defaults($item, 'created', DateTimeFormat::utcNow())),
@@ -2524,7 +2526,7 @@ function api_get_entitities(&$text, $bbcode)
                preg_match_all("/\[img](.*?)\[\/img\]/ism", $bbcode, $images);
 
                foreach ($images[1] as $image) {
-                       $replace = proxy_url($image);
+                       $replace = ProxyUtils::proxifyUrl($image);
                        $text = str_replace($image, $replace, $text);
                }
                return [];
@@ -2633,7 +2635,7 @@ function api_get_entitities(&$text, $bbcode)
                                // If image cache is activated, then use the following sizes:
                                // thumb  (150), small (340), medium (600) and large (1024)
                                if (!Config::get("system", "proxy_disabled")) {
-                                       $media_url = proxy_url($url);
+                                       $media_url = ProxyUtils::proxifyUrl($url);
 
                                        $sizes = [];
                                        $scale = Image::getScalingDimensions($image[0], $image[1], 150);
@@ -2731,7 +2733,7 @@ function api_contactlink_to_array($txt)
  *                     likes => int count,
  *                     dislikes => int count
  */
-function api_format_items_activities(&$item, $type = "json")
+function api_format_items_activities($item, $type = "json")
 {
        $a = get_app();
 
@@ -2746,13 +2748,13 @@ function api_format_items_activities(&$item, $type = "json")
        $condition = ['uid' => $item['uid'], 'thr-parent' => $item['uri']];
        $ret = Item::selectForUser($item['uid'], ['author-id', 'verb'], $condition);
 
-       while ($item = Item::fetch($ret)) {
+       while ($parent_item = Item::fetch($ret)) {
                // not used as result should be structured like other user data
                //builtin_activity_puller($i, $activities);
 
                // get user data and add it to the array of the activity
-               $user = api_get_user($a, $item['author-id']);
-               switch ($item['verb']) {
+               $user = api_get_user($a, $parent_item['author-id']);
+               switch ($parent_item['verb']) {
                        case ACTIVITY_LIKE:
                                $activities['like'][] = $user;
                                break;
@@ -2773,7 +2775,7 @@ function api_format_items_activities(&$item, $type = "json")
                }
        }
 
-       dba::close($ret);
+       DBA::close($ret);
 
        if ($type == "xml") {
                $xml_activities = [];
@@ -2892,8 +2894,9 @@ function api_format_items($r, $user_info, $filter_user = false, $type = "json")
                        'in_reply_to_screen_name' => $in_reply_to['screen_name'],
                        $geo => null,
                        'favorited' => $item['starred'] ? true : false,
-                       'user' =>  $status_user ,
+                       'user' =>  $status_user,
                        'friendica_owner' => $owner_user,
+                       'friendica_private' => $item['private'] == 1,
                        //'entities' => NULL,
                        'statusnet_html' => $converted["html"],
                        'statusnet_conversation_id' => $item['parent'],
@@ -2910,9 +2913,9 @@ function api_format_items($r, $user_info, $filter_user = false, $type = "json")
                }
 
                if ($status["source"] == 'web') {
-                       $status["source"] = ContactSelector::networkToName($item['network'], $user_info['url']);
-               } elseif (ContactSelector::networkToName($item['network'], $user_info['url']) != $status["source"]) {
-                       $status["source"] = trim($status["source"].' ('.ContactSelector::networkToName($item['network'], $user_info['url']).')');
+                       $status["source"] = ContactSelector::networkToName($item['network'], $item['author-link']);
+               } elseif (ContactSelector::networkToName($item['network'], $item['author-link']) != $status["source"]) {
+                       $status["source"] = trim($status["source"].' ('.ContactSelector::networkToName($item['network'], $item['author-link']).')');
                }
 
                if ($item["id"] == $item["parent"]) {
@@ -3053,7 +3056,7 @@ function api_lists_ownerships($type)
        $user_info = api_get_user($a);
        $uid = $user_info['uid'];
 
-       $groups = dba::select('group', [], ['deleted' => 0, 'uid' => $uid]);
+       $groups = DBA::select('group', [], ['deleted' => 0, 'uid' => $uid]);
 
        // loop through all groups
        $lists = [];
@@ -3192,9 +3195,9 @@ function api_statuses_f($qtype)
 
        $sql_extra = '';
        if ($qtype == 'friends') {
-               $sql_extra = sprintf(" AND ( `rel` = %d OR `rel` = %d ) ", intval(CONTACT_IS_SHARING), intval(CONTACT_IS_FRIEND));
+               $sql_extra = sprintf(" AND ( `rel` = %d OR `rel` = %d ) ", intval(Contact::SHARING), intval(Contact::FRIEND));
        } elseif ($qtype == 'followers') {
-               $sql_extra = sprintf(" AND ( `rel` = %d OR `rel` = %d ) ", intval(CONTACT_IS_FOLLOWER), intval(CONTACT_IS_FRIEND));
+               $sql_extra = sprintf(" AND ( `rel` = %d OR `rel` = %d ) ", intval(Contact::FOLLOWER), intval(Contact::FRIEND));
        }
 
        // friends and followers only for self
@@ -3342,7 +3345,7 @@ function api_statusnet_config($type)
        $a = get_app();
 
        $name      = Config::get('config', 'sitename');
-       $server    = $a->get_hostname();
+       $server    = $a->getHostName();
        $logo      = System::baseUrl() . '/images/friendica-64.png';
        $email     = Config::get('config', 'admin_email');
        $closed    = intval(Config::get('config', 'register_policy')) === REGISTER_CLOSED ? 'true' : 'false';
@@ -3399,7 +3402,7 @@ api_register_func('api/statusnet/version', 'api_statusnet_version', false);
  */
 function api_ff_ids($type)
 {
-       if (! api_user()) {
+       if (!api_user()) {
                throw new ForbiddenException();
        }
 
@@ -3415,7 +3418,7 @@ function api_ff_ids($type)
                        WHERE `contact`.`uid` = %s AND NOT `contact`.`self`",
                intval(api_user())
        );
-       if (!DBM::is_result($r)) {
+       if (!DBA::isResult($r)) {
                return;
        }
 
@@ -3488,10 +3491,10 @@ function api_direct_messages_new($type)
                $r = q(
                        "SELECT `id`, `nurl`, `network` FROM `contact` WHERE `uid`=%d AND `nick`='%s'",
                        intval(api_user()),
-                       dbesc($_POST['screen_name'])
+                       DBA::escape($_POST['screen_name'])
                );
 
-               if (DBM::is_result($r)) {
+               if (DBA::isResult($r)) {
                        // Selecting the id by priority, friendica first
                        api_best_nickname($r);
 
@@ -3585,7 +3588,7 @@ function api_direct_messages_destroy($type)
        }
 
        // add parent-uri to sql command if specified by calling app
-       $sql_extra = ($parenturi != "" ? " AND `parent-uri` = '" . dbesc($parenturi) . "'" : "");
+       $sql_extra = ($parenturi != "" ? " AND `parent-uri` = '" . DBA::escape($parenturi) . "'" : "");
 
        // get data of the specified message id
        $r = q(
@@ -3595,7 +3598,7 @@ function api_direct_messages_destroy($type)
        );
 
        // error message if specified id is not in database
-       if (!DBM::is_result($r)) {
+       if (!DBA::isResult($r)) {
                if ($verbose == "true") {
                        $answer = ['result' => 'error', 'message' => 'message id not in database'];
                        return api_format_data("direct_messages_delete", $type, ['$result' => $answer]);
@@ -3627,6 +3630,84 @@ function api_direct_messages_destroy($type)
 /// @TODO move to top of file or somewhere better
 api_register_func('api/direct_messages/destroy', 'api_direct_messages_destroy', true, API_METHOD_DELETE);
 
+/**
+ * Unfollow Contact
+ *
+ * @brief unfollow contact 
+ *
+ * @param string $type Known types are 'atom', 'rss', 'xml' and 'json'
+ * @return string|array
+ * @see https://developer.twitter.com/en/docs/accounts-and-users/follow-search-get-users/api-reference/post-friendships-destroy.html
+ */
+function api_friendships_destroy($type)
+{
+       $uid = api_user();
+
+       if ($uid === false) {
+               throw new ForbiddenException();
+       }
+
+       $contact_id = defaults($_REQUEST, 'user_id');
+
+       if (empty($contact_id)) {
+               Logger::log("No user_id specified", Logger::DEBUG);
+               throw new BadRequestException("no user_id specified");
+       }
+
+       // Get Contact by given id
+       $contact = DBA::selectFirst('contact', ['url'], ['id' => $contact_id, 'uid' => 0, 'self' => false]);
+
+       if(!DBA::isResult($contact)) {
+               Logger::log("No contact found for ID" . $contact_id, Logger::DEBUG);
+               throw new NotFoundException("no contact found to given ID");
+       }
+
+       $url = $contact["url"];
+
+       $condition = ["`uid` = ? AND (`rel` = ? OR `rel` = ?) AND (`nurl` = ? OR `alias` = ? OR `alias` = ?)",
+                       $uid, Contact::SHARING, Contact::FRIEND, normalise_link($url),
+                       normalise_link($url), $url];
+       $contact = DBA::selectFirst('contact', [], $condition);
+
+       if (!DBA::isResult($contact)) {
+               Logger::log("Not following Contact", Logger::DEBUG);
+               throw new NotFoundException("Not following Contact");
+       }
+
+       if (!in_array($contact['network'], Protocol::NATIVE_SUPPORT)) {
+               Logger::log("Not supported", Logger::DEBUG);
+               throw new ExpectationFailedException("Not supported");
+       }
+
+       $dissolve = ($contact['rel'] == Contact::SHARING);
+
+       $owner = User::getOwnerDataById($uid);
+       if ($owner) {
+               Contact::terminateFriendship($owner, $contact, $dissolve);
+       }
+       else {
+               Logger::log("No owner found", Logger::DEBUG);
+               throw new NotFoundException("Error Processing Request");
+       }
+
+       // Sharing-only contacts get deleted as there no relationship any more
+       if ($dissolve) {
+               Contact::remove($contact['id']);
+       } else {
+               DBA::update('contact', ['rel' => Contact::FOLLOWER], ['id' => $contact['id']]);
+       }
+
+       // "uid" and "self" are only needed for some internal stuff, so remove it from here
+       unset($contact["uid"]);
+       unset($contact["self"]);
+
+       // Set screen_name since Twidere requests it
+       $contact["screen_name"] = $contact["nick"];
+
+       return api_format_data("friendships-destroy", $type, ['user' => $contact]);
+}
+api_register_func('api/friendships/destroy', 'api_friendships_destroy', true, API_METHOD_POST);
+
 /**
  *
  * @param string $type Return type (atom, rss, xml, json)
@@ -3674,13 +3755,13 @@ function api_direct_messages_box($type, $box, $verbose)
 
        // filters
        if ($box=="sentbox") {
-               $sql_extra = "`mail`.`from-url`='" . dbesc($profile_url) . "'";
+               $sql_extra = "`mail`.`from-url`='" . DBA::escape($profile_url) . "'";
        } elseif ($box == "conversation") {
-               $sql_extra = "`mail`.`parent-uri`='" . dbesc(defaults($_GET, 'uri', ''))  . "'";
+               $sql_extra = "`mail`.`parent-uri`='" . DBA::escape(defaults($_GET, 'uri', ''))  . "'";
        } elseif ($box == "all") {
                $sql_extra = "true";
        } elseif ($box == "inbox") {
-               $sql_extra = "`mail`.`from-url`!='" . dbesc($profile_url) . "'";
+               $sql_extra = "`mail`.`from-url`!='" . DBA::escape($profile_url) . "'";
        }
 
        if ($max_id > 0) {
@@ -3690,7 +3771,7 @@ function api_direct_messages_box($type, $box, $verbose)
        if ($user_id != "") {
                $sql_extra .= ' AND `mail`.`contact-id` = ' . intval($user_id);
        } elseif ($screen_name !="") {
-               $sql_extra .= " AND `contact`.`nick` = '" . dbesc($screen_name). "'";
+               $sql_extra .= " AND `contact`.`nick` = '" . DBA::escape($screen_name). "'";
        }
 
        $r = q(
@@ -3700,7 +3781,7 @@ function api_direct_messages_box($type, $box, $verbose)
                intval($start),
                intval($count)
        );
-       if ($verbose == "true" && !DBM::is_result($r)) {
+       if ($verbose == "true" && !DBA::isResult($r)) {
                $answer = ['result' => 'error', 'message' => 'no mails available'];
                return api_format_data("direct_messages_all", $type, ['$result' => $answer]);
        }
@@ -3853,9 +3934,9 @@ function api_fr_photoalbum_delete($type)
        $r = q(
                "SELECT DISTINCT `resource-id` FROM `photo` WHERE `uid` = %d AND `album` = '%s'",
                intval(api_user()),
-               dbesc($album)
+               DBA::escape($album)
        );
-       if (!DBM::is_result($r)) {
+       if (!DBA::isResult($r)) {
                throw new BadRequestException("album not available");
        }
 
@@ -3865,14 +3946,14 @@ function api_fr_photoalbum_delete($type)
                $condition = ['uid' => local_user(), 'resource-id' => $rr['resource-id'], 'type' => 'photo'];
                $photo_item = Item::selectFirstForUser(local_user(), ['id'], $condition);
 
-               if (!DBM::is_result($photo_item)) {
+               if (!DBA::isResult($photo_item)) {
                        throw new InternalServerErrorException("problem with deleting items occured");
                }
                Item::deleteForUser(['id' => $photo_item['id']], api_user());
        }
 
        // now let's delete all photos from the album
-       $result = dba::delete('photo', ['uid' => api_user(), 'album' => $album]);
+       $result = DBA::delete('photo', ['uid' => api_user(), 'album' => $album]);
 
        // return success of deletion or error message
        if ($result) {
@@ -3906,11 +3987,11 @@ function api_fr_photoalbum_update($type)
                throw new BadRequestException("no new albumname specified");
        }
        // check if album is existing
-       if (!dba::exists('photo', ['uid' => api_user(), 'album' => $album])) {
+       if (!DBA::exists('photo', ['uid' => api_user(), 'album' => $album])) {
                throw new BadRequestException("album not available");
        }
        // now let's update all photos to the albumname
-       $result = dba::update('photo', ['album' => $album_new], ['uid' => api_user(), 'album' => $album]);
+       $result = DBA::update('photo', ['album' => $album_new], ['uid' => api_user(), 'album' => $album]);
 
        // return success of updating or error message
        if ($result) {
@@ -3945,7 +4026,7 @@ function api_fr_photos_list($type)
                'image/gif' => 'gif'
        ];
        $data = ['photo'=>[]];
-       if (DBM::is_result($r)) {
+       if (DBA::isResult($r)) {
                foreach ($r as $rr) {
                        $photo = [];
                        $photo['id'] = $rr['resource-id'];
@@ -4014,10 +4095,10 @@ function api_fr_photo_create_update($type)
                $r = q(
                        "SELECT `id` FROM `photo` WHERE `uid` = %d AND `resource-id` = '%s' AND `album` = '%s'",
                        intval(api_user()),
-                       dbesc($photo_id),
-                       dbesc($album)
+                       DBA::escape($photo_id),
+                       DBA::escape($album)
                );
-               if (!DBM::is_result($r)) {
+               if (!DBA::isResult($r)) {
                        throw new BadRequestException("photo not available");
                }
        }
@@ -4084,8 +4165,8 @@ function api_fr_photo_create_update($type)
                                $sql_extra,
                                DateTimeFormat::utcNow(),   // update edited timestamp
                                intval(api_user()),
-                               dbesc($photo_id),
-                               dbesc($album)
+                               DBA::escape($photo_id),
+                               DBA::escape($album)
                        );
                } else {
                        $nothingtodo = true;
@@ -4138,13 +4219,13 @@ function api_fr_photo_delete($type)
        $r = q(
                "SELECT `id` FROM `photo` WHERE `uid` = %d AND `resource-id` = '%s'",
                intval(api_user()),
-               dbesc($photo_id)
+               DBA::escape($photo_id)
        );
-       if (!DBM::is_result($r)) {
+       if (!DBA::isResult($r)) {
                throw new BadRequestException("photo not available");
        }
        // now we can perform on the deletion of the photo
-       $result = dba::delete('photo', ['uid' => api_user(), 'resource-id' => $photo_id]);
+       $result = DBA::delete('photo', ['uid' => api_user(), 'resource-id' => $photo_id]);
 
        // return success of deletion or error message
        if ($result) {
@@ -4152,7 +4233,7 @@ function api_fr_photo_delete($type)
                $condition = ['uid' => local_user(), 'resource-id' => $photo_id, 'type' => 'photo'];
                $photo_item = Item::selectFirstForUser(local_user(), ['id'], $condition);
 
-               if (!DBM::is_result($photo_item)) {
+               if (!DBA::isResult($photo_item)) {
                        throw new InternalServerErrorException("problem with deleting items occured");
                }
                // function for setting the items to "deleted = 1" which ensures that comments, likes etc. are not shown anymore
@@ -4217,9 +4298,9 @@ function api_account_update_profile_image($type)
 
        // check if specified profile id is valid
        if ($profile_id != 0) {
-               $profile = dba::selectFirst('profile', ['is-default'], ['uid' => api_user(), 'id' => $profile_id]);
+               $profile = DBA::selectFirst('profile', ['is-default'], ['uid' => api_user(), 'id' => $profile_id]);
                // error message if specified profile id is not in database
-               if (!DBM::is_result($profile)) {
+               if (!DBA::isResult($profile)) {
                        throw new BadRequestException("profile_id not available");
                }
                $is_default_profile = $profile['is-default'];
@@ -4254,11 +4335,11 @@ function api_account_update_profile_image($type)
        // change specified profile or all profiles to the new resource-id
        if ($is_default_profile) {
                $condition = ["`profile` AND `resource-id` != ? AND `uid` = ?", $data['photo']['id'], api_user()];
-               dba::update('photo', ['profile' => false], $condition);
+               DBA::update('photo', ['profile' => false], $condition);
        } else {
                $fields = ['photo' => System::baseUrl() . '/photo/' . $data['photo']['id'] . '-4.' . $filetype,
                        'thumb' => System::baseUrl() . '/photo/' . $data['photo']['id'] . '-5.' . $filetype];
-               dba::update('profile', $fields, ['id' => $_REQUEST['profile'], 'uid' => api_user()]);
+               DBA::update('profile', $fields, ['id' => $_REQUEST['profile'], 'uid' => api_user()]);
        }
 
        Contact::updateSelfFromUserID(api_user(), true);
@@ -4303,16 +4384,16 @@ function api_account_update_profile($type)
        $api_user = api_get_user(get_app());
 
        if (!empty($_POST['name'])) {
-               dba::update('profile', ['name' => $_POST['name']], ['uid' => $local_user]);
-               dba::update('user', ['username' => $_POST['name']], ['uid' => $local_user]);
-               dba::update('contact', ['name' => $_POST['name']], ['uid' => $local_user, 'self' => 1]);
-               dba::update('contact', ['name' => $_POST['name']], ['id' => $api_user['id']]);
+               DBA::update('profile', ['name' => $_POST['name']], ['uid' => $local_user]);
+               DBA::update('user', ['username' => $_POST['name']], ['uid' => $local_user]);
+               DBA::update('contact', ['name' => $_POST['name']], ['uid' => $local_user, 'self' => 1]);
+               DBA::update('contact', ['name' => $_POST['name']], ['id' => $api_user['id']]);
        }
 
        if (isset($_POST['description'])) {
-               dba::update('profile', ['about' => $_POST['description']], ['uid' => $local_user]);
-               dba::update('contact', ['about' => $_POST['description']], ['uid' => $local_user, 'self' => 1]);
-               dba::update('contact', ['about' => $_POST['description']], ['id' => $api_user['id']]);
+               DBA::update('profile', ['about' => $_POST['description']], ['uid' => $local_user]);
+               DBA::update('contact', ['about' => $_POST['description']], ['uid' => $local_user, 'self' => 1]);
+               DBA::update('contact', ['about' => $_POST['description']], ['id' => $api_user['id']]);
        }
 
        Worker::add(PRIORITY_LOW, 'ProfileUpdate', $local_user);
@@ -4346,12 +4427,8 @@ function check_acl_input($acl_string)
        foreach ($cid_array as $cid) {
                $cid = str_replace("<", "", $cid);
                $cid = str_replace(">", "", $cid);
-               $contact = q(
-                       "SELECT * FROM `contact` WHERE `id` = %d AND `uid` = %d",
-                       intval($cid),
-                       intval(api_user())
-               );
-               $contact_not_found |= !DBM::is_result($contact);
+               $condition = ['id' => $cid, 'uid' => api_user()];
+               $contact_not_found |= !DBA::exists('contact', $condition);
        }
        return $contact_not_found;
 }
@@ -4405,14 +4482,14 @@ function save_media_to_database($mediatype, $media, $type, $album, $allow_cid, $
        if ($filetype == "") {
                $filetype=Image::guessType($filename);
        }
-       $imagedata = getimagesize($src);
+       $imagedata = @getimagesize($src);
        if ($imagedata) {
                $filetype = $imagedata['mime'];
        }
-       logger(
+       Logger::log(
                "File upload src: " . $src . " - filename: " . $filename .
                " - size: " . $filesize . " - type: " . $filetype,
-               LOGGER_DEBUG
+               Logger::DEBUG
        );
 
        // check if there was a php upload error
@@ -4429,7 +4506,7 @@ function save_media_to_database($mediatype, $media, $type, $album, $allow_cid, $
        // create Photo instance with the data of the image
        $imagedata = @file_get_contents($src);
        $Image = new Image($imagedata, $filetype);
-       if (! $Image->isValid()) {
+       if (!$Image->isValid()) {
                throw new InternalServerErrorException("unable to process image data");
        }
 
@@ -4439,12 +4516,12 @@ function save_media_to_database($mediatype, $media, $type, $album, $allow_cid, $
 
        // check max length of images on server
        $max_length = Config::get('system', 'max_image_length');
-       if (! $max_length) {
+       if (!$max_length) {
                $max_length = MAX_IMAGE_LENGTH;
        }
        if ($max_length > 0) {
                $Image->scaleDown($max_length);
-               logger("File upload: Scaling picture to new size " . $max_length, LOGGER_DEBUG);
+               Logger::log("File upload: Scaling picture to new size " . $max_length, Logger::DEBUG);
        }
        $width = $Image->getWidth();
        $height = $Image->getHeight();
@@ -4454,57 +4531,57 @@ function save_media_to_database($mediatype, $media, $type, $album, $allow_cid, $
 
        if ($mediatype == "photo") {
                // upload normal image (scales 0, 1, 2)
-               logger("photo upload: starting new photo upload", LOGGER_DEBUG);
+               Logger::log("photo upload: starting new photo upload", Logger::DEBUG);
 
                $r = Photo::store($Image, local_user(), $visitor, $hash, $filename, $album, 0, 0, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
-               if (! $r) {
-                       logger("photo upload: image upload with scale 0 (original size) failed");
+               if (!$r) {
+                       Logger::log("photo upload: image upload with scale 0 (original size) failed");
                }
                if ($width > 640 || $height > 640) {
                        $Image->scaleDown(640);
                        $r = Photo::store($Image, local_user(), $visitor, $hash, $filename, $album, 1, 0, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
-                       if (! $r) {
-                               logger("photo upload: image upload with scale 1 (640x640) failed");
+                       if (!$r) {
+                               Logger::log("photo upload: image upload with scale 1 (640x640) failed");
                        }
                }
 
                if ($width > 320 || $height > 320) {
                        $Image->scaleDown(320);
                        $r = Photo::store($Image, local_user(), $visitor, $hash, $filename, $album, 2, 0, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
-                       if (! $r) {
-                               logger("photo upload: image upload with scale 2 (320x320) failed");
+                       if (!$r) {
+                               Logger::log("photo upload: image upload with scale 2 (320x320) failed");
                        }
                }
-               logger("photo upload: new photo upload ended", LOGGER_DEBUG);
+               Logger::log("photo upload: new photo upload ended", Logger::DEBUG);
        } elseif ($mediatype == "profileimage") {
                // upload profile image (scales 4, 5, 6)
-               logger("photo upload: starting new profile image upload", LOGGER_DEBUG);
+               Logger::log("photo upload: starting new profile image upload", Logger::DEBUG);
 
-               if ($width > 175 || $height > 175) {
-                       $Image->scaleDown(175);
+               if ($width > 300 || $height > 300) {
+                       $Image->scaleDown(300);
                        $r = Photo::store($Image, local_user(), $visitor, $hash, $filename, $album, 4, $profile, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
-                       if (! $r) {
-                               logger("photo upload: profile image upload with scale 4 (175x175) failed");
+                       if (!$r) {
+                               Logger::log("photo upload: profile image upload with scale 4 (300x300) failed");
                        }
                }
 
                if ($width > 80 || $height > 80) {
                        $Image->scaleDown(80);
                        $r = Photo::store($Image, local_user(), $visitor, $hash, $filename, $album, 5, $profile, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
-                       if (! $r) {
-                               logger("photo upload: profile image upload with scale 5 (80x80) failed");
+                       if (!$r) {
+                               Logger::log("photo upload: profile image upload with scale 5 (80x80) failed");
                        }
                }
 
                if ($width > 48 || $height > 48) {
                        $Image->scaleDown(48);
                        $r = Photo::store($Image, local_user(), $visitor, $hash, $filename, $album, 6, $profile, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
-                       if (! $r) {
-                               logger("photo upload: profile image upload with scale 6 (48x48) failed");
+                       if (!$r) {
+                               Logger::log("photo upload: profile image upload with scale 6 (48x48) failed");
                        }
                }
                $Image->__destruct();
-               logger("photo upload: new profile image upload ended", LOGGER_DEBUG);
+               Logger::log("photo upload: new profile image upload ended", Logger::DEBUG);
        }
 
        if (isset($r) && $r) {
@@ -4533,23 +4610,23 @@ function post_photo_item($hash, $allow_cid, $deny_cid, $allow_gid, $deny_gid, $f
 {
        // get data about the api authenticated user
        $uri = Item::newURI(intval(api_user()));
-       $owner_record = q("SELECT * FROM `contact` WHERE `uid`= %d AND `self` LIMIT 1", intval(api_user()));
+       $owner_record = DBA::selectFirst('contact', [], ['uid' => api_user(), 'self' => true]);
 
        $arr = [];
-       $arr['guid']          = System::createGUID(32);
+       $arr['guid']          = System::createUUID();
        $arr['uid']           = intval(api_user());
        $arr['uri']           = $uri;
        $arr['parent-uri']    = $uri;
        $arr['type']          = 'photo';
        $arr['wall']          = 1;
        $arr['resource-id']   = $hash;
-       $arr['contact-id']    = $owner_record[0]['id'];
-       $arr['owner-name']    = $owner_record[0]['name'];
-       $arr['owner-link']    = $owner_record[0]['url'];
-       $arr['owner-avatar']  = $owner_record[0]['thumb'];
-       $arr['author-name']   = $owner_record[0]['name'];
-       $arr['author-link']   = $owner_record[0]['url'];
-       $arr['author-avatar'] = $owner_record[0]['thumb'];
+       $arr['contact-id']    = $owner_record['id'];
+       $arr['owner-name']    = $owner_record['name'];
+       $arr['owner-link']    = $owner_record['url'];
+       $arr['owner-avatar']  = $owner_record['thumb'];
+       $arr['author-name']   = $owner_record['name'];
+       $arr['author-link']   = $owner_record['url'];
+       $arr['author-avatar'] = $owner_record['thumb'];
        $arr['title']         = "";
        $arr['allow_cid']     = $allow_cid;
        $arr['allow_gid']     = $allow_gid;
@@ -4565,7 +4642,7 @@ function post_photo_item($hash, $allow_cid, $deny_cid, $allow_gid, $deny_gid, $f
                        ];
 
        // adds link to the thumbnail scale photo
-       $arr['body'] = '[url=' . System::baseUrl() . '/photos/' . $owner_record[0]['nick'] . '/image/' . $hash . ']'
+       $arr['body'] = '[url=' . System::baseUrl() . '/photos/' . $owner_record['nick'] . '/image/' . $hash . ']'
                                . '[img]' . System::baseUrl() . '/photo/' . $hash . '-' . "2" . '.'. $typetoext[$filetype] . '[/img]'
                                . '[/url]';
 
@@ -4602,7 +4679,7 @@ function prepare_photo_data($type, $scale, $photo_id)
                        FROM `photo` WHERE `uid` = %d AND `resource-id` = '%s' %s GROUP BY `resource-id`",
                $data_sql,
                intval(local_user()),
-               dbesc($photo_id),
+               DBA::escape($photo_id),
                $scale_sql
        );
 
@@ -4613,7 +4690,7 @@ function prepare_photo_data($type, $scale, $photo_id)
        ];
 
        // prepare output data for photo
-       if (DBM::is_result($r)) {
+       if (DBA::isResult($r)) {
                $data = ['photo' => $r[0]];
                $data['photo']['id'] = $data['photo']['resource-id'];
                if ($scale !== false) {
@@ -4706,9 +4783,9 @@ function api_friendica_remoteauth()
 
        // traditional DFRN
 
-       $contact = dba::selectFirst('contact', [], ['uid' => api_user(), 'nurl' => $c_url]);
+       $contact = DBA::selectFirst('contact', [], ['uid' => api_user(), 'nurl' => $c_url]);
 
-       if (!DBM::is_result($contact) || ($contact['network'] !== NETWORK_DFRN)) {
+       if (!DBA::isResult($contact) || ($contact['network'] !== Protocol::DFRN)) {
                throw new BadRequestException("Unknown contact");
        }
 
@@ -4729,11 +4806,12 @@ function api_friendica_remoteauth()
 
        $fields = ['uid' => api_user(), 'cid' => $cid, 'dfrn_id' => $dfrn_id,
                'sec' => $sec, 'expire' => time() + 45];
-       dba::insert('profile_check', $fields);
+       DBA::insert('profile_check', $fields);
 
-       logger($contact['name'] . ' ' . $sec, LOGGER_DEBUG);
+       Logger::log($contact['name'] . ' ' . $sec, Logger::DEBUG);
        $dest = ($url ? '&destination_url=' . $url : '');
-       goaway(
+
+       System::externalRedirect(
                $contact['poll'] . '?dfrn_id=' . $dfrn_id
                . '&dfrn_version=' . DFRN_PROTOCOL_VERSION
                . '&type=profile&sec=' . $sec . $dest
@@ -4751,77 +4829,86 @@ function api_share_as_retweet(&$item)
 {
        $body = trim($item["body"]);
 
-       if (Diaspora::isReshare($body, false)===false) {
-               return false;
+       if (Diaspora::isReshare($body, false) === false) {
+               if ($item['author-id'] == $item['owner-id']) {
+                       return false;
+               } else {
+                       // Reshares from OStatus, ActivityPub and Twitter
+                       $reshared_item = $item;
+                       $reshared_item['owner-id'] = $reshared_item['author-id'];
+                       $reshared_item['owner-link'] = $reshared_item['author-link'];
+                       $reshared_item['owner-name'] = $reshared_item['author-name'];
+                       $reshared_item['owner-avatar'] = $reshared_item['author-avatar'];
+                       return $reshared_item;
+               }
        }
 
        /// @TODO "$1" should maybe mean '$1' ?
        $attributes = preg_replace("/\[share(.*?)\]\s?(.*?)\s?\[\/share\]\s?/ism", "$1", $body);
        /*
-               * Skip if there is no shared message in there
-               * we already checked this in diaspora::isReshare()
-               * but better one more than one less...
-               */
-       if ($body == $attributes) {
+        * Skip if there is no shared message in there
+        * we already checked this in diaspora::isReshare()
+        * but better one more than one less...
+        */
+       if (($body == $attributes) || empty($attributes)) {
                return false;
        }
 
-
        // build the fake reshared item
        $reshared_item = $item;
 
        $author = "";
        preg_match("/author='(.*?)'/ism", $attributes, $matches);
-       if ($matches[1] != "") {
+       if (!empty($matches[1])) {
                $author = html_entity_decode($matches[1], ENT_QUOTES, 'UTF-8');
        }
 
        preg_match('/author="(.*?)"/ism', $attributes, $matches);
-       if ($matches[1] != "") {
+       if (!empty($matches[1])) {
                $author = $matches[1];
        }
 
        $profile = "";
        preg_match("/profile='(.*?)'/ism", $attributes, $matches);
-       if ($matches[1] != "") {
+       if (!empty($matches[1])) {
                $profile = $matches[1];
        }
 
        preg_match('/profile="(.*?)"/ism', $attributes, $matches);
-       if ($matches[1] != "") {
+       if (!empty($matches[1])) {
                $profile = $matches[1];
        }
 
        $avatar = "";
        preg_match("/avatar='(.*?)'/ism", $attributes, $matches);
-       if ($matches[1] != "") {
+       if (!empty($matches[1])) {
                $avatar = $matches[1];
        }
 
        preg_match('/avatar="(.*?)"/ism', $attributes, $matches);
-       if ($matches[1] != "") {
+       if (!empty($matches[1])) {
                $avatar = $matches[1];
        }
 
        $link = "";
        preg_match("/link='(.*?)'/ism", $attributes, $matches);
-       if ($matches[1] != "") {
+       if (!empty($matches[1])) {
                $link = $matches[1];
        }
 
        preg_match('/link="(.*?)"/ism', $attributes, $matches);
-       if ($matches[1] != "") {
+       if (!empty($matches[1])) {
                $link = $matches[1];
        }
 
        $posted = "";
        preg_match("/posted='(.*?)'/ism", $attributes, $matches);
-       if ($matches[1] != "") {
+       if (!empty($matches[1])) {
                $posted = $matches[1];
        }
 
        preg_match('/posted="(.*?)"/ism', $attributes, $matches);
-       if ($matches[1] != "") {
+       if (!empty($matches[1])) {
                $posted = $matches[1];
        }
 
@@ -4856,20 +4943,20 @@ function api_get_nick($profile)
 
        $r = q(
                "SELECT `nick` FROM `contact` WHERE `uid` = 0 AND `nurl` = '%s'",
-               dbesc(normalise_link($profile))
+               DBA::escape(normalise_link($profile))
        );
 
-       if (DBM::is_result($r)) {
+       if (DBA::isResult($r)) {
                $nick = $r[0]["nick"];
        }
 
        if (!$nick == "") {
                $r = q(
                        "SELECT `nick` FROM `contact` WHERE `uid` = 0 AND `nurl` = '%s'",
-                       dbesc(normalise_link($profile))
+                       DBA::escape(normalise_link($profile))
                );
 
-               if (DBM::is_result($r)) {
+               if (DBA::isResult($r)) {
                        $nick = $r[0]["nick"];
                }
        }
@@ -4944,7 +5031,7 @@ function api_in_reply_to($item)
 
        if (($item['thr-parent'] != $item['uri']) && (intval($item['parent']) != intval($item['id']))) {
                $parent = Item::selectFirst(['id'], ['uid' => $item['uid'], 'uri' => $item['thr-parent']]);
-               if (DBM::is_result($parent)) {
+               if (DBA::isResult($parent)) {
                        $in_reply_to['status_id'] = intval($parent['id']);
                } else {
                        $in_reply_to['status_id'] = intval($item['parent']);
@@ -4955,7 +5042,7 @@ function api_in_reply_to($item)
                $fields = ['author-nick', 'author-name', 'author-id', 'author-link'];
                $parent = Item::selectFirst($fields, ['id' => $in_reply_to['status_id']]);
 
-               if (DBM::is_result($parent)) {
+               if (DBA::isResult($parent)) {
                        if ($parent['author-nick'] == "") {
                                $parent['author-nick'] = api_get_nick($parent['author-link']);
                        }
@@ -4969,7 +5056,7 @@ function api_in_reply_to($item)
                // https://github.com/friendica/friendica/issues/1010
                // This is a bugfix for that.
                if (intval($in_reply_to['status_id']) == intval($item['id'])) {
-                       logger('this message should never appear: id: '.$item['id'].' similar to reply-to: '.$in_reply_to['status_id'], LOGGER_DEBUG);
+                       Logger::log('this message should never appear: id: '.$item['id'].' similar to reply-to: '.$in_reply_to['status_id'], Logger::DEBUG);
                        $in_reply_to['status_id'] = null;
                        $in_reply_to['user_id'] = null;
                        $in_reply_to['status_id_str'] = null;
@@ -5132,7 +5219,7 @@ function api_friendica_group_show($type)
                        intval($gid)
                );
                // error message if specified gid is not in database
-               if (!DBM::is_result($r)) {
+               if (!DBA::isResult($r)) {
                        throw new BadRequestException("gid not available");
                }
        } else {
@@ -5202,7 +5289,7 @@ function api_friendica_group_delete($type)
                intval($gid)
        );
        // error message if specified gid is not in database
-       if (!DBM::is_result($r)) {
+       if (!DBA::isResult($r)) {
                throw new BadRequestException('gid not available');
        }
 
@@ -5211,10 +5298,10 @@ function api_friendica_group_delete($type)
                "SELECT * FROM `group` WHERE `uid` = %d AND `id` = %d AND `name` = '%s'",
                intval($uid),
                intval($gid),
-               dbesc($name)
+               DBA::escape($name)
        );
        // error message if specified gid is not in database
-       if (!DBM::is_result($rname)) {
+       if (!DBA::isResult($rname)) {
                throw new BadRequestException('wrong group name');
        }
 
@@ -5257,7 +5344,7 @@ function api_lists_destroy($type)
        }
 
        // get data of the specified group id
-       $group = dba::selectFirst('group', [], ['uid' => $uid, 'id' => $gid]);
+       $group = DBA::selectFirst('group', [], ['uid' => $uid, 'id' => $gid]);
        // error message if specified gid is not in database
        if (!$group) {
                throw new BadRequestException('gid not available');
@@ -5296,10 +5383,10 @@ function group_create($name, $uid, $users = [])
        $rname = q(
                "SELECT * FROM `group` WHERE `uid` = %d AND `name` = '%s' AND `deleted` = 0",
                intval($uid),
-               dbesc($name)
+               DBA::escape($name)
        );
        // error message if specified group name already exists
-       if (DBM::is_result($rname)) {
+       if (DBA::isResult($rname)) {
                throw new BadRequestException('group name already exists');
        }
 
@@ -5307,10 +5394,10 @@ function group_create($name, $uid, $users = [])
        $rname = q(
                "SELECT * FROM `group` WHERE `uid` = %d AND `name` = '%s' AND `deleted` = 1",
                intval($uid),
-               dbesc($name)
+               DBA::escape($name)
        );
        // error message if specified group name already exists
-       if (DBM::is_result($rname)) {
+       if (DBA::isResult($rname)) {
                $reactivate_group = true;
        }
 
@@ -5511,7 +5598,7 @@ function api_lists_update($type)
        }
 
        // get data of the specified group id
-       $group = dba::selectFirst('group', [], ['uid' => $uid, 'id' => $gid]);
+       $group = DBA::selectFirst('group', [], ['uid' => $uid, 'id' => $gid]);
        // error message if specified gid is not in database
        if (!$group) {
                throw new BadRequestException('gid not available');
@@ -5641,7 +5728,7 @@ function api_friendica_notification_seen($type)
        if ($note['otype']=='item') {
                // would be really better with an ItemsManager and $im->getByID() :-P
                $item = Item::selectFirstForUser(api_user(), [], ['id' => $note['iid'], 'uid' => api_user()]);
-               if (DBM::is_result($$item)) {
+               if (DBA::isResult($item)) {
                        // we found the item, return it to the user
                        $ret = api_format_items([$item], $user_info, false, $type);
                        $data = ['status' => $ret];
@@ -5681,13 +5768,13 @@ function api_friendica_direct_messages_setseen($type)
        }
 
        // error message if specified id is not in database
-       if (!dba::exists('mail', ['id' => $id, 'uid' => $uid])) {
+       if (!DBA::exists('mail', ['id' => $id, 'uid' => $uid])) {
                $answer = ['result' => 'error', 'message' => 'message id not in database'];
                return api_format_data("direct_messages_setseen", $type, ['$result' => $answer]);
        }
 
        // update seen indicator
-       $result = dba::update('mail', ['seen' => true], ['id' => $id]);
+       $result = DBA::update('mail', ['seen' => true], ['id' => $id]);
 
        if ($result) {
                // return success
@@ -5734,13 +5821,13 @@ function api_friendica_direct_messages_search($type, $box = "")
        $r = q(
                "SELECT `mail`.*, `contact`.`nurl` AS `contact-url` FROM `mail`,`contact` WHERE `mail`.`contact-id` = `contact`.`id` AND `mail`.`uid`=%d AND `body` LIKE '%s' ORDER BY `mail`.`id` DESC",
                intval($uid),
-               dbesc('%'.$searchstring.'%')
+               DBA::escape('%'.$searchstring.'%')
        );
 
        $profile_url = $user_info["url"];
 
        // message if nothing was found
-       if (!DBM::is_result($r)) {
+       if (!DBA::isResult($r)) {
                $success = ['success' => false, 'search_results' => 'problem with query'];
        } elseif (count($r) == 0) {
                $success = ['success' => false, 'search_results' => 'nothing found'];
@@ -5798,7 +5885,7 @@ function api_friendica_profile_show($type)
                );
 
                // error message if specified gid is not in database
-               if (!DBM::is_result($r)) {
+               if (!DBA::isResult($r)) {
                        throw new BadRequestException("profile_id not available");
                }
        } else {
@@ -5818,7 +5905,7 @@ function api_friendica_profile_show($type)
                $nurls = q(
                        "SELECT `id`, `nurl` FROM `contact` WHERE `uid`= %d AND `profile-id` = %d",
                        intval(api_user()),
-                       intval($rr['profile_id'])
+                       intval($rr['id'])
                );
 
                foreach ($nurls as $nurl) {
@@ -5836,11 +5923,11 @@ function api_friendica_profile_show($type)
        }
 
        // return settings, authenticated user and profiles data
-       $self = q("SELECT `nurl` FROM `contact` WHERE `uid`= %d AND `self` LIMIT 1", intval(api_user()));
+       $self = DBA::selectFirst('contact', ['nurl'], ['uid' => api_user(), 'self' => true]);
 
        $result = ['multi_profiles' => $multi_profiles ? true : false,
                                        'global_dir' => $directory,
-                                       'friendica_owner' => api_get_user($a, $self[0]['nurl']),
+                                       'friendica_owner' => api_get_user($a, $self['nurl']),
                                        'profiles' => $profiles];
        return api_format_data("friendica_profiles", $type, ['$result' => $result]);
 }
@@ -5857,7 +5944,7 @@ api_register_func('api/friendica/profile/show', 'api_friendica_profile_show', tr
  */
 function api_saved_searches_list($type)
 {
-       $terms = dba::select('search', ['id', 'term'], ['uid' => local_user()]);
+       $terms = DBA::select('search', ['id', 'term'], ['uid' => local_user()]);
 
        $result = [];
        while ($term = $terms->fetch()) {
@@ -5871,7 +5958,7 @@ function api_saved_searches_list($type)
                ];
        }
 
-       dba::close($terms);
+       DBA::close($terms);
 
        return api_format_data("terms", $type, ['terms' => $result]);
 }