// Searching for contact URL
if (!is_null($contact_id) && (intval($contact_id) == 0)) {
- $user = DBA::escape(Strings::normaliseLink($contact_id));
+ $user = Strings::normaliseLink($contact_id);
$url = $user;
- $extra_query = "AND `contact`.`nurl` = '%s' ";
+ $extra_query = "AND `contact`.`nurl` = ? ";
if (api_user() !== false) {
$extra_query .= "AND `contact`.`uid`=" . intval(api_user());
}
// Searching for contact id with uid = 0
if (!is_null($contact_id) && (intval($contact_id) != 0)) {
- $user = DBA::escape(api_unique_id_to_nurl(intval($contact_id)));
+ $user = api_unique_id_to_nurl(intval($contact_id));
if ($user == "") {
throw new BadRequestException("User ID ".$contact_id." not found.");
}
$url = $user;
- $extra_query = "AND `contact`.`nurl` = '%s' ";
+ $extra_query = "AND `contact`.`nurl` = ? ";
if (api_user() !== false) {
$extra_query .= "AND `contact`.`uid`=" . intval(api_user());
}
}
if (is_null($user) && !empty($_GET['user_id'])) {
- $user = DBA::escape(api_unique_id_to_nurl($_GET['user_id']));
+ $user = api_unique_id_to_nurl($_GET['user_id']);
if ($user == "") {
throw new BadRequestException("User ID ".$_GET['user_id']." not found.");
}
$url = $user;
- $extra_query = "AND `contact`.`nurl` = '%s' ";
+ $extra_query = "AND `contact`.`nurl` = ? ";
if (api_user() !== false) {
$extra_query .= "AND `contact`.`uid`=" . intval(api_user());
}
}
if (is_null($user) && !empty($_GET['screen_name'])) {
- $user = DBA::escape($_GET['screen_name']);
- $extra_query = "AND `contact`.`nick` = '%s' ";
+ $user = $_GET['screen_name'];
+ $extra_query = "AND `contact`.`nick` = ? ";
if (api_user() !== false) {
$extra_query .= "AND `contact`.`uid`=".intval(api_user());
}
}
if (is_null($user) && !empty($_GET['profileurl'])) {
- $user = DBA::escape(Strings::normaliseLink($_GET['profileurl']));
- $extra_query = "AND `contact`.`nurl` = '%s' ";
+ $user = Strings::normaliseLink($_GET['profileurl']);
+ $extra_query = "AND `contact`.`nurl` = ? ";
if (api_user() !== false) {
$extra_query .= "AND `contact`.`uid`=".intval(api_user());
}
}
}
if (is_numeric($user)) {
- $user = DBA::escape(api_unique_id_to_nurl(intval($user)));
+ $user = api_unique_id_to_nurl(intval($user));
if ($user != "") {
$url = $user;
- $extra_query = "AND `contact`.`nurl` = '%s' ";
+ $extra_query = "AND `contact`.`nurl` = ? ";
if (api_user() !== false) {
$extra_query .= "AND `contact`.`uid`=" . intval(api_user());
}
}
} else {
- $user = DBA::escape($user);
- $extra_query = "AND `contact`.`nick` = '%s' ";
+ $extra_query = "AND `contact`.`nick` = ? ";
if (api_user() !== false) {
$extra_query .= "AND `contact`.`uid`=" . intval(api_user());
}
return false;
} else {
$user = api_user();
- $extra_query = "AND `contact`.`uid` = %d AND `contact`.`self` ";
+ $extra_query = "AND `contact`.`uid` = ? AND `contact`.`self` ";
}
}
Logger::info(API_LOG_PREFIX . 'found user {user}', ['module' => 'api', 'action' => 'get_user', 'user' => $user, 'extra_query' => $extra_query]);
// user info
- $uinfo = q(
+ $uinfo = DBA::toArray(DBA::p(
"SELECT *, `contact`.`id` AS `cid` FROM `contact`
WHERE 1
$extra_query",
$user
- );
+ ));
// Selecting the id by priority, friendica first
if (is_array($uinfo)) {
$a = DI::app();
if (api_user() === false) {
- Logger::log('api_statuses_update: no user');
+ logger::notice('api_statuses_update: no user');
throw new ForbiddenException();
}
$user_info = api_get_user($a);
$a = DI::app();
if (api_user() === false) {
- Logger::log('api_statuses_update: no user');
+ logger::notice('api_statuses_update: no user');
throw new ForbiddenException();
}
$posts_day = Post::count($condition);
if ($posts_day > $throttle_day) {
- Logger::log('Daily posting limit reached for user '.api_user(), Logger::DEBUG);
+ logger::info('Daily posting limit reached for user '.api_user());
// die(api_error($type, DI::l10n()->t("Daily posting limit of %d posts reached. The post was rejected.", $throttle_day));
throw new TooManyRequestsException(DI::l10n()->tt("Daily posting limit of %d post reached. The post was rejected.", "Daily posting limit of %d posts reached. The post was rejected.", $throttle_day));
}
$posts_week = Post::count($condition);
if ($posts_week > $throttle_week) {
- Logger::log('Weekly posting limit reached for user '.api_user(), Logger::DEBUG);
+ logger::info('Weekly posting limit reached for user '.api_user());
// die(api_error($type, DI::l10n()->t("Weekly posting limit of %d posts reached. The post was rejected.", $throttle_week)));
throw new TooManyRequestsException(DI::l10n()->tt("Weekly posting limit of %d post reached. The post was rejected.", "Weekly posting limit of %d posts reached. The post was rejected.", $throttle_week));
}
$posts_month = Post::count($condition);
if ($posts_month > $throttle_month) {
- Logger::log('Monthly posting limit reached for user '.api_user(), Logger::DEBUG);
+ logger::info('Monthly posting limit reached for user '.api_user());
// die(api_error($type, DI::l10n()->t("Monthly posting limit of %d posts reached. The post was rejected.", $throttle_month));
throw new TooManyRequestsException(DI::l10n()->t("Monthly posting limit of %d post reached. The post was rejected.", "Monthly posting limit of %d posts reached. The post was rejected.", $throttle_month));
}
$a = DI::app();
if (api_user() === false) {
- Logger::log('no user');
+ logger::notice('no user');
throw new ForbiddenException();
}
$id = intval(DI::args()->getArgv()[4] ?? 0);
}
- Logger::log('API: api_statuses_show: ' . $id);
+ logger::notice('API: api_statuses_show: ' . $id);
$conversation = !empty($_REQUEST['conversation']);
$id = intval(DI::args()->getArgv()[4] ?? 0);
}
- Logger::log('API: api_statuses_repeat: '.$id);
+ logger::notice('API: api_statuses_repeat: ' . $id);
$fields = ['uri-id', 'network', 'body', 'title', 'author-name', 'author-link', 'author-avatar', 'guid', 'created', 'plink'];
$item = Post::selectFirst($fields, ['id' => $id, 'private' => [Item::PUBLIC, Item::UNLISTED]]);
$id = intval(DI::args()->getArgv()[4] ?? 0);
}
- Logger::log('API: api_statuses_destroy: '.$id);
+ logger::notice('API: api_statuses_destroy: ' . $id);
$ret = api_statuses_show($type);
$sql_filter = 'AND (NOT `blocked` OR `pending`)';
}
- $r = q(
+ // @todo This query most likely can be replaced with a Contact::select...
+ $r = DBA::toArray(DBA::p(
"SELECT `nurl`
FROM `contact`
- WHERE `uid` = %d
+ WHERE `uid` = ?
AND NOT `self`
$sql_filter
$sql_extra
ORDER BY `nick`
- LIMIT %d, %d",
- intval(api_user()),
- intval($start),
- intval($count)
- );
+ LIMIT ?, ?",
+ api_user(),
+ $start,
+ $count
+ ));
$ret = [];
foreach ($r as $cid) {
// add parent-uri to sql command if specified by calling app
$sql_extra = ($parenturi != "" ? " AND `parent-uri` = '" . DBA::escape($parenturi) . "'" : "");
- // get data of the specified message id
- $r = q(
- "SELECT `id` FROM `mail` WHERE `uid` = %d AND `id` = %d" . $sql_extra,
- intval($uid),
- intval($id)
- );
-
// error message if specified id is not in database
- if (!DBA::isResult($r)) {
+ if (!DBA::exists('mail', ["`uid` = ? AND `id` = ? " . $sql_extra, $uid, $id])) {
if ($verbose == "true") {
$answer = ['result' => 'error', 'message' => 'message id not in database'];
return api_format_data("direct_messages_delete", $type, ['$result' => $answer]);
}
// delete message
- $result = q(
- "DELETE FROM `mail` WHERE `uid` = %d AND `id` = %d" . $sql_extra,
- intval($uid),
- intval($id)
- );
+ $result = DBA::delete('mail', ["`uid` = ? AND `id` = ? " . $sql_extra, $uid, $id]);
if ($verbose == "true") {
if ($result) {
$sql_extra .= " AND `contact`.`nick` = '" . DBA::escape($screen_name). "'";
}
- $r = q(
- "SELECT `mail`.*, `contact`.`nurl` AS `contact-url` FROM `mail`,`contact` WHERE `mail`.`contact-id` = `contact`.`id` AND `mail`.`uid`=%d AND $sql_extra AND `mail`.`id` > %d ORDER BY `mail`.`id` DESC LIMIT %d,%d",
- intval(api_user()),
- intval($since_id),
- intval($start),
- intval($count)
- );
+ $r = DBA::toArray(DBA::p(
+ "SELECT `mail`.*, `contact`.`nurl` AS `contact-url` FROM `mail`,`contact` WHERE `mail`.`contact-id` = `contact`.`id` AND `mail`.`uid` = ? AND $sql_extra AND `mail`.`id` > ? ORDER BY `mail`.`id` DESC LIMIT ?,?",
+ api_user(),
+ $since_id,
+ $start,
+ $count
+ ));
if ($verbose == "true" && !DBA::isResult($r)) {
$answer = ['result' => 'error', 'message' => 'no mails available'];
return api_format_data("direct_messages_all", $type, ['$result' => $answer]);
if (api_user() === false) {
throw new ForbiddenException();
}
- $r = q(
+ $r = DBA::toArray(DBA::p(
"SELECT `resource-id`, MAX(scale) AS `scale`, `album`, `filename`, `type`, MAX(`created`) AS `created`,
MAX(`edited`) AS `edited`, MAX(`desc`) AS `desc` FROM `photo`
- WHERE `uid` = %d AND `album` != 'Contact Photos' GROUP BY `resource-id`, `album`, `filename`, `type`",
- intval(local_user())
- );
+ WHERE `uid` = ? AND NOT `photo-type` IN (?, ?) GROUP BY `resource-id`, `album`, `filename`, `type`",
+ local_user(), Photo::CONTACT_AVATAR, Photo::CONTACT_BANNER
+ ));
$typetoext = [
'image/jpeg' => 'jpg',
'image/png' => 'png',
// now let's upload the new media in create-mode
if ($mode == "create") {
$media = $_FILES['media'];
- $data = save_media_to_database("photo", $media, $type, $album, trim($allow_cid), trim($deny_cid), trim($allow_gid), trim($deny_gid), $desc, $visibility);
+ $data = save_media_to_database("photo", $media, $type, $album, trim($allow_cid), trim($deny_cid), trim($allow_gid), trim($deny_gid), $desc, Photo::DEFAULT, $visibility);
// return success of updating or error message
if (!is_null($data)) {
if (!empty($_FILES['media'])) {
$nothingtodo = false;
$media = $_FILES['media'];
- $data = save_media_to_database("photo", $media, $type, $album, $allow_cid, $deny_cid, $allow_gid, $deny_gid, $desc, 0, $visibility, $photo_id);
+ $data = save_media_to_database("photo", $media, $type, $album, $allow_cid, $deny_cid, $allow_gid, $deny_gid, $desc, Photo::DEFAULT, $visibility, $photo_id);
if (!is_null($data)) {
return api_format_data("photo_update", $type, $data);
}
$media = $_FILES['media'];
}
// save new profile image
- $data = save_media_to_database("profileimage", $media, $type, DI::l10n()->t('Profile Photos'), "", "", "", "", "", $is_default_profile);
+ $data = save_media_to_database("profileimage", $media, $type, DI::l10n()->t(Photo::PROFILE_PHOTOS), "", "", "", "", "", Photo::USER_AVATAR);
// get filetype
if (is_array($media['type'])) {
// change specified profile or all profiles to the new resource-id
if ($is_default_profile) {
$condition = ["`profile` AND `resource-id` != ? AND `uid` = ?", $data['photo']['id'], api_user()];
- Photo::update(['profile' => false], $condition);
+ Photo::update(['profile' => false, 'photo-type' => Photo::DEFAULT], $condition);
} else {
$fields = ['photo' => DI::baseUrl() . '/photo/' . $data['photo']['id'] . '-4.' . $fileext,
'thumb' => DI::baseUrl() . '/photo/' . $data['photo']['id'] . '-5.' . $fileext];
* @param string $allow_gid
* @param string $deny_gid
* @param string $desc
- * @param integer $profile
+ * @param integer $phototype
* @param boolean $visibility
* @param string $photo_id
* @return array
* @throws NotFoundException
* @throws UnauthorizedException
*/
-function save_media_to_database($mediatype, $media, $type, $album, $allow_cid, $deny_cid, $allow_gid, $deny_gid, $desc, $profile = 0, $visibility = false, $photo_id = null)
+function save_media_to_database($mediatype, $media, $type, $album, $allow_cid, $deny_cid, $allow_gid, $deny_gid, $desc, $phototype = 0, $visibility = false, $photo_id = null)
{
$visitor = 0;
$src = "";
$filetype = Images::getMimeTypeBySource($src, $filename, $filetype);
- Logger::log(
+ logger::info(
"File upload src: " . $src . " - filename: " . $filename .
- " - size: " . $filesize . " - type: " . $filetype,
- Logger::DEBUG
- );
+ " - size: " . $filesize . " - type: " . $filetype);
// check if there was a php upload error
if ($filesize == 0 && $media['error'] == 1) {
}
if ($max_length > 0) {
$Image->scaleDown($max_length);
- Logger::log("File upload: Scaling picture to new size " . $max_length, Logger::DEBUG);
+ logger::info("File upload: Scaling picture to new size " . $max_length);
}
$width = $Image->getWidth();
$height = $Image->getHeight();
if ($mediatype == "photo") {
// upload normal image (scales 0, 1, 2)
- Logger::log("photo upload: starting new photo upload", Logger::DEBUG);
+ logger::info("photo upload: starting new photo upload");
- $r = Photo::store($Image, local_user(), $visitor, $resource_id, $filename, $album, 0, 0, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
+ $r = Photo::store($Image, local_user(), $visitor, $resource_id, $filename, $album, 0, Photo::DEFAULT, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
if (!$r) {
- Logger::log("photo upload: image upload with scale 0 (original size) failed");
+ logger::notice("photo upload: image upload with scale 0 (original size) failed");
}
if ($width > 640 || $height > 640) {
$Image->scaleDown(640);
- $r = Photo::store($Image, local_user(), $visitor, $resource_id, $filename, $album, 1, 0, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
+ $r = Photo::store($Image, local_user(), $visitor, $resource_id, $filename, $album, 1, Photo::DEFAULT, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
if (!$r) {
- Logger::log("photo upload: image upload with scale 1 (640x640) failed");
+ logger::notice("photo upload: image upload with scale 1 (640x640) failed");
}
}
if ($width > 320 || $height > 320) {
$Image->scaleDown(320);
- $r = Photo::store($Image, local_user(), $visitor, $resource_id, $filename, $album, 2, 0, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
+ $r = Photo::store($Image, local_user(), $visitor, $resource_id, $filename, $album, 2, Photo::DEFAULT, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
if (!$r) {
- Logger::log("photo upload: image upload with scale 2 (320x320) failed");
+ logger::notice("photo upload: image upload with scale 2 (320x320) failed");
}
}
- Logger::log("photo upload: new photo upload ended", Logger::DEBUG);
+ logger::info("photo upload: new photo upload ended");
} elseif ($mediatype == "profileimage") {
// upload profile image (scales 4, 5, 6)
- Logger::log("photo upload: starting new profile image upload", Logger::DEBUG);
+ logger::info("photo upload: starting new profile image upload");
if ($width > 300 || $height > 300) {
$Image->scaleDown(300);
- $r = Photo::store($Image, local_user(), $visitor, $resource_id, $filename, $album, 4, $profile, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
+ $r = Photo::store($Image, local_user(), $visitor, $resource_id, $filename, $album, 4, $phototype, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
if (!$r) {
- Logger::log("photo upload: profile image upload with scale 4 (300x300) failed");
+ logger::notice("photo upload: profile image upload with scale 4 (300x300) failed");
}
}
if ($width > 80 || $height > 80) {
$Image->scaleDown(80);
- $r = Photo::store($Image, local_user(), $visitor, $resource_id, $filename, $album, 5, $profile, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
+ $r = Photo::store($Image, local_user(), $visitor, $resource_id, $filename, $album, 5, $phototype, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
if (!$r) {
- Logger::log("photo upload: profile image upload with scale 5 (80x80) failed");
+ logger::notice("photo upload: profile image upload with scale 5 (80x80) failed");
}
}
if ($width > 48 || $height > 48) {
$Image->scaleDown(48);
- $r = Photo::store($Image, local_user(), $visitor, $resource_id, $filename, $album, 6, $profile, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
+ $r = Photo::store($Image, local_user(), $visitor, $resource_id, $filename, $album, 6, $phototype, $allow_cid, $allow_gid, $deny_cid, $deny_gid, $desc);
if (!$r) {
- Logger::log("photo upload: profile image upload with scale 6 (48x48) failed");
+ logger::notice("photo upload: profile image upload with scale 6 (48x48) failed");
}
}
$Image->__destruct();
- Logger::log("photo upload: new profile image upload ended", Logger::DEBUG);
+ logger::info("photo upload: new profile image upload ended");
}
if (!empty($r)) {
// added allow_cid, allow_gid, deny_cid, deny_gid to output as string like stored in database
// clients needs to convert this in their way for further processing
- $r = q(
- "SELECT %s `resource-id`, `created`, `edited`, `title`, `desc`, `album`, `filename`,
+ $r = DBA::toArray(DBA::p(
+ "SELECT $data_sql `resource-id`, `created`, `edited`, `title`, `desc`, `album`, `filename`,
`type`, `height`, `width`, `datasize`, `profile`, `allow_cid`, `deny_cid`, `allow_gid`, `deny_gid`,
MIN(`scale`) AS `minscale`, MAX(`scale`) AS `maxscale`
- FROM `photo` WHERE `uid` = %d AND `resource-id` = '%s' %s GROUP BY
+ FROM `photo` WHERE `uid` = ? AND `resource-id` = ? $scale_sql GROUP BY
`resource-id`, `created`, `edited`, `title`, `desc`, `album`, `filename`,
`type`, `height`, `width`, `datasize`, `profile`, `allow_cid`, `deny_cid`, `allow_gid`, `deny_gid`",
- $data_sql,
- intval(local_user()),
- DBA::escape($photo_id),
- $scale_sql
- );
+ local_user(),
+ $photo_id
+ ));
$typetoext = [
'image/jpeg' => 'jpg',
throw new BadRequestException('group name not specified');
}
- // error message if specified group name already exists
+ // error message if specified group name already exists
if (DBA::exists('group', ['uid' => $uid, 'name' => $name, 'deleted' => false])) {
throw new BadRequestException('group name already exists');
}
}
// get data for the specified searchstring
- $r = q(
- "SELECT `mail`.*, `contact`.`nurl` AS `contact-url` FROM `mail`,`contact` WHERE `mail`.`contact-id` = `contact`.`id` AND `mail`.`uid`=%d AND `body` LIKE '%s' ORDER BY `mail`.`id` DESC",
- intval($uid),
- DBA::escape('%'.$searchstring.'%')
- );
+ $r = DBA::toArray(DBA::p(
+ "SELECT `mail`.*, `contact`.`nurl` AS `contact-url` FROM `mail`,`contact` WHERE `mail`.`contact-id` = `contact`.`id` AND `mail`.`uid` = ? AND `body` LIKE ? ORDER BY `mail`.`id` DESC",
+ $uid,
+ '%'.$searchstring.'%'
+ ));
$profile_url = $user_info["url"];