use Friendica\Util\DateTimeFormat;
use Friendica\Util\Network;
use Friendica\Util\Proxy as ProxyUtils;
+use Friendica\Util\Strings;
use Friendica\Util\XML;
require_once 'include/conversation.php';
*/
function api_user()
{
- if (x($_SESSION, 'allow_api')) {
+ if (!empty($_SESSION['allow_api'])) {
return local_user();
}
}
// workaround for HTTP-auth in CGI mode
- if (x($_SERVER, 'REDIRECT_REMOTE_USER')) {
- $userpass = base64_decode(substr($_SERVER["REDIRECT_REMOTE_USER"], 6)) ;
+ if (!empty($_SERVER['REDIRECT_REMOTE_USER'])) {
+ $userpass = base64_decode(substr($_SERVER["REDIRECT_REMOTE_USER"], 6));
if (strlen($userpass)) {
list($name, $password) = explode(':', $userpass);
$_SERVER['PHP_AUTH_USER'] = $name;
}
}
- if (!x($_SERVER, 'PHP_AUTH_USER')) {
+ if (empty($_SERVER['PHP_AUTH_USER'])) {
Logger::log('API_login: ' . print_r($_SERVER, true), Logger::DEBUG);
header('WWW-Authenticate: Basic realm="Friendica"');
throw new UnauthorizedException("This API requires login");
case "json":
header("Content-Type: application/json");
$json = json_encode(end($return));
- if (x($_GET, 'callback')) {
+ if (!empty($_GET['callback'])) {
$json = $_GET['callback'] . "(" . $json . ")";
}
$return = $json;
// Searching for contact URL
if (!is_null($contact_id) && (intval($contact_id) == 0)) {
- $user = DBA::escape(normalise_link($contact_id));
+ $user = DBA::escape(Strings::normaliseLink($contact_id));
$url = $user;
$extra_query = "AND `contact`.`nurl` = '%s' ";
if (api_user() !== false) {
}
}
- if (is_null($user) && x($_GET, 'user_id')) {
+ if (is_null($user) && !empty($_GET['user_id'])) {
$user = DBA::escape(api_unique_id_to_nurl($_GET['user_id']));
if ($user == "") {
$extra_query .= "AND `contact`.`uid`=" . intval(api_user());
}
}
- if (is_null($user) && x($_GET, 'screen_name')) {
+ if (is_null($user) && !empty($_GET['screen_name'])) {
$user = DBA::escape($_GET['screen_name']);
$extra_query = "AND `contact`.`nick` = '%s' ";
if (api_user() !== false) {
}
}
- if (is_null($user) && x($_GET, 'profileurl')) {
- $user = DBA::escape(normalise_link($_GET['profileurl']));
+ if (is_null($user) && !empty($_GET['profileurl'])) {
+ $user = DBA::escape(Strings::normaliseLink($_GET['profileurl']));
$extra_query = "AND `contact`.`nurl` = '%s' ";
if (api_user() !== false) {
$extra_query .= "AND `contact`.`uid`=".intval(api_user());
throw new BadRequestException("User not found.");
}
- $contact = DBA::selectFirst('contact', [], ['uid' => 0, 'nurl' => normalise_link($url)]);
+ $contact = DBA::selectFirst('contact', [], ['uid' => 0, 'nurl' => Strings::normaliseLink($url)]);
if (DBA::isResult($contact)) {
$network_name = ContactSelector::networkToName($contact['network'], $contact['url']);
unset($_REQUEST["screen_name"]);
unset($_GET["screen_name"]);
- $skip_status = (x($_REQUEST, 'skip_status')?$_REQUEST['skip_status'] : false);
+ $skip_status = defaults($_REQUEST, 'skip_status', false);
$user_info = api_get_user($a);
*/
function requestdata($k)
{
- if (x($_POST, $k)) {
+ if (!empty($_POST[$k])) {
return $_POST[$k];
}
- if (x($_GET, $k)) {
+ if (!empty($_GET[$k])) {
return $_GET[$k];
}
return null;
//$txt = urldecode(requestdata('status'));
if ((strpos($txt, '<') !== false) || (strpos($txt, '>') !== false)) {
- $txt = HTML::toBBVideo($txt);
+ $txt = HTML::toBBCodeVideo($txt);
$config = HTMLPurifier_Config::createDefault();
$config->set('Cache.DefinitionImpl', null);
$purifier = new HTMLPurifier($config);
if (requestdata('htmlstatus')) {
$txt = requestdata('htmlstatus');
if ((strpos($txt, '<') !== false) || (strpos($txt, '>') !== false)) {
- $txt = HTML::toBBVideo($txt);
+ $txt = HTML::toBBCodeVideo($txt);
$config = HTMLPurifier_Config::createDefault();
$config->set('Cache.DefinitionImpl', null);
}
}
- if (x($_FILES, 'media')) {
+ if (!empty($_FILES['media'])) {
// upload the image if we have one
$picture = wall_upload_post($a, false);
if (is_array($picture)) {
$_REQUEST['api_source'] = true;
- if (!x($_REQUEST, "source")) {
+ if (empty($_REQUEST['source'])) {
$_REQUEST["source"] = api_source();
}
api_get_user($a);
- if (!x($_FILES, 'media')) {
+ if (empty($_FILES['media'])) {
// Output error
throw new BadRequestException("No media.");
}
$userlist = [];
- if (x($_GET, 'q')) {
+ if (!empty($_GET['q'])) {
$r = q("SELECT id FROM `contact` WHERE `uid` = 0 AND `name` = '%s'", DBA::escape($_GET["q"]));
if (!DBA::isResult($r)) {
$data = [];
- if (!x($_REQUEST, 'q')) {
+ if (empty($_REQUEST['q'])) {
throw new BadRequestException("q parameter is required.");
}
- if (x($_REQUEST, 'rpp')) {
+ if (!empty($_REQUEST['rpp'])) {
$count = $_REQUEST['rpp'];
- } elseif (x($_REQUEST, 'count')) {
+ } elseif (!empty($_REQUEST['count'])) {
$count = $_REQUEST['count'];
} else {
$count = 15;
}
- $since_id = (x($_REQUEST, 'since_id') ? $_REQUEST['since_id'] : 0);
- $max_id = (x($_REQUEST, 'max_id') ? $_REQUEST['max_id'] : 0);
- $page = (x($_REQUEST, 'page') ? $_REQUEST['page'] - 1 : 0);
+ $since_id = defaults($_REQUEST, 'since_id', 0);
+ $max_id = defaults($_REQUEST, 'max_id', 0);
+ $page = (!empty($_REQUEST['page']) ? $_REQUEST['page'] - 1 : 0);
$start = $page * $count;
// get last network messages
// params
- $count = (x($_REQUEST, 'count') ? $_REQUEST['count'] : 20);
- $page = (x($_REQUEST, 'page') ? $_REQUEST['page'] - 1 : 0);
+ $count = defaults($_REQUEST, 'count', 20);
+ $page = (!empty($_REQUEST['page']) ? $_REQUEST['page'] - 1 : 0);
if ($page < 0) {
$page = 0;
}
- $since_id = (x($_REQUEST, 'since_id') ? $_REQUEST['since_id'] : 0);
- $max_id = (x($_REQUEST, 'max_id') ? $_REQUEST['max_id'] : 0);
- //$since_id = 0;//$since_id = (x($_REQUEST, 'since_id')?$_REQUEST['since_id'] : 0);
- $exclude_replies = (x($_REQUEST, 'exclude_replies') ? 1 : 0);
- $conversation_id = (x($_REQUEST, 'conversation_id') ? $_REQUEST['conversation_id'] : 0);
+ $since_id = defaults($_REQUEST, 'since_id', 0);
+ $max_id = defaults($_REQUEST, 'max_id', 0);
+ $exclude_replies = !empty($_REQUEST['exclude_replies']);
+ $conversation_id = defaults($_REQUEST, 'conversation_id', 0);
$start = $page * $count;
$condition[0] .= " AND `item`.`id` <= ?";
$condition[] = $max_id;
}
- if ($exclude_replies > 0) {
+ if ($exclude_replies) {
$condition[0] .= ' AND `item`.`parent` = `item`.`id`';
}
if ($conversation_id > 0) {
$data = ['status' => $ret];
switch ($type) {
case "atom":
+ break;
case "rss":
$data = api_rss_extra($a, $data, $user_info);
break;
// get last network messages
// params
- $count = (x($_REQUEST, 'count') ? $_REQUEST['count'] : 20);
- $page = (x($_REQUEST, 'page') ? $_REQUEST['page'] -1 : 0);
+ $count = defaults($_REQUEST, 'count', 20);
+ $page = (!empty($_REQUEST['page']) ? $_REQUEST['page'] -1 : 0);
if ($page < 0) {
$page = 0;
}
- $since_id = (x($_REQUEST, 'since_id') ? $_REQUEST['since_id'] : 0);
- $max_id = (x($_REQUEST, 'max_id') ? $_REQUEST['max_id'] : 0);
- //$since_id = 0;//$since_id = (x($_REQUEST, 'since_id')?$_REQUEST['since_id'] : 0);
- $exclude_replies = (x($_REQUEST, 'exclude_replies') ? 1 : 0);
- $conversation_id = (x($_REQUEST, 'conversation_id') ? $_REQUEST['conversation_id'] : 0);
+ $since_id = defaults($_REQUEST, 'since_id', 0);
+ $max_id = defaults($_REQUEST, 'max_id', 0);
+ $exclude_replies = (!empty($_REQUEST['exclude_replies']) ? 1 : 0);
+ $conversation_id = defaults($_REQUEST, 'conversation_id', 0);
$start = $page * $count;
- $sql_extra = '';
if ($exclude_replies && !$conversation_id) {
$condition = ["`gravity` IN (?, ?) AND `iid` > ? AND NOT `private` AND `wall` AND NOT `user`.`hidewall`",
$data = ['status' => $ret];
switch ($type) {
case "atom":
+ break;
case "rss":
$data = api_rss_extra($a, $data, $user_info);
break;
throw new ForbiddenException();
}
- $since_id = x($_REQUEST, 'since_id') ? $_REQUEST['since_id'] : 0;
- $max_id = x($_REQUEST, 'max_id') ? $_REQUEST['max_id'] : 0;
+ $since_id = defaults($_REQUEST, 'since_id', 0);
+ $max_id = defaults($_REQUEST, 'max_id', 0);
// pagination
- $count = x($_REQUEST, 'count') ? $_REQUEST['count'] : 20;
- $page = x($_REQUEST, 'page') ? $_REQUEST['page'] : 1;
+ $count = defaults($_REQUEST, 'count', 20);
+ $page = defaults($_REQUEST, 'page', 1);
if ($page < 1) {
$page = 1;
}
$data = ['status' => $ret];
switch ($type) {
case "atom":
+ break;
case "rss":
$data = api_rss_extra($a, $data, $user_info);
break;
$_REQUEST['profile_uid'] = api_user();
$_REQUEST['api_source'] = true;
- if (!x($_REQUEST, "source")) {
+ if (empty($_REQUEST['source'])) {
$_REQUEST["source"] = api_source();
}
$data = ['status' => $ret];
switch ($type) {
case "atom":
+ break;
case "rss":
$data = api_rss_extra($a, $data, $user_info);
break;
Logger::DEBUG
);
- $since_id = x($_REQUEST, 'since_id') ? $_REQUEST['since_id'] : 0;
- $max_id = x($_REQUEST, 'max_id') ? $_REQUEST['max_id'] : 0;
- $exclude_replies = x($_REQUEST, 'exclude_replies') ? 1 : 0;
- $conversation_id = x($_REQUEST, 'conversation_id') ? $_REQUEST['conversation_id'] : 0;
+ $since_id = defaults($_REQUEST, 'since_id', 0);
+ $max_id = defaults($_REQUEST, 'max_id', 0);
+ $exclude_replies = !empty($_REQUEST['exclude_replies']);
+ $conversation_id = defaults($_REQUEST, 'conversation_id', 0);
// pagination
- $count = x($_REQUEST, 'count') ? $_REQUEST['count'] : 20;
- $page = x($_REQUEST, 'page') ? $_REQUEST['page'] : 1;
+ $count = defaults($_REQUEST, 'count', 20);
+ $page = defaults($_REQUEST, 'page', 1);
if ($page < 1) {
$page = 1;
}
$condition[0] .= ' AND `item`.`wall` ';
}
- if ($exclude_replies > 0) {
+ if ($exclude_replies) {
$condition[0] .= ' AND `item`.`parent` = `item`.`id`';
}
$data = ['status' => $ret];
switch ($type) {
case "atom":
+ break;
case "rss":
$data = api_rss_extra($a, $data, $user_info);
break;
$data = ['status' => $ret];
switch ($type) {
case "atom":
+ break;
case "rss":
$data = api_rss_extra($a, $data, $user_info);
+ break;
}
return api_format_data("status", $type, $data);
$ret = [];
} else {
// params
- $since_id = (x($_REQUEST, 'since_id') ? $_REQUEST['since_id'] : 0);
- $max_id = (x($_REQUEST, 'max_id') ? $_REQUEST['max_id'] : 0);
- $count = (x($_GET, 'count') ? $_GET['count'] : 20);
- $page = (x($_REQUEST, 'page') ? $_REQUEST['page'] -1 : 0);
+ $since_id = defaults($_REQUEST, 'since_id', 0);
+ $max_id = defaults($_REQUEST, 'max_id', 0);
+ $count = defaults($_GET, 'count', 20);
+ $page = (!empty($_REQUEST['page']) ? $_REQUEST['page'] -1 : 0);
if ($page < 0) {
$page = 0;
}
$data = ['status' => $ret];
switch ($type) {
case "atom":
+ break;
case "rss":
$data = api_rss_extra($a, $data, $user_info);
+ break;
}
return api_format_data("statuses", $type, $data);
}
//don't send title to regular StatusNET requests to avoid confusing these apps
- if (x($_GET, 'getText')) {
+ if (!empty($_GET['getText'])) {
$ret['title'] = $item['title'];
if ($_GET['getText'] == 'html') {
$ret['text'] = BBCode::convert($item['body'], false);
} else {
$ret['text'] = $item['title'] . "\n" . HTML::toPlaintext(BBCode::convert(api_clean_plain_items($item['body']), false, 2, true), 0);
}
- if (x($_GET, 'getUserObjects') && $_GET['getUserObjects'] == 'false') {
+ if (!empty($_GET['getUserObjects']) && $_GET['getUserObjects'] == 'false') {
unset($ret['sender']);
unset($ret['recipient']);
}
*/
function api_get_entitities(&$text, $bbcode)
{
- $include_entities = strtolower(x($_REQUEST, 'include_entities') ? $_REQUEST['include_entities'] : "false");
+ $include_entities = strtolower(defaults($_REQUEST, 'include_entities', "false"));
if ($include_entities != "true") {
preg_match_all("/\[img](.*?)\[\/img\]/ism", $bbcode, $images);
"id" => $start+1,
"id_str" => (string)$start+1,
"indices" => [$start, $start+strlen($url)],
- "media_url" => normalise_link($media_url),
+ "media_url" => Strings::normaliseLink($media_url),
"media_url_https" => $media_url,
"url" => $url,
"display_url" => $display_url,
$retweeted_item = api_share_as_retweet($item);
if ($retweeted_item !== false) {
$retweeted_status = $status;
+ $status['user'] = $status['friendica_owner'];
try {
$retweeted_status["user"] = api_get_user($a, $retweeted_item["author-id"]);
} catch (BadRequestException $e) {
}
// params
- $count = (x($_REQUEST, 'count') ? $_REQUEST['count'] : 20);
- $page = (x($_REQUEST, 'page') ? $_REQUEST['page'] - 1 : 0);
+ $count = defaults($_REQUEST, 'count', 20);
+ $page = (!empty($_REQUEST['page']) ? $_REQUEST['page'] - 1 : 0);
if ($page < 0) {
$page = 0;
}
- $since_id = (x($_REQUEST, 'since_id') ? $_REQUEST['since_id'] : 0);
- $max_id = (x($_REQUEST, 'max_id') ? $_REQUEST['max_id'] : 0);
- $exclude_replies = (x($_REQUEST, 'exclude_replies') ? 1 : 0);
- $conversation_id = (x($_REQUEST, 'conversation_id') ? $_REQUEST['conversation_id'] : 0);
+ $since_id = defaults($_REQUEST, 'since_id', 0);
+ $max_id = defaults($_REQUEST, 'max_id', 0);
+ $exclude_replies = (!empty($_REQUEST['exclude_replies']) ? 1 : 0);
+ $conversation_id = defaults($_REQUEST, 'conversation_id', 0);
$start = $page * $count;
$data = ['status' => $items];
switch ($type) {
case "atom":
+ break;
case "rss":
$data = api_rss_extra($a, $data, $user_info);
break;
}
// pagination
- $count = x($_GET, 'count') ? $_GET['count'] : 20;
- $page = x($_GET, 'page') ? $_GET['page'] : 1;
+ $count = defaults($_GET, 'count', 20);
+ $page = defaults($_GET, 'page', 1);
if ($page < 1) {
$page = 1;
}
$user_info = api_get_user($a);
- if (x($_GET, 'cursor') && $_GET['cursor'] == 'undefined') {
+ if (!empty($_GET['cursor']) && $_GET['cursor'] == 'undefined') {
/* this is to stop Hotot to load friends multiple times
* I'm not sure if I'm missing return something or
* is a bug in hotot. Workaround, meantime
$replyto = '';
$sub = '';
- if (x($_REQUEST, 'replyto')) {
+ if (!empty($_REQUEST['replyto'])) {
$r = q(
'SELECT `parent-uri`, `title` FROM `mail` WHERE `uid`=%d AND `id`=%d',
intval(api_user()),
$replyto = $r[0]['parent-uri'];
$sub = $r[0]['title'];
} else {
- if (x($_REQUEST, 'title')) {
+ if (!empty($_REQUEST['title'])) {
$sub = $_REQUEST['title'];
} else {
$sub = ((strlen($_POST['text'])>10) ? substr($_POST['text'], 0, 10)."...":$_POST['text']);
switch ($type) {
case "atom":
+ break;
case "rss":
$data = api_rss_extra($a, $data, $sender);
+ break;
}
return api_format_data("direct-messages", $type, $data);
// params
$user_info = api_get_user($a);
//required
- $id = (x($_REQUEST, 'id') ? $_REQUEST['id'] : 0);
+ $id = defaults($_REQUEST, 'id', 0);
// optional
- $parenturi = (x($_REQUEST, 'friendica_parenturi') ? $_REQUEST['friendica_parenturi'] : "");
- $verbose = (x($_GET, 'friendica_verbose') ? strtolower($_GET['friendica_verbose']) : "false");
+ $parenturi = defaults($_REQUEST, 'friendica_parenturi', "");
+ $verbose = (!empty($_GET['friendica_verbose']) ? strtolower($_GET['friendica_verbose']) : "false");
/// @todo optional parameter 'include_entities' from Twitter API not yet implemented
$uid = $user_info['uid'];
/**
* Unfollow Contact
*
- * @brief unfollow contact
+ * @brief unfollow contact
*
* @param string $type Known types are 'atom', 'rss', 'xml' and 'json'
* @return string|array
$url = $contact["url"];
$condition = ["`uid` = ? AND (`rel` = ? OR `rel` = ?) AND (`nurl` = ? OR `alias` = ? OR `alias` = ?)",
- $uid, Contact::SHARING, Contact::FRIEND, normalise_link($url),
- normalise_link($url), $url];
+ $uid, Contact::SHARING, Contact::FRIEND, Strings::normaliseLink($url),
+ Strings::normaliseLink($url), $url];
$contact = DBA::selectFirst('contact', [], $condition);
if (!DBA::isResult($contact)) {
foreach ($r as $item) {
if ($box == "inbox" || $item['from-url'] != $profile_url) {
$recipient = $user_info;
- $sender = api_get_user($a, normalise_link($item['contact-url']));
+ $sender = api_get_user($a, Strings::normaliseLink($item['contact-url']));
} elseif ($box == "sentbox" || $item['from-url'] == $profile_url) {
- $recipient = api_get_user($a, normalise_link($item['contact-url']));
+ $recipient = api_get_user($a, Strings::normaliseLink($item['contact-url']));
$sender = $user_info;
}
$data = ['direct_message' => $ret];
switch ($type) {
case "atom":
+ break;
case "rss":
$data = api_rss_extra($a, $data, $user_info);
+ break;
}
return api_format_data("direct-messages", $type, $data);
*/
function api_direct_messages_sentbox($type)
{
- $verbose = (x($_GET, 'friendica_verbose') ? strtolower($_GET['friendica_verbose']) : "false");
+ $verbose = !empty($_GET['friendica_verbose']) ? strtolower($_GET['friendica_verbose']) : "false";
return api_direct_messages_box($type, "sentbox", $verbose);
}
*/
function api_direct_messages_inbox($type)
{
- $verbose = (x($_GET, 'friendica_verbose') ? strtolower($_GET['friendica_verbose']) : "false");
+ $verbose = !empty($_GET['friendica_verbose']) ? strtolower($_GET['friendica_verbose']) : "false";
return api_direct_messages_box($type, "inbox", $verbose);
}
*/
function api_direct_messages_all($type)
{
- $verbose = (x($_GET, 'friendica_verbose') ? strtolower($_GET['friendica_verbose']) : "false");
+ $verbose = !empty($_GET['friendica_verbose']) ? strtolower($_GET['friendica_verbose']) : "false";
return api_direct_messages_box($type, "all", $verbose);
}
*/
function api_direct_messages_conversation($type)
{
- $verbose = (x($_GET, 'friendica_verbose') ? strtolower($_GET['friendica_verbose']) : "false");
+ $verbose = !empty($_GET['friendica_verbose']) ? strtolower($_GET['friendica_verbose']) : "false";
return api_direct_messages_box($type, "conversation", $verbose);
}
throw new ForbiddenException();
}
// input params
- $album = (x($_REQUEST, 'album') ? $_REQUEST['album'] : "");
+ $album = defaults($_REQUEST, 'album', "");
// we do not allow calls without album string
if ($album == "") {
throw new ForbiddenException();
}
// input params
- $album = (x($_REQUEST, 'album') ? $_REQUEST['album'] : "");
- $album_new = (x($_REQUEST, 'album_new') ? $_REQUEST['album_new'] : "");
+ $album = defaults($_REQUEST, 'album', "");
+ $album_new = defaults($_REQUEST, 'album_new', "");
// we do not allow calls without album string
if ($album == "") {
throw new ForbiddenException();
}
// input params
- $photo_id = (x($_REQUEST, 'photo_id') ? $_REQUEST['photo_id'] : null);
- $desc = (x($_REQUEST, 'desc') ? $_REQUEST['desc'] : (array_key_exists('desc', $_REQUEST) ? "" : null)); // extra check necessary to distinguish between 'not provided' and 'empty string'
- $album = (x($_REQUEST, 'album') ? $_REQUEST['album'] : null);
- $album_new = (x($_REQUEST, 'album_new') ? $_REQUEST['album_new'] : null);
- $allow_cid = (x($_REQUEST, 'allow_cid') ? $_REQUEST['allow_cid'] : (array_key_exists('allow_cid', $_REQUEST) ? " " : null));
- $deny_cid = (x($_REQUEST, 'deny_cid') ? $_REQUEST['deny_cid'] : (array_key_exists('deny_cid', $_REQUEST) ? " " : null));
- $allow_gid = (x($_REQUEST, 'allow_gid') ? $_REQUEST['allow_gid'] : (array_key_exists('allow_gid', $_REQUEST) ? " " : null));
- $deny_gid = (x($_REQUEST, 'deny_gid') ? $_REQUEST['deny_gid'] : (array_key_exists('deny_gid', $_REQUEST) ? " " : null));
- $visibility = (x($_REQUEST, 'visibility') ? (($_REQUEST['visibility'] == "true" || $_REQUEST['visibility'] == 1) ? true : false) : false);
+ $photo_id = defaults($_REQUEST, 'photo_id', null);
+ $desc = defaults($_REQUEST, 'desc', (array_key_exists('desc', $_REQUEST) ? "" : null)) ; // extra check necessary to distinguish between 'not provided' and 'empty string'
+ $album = defaults($_REQUEST, 'album', null);
+ $album_new = defaults($_REQUEST, 'album_new', null);
+ $allow_cid = defaults($_REQUEST, 'allow_cid', (array_key_exists('allow_cid', $_REQUEST) ? " " : null));
+ $deny_cid = defaults($_REQUEST, 'deny_cid' , (array_key_exists('deny_cid' , $_REQUEST) ? " " : null));
+ $allow_gid = defaults($_REQUEST, 'allow_gid', (array_key_exists('allow_gid', $_REQUEST) ? " " : null));
+ $deny_gid = defaults($_REQUEST, 'deny_gid' , (array_key_exists('deny_gid' , $_REQUEST) ? " " : null));
+ $visibility = !empty($_REQUEST['visibility']) && $_REQUEST['visibility'] !== "false";
// do several checks on input parameters
// we do not allow calls without album string
$mode = "create";
// error if no media posted in create-mode
- if (!x($_FILES, 'media')) {
+ if (empty($_FILES['media'])) {
// Output error
throw new BadRequestException("no media data submitted");
}
$nothingtodo = true;
}
- if (x($_FILES, 'media')) {
+ if (!empty($_FILES['media'])) {
$nothingtodo = false;
$media = $_FILES['media'];
$data = save_media_to_database("photo", $media, $type, $album, $allow_cid, $deny_cid, $allow_gid, $deny_gid, $desc, 0, $visibility, $photo_id);
throw new ForbiddenException();
}
// input params
- $photo_id = (x($_REQUEST, 'photo_id') ? $_REQUEST['photo_id'] : null);
+ $photo_id = defaults($_REQUEST, 'photo_id', null);
// do several checks on input parameters
// we do not allow calls without photo id
if (api_user() === false) {
throw new ForbiddenException();
}
- if (!x($_REQUEST, 'photo_id')) {
+ if (empty($_REQUEST['photo_id'])) {
throw new BadRequestException("No photo id.");
}
- $scale = (x($_REQUEST, 'scale') ? intval($_REQUEST['scale']) : false);
+ $scale = (!empty($_REQUEST['scale']) ? intval($_REQUEST['scale']) : false);
$photo_id = $_REQUEST['photo_id'];
// prepare json/xml output with data from database for the requested photo
$profile_id = defaults($_REQUEST, 'profile_id', 0);
// error if image data is missing
- if (!x($_FILES, 'image')) {
+ if (empty($_FILES['image'])) {
throw new BadRequestException("no media data submitted");
}
// get mediadata from image or media (Twitter call api/account/update_profile_image provides image)
$media = null;
- if (x($_FILES, 'image')) {
+ if (!empty($_FILES['image'])) {
$media = $_FILES['image'];
- } elseif (x($_FILES, 'media')) {
+ } elseif (!empty($_FILES['media'])) {
$media = $_FILES['media'];
}
// save new profile image
// check against max upload size within Friendica instance
$maximagesize = Config::get('system', 'maximagesize');
if ($maximagesize && ($filesize > $maximagesize)) {
- $formattedBytes = formatBytes($maximagesize);
+ $formattedBytes = Strings::formatBytes($maximagesize);
throw new InternalServerErrorException("image size exceeds Friendica config setting (uploaded size: $formattedBytes)");
}
*/
function api_friendica_remoteauth()
{
- $url = (x($_GET, 'url') ? $_GET['url'] : '');
- $c_url = (x($_GET, 'c_url') ? $_GET['c_url'] : '');
+ $url = defaults($_GET, 'url', '');
+ $c_url = defaults($_GET, 'c_url', '');
if ($url === '' || $c_url === '') {
throw new BadRequestException("Wrong parameters.");
}
- $c_url = normalise_link($c_url);
+ $c_url = Strings::normaliseLink($c_url);
// traditional DFRN
$dfrn_id = '0:' . $orig_id;
}
- $sec = random_string();
+ $sec = Strings::getRandomHex();
$fields = ['uid' => api_user(), 'cid' => $cid, 'dfrn_id' => $dfrn_id,
'sec' => $sec, 'expire' => time() + 45];
}
$reshared_item["body"] = $shared_body;
+ $reshared_item["author-id"] = Contact::getIdForURL($profile, 0, true);
$reshared_item["author-name"] = $author;
$reshared_item["author-link"] = $profile;
$reshared_item["author-avatar"] = $avatar;
$r = q(
"SELECT `nick` FROM `contact` WHERE `uid` = 0 AND `nurl` = '%s'",
- DBA::escape(normalise_link($profile))
+ DBA::escape(Strings::normaliseLink($profile))
);
if (DBA::isResult($r)) {
if (!$nick == "") {
$r = q(
"SELECT `nick` FROM `contact` WHERE `uid` = 0 AND `nurl` = '%s'",
- DBA::escape(normalise_link($profile))
+ DBA::escape(Strings::normaliseLink($profile))
);
if (DBA::isResult($r)) {
*/
function api_clean_plain_items($text)
{
- $include_entities = strtolower(x($_REQUEST, 'include_entities') ? $_REQUEST['include_entities'] : "false");
+ $include_entities = strtolower(defaults($_REQUEST, 'include_entities', "false"));
$text = BBCode::cleanPictureLinks($text);
$URLSearchString = "^\[\]";
// params
$user_info = api_get_user($a);
- $gid = (x($_REQUEST, 'gid') ? $_REQUEST['gid'] : 0);
+ $gid = defaults($_REQUEST, 'gid', 0);
$uid = $user_info['uid'];
// get data of the specified group id or all groups if not specified
// params
$user_info = api_get_user($a);
- $gid = (x($_REQUEST, 'gid') ? $_REQUEST['gid'] : 0);
- $name = (x($_REQUEST, 'name') ? $_REQUEST['name'] : "");
+ $gid = defaults($_REQUEST, 'gid', 0);
+ $name = defaults($_REQUEST, 'name', "");
$uid = $user_info['uid'];
// error if no gid specified
// params
$user_info = api_get_user($a);
- $gid = (x($_REQUEST, 'list_id') ? $_REQUEST['list_id'] : 0);
+ $gid = defaults($_REQUEST, 'list_id', 0);
$uid = $user_info['uid'];
// error if no gid specified
// params
$user_info = api_get_user($a);
- $name = (x($_REQUEST, 'name') ? $_REQUEST['name'] : "");
+ $name = defaults($_REQUEST, 'name', "");
$uid = $user_info['uid'];
$json = json_decode($_POST['json'], true);
$users = $json['user'];
// params
$user_info = api_get_user($a);
- $name = (x($_REQUEST, 'name') ? $_REQUEST['name'] : "");
+ $name = defaults($_REQUEST, 'name', "");
$uid = $user_info['uid'];
$success = group_create($name, $uid);
// params
$user_info = api_get_user($a);
$uid = $user_info['uid'];
- $gid = (x($_REQUEST, 'gid') ? $_REQUEST['gid'] : 0);
- $name = (x($_REQUEST, 'name') ? $_REQUEST['name'] : "");
+ $gid = defaults($_REQUEST, 'gid', 0);
+ $name = defaults($_REQUEST, 'name', "");
$json = json_decode($_POST['json'], true);
$users = $json['user'];
// params
$user_info = api_get_user($a);
- $gid = (x($_REQUEST, 'list_id') ? $_REQUEST['list_id'] : 0);
- $name = (x($_REQUEST, 'name') ? $_REQUEST['name'] : "");
+ $gid = defaults($_REQUEST, 'list_id', 0);
+ $name = defaults($_REQUEST, 'name', "");
$uid = $user_info['uid'];
// error if no gid specified
$verb = strtolower($a->argv[3]);
$verb = preg_replace("|\..*$|", "", $verb);
- $id = (x($_REQUEST, 'id') ? $_REQUEST['id'] : 0);
+ $id = defaults($_REQUEST, 'id', 0);
$res = Item::performLike($id, $verb);
throw new BadRequestException("Invalid argument count");
}
- $id = (x($_REQUEST, 'id') ? intval($_REQUEST['id']) : 0);
+ $id = (!empty($_REQUEST['id']) ? intval($_REQUEST['id']) : 0);
$nm = new NotificationsManager();
$note = $nm->getByID($id);
// params
$user_info = api_get_user($a);
$uid = $user_info['uid'];
- $id = (x($_REQUEST, 'id') ? $_REQUEST['id'] : 0);
+ $id = defaults($_REQUEST, 'id', 0);
// return error if id is zero
if ($id == "") {
// params
$user_info = api_get_user($a);
- $searchstring = (x($_REQUEST, 'searchstring') ? $_REQUEST['searchstring'] : "");
+ $searchstring = defaults($_REQUEST, 'searchstring', "");
$uid = $user_info['uid'];
// error if no searchstring specified
foreach ($r as $item) {
if ($box == "inbox" || $item['from-url'] != $profile_url) {
$recipient = $user_info;
- $sender = api_get_user($a, normalise_link($item['contact-url']));
+ $sender = api_get_user($a, Strings::normaliseLink($item['contact-url']));
} elseif ($box == "sentbox" || $item['from-url'] == $profile_url) {
- $recipient = api_get_user($a, normalise_link($item['contact-url']));
+ $recipient = api_get_user($a, Strings::normaliseLink($item['contact-url']));
$sender = $user_info;
}
}
// input params
- $profile_id = (x($_REQUEST, 'profile_id') ? $_REQUEST['profile_id'] : 0);
+ $profile_id = defaults($_REQUEST, 'profile_id', 0);
// retrieve general information about profiles for user
$multi_profiles = Feature::isEnabled(api_user(), 'multi_profiles');
projects / friendica.git / blobdiff