/**
* Render actions localized
*/
-function localize_item(&$item) {
-
+function localize_item(&$item)
+{
$extracted = item_extract_images($item['body']);
if ($extracted['images']) {
$item['body'] = item_redir_and_replace_images($extracted['body'], $extracted['images'], $item['contact-id']);
}
- /// @TODO Separted ???
+ /*
+ heluecht 2018-06-19: from my point of view this whole code part is useless.
+ It just renders the body message of technical posts (Like, dislike, ...).
+ But: The body isn't visible at all. So we do this stuff just because we can.
+ Even if these messages were visible, this would only mean that something went wrong.
+ During the further steps of the database restructuring I would like to address this issue.
+ */
+
$xmlhead = "<" . "?xml version='1.0' encoding='UTF-8' ?" . ">";
if (activity_match($item['verb'], ACTIVITY_LIKE)
|| activity_match($item['verb'], ACTIVITY_DISLIKE)
|| activity_match($item['verb'], ACTIVITY_ATTENDNO)
|| activity_match($item['verb'], ACTIVITY_ATTENDMAYBE)) {
- /// @TODO may hurt performance
- $r = q("SELECT * FROM `item`, `contact`
- WHERE `item`.`contact-id`=`contact`.`id`
- AND `item`.`uri`='%s'",
- dbesc($item['parent-uri']));
- if (!DBM::is_result($r)) {
+ $fields = ['author-link', 'author-name', 'verb', 'object-type', 'resource-id', 'body', 'plink'];
+ $obj = Item::selectFirst($fields, ['uri' => $item['parent-uri']]);
+ if (!DBM::is_result($obj)) {
return;
}
- $obj = $r[0];
$author = '[url=' . $item['author-link'] . ']' . $item['author-name'] . '[/url]';
$objauthor = '[url=' . $obj['author-link'] . ']' . $obj['author-name'] . '[/url]';
$links = XML::parseString($xmlhead."<links>".unxmlify($obj->link)."</links>");
$Bname = $obj->title;
- $Blink = ""; $Bphoto = "";
+ $Blink = "";
+ $Bphoto = "";
foreach ($links->link as $l) {
$atts = $l->attributes();
switch ($atts['rel']) {
// now translate the verb
$poked_t = trim(sprintf($txt, "", ""));
- $txt = str_replace( $poked_t, L10n::t($verb), $txt);
+ $txt = str_replace($poked_t, L10n::t($verb), $txt);
// then do the sprintf on the translation string
}
if (activity_match($item['verb'], ACTIVITY_TAG)) {
- /// @TODO may hurt performance "joining" two tables + asterisk
- $r = q("SELECT * FROM `item`, `contact`
- WHERE `item`.`contact-id`=`contact`.`id`
- AND `item`.`uri`='%s'",
- dbesc($item['parent-uri']));
-
- if (!DBM::is_result($r)) {
+ $fields = ['author-link', 'author-name', 'verb', 'object-type', 'resource-id', 'body', 'plink'];
+ $obj = Item::selectFirst($fields, ['uri' => $item['parent-uri']]);
+ if (!DBM::is_result($obj)) {
return;
}
- $obj = $r[0];
-
$author = '[url=' . Contact::magicLinkById($item['author-id']) . ']' . $item['author-name'] . '[/url]';
$objauthor = '[url=' . Contact::magicLinkById($obj['author-id']) . ']' . $obj['author-name'] . '[/url]';
$parsedobj = XML::parseString($xmlhead.$item['object']);
$tag = sprintf('#[url=%s]%s[/url]', $parsedobj->id, $parsedobj->content);
- $item['body'] = L10n::t('%1$s tagged %2$s\'s %3$s with %4$s', $author, $objauthor, $plink, $tag );
-
+ $item['body'] = L10n::t('%1$s tagged %2$s\'s %3$s with %4$s', $author, $objauthor, $plink, $tag);
}
if (activity_match($item['verb'], ACTIVITY_FAVORITE)) {
$obj = XML::parseString($xmlhead.$item['object']);
if (strlen($obj->id)) {
- $r = q("SELECT * FROM `item` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
- dbesc($obj->id),
- intval($item['uid'])
- );
-
- if (DBM::is_result($r) && $r[0]['plink']) {
- $target = $r[0];
+ $fields = ['author-link', 'author-name', 'plink'];
+ $target = Item::selectFirst($fields, ['uri' => $obj->id, 'uid' => $item['uid']]);
+ if (DBM::is_result($target) && $target['plink']) {
$Bname = $target['author-name'];
$Blink = $target['author-link'];
$A = '[url=' . Contact::magicLink($Alink) . ']' . $Aname . '[/url]';
$location_e = $location;
$owner_name_e = $owner_name;
- if ($item['item_network'] == "") {
- $item['item_network'] = $item['network'];
- }
-
$tmp_item = [
'template' => $tpl,
'id' => (($preview) ? 'P0' : $item['item_id']),
'guid' => (($preview) ? 'Q0' : $item['guid']),
- 'network' => $item['item_network'],
- 'network_name' => ContactSelector::networkToName($item['item_network'], $profile_link),
+ 'network' => $item['network'],
+ 'network_name' => ContactSelector::networkToName($item['network'], $profile_link),
'linktitle' => L10n::t('View %s\'s profile @ %s', $profile_name, $item['author-link']),
'profile_url' => $profile_link,
'item_photo_menu' => item_photo_menu($item),
Addon::callHooks('display_item', $arr);
$threads[$threadsid]['id'] = $item['item_id'];
- $threads[$threadsid]['network'] = $item['item_network'];
+ $threads[$threadsid]['network'] = $item['network'];
$threads[$threadsid]['items'] = [$arr['output']];
}
if ($block_authors) {
$condition[0] .= "AND NOT `author`.`hidden`";
}
- $thread_items = Item::select(local_user(), [], $condition, $params);
+ $thread_items = Item::selectForUser(local_user(), [], $condition, $params);
- $comments = dba::inArray($thread_items);
+ $comments = Item::inArray($thread_items);
if (count($comments) != 0) {
$items = array_merge($items, $comments);
}
if ($total >= MAX_LIKERS) {
$str = implode(', ', $arr);
- $str .= L10n::t('and %d other people', $total - MAX_LIKERS );
+ $str .= L10n::t('and %d other people', $total - MAX_LIKERS);
}
$likers = $str;
projects / friendica.git / blobdiff