}
try {
self::$db = @new PDO($connect, $user, $pass);
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, false);
self::$connected = true;
} catch (PDOException $e) {
}
* For all regular queries please use dba::select or dba::exists
*
* @param string $sql SQL statement
- * @return bool|object statement object
+ * @return bool|object statement object or result object
*/
public static function p($sql) {
$a = get_app();
*/
public static function lock($table) {
// See here: https://dev.mysql.com/doc/refman/5.7/en/lock-tables-and-transactions.html
- self::e("SET autocommit=0");
+ if (self::$driver == 'pdo') {
+ self::e("SET autocommit=0");
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);
+ } else {
+ self::$db->autocommit(false);
+ }
+
$success = self::e("LOCK TABLES `".self::escape($table)."` WRITE");
+
+ if (self::$driver == 'pdo') {
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, false);
+ }
+
if (!$success) {
- self::e("SET autocommit=1");
+ if (self::$driver == 'pdo') {
+ self::e("SET autocommit=1");
+ } else {
+ self::$db->autocommit(true);
+ }
} else {
self::$in_transaction = true;
}
*/
public static function unlock() {
// See here: https://dev.mysql.com/doc/refman/5.7/en/lock-tables-and-transactions.html
- self::e("COMMIT");
+ self::performCommit();
+
+ if (self::$driver == 'pdo') {
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);
+ }
+
$success = self::e("UNLOCK TABLES");
- self::e("SET autocommit=1");
+
+ if (self::$driver == 'pdo') {
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, false);
+ self::e("SET autocommit=1");
+ } else {
+ self::$db->autocommit(true);
+ }
+
self::$in_transaction = false;
return $success;
}
* @return boolean Was the command executed successfully?
*/
public static function transaction() {
- if (!self::e('COMMIT')) {
+ if (!self::performCommit()) {
return false;
}
- if (!self::e('START TRANSACTION')) {
- return false;
+
+ switch (self::$driver) {
+ case 'pdo':
+ if (self::$db->inTransaction()) {
+ break;
+ }
+ if (!self::$db->beginTransaction()) {
+ return false;
+ }
+ break;
+ case 'mysqli':
+ if (!self::$db->begin_transaction()) {
+ return false;
+ }
+ break;
}
+
self::$in_transaction = true;
return true;
}
+ private static function performCommit()
+ {
+ switch (self::$driver) {
+ case 'pdo':
+ if (!self::$db->inTransaction()) {
+ return true;
+ }
+ return self::$db->commit();
+ case 'mysqli':
+ return self::$db->commit();
+ }
+ return true;
+ }
+
/**
* @brief Does a commit
*
* @return boolean Was the command executed successfully?
*/
public static function commit() {
- if (!self::e('COMMIT')) {
+ if (!self::performCommit()) {
return false;
}
self::$in_transaction = false;
* @return boolean Was the command executed successfully?
*/
public static function rollback() {
- if (!self::e('ROLLBACK')) {
- return false;
+ switch (self::$driver) {
+ case 'pdo':
+ if (!self::$db->inTransaction()) {
+ $ret = true;
+ break;
+ }
+ $ret = self::$db->rollBack();
+ break;
+ case 'mysqli':
+ $ret = self::$db->rollback();
+ break;
}
self::$in_transaction = false;
- return true;
+ return $ret;
}
/**
$commands = [];
// Create a key for the loop prevention
- $key = $table . ':' . implode(':', array_keys($conditions)) . ':' . implode(':', $conditions);
+ $key = $table . ':' . json_encode($conditions);
// We quit when this key already exists in the callstack.
if (isset($callstack[$key])) {
$rel_def = array_values(self::$relation[$table])[0];
// Create a key for preventing double queries
- $qkey = $field . '-' . $table . ':' . implode(':', array_keys($conditions)) . ':' . implode(':', $conditions);
+ $qkey = $field . '-' . $table . ':' . json_encode($conditions);
// When the search field is the relation field, we don't need to fetch the rows
// This is useful when the leading record is already deleted in the frontend but the rest is done in the backend
$condition_string .= " AND ";
}
if (is_array($value)) {
- // Check if there are integer values in the parameters
+ /* Workaround for MySQL Bug #64791.
+ * Never mix data types inside any IN() condition.
+ * In case of mixed types, cast all as string.
+ * Logic needs to be consistent with dba::p() data types.
+ */
$is_int = false;
$is_alpha = false;
foreach ($value as $single_value) {
if (is_int($single_value)) {
$is_int = true;
- }
-
- // Is any non numeric value present?
- if (!is_numeric($single_value)) {
+ } else {
$is_alpha = true;
}
}
-
- // Cast them all in an unique method
- if ($is_int) {
- $casted = [];
- foreach ($value as $single_value) {
- if (!$is_alpha) {
- $casted[] = (int)$single_value;
- } else {
- $casted[] = (string)$single_value;
+
+ if ($is_int && $is_alpha) {
+ foreach ($value as &$ref) {
+ if (is_int($ref)) {
+ $ref = (string)$ref;
}
}
- $value = $casted;
+ unset($ref); //Prevent accidental re-use.
}
$new_values = array_merge($new_values, array_values($value));
$ret = $stmt->closeCursor();
break;
case 'mysqli':
- $stmt->free_result();
- $ret = $stmt->close();
+ // MySQLi offers both a mysqli_stmt and a mysqli_result class.
+ // We should be careful not to assume the object type of $stmt
+ // because dba::p() has been able to return both types.
+ if ($stmt instanceof mysqli_stmt) {
+ $stmt->free_result();
+ $ret = $stmt->close();
+ } elseif ($stmt instanceof mysqli_result) {
+ $stmt->free();
+ $ret = true;
+ } else {
+ $ret = false;
+ }
break;
}
projects / friendica.git / blobdiff