private static $errorno = 0;
private static $affected_rows = 0;
private static $in_transaction = false;
+ private static $in_retrial = false;
private static $relation = [];
+ private static $db_serveraddr = '';
+ private static $db_user = '';
+ private static $db_pass = '';
+ private static $db_name = '';
public static function connect($serveraddr, $user, $pass, $db) {
if (!is_null(self::$db) && self::connected()) {
$stamp1 = microtime(true);
+ // We are storing these values for being able to perform a reconnect
+ self::$db_serveraddr = $serveraddr;
+ self::$db_user = $user;
+ self::$db_pass = $pass;
+ self::$db_name = $db;
+
$serveraddr = trim($serveraddr);
$serverdata = explode(':', $serveraddr);
}
try {
self::$db = @new PDO($connect, $user, $pass);
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, false);
self::$connected = true;
} catch (PDOException $e) {
}
return self::$connected;
}
+ /**
+ * Disconnects the current database connection
+ */
+ public static function disconnect()
+ {
+ if (is_null(self::$db)) {
+ return;
+ }
+
+ switch (self::$driver) {
+ case 'pdo':
+ self::$db = null;
+ break;
+ case 'mysqli':
+ self::$db->close();
+ self::$db = null;
+ break;
+ }
+ }
+
+ /**
+ * Perform a reconnect of an existing database connection
+ */
+ public static function reconnect() {
+ self::disconnect();
+
+ $ret = self::connect(self::$db_serveraddr, self::$db_user, self::$db_pass, self::$db_name);
+ return $ret;
+ }
+
/**
* Return the database object.
* @return PDO|mysqli
*/
public static function database_name() {
$ret = self::p("SELECT DATABASE() AS `db`");
- $data = self::inArray($ret);
+ $data = self::inArray($ret);
return $data[0]['db'];
}
* For all regular queries please use dba::select or dba::exists
*
* @param string $sql SQL statement
- * @return bool|object statement object
+ * @return bool|object statement object or result object
*/
public static function p($sql) {
$a = get_app();
}
foreach ($args AS $param => $value) {
- $stmt->bindParam($param, $args[$param]);
+ if (is_int($args[$param])) {
+ $data_type = PDO::PARAM_INT;
+ } else {
+ $data_type = PDO::PARAM_STR;
+ }
+ $stmt->bindParam($param, $args[$param], $data_type);
}
if (!$stmt->execute()) {
break;
}
- $params = '';
+ $param_types = '';
$values = [];
foreach ($args AS $param => $value) {
if (is_int($args[$param])) {
- $params .= 'i';
+ $param_types .= 'i';
} elseif (is_float($args[$param])) {
- $params .= 'd';
+ $param_types .= 'd';
} elseif (is_string($args[$param])) {
- $params .= 's';
+ $param_types .= 's';
} else {
- $params .= 'b';
+ $param_types .= 'b';
}
$values[] = &$args[$param];
}
if (count($values) > 0) {
- array_unshift($values, $params);
+ array_unshift($values, $param_types);
call_user_func_array([$stmt, 'bind_param'], $values);
}
$errorno = self::$errorno;
logger('DB Error '.self::$errorno.': '.self::$error."\n".
- System::callstack(8)."\n".self::replaceParameters($sql, $params));
+ System::callstack(8)."\n".self::replaceParameters($sql, $args));
+
+ // On a lost connection we try to reconnect - but only once.
+ if ($errorno == 2006) {
+ if (self::$in_retrial || !self::reconnect()) {
+ // It doesn't make sense to continue when the database connection was lost
+ if (self::$in_retrial) {
+ logger('Giving up retrial because of database error '.$errorno.': '.$error);
+ } else {
+ logger("Couldn't reconnect after database error ".$errorno.': '.$error);
+ }
+ exit(1);
+ } else {
+ // We try it again
+ logger('Reconnected after database error '.$errorno.': '.$error);
+ self::$in_retrial = true;
+ $ret = self::p($sql, $args);
+ self::$in_retrial = false;
+ return $ret;
+ }
+ }
self::$error = $error;
self::$errorno = $errorno;
logger('DB Error '.self::$errorno.': '.self::$error."\n".
System::callstack(8)."\n".self::replaceParameters($sql, $params));
+ // On a lost connection we simply quit.
+ // A reconnect like in self::p could be dangerous with modifications
+ if ($errorno == 2006) {
+ logger('Giving up because of database error '.$errorno.': '.$error);
+ exit(1);
+ }
+
self::$error = $error;
self::$errorno = $errorno;
}
*/
public static function lock($table) {
// See here: https://dev.mysql.com/doc/refman/5.7/en/lock-tables-and-transactions.html
- self::e("SET autocommit=0");
+ if (self::$driver == 'pdo') {
+ self::e("SET autocommit=0");
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);
+ } else {
+ self::$db->autocommit(false);
+ }
+
$success = self::e("LOCK TABLES `".self::escape($table)."` WRITE");
+
+ if (self::$driver == 'pdo') {
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, false);
+ }
+
if (!$success) {
- self::e("SET autocommit=1");
+ if (self::$driver == 'pdo') {
+ self::e("SET autocommit=1");
+ } else {
+ self::$db->autocommit(true);
+ }
} else {
self::$in_transaction = true;
}
*/
public static function unlock() {
// See here: https://dev.mysql.com/doc/refman/5.7/en/lock-tables-and-transactions.html
- self::e("COMMIT");
+ self::performCommit();
+
+ if (self::$driver == 'pdo') {
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);
+ }
+
$success = self::e("UNLOCK TABLES");
- self::e("SET autocommit=1");
+
+ if (self::$driver == 'pdo') {
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, false);
+ self::e("SET autocommit=1");
+ } else {
+ self::$db->autocommit(true);
+ }
+
self::$in_transaction = false;
return $success;
}
* @return boolean Was the command executed successfully?
*/
public static function transaction() {
- if (!self::e('COMMIT')) {
+ if (!self::performCommit()) {
return false;
}
- if (!self::e('START TRANSACTION')) {
- return false;
+
+ switch (self::$driver) {
+ case 'pdo':
+ if (self::$db->inTransaction()) {
+ break;
+ }
+ if (!self::$db->beginTransaction()) {
+ return false;
+ }
+ break;
+ case 'mysqli':
+ if (!self::$db->begin_transaction()) {
+ return false;
+ }
+ break;
}
+
self::$in_transaction = true;
return true;
}
+ private static function performCommit()
+ {
+ switch (self::$driver) {
+ case 'pdo':
+ if (!self::$db->inTransaction()) {
+ return true;
+ }
+ return self::$db->commit();
+ case 'mysqli':
+ return self::$db->commit();
+ }
+ return true;
+ }
+
/**
* @brief Does a commit
*
* @return boolean Was the command executed successfully?
*/
public static function commit() {
- if (!self::e('COMMIT')) {
+ if (!self::performCommit()) {
return false;
}
self::$in_transaction = false;
* @return boolean Was the command executed successfully?
*/
public static function rollback() {
- if (!self::e('ROLLBACK')) {
- return false;
+ $ret = false;
+
+ switch (self::$driver) {
+ case 'pdo':
+ if (!self::$db->inTransaction()) {
+ $ret = true;
+ break;
+ }
+ $ret = self::$db->rollBack();
+ break;
+ case 'mysqli':
+ $ret = self::$db->rollback();
+ break;
}
self::$in_transaction = false;
- return true;
+ return $ret;
}
/**
$commands = [];
// Create a key for the loop prevention
- $key = $table . ':' . implode(':', array_keys($conditions)) . ':' . implode(':', $conditions);
+ $key = $table . ':' . json_encode($conditions);
// We quit when this key already exists in the callstack.
if (isset($callstack[$key])) {
$rel_def = array_values(self::$relation[$table])[0];
// Create a key for preventing double queries
- $qkey = $field . '-' . $table . ':' . implode(':', array_keys($conditions)) . ':' . implode(':', $conditions);
+ $qkey = $field . '-' . $table . ':' . json_encode($conditions);
// When the search field is the relation field, we don't need to fetch the rows
// This is useful when the leading record is already deleted in the frontend but the rest is done in the backend
// Split the SQL queries in chunks of 100 values
// We do the $i stuff here to make the code better readable
- $i = $counter[$key_table][$key_condition];
+ $i = isset($counter[$key_table][$key_condition]) ? $counter[$key_table][$key_condition] : 0;
if (isset($compacted[$key_table][$key_condition][$i]) && count($compacted[$key_table][$key_condition][$i]) > 100) {
++$i;
}
$condition_string .= " AND ";
}
if (is_array($value)) {
+ /* Workaround for MySQL Bug #64791.
+ * Never mix data types inside any IN() condition.
+ * In case of mixed types, cast all as string.
+ * Logic needs to be consistent with dba::p() data types.
+ */
+ $is_int = false;
+ $is_alpha = false;
+ foreach ($value as $single_value) {
+ if (is_int($single_value)) {
+ $is_int = true;
+ } else {
+ $is_alpha = true;
+ }
+ }
+
+ if ($is_int && $is_alpha) {
+ foreach ($value as &$ref) {
+ if (is_int($ref)) {
+ $ref = (string)$ref;
+ }
+ }
+ unset($ref); //Prevent accidental re-use.
+ }
+
$new_values = array_merge($new_values, array_values($value));
$placeholders = substr(str_repeat("?, ", count($value)), 0, -2);
$condition_string .= "`" . $field . "` IN (" . $placeholders . ")";
$ret = $stmt->closeCursor();
break;
case 'mysqli':
- $stmt->free_result();
- $ret = $stmt->close();
+ // MySQLi offers both a mysqli_stmt and a mysqli_result class.
+ // We should be careful not to assume the object type of $stmt
+ // because dba::p() has been able to return both types.
+ if ($stmt instanceof mysqli_stmt) {
+ $stmt->free_result();
+ $ret = $stmt->close();
+ } elseif ($stmt instanceof mysqli_result) {
+ $stmt->free();
+ $ret = true;
+ } else {
+ $ret = false;
+ }
break;
}