Merge branch 'master' of https://github.com/friendica/friendica

[friendica.git] / include / dba.php

diff --git a/include/dba.php b/include/dba.php
old mode 100755 (executable)
new mode 100644 (file)
index 55a4493..c9f8802
--- a/include/dba.php
+++ b/include/dba.php
@@ -75,36 +75,28 @@ class dba {
                if((! $this->db) || (! $this->connected))
                        return false;
                
+               $this->error = '';
+
                if($this->mysqli)
                        $result = @$this->db->query($sql);
                else
                        $result = @mysql_query($sql,$this->db);
 
+               if($this->mysqli) {
+                       if($this->db->errno)
+                               $this->error = $this->db->error;
+               }
+               elseif(mysql_errno($this->db))
+                               $this->error = mysql_error($this->db);  
+
+               if(strlen($this->error)) {
+                       logger('dba: ' . $this->error);
+               }
+
                if($this->debug) {
 
                        $mesg = '';
 
-<<<<<<< HEAD:include/dba.php
-                        // If dbfail.out exists, we will write any failed calls directly to it,
-                        // regardless of any logging that may or may nor be in effect.
-                        // These usually indicate SQL syntax errors that need to be resolved.
-                               if(file_exists('dbfail.out')) {
-                                       file_put_contents('dbfail.out', datetime_convert() . "\n" . $str . "\n", FILE_APPEND);
-                               }
-                               logger('dba: ' . $str );
-                               if(FALSE===$result) {
-                                       $this->throwOrLog(new RuntimeException('dba: ' . $str));
-                                       return; 
-                               }
-=======
-                       if($this->mysqli) {
-                               if($this->db->errno)
-                                       logger('dba: ' . $this->db->error);
->>>>>>> upstream/master:include/dba.php
-                       }
-                       elseif(mysql_errno($this->db))
-                               logger('dba: ' . mysql_error($this->db));
-
                        if($result === false)
                                $mesg = 'false';
                        elseif($result === true)
@@ -116,7 +108,9 @@ class dba {
                                        $mesg = mysql_num_rows($result) . ' results' . EOL;
                        }
     
-                       $str =  'SQL = ' . printable($sql) . EOL . 'SQL returned ' . $mesg . EOL;
+                       $str =  'SQL = ' . printable($sql) . EOL . 'SQL returned ' . $mesg 
+                               . (($this->error) ? ' error: ' . $this->error : '')
+                               . EOL;
 
                        logger('dba: ' . $str );
                }
@@ -128,9 +122,9 @@ class dba {
                 */
 
                if($result === false) {
-                       logger('dba: ' . printable($sql) . ' returned false.');
+                       logger('dba: ' . printable($sql) . ' returned false.' . "\n" . $this->error);
                        if(file_exists('dbfail.out'))
-                               file_put_contents('dbfail.out', datetime_convert() . "\n" . printable($sql) . ' returned false' . "\n", FILE_APPEND);
+                               file_put_contents('dbfail.out', datetime_convert() . "\n" . printable($sql) . ' returned false' . "\n" . $this->error . "\n", FILE_APPEND);
                }
 
                if(($result === true) || ($result === false))
@@ -144,62 +138,6 @@ class dba {
                                $result->free_result();
                        }
                }
-<<<<<<< HEAD:include/dba.php
-               
-               /**
-                * starts a transaction. Transactions need to be finished with 
-                * commit() or rollback(). Please mind that the db table engine may
-                * not support this. 
-                */
-               public function beginTransaction() {
-                       if($this->mysqli) {
-                               return $this->db->autocommit(false);
-                       } else {
-                               //no transaction support in mysql module...
-                               mysql_query('SET AUTOCOMMIT = 0;', $db); 
-                       }
-               }
-               
-               /**
-                * rollback a transaction. So, rollback anything that was done since the last call 
-                * to beginTransaction(). 
-                */
-               public function rollback() {
-                       if($this->mysqli) {
-                               return $this->db->rollback();
-                       } else {
-                               //no transaction support in mysql module...
-                               mysql_query('ROLLBACK;', $db);
-                       }
-                       $this->stopTransaction(); 
-               }
-
-               /**
-                * commit a transaction. So, write any query to the database. 
-                */
-               public function commit() {
-                       if($this->mysqli) {
-                               return $this->db->commit();
-                       } else {
-                               //no transaction support in mysql module...
-                               mysql_query('COMMIT;', $db);
-                       }
-                       $this->stopTransaction();
-               }
-               
-               private function stopTransaction() {
-                       if($this->mysqli) {
-                               return $this->db->autocommit(true);
-                       } else {
-                               //no transaction support in mysql module...
-                               mysql_query('SET AUTOCOMMIT = 1;', $db);
-                       }
-               }
-               
-               public function dbg($dbg) {
-                       $this->debug = $dbg;
-               }
-=======
                else {
                        if(mysql_num_rows($result)) {
                                while($x = mysql_fetch_array($result, MYSQL_ASSOC))
@@ -213,7 +151,6 @@ class dba {
                        logger('dba: ' . printable(print_r($r, true)));
                return($r);
        }
->>>>>>> upstream/master:include/dba.php
 
        public function dbg($dbg) {
                $this->debug = $dbg;
@@ -331,6 +268,4 @@ function dbesc_array(&$arr) {
        if(is_array($arr) && count($arr)) {
                array_walk($arr,'dbesc_array_cb');
        }
-}}             
-
-
+}}