<?php
-use Friendica\App;
-use Friendica\Core\L10n;
+// Do not use Core\Config in this class at risk of infinite loop.
+// Please use App->getConfigVariable() instead.
+//use Friendica\Core\Config;
+
use Friendica\Core\System;
use Friendica\Database\DBM;
use Friendica\Database\DBStructure;
private static $db_user = '';
private static $db_pass = '';
private static $db_name = '';
+ private static $db_charset = '';
- public static function connect($serveraddr, $user, $pass, $db) {
+ public static function connect($serveraddr, $user, $pass, $db, $charset = null)
+ {
if (!is_null(self::$db) && self::connected()) {
return true;
}
- $a = get_app();
-
- $stamp1 = microtime(true);
-
// We are storing these values for being able to perform a reconnect
self::$db_serveraddr = $serveraddr;
self::$db_user = $user;
self::$db_pass = $pass;
self::$db_name = $db;
+ self::$db_charset = $charset;
$serveraddr = trim($serveraddr);
$user = trim($user);
$pass = trim($pass);
$db = trim($db);
+ $charset = trim($charset);
if (!(strlen($server) && strlen($user))) {
return false;
$connect .= ";port=".$port;
}
- if (isset($a->config["system"]["db_charset"])) {
- $connect .= ";charset=".$a->config["system"]["db_charset"];
+ if ($charset) {
+ $connect .= ";charset=".$charset;
}
+
try {
self::$db = @new PDO($connect, $user, $pass);
- // Needs more testing
- //self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, false);
- //self::$db->setAttribute(PDO::ATTR_STRINGIFY_FETCHES, false);
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, false);
self::$connected = true;
} catch (PDOException $e) {
}
if (!mysqli_connect_errno()) {
self::$connected = true;
- if (isset($a->config["system"]["db_charset"])) {
- self::$db->set_charset($a->config["system"]["db_charset"]);
+ if ($charset) {
+ self::$db->set_charset($charset);
}
}
}
self::$driver = null;
self::$db = null;
}
- $a->save_timestamp($stamp1, "network");
return self::$connected;
}
public static function reconnect() {
self::disconnect();
- $ret = self::connect(self::$db_serveraddr, self::$db_user, self::$db_pass, self::$db_name);
+ $ret = self::connect(self::$db_serveraddr, self::$db_user, self::$db_pass, self::$db_name, self::$db_charset);
return $ret;
}
private static function logIndex($query) {
$a = get_app();
- if (empty($a->config["system"]["db_log_index"])) {
+ if (empty(Config::get('system', 'db_log_index'))) {
return;
}
return;
}
- $watchlist = explode(',', $a->config["system"]["db_log_index_watch"]);
- $blacklist = explode(',', $a->config["system"]["db_log_index_blacklist"]);
+ $watchlist = explode(',', Config::get('system', 'db_log_index_watch'));
+ $blacklist = explode(',', Config::get('system', 'db_log_index_blacklist'));
while ($row = dba::fetch($r)) {
- if ((intval($a->config["system"]["db_loglimit_index"]) > 0)) {
+ if ((intval(Config::get('system', 'db_loglimit_index')) > 0)) {
$log = (in_array($row['key'], $watchlist) &&
- ($row['rows'] >= intval($a->config["system"]["db_loglimit_index"])));
+ ($row['rows'] >= intval(Config::get('system', 'db_loglimit_index'))));
} else {
$log = false;
}
- if ((intval($a->config["system"]["db_loglimit_index_high"]) > 0) && ($row['rows'] >= intval($a->config["system"]["db_loglimit_index_high"]))) {
+ if ((intval(Config::get('system', 'db_loglimit_index_high')) > 0) && ($row['rows'] >= intval(Config::get('system', 'db_loglimit_index_high')))) {
$log = true;
}
if ($log) {
$backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
- @file_put_contents($a->config["system"]["db_log_index"], DateTimeFormat::utcNow()."\t".
+ @file_put_contents(Config::get('system', 'db_log_index'), DateTimeFormat::utcNow()."\t".
$row['key']."\t".$row['rows']."\t".$row['Extra']."\t".
basename($backtrace[1]["file"])."\t".
$backtrace[1]["line"]."\t".$backtrace[2]["function"]."\t".
* For all regular queries please use dba::select or dba::exists
*
* @param string $sql SQL statement
- * @return bool|object statement object
+ * @return bool|object statement object or result object
*/
public static function p($sql) {
$a = get_app();
$orig_sql = $sql;
- if (x($a->config,'system') && x($a->config['system'], 'db_callstack')) {
+ if ($a->getConfigValue('system', 'db_callstack')) {
$sql = "/*".System::callstack()." */ ".$sql;
}
$a->save_timestamp($stamp1, 'database');
- if (x($a->config,'system') && x($a->config['system'], 'db_log')) {
-
+ if ($a->getConfigValue('system', 'db_log')) {
$stamp2 = microtime(true);
$duration = (float)($stamp2 - $stamp1);
- if (($duration > $a->config["system"]["db_loglimit"])) {
+ if (($duration > $a->getConfigValue('system', 'db_loglimit'))) {
$duration = round($duration, 3);
$backtrace = debug_backtrace(DEBUG_BACKTRACE_IGNORE_ARGS);
- @file_put_contents($a->config["system"]["db_log"], DateTimeFormat::utcNow()."\t".$duration."\t".
+ @file_put_contents($a->getConfigValue('system', 'db_log'), DateTimeFormat::utcNow()."\t".$duration."\t".
basename($backtrace[1]["file"])."\t".
$backtrace[1]["line"]."\t".$backtrace[2]["function"]."\t".
substr(self::replaceParameters($sql, $args), 0, 2000)."\n", FILE_APPEND);
*/
public static function lock($table) {
// See here: https://dev.mysql.com/doc/refman/5.7/en/lock-tables-and-transactions.html
- self::e("SET autocommit=0");
+ if (self::$driver == 'pdo') {
+ self::e("SET autocommit=0");
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);
+ } else {
+ self::$db->autocommit(false);
+ }
+
$success = self::e("LOCK TABLES `".self::escape($table)."` WRITE");
+
+ if (self::$driver == 'pdo') {
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, false);
+ }
+
if (!$success) {
- self::e("SET autocommit=1");
+ if (self::$driver == 'pdo') {
+ self::e("SET autocommit=1");
+ } else {
+ self::$db->autocommit(true);
+ }
} else {
self::$in_transaction = true;
}
*/
public static function unlock() {
// See here: https://dev.mysql.com/doc/refman/5.7/en/lock-tables-and-transactions.html
- self::e("COMMIT");
+ self::performCommit();
+
+ if (self::$driver == 'pdo') {
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, true);
+ }
+
$success = self::e("UNLOCK TABLES");
- self::e("SET autocommit=1");
+
+ if (self::$driver == 'pdo') {
+ self::$db->setAttribute(PDO::ATTR_EMULATE_PREPARES, false);
+ self::e("SET autocommit=1");
+ } else {
+ self::$db->autocommit(true);
+ }
+
self::$in_transaction = false;
return $success;
}
* @return boolean Was the command executed successfully?
*/
public static function transaction() {
- if (!self::e('COMMIT')) {
+ if (!self::performCommit()) {
return false;
}
- if (!self::e('START TRANSACTION')) {
- return false;
+
+ switch (self::$driver) {
+ case 'pdo':
+ if (self::$db->inTransaction()) {
+ break;
+ }
+ if (!self::$db->beginTransaction()) {
+ return false;
+ }
+ break;
+ case 'mysqli':
+ if (!self::$db->begin_transaction()) {
+ return false;
+ }
+ break;
}
+
self::$in_transaction = true;
return true;
}
+ private static function performCommit()
+ {
+ switch (self::$driver) {
+ case 'pdo':
+ if (!self::$db->inTransaction()) {
+ return true;
+ }
+ return self::$db->commit();
+ case 'mysqli':
+ return self::$db->commit();
+ }
+ return true;
+ }
+
/**
* @brief Does a commit
*
* @return boolean Was the command executed successfully?
*/
public static function commit() {
- if (!self::e('COMMIT')) {
+ if (!self::performCommit()) {
return false;
}
self::$in_transaction = false;
* @return boolean Was the command executed successfully?
*/
public static function rollback() {
- if (!self::e('ROLLBACK')) {
- return false;
+ $ret = false;
+
+ switch (self::$driver) {
+ case 'pdo':
+ if (!self::$db->inTransaction()) {
+ $ret = true;
+ break;
+ }
+ $ret = self::$db->rollBack();
+ break;
+ case 'mysqli':
+ $ret = self::$db->rollback();
+ break;
}
self::$in_transaction = false;
- return true;
+ return $ret;
}
/**
$commands = [];
// Create a key for the loop prevention
- $key = $table . ':' . implode(':', array_keys($conditions)) . ':' . implode(':', $conditions);
+ $key = $table . ':' . json_encode($conditions);
// We quit when this key already exists in the callstack.
if (isset($callstack[$key])) {
$rel_def = array_values(self::$relation[$table])[0];
// Create a key for preventing double queries
- $qkey = $field . '-' . $table . ':' . implode(':', array_keys($conditions)) . ':' . implode(':', $conditions);
+ $qkey = $field . '-' . $table . ':' . json_encode($conditions);
// When the search field is the relation field, we don't need to fetch the rows
// This is useful when the leading record is already deleted in the frontend but the rest is done in the backend
// Split the SQL queries in chunks of 100 values
// We do the $i stuff here to make the code better readable
- $i = $counter[$key_table][$key_condition];
+ $i = isset($counter[$key_table][$key_condition]) ? $counter[$key_table][$key_condition] : 0;
if (isset($compacted[$key_table][$key_condition][$i]) && count($compacted[$key_table][$key_condition][$i]) > 100) {
++$i;
}
$condition_string .= " AND ";
}
if (is_array($value)) {
- // Check if there are integer values in the parameters
+ /* Workaround for MySQL Bug #64791.
+ * Never mix data types inside any IN() condition.
+ * In case of mixed types, cast all as string.
+ * Logic needs to be consistent with dba::p() data types.
+ */
$is_int = false;
- $is_float = false;
$is_alpha = false;
foreach ($value as $single_value) {
if (is_int($single_value)) {
$is_int = true;
- }
-
- // To prevent to round floats we look for them
- if (round($single_value) != (float)$single_value) {
- $is_float = true;
- }
-
- // Is any non numeric value present?
- if (!is_numeric($single_value)) {
+ } else {
$is_alpha = true;
}
}
- // Cast them all in an unique method
- if ($is_int) {
- $casted = [];
- foreach ($value as $single_value) {
- if (!$is_alpha && !$is_float) {
- $casted[] = (int)$single_value;
- } else {
- $casted[] = (string)$single_value;
+ if ($is_int && $is_alpha) {
+ foreach ($value as &$ref) {
+ if (is_int($ref)) {
+ $ref = (string)$ref;
}
}
- $value = $casted;
+ unset($ref); //Prevent accidental re-use.
}
$new_values = array_merge($new_values, array_values($value));
$ret = $stmt->closeCursor();
break;
case 'mysqli':
- $stmt->free_result();
- $ret = $stmt->close();
+ // MySQLi offers both a mysqli_stmt and a mysqli_result class.
+ // We should be careful not to assume the object type of $stmt
+ // because dba::p() has been able to return both types.
+ if ($stmt instanceof mysqli_stmt) {
+ $stmt->free_result();
+ $ret = $stmt->close();
+ } elseif ($stmt instanceof mysqli_result) {
+ $stmt->free();
+ $ret = true;
+ } else {
+ $ret = false;
+ }
break;
}
projects / friendica.git / blobdiff