]> git.mxchange.org Git - friendica.git/blobdiff - include/diaspora.php
events: use best_link_url() and zrl() for the author_link (author link as magic-link)
[friendica.git] / include / diaspora.php
index 6ba1806ade1572bad3894dc10c2daa1da98cf21b..60c7909184360baa6ca007061372d7a98726cb3f 100644 (file)
@@ -4,12 +4,15 @@
  * @brief The implementation of the diaspora protocol
  *
  * The new protocol is described here: http://diaspora.github.io/diaspora_federation/index.html
- * Currently this implementation here interprets the old and the new protocol and sends the old one.
- * This will change in the future.
+ * This implementation here interprets the old and the new protocol and sends the new one.
+ * In the future we will remove most stuff from "valid_posting" and interpret only the new protocol.
  */
 
 use Friendica\App;
+use Friendica\Core\System;
 use Friendica\Core\Config;
+use Friendica\Core\PConfig;
+use Friendica\Network\Probe;
 
 require_once 'include/items.php';
 require_once 'include/bb2diaspora.php';
@@ -117,7 +120,7 @@ class Diaspora {
         */
        private static function verify_magic_envelope($envelope) {
 
-               $basedom = parse_xml_string($envelope, false);
+               $basedom = parse_xml_string($envelope);
 
                if (!is_object($basedom)) {
                        logger("Envelope is no XML file");
@@ -226,7 +229,7 @@ class Diaspora {
                $basedom = parse_xml_string($xml);
 
                if (!is_object($basedom)) {
-                       logger('Received data does not seem to be an XML. Discarding.');
+                       logger('Received data does not seem to be an XML. Discarding. '.$xml);
                        http_status_exit(400);
                }
 
@@ -286,6 +289,11 @@ class Diaspora {
                        $public = true;
                        $author_link = str_replace('acct:','',$children->header->author_id);
                } else {
+                       // This happens with posts from a relais
+                       if (!$importer) {
+                               logger("This is no private post in the old format", LOGGER_DEBUG);
+                               return false;
+                       }
 
                        $encrypted_header = json_decode(base64_decode($children->encrypted_header));
 
@@ -303,7 +311,7 @@ class Diaspora {
                        $decrypted = self::aes_decrypt($outer_key, $outer_iv, $ciphertext);
 
                        logger('decrypted: '.$decrypted, LOGGER_DEBUG);
-                       $idom = parse_xml_string($decrypted,false);
+                       $idom = parse_xml_string($decrypted);
 
                        $inner_iv = base64_decode($idom->iv);
                        $inner_aes_key = base64_decode($idom->aes_key);
@@ -416,7 +424,7 @@ class Diaspora {
                $fields = $postdata['fields'];
 
                // Is it a an action (comment, like, ...) for our own post?
-               if (isset($fields->parent_guid) AND !$postdata["relayed"]) {
+               if (isset($fields->parent_guid) && !$postdata["relayed"]) {
                        $guid = notags(unxmlify($fields->parent_guid));
                        $importer = self::importer_for_guid($guid);
                        if (is_array($importer)) {
@@ -426,6 +434,18 @@ class Diaspora {
                        }
                }
 
+               // Process item retractions. This has to be done separated from the other stuff,
+               // since retractions for comments could come even from non followers.
+               if (!empty($fields) && in_array($fields->getName(), array('retraction'))) {
+                       $target = notags(unxmlify($fields->target_type));
+                       if (in_array($target, array("Comment", "Like", "Post", "Reshare", "StatusMessage"))) {
+                               logger('processing retraction for '.$target, LOGGER_DEBUG);
+                               $importer = array("uid" => 0, "page-flags" => PAGE_FREELOVE);
+                               $message_id = self::dispatch($importer, $msg, $fields);
+                               return $message_id;
+                       }
+               }
+
                // Now distribute it to the followers
                $r = q("SELECT `user`.* FROM `user` WHERE `user`.`uid` IN
                        (SELECT `contact`.`uid` FROM `contact` WHERE `contact`.`network` = '%s' AND `contact`.`addr` = '%s')
@@ -479,6 +499,9 @@ class Diaspora {
                logger("Received message type ".$type." from ".$sender." for user ".$importer["uid"], LOGGER_DEBUG);
 
                switch ($type) {
+                       case "account_migration":
+                               return self::receiveAccountMigration($importer, $fields);
+
                        case "account_deletion":
                                return self::receive_account_deletion($importer, $fields);
 
@@ -538,7 +561,7 @@ class Diaspora {
         */
        private static function valid_posting($msg) {
 
-               $data = parse_xml_string($msg["message"], false);
+               $data = parse_xml_string($msg["message"]);
 
                if (!is_object($data)) {
                        logger("No valid XML ".$msg["message"], LOGGER_DEBUG);
@@ -612,9 +635,9 @@ class Diaspora {
                                }
                        }
 
-                       if (($fieldname == "author_signature") AND ($entry != ""))
+                       if (($fieldname == "author_signature") && ($entry != ""))
                                $author_signature = base64_decode($entry);
-                       elseif (($fieldname == "parent_author_signature") AND ($entry != ""))
+                       elseif (($fieldname == "parent_author_signature") && ($entry != ""))
                                $parent_author_signature = base64_decode($entry);
                        elseif (!in_array($fieldname, array("author_signature", "parent_author_signature", "target_author_signature"))) {
                                if ($signed_data != "") {
@@ -624,7 +647,7 @@ class Diaspora {
 
                                $signed_data .= $entry;
                        }
-                       if (!in_array($fieldname, array("parent_author_signature", "target_author_signature")) OR
+                       if (!in_array($fieldname, array("parent_author_signature", "target_author_signature")) ||
                                ($orig_type == "relayable_retraction"))
                                xml::copy($entry, $fields, $fieldname);
                }
@@ -714,13 +737,13 @@ class Diaspora {
                                $update = true;
                }
 
-               if (!$person OR $update) {
+               if (!$person || $update) {
                        logger("create or refresh", LOGGER_DEBUG);
                        $r = probe_url($handle, PROBE_DIASPORA);
 
                        // Note that Friendica contacts will return a "Diaspora person"
                        // if Diaspora connectivity is enabled on their server
-                       if ($r AND ($r["network"] === NETWORK_DIASPORA)) {
+                       if ($r && ($r["network"] === NETWORK_DIASPORA)) {
                                self::add_fcontact($r, $update);
                                $person = $r;
                        }
@@ -881,8 +904,8 @@ class Diaspora {
                        return $r[0];
                } else {
                        /*
-                        * Not found yet? Then use another function for it that will
-                        * possibly create a contact entry.
+                        * We haven't found it?
+                        * We use another function for it that will possibly create a contact entry.
                         */
                        $cid = get_contact($handle, $uid);
 
@@ -923,25 +946,23 @@ class Diaspora {
        private static function post_allow($importer, $contact, $is_comment = false) {
 
                /*
-                * perhaps we were already sharing with this person. Now they're sharing with us.
+                * Perhaps we were already sharing with this person. Now they're sharing with us.
                 * That makes us friends.
                 * Normally this should have handled by getting a request - but this could get lost
                 */
                if ($contact["rel"] == CONTACT_IS_FOLLOWER && in_array($importer["page-flags"], array(PAGE_FREELOVE))) {
-                       q("UPDATE `contact` SET `rel` = %d, `writable` = 1 WHERE `id` = %d AND `uid` = %d",
-                               intval(CONTACT_IS_FRIEND),
-                               intval($contact["id"]),
-                               intval($importer["uid"])
-                       );
+                       dba::update('contact', array('rel' => CONTACT_IS_FRIEND, 'writable' => true),
+                                       array('id' => $contact["id"], 'uid' => $contact["uid"]));
+
                        $contact["rel"] = CONTACT_IS_FRIEND;
                        logger("defining user ".$contact["nick"]." as friend");
                }
 
-               // Is this contact wanted?
+               // We don't seem to like that person
                if ($contact["blocked"] || $contact["readonly"] || $contact["archive"]) {
                        // Maybe blocked, don't accept.
                        return false;
-               // Is this person being followed?
+               // We are following this person?
                } elseif (($contact["rel"] == CONTACT_IS_SHARING) || ($contact["rel"] == CONTACT_IS_FRIEND)) {
                        // Yes, then it is fine.
                        return true;
@@ -1014,10 +1035,16 @@ class Diaspora {
         * @param array $item The item array
         */
        private static function fetch_guid($item) {
+               $expression = "=diaspora://.*?/post/([0-9A-Za-z\-_@.:]{15,254}[0-9A-Za-z])=ism";
+               preg_replace_callback($expression,
+                       function ($match) use ($item) {
+                               return self::fetch_guid_sub($match, $item);
+                       }, $item["body"]);
+
                preg_replace_callback("&\[url=/posts/([^\[\]]*)\](.*)\[\/url\]&Usi",
-                       function ($match) use ($item){
-                               return(self::fetch_guid_sub($match, $item));
-                       },$item["body"]);
+                       function ($match) use ($item) {
+                               return self::fetch_guid_sub($match, $item);
+                       }, $item["body"]);
        }
 
        /**
@@ -1029,7 +1056,7 @@ class Diaspora {
         *
         * @return the replaced string
         */
-       public function replace_people_guid($body, $author_link) {
+       public static function replace_people_guid($body, $author_link) {
                $return = preg_replace_callback("&\[url=/people/([^\[\]]*)\](.*)\[\/url\]&Usi",
                        function ($match) use ($author_link) {
                                // $match
@@ -1107,7 +1134,8 @@ class Diaspora {
                        return false;
 
                // This will work for new Diaspora servers and Friendica servers from 3.5
-               $source_url = $server."/fetch/post/".$guid;
+               $source_url = $server."/fetch/post/".urlencode($guid);
+
                logger("Fetch post from ".$source_url, LOGGER_DEBUG);
 
                $envelope = fetch_url($source_url);
@@ -1123,7 +1151,7 @@ class Diaspora {
 
                // This will work for older Diaspora and Friendica servers
                if (!$x) {
-                       $source_url = $server."/p/".$guid.".xml";
+                       $source_url = $server."/p/".urlencode($guid).".xml";
                        logger("Fetch post from ".$source_url, LOGGER_DEBUG);
 
                        $x = fetch_url($source_url);
@@ -1131,7 +1159,7 @@ class Diaspora {
                                return false;
                }
 
-               $source_xml = parse_xml_string($x, false);
+               $source_xml = parse_xml_string($x);
 
                if (!is_object($source_xml))
                        return false;
@@ -1151,7 +1179,7 @@ class Diaspora {
                // Fetch the author - for the old and the new Diaspora version
                if ($source_xml->post->status_message->diaspora_handle)
                        $author = (string)$source_xml->post->status_message->diaspora_handle;
-               elseif ($source_xml->author AND ($source_xml->getName() == "status_message"))
+               elseif ($source_xml->author && ($source_xml->getName() == "status_message"))
                        $author = (string)$source_xml->author;
 
                // If this isn't a "status_message" then quit
@@ -1178,7 +1206,7 @@ class Diaspora {
         * @return array the item record
         */
        private static function parent_item($uid, $guid, $author, $contact) {
-               $r = q("SELECT `id`, `body`, `wall`, `uri`, `private`, `origin`,
+               $r = q("SELECT `id`, `parent`, `body`, `wall`, `uri`, `guid`, `private`, `origin`,
                                `author-name`, `author-link`, `author-avatar`,
                                `owner-name`, `owner-link`, `owner-avatar`
                        FROM `item` WHERE `uid` = %d AND `guid` = '%s' LIMIT 1",
@@ -1261,26 +1289,123 @@ class Diaspora {
         *
         * @return string the post link
         */
-       private static function plink($addr, $guid) {
+       private static function plink($addr, $guid, $parent_guid = '') {
                $r = q("SELECT `url`, `nick`, `network` FROM `fcontact` WHERE `addr`='%s' LIMIT 1", dbesc($addr));
 
                // Fallback
-               if (!$r)
-                       return "https://".substr($addr,strpos($addr,"@")+1)."/posts/".$guid;
+               if (!dbm::is_result($r)) {
+                       if ($parent_guid != '') {
+                               return "https://".substr($addr,strpos($addr,"@") + 1)."/posts/".$parent_guid."#".$guid;
+                       } else {
+                               return "https://".substr($addr,strpos($addr,"@") + 1)."/posts/".$guid;
+                       }
+               }
 
                // Friendica contacts are often detected as Diaspora contacts in the "fcontact" table
                // So we try another way as well.
                $s = q("SELECT `network` FROM `gcontact` WHERE `nurl`='%s' LIMIT 1", dbesc(normalise_link($r[0]["url"])));
-               if ($s)
+               if (dbm::is_result($s)) {
                        $r[0]["network"] = $s[0]["network"];
+               }
 
-               if ($r[0]["network"] == NETWORK_DFRN)
-                       return(str_replace("/profile/".$r[0]["nick"]."/", "/display/".$guid, $r[0]["url"]."/"));
+               if ($r[0]["network"] == NETWORK_DFRN) {
+                       return str_replace("/profile/".$r[0]["nick"]."/", "/display/".$guid, $r[0]["url"]."/");
+               }
 
-               if (self::is_redmatrix($r[0]["url"]))
+               if (self::is_redmatrix($r[0]["url"])) {
                        return $r[0]["url"]."/?f=&mid=".$guid;
+               }
+
+               if ($parent_guid != '') {
+                       return "https://".substr($addr,strpos($addr,"@")+1)."/posts/".$parent_guid."#".$guid;
+               } else {
+                       return "https://".substr($addr,strpos($addr,"@")+1)."/posts/".$guid;
+               }
+       }
+
+       /**
+        * @brief Receives account migration
+        *
+        * @param array $importer Array of the importer user
+        * @param object $data The message object
+        *
+        * @return bool Success
+        */
+       private static function receiveAccountMigration($importer, $data) {
+               $old_handle = notags(unxmlify($data->author));
+               $new_handle = notags(unxmlify($data->profile->author));
+               $signature = notags(unxmlify($data->signature));
+
+               $contact = self::contact_by_handle($importer["uid"], $old_handle);
+               if (!$contact) {
+                       logger("cannot find contact for sender: ".$old_handle." and user ".$importer["uid"]);
+                       return false;
+               }
+
+               logger("Got migration for ".$old_handle.", to ".$new_handle." with user ".$importer["uid"]);
 
-               return "https://".substr($addr,strpos($addr,"@")+1)."/posts/".$guid;
+               // Check signature
+               $signed_text = 'AccountMigration:'.$old_handle.':'.$new_handle;
+               $key = self::key($old_handle);
+               if (!rsa_verify($signed_text, $signature, $key, "sha256")) {
+                       logger('No valid signature for migration.');
+                       return false;
+               }
+
+               // Update the profile
+               self::receive_profile($importer, $data->profile);
+
+               // change the technical stuff in contact and gcontact
+               $data = Probe::uri($new_handle);
+               if ($data['network'] == NETWORK_PHANTOM) {
+                       logger('Account for '.$new_handle." couldn't be probed.");
+                       return false;
+               }
+
+               $fields = array('url' => $data['url'], 'nurl' => normalise_link($data['url']),
+                               'name' => $data['name'], 'nick' => $data['nick'],
+                               'addr' => $data['addr'], 'batch' => $data['batch'],
+                               'notify' => $data['notify'], 'poll' => $data['poll'],
+                               'network' => $data['network']);
+
+               dba::update('contact', $fields, array('addr' => $old_handle));
+
+               $fields = array('url' => $data['url'], 'nurl' => normalise_link($data['url']),
+                               'name' => $data['name'], 'nick' => $data['nick'],
+                               'addr' => $data['addr'], 'connect' => $data['addr'],
+                               'notify' => $data['notify'], 'photo' => $data['photo'],
+                               'server_url' => $data['baseurl'], 'network' => $data['network']);
+
+               dba::update('gcontact', $fields, array('addr' => $old_handle));
+
+               logger('Contacts are updated.');
+
+               // update items
+               /// @todo This is an extreme performance killer
+               $fields = array(
+                       'owner-link' => array($contact["url"], $data["url"]),
+                       'author-link' => array($contact["url"], $data["url"]),
+               );
+               foreach ($fields as $n=>$f) {
+                       $r = q("SELECT `id` FROM `item` WHERE `%s` = '%s' AND `uid` = %d LIMIT 1",
+                                       $n, dbesc($f[0]),
+                                       intval($importer["uid"]));
+
+                       if (dbm::is_result($r)) {
+                               $x = q("UPDATE `item` SET `%s` = '%s' WHERE `%s` = '%s' AND `uid` = %d",
+                                               $n, dbesc($f[1]),
+                                               $n, dbesc($f[0]),
+                                               intval($importer["uid"]));
+
+                               if ($x === false) {
+                                       return false;
+                               }
+                       }
+               }
+
+               logger('Items are updated.');
+
+               return true;
        }
 
        /**
@@ -1403,7 +1528,7 @@ class Diaspora {
 
                $message_id = self::message_exists($importer["uid"], $guid);
                if ($message_id) {
-                       return $message_id;
+                       return true;
                }
 
                $parent_item = self::parent_item($importer["uid"], $parent_guid, $author, $contact);
@@ -1454,6 +1579,8 @@ class Diaspora {
 
                $datarray["changed"] = $datarray["created"] = $datarray["edited"] = $created_at;
 
+               $datarray["plink"] = self::plink($author, $guid, $parent_item['guid']);
+
                $body = diaspora2bb($text);
 
                $datarray["body"] = self::replace_people_guid($body, $person["url"]);
@@ -1462,25 +1589,26 @@ class Diaspora {
 
                $message_id = item_store($datarray);
 
+               if ($message_id <= 0) {
+                       return false;
+               }
+
                if ($message_id) {
                        logger("Stored comment ".$datarray["guid"]." with message id ".$message_id, LOGGER_DEBUG);
                }
 
                // If we are the origin of the parent we store the original data and notify our followers
-               if ($message_id AND $parent_item["origin"]) {
+               if ($message_id && $parent_item["origin"]) {
 
                        // Formerly we stored the signed text, the signature and the author in different fields.
                        // We now store the raw data so that we are more flexible.
-                       q("INSERT INTO `sign` (`iid`,`signed_text`) VALUES (%d,'%s')",
-                               intval($message_id),
-                               dbesc(json_encode($data))
-                       );
+                       dba::insert('sign', array('iid' => $message_id, 'signed_text' => json_encode($data)));
 
                        // notify others
                        proc_run(PRIORITY_HIGH, "include/notifier.php", "comment-import", $message_id);
                }
 
-               return $message_id;
+               return true;
        }
 
        /**
@@ -1525,6 +1653,8 @@ class Diaspora {
 
                $person = self::person_by_handle($msg_author);
 
+               dba::lock('mail');
+
                $r = q("SELECT `id` FROM `mail` WHERE `guid` = '%s' AND `uid` = %d LIMIT 1",
                        dbesc($msg_guid),
                        intval($importer["uid"])
@@ -1552,10 +1682,9 @@ class Diaspora {
                        dbesc($msg_created_at)
                );
 
-               q("UPDATE `conv` SET `updated` = '%s' WHERE `id` = %d",
-                       dbesc(datetime_convert()),
-                       intval($conversation["id"])
-               );
+               dba::unlock();
+
+               dba::update('conv', array('updated' => datetime_convert()), array('id' => $conversation["id"]));
 
                notification(array(
                        "type" => NOTIFY_MAIL,
@@ -1631,7 +1760,7 @@ class Diaspora {
                }
                if (!$conversation) {
                        logger("unable to create conversation.");
-                       return;
+                       return false;
                }
 
                foreach ($messages as $mesg)
@@ -1654,7 +1783,7 @@ class Diaspora {
 
                $ulink = "[url=".$contact["url"]."]".$contact["name"]."[/url]";
                $alink = "[url=".$parent_item["author-link"]."]".$parent_item["author-name"]."[/url]";
-               $plink = "[url=".App::get_baseurl()."/display/".urlencode($guid)."]".t("status")."[/url]";
+               $plink = "[url=".System::baseUrl()."/display/".urlencode($guid)."]".t("status")."[/url]";
 
                return sprintf($bodyverb, $ulink, $alink, $plink);
        }
@@ -1669,7 +1798,7 @@ class Diaspora {
         */
        private static function construct_like_object($importer, $parent_item) {
                $objtype = ACTIVITY_OBJ_NOTE;
-               $link = '<link rel="alternate" type="text/html" href="'.App::get_baseurl()."/display/".$importer["nickname"]."/".$parent_item["id"].'" />';
+               $link = '<link rel="alternate" type="text/html" href="'.System::baseUrl()."/display/".$importer["nickname"]."/".$parent_item["id"].'" />';
                $parent_body = $parent_item["body"];
 
                $xmldata = array("object" => array("type" => $objtype,
@@ -1709,7 +1838,7 @@ class Diaspora {
 
                $message_id = self::message_exists($importer["uid"], $guid);
                if ($message_id)
-                       return $message_id;
+                       return true;
 
                $parent_item = self::parent_item($importer["uid"], $parent_guid, $author, $contact);
                if (!$parent_item)
@@ -1762,24 +1891,34 @@ class Diaspora {
 
                $message_id = item_store($datarray);
 
-               if ($message_id)
+               if ($message_id <= 0) {
+                       return false;
+               }
+
+               if ($message_id) {
                        logger("Stored like ".$datarray["guid"]." with message id ".$message_id, LOGGER_DEBUG);
+               }
+
+               // like on comments have the comment as parent. So we need to fetch the toplevel parent
+               if ($parent_item["id"] != $parent_item["parent"]) {
+                       $toplevel = dba::select('item', array('origin'), array('id' => $parent_item["parent"]), array('limit' => 1));
+                       $origin = $toplevel["origin"];
+               } else {
+                       $origin = $parent_item["origin"];
+               }
 
                // If we are the origin of the parent we store the original data and notify our followers
-               if ($message_id AND $parent_item["origin"]) {
+               if ($message_id && $origin) {
 
                        // Formerly we stored the signed text, the signature and the author in different fields.
                        // We now store the raw data so that we are more flexible.
-                       q("INSERT INTO `sign` (`iid`,`signed_text`) VALUES (%d,'%s')",
-                               intval($message_id),
-                               dbesc(json_encode($data))
-                       );
+                       dba::insert('sign', array('iid' => $message_id, 'signed_text' => json_encode($data)));
 
                        // notify others
                        proc_run(PRIORITY_HIGH, "include/notifier.php", "comment-import", $message_id);
                }
 
-               return $message_id;
+               return true;
        }
 
        /**
@@ -1823,6 +1962,12 @@ class Diaspora {
                        return false;
                }
 
+               $body = diaspora2bb($text);
+
+               $body = self::replace_people_guid($body, $person["url"]);
+
+               dba::lock('mail');
+
                $r = q("SELECT `id` FROM `mail` WHERE `guid` = '%s' AND `uid` = %d LIMIT 1",
                        dbesc($guid),
                        intval($importer["uid"])
@@ -1832,10 +1977,6 @@ class Diaspora {
                        return false;
                }
 
-               $body = diaspora2bb($text);
-
-               $body = self::replace_people_guid($body, $person["url"]);
-
                q("INSERT INTO `mail` (`uid`, `guid`, `convid`, `from-name`,`from-photo`,`from-url`,`contact-id`,`title`,`body`,`seen`,`reply`,`uri`,`parent-uri`,`created`)
                                VALUES ( %d, '%s', %d, '%s', '%s', '%s', %d, '%s', '%s', %d, %d, '%s','%s','%s')",
                        intval($importer["uid"]),
@@ -1854,11 +1995,9 @@ class Diaspora {
                        dbesc($created_at)
                );
 
-               q("UPDATE `conv` SET `updated` = '%s' WHERE `id` = %d",
-                       dbesc(datetime_convert()),
-                       intval($conversation["id"])
-               );
+               dba::unlock();
 
+               dba::update('conv', array('updated' => datetime_convert()), array('id' => $conversation["id"]));
                return true;
        }
 
@@ -2001,12 +2140,9 @@ class Diaspora {
 
                $a = get_app();
 
-               if ($contact["rel"] == CONTACT_IS_FOLLOWER && in_array($importer["page-flags"], array(PAGE_FREELOVE))) {
-                       q("UPDATE `contact` SET `rel` = %d, `writable` = 1 WHERE `id` = %d AND `uid` = %d",
-                               intval(CONTACT_IS_FRIEND),
-                               intval($contact["id"]),
-                               intval($importer["uid"])
-                       );
+               if ($contact["rel"] == CONTACT_IS_SHARING) {
+                       dba::update('contact', array('rel' => CONTACT_IS_FRIEND, 'writable' => true),
+                                       array('id' => $contact["id"], 'uid' => $importer["uid"]));
                }
                // send notification
 
@@ -2115,8 +2251,8 @@ class Diaspora {
                // perhaps we were already sharing with this person. Now they're sharing with us.
                // That makes us friends.
                if ($contact) {
-                       if ($following AND $sharing) {
-                               logger("Author ".$author." (Contact ".$contact["id"].") wants to have a bidirectional conection.", LOGGER_DEBUG);
+                       if ($following) {
+                               logger("Author ".$author." (Contact ".$contact["id"].") wants to follow us.", LOGGER_DEBUG);
                                self::receive_request_make_friend($importer, $contact);
 
                                // refetch the contact array
@@ -2124,7 +2260,7 @@ class Diaspora {
 
                                // If we are now friends, we are sending a share message.
                                // Normally we needn't to do so, but the first message could have been vanished.
-                               if (in_array($contact["rel"], array(CONTACT_IS_FRIEND, CONTACT_IS_FOLLOWER))) {
+                               if (in_array($contact["rel"], array(CONTACT_IS_FRIEND))) {
                                        $u = q("SELECT * FROM `user` WHERE `uid` = %d LIMIT 1", intval($importer["uid"]));
                                        if ($u) {
                                                logger("Sending share message to author ".$author." - Contact: ".$contact["id"]." - User: ".$importer["uid"], LOGGER_DEBUG);
@@ -2132,23 +2268,24 @@ class Diaspora {
                                        }
                                }
                                return true;
-                       } else { /// @todo Handle all possible variations of adding and retracting of permissions
-                               logger("Author ".$author." (Contact ".$contact["id"].") wants to change the relationship: Following: ".$following." - sharing: ".$sharing. "(By now unsupported)", LOGGER_DEBUG);
-                               return false;
+                       } else {
+                               logger("Author ".$author." doesn't want to follow us anymore.", LOGGER_DEBUG);
+                               lose_follower($importer, $contact);
+                               return true;
                        }
                }
 
-               if (!$following AND $sharing AND in_array($importer["page-flags"], array(PAGE_SOAPBOX, PAGE_NORMAL))) {
+               if (!$following && $sharing && in_array($importer["page-flags"], array(PAGE_SOAPBOX, PAGE_NORMAL))) {
                        logger("Author ".$author." wants to share with us - but doesn't want to listen. Request is ignored.", LOGGER_DEBUG);
                        return false;
-               } elseif (!$following AND !$sharing) {
+               } elseif (!$following && !$sharing) {
                        logger("Author ".$author." doesn't want anything - and we don't know the author. Request is ignored.", LOGGER_DEBUG);
                        return false;
-               } elseif (!$following AND $sharing) {
+               } elseif (!$following && $sharing) {
                        logger("Author ".$author." wants to share with us.", LOGGER_DEBUG);
-               } elseif ($following AND $sharing) {
+               } elseif ($following && $sharing) {
                        logger("Author ".$author." wants to have a bidirectional conection.", LOGGER_DEBUG);
-               } elseif ($following AND !$sharing) {
+               } elseif ($following && !$sharing) {
                        logger("Author ".$author." wants to listen to us.", LOGGER_DEBUG);
                }
 
@@ -2226,9 +2363,9 @@ class Diaspora {
                        // but if our page-type is PAGE_COMMUNITY or PAGE_SOAPBOX
                        // we are going to change the relationship and make them a follower.
 
-                       if (($importer["page-flags"] == PAGE_FREELOVE) AND $sharing AND $following)
+                       if (($importer["page-flags"] == PAGE_FREELOVE) && $sharing && $following)
                                $new_relation = CONTACT_IS_FRIEND;
-                       elseif (($importer["page-flags"] == PAGE_FREELOVE) AND $sharing)
+                       elseif (($importer["page-flags"] == PAGE_FREELOVE) && $sharing)
                                $new_relation = CONTACT_IS_SHARING;
                        else
                                $new_relation = CONTACT_IS_FOLLOWER;
@@ -2285,7 +2422,7 @@ class Diaspora {
                        // If it is a reshared post from another network then reformat to avoid display problems with two share elements
                        if (self::is_reshare($r[0]["body"], true)) {
                                $r = array();
-                       } elseif (self::is_reshare($r[0]["body"], false)) {
+                       } elseif (self::is_reshare($r[0]["body"], false) || strstr($r[0]["body"], "[share")) {
                                $r[0]["body"] = diaspora2bb(bb2diaspora($r[0]["body"]));
 
                                $r[0]["body"] = self::replace_people_guid($r[0]["body"], $r[0]["author-link"]);
@@ -2356,7 +2493,7 @@ class Diaspora {
 
                $message_id = self::message_exists($importer["uid"], $guid);
                if ($message_id) {
-                       return $message_id;
+                       return true;
                }
 
                $original_item = self::original_item($root_guid, $root_author, $author);
@@ -2364,7 +2501,7 @@ class Diaspora {
                        return false;
                }
 
-               $orig_url = App::get_baseurl()."/display/".$original_item["guid"];
+               $orig_url = System::baseUrl()."/display/".$original_item["guid"];
 
                $datarray = array();
 
@@ -2407,9 +2544,10 @@ class Diaspora {
 
                if ($message_id) {
                        logger("Stored reshare ".$datarray["guid"]." with message id ".$message_id, LOGGER_DEBUG);
+                       return true;
+               } else {
+                       return false;
                }
-
-               return $message_id;
        }
 
        /**
@@ -2432,43 +2570,52 @@ class Diaspora {
                        return false;
                }
 
-               if (!isset($contact["url"])) {
+               if (empty($contact["url"])) {
                        $contact["url"] = $person["url"];
                }
 
-               $r = q("SELECT `id`, `parent`, `parent-uri`, `author-link` FROM `item` WHERE `guid` = '%s' AND `uid` = %d AND NOT `file` LIKE '%%[%%' LIMIT 1",
-                       dbesc($target_guid),
-                       intval($importer["uid"])
-               );
-               if (!$r) {
-                       logger("Target guid ".$target_guid." was not found for user ".$importer["uid"]);
+               // Fetch items that are about to be deleted
+               $fields = array('uid', 'id', 'parent', 'parent-uri', 'author-link');
+
+               // When we receive a public retraction, we delete every item that we find.
+               if ($importer['uid'] == 0) {
+                       $condition = array("`guid` = ? AND NOT `file` LIKE '%%[%%' AND NOT `deleted`", $target_guid);
+               } else {
+                       $condition = array("`guid` = ? AND `uid` = ? AND NOT `file` LIKE '%%[%%' AND NOT `deleted`", $target_guid, $importer['uid']);
+               }
+               $r = dba::select('item', $fields, $condition);
+               if (!dbm::is_result($r)) {
+                       logger("Target guid ".$target_guid." was not found on this system for user ".$importer['uid'].".");
                        return false;
                }
 
-               // Check if the sender is the thread owner
-               $p = q("SELECT `id`, `author-link`, `origin` FROM `item` WHERE `id` = %d",
-                       intval($r[0]["parent"]));
+               while ($item = dba::fetch($r)) {
+                       // Fetch the parent item
+                       $parent = dba::select('item', array('author-link', 'origin'), array('id' => $item["parent"]), array('limit' => 1));
 
-               // Only delete it if the parent author really fits
-               if (!link_compare($p[0]["author-link"], $contact["url"]) AND !link_compare($r[0]["author-link"], $contact["url"])) {
-                       logger("Thread author ".$p[0]["author-link"]." and item author ".$r[0]["author-link"]." don't fit to expected contact ".$contact["url"], LOGGER_DEBUG);
-                       return false;
-               }
+                       // Only delete it if the parent author really fits
+                       if (!link_compare($parent["author-link"], $contact["url"]) && !link_compare($item["author-link"], $contact["url"])) {
+                               logger("Thread author ".$parent["author-link"]." and item author ".$item["author-link"]." don't fit to expected contact ".$contact["url"], LOGGER_DEBUG);
+                               continue;
+                       }
 
-               // Currently we don't have a central deletion function that we could use in this case. The function "item_drop" doesn't work for that case
-               q("UPDATE `item` SET `deleted` = 1, `edited` = '%s', `changed` = '%s', `body` = '' , `title` = '' WHERE `id` = %d",
-                       dbesc(datetime_convert()),
-                       dbesc(datetime_convert()),
-                       intval($r[0]["id"])
-               );
-               delete_thread($r[0]["id"], $r[0]["parent-uri"]);
+                       // Currently we don't have a central deletion function that we could use in this case. The function "item_drop" doesn't work for that case
+                       dba::update('item', array('deleted' => true, 'title' => '', 'body' => '',
+                                               'edited' => datetime_convert(), 'changed' => datetime_convert()),
+                                       array('id' => $item["id"]));
 
-               logger("Deleted target ".$target_guid." (".$r[0]["id"].") from user ".$importer["uid"]." parent: ".$p[0]["id"], LOGGER_DEBUG);
+                       // Delete the thread - if it is a starting post and not a comment
+                       if ($target_type != 'Comment') {
+                               delete_thread($item["id"], $item["parent-uri"]);
+                       }
 
-               // Now check if the retraction needs to be relayed by us
-               if ($p[0]["origin"]) {
-                       // notify others
-                       proc_run(PRIORITY_HIGH, "include/notifier.php", "drop", $r[0]["id"]);
+                       logger("Deleted target ".$target_guid." (".$item["id"].") from user ".$item["uid"]." parent: ".$item["parent"], LOGGER_DEBUG);
+
+                       // Now check if the retraction needs to be relayed by us
+                       if ($parent["origin"]) {
+                               // notify others
+                               proc_run(PRIORITY_HIGH, "include/notifier.php", "drop", $item["id"]);
+                       }
                }
 
                return true;
@@ -2487,7 +2634,7 @@ class Diaspora {
                $target_type = notags(unxmlify($data->target_type));
 
                $contact = self::contact_by_handle($importer["uid"], $sender);
-               if (!$contact AND (in_array($target_type, array("Contact", "Person")))) {
+               if (!$contact && (in_array($target_type, array("Contact", "Person")))) {
                        logger("cannot find contact for sender: ".$sender." and user ".$importer["uid"]);
                        return false;
                }
@@ -2497,7 +2644,7 @@ class Diaspora {
                switch ($target_type) {
                        case "Comment":
                        case "Like":
-                       case "Post": // "Post" will be supported in a future version
+                       case "Post":
                        case "Reshare":
                        case "StatusMessage":
                                return self::item_retraction($importer, $contact, $data);
@@ -2540,7 +2687,7 @@ class Diaspora {
 
                $message_id = self::message_exists($importer["uid"], $guid);
                if ($message_id) {
-                       return $message_id;
+                       return true;
                }
 
                $address = array();
@@ -2615,7 +2762,7 @@ class Diaspora {
                        $datarray["location"] = $address["address"];
                }
 
-               if (isset($address["lat"]) AND isset($address["lng"])) {
+               if (isset($address["lat"]) && isset($address["lng"])) {
                        $datarray["coord"] = $address["lat"]." ".$address["lng"];
                }
 
@@ -2624,9 +2771,10 @@ class Diaspora {
 
                if ($message_id) {
                        logger("Stored item ".$datarray["guid"]." with message id ".$message_id, LOGGER_DEBUG);
+                       return true;
+               } else {
+                       return false;
                }
-
-               return $message_id;
        }
 
        /* ************************************************************************************** *
@@ -2653,45 +2801,12 @@ class Diaspora {
                        $nick = $contact["nick"];
                }
 
-               return $nick."@".substr(App::get_baseurl(), strpos(App::get_baseurl(),"://") + 3);
+               return $nick."@".substr(System::baseUrl(), strpos(System::baseUrl(),"://") + 3);
        }
 
-       /**
-        * @brief Creates the envelope for the "fetch" endpoint
-        *
-        * @param string $msg The message that is to be transmitted
-        * @param array $user The record of the sender
-        *
-        * @return string The envelope
-        */
-
-       public static function build_magic_envelope($msg, $user) {
-
-               $b64url_data = base64url_encode($msg);
-               $data = str_replace(array("\n", "\r", " ", "\t"), array("", "", "", ""), $b64url_data);
-
-               $key_id = base64url_encode(self::my_handle($user));
-               $type = "application/xml";
-               $encoding = "base64url";
-               $alg = "RSA-SHA256";
-               $signable_data = $data.".".base64url_encode($type).".".base64url_encode($encoding).".".base64url_encode($alg);
-               $signature = rsa_sign($signable_data, $user["prvkey"]);
-               $sig = base64url_encode($signature);
-
-               $xmldata = array("me:env" => array("me:data" => $data,
-                                                       "@attributes" => array("type" => $type),
-                                                       "me:encoding" => $encoding,
-                                                       "me:alg" => $alg,
-                                                       "me:sig" => $sig,
-                                                       "@attributes2" => array("key_id" => $key_id)));
-
-               $namespaces = array("me" => "http://salmon-protocol.org/ns/magic-env");
-
-               return xml::from_array($xmldata, $xml, false, $namespaces);
-       }
 
        /**
-        * @brief Creates the envelope for a public message
+        * @brief Creates the data for a private message in the new format
         *
         * @param string $msg The message that is to be transmitted
         * @param array $user The record of the sender
@@ -2699,129 +2814,72 @@ class Diaspora {
         * @param string $prvkey The private key of the sender
         * @param string $pubkey The public key of the receiver
         *
-        * @return string The envelope
+        * @return string The encrypted data
         */
-       private static function build_public_message($msg, $user, $contact, $prvkey, $pubkey) {
+       public static function encode_private_data($msg, $user, $contact, $prvkey, $pubkey) {
 
                logger("Message: ".$msg, LOGGER_DATA);
 
-               $handle = self::my_handle($user);
-
-               $b64url_data = base64url_encode($msg);
-
-               $data = str_replace(array("\n", "\r", " ", "\t"), array("", "", "", ""), $b64url_data);
-
-               $type = "application/xml";
-               $encoding = "base64url";
-               $alg = "RSA-SHA256";
+               // without a public key nothing will work
+               if (!$pubkey) {
+                       logger("pubkey missing: contact id: ".$contact["id"]);
+                       return false;
+               }
 
-               $signable_data = $data.".".base64url_encode($type).".".base64url_encode($encoding).".".base64url_encode($alg);
+               $aes_key = openssl_random_pseudo_bytes(32);
+               $b_aes_key = base64_encode($aes_key);
+               $iv = openssl_random_pseudo_bytes(16);
+               $b_iv = base64_encode($iv);
 
-               $signature = rsa_sign($signable_data,$prvkey);
-               $sig = base64url_encode($signature);
+               $ciphertext = self::aes_encrypt($aes_key, $iv, $msg);
 
-               $xmldata = array("diaspora" => array("header" => array("author_id" => $handle),
-                                                       "me:env" => array("me:encoding" => $encoding,
-                                                       "me:alg" => $alg,
-                                                       "me:data" => $data,
-                                                       "@attributes" => array("type" => $type),
-                                                       "me:sig" => $sig)));
+               $json = json_encode(array("iv" => $b_iv, "key" => $b_aes_key));
 
-               $namespaces = array("" => "https://joindiaspora.com/protocol",
-                               "me" => "http://salmon-protocol.org/ns/magic-env");
+               $encrypted_key_bundle = "";
+               openssl_public_encrypt($json, $encrypted_key_bundle, $pubkey);
 
-               $magic_env = xml::from_array($xmldata, $xml, false, $namespaces);
+               $json_object = json_encode(array("aes_key" => base64_encode($encrypted_key_bundle),
+                                               "encrypted_magic_envelope" => base64_encode($ciphertext)));
 
-               logger("magic_env: ".$magic_env, LOGGER_DATA);
-               return $magic_env;
+               return $json_object;
        }
 
        /**
-        * @brief Creates the envelope for a private message
+        * @brief Creates the envelope for the "fetch" endpoint and for the new format
         *
         * @param string $msg The message that is to be transmitted
         * @param array $user The record of the sender
-        * @param array $contact Target of the communication
-        * @param string $prvkey The private key of the sender
-        * @param string $pubkey The public key of the receiver
         *
         * @return string The envelope
         */
-       private static function build_private_message($msg, $user, $contact, $prvkey, $pubkey) {
-
-               logger("Message: ".$msg, LOGGER_DATA);
-
-               // without a public key nothing will work
-
-               if (!$pubkey) {
-                       logger("pubkey missing: contact id: ".$contact["id"]);
-                       return false;
-               }
-
-               $inner_aes_key = openssl_random_pseudo_bytes(32);
-               $b_inner_aes_key = base64_encode($inner_aes_key);
-               $inner_iv = openssl_random_pseudo_bytes(16);
-               $b_inner_iv = base64_encode($inner_iv);
-
-               $outer_aes_key = openssl_random_pseudo_bytes(32);
-               $b_outer_aes_key = base64_encode($outer_aes_key);
-               $outer_iv = openssl_random_pseudo_bytes(16);
-               $b_outer_iv = base64_encode($outer_iv);
-
-               $handle = self::my_handle($user);
-
-               $inner_encrypted = self::aes_encrypt($inner_aes_key, $inner_iv, $msg);
-
-               $b64_data = base64_encode($inner_encrypted);
-
+       public static function build_magic_envelope($msg, $user) {
 
-               $b64url_data = base64url_encode($b64_data);
+               $b64url_data = base64url_encode($msg);
                $data = str_replace(array("\n", "\r", " ", "\t"), array("", "", "", ""), $b64url_data);
 
+               $key_id = base64url_encode(self::my_handle($user));
                $type = "application/xml";
                $encoding = "base64url";
                $alg = "RSA-SHA256";
-
                $signable_data = $data.".".base64url_encode($type).".".base64url_encode($encoding).".".base64url_encode($alg);
 
-               $signature = rsa_sign($signable_data,$prvkey);
-               $sig = base64url_encode($signature);
-
-               $xmldata = array("decrypted_header" => array("iv" => $b_inner_iv,
-                                                       "aes_key" => $b_inner_aes_key,
-                                                       "author_id" => $handle));
-
-               $decrypted_header = xml::from_array($xmldata, $xml, true);
-
-               $ciphertext = self::aes_encrypt($outer_aes_key, $outer_iv, $decrypted_header);
-
-               $outer_json = json_encode(array("iv" => $b_outer_iv, "key" => $b_outer_aes_key));
-
-               $encrypted_outer_key_bundle = "";
-               openssl_public_encrypt($outer_json, $encrypted_outer_key_bundle, $pubkey);
-
-               $b64_encrypted_outer_key_bundle = base64_encode($encrypted_outer_key_bundle);
-
-               logger("outer_bundle: ".$b64_encrypted_outer_key_bundle." key: ".$pubkey, LOGGER_DATA);
-
-               $encrypted_header_json_object = json_encode(array("aes_key" => base64_encode($encrypted_outer_key_bundle),
-                                                               "ciphertext" => base64_encode($ciphertext)));
-               $cipher_json = base64_encode($encrypted_header_json_object);
+               // Fallback if the private key wasn't transmitted in the expected field
+               if ($user['uprvkey'] == "")
+                       $user['uprvkey'] = $user['prvkey'];
 
-               $xmldata = array("diaspora" => array("encrypted_header" => $cipher_json,
-                                               "me:env" => array("me:encoding" => $encoding,
-                                                               "me:alg" => $alg,
-                                                               "me:data" => $data,
-                                                               "@attributes" => array("type" => $type),
-                                                               "me:sig" => $sig)));
+               $signature = rsa_sign($signable_data, $user["uprvkey"]);
+               $sig = base64url_encode($signature);
 
-               $namespaces = array("" => "https://joindiaspora.com/protocol",
-                               "me" => "http://salmon-protocol.org/ns/magic-env");
+               $xmldata = array("me:env" => array("me:data" => $data,
+                                                       "@attributes" => array("type" => $type),
+                                                       "me:encoding" => $encoding,
+                                                       "me:alg" => $alg,
+                                                       "me:sig" => $sig,
+                                                       "@attributes2" => array("key_id" => $key_id)));
 
-               $magic_env = xml::from_array($xmldata, $xml, false, $namespaces);
+               $namespaces = array("me" => "http://salmon-protocol.org/ns/magic-env");
 
-               logger("magic_env: ".$magic_env, LOGGER_DATA);
-               return $magic_env;
+               return xml::from_array($xmldata, $xml, false, $namespaces);
        }
 
        /**
@@ -2838,14 +2896,15 @@ class Diaspora {
         */
        private static function build_message($msg, $user, $contact, $prvkey, $pubkey, $public = false) {
 
-               if ($public)
-                       $magic_env =  self::build_public_message($msg,$user,$contact,$prvkey,$pubkey);
-               else
-                       $magic_env =  self::build_private_message($msg,$user,$contact,$prvkey,$pubkey);
+               // The message is put into an envelope with the sender's signature
+               $envelope = self::build_magic_envelope($msg, $user);
 
-               // The data that will be transmitted is double encoded via "urlencode", strange ...
-               $slap = "xml=".urlencode(urlencode($magic_env));
-               return $slap;
+               // Private messages are put into a second envelope, encrypted with the receivers public key
+               if (!$public) {
+                       $envelope = self::encode_private_data($envelope, $user, $contact, $prvkey, $pubkey);
+               }
+
+               return $envelope;
        }
 
        /**
@@ -2871,14 +2930,14 @@ class Diaspora {
         *
         * @param array $owner the array of the item owner
         * @param array $contact Target of the communication
-        * @param string $slap The message that is to be transmitted
+        * @param string $envelope The message that is to be transmitted
         * @param bool $public_batch Is it a public post?
         * @param bool $queue_run Is the transmission called from the queue?
         * @param string $guid message guid
         *
         * @return int Result of the transmission
         */
-       public static function transmit($owner, $contact, $slap, $public_batch, $queue_run=false, $guid = "") {
+       public static function transmit($owner, $contact, $envelope, $public_batch, $queue_run=false, $guid = "") {
 
                $a = get_app();
 
@@ -2899,7 +2958,9 @@ class Diaspora {
                        $return_code = 0;
                } else {
                        if (!intval(get_config("system", "diaspora_test"))) {
-                               post_url($dest_url."/", $slap);
+                               $content_type = (($public_batch) ? "application/magic-envelope+xml" : "application/json");
+
+                               post_url($dest_url."/", $envelope, array("Content-Type: ".$content_type));
                                $return_code = $a->get_curl_code();
                        } else {
                                logger("test_mode");
@@ -2915,19 +2976,19 @@ class Diaspora {
                        $r = q("SELECT `id` FROM `queue` WHERE `cid` = %d AND `network` = '%s' AND `content` = '%s' AND `batch` = %d LIMIT 1",
                                intval($contact["id"]),
                                dbesc(NETWORK_DIASPORA),
-                               dbesc($slap),
+                               dbesc($envelope),
                                intval($public_batch)
                        );
                        if ($r) {
                                logger("add_to_queue ignored - identical item already in queue");
                        } else {
                                // queue message for redelivery
-                               add_to_queue($contact["id"], NETWORK_DIASPORA, $slap, $public_batch);
+                               add_to_queue($contact["id"], NETWORK_DIASPORA, $envelope, $public_batch);
 
                                // The message could not be delivered. We mark the contact as "dead"
                                mark_for_death($contact);
                        }
-               } elseif (($return_code >= 200) AND ($return_code <= 299)) {
+               } elseif (($return_code >= 200) && ($return_code <= 299)) {
                        // We successfully delivered a message, the contact is alive
                        unmark_for_death($contact);
                }
@@ -2946,7 +3007,8 @@ class Diaspora {
         */
        public static function build_post_xml($type, $message) {
 
-               $data = array("XML" => array("post" => array($type => $message)));
+               $data = array($type => $message);
+
                return xml::from_array($data, $xml);
        }
 
@@ -2974,19 +3036,45 @@ class Diaspora {
                if ($owner['uprvkey'] == "")
                        $owner['uprvkey'] = $owner['prvkey'];
 
-               $slap = self::build_message($msg, $owner, $contact, $owner['uprvkey'], $contact['pubkey'], $public_batch);
+               $envelope = self::build_message($msg, $owner, $contact, $owner['uprvkey'], $contact['pubkey'], $public_batch);
 
                if ($spool) {
-                       add_to_queue($contact['id'], NETWORK_DIASPORA, $slap, $public_batch);
+                       add_to_queue($contact['id'], NETWORK_DIASPORA, $envelope, $public_batch);
                        return true;
                } else
-                       $return_code = self::transmit($owner, $contact, $slap, $public_batch, false, $guid);
+                       $return_code = self::transmit($owner, $contact, $envelope, $public_batch, false, $guid);
 
                logger("guid: ".$item["guid"]." result ".$return_code, LOGGER_DEBUG);
 
                return $return_code;
        }
 
+       /**
+        * @brief sends an account migration
+        *
+        * @param array $owner the array of the item owner
+        * @param array $contact Target of the communication
+        * @param int $uid User ID
+        *
+        * @return int The result of the transmission
+        */
+       public static function sendAccountMigration($owner, $contact, $uid) {
+
+               $old_handle = PConfig::get($uid, 'system', 'previous_addr');
+               $profile = self::createProfileData($uid);
+
+               $signed_text = 'AccountMigration:'.$old_handle.':'.$profile['author'];
+               $signature = base64_encode(rsa_sign($signed_text, $owner["uprvkey"], "sha256"));
+
+               $message = array("author" => $old_handle,
+                               "profile" => $profile,
+                               "signature" => $signature);
+
+               logger("Send account migration ".print_r($message, true), LOGGER_DEBUG);
+
+               return self::build_and_transmit($owner, $contact, "account_migration", $message);
+       }
+
        /**
         * @brief Sends a "share" message
         *
@@ -2995,14 +3083,37 @@ class Diaspora {
         *
         * @return int The result of the transmission
         */
-       public static function send_share($owner,$contact) {
+       public static function send_share($owner, $contact) {
+
+               /**
+                * @todo support the different possible combinations of "following" and "sharing"
+                * Currently, Diaspora only interprets the "sharing" field
+                *
+                * Before switching this code productive, we have to check all "send_share" calls if "rel" is set correctly
+                */
 
-               $message = array("sender_handle" => self::my_handle($owner),
-                               "recipient_handle" => $contact["addr"]);
+               /*
+               switch ($contact["rel"]) {
+                       case CONTACT_IS_FRIEND:
+                               $following = true;
+                               $sharing = true;
+                       case CONTACT_IS_SHARING:
+                               $following = false;
+                               $sharing = true;
+                       case CONTACT_IS_FOLLOWER:
+                               $following = true;
+                               $sharing = false;
+               }
+               */
+
+               $message = array("author" => self::my_handle($owner),
+                               "recipient" => $contact["addr"],
+                               "following" => "true",
+                               "sharing" => "true");
 
                logger("Send share ".print_r($message, true), LOGGER_DEBUG);
 
-               return self::build_and_transmit($owner, $contact, "request", $message);
+               return self::build_and_transmit($owner, $contact, "contact", $message);
        }
 
        /**
@@ -3013,15 +3124,16 @@ class Diaspora {
         *
         * @return int The result of the transmission
         */
-       public static function send_unshare($owner,$contact) {
+       public static function send_unshare($owner, $contact) {
 
-               $message = array("post_guid" => $owner["guid"],
-                               "diaspora_handle" => self::my_handle($owner),
-                               "type" => "Person");
+               $message = array("author" => self::my_handle($owner),
+                               "recipient" => $contact["addr"],
+                               "following" => "false",
+                               "sharing" => "false");
 
                logger("Send unshare ".print_r($message, true), LOGGER_DEBUG);
 
-               return self::build_and_transmit($owner, $contact, "retraction", $message);
+               return self::build_and_transmit($owner, $contact, "contact", $message);
        }
 
        /**
@@ -3037,7 +3149,7 @@ class Diaspora {
 
                // Skip if it isn't a pure repeated messages
                // Does it start with a share?
-               if ((strpos($body, "[share") > 0) AND $complete)
+               if ((strpos($body, "[share") > 0) && $complete)
                        return(false);
 
                // Does it end with a share?
@@ -3085,7 +3197,7 @@ class Diaspora {
                $ret= array();
 
                $ret["root_handle"] = preg_replace("=https?://(.*)/u/(.*)=ism", "$2@$1", $profile);
-               if (($ret["root_handle"] == $profile) OR ($ret["root_handle"] == ""))
+               if (($ret["root_handle"] == $profile) || ($ret["root_handle"] == ""))
                        return(false);
 
                $link = "";
@@ -3098,7 +3210,7 @@ class Diaspora {
                        $link = $matches[1];
 
                $ret["root_guid"] = preg_replace("=https?://(.*)/posts/(.*)=ism", "$2", $link);
-               if (($ret["root_guid"] == $link) OR (trim($ret["root_guid"]) == ""))
+               if (($ret["root_guid"] == $link) || (trim($ret["root_guid"]) == ""))
                        return(false);
 
                return($ret);
@@ -3158,7 +3270,7 @@ class Diaspora {
                if ($event['start']) {
                        $eventdata['start'] = datetime_convert($eventdata['timezone'], "UTC", $event['start'], $mask);
                }
-               if ($event['finish'] AND !$event['nofinish']) {
+               if ($event['finish'] && !$event['nofinish']) {
                        $eventdata['end'] = datetime_convert($eventdata['timezone'], "UTC", $event['finish'], $mask);
                }
                if ($event['summary']) {
@@ -3204,14 +3316,14 @@ class Diaspora {
                $created = datetime_convert("UTC", "UTC", $item["created"], 'Y-m-d\TH:i:s\Z');
 
                // Detect a share element and do a reshare
-               if (!$item['private'] AND ($ret = self::is_reshare($item["body"]))) {
-                       $message = array("root_diaspora_id" => $ret["root_handle"],
-                                       "root_guid" => $ret["root_guid"],
+               if (!$item['private'] && ($ret = self::is_reshare($item["body"]))) {
+                       $message = array("author" => $myaddr,
                                        "guid" => $item["guid"],
-                                       "diaspora_handle" => $myaddr,
-                                       "public" => $public,
                                        "created_at" => $created,
-                                       "provider_display_name" => $item["app"]);
+                                       "root_author" => $ret["root_handle"],
+                                       "root_guid" => $ret["root_guid"],
+                                       "provider_display_name" => $item["app"],
+                                       "public" => $public);
 
                        $type = "reshare";
                } else {
@@ -3245,16 +3357,16 @@ class Diaspora {
                                $location["lng"] = $coord[1];
                        }
 
-                       $message = array("raw_message" => $body,
-                                       "location" => $location,
+                       $message = array("author" => $myaddr,
                                        "guid" => $item["guid"],
-                                       "diaspora_handle" => $myaddr,
-                                       "public" => $public,
                                        "created_at" => $created,
-                                       "provider_display_name" => $item["app"]);
+                                       "public" => $public,
+                                       "text" => $body,
+                                       "provider_display_name" => $item["app"],
+                                       "location" => $location);
 
                        // Diaspora rejects messages when they contain a location without "lat" or "lng"
-                       if (!isset($location["lat"]) OR !isset($location["lng"])) {
+                       if (!isset($location["lat"]) || !isset($location["lng"])) {
                                unset($message["location"]);
                        }
 
@@ -3264,7 +3376,7 @@ class Diaspora {
                                        $message['event'] = $event;
 
                                        /// @todo Once Diaspora supports it, we will remove the body
-                                       // $message['raw_message'] = '';
+                                       // $message['text'] = '';
                                }
                        }
 
@@ -3319,12 +3431,12 @@ class Diaspora {
                        $positive = "false";
                }
 
-               return(array("positive" => $positive,
+               return(array("author" => self::my_handle($owner),
                                "guid" => $item["guid"],
-                               "target_type" => $target_type,
                                "parent_guid" => $parent["guid"],
-                               "author_signature" => "",
-                               "diaspora_handle" => self::my_handle($owner)));
+                               "parent_type" => $target_type,
+                               "positive" => $positive,
+                               "author_signature" => ""));
        }
 
        /**
@@ -3396,12 +3508,12 @@ class Diaspora {
                $text = html_entity_decode(bb2diaspora($item["body"]));
                $created = datetime_convert("UTC", "UTC", $item["created"], 'Y-m-d\TH:i:s\Z');
 
-               $comment = array("guid" => $item["guid"],
+               $comment = array("author" => self::my_handle($owner),
+                               "guid" => $item["guid"],
+                               "created_at" => $created,
                                "parent_guid" => $parent["guid"],
-                               "author_signature" => "",
                                "text" => $text,
-                               /// @todo Currently disabled until Diaspora supports it: "created_at" => $created,
-                               "diaspora_handle" => self::my_handle($owner));
+                               "author_signature" => "");
 
                // Send the thread parent guid only if it is a threaded comment
                if ($item['thr-parent'] != $item['parent-uri']) {
@@ -3457,21 +3569,19 @@ class Diaspora {
                // Split the signed text
                $signed_parts = explode(";", $signature['signed_text']);
 
-               if ($item["deleted"])
-                       $message = array("parent_author_signature" => "",
+               if ($item["deleted"]) {
+                       $message = array("author" => $signature['signer'],
                                        "target_guid" => $signed_parts[0],
-                                       "target_type" => $signed_parts[1],
-                                       "sender_handle" => $signature['signer'],
-                                       "target_author_signature" => $signature['signature']);
-               elseif ($item['verb'] === ACTIVITY_LIKE)
-                       $message = array("positive" => $signed_parts[0],
+                                       "target_type" => $signed_parts[1]);
+               } elseif (in_array($item["verb"], array(ACTIVITY_LIKE, ACTIVITY_DISLIKE))) {
+                       $message = array("author" => $signed_parts[4],
                                        "guid" => $signed_parts[1],
-                                       "target_type" => $signed_parts[2],
                                        "parent_guid" => $signed_parts[3],
-                                       "parent_author_signature" => "",
+                                       "parent_type" => $signed_parts[2],
+                                       "positive" => $signed_parts[0],
                                        "author_signature" => $signature['signature'],
-                                       "diaspora_handle" => $signed_parts[4]);
-               else {
+                                       "parent_author_signature" => "");
+               else {
                        // Remove the comment guid
                        $guid = array_shift($signed_parts);
 
@@ -3484,12 +3594,12 @@ class Diaspora {
                        // Glue the parts together
                        $text = implode(";", $signed_parts);
 
-                       $message = array("guid" => $guid,
+                       $message = array("author" => $handle,
+                                       "guid" => $guid,
                                        "parent_guid" => $parent_guid,
-                                       "parent_author_signature" => "",
-                                       "author_signature" => $signature['signature'],
                                        "text" => implode(";", $signed_parts),
-                                       "diaspora_handle" => $handle);
+                                       "author_signature" => $signature['signature'],
+                                       "parent_author_signature" => "");
                }
                return $message;
        }
@@ -3506,12 +3616,13 @@ class Diaspora {
         */
        public static function send_relay($item, $owner, $contact, $public_batch = false) {
 
-               if ($item["deleted"])
+               if ($item["deleted"]) {
                        return self::send_retraction($item, $owner, $contact, $public_batch, true);
-               elseif ($item['verb'] === ACTIVITY_LIKE)
+               } elseif (in_array($item["verb"], array(ACTIVITY_LIKE, ACTIVITY_DISLIKE))) {
                        $type = "like";
-               else
+               } else {
                        $type = "comment";
+               }
 
                logger("Got relayable data ".$type." for item ".$item["guid"]." (".$item["id"].")", LOGGER_DEBUG);
 
@@ -3529,7 +3640,7 @@ class Diaspora {
 
                // Old way - is used by the internal Friendica functions
                /// @todo Change all signatur storing functions to the new format
-               if ($signature['signed_text'] AND $signature['signature'] AND $signature['signer'])
+               if ($signature['signed_text'] && $signature['signature'] && $signature['signer'])
                        $message = self::message_from_signature($item, $signature);
                else {// New way
                        $msg = json_decode($signature['signed_text'], true);
@@ -3538,10 +3649,12 @@ class Diaspora {
                        if (is_array($msg)) {
                                foreach ($msg AS $field => $data) {
                                        if (!$item["deleted"]) {
-                                               if ($field == "author")
-                                                       $field = "diaspora_handle";
-                                               if ($field == "parent_type")
-                                                       $field = "target_type";
+                                               if ($field == "diaspora_handle") {
+                                                       $field = "author";
+                                               }
+                                               if ($field == "target_type") {
+                                                       $field = "parent_type";
+                                               }
                                        }
 
                                        $message[$field] = $data;
@@ -3572,26 +3685,19 @@ class Diaspora {
 
                $itemaddr = self::handle_from_contact($item["contact-id"], $item["gcontact-id"]);
 
-               // Check whether the retraction is for a top-level post or whether it's a relayable
-               if ($item["uri"] !== $item["parent-uri"]) {
-                       $msg_type = "relayable_retraction";
-                       $target_type = (($item["verb"] === ACTIVITY_LIKE) ? "Like" : "Comment");
+               $msg_type = "retraction";
+
+               if ($item['id'] == $item['parent']) {
+                       $target_type = "Post";
+               } elseif (in_array($item["verb"], array(ACTIVITY_LIKE, ACTIVITY_DISLIKE))) {
+                       $target_type = "Like";
                } else {
-                       $msg_type = "signed_retraction";
-                       $target_type = "StatusMessage";
+                       $target_type = "Comment";
                }
 
-               if ($relay AND ($item["uri"] !== $item["parent-uri"]))
-                       $signature = "parent_author_signature";
-               else
-                       $signature = "target_author_signature";
-
-               $signed_text = $item["guid"].";".$target_type;
-
-               $message = array("target_guid" => $item['guid'],
-                               "target_type" => $target_type,
-                               "sender_handle" => $itemaddr,
-                               $signature => base64_encode(rsa_sign($signed_text,$owner['uprvkey'],'sha256')));
+               $message = array("author" => $itemaddr,
+                               "target_guid" => $item['guid'],
+                               "target_type" => $target_type);
 
                logger("Got message ".print_r($message, true), LOGGER_DEBUG);
 
@@ -3623,40 +3729,35 @@ class Diaspora {
                $cnv = $r[0];
 
                $conv = array(
+                       "author" => $cnv["creator"],
                        "guid" => $cnv["guid"],
                        "subject" => $cnv["subject"],
                        "created_at" => datetime_convert("UTC", "UTC", $cnv['created'], 'Y-m-d\TH:i:s\Z'),
-                       "diaspora_handle" => $cnv["creator"],
-                       "participant_handles" => $cnv["recips"]
+                       "participants" => $cnv["recips"]
                );
 
                $body = bb2diaspora($item["body"]);
                $created = datetime_convert("UTC", "UTC", $item["created"], 'Y-m-d\TH:i:s\Z');
 
-               $signed_text = $item["guid"].";".$cnv["guid"].";".$body.";".$created.";".$myaddr.";".$cnv['guid'];
-               $sig = base64_encode(rsa_sign($signed_text, $owner["uprvkey"], "sha256"));
-
                $msg = array(
+                       "author" => $myaddr,
                        "guid" => $item["guid"],
-                       "parent_guid" => $cnv["guid"],
-                       "parent_author_signature" => $sig,
-                       "author_signature" => $sig,
+                       "conversation_guid" => $cnv["guid"],
                        "text" => $body,
                        "created_at" => $created,
-                       "diaspora_handle" => $myaddr,
-                       "conversation_guid" => $cnv["guid"]
                );
 
                if ($item["reply"]) {
                        $message = $msg;
                        $type = "message";
                } else {
-                       $message = array("guid" => $cnv["guid"],
+                       $message = array(
+                                       "author" => $cnv["creator"],
+                                       "guid" => $cnv["guid"],
                                        "subject" => $cnv["subject"],
                                        "created_at" => datetime_convert("UTC", "UTC", $cnv['created'], 'Y-m-d\TH:i:s\Z'),
-                                       "message" => $msg,
-                                       "diaspora_handle" => $cnv["creator"],
-                                       "participant_handles" => $cnv["recips"]);
+                                       "participants" => $cnv["recips"],
+                                       "message" => $msg);
 
                        $type = "conversation";
                }
@@ -3665,25 +3766,13 @@ class Diaspora {
        }
 
        /**
-        * @brief Sends profile data
+        * @brief Create profile data
         *
         * @param int $uid The user id
+        *
+        * @return array The profile data
         */
-       public static function send_profile($uid, $recips = false) {
-
-               if (!$uid)
-                       return;
-
-               if (!$recips)
-                       $recips = q("SELECT `id`,`name`,`network`,`pubkey`,`notify` FROM `contact` WHERE `network` = '%s'
-                               AND `uid` = %d AND `rel` != %d",
-                               dbesc(NETWORK_DIASPORA),
-                               intval($uid),
-                               intval(CONTACT_IS_SHARING)
-                       );
-               if (!$recips)
-                       return;
-
+       private static function createProfileData($uid) {
                $r = q("SELECT `profile`.`uid` AS `profile_uid`, `profile`.* , `user`.*, `user`.`prvkey` AS `uprvkey`, `contact`.`addr`
                        FROM `profile`
                        INNER JOIN `user` ON `profile`.`uid` = `user`.`uid`
@@ -3692,8 +3781,9 @@ class Diaspora {
                        intval($uid)
                );
 
-               if (!$r)
-                       return;
+               if (!$r) {
+                       return array();
+               }
 
                $profile = $r[0];
 
@@ -3701,9 +3791,9 @@ class Diaspora {
                $first = ((strpos($profile['name'],' ')
                        ? trim(substr($profile['name'],0,strpos($profile['name'],' '))) : $profile['name']));
                $last = (($first === $profile['name']) ? '' : trim(substr($profile['name'], strlen($first))));
-               $large = App::get_baseurl().'/photo/custom/300/'.$profile['uid'].'.jpg';
-               $medium = App::get_baseurl().'/photo/custom/100/'.$profile['uid'].'.jpg';
-               $small = App::get_baseurl().'/photo/custom/50/'  .$profile['uid'].'.jpg';
+               $large = System::baseUrl().'/photo/custom/300/'.$profile['uid'].'.jpg';
+               $medium = System::baseUrl().'/photo/custom/100/'.$profile['uid'].'.jpg';
+               $small = System::baseUrl().'/photo/custom/50/'  .$profile['uid'].'.jpg';
                $searchable = (($profile['publish'] && $profile['net-publish']) ? 'true' : 'false');
 
                if ($searchable === 'true') {
@@ -3731,7 +3821,7 @@ class Diaspora {
                        $tags = trim($tags);
                }
 
-               $message = array("diaspora_handle" => $handle,
+               return array("author" => $handle,
                                "first_name" => $first,
                                "last_name" => $last,
                                "image_url" => $large,
@@ -3742,7 +3832,31 @@ class Diaspora {
                                "bio" => $about,
                                "location" => $location,
                                "searchable" => $searchable,
+                               "nsfw" => "false",
                                "tag_string" => $tags);
+       }
+
+       /**
+        * @brief Sends profile data
+        *
+        * @param int $uid The user id
+        */
+       public static function send_profile($uid, $recips = false) {
+
+               if (!$uid)
+                       return;
+
+               if (!$recips)
+                       $recips = q("SELECT `id`,`name`,`network`,`pubkey`,`notify` FROM `contact` WHERE `network` = '%s'
+                               AND `uid` = %d AND `rel` != %d",
+                               dbesc(NETWORK_DIASPORA),
+                               intval($uid),
+                               intval(CONTACT_IS_SHARING)
+                       );
+               if (!$recips)
+                       return;
+
+               $message = self::createProfileData($uid);
 
                foreach ($recips as $recip) {
                        logger("Send updated profile data for user ".$uid." to contact ".$recip["id"], LOGGER_DEBUG);
@@ -3761,7 +3875,7 @@ class Diaspora {
        public static function store_like_signature($contact, $post_id) {
 
                // Is the contact the owner? Then fetch the private key
-               if (!$contact['self'] OR ($contact['uid'] == 0)) {
+               if (!$contact['self'] || ($contact['uid'] == 0)) {
                        logger("No owner post, so not storing signature", LOGGER_DEBUG);
                        return false;
                }
@@ -3789,10 +3903,7 @@ class Diaspora {
                 * Now store the signature more flexible to dynamically support new fields.
                 * This will break Diaspora compatibility with Friendica versions prior to 3.5.
                 */
-               q("INSERT INTO `sign` (`iid`,`signed_text`) VALUES (%d,'%s')",
-                       intval($message_id),
-                       dbesc(json_encode($message))
-               );
+               dba::insert('sign', array('iid' => $post_id, 'signed_text' => json_encode($message)));
 
                logger('Stored diaspora like signature');
                return true;
@@ -3824,10 +3935,7 @@ class Diaspora {
                 * Now store the signature more flexible to dynamically support new fields.
                 * This will break Diaspora compatibility with Friendica versions prior to 3.5.
                 */
-               q("INSERT INTO `sign` (`iid`, `signed_text`) VALUES (%d, '%s')",
-                       intval($message_id),
-                       dbesc(json_encode($message))
-               );
+               dba::insert('sign', array('iid' => $message_id, 'signed_text' => json_encode($message)));
 
                logger('Stored diaspora comment signature');
                return true;