]> git.mxchange.org Git - friendica.git/blobdiff - include/diaspora.php
fixed parser error, need parentheses
[friendica.git] / include / diaspora.php
index 841ba7e7ff15c647ba1929dd77f3492af8f81a4c..820f8bd8967d73ed997653e2c1a0aff1e8368f5e 100644 (file)
@@ -8,19 +8,20 @@
  * This will change in the future.
  */
 
-use \Friendica\Core\Config;
-
-require_once("include/items.php");
-require_once("include/bb2diaspora.php");
-require_once("include/Scrape.php");
-require_once("include/Contact.php");
-require_once("include/Photo.php");
-require_once("include/socgraph.php");
-require_once("include/group.php");
-require_once("include/xml.php");
-require_once("include/datetime.php");
-require_once("include/queue_fn.php");
-require_once("include/cache.php");
+use Friendica\App;
+use Friendica\Core\Config;
+
+require_once 'include/items.php';
+require_once 'include/bb2diaspora.php';
+require_once 'include/probe.php';
+require_once 'include/Contact.php';
+require_once 'include/Photo.php';
+require_once 'include/socgraph.php';
+require_once 'include/group.php';
+require_once 'include/xml.php';
+require_once 'include/datetime.php';
+require_once 'include/queue_fn.php';
+require_once 'include/cache.php';
 
 /**
  * @brief This class contain functions to create and send Diaspora XML files
@@ -45,7 +46,7 @@ class Diaspora {
 
                $servers = explode(",", $serverdata);
 
-               foreach($servers AS $server) {
+               foreach ($servers AS $server) {
                        $server = trim($server);
                        $addr = "relay@".str_replace("http://", "", normalise_link($server));
                        $batch = $server."/receive/public";
@@ -161,7 +162,106 @@ class Diaspora {
        }
 
        /**
-        * @brief: Decodes incoming Diaspora message
+        * @brief encrypts data via AES
+        *
+        * @param string $key The AES key
+        * @param string $iv The IV (is used for CBC encoding)
+        * @param string $data The data that is to be encrypted
+        *
+        * @return string encrypted data
+        */
+       private static function aes_encrypt($key, $iv, $data) {
+               return openssl_encrypt($data, 'aes-256-cbc', str_pad($key, 32, "\0"), OPENSSL_RAW_DATA, str_pad($iv, 16, "\0"));
+       }
+
+       /**
+        * @brief decrypts data via AES
+        *
+        * @param string $key The AES key
+        * @param string $iv The IV (is used for CBC encoding)
+        * @param string $encrypted The encrypted data
+        *
+        * @return string decrypted data
+        */
+       private static function aes_decrypt($key, $iv, $encrypted) {
+               return openssl_decrypt($encrypted,'aes-256-cbc', str_pad($key, 32, "\0"), OPENSSL_RAW_DATA,str_pad($iv, 16, "\0"));
+       }
+
+       /**
+        * @brief: Decodes incoming Diaspora message in the new format
+        *
+        * @param array $importer Array of the importer user
+        * @param string $raw raw post message
+        *
+        * @return array
+        * 'message' -> decoded Diaspora XML message
+        * 'author' -> author diaspora handle
+        * 'key' -> author public key (converted to pkcs#8)
+        */
+       public static function decode_raw($importer, $raw) {
+               $data = json_decode($raw);
+
+               // Is it a private post? Then decrypt the outer Salmon
+               if (is_object($data)) {
+                       $encrypted_aes_key_bundle = base64_decode($data->aes_key);
+                       $ciphertext = base64_decode($data->encrypted_magic_envelope);
+
+                       $outer_key_bundle = '';
+                       @openssl_private_decrypt($encrypted_aes_key_bundle, $outer_key_bundle, $importer['prvkey']);
+                       $j_outer_key_bundle = json_decode($outer_key_bundle);
+
+                       if (!is_object($j_outer_key_bundle)) {
+                               logger('Outer Salmon did not verify. Discarding.');
+                               http_status_exit(400);
+                       }
+
+                       $outer_iv = base64_decode($j_outer_key_bundle->iv);
+                       $outer_key = base64_decode($j_outer_key_bundle->key);
+
+                       $xml = diaspora::aes_decrypt($outer_key, $outer_iv, $ciphertext);
+               } else {
+                       $xml = $raw;
+               }
+
+               $basedom = parse_xml_string($xml);
+
+               if (!is_object($basedom)) {
+                       logger('Received data does not seem to be an XML. Discarding.');
+                       http_status_exit(400);
+               }
+
+               $base = $basedom->children(NAMESPACE_SALMON_ME);
+
+               // Not sure if this cleaning is needed
+               $data = str_replace(array(" ", "\t", "\r", "\n"), array("", "", "", ""), $base->data);
+
+               // Build the signed data
+               $type = $base->data[0]->attributes()->type[0];
+               $encoding = $base->encoding;
+               $alg = $base->alg;
+               $signed_data = $data.'.'.base64url_encode($type).'.'.base64url_encode($encoding).'.'.base64url_encode($alg);
+
+               // This is the signature
+               $signature = base64url_decode($base->sig);
+
+               // Get the senders' public key
+               $key_id = $base->sig[0]->attributes()->key_id[0];
+               $author_addr = base64_decode($key_id);
+               $key = diaspora::key($author_addr);
+
+               $verify = rsa_verify($signed_data, $signature, $key);
+               if (!$verify) {
+                       logger('Message did not verify. Discarding.');
+                       http_status_exit(400);
+               }
+
+               return array('message' => (string)base64url_decode($base->data),
+                               'author' => unxmlify($author_addr),
+                               'key' => (string)$key);
+       }
+
+       /**
+        * @brief: Decodes incoming Diaspora message in the deprecated format
         *
         * @param array $importer Array of the importer user
         * @param string $xml urldecoded Diaspora salmon
@@ -176,12 +276,13 @@ class Diaspora {
                $public = false;
                $basedom = parse_xml_string($xml);
 
-               if (!is_object($basedom))
+               if (!is_object($basedom)) {
+                       logger("XML is not parseable.");
                        return false;
-
+               }
                $children = $basedom->children('https://joindiaspora.com/protocol');
 
-               if($children->header) {
+               if ($children->header) {
                        $public = true;
                        $author_link = str_replace('acct:','',$children->header->author_id);
                } else {
@@ -199,10 +300,7 @@ class Diaspora {
                        $outer_iv = base64_decode($j_outer_key_bundle->iv);
                        $outer_key = base64_decode($j_outer_key_bundle->key);
 
-                       $decrypted = mcrypt_decrypt(MCRYPT_RIJNDAEL_128, $outer_key, $ciphertext, MCRYPT_MODE_CBC, $outer_iv);
-
-
-                       $decrypted = pkcs5_unpad($decrypted);
+                       $decrypted = self::aes_decrypt($outer_key, $outer_iv, $ciphertext);
 
                        logger('decrypted: '.$decrypted, LOGGER_DEBUG);
                        $idom = parse_xml_string($decrypted,false);
@@ -217,11 +315,11 @@ class Diaspora {
 
                // figure out where in the DOM tree our data is hiding
 
-               if($dom->provenance->data)
+               if ($dom->provenance->data)
                        $base = $dom->provenance;
-               elseif($dom->env->data)
+               elseif ($dom->env->data)
                        $base = $dom->env;
-               elseif($dom->data)
+               elseif ($dom->data)
                        $base = $dom;
 
                if (!$base) {
@@ -254,15 +352,14 @@ class Diaspora {
                $data = base64url_decode($data);
 
 
-               if($public)
+               if ($public)
                        $inner_decrypted = $data;
                else {
 
                        // Decode the encrypted blob
 
                        $inner_encrypted = base64_decode($data);
-                       $inner_decrypted = mcrypt_decrypt(MCRYPT_RIJNDAEL_128, $inner_aes_key, $inner_encrypted, MCRYPT_MODE_CBC, $inner_iv);
-                       $inner_decrypted = pkcs5_unpad($inner_decrypted);
+                       $inner_decrypted = self::aes_decrypt($inner_aes_key, $inner_iv, $inner_encrypted);
                }
 
                if (!$author_link) {
@@ -311,6 +408,24 @@ class Diaspora {
                        return false;
                }
 
+               if (!($postdata = self::valid_posting($msg))) {
+                       logger("Invalid posting");
+                       return false;
+               }
+
+               $fields = $postdata['fields'];
+
+               // Is it a an action (comment, like, ...) for our own post?
+               if (isset($fields->parent_guid) AND !$postdata["relayed"]) {
+                       $guid = notags(unxmlify($fields->parent_guid));
+                       $importer = self::importer_for_guid($guid);
+                       if (is_array($importer)) {
+                               logger("delivering to origin: ".$importer["name"]);
+                               $message_id = self::dispatch($importer, $msg, $fields);
+                               return $message_id;
+                       }
+               }
+
                // Now distribute it to the followers
                $r = q("SELECT `user`.* FROM `user` WHERE `user`.`uid` IN
                        (SELECT `contact`.`uid` FROM `contact` WHERE `contact`.`network` = '%s' AND `contact`.`addr` = '%s')
@@ -322,18 +437,14 @@ class Diaspora {
                if (dbm::is_result($r)) {
                        foreach ($r as $rr) {
                                logger("delivering to: ".$rr["username"]);
-                               self::dispatch($rr,$msg);
+                               self::dispatch($rr, $msg, $fields);
                        }
+               } elseif (!Config::get('system', 'relay_subscribe', false)) {
+                       logger("Unwanted message from ".$msg["author"]." send by ".$_SERVER["REMOTE_ADDR"]." with ".$_SERVER["HTTP_USER_AGENT"].": ".print_r($msg, true), LOGGER_DEBUG);
                } else {
-                       $social_relay = (bool)Config::get('system', 'relay_subscribe', false);
-
                        // Use a dummy importer to import the data for the public copy
-                       if ($social_relay) {
-                               $importer = array("uid" => 0, "page-flags" => PAGE_FREELOVE);
-                               $message_id = self::dispatch($importer,$msg);
-                       } else {
-                               logger("Unwanted message from ".$msg["author"]." send by ".$_SERVER["REMOTE_ADDR"]." with ".$_SERVER["HTTP_USER_AGENT"].": ".print_r($msg, true), LOGGER_DEBUG);
-                       }
+                       $importer = array("uid" => 0, "page-flags" => PAGE_FREELOVE);
+                       $message_id = self::dispatch($importer, $msg, $fields);
                }
 
                return $message_id;
@@ -344,18 +455,23 @@ class Diaspora {
         *
         * @param array $importer Array of the importer user
         * @param array $msg The post that will be dispatched
+        * @param object $fields SimpleXML object that contains the message
         *
         * @return int The message id of the generated message, "true" or "false" if there was an error
         */
-       public static function dispatch($importer, $msg) {
+       public static function dispatch($importer, $msg, $fields = null) {
 
                // The sender is the handle of the contact that sent the message.
                // This will often be different with relayed messages (for example "like" and "comment")
                $sender = $msg["author"];
 
-               if (!self::valid_posting($msg, $fields)) {
-                       logger("Invalid posting");
-                       return false;
+               // This is only needed for private postings since this is already done for public ones before
+               if (is_null($fields)) {
+                       if (!($postdata = self::valid_posting($msg))) {
+                               logger("Invalid posting");
+                               return false;
+                       }
+                       $fields = $postdata['fields'];
                }
 
                $type = $fields->getName();
@@ -417,11 +533,10 @@ class Diaspora {
         * It also does the conversion between the old and the new diaspora format.
         *
         * @param array $msg Array with the XML, the sender handle and the sender signature
-        * @param object $fields SimpleXML object that contains the posting when it is valid
         *
-        * @return bool Is the posting valid?
+        * @return bool|array If the posting is valid then an array with an SimpleXML object is returned
         */
-       private static function valid_posting($msg, &$fields) {
+       private static function valid_posting($msg) {
 
                $data = parse_xml_string($msg["message"], false);
 
@@ -462,32 +577,38 @@ class Diaspora {
                foreach ($element->children() AS $fieldname => $entry) {
                        if ($oldXML) {
                                // Translation for the old XML structure
-                               if ($fieldname == "diaspora_handle")
+                               if ($fieldname == "diaspora_handle") {
                                        $fieldname = "author";
-
-                               if ($fieldname == "participant_handles")
+                               }
+                               if ($fieldname == "participant_handles") {
                                        $fieldname = "participants";
-
+                               }
                                if (in_array($type, array("like", "participation"))) {
-                                       if ($fieldname == "target_type")
+                                       if ($fieldname == "target_type") {
                                                $fieldname = "parent_type";
+                                       }
                                }
-
-                               if ($fieldname == "sender_handle")
+                               if ($fieldname == "sender_handle") {
                                        $fieldname = "author";
-
-                               if ($fieldname == "recipient_handle")
+                               }
+                               if ($fieldname == "recipient_handle") {
                                        $fieldname = "recipient";
-
-                               if ($fieldname == "root_diaspora_id")
+                               }
+                               if ($fieldname == "root_diaspora_id") {
                                        $fieldname = "root_author";
-
+                               }
+                               if ($type == "status_message") {
+                                       if ($fieldname == "raw_message") {
+                                               $fieldname = "text";
+                                       }
+                               }
                                if ($type == "retraction") {
-                                       if ($fieldname == "post_guid")
+                                       if ($fieldname == "post_guid") {
                                                $fieldname = "target_guid";
-
-                                       if ($fieldname == "type")
+                                       }
+                                       if ($fieldname == "type") {
                                                $fieldname = "target_type";
+                                       }
                                }
                        }
 
@@ -516,9 +637,9 @@ class Diaspora {
                        }
 
                // Only some message types have signatures. So we quit here for the other types.
-               if (!in_array($type, array("comment", "message", "like")))
-                       return true;
-
+               if (!in_array($type, array("comment", "like"))) {
+                       return array("fields" => $fields, "relayed" => false);
+               }
                // No author_signature? This is a must, so we quit.
                if (!isset($author_signature)) {
                        logger("No author signature for type ".$type." - Message: ".$msg["message"], LOGGER_DEBUG);
@@ -526,12 +647,16 @@ class Diaspora {
                }
 
                if (isset($parent_author_signature)) {
+                       $relayed = true;
+
                        $key = self::key($msg["author"]);
 
                        if (!rsa_verify($signed_data, $parent_author_signature, $key, "sha256")) {
                                logger("No valid parent author signature for parent author ".$msg["author"]. " in type ".$type." - signed data: ".$signed_data." - Message: ".$msg["message"]." - Signature ".$parent_author_signature, LOGGER_DEBUG);
                                return false;
                        }
+               } else {
+                       $relayed = false;
                }
 
                $key = self::key($fields->author);
@@ -539,8 +664,9 @@ class Diaspora {
                if (!rsa_verify($signed_data, $author_signature, $key, "sha256")) {
                        logger("No valid author signature for author ".$fields->author. " in type ".$type." - signed data: ".$signed_data." - Message: ".$msg["message"]." - Signature ".$author_signature, LOGGER_DEBUG);
                        return false;
-               } else
-                       return true;
+               } else {
+                       return array("fields" => $fields, "relayed" => $relayed);
+               }
        }
 
        /**
@@ -556,7 +682,7 @@ class Diaspora {
                logger("Fetching diaspora key for: ".$handle);
 
                $r = self::person_by_handle($handle);
-               if($r)
+               if ($r)
                        return $r["pubkey"];
 
                return "";
@@ -569,7 +695,7 @@ class Diaspora {
         *
         * @return array the queried data
         */
-       private static function person_by_handle($handle) {
+       public static function person_by_handle($handle) {
 
                $r = q("SELECT * FROM `fcontact` WHERE `network` = '%s' AND `addr` = '%s' LIMIT 1",
                        dbesc(NETWORK_DIASPORA),
@@ -612,7 +738,7 @@ class Diaspora {
         */
        private static function add_fcontact($arr, $update = false) {
 
-               if($update) {
+               if ($update) {
                        $r = q("UPDATE `fcontact` SET
                                        `name` = '%s',
                                        `photo` = '%s',
@@ -796,7 +922,7 @@ class Diaspora {
                // perhaps we were already sharing with this person. Now they're sharing with us.
                // That makes us friends.
                // Normally this should have handled by getting a request - but this could get lost
-               if($contact["rel"] == CONTACT_IS_FOLLOWER && in_array($importer["page-flags"], array(PAGE_FREELOVE))) {
+               if ($contact["rel"] == CONTACT_IS_FOLLOWER && in_array($importer["page-flags"], array(PAGE_FREELOVE))) {
                        q("UPDATE `contact` SET `rel` = %d, `writable` = 1 WHERE `id` = %d AND `uid` = %d",
                                intval(CONTACT_IS_FRIEND),
                                intval($contact["id"]),
@@ -806,17 +932,20 @@ class Diaspora {
                        logger("defining user ".$contact["nick"]." as friend");
                }
 
-               if(($contact["blocked"]) || ($contact["readonly"]) || ($contact["archive"]))
+               // We don't seem to like that person
+               if ($contact["blocked"] || $contact["readonly"] || $contact["archive"]) {
                        return false;
-               if($contact["rel"] == CONTACT_IS_SHARING || $contact["rel"] == CONTACT_IS_FRIEND)
+               // We are following this person? Then it is okay
+               } elseif (($contact["rel"] == CONTACT_IS_SHARING) || ($contact["rel"] == CONTACT_IS_FRIEND)) {
                        return true;
-               if($contact["rel"] == CONTACT_IS_FOLLOWER)
-                       if(($importer["page-flags"] == PAGE_COMMUNITY) OR $is_comment)
-                               return true;
-
-               // Messages for the global users are always accepted
-               if ($importer["uid"] == 0)
+               // Is it a post to a community? That's good
+               } elseif (($contact["rel"] == CONTACT_IS_FOLLOWER) && ($importer["page-flags"] == PAGE_COMMUNITY)) {
+                       return true;
+               }
+               // Messages for the global users and comments are always accepted
+               if (($importer["uid"] == 0) || $is_comment) {
                        return true;
+               }
 
                return false;
        }
@@ -834,7 +963,12 @@ class Diaspora {
                $contact = self::contact_by_handle($importer["uid"], $handle);
                if (!$contact) {
                        logger("A Contact for handle ".$handle." and user ".$importer["uid"]." was not found");
-                       return false;
+                       // If a contact isn't found, we accept it anyway if it is a comment
+                       if ($is_comment) {
+                               return $importer;
+                       } else {
+                               return false;
+                       }
                }
 
                if (!self::post_allow($importer, $contact, $is_comment)) {
@@ -969,7 +1103,7 @@ class Diaspora {
                logger("Fetch post from ".$source_url, LOGGER_DEBUG);
 
                $envelope = fetch_url($source_url);
-               if($envelope) {
+               if ($envelope) {
                        logger("Envelope was fetched.", LOGGER_DEBUG);
                        $x = self::verify_magic_envelope($envelope);
                        if (!$x)
@@ -985,7 +1119,7 @@ class Diaspora {
                        logger("Fetch post from ".$source_url, LOGGER_DEBUG);
 
                        $x = fetch_url($source_url);
-                       if(!$x)
+                       if (!$x)
                                return false;
                }
 
@@ -1042,7 +1176,7 @@ class Diaspora {
                        FROM `item` WHERE `uid` = %d AND `guid` = '%s' LIMIT 1",
                        intval($uid), dbesc($guid));
 
-               if(!$r) {
+               if (!$r) {
                        $result = self::store_by_guid($guid, $contact["url"], $uid);
 
                        if (!$result) {
@@ -1089,9 +1223,9 @@ class Diaspora {
                        $cid = $r[0]["id"];
                        $network = $r[0]["network"];
 
-                       // We are receiving content from a user that is about to be terminated
+                       // We are receiving content from a user that possibly is about to be terminated
                        // This means the user is vital, so we remove a possible termination date.
-                       unmark_for_death($contact);
+                       unmark_for_death($r[0]);
                } else {
                        $cid = $contact["id"];
                        $network = NETWORK_DIASPORA;
@@ -1205,6 +1339,26 @@ class Diaspora {
                }
        }
 
+       /**
+        * @brief Find the best importer for a comment, like, ...
+        *
+        * @param string $guid The guid of the item
+        *
+        * @return array|boolean the origin owner of that post - or false
+        */
+       private static function importer_for_guid($guid) {
+               $item = dba::fetch_first("SELECT `uid` FROM `item` WHERE `origin` AND `guid` = ? LIMIT 1", $guid);
+
+               if (dbm::is_result($item)) {
+                       logger("Found user ".$item['uid']." as owner of item ".$guid, LOGGER_DEBUG);
+                       $contact = dba::fetch_first("SELECT * FROM `contact` WHERE `self` AND `uid` = ?", $item['uid']);
+                       if (dbm::is_result($contact)) {
+                               return $contact;
+                       }
+               }
+               return false;
+       }
+
        /**
         * @brief Processes an incoming comment
         *
@@ -1216,10 +1370,10 @@ class Diaspora {
         * @return int The message id of the generated comment or "false" if there was an error
         */
        private static function receive_comment($importer, $sender, $data, $xml) {
+               $author = notags(unxmlify($data->author));
                $guid = notags(unxmlify($data->guid));
                $parent_guid = notags(unxmlify($data->parent_guid));
                $text = unxmlify($data->text);
-               $author = notags(unxmlify($data->author));
 
                if (isset($data->created_at)) {
                        $created_at = datetime_convert("UTC", "UTC", notags(unxmlify($data->created_at)));
@@ -1286,7 +1440,9 @@ class Diaspora {
                }
 
                $datarray["object-type"] = ACTIVITY_OBJ_COMMENT;
-               $datarray["object"] = $xml;
+
+               $datarray["protocol"] = PROTOCOL_DIASPORA;
+               $datarray["source"] = $xml;
 
                $datarray["changed"] = $datarray["created"] = $datarray["edited"] = $created_at;
 
@@ -1303,7 +1459,7 @@ class Diaspora {
                }
 
                // If we are the origin of the parent we store the original data and notify our followers
-               if($message_id AND $parent_item["origin"]) {
+               if ($message_id AND $parent_item["origin"]) {
 
                        // Formerly we stored the signed text, the signature and the author in different fields.
                        // We now store the raw data so that we are more flexible.
@@ -1332,16 +1488,9 @@ class Diaspora {
         * @return bool "true" if it was successful
         */
        private static function receive_conversation_message($importer, $contact, $data, $msg, $mesg, $conversation) {
+               $author = notags(unxmlify($data->author));
                $guid = notags(unxmlify($data->guid));
                $subject = notags(unxmlify($data->subject));
-               $author = notags(unxmlify($data->author));
-
-               $msg_guid = notags(unxmlify($mesg->guid));
-               $msg_parent_guid = notags(unxmlify($mesg->parent_guid));
-               $msg_parent_author_signature = notags(unxmlify($mesg->parent_author_signature));
-               $msg_author_signature = notags(unxmlify($mesg->author_signature));
-               $msg_text = unxmlify($mesg->text);
-               $msg_created_at = datetime_convert("UTC", "UTC", notags(unxmlify($mesg->created_at)));
 
                // "diaspora_handle" is the element name from the old version
                // "author" is the element name from the new version
@@ -1353,7 +1502,10 @@ class Diaspora {
                        return false;
                }
 
+               $msg_guid = notags(unxmlify($mesg->guid));
                $msg_conversation_guid = notags(unxmlify($mesg->conversation_guid));
+               $msg_text = unxmlify($mesg->text);
+               $msg_created_at = datetime_convert("UTC", "UTC", notags(unxmlify($mesg->created_at)));
 
                if ($msg_conversation_guid != $guid) {
                        logger("message conversation guid does not belong to the current conversation.");
@@ -1363,44 +1515,11 @@ class Diaspora {
                $body = diaspora2bb($msg_text);
                $message_uri = $msg_author.":".$msg_guid;
 
-               $author_signed_data = $msg_guid.";".$msg_parent_guid.";".$msg_text.";".unxmlify($mesg->created_at).";".$msg_author.";".$msg_conversation_guid;
-
-               $author_signature = base64_decode($msg_author_signature);
-
-               if (strcasecmp($msg_author,$msg["author"]) == 0) {
-                       $person = $contact;
-                       $key = $msg["key"];
-               } else {
-                       $person = self::person_by_handle($msg_author);
-
-                       if (is_array($person) && x($person, "pubkey")) {
-                               $key = $person["pubkey"];
-                       } else {
-                               logger("unable to find author details");
-                                       return false;
-                       }
-               }
-
-               if (!rsa_verify($author_signed_data, $author_signature, $key, "sha256")) {
-                       logger("verification failed.");
-                       return false;
-               }
-
-               if ($msg_parent_author_signature) {
-                       $owner_signed_data = $msg_guid.";".$msg_parent_guid.";".$msg_text.";".unxmlify($mesg->created_at).";".$msg_author.";".$msg_conversation_guid;
+               $person = self::person_by_handle($msg_author);
 
-                       $parent_author_signature = base64_decode($msg_parent_author_signature);
-
-                       $key = $msg["key"];
-
-                       if (!rsa_verify($owner_signed_data, $parent_author_signature, $key, "sha256")) {
-                               logger("owner verification failed.");
-                               return false;
-                       }
-               }
-
-               $r = q("SELECT `id` FROM `mail` WHERE `uri` = '%s' LIMIT 1",
-                       dbesc($message_uri)
+               $r = q("SELECT `id` FROM `mail` WHERE `guid` = '%s' AND `uid` = %d LIMIT 1",
+                       dbesc($msg_guid),
+                       intval($importer["uid"])
                );
                if (dbm::is_result($r)) {
                        logger("duplicate message already delivered.", LOGGER_DEBUG);
@@ -1457,10 +1576,10 @@ class Diaspora {
         * @return bool Success
         */
        private static function receive_conversation($importer, $msg, $data) {
+               $author = notags(unxmlify($data->author));
                $guid = notags(unxmlify($data->guid));
                $subject = notags(unxmlify($data->subject));
                $created_at = datetime_convert("UTC", "UTC", notags(unxmlify($data->created_at)));
-               $author = notags(unxmlify($data->author));
                $participants = notags(unxmlify($data->participants));
 
                $messages = $data->message;
@@ -1480,7 +1599,7 @@ class Diaspora {
                        intval($importer["uid"]),
                        dbesc($guid)
                );
-               if($c)
+               if ($c)
                        $conversation = $c[0];
                else {
                        $r = q("INSERT INTO `conv` (`uid`, `guid`, `creator`, `created`, `updated`, `subject`, `recips`)
@@ -1493,13 +1612,13 @@ class Diaspora {
                                dbesc($subject),
                                dbesc($participants)
                        );
-                       if($r)
+                       if ($r)
                                $c = q("SELECT * FROM `conv` WHERE `uid` = %d AND `guid` = '%s' LIMIT 1",
                                        intval($importer["uid"]),
                                        dbesc($guid)
                                );
 
-                       if($c)
+                       if ($c)
                                $conversation = $c[0];
                }
                if (!$conversation) {
@@ -1507,7 +1626,7 @@ class Diaspora {
                        return;
                }
 
-               foreach($messages as $mesg)
+               foreach ($messages as $mesg)
                        self::receive_conversation_message($importer, $contact, $data, $msg, $mesg, $conversation);
 
                return true;
@@ -1565,11 +1684,11 @@ class Diaspora {
         * @return int The message id of the generated like or "false" if there was an error
         */
        private static function receive_like($importer, $sender, $data) {
-               $positive = notags(unxmlify($data->positive));
+               $author = notags(unxmlify($data->author));
                $guid = notags(unxmlify($data->guid));
-               $parent_type = notags(unxmlify($data->parent_type));
                $parent_guid = notags(unxmlify($data->parent_guid));
-               $author = notags(unxmlify($data->author));
+               $parent_type = notags(unxmlify($data->parent_type));
+               $positive = notags(unxmlify($data->positive));
 
                // likes on comments aren't supported by Diaspora - only on posts
                // But maybe this will be supported in the future, so we will accept it.
@@ -1606,6 +1725,8 @@ class Diaspora {
 
                $datarray = array();
 
+               $datarray["protocol"] = PROTOCOL_DIASPORA;
+
                $datarray["uid"] = $importer["uid"];
                $datarray["contact-id"] = $author_contact["cid"];
                $datarray["network"]  = $author_contact["network"];
@@ -1637,7 +1758,7 @@ class Diaspora {
                        logger("Stored like ".$datarray["guid"]." with message id ".$message_id, LOGGER_DEBUG);
 
                // If we are the origin of the parent we store the original data and notify our followers
-               if($message_id AND $parent_item["origin"]) {
+               if ($message_id AND $parent_item["origin"]) {
 
                        // Formerly we stored the signed text, the signature and the author in different fields.
                        // We now store the raw data so that we are more flexible.
@@ -1662,12 +1783,11 @@ class Diaspora {
         * @return bool Success?
         */
        private static function receive_message($importer, $data) {
+               $author = notags(unxmlify($data->author));
                $guid = notags(unxmlify($data->guid));
-               $parent_guid = notags(unxmlify($data->parent_guid));
+               $conversation_guid = notags(unxmlify($data->conversation_guid));
                $text = unxmlify($data->text);
                $created_at = datetime_convert("UTC", "UTC", notags(unxmlify($data->created_at)));
-               $author = notags(unxmlify($data->author));
-               $conversation_guid = notags(unxmlify($data->conversation_guid));
 
                $contact = self::allowed_contact_by_handle($importer, $author, true);
                if (!$contact) {
@@ -1695,8 +1815,8 @@ class Diaspora {
                        return false;
                }
 
-               $r = q("SELECT `id` FROM `mail` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
-                       dbesc($message_uri),
+               $r = q("SELECT `id` FROM `mail` WHERE `guid` = '%s' AND `uid` = %d LIMIT 1",
+                       dbesc($guid),
                        intval($importer["uid"])
                );
                if (dbm::is_result($r)) {
@@ -1722,7 +1842,7 @@ class Diaspora {
                        0,
                        1,
                        dbesc($message_uri),
-                       dbesc($author.":".$parent_guid),
+                       dbesc($author.":".$conversation["guid"]),
                        dbesc($created_at)
                );
 
@@ -1791,9 +1911,9 @@ class Diaspora {
                $name = unxmlify($data->first_name).((strlen($data->last_name)) ? " ".unxmlify($data->last_name) : "");
                $image_url = unxmlify($data->image_url);
                $birthday = unxmlify($data->birthday);
-               $location = diaspora2bb(unxmlify($data->location));
-               $about = diaspora2bb(unxmlify($data->bio));
                $gender = unxmlify($data->gender);
+               $about = diaspora2bb(unxmlify($data->bio));
+               $location = diaspora2bb(unxmlify($data->location));
                $searchable = (unxmlify($data->searchable) == "true");
                $nsfw = (unxmlify($data->nsfw) == "true");
                $tags = unxmlify($data->tag_string);
@@ -1812,10 +1932,10 @@ class Diaspora {
                $handle_parts = explode("@", $author);
                $nick = $handle_parts[0];
 
-               if($name === "")
+               if ($name === "")
                        $name = $handle_parts[0];
 
-               if( preg_match("|^https?://|", $image_url) === 0)
+               if ( preg_match("|^https?://|", $image_url) === 0)
                        $image_url = "http://".$handle_parts[1].$image_url;
 
                update_contact_avatar($image_url, $importer["uid"], $contact["id"]);
@@ -1830,7 +1950,7 @@ class Diaspora {
                // this is to prevent multiple birthday notifications in a single year
                // if we already have a stored birthday and the 'm-d' part hasn't changed, preserve the entry, which will preserve the notify year
 
-               if(substr($birthday,5) === substr($contact["bd"],5))
+               if (substr($birthday,5) === substr($contact["bd"],5))
                        $birthday = $contact["bd"];
 
                $r = q("UPDATE `contact` SET `name` = '%s', `nick` = '%s', `addr` = '%s', `name-date` = '%s', `bd` = '%s',
@@ -1873,7 +1993,7 @@ class Diaspora {
 
                $a = get_app();
 
-               if($contact["rel"] == CONTACT_IS_FOLLOWER && in_array($importer["page-flags"], array(PAGE_FREELOVE))) {
+               if ($contact["rel"] == CONTACT_IS_FOLLOWER && in_array($importer["page-flags"], array(PAGE_FREELOVE))) {
                        q("UPDATE `contact` SET `rel` = %d, `writable` = 1 WHERE `id` = %d AND `uid` = %d",
                                intval(CONTACT_IS_FRIEND),
                                intval($contact["id"]),
@@ -1886,7 +2006,7 @@ class Diaspora {
                        intval($importer["uid"])
                );
 
-               if($r && !$r[0]["hide-friends"] && !$contact["hidden"] && intval(get_pconfig($importer["uid"], "system", "post_newfriend"))) {
+               if ($r && !$r[0]["hide-friends"] && !$contact["hidden"] && intval(get_pconfig($importer["uid"], "system", "post_newfriend"))) {
 
                        $self = q("SELECT * FROM `contact` WHERE `self` AND `uid` = %d LIMIT 1",
                                intval($importer["uid"])
@@ -1894,9 +2014,10 @@ class Diaspora {
 
                        // they are not CONTACT_IS_FOLLOWER anymore but that's what we have in the array
 
-                       if($self && $contact["rel"] == CONTACT_IS_FOLLOWER) {
+                       if ($self && $contact["rel"] == CONTACT_IS_FOLLOWER) {
 
                                $arr = array();
+                               $arr["protocol"] = PROTOCOL_DIASPORA;
                                $arr["uri"] = $arr["parent-uri"] = item_new_uri($a->get_hostname(), $importer["uid"]);
                                $arr["uid"] = $importer["uid"];
                                $arr["contact-id"] = $self[0]["id"];
@@ -1925,7 +2046,7 @@ class Diaspora {
                                $arr["deny_gid"]  = $user[0]["deny_gid"];
 
                                $i = item_store($arr);
-                               if($i)
+                               if ($i)
                                        proc_run(PRIORITY_HIGH, "include/notifier.php", "activity", $i);
                        }
                }
@@ -2064,12 +2185,12 @@ class Diaspora {
 
                $def_gid = get_default_group($importer['uid'], $ret["network"]);
 
-               if(intval($def_gid))
+               if (intval($def_gid))
                        group_add_member($importer["uid"], "", $contact_record["id"], $def_gid);
 
                update_contact_avatar($ret["photo"], $importer['uid'], $contact_record["id"], true);
 
-               if($importer["page-flags"] == PAGE_NORMAL) {
+               if ($importer["page-flags"] == PAGE_NORMAL) {
 
                        logger("Sending intra message for author ".$author.".", LOGGER_DEBUG);
 
@@ -2119,7 +2240,7 @@ class Diaspora {
                        );
 
                        $u = q("SELECT * FROM `user` WHERE `uid` = %d LIMIT 1", intval($importer["uid"]));
-                       if($u) {
+                       if ($u) {
                                logger("Sending share message (Relation: ".$new_relation.") to author ".$author." - Contact: ".$contact_record["id"]." - User: ".$importer["uid"], LOGGER_DEBUG);
                                $ret = self::send_share($u[0], $contact_record);
 
@@ -2212,12 +2333,13 @@ class Diaspora {
         * @return int the message id
         */
        private static function receive_reshare($importer, $data, $xml) {
+               $author = notags(unxmlify($data->author));
+               $guid = notags(unxmlify($data->guid));
+               $created_at = datetime_convert("UTC", "UTC", notags(unxmlify($data->created_at)));
                $root_author = notags(unxmlify($data->root_author));
                $root_guid = notags(unxmlify($data->root_guid));
-               $guid = notags(unxmlify($data->guid));
-               $author = notags(unxmlify($data->author));
+               /// @todo handle unprocessed property "provider_display_name"
                $public = notags(unxmlify($data->public));
-               $created_at = datetime_convert("UTC", "UTC", notags(unxmlify($data->created_at)));
 
                $contact = self::allowed_contact_by_handle($importer, $author, false);
                if (!$contact) {
@@ -2256,7 +2378,8 @@ class Diaspora {
                $datarray["verb"] = ACTIVITY_POST;
                $datarray["gravity"] = GRAVITY_PARENT;
 
-               $datarray["object"] = $xml;
+               $datarray["protocol"] = PROTOCOL_DIASPORA;
+               $datarray["source"] = $xml;
 
                $prefix = share_header($original_item["author-name"], $original_item["author-link"], $original_item["author-avatar"],
                                        $original_item["guid"], $original_item["created"], $orig_url);
@@ -2291,9 +2414,9 @@ class Diaspora {
         * @return bool success
         */
        private static function item_retraction($importer, $contact, $data) {
-               $target_type = notags(unxmlify($data->target_type));
-               $target_guid = notags(unxmlify($data->target_guid));
                $author = notags(unxmlify($data->author));
+               $target_guid = notags(unxmlify($data->target_guid));
+               $target_type = notags(unxmlify($data->target_type));
 
                $person = self::person_by_handle($author);
                if (!is_array($person)) {
@@ -2301,11 +2424,16 @@ class Diaspora {
                        return false;
                }
 
+               if (!isset($contact["url"])) {
+                       $contact["url"] = $person["url"];
+               }
+
                $r = q("SELECT `id`, `parent`, `parent-uri`, `author-link` FROM `item` WHERE `guid` = '%s' AND `uid` = %d AND NOT `file` LIKE '%%[%%' LIMIT 1",
                        dbesc($target_guid),
                        intval($importer["uid"])
                );
                if (!$r) {
+                       logger("Target guid ".$target_guid." was not found for user ".$importer["uid"]);
                        return false;
                }
 
@@ -2351,7 +2479,7 @@ class Diaspora {
                $target_type = notags(unxmlify($data->target_type));
 
                $contact = self::contact_by_handle($importer["uid"], $sender);
-               if (!$contact) {
+               if (!$contact AND (in_array($target_type, array("Contact", "Person")))) {
                        logger("cannot find contact for sender: ".$sender." and user ".$importer["uid"]);
                        return false;
                }
@@ -2364,7 +2492,7 @@ class Diaspora {
                        case "Post": // "Post" will be supported in a future version
                        case "Reshare":
                        case "StatusMessage":
-                               return self::item_retraction($importer, $contact, $data);;
+                               return self::item_retraction($importer, $contact, $data);
 
                        case "Contact":
                        case "Person":
@@ -2390,19 +2518,13 @@ class Diaspora {
         * @return int The message id of the newly created item
         */
        private static function receive_status_message($importer, $data, $xml) {
-               $raw_message = unxmlify($data->raw_message);
-               $guid = notags(unxmlify($data->guid));
                $author = notags(unxmlify($data->author));
-               $public = notags(unxmlify($data->public));
+               $guid = notags(unxmlify($data->guid));
                $created_at = datetime_convert("UTC", "UTC", notags(unxmlify($data->created_at)));
+               $public = notags(unxmlify($data->public));
+               $text = unxmlify($data->text);
                $provider_display_name = notags(unxmlify($data->provider_display_name));
 
-               /// @todo enable support for polls
-               //if ($data->poll) {
-               //      foreach ($data->poll AS $poll)
-               //              print_r($poll);
-               //      die("poll!\n");
-               //}
                $contact = self::allowed_contact_by_handle($importer, $author, false);
                if (!$contact) {
                        return false;
@@ -2420,7 +2542,7 @@ class Diaspora {
                        }
                }
 
-               $body = diaspora2bb($raw_message);
+               $body = diaspora2bb($text);
 
                $datarray = array();
 
@@ -2441,6 +2563,15 @@ class Diaspora {
                        }
                }
 
+               /// @todo enable support for polls
+               //if ($data->poll) {
+               //      foreach ($data->poll AS $poll)
+               //              print_r($poll);
+               //      die("poll!\n");
+               //}
+
+               /// @todo enable support for events
+
                $datarray["uid"] = $importer["uid"];
                $datarray["contact-id"] = $contact["id"];
                $datarray["network"] = NETWORK_DIASPORA;
@@ -2459,7 +2590,8 @@ class Diaspora {
                $datarray["verb"] = ACTIVITY_POST;
                $datarray["gravity"] = GRAVITY_PARENT;
 
-               $datarray["object"] = $xml;
+               $datarray["protocol"] = PROTOCOL_DIASPORA;
+               $datarray["source"] = $xml;
 
                $datarray["body"] = self::replace_people_guid($body, $contact["url"]);
 
@@ -2618,20 +2750,19 @@ class Diaspora {
                        return false;
                }
 
-               $inner_aes_key = random_string(32);
+               $inner_aes_key = openssl_random_pseudo_bytes(32);
                $b_inner_aes_key = base64_encode($inner_aes_key);
-               $inner_iv = random_string(16);
+               $inner_iv = openssl_random_pseudo_bytes(16);
                $b_inner_iv = base64_encode($inner_iv);
 
-               $outer_aes_key = random_string(32);
+               $outer_aes_key = openssl_random_pseudo_bytes(32);
                $b_outer_aes_key = base64_encode($outer_aes_key);
-               $outer_iv = random_string(16);
+               $outer_iv = openssl_random_pseudo_bytes(16);
                $b_outer_iv = base64_encode($outer_iv);
 
                $handle = self::my_handle($user);
 
-               $padded_data = pkcs5_pad($msg,16);
-               $inner_encrypted = mcrypt_encrypt(MCRYPT_RIJNDAEL_128, $inner_aes_key, $padded_data, MCRYPT_MODE_CBC, $inner_iv);
+               $inner_encrypted = self::aes_encrypt($inner_aes_key, $inner_iv, $msg);
 
                $b64_data = base64_encode($inner_encrypted);
 
@@ -2653,9 +2784,8 @@ class Diaspora {
                                                        "author_id" => $handle));
 
                $decrypted_header = xml::from_array($xmldata, $xml, true);
-               $decrypted_header = pkcs5_pad($decrypted_header,16);
 
-               $ciphertext = mcrypt_encrypt(MCRYPT_RIJNDAEL_128, $outer_aes_key, $decrypted_header, MCRYPT_MODE_CBC, $outer_iv);
+               $ciphertext = self::aes_encrypt($outer_aes_key, $outer_iv, $decrypted_header);
 
                $outer_json = json_encode(array("iv" => $b_outer_iv, "key" => $b_outer_aes_key));
 
@@ -2745,7 +2875,7 @@ class Diaspora {
                $a = get_app();
 
                $enabled = intval(get_config("system", "diaspora_enabled"));
-               if(!$enabled)
+               if (!$enabled)
                        return 200;
 
                $logid = random_string(4);
@@ -3084,14 +3214,14 @@ class Diaspora {
                        $body = html_entity_decode(bb2diaspora($body));
 
                        // Adding the title
-                       if(strlen($title))
+                       if (strlen($title))
                                $body = "## ".html_entity_decode($title)."\n\n".$body;
 
                        if ($item["attach"]) {
                                $cnt = preg_match_all('/href=\"(.*?)\"(.*?)title=\"(.*?)\"/ism', $item["attach"], $matches, PREG_SET_ORDER);
-                               if(cnt) {
+                               if (cnt) {
                                        $body .= "\n".t("Attachments:")."\n";
-                                       foreach($matches as $mtch)
+                                       foreach ($matches as $mtch)
                                                $body .= "[".$mtch[3]."](".$mtch[1].")\n";
                                }
                        }
@@ -3571,7 +3701,7 @@ class Diaspora {
                if ($searchable === 'true') {
                        $dob = '1000-00-00';
 
-                       if (($profile['dob']) && ($profile['dob'] != '0000-00-00'))
+                       if (($profile['dob']) && ($profile['dob'] > '0001-01-01'))
                                $dob = ((intval($profile['dob'])) ? intval($profile['dob']) : '1000') .'-'. datetime_convert('UTC','UTC',$profile['dob'],'m-d');
 
                        $about = $profile['about'];
@@ -3584,7 +3714,7 @@ class Diaspora {
                                $kw = str_replace('  ',' ',$kw);
                                $arr = explode(' ',$profile['pub_keywords']);
                                if (count($arr)) {
-                                       for($x = 0; $x < 5; $x ++) {
+                                       for ($x = 0; $x < 5; $x ++) {
                                                if (trim($arr[$x]))
                                                        $tags .= '#'. trim($arr[$x]) .' ';
                                        }
@@ -3606,7 +3736,7 @@ class Diaspora {
                                "searchable" => $searchable,
                                "tag_string" => $tags);
 
-               foreach($recips as $recip) {
+               foreach ($recips as $recip) {
                        logger("Send updated profile data for user ".$uid." to contact ".$recip["id"], LOGGER_DEBUG);
                        self::build_and_transmit($profile, $recip, "profile", $message, false, "", true);
                }
@@ -3629,17 +3759,20 @@ class Diaspora {
                }
 
                $r = q("SELECT `prvkey` FROM `user` WHERE `uid` = %d LIMIT 1", intval($contact['uid']));
-               if(!$r)
+               if (!dbm::is_result($r)) {
                        return false;
+               }
 
                $contact["uprvkey"] = $r[0]['prvkey'];
 
                $r = q("SELECT * FROM `item` WHERE `id` = %d LIMIT 1", intval($post_id));
-               if (!$r)
+               if (!dbm::is_result($r)) {
                        return false;
+               }
 
-               if (!in_array($r[0]["verb"], array(ACTIVITY_LIKE, ACTIVITY_DISLIKE)))
+               if (!in_array($r[0]["verb"], array(ACTIVITY_LIKE, ACTIVITY_DISLIKE))) {
                        return false;
+               }
 
                $message = self::construct_like($r[0], $contact);
                $message["author_signature"] = self::signature($contact, $message);
@@ -3688,4 +3821,3 @@ class Diaspora {
                return true;
        }
 }
-?>