]> git.mxchange.org Git - friendica.git/blobdiff - include/diaspora.php
modified: view/theme/smoothly/style.css
[friendica.git] / include / diaspora.php
old mode 100644 (file)
new mode 100755 (executable)
index 7e1e034..baee042
@@ -5,10 +5,17 @@ require_once('include/items.php');
 require_once('include/bb2diaspora.php');
 require_once('include/contact_selectors.php');
 require_once('include/queue_fn.php');
+require_once('include/lock.php');
 
 
 function diaspora_dispatch_public($msg) {
 
+       $enabled = intval(get_config('system','diaspora_enabled'));
+       if(! $enabled) {
+               logger('mod-diaspora: disabled');
+               return;
+       }
+
        $r = q("SELECT `user`.* FROM `user` WHERE `user`.`uid` IN ( SELECT `contact`.`uid` FROM `contact` WHERE `contact`.`network` = '%s' AND `contact`.`addr` = '%s' ) AND `account_expired` = 0 ",
                dbesc(NETWORK_DIASPORA),
                dbesc($msg['author'])
@@ -29,6 +36,12 @@ function diaspora_dispatch($importer,$msg) {
 
        $ret = 0;
 
+       $enabled = intval(get_config('system','diaspora_enabled'));
+       if(! $enabled) {
+               logger('mod-diaspora: disabled');
+               return;
+       }
+
        // php doesn't like dashes in variable names
 
        $msg['message'] = str_replace(
@@ -41,14 +54,17 @@ function diaspora_dispatch($importer,$msg) {
 
        $xmlbase = $parsed_xml->post;
 
+       logger('diaspora_dispatch: ' . print_r($xmlbase,true), LOGGER_DEBUG);
+
+
        if($xmlbase->request) {
                $ret = diaspora_request($importer,$xmlbase->request);
        }
        elseif($xmlbase->status_message) {
-               $ret = diaspora_post($importer,$xmlbase->status_message);
+               $ret = diaspora_post($importer,$xmlbase->status_message,$msg);
        }
        elseif($xmlbase->profile) {
-               $ret = diaspora_profile($importer,$xmlbase->profile);
+               $ret = diaspora_profile($importer,$xmlbase->profile,$msg);
        }
        elseif($xmlbase->comment) {
                $ret = diaspora_comment($importer,$xmlbase->comment,$msg);
@@ -57,26 +73,66 @@ function diaspora_dispatch($importer,$msg) {
                $ret = diaspora_like($importer,$xmlbase->like,$msg);
        }
        elseif($xmlbase->asphoto) {
-               $ret = diaspora_asphoto($importer,$xmlbase->asphoto);
+               $ret = diaspora_asphoto($importer,$xmlbase->asphoto,$msg);
        }
        elseif($xmlbase->reshare) {
-               $ret = diaspora_reshare($importer,$xmlbase->reshare);
+               $ret = diaspora_reshare($importer,$xmlbase->reshare,$msg);
        }
        elseif($xmlbase->retraction) {
                $ret = diaspora_retraction($importer,$xmlbase->retraction,$msg);
        }
        elseif($xmlbase->signed_retraction) {
-               $ret = diaspora_signed_retraction($importer,$xmlbase->retraction,$msg);
+               $ret = diaspora_signed_retraction($importer,$xmlbase->signed_retraction,$msg);
+       }
+       elseif($xmlbase->relayable_retraction) {
+               $ret = diaspora_signed_retraction($importer,$xmlbase->relayable_retraction,$msg);
        }
        elseif($xmlbase->photo) {
                $ret = diaspora_photo($importer,$xmlbase->photo,$msg);
        }
+       elseif($xmlbase->conversation) {
+               $ret = diaspora_conversation($importer,$xmlbase->conversation,$msg);
+       }
+       elseif($xmlbase->message) {
+               $ret = diaspora_message($importer,$xmlbase->message,$msg);
+       }
        else {
                logger('diaspora_dispatch: unknown message type: ' . print_r($xmlbase,true));
        }
        return $ret;
 }
 
+function diaspora_handle_from_contact($contact_id) {
+       $handle = False;
+
+       logger("diaspora_handle_from_contact: contact id is " . $contact_id, LOGGER_DEBUG);
+
+       $r = q("SELECT network, addr, self, url, nick FROM contact WHERE id = %d",
+              intval($contact_id)
+       );
+       if($r) {
+               $contact = $r[0];
+
+               logger("diaspora_handle_from_contact: contact 'self' = " . $contact['self'] . " 'url' = " . $contact['url'], LOGGER_DEBUG);
+
+               if($contact['network'] === NETWORK_DIASPORA) {
+                       $handle = $contact['addr'];
+
+//                     logger("diaspora_handle_from_contact: contact id is a Diaspora person, handle = " . $handle, LOGGER_DEBUG);
+               }
+               elseif(($contact['network'] === NETWORK_DFRN) || ($contact['self'] == 1)) {
+                       $baseurl_start = strpos($contact['url'],'://') + 3;
+                       $baseurl_length = strpos($contact['url'],'/profile') - $baseurl_start; // allows installations in a subdirectory--not sure how Diaspora will handle
+                       $baseurl = substr($contact['url'], $baseurl_start, $baseurl_length);
+                       $handle = $contact['nick'] . '@' . $baseurl;
+
+//                     logger("diaspora_handle_from_contact: contact id is a DFRN person, handle = " . $handle, LOGGER_DEBUG);
+               }
+       }
+
+       return $handle;
+}
+
 function diaspora_get_contact_by_handle($uid,$handle) {
        $r = q("SELECT * FROM `contact` WHERE `network` = '%s' AND `uid` = %d AND `addr` = '%s' LIMIT 1",
                dbesc(NETWORK_DIASPORA),
@@ -89,27 +145,93 @@ function diaspora_get_contact_by_handle($uid,$handle) {
 }
 
 function find_diaspora_person_by_handle($handle) {
+
+       $person = false;
        $update = false;
-       $r = q("select * from fcontact where network = '%s' and addr = '%s' limit 1",
-               dbesc(NETWORK_DIASPORA),
-               dbesc($handle)
-       );
-       if(count($r)) {
-               logger('find_diaspora_person_by handle: in cache ' . print_r($r,true), LOGGER_DEBUG);
-               // update record occasionally so it doesn't get stale
-               $d = strtotime($r[0]['updated'] . ' +00:00');
-               if($d > strtotime('now - 14 days'))
-                       return $r[0];
-               $update = true;
-       }
-       logger('find_diaspora_person_by_handle: refresh',LOGGER_DEBUG);
-       require_once('include/Scrape.php');
-       $r = probe_url($handle, PROBE_DIASPORA);
-       if((count($r)) && ($r['network'] === NETWORK_DIASPORA)) {
-               add_fcontact($r,$update);
-               return ($r);
-       }
-       return false;
+       $got_lock = false;
+
+       $endlessloop = 0;
+       $maxloops = 10;
+
+       do {
+               $r = q("select * from fcontact where network = '%s' and addr = '%s' limit 1",
+                       dbesc(NETWORK_DIASPORA),
+                       dbesc($handle)
+               );
+               if(count($r)) {
+                       $person = $r[0];
+                       logger('find_diaspora_person_by handle: in cache ' . print_r($r,true), LOGGER_DEBUG);
+
+                       // update record occasionally so it doesn't get stale
+                       $d = strtotime($person['updated'] . ' +00:00');
+                       if($d < strtotime('now - 14 days'))
+                               $update = true;
+               }
+
+
+               // FETCHING PERSON INFORMATION FROM REMOTE SERVER
+               //
+               // If the person isn't in our 'fcontact' table, or if he/she is but
+               // his/her information hasn't been updated for more than 14 days, then
+               // we want to fetch the person's information from the remote server.
+               //
+               // Note that $person isn't changed by this block of code unless the
+               // person's information has been successfully fetched from the remote
+               // server. So if $person was 'false' to begin with (because he/she wasn't
+               // in the local cache), it'll stay false, and if $person held the local
+               // cache information to begin with, it'll keep that information. That way
+               // if there's a problem with the remote fetch, we can at least use our
+               // cached information--it's better than nothing.
+
+               if((! $person) || ($update))  {
+                       // Lock the function to prevent race conditions if multiple items
+                       // come in at the same time from a person who doesn't exist in
+                       // fcontact
+                       //
+                       // Don't loop forever. On the last loop, try to create the contact
+                       // whether the function is locked or not. Maybe the locking thread
+                       // has died or something. At any rate, a duplicate in 'fcontact'
+                       // is a much smaller problem than a deadlocked thread
+                       $got_lock = lock_function('find_diaspora_person_by_handle', false);
+                       if(($endlessloop + 1) >= $maxloops)
+                               $got_lock = true;
+
+                       if($got_lock) {
+                               logger('find_diaspora_person_by_handle: create or refresh', LOGGER_DEBUG);
+                               require_once('include/Scrape.php');
+                               $r = probe_url($handle, PROBE_DIASPORA);
+
+                               // Note that Friendica contacts can return a "Diaspora person"
+                               // if Diaspora connectivity is enabled on their server
+                               if((count($r)) && ($r['network'] === NETWORK_DIASPORA)) {
+                                       add_fcontact($r,$update);
+                                       $person = ($r);
+                               }
+
+                               unlock_function('find_diaspora_person_by_handle');
+                       }
+                       else {
+                               logger('find_diaspora_person_by_handle: couldn\'t lock function', LOGGER_DEBUG);
+                               if(! $person)
+                                       block_on_function_lock('find_diaspora_person_by_handle');
+                       }
+               }
+       } while((! $person) && (! $got_lock) && (++$endlessloop < $maxloops));
+       // We need to try again if the person wasn't in 'fcontact' but the function was locked.
+       // The fact that the function was locked may mean that another process was creating the
+       // person's record. It could also mean another process was creating or updating an unrelated
+       // person.
+       //
+       // At any rate, we need to keep trying until we've either got the person or had a chance to
+       // try to fetch his/her remote information. But we don't want to block on locking the
+       // function, because if the other process is creating the record, then when we acquire the lock
+       // we'll dive right into creating another, duplicate record. We DO want to at least wait
+       // until the lock is released, so we don't flood the database with requests.
+       //
+       // If the person was in the 'fcontact' table, don't try again. It's not worth the time, since
+       // we do have some information for the person
+
+       return $person;
 }
 
 
@@ -179,6 +301,13 @@ function diaspora_msg_build($msg,$user,$contact,$prvkey,$pubkey,$public = false)
 
        logger('diaspora_msg_build: ' . $msg, LOGGER_DATA);
 
+       // without a public key nothing will work
+
+       if(! $pubkey) {
+               logger('diaspora_msg_build: pubkey missing: contact id: ' . $contact['id']);
+               return '';
+       }
+
        $inner_aes_key = random_string(32);
        $b_inner_aes_key = base64_encode($inner_aes_key);
        $inner_iv = random_string(16);
@@ -420,6 +549,8 @@ function diaspora_decode($importer,$xml) {
        
 function diaspora_request($importer,$xml) {
 
+       $a = get_app();
+
        $sender_handle = unxmlify($xml->sender_handle);
        $recipient_handle = unxmlify($xml->recipient_handle);
 
@@ -433,14 +564,69 @@ function diaspora_request($importer,$xml) {
                // perhaps we were already sharing with this person. Now they're sharing with us.
                // That makes us friends.
 
-               if($contact['rel'] == CONTACT_IS_FOLLOWER) {
+               if($contact['rel'] == CONTACT_IS_FOLLOWER && $importer['page-flags'] != PAGE_COMMUNITY) {
                        q("UPDATE `contact` SET `rel` = %d, `writable` = 1 WHERE `id` = %d AND `uid` = %d LIMIT 1",
                                intval(CONTACT_IS_FRIEND),
                                intval($contact['id']),
                                intval($importer['uid'])
                        );
                }
-               // send notification?
+               // send notification
+
+               $r = q("SELECT `hide-friends` FROM `profile` WHERE `uid` = %d AND `is-default` = 1 LIMIT 1",
+                       intval($importer['uid'])
+               );
+
+               if((count($r)) && (! $r[0]['hide-friends']) && (! $contact['hidden'])) {
+                       require_once('include/items.php');
+
+                       $self = q("SELECT * FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1",
+                               intval($importer['uid'])
+                       );
+
+                       // they are not CONTACT_IS_FOLLOWER anymore but that's what we have in the array
+
+                       if(count($self) && $contact['rel'] == CONTACT_IS_FOLLOWER) {
+
+                               $arr = array();
+                               $arr['uri'] = $arr['parent-uri'] = item_new_uri($a->get_hostname(), $importer['uid']); 
+                               $arr['uid'] = $importer['uid'];
+                               $arr['contact-id'] = $self[0]['id'];
+                               $arr['wall'] = 1;
+                               $arr['type'] = 'wall';
+                               $arr['gravity'] = 0;
+                               $arr['origin'] = 1;
+                               $arr['author-name'] = $arr['owner-name'] = $self[0]['name'];
+                               $arr['author-link'] = $arr['owner-link'] = $self[0]['url'];
+                               $arr['author-avatar'] = $arr['owner-avatar'] = $self[0]['thumb'];
+                               $arr['verb'] = ACTIVITY_FRIEND;
+                               $arr['object-type'] = ACTIVITY_OBJ_PERSON;
+                               
+                               $A = '[url=' . $self[0]['url'] . ']' . $self[0]['name'] . '[/url]';
+                               $B = '[url=' . $contact['url'] . ']' . $contact['name'] . '[/url]';
+                               $BPhoto = '[url=' . $contact['url'] . ']' . '[img]' . $contact['thumb'] . '[/img][/url]';
+                               $arr['body'] =  sprintf( t('%1$s is now friends with %2$s'), $A, $B)."\n\n\n".$Bphoto;
+
+                               $arr['object'] = '<object><type>' . ACTIVITY_OBJ_PERSON . '</type><title>' . $contact['name'] . '</title>'
+                                       . '<id>' . $contact['url'] . '/' . $contact['name'] . '</id>';
+                               $arr['object'] .= '<link>' . xmlify('<link rel="alternate" type="text/html" href="' . $contact['url'] . '" />' . "\n");
+                               $arr['object'] .= xmlify('<link rel="photo" type="image/jpeg" href="' . $contact['thumb'] . '" />' . "\n");
+                               $arr['object'] .= '</link></object>' . "\n";
+                               $arr['last-child'] = 1;
+
+                               $arr['allow_cid'] = $user[0]['allow_cid'];
+                               $arr['allow_gid'] = $user[0]['allow_gid'];
+                               $arr['deny_cid']  = $user[0]['deny_cid'];
+                               $arr['deny_gid']  = $user[0]['deny_gid'];
+
+                               $i = item_store($arr);
+                               if($i)
+                               proc_run('php',"include/notifier.php","activity","$i");
+
+                       }
+
+               }
+
                return;
        }
        
@@ -454,6 +640,8 @@ function diaspora_request($importer,$xml) {
 
        $batch = (($ret['batch']) ? $ret['batch'] : implode('/', array_slice(explode('/',$ret['url']),0,3)) . '/receive/public');
 
+
+
        $r = q("INSERT INTO `contact` (`uid`, `network`,`addr`,`created`,`url`,`nurl`,`batch`,`name`,`nick`,`photo`,`pubkey`,`notify`,`poll`,`blocked`,`priority`)
                VALUES ( %d, '%s', '%s', '%s', '%s','%s','%s','%s','%s','%s','%s','%s','%s',%d,%d) ",
                intval($importer['uid']),
@@ -477,9 +665,23 @@ function diaspora_request($importer,$xml) {
 
        $contact_record = diaspora_get_contact_by_handle($importer['uid'],$sender_handle);
 
-       $hash = random_string() . (string) time();   // Generate a confirm_key
+       if(! $contact_record) {
+               logger('diaspora_request: unable to locate newly created contact record.');
+               return;
+       }
+
+       $g = q("select def_gid from user where uid = %d limit 1",
+               intval($importer['uid'])
+       );
+       if($g && intval($g[0]['def_gid'])) {
+               require_once('include/group.php');
+               group_add_member($importer['uid'],'',$contact_record['id'],$g[0]['def_gid']);
+       }
+
+       if($importer['page-flags'] == PAGE_NORMAL) {
+
+               $hash = random_string() . (string) time();   // Generate a confirm_key
        
-       if($contact_record) {
                $ret = q("INSERT INTO `intro` ( `uid`, `contact-id`, `blocked`, `knowyou`, `note`, `hash`, `datetime` )
                        VALUES ( %d, %d, %d, %d, '%s', '%s', '%s' )",
                        intval($importer['uid']),
@@ -491,21 +693,81 @@ function diaspora_request($importer,$xml) {
                        dbesc(datetime_convert())
                );
        }
+       else {
+
+               // automatic friend approval
+
+               require_once('include/Photo.php');
+
+               $photos = import_profile_photo($contact_record['photo'],$importer['uid'],$contact_record['id']);
+               
+               // technically they are sharing with us (CONTACT_IS_SHARING), 
+               // but if our page-type is PAGE_COMMUNITY or PAGE_SOAPBOX
+               // we are going to change the relationship and make them a follower.
+
+               if($importer['page-flags'] == PAGE_FREELOVE)
+                       $new_relation = CONTACT_IS_FRIEND;
+               else
+                       $new_relation = CONTACT_IS_FOLLOWER;
+
+               $r = q("UPDATE `contact` SET 
+                       `photo` = '%s', 
+                       `thumb` = '%s',
+                       `micro` = '%s', 
+                       `rel` = %d, 
+                       `name-date` = '%s', 
+                       `uri-date` = '%s', 
+                       `avatar-date` = '%s', 
+                       `blocked` = 0, 
+                       `pending` = 0
+                       WHERE `id` = %d LIMIT 1
+                       ",
+                       dbesc($photos[0]),
+                       dbesc($photos[1]),
+                       dbesc($photos[2]),
+                       intval($new_relation),
+                       dbesc(datetime_convert()),
+                       dbesc(datetime_convert()),
+                       dbesc(datetime_convert()),
+                       intval($contact_record['id'])
+               );
+
+               $u = q("select * from user where uid = %d limit 1",intval($importer['uid']));
+               if($u)
+                       $ret = diaspora_share($u[0],$contact_record);
+       }
 
        return;
 }
 
-function diaspora_post($importer,$xml) {
+function diaspora_post_allow($importer,$contact) {
+       if(($contact['blocked']) || ($contact['readonly']))
+               return false;
+       if($contact['rel'] == CONTACT_IS_SHARING || $contact['rel'] == CONTACT_IS_FRIEND)
+               return true;
+       if($contact['rel'] == CONTACT_IS_FOLLOWER)
+               if($importer['page-flags'] == PAGE_COMMUNITY)
+                       return true;
+       return false;
+}
+
+
+function diaspora_post($importer,$xml,$msg) {
 
        $a = get_app();
        $guid = notags(unxmlify($xml->guid));
        $diaspora_handle = notags(unxmlify($xml->diaspora_handle));
 
+       if($diaspora_handle != $msg['author']) {
+               logger('diaspora_post: Potential forgery. Message handle is not the same as envelope sender.');
+               return 202;
+       }
+
        $contact = diaspora_get_contact_by_handle($importer['uid'],$diaspora_handle);
        if(! $contact)
                return;
 
-       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+       if(! diaspora_post_allow($importer,$contact)) {
                logger('diaspora_post: Ignoring this author.');
                return 202;
        }
@@ -521,7 +783,7 @@ function diaspora_post($importer,$xml) {
                return;
        }
 
-    // allocate a guid on our system - we aren't fixing any collisions.
+       // allocate a guid on our system - we aren't fixing any collisions.
        // we're ignoring them
 
        $g = q("select * from guid where guid = '%s' limit 1",
@@ -549,16 +811,33 @@ function diaspora_post($importer,$xml) {
                        if(strpos($tag,'#') === 0) {
                                if(strpos($tag,'[url='))
                                        continue;
+
+                               // don't link tags that are already embedded in links
+
+                               if(preg_match('/\[(.*?)' . preg_quote($tag,'/') . '(.*?)\]/',$body))
+                                       continue;
+                               if(preg_match('/\[(.*?)\]\((.*?)' . preg_quote($tag,'/') . '(.*?)\)/',$body))
+                                       continue;
+
                                $basetag = str_replace('_',' ',substr($tag,1));
-                               $body = str_replace($tag,'#[url=' . $a->get_baseurl() . '/search?search=' . rawurlencode($basetag) . ']' . $basetag . '[/url]',$body);
+                               $body = str_replace($tag,'#[url=' . $a->get_baseurl() . '/search?tag=' . rawurlencode($basetag) . ']' . $basetag . '[/url]',$body);
                                if(strlen($str_tags))
                                        $str_tags .= ',';
-                               $str_tags .= '#[url=' . $a->get_baseurl() . '/search?search=' . rawurlencode($basetag) . ']' . $basetag . '[/url]';
+                               $str_tags .= '#[url=' . $a->get_baseurl() . '/search?tag=' . rawurlencode($basetag) . ']' . $basetag . '[/url]';
                                continue;
                        }
                }
        }
-       
+
+       $cnt = preg_match_all('/@\[url=(.*?)\[\/url\]/ism',$body,$matches,PREG_SET_ORDER);
+       if($cnt) {
+               foreach($matches as $mtch) {
+                       if(strlen($str_tags))
+                               $str_tags .= ',';
+                       $str_tags .= '@[url=' . $mtch[1] . '[/url]';    
+               }
+       }
+
        $datarray['uid'] = $importer['uid'];
        $datarray['contact-id'] = $contact['id'];
        $datarray['wall'] = 0;
@@ -594,7 +873,7 @@ function diaspora_post($importer,$xml) {
 
 }
 
-function diaspora_reshare($importer,$xml) {
+function diaspora_reshare($importer,$xml,$msg) {
 
        logger('diaspora_reshare: init: ' . print_r($xml,true));
 
@@ -603,11 +882,16 @@ function diaspora_reshare($importer,$xml) {
        $diaspora_handle = notags(unxmlify($xml->diaspora_handle));
 
 
+       if($diaspora_handle != $msg['author']) {
+               logger('diaspora_post: Potential forgery. Message handle is not the same as envelope sender.');
+               return 202;
+       }
+
        $contact = diaspora_get_contact_by_handle($importer['uid'],$diaspora_handle);
        if(! $contact)
                return;
 
-       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+       if(! diaspora_post_allow($importer,$contact)) {
                logger('diaspora_reshare: Ignoring this author: ' . $diaspora_handle . ' ' . print_r($xml,true));
                return 202;
        }
@@ -641,15 +925,15 @@ function diaspora_reshare($importer,$xml) {
 
        if(strlen($source_xml->post->asphoto->objectId) && ($source_xml->post->asphoto->objectId != 0) && ($source_xml->post->asphoto->image_url)) {
                $body = '[url=' . notags(unxmlify($source_xml->post->asphoto->image_url)) . '][img]' . notags(unxmlify($source_xml->post->asphoto->objectId)) . '[/img][/url]' . "\n";
-               $body = scale_diaspora_images($body,false);
+               $body = scale_external_images($body,false);
        }
        elseif($source_xml->post->asphoto->image_url) {
                $body = '[img]' . notags(unxmlify($source_xml->post->asphoto->image_url)) . '[/img]' . "\n";
-               $body = scale_diaspora_images($body);
+               $body = scale_external_images($body);
        }
        elseif($source_xml->post->status_message) {
                $body = diaspora2bb($source_xml->post->status_message->raw_message);
-               $body = scale_diaspora_images($body);
+               $body = scale_external_images($body);
 
        }
        else {
@@ -668,10 +952,10 @@ function diaspora_reshare($importer,$xml) {
        else
                $details = $orig_author;
        
-       $prefix = '&#x2672; ' . $details . "\n"; 
+       $prefix = html_entity_decode("&#x2672; ", ENT_QUOTES, 'UTF-8') . $details . "\n"; 
 
 
-    // allocate a guid on our system - we aren't fixing any collisions.
+       // allocate a guid on our system - we aren't fixing any collisions.
        // we're ignoring them
 
        $g = q("select * from guid where guid = '%s' limit 1",
@@ -697,11 +981,20 @@ function diaspora_reshare($importer,$xml) {
                        if(strpos($tag,'#') === 0) {
                                if(strpos($tag,'[url='))
                                        continue;
+
+                               // don't link tags that are already embedded in links
+
+                               if(preg_match('/\[(.*?)' . preg_quote($tag,'/') . '(.*?)\]/',$body))
+                                       continue;
+                               if(preg_match('/\[(.*?)\]\((.*?)' . preg_quote($tag,'/') . '(.*?)\)/',$body))
+                                       continue;
+
+
                                $basetag = str_replace('_',' ',substr($tag,1));
-                               $body = str_replace($tag,'#[url=' . $a->get_baseurl() . '/search?search=' . rawurlencode($basetag) . ']' . $basetag . '[/url]',$body);
+                               $body = str_replace($tag,'#[url=' . $a->get_baseurl() . '/search?tag=' . rawurlencode($basetag) . ']' . $basetag . '[/url]',$body);
                                if(strlen($str_tags))
                                        $str_tags .= ',';
-                               $str_tags .= '#[url=' . $a->get_baseurl() . '/search?search=' . rawurlencode($basetag) . ']' . $basetag . '[/url]';
+                               $str_tags .= '#[url=' . $a->get_baseurl() . '/search?tag=' . rawurlencode($basetag) . ']' . $basetag . '[/url]';
                                continue;
                        }
                }
@@ -739,18 +1032,23 @@ function diaspora_reshare($importer,$xml) {
 }
 
 
-function diaspora_asphoto($importer,$xml) {
+function diaspora_asphoto($importer,$xml,$msg) {
        logger('diaspora_asphoto called');
 
        $a = get_app();
        $guid = notags(unxmlify($xml->guid));
        $diaspora_handle = notags(unxmlify($xml->diaspora_handle));
 
+       if($diaspora_handle != $msg['author']) {
+               logger('diaspora_post: Potential forgery. Message handle is not the same as envelope sender.');
+               return 202;
+       }
+
        $contact = diaspora_get_contact_by_handle($importer['uid'],$diaspora_handle);
        if(! $contact)
                return;
 
-       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+       if(! diaspora_post_allow($importer,$contact)) {
                logger('diaspora_asphoto: Ignoring this author.');
                return 202;
        }
@@ -766,7 +1064,7 @@ function diaspora_asphoto($importer,$xml) {
                return;
        }
 
-    // allocate a guid on our system - we aren't fixing any collisions.
+       // allocate a guid on our system - we aren't fixing any collisions.
        // we're ignoring them
 
        $g = q("select * from guid where guid = '%s' limit 1",
@@ -783,11 +1081,11 @@ function diaspora_asphoto($importer,$xml) {
 
        if(strlen($xml->objectId) && ($xml->objectId != 0) && ($xml->image_url)) {
                $body = '[url=' . notags(unxmlify($xml->image_url)) . '][img]' . notags(unxmlify($xml->objectId)) . '[/img][/url]' . "\n";
-               $body = scale_diaspora_images($body,false);
+               $body = scale_external_images($body,false);
        }
        elseif($xml->image_url) {
                $body = '[img]' . notags(unxmlify($xml->image_url)) . '[/img]' . "\n";
-               $body = scale_diaspora_images($body);
+               $body = scale_external_images($body);
        }
        else {
                logger('diaspora_asphoto: no photo url found.');
@@ -845,15 +1143,13 @@ function diaspora_comment($importer,$xml,$msg) {
 
        $parent_author_signature = (($xml->parent_author_signature) ? notags(unxmlify($xml->parent_author_signature)) : '');
 
-       $text = $xml->text;
-
        $contact = diaspora_get_contact_by_handle($importer['uid'],$msg['author']);
        if(! $contact) {
                logger('diaspora_comment: cannot find contact: ' . $msg['author']);
                return;
        }
 
-       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+       if(! diaspora_post_allow($importer,$contact)) {
                logger('diaspora_comment: Ignoring this author.');
                return 202;
        }
@@ -877,45 +1173,64 @@ function diaspora_comment($importer,$xml,$msg) {
        }
        $parent_item = $r[0];
 
-       $author_signed_data = $guid . ';' . $parent_guid . ';' . $text . ';' . $diaspora_handle;
-
-       $author_signature = base64_decode($author_signature);
 
-       if(strcasecmp($diaspora_handle,$msg['author']) == 0) {
-               $person = $contact;
-               $key = $msg['key'];
-       }
-       else {
-               $person = find_diaspora_person_by_handle($diaspora_handle);     
+       /* How Diaspora performs comment signature checking:
 
-               if(is_array($person) && x($person,'pubkey'))
-                       $key = $person['pubkey'];
-               else {
-                       logger('diaspora_comment: unable to find author details');
-                       return;
-               }
-       }
+          - If an item has been sent by the comment author to the top-level post owner to relay on
+            to the rest of the contacts on the top-level post, the top-level post owner should check
+            the author_signature, then create a parent_author_signature before relaying the comment on
+          - If an item has been relayed on by the top-level post owner, the contacts who receive it
+            check only the parent_author_signature. Basically, they trust that the top-level post
+            owner has already verified the authenticity of anything he/she sends out
+          - In either case, the signature that get checked is the signature created by the person
+            who sent the salmon
+       */
 
-       if(! rsa_verify($author_signed_data,$author_signature,$key,'sha256')) {
-               logger('diaspora_comment: verification failed.');
-               return;
-       }
+       $signed_data = $guid . ';' . $parent_guid . ';' . $text . ';' . $diaspora_handle;
+       $key = $msg['key'];
 
        if($parent_author_signature) {
-               $owner_signed_data = $guid . ';' . $parent_guid . ';' . $text . ';' . $diaspora_handle;
+               // If a parent_author_signature exists, then we've received the comment
+               // relayed from the top-level post owner. There's no need to check the
+               // author_signature if the parent_author_signature is valid
 
                $parent_author_signature = base64_decode($parent_author_signature);
 
-               $key = $msg['key'];
+               if(! rsa_verify($signed_data,$parent_author_signature,$key,'sha256')) {
+                       logger('diaspora_comment: top-level owner verification failed.');
+                       return;
+               }
+       }
+       else {
+               // If there's no parent_author_signature, then we've received the comment
+               // from the comment creator. In that case, the person is commenting on
+               // our post, so he/she must be a contact of ours and his/her public key
+               // should be in $msg['key']
 
-               if(! rsa_verify($owner_signed_data,$parent_author_signature,$key,'sha256')) {
-                       logger('diaspora_comment: owner verification failed.');
+               $author_signature = base64_decode($author_signature);
+
+               if(! rsa_verify($signed_data,$author_signature,$key,'sha256')) {
+                       logger('diaspora_comment: comment author verification failed.');
                        return;
                }
        }
 
        // Phew! Everything checks out. Now create an item.
 
+       // Find the original comment author information.
+       // We need this to make sure we display the comment author
+       // information (name and avatar) correctly.
+       if(strcasecmp($diaspora_handle,$msg['author']) == 0)
+               $person = $contact;
+       else {
+               $person = find_diaspora_person_by_handle($diaspora_handle);     
+
+               if(! is_array($person)) {
+                       logger('diaspora_comment: unable to find author details');
+                       return;
+               }
+       }
+
        $body = diaspora2bb($text);
 
        $message_id = $diaspora_handle . ':' . $guid;
@@ -931,11 +1246,20 @@ function diaspora_comment($importer,$xml,$msg) {
                        if(strpos($tag,'#') === 0) {
                                if(strpos($tag,'[url='))
                                        continue;
+
+                               // don't link tags that are already embedded in links
+
+                               if(preg_match('/\[(.*?)' . preg_quote($tag,'/') . '(.*?)\]/',$body))
+                                       continue;
+                               if(preg_match('/\[(.*?)\]\((.*?)' . preg_quote($tag,'/') . '(.*?)\)/',$body))
+                                       continue;
+
+
                                $basetag = str_replace('_',' ',substr($tag,1));
-                               $body = str_replace($tag,'#[url=' . $a->get_baseurl() . '/search?search=' . rawurlencode($basetag) . ']' . $basetag . '[/url]',$body);
+                               $body = str_replace($tag,'#[url=' . $a->get_baseurl() . '/search?tag=' . rawurlencode($basetag) . ']' . $basetag . '[/url]',$body);
                                if(strlen($str_tags))
                                        $str_tags .= ',';
-                               $str_tags .= '#[url=' . $a->get_baseurl() . '/search?search=' . rawurlencode($basetag) . ']' . $basetag . '[/url]';
+                               $str_tags .= '#[url=' . $a->get_baseurl() . '/search?tag=' . rawurlencode($basetag) . ']' . $basetag . '[/url]';
                                continue;
                        }
                }
@@ -943,6 +1267,7 @@ function diaspora_comment($importer,$xml,$msg) {
 
        $datarray['uid'] = $importer['uid'];
        $datarray['contact-id'] = $contact['id'];
+       $datarray['type'] = 'remote-comment';
        $datarray['wall'] = $parent_item['wall'];
        $datarray['gravity'] = GRAVITY_COMMENT;
        $datarray['guid'] = $guid;
@@ -979,7 +1304,7 @@ function diaspora_comment($importer,$xml,$msg) {
        if(($parent_item['origin']) && (! $parent_author_signature)) {
                q("insert into sign (`iid`,`signed_text`,`signature`,`signer`) values (%d,'%s','%s','%s') ",
                        intval($message_id),
-                       dbesc($author_signed_data),
+                       dbesc($signed_data),
                        dbesc(base64_encode($author_signature)),
                        dbesc($diaspora_handle)
                );
@@ -988,14 +1313,327 @@ function diaspora_comment($importer,$xml,$msg) {
                // the existence of parent_author_signature means the parent_author or owner
                // is already relaying.
 
-               proc_run('php','include/notifier.php','comment',$message_id);
+               proc_run('php','include/notifier.php','comment-import',$message_id);
+       }
+
+       $myconv = q("SELECT `author-link`, `author-avatar`, `parent` FROM `item` WHERE `parent-uri` = '%s' AND `uid` = %d AND `parent` != 0 AND `deleted` = 0 ",
+               dbesc($parent_item['uri']),
+               intval($importer['uid'])
+       );
+
+       if(count($myconv)) {
+               $importer_url = $a->get_baseurl() . '/profile/' . $importer['nickname'];
+
+               foreach($myconv as $conv) {
+
+                       // now if we find a match, it means we're in this conversation
+       
+                       if(! link_compare($conv['author-link'],$importer_url))
+                               continue;
+
+                       require_once('include/enotify.php');
+                                                               
+                       $conv_parent = $conv['parent'];
+
+                       notification(array(
+                               'type'         => NOTIFY_COMMENT,
+                               'notify_flags' => $importer['notify-flags'],
+                               'language'     => $importer['language'],
+                               'to_name'      => $importer['username'],
+                               'to_email'     => $importer['email'],
+                               'uid'          => $importer['uid'],
+                               'item'         => $datarray,
+                               'link'             => $a->get_baseurl() . '/display/' . $importer['nickname'] . '/' . $message_id,
+                               'source_name'  => $datarray['author-name'],
+                               'source_link'  => $datarray['author-link'],
+                               'source_photo' => $datarray['author-avatar'],
+                               'verb'         => ACTIVITY_POST,
+                               'otype'        => 'item',
+                               'parent'       => $conv_parent,
+                               'parent_uri'   => $parent_uri
+                       ));
+
+                       // only send one notification
+                       break;
+               }
        }
        return;
 }
 
+
+
+
+function diaspora_conversation($importer,$xml,$msg) {
+
+       $a = get_app();
+
+       $guid = notags(unxmlify($xml->guid));
+       $subject = notags(unxmlify($xml->subject));
+       $diaspora_handle = notags(unxmlify($xml->diaspora_handle));
+       $participant_handles = notags(unxmlify($xml->participant_handles));
+       $created_at = datetime_convert('UTC','UTC',notags(unxmlify($xml->created_at)));
+
+       $parent_uri = $diaspora_handle . ':' . $guid;
+       $messages = $xml->message;
+
+       if(! count($messages)) {
+               logger('diaspora_conversation: empty conversation');
+               return;
+       }
+
+       $contact = diaspora_get_contact_by_handle($importer['uid'],$msg['author']);
+       if(! $contact) {
+               logger('diaspora_conversation: cannot find contact: ' . $msg['author']);
+               return;
+       }
+
+       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+               logger('diaspora_conversation: Ignoring this author.');
+               return 202;
+       }
+
+       $conversation = null;
+
+       $c = q("select * from conv where uid = %d and guid = '%s' limit 1",
+               intval($importer['uid']),
+               dbesc($guid)
+       );
+       if(count($c))
+               $conversation = $c[0];
+       else {
+               $r = q("insert into conv (uid,guid,creator,created,updated,subject,recips) values(%d, '%s', '%s', '%s', '%s', '%s', '%s') ",
+                       intval($importer['uid']),
+                       dbesc($guid),
+                       dbesc($diaspora_handle),
+                       dbesc(datetime_convert('UTC','UTC',$created_at)),
+                       dbesc(datetime_convert()),
+                       dbesc($subject),
+                       dbesc($participant_handles)
+               );
+               if($r)
+                       $c = q("select * from conv where uid = %d and guid = '%s' limit 1",
+               intval($importer['uid']),
+           dbesc($guid)
+       );
+           if(count($c))
+           $conversation = $c[0];
+       }
+       if(! $conversation) {
+               logger('diaspora_conversation: unable to create conversation.');
+               return;
+       }
+
+       foreach($messages as $mesg) {
+
+               $reply = 0;
+
+               $msg_guid = notags(unxmlify($mesg->guid));
+               $msg_parent_guid = notags(unxmlify($mesg->parent_guid));
+               $msg_parent_author_signature = notags(unxmlify($mesg->parent_author_signature));
+               $msg_author_signature = notags(unxmlify($mesg->author_signature));
+               $msg_text = unxmlify($mesg->text);
+               $msg_created_at = datetime_convert('UTC','UTC',notags(unxmlify($mesg->created_at)));
+               $msg_diaspora_handle = notags(unxmlify($mesg->diaspora_handle));
+               $msg_conversation_guid = notags(unxmlify($mesg->conversation_guid));
+               if($msg_conversation_guid != $guid) {
+                       logger('diaspora_conversation: message conversation guid does not belong to the current conversation. ' . $xml);
+                       continue;
+               }
+
+               $body = diaspora2bb($msg_text);
+               $message_id = $msg_diaspora_handle . ':' . $msg_guid;
+
+               $author_signed_data = $msg_guid . ';' . $msg_parent_guid . ';' . $msg_text . ';' . unxmlify($mesg->created_at) . ';' . $msg_diaspora_handle . ';' . $msg_conversation_guid;
+
+               $author_signature = base64_decode($msg_author_signature);
+
+               if(strcasecmp($msg_diaspora_handle,$msg['author']) == 0) {
+                       $person = $contact;
+                       $key = $msg['key'];
+               }
+               else {
+                       $person = find_diaspora_person_by_handle($msg_diaspora_handle); 
+
+                       if(is_array($person) && x($person,'pubkey'))
+                               $key = $person['pubkey'];
+                       else {
+                               logger('diaspora_conversation: unable to find author details');
+                               continue;
+                       }
+               }
+
+               if(! rsa_verify($author_signed_data,$author_signature,$key,'sha256')) {
+                       logger('diaspora_conversation: verification failed.');
+                       continue;
+               }
+
+               if($msg_parent_author_signature) {
+                       $owner_signed_data = $msg_guid . ';' . $msg_parent_guid . ';' . $msg_text . ';' . unxmlify($mesg->created_at) . ';' . $msg_diaspora_handle . ';' . $msg_conversation_guid;
+
+                       $parent_author_signature = base64_decode($msg_parent_author_signature);
+
+                       $key = $msg['key'];
+
+                       if(! rsa_verify($owner_signed_data,$parent_author_signature,$key,'sha256')) {
+                               logger('diaspora_conversation: owner verification failed.');
+                               continue;
+                       }
+               }
+
+               $r = q("select id from mail where `uri` = '%s' limit 1",
+                       dbesc($message_id)
+               );
+               if(count($r)) {
+                       logger('diaspora_conversation: duplicate message already delivered.', LOGGER_DEBUG);
+                       continue;
+               }
+
+               q("insert into mail ( `uid`, `guid`, `convid`, `from-name`,`from-photo`,`from-url`,`contact-id`,`title`,`body`,`seen`,`reply`,`uri`,`parent-uri`,`created`) values ( %d, '%s', %d, '%s', '%s', '%s', %d, '%s', '%s', %d, %d, '%s','%s','%s')",
+                       intval($importer['uid']),
+                       dbesc($msg_guid),
+                       intval($conversation['id']),
+                       dbesc($person['name']),
+                       dbesc($person['photo']),
+                       dbesc($person['url']),
+                       intval($contact['id']),  
+                       dbesc($subject),
+                       dbesc($body),
+                       0,
+                       0,
+                       dbesc($message_id),
+                       dbesc($parent_uri),
+                       dbesc($msg_created_at)
+               );                      
+
+               q("update conv set updated = '%s' where id = %d limit 1",
+                       dbesc(datetime_convert()),
+                       intval($conversation['id'])
+               );              
+
+               require_once('include/enotify.php');
+               notification(array(                     
+                       'type' => NOTIFY_MAIL,
+                       'notify_flags' => $importer['notify-flags'],
+                       'language' => $importer['language'],
+                       'to_name' => $importer['username'],
+                       'to_email' => $importer['email'],
+                       'uid' =>$importer['importer_uid'],
+                       'item' => array('subject' => $subject, 'body' => $body),
+                       'source_name' => $person['name'],
+                       'source_link' => $person['url'],
+                       'source_photo' => $person['thumb'],
+                       'verb' => ACTIVITY_POST,
+                       'otype' => 'mail'
+               ));
+       }       
+
+       return;
+}
+
+function diaspora_message($importer,$xml,$msg) {
+
+       $a = get_app();
+
+       $msg_guid = notags(unxmlify($xml->guid));
+       $msg_parent_guid = notags(unxmlify($xml->parent_guid));
+       $msg_parent_author_signature = notags(unxmlify($xml->parent_author_signature));
+       $msg_author_signature = notags(unxmlify($xml->author_signature));
+       $msg_text = unxmlify($xml->text);
+       $msg_created_at = datetime_convert('UTC','UTC',notags(unxmlify($xml->created_at)));
+       $msg_diaspora_handle = notags(unxmlify($xml->diaspora_handle));
+       $msg_conversation_guid = notags(unxmlify($xml->conversation_guid));
+
+       $parent_uri = $diaspora_handle . ':' . $msg_parent_guid;
+       $contact = diaspora_get_contact_by_handle($importer['uid'],$msg_diaspora_handle);
+       if(! $contact) {
+               logger('diaspora_message: cannot find contact: ' . $msg_diaspora_handle);
+               return;
+       }
+
+       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+               logger('diaspora_message: Ignoring this author.');
+               return 202;
+       }
+
+       $conversation = null;
+
+       $c = q("select * from conv where uid = %d and guid = '%s' limit 1",
+               intval($importer['uid']),
+               dbesc($msg_conversation_guid)
+       );
+       if(count($c))
+               $conversation = $c[0];
+       else {
+               logger('diaspora_message: conversation not available.');
+               return;
+       }
+
+       $reply = 0;
+                       
+       $body = diaspora2bb($msg_text);
+       $message_id = $msg_diaspora_handle . ':' . $msg_guid;
+
+       $author_signed_data = $msg_guid . ';' . $msg_parent_guid . ';' . $msg_text . ';' . unxmlify($xml->created_at) . ';' . $msg_diaspora_handle . ';' . $msg_conversation_guid;
+
+
+       $author_signature = base64_decode($msg_author_signature);
+
+       $person = find_diaspora_person_by_handle($msg_diaspora_handle); 
+       if(is_array($person) && x($person,'pubkey'))
+               $key = $person['pubkey'];
+       else {
+               logger('diaspora_message: unable to find author details');
+               return;
+       }
+
+       if(! rsa_verify($author_signed_data,$author_signature,$key,'sha256')) {
+               logger('diaspora_message: verification failed.');
+               return;
+       }
+
+       $r = q("select id from mail where `uri` = '%s' and uid = %d limit 1",
+               dbesc($message_id),
+               intval($importer['uid'])
+       );
+       if(count($r)) {
+               logger('diaspora_message: duplicate message already delivered.', LOGGER_DEBUG);
+               return;
+       }
+
+       q("insert into mail ( `uid`, `guid`, `convid`, `from-name`,`from-photo`,`from-url`,`contact-id`,`title`,`body`,`seen`,`reply`,`uri`,`parent-uri`,`created`) values ( %d, '%s', %d, '%s', '%s', '%s', %d, '%s', '%s', %d, %d, '%s','%s','%s')",
+               intval($importer['uid']),
+               dbesc($msg_guid),
+               intval($conversation['id']),
+               dbesc($person['name']),
+               dbesc($person['photo']),
+               dbesc($person['url']),
+               intval($contact['id']),  
+               dbesc($conversation['subject']),
+               dbesc($body),
+               0,
+               1,
+               dbesc($message_id),
+               dbesc($parent_uri),
+               dbesc($msg_created_at)
+       );                      
+
+       q("update conv set updated = '%s' where id = %d limit 1",
+               dbesc(datetime_convert()),
+               intval($conversation['id'])
+       );              
+       
+       return;
+}
+
+
 function diaspora_photo($importer,$xml,$msg) {
 
        $a = get_app();
+
+       logger('diaspora_photo: init',LOGGER_DEBUG);
+
        $remote_photo_path = notags(unxmlify($xml->remote_photo_path));
 
        $remote_photo_name = notags(unxmlify($xml->remote_photo_name));
@@ -1010,12 +1648,15 @@ function diaspora_photo($importer,$xml,$msg) {
 
        $created_at = notags(unxmlify($xml_created_at));
 
+       logger('diaspora_photo: status_message_guid: ' . $status_message_guid, LOGGER_DEBUG);
 
        $contact = diaspora_get_contact_by_handle($importer['uid'],$msg['author']);
-       if(! $contact)
+       if(! $contact) {
+               logger('diaspora_photo: contact record not found: ' . $msg['author'] . ' handle: ' . $diaspora_handle);
                return;
+       }
 
-       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+       if(! diaspora_post_allow($importer,$contact)) {
                logger('diaspora_photo: Ignoring this author.');
                return 202;
        }
@@ -1028,11 +1669,13 @@ function diaspora_photo($importer,$xml,$msg) {
                logger('diaspora_photo: parent item not found: parent: ' . $parent_guid . ' item: ' . $guid);
                return;
        }
+
        $parent_item = $r[0];
 
        $link_text = '[img]' . $remote_photo_path . $remote_photo_name . '[/img]' . "\n";
 
-       $link_text = scale_diaspora_images($link_text);
+       $link_text = scale_external_images($link_text, true,
+                                          array($remote_photo_name, 'scaled_full_' . $remote_photo_name));
 
        if(strpos($parent_item['body'],$link_text) === false) {
                $r = q("update item set `body` = '%s', `visible` = 1 where `id` = %d and `uid` = %d limit 1",
@@ -1062,8 +1705,8 @@ function diaspora_like($importer,$xml,$msg) {
 
        // likes on comments not supported here and likes on photos not supported by Diaspora
 
-       if($target_type !== 'Post')
-               return;
+//     if($target_type !== 'Post')
+//             return;
 
        $contact = diaspora_get_contact_by_handle($importer['uid'],$msg['author']);
        if(! $contact) {
@@ -1071,7 +1714,7 @@ function diaspora_like($importer,$xml,$msg) {
                return;
        }
 
-       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+       if(! diaspora_post_allow($importer,$contact)) {
                logger('diaspora_like: Ignoring this author.');
                return 202;
        }
@@ -1096,60 +1739,85 @@ function diaspora_like($importer,$xml,$msg) {
                        logger('diaspora_like: duplicate like: ' . $guid);
                        return;
                } 
+               // Note: I don't think "Like" objects with positive = "false" are ever actually used
+               // It looks like "RelayableRetractions" are used for "unlike" instead
                if($positive === 'false') {
-                       q("UPDATE `item` SET `deleted` = 1 WHERE `id` = %d AND `uid` = %d LIMIT 1",
+                       logger('diaspora_like: received a like with positive set to "false"...ignoring');
+/*                     q("UPDATE `item` SET `deleted` = 1 WHERE `id` = %d AND `uid` = %d LIMIT 1",
                                intval($r[0]['id']),
                                intval($importer['uid'])
-                       );
-                       // FIXME
+                       );*/
+                       // FIXME--actually don't unless it turns out that Diaspora does indeed send out "false" likes
                        //  send notification via proc_run()
                        return;
                }
        }
+       // Note: I don't think "Like" objects with positive = "false" are ever actually used
+       // It looks like "RelayableRetractions" are used for "unlike" instead
        if($positive === 'false') {
-               logger('diaspora_like: unlike received with no corresponding like');
+               logger('diaspora_like: received a like with positive set to "false"');
+               logger('diaspora_like: unlike received with no corresponding like...ignoring');
                return; 
        }
 
-       $author_signed_data = $guid . ';' . $target_type . ';' . $parent_guid . ';' . $positive . ';' . $diaspora_handle;
 
-       $author_signature = base64_decode($author_signature);
+       /* How Diaspora performs "like" signature checking:
 
-       if(strcasecmp($diaspora_handle,$msg['author']) == 0) {
-               $person = $contact;
-               $key = $msg['key'];
-       }
-       else {
-               $person = find_diaspora_person_by_handle($diaspora_handle);     
-               if(is_array($person) && x($person,'pubkey'))
-                       $key = $person['pubkey'];
-               else {
-                       logger('diaspora_like: unable to find author details');
-                       return;
-               }
-       }
+          - If an item has been sent by the like author to the top-level post owner to relay on
+            to the rest of the contacts on the top-level post, the top-level post owner should check
+            the author_signature, then create a parent_author_signature before relaying the like on
+          - If an item has been relayed on by the top-level post owner, the contacts who receive it
+            check only the parent_author_signature. Basically, they trust that the top-level post
+            owner has already verified the authenticity of anything he/she sends out
+          - In either case, the signature that get checked is the signature created by the person
+            who sent the salmon
+       */
 
-       if(! rsa_verify($author_signed_data,$author_signature,$key,'sha256')) {
-               logger('diaspora_like: verification failed.');
-               return;
-       }
+       $signed_data = $guid . ';' . $target_type . ';' . $parent_guid . ';' . $positive . ';' . $diaspora_handle;
+       $key = $msg['key'];
 
        if($parent_author_signature) {
-
-               $owner_signed_data = $guid . ';' . $target_type . ';' . $parent_guid . ';' . $positive . ';' . $diaspora_handle;
+               // If a parent_author_signature exists, then we've received the like
+               // relayed from the top-level post owner. There's no need to check the
+               // author_signature if the parent_author_signature is valid
 
                $parent_author_signature = base64_decode($parent_author_signature);
 
-               $key = $msg['key'];
+               if(! rsa_verify($signed_data,$parent_author_signature,$key,'sha256')) {
+                       logger('diaspora_like: top-level owner verification failed.');
+                       return;
+               }
+       }
+       else {
+               // If there's no parent_author_signature, then we've received the like
+               // from the like creator. In that case, the person is "like"ing
+               // our post, so he/she must be a contact of ours and his/her public key
+               // should be in $msg['key']
 
-               if(! rsa_verify($owner_signed_data,$parent_author_signature,$key,'sha256')) {
-                       logger('diaspora_like: owner verification failed.');
+               $author_signature = base64_decode($author_signature);
+
+               if(! rsa_verify($signed_data,$author_signature,$key,'sha256')) {
+                       logger('diaspora_like: like creator verification failed.');
                        return;
                }
        }
 
        // Phew! Everything checks out. Now create an item.
 
+       // Find the original comment author information.
+       // We need this to make sure we display the comment author
+       // information (name and avatar) correctly.
+       if(strcasecmp($diaspora_handle,$msg['author']) == 0)
+               $person = $contact;
+       else {
+               $person = find_diaspora_person_by_handle($diaspora_handle);
+
+               if(! is_array($person)) {
+                       logger('diaspora_like: unable to find author details');
+                       return;
+               }
+       }
+
        $uri = $diaspora_handle . ':' . $guid;
 
        $activity = ACTIVITY_LIKE;
@@ -1219,7 +1887,7 @@ EOT;
        if(! $parent_author_signature) {
                q("insert into sign (`iid`,`signed_text`,`signature`,`signer`) values (%d,'%s','%s','%s') ",
                        intval($message_id),
-                       dbesc($author_signed_data),
+                       dbesc($signed_data),
                        dbesc(base64_encode($author_signature)),
                        dbesc($diaspora_handle)
                );
@@ -1230,13 +1898,14 @@ EOT;
        // is already relaying. The parent_item['origin'] indicates the message was created on our system
 
        if(($parent_item['origin']) && (! $parent_author_signature))
-               proc_run('php','include/notifier.php','comment',$message_id);
+               proc_run('php','include/notifier.php','comment-import',$message_id);
 
        return;
 }
 
 function diaspora_retraction($importer,$xml) {
 
+
        $guid = notags(unxmlify($xml->guid));
        $diaspora_handle = notags(unxmlify($xml->diaspora_handle));
        $type = notags(unxmlify($xml->type));
@@ -1246,10 +1915,11 @@ function diaspora_retraction($importer,$xml) {
                return;
 
        if($type === 'Person') {
+               require_once('include/Contact.php');
                contact_remove($contact['id']);
        }
        elseif($type === 'Post') {
-               $r = q("select * from item where guid = '%s' and uid = %d limit 1",
+               $r = q("select * from item where guid = '%s' and uid = %d and not file like '%%[%%' limit 1",
                        dbesc('guid'),
                        intval($importer['uid'])
                );
@@ -1267,56 +1937,117 @@ function diaspora_retraction($importer,$xml) {
        // NOTREACHED
 }
 
-function diaspora_signed_retraction($importer,$xml) {
+function diaspora_signed_retraction($importer,$xml,$msg) {
+
 
        $guid = notags(unxmlify($xml->target_guid));
        $diaspora_handle = notags(unxmlify($xml->sender_handle));
        $type = notags(unxmlify($xml->target_type));
        $sig = notags(unxmlify($xml->target_author_signature));
 
+       $parent_author_signature = (($xml->parent_author_signature) ? notags(unxmlify($xml->parent_author_signature)) : '');
+
        $contact = diaspora_get_contact_by_handle($importer['uid'],$diaspora_handle);
-       if(! $contact)
+       if(! $contact) {
+               logger('diaspora_signed_retraction: no contact');
                return;
-
-       // this may not yet work for comments. Need to see how the relaying works
-       // and figure out who signs it.
+       }
 
 
        $signed_data = $guid . ';' . $type ;
+       $key = $msg['key'];
 
-       $sig = base64_decode($sig);
+       /* How Diaspora performs relayable_retraction signature checking:
 
-       $key = $msg['key'];
+          - If an item has been sent by the item author to the top-level post owner to relay on
+            to the rest of the contacts on the top-level post, the top-level post owner checks
+            the author_signature, then creates a parent_author_signature before relaying the item on
+          - If an item has been relayed on by the top-level post owner, the contacts who receive it
+            check only the parent_author_signature. Basically, they trust that the top-level post
+            owner has already verified the authenticity of anything he/she sends out
+          - In either case, the signature that get checked is the signature created by the person
+            who sent the salmon
+       */
+
+       if($parent_author_signature) {
+
+               $parent_author_signature = base64_decode($parent_author_signature);
+
+               if(! rsa_verify($signed_data,$parent_author_signature,$key,'sha256')) {
+                       logger('diaspora_signed_retraction: top-level post owner verification failed');
+                       return;
+               }
 
-       if(! rsa_verify($signed_data,$sig,$key,'sha256')) {
-               logger('diaspora_signed_retraction: owner verification failed.' . print_r($msg,true));
-               return;
        }
+       else {
 
-       if($type === 'StatusMessage') {
-               $r = q("select * from item where guid = '%s' and uid = %d limit 1",
-                       dbesc('guid'),
+               $sig_decode = base64_decode($sig);
+
+               if(! rsa_verify($signed_data,$sig_decode,$key,'sha256')) {
+                       logger('diaspora_signed_retraction: retraction owner verification failed.' . print_r($msg,true));
+                       return;
+               }
+       }
+
+       if($type === 'StatusMessage' || $type === 'Comment' || $type === 'Like') {
+               $r = q("select * from item where guid = '%s' and uid = %d and not file like '%%[%%' limit 1",
+                       dbesc($guid),
                        intval($importer['uid'])
                );
                if(count($r)) {
                        if(link_compare($r[0]['author-link'],$contact['url'])) {
-                               q("update item set `deleted` = 1, `changed` = '%s' where `id` = %d limit 1",
+                               q("update item set `deleted` = 1, `edited` = '%s', `changed` = '%s', `body` = '' , `title` = '' where `id` = %d limit 1",
+                                       dbesc(datetime_convert()),                      
                                        dbesc(datetime_convert()),                      
                                        intval($r[0]['id'])
                                );
+       
+                               // Now check if the retraction needs to be relayed by us
+                               //
+                               // The first item in the `item` table with the parent id is the parent. However, MySQL doesn't always
+                               // return the items ordered by `item`.`id`, in which case the wrong item is chosen as the parent.
+                               // The only item with `parent` and `id` as the parent id is the parent item.
+                               $p = q("select origin from item where parent = %d and id = %d limit 1",
+                                       $r[0]['parent'],
+                                       $r[0]['parent']
+                               );
+                               if(count($p)) {
+                                       if(($p[0]['origin']) && (! $parent_author_signature)) {
+                                               q("insert into sign (`retract_iid`,`signed_text`,`signature`,`signer`) values (%d,'%s','%s','%s') ",
+                                                       $r[0]['id'],
+                                                       dbesc($signed_data),
+                                                       dbesc($sig),
+                                                       dbesc($diaspora_handle)
+                                               );
+
+                                               // the existence of parent_author_signature would have meant the parent_author or owner
+                                               // is already relaying.
+                                               logger('diaspora_signed_retraction: relaying relayable_retraction');
+
+                                               proc_run('php','include/notifier.php','drop',$r[0]['id']);
+                                       }
+                               }
                        }
                }
        }
+       else
+               logger('diaspora_signed_retraction: unknown type: ' . $type);
 
        return 202;
        // NOTREACHED
 }
 
-function diaspora_profile($importer,$xml) {
+function diaspora_profile($importer,$xml,$msg) {
 
        $a = get_app();
        $diaspora_handle = notags(unxmlify($xml->diaspora_handle));
 
+
+       if($diaspora_handle != $msg['author']) {
+               logger('diaspora_post: Potential forgery. Message handle is not the same as envelope sender.');
+               return 202;
+       }
+
        $contact = diaspora_get_contact_by_handle($importer['uid'],$diaspora_handle);
        if(! $contact)
                return;
@@ -1346,6 +2077,15 @@ function diaspora_profile($importer,$xml) {
 
        $birthday = datetime_convert('UTC','UTC',$birthday,'Y-m-d');
 
+       // this is to prevent multiple birthday notifications in a single year
+       // if we already have a stored birthday and the 'm-d' part hasn't changed, preserve the entry, which will preserve the notify year
+
+       if(substr($birthday,5) === substr($contact['bd'],5))
+               $birthday = $contact['bd'];
+
+       // TODO: update name on item['author-name'] if the name changed. See consume_feed()
+       // Not doing this currently because D* protocol is scheduled for revision soon. 
+
        $r = q("UPDATE `contact` SET `name` = '%s', `name-date` = '%s', `photo` = '%s', `thumb` = '%s', `micro` = '%s', `avatar-date` = '%s' , `bd` = '%s' WHERE `id` = %d AND `uid` = %d LIMIT 1",
                dbesc($name),
                dbesc(datetime_convert()),
@@ -1374,27 +2114,6 @@ function diaspora_profile($importer,$xml) {
 
 }
 
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
 function diaspora_share($me,$contact) {
        $a = get_app();
        $myaddr = $me['nickname'] . '@' .  substr($a->get_baseurl(), strpos($a->get_baseurl(),'://') + 3);
@@ -1407,6 +2126,7 @@ function diaspora_share($me,$contact) {
        ));
 
        $slap = 'xml=' . urlencode(urlencode(diaspora_msg_build($msg,$me,$contact,$me['prvkey'],$contact['pubkey'])));
+       //$slap = 'xml=' . urlencode(diaspora_msg_build($msg,$me,$contact,$me['prvkey'],$contact['pubkey']));
 
        return(diaspora_transmit($owner,$contact,$slap, false));
 }
@@ -1424,13 +2144,13 @@ function diaspora_unshare($me,$contact) {
        ));
 
        $slap = 'xml=' . urlencode(urlencode(diaspora_msg_build($msg,$me,$contact,$me['prvkey'],$contact['pubkey'])));
+       //$slap = 'xml=' . urlencode(diaspora_msg_build($msg,$me,$contact,$me['prvkey'],$contact['pubkey']));
 
        return(diaspora_transmit($owner,$contact,$slap, false));
 
 }
 
 
-
 function diaspora_send_status($item,$owner,$contact,$public_batch = false) {
 
        $a = get_app();
@@ -1439,6 +2159,7 @@ function diaspora_send_status($item,$owner,$contact,$public_batch = false) {
 
        $images = array();
 
+       $title = $item['title'];
        $body = $item['body'];
 
 /*
@@ -1461,10 +2182,19 @@ function diaspora_send_status($item,$owner,$contact,$public_batch = false) {
                        $images[] = $detail;
                        $body = str_replace($detail['str'],$mtch[1],$body);
                }
-       }       
+       }
 */
 
+       //if(strlen($title))
+       //      $body = "[b]".html_entity_decode($title)."[/b]\n\n".$body;
+
+       // convert to markdown
        $body = xmlify(html_entity_decode(bb2diaspora($body)));
+       //$body = bb2diaspora($body);
+
+       // Adding the title
+       if(strlen($title))
+               $body = "## ".html_entity_decode($title)."\n\n".$body;
 
        if($item['attach']) {
                $cnt = preg_match_all('/href=\"(.*?)\"(.*?)title=\"(.*?)\"/ism',$item['attach'],$matches,PREG_SET_ORDER);
@@ -1494,6 +2224,7 @@ function diaspora_send_status($item,$owner,$contact,$public_batch = false) {
        logger('diaspora_send_status: ' . $owner['username'] . ' -> ' . $contact['name'] . ' base message: ' . $msg, LOGGER_DATA);
 
        $slap = 'xml=' . urlencode(urlencode(diaspora_msg_build($msg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],$public_batch)));
+       //$slap = 'xml=' . urlencode(diaspora_msg_build($msg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],$public_batch));
 
        $return_code = diaspora_transmit($owner,$contact,$slap,$public_batch);
 
@@ -1538,6 +2269,7 @@ function diaspora_send_images($item,$owner,$contact,$images,$public_batch = fals
 
                logger('diaspora_send_photo: base message: ' . $msg, LOGGER_DATA);
                $slap = 'xml=' . urlencode(urlencode(diaspora_msg_build($msg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],$public_batch)));
+               //$slap = 'xml=' . urlencode(diaspora_msg_build($msg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],$public_batch));
 
                diaspora_transmit($owner,$contact,$slap,$public_batch);
        }
@@ -1548,21 +2280,38 @@ function diaspora_send_followup($item,$owner,$contact,$public_batch = false) {
 
        $a = get_app();
        $myaddr = $owner['nickname'] . '@' .  substr($a->get_baseurl(), strpos($a->get_baseurl(),'://') + 3);
-       $theiraddr = $contact['addr'];
-
-       $p = q("select guid from item where parent = %d limit 1",
-               $item['parent']
-       );
+//     $theiraddr = $contact['addr'];
+
+       // Diaspora doesn't support threaded comments
+       /*if($item['thr-parent']) {
+               $p = q("select guid, type, uri, `parent-uri` from item where uri = '%s' limit 1",
+                       dbesc($item['thr-parent'])
+                     );
+       }
+       else {*/
+               // The first item in the `item` table with the parent id is the parent. However, MySQL doesn't always
+               // return the items ordered by `item`.`id`, in which case the wrong item is chosen as the parent.
+               // The only item with `parent` and `id` as the parent id is the parent item.
+               $p = q("select guid, type, uri, `parent-uri` from item where parent = %d and id = %d limit 1",
+                       intval($item['parent']),
+                       intval($item['parent'])
+               );
+       //}
        if(count($p))
-               $parent_guid = $p[0]['guid'];
+               $parent = $p[0];
        else
                return;
 
        if($item['verb'] === ACTIVITY_LIKE) {
                $tpl = get_markup_template('diaspora_like.tpl');
                $like = true;
-               $target_type = 'Post';
-               $positive = (($item['deleted']) ? 'false' : 'true');
+               $target_type = ( $parent['uri'] === $parent['parent-uri']  ? 'Post' : 'Comment');
+//             $target_type = (strpos($parent['type'], 'comment') ? 'Comment' : 'Post');
+//             $positive = (($item['deleted']) ? 'false' : 'true');
+               $positive = 'true';
+
+               if(($item['deleted']))
+                       logger('diaspora_send_followup: received deleted "like". Those should go to diaspora_send_retraction');
        }
        else {
                $tpl = get_markup_template('diaspora_comment.tpl');
@@ -1574,15 +2323,15 @@ function diaspora_send_followup($item,$owner,$contact,$public_batch = false) {
        // sign it
 
        if($like)
-               $signed_text = $item['guid'] . ';' . $target_type . ';' . $parent_guid . ';' . $positive . ';' . $myaddr;
+               $signed_text = $item['guid'] . ';' . $target_type . ';' . $parent['guid'] . ';' . $positive . ';' . $myaddr;
        else
-               $signed_text = $item['guid'] . ';' . $parent_guid . ';' . $text . ';' . $myaddr;
+               $signed_text = $item['guid'] . ';' . $parent['guid'] . ';' . $text . ';' . $myaddr;
 
        $authorsig = base64_encode(rsa_sign($signed_text,$owner['uprvkey'],'sha256'));
 
        $msg = replace_macros($tpl,array(
                '$guid' => xmlify($item['guid']),
-               '$parent_guid' => xmlify($parent_guid),
+               '$parent_guid' => xmlify($parent['guid']),
                '$target_type' =>xmlify($target_type),
                '$authorsig' => xmlify($authorsig),
                '$body' => xmlify($text),
@@ -1593,6 +2342,7 @@ function diaspora_send_followup($item,$owner,$contact,$public_batch = false) {
        logger('diaspora_followup: base message: ' . $msg, LOGGER_DATA);
 
        $slap = 'xml=' . urlencode(urlencode(diaspora_msg_build($msg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],$public_batch)));
+       //$slap = 'xml=' . urlencode(diaspora_msg_build($msg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],$public_batch));
 
        return(diaspora_transmit($owner,$contact,$slap,$public_batch));
 }
@@ -1602,41 +2352,61 @@ function diaspora_send_relay($item,$owner,$contact,$public_batch = false) {
 
 
        $a = get_app();
-       $myaddr = $owner['nickname'] . '@' .  substr($a->get_baseurl(), strpos($a->get_baseurl(),'://') + 3);
-       $theiraddr = $contact['addr'];
+       $myaddr = $owner['nickname'] . '@' . substr($a->get_baseurl(), strpos($a->get_baseurl(),'://') + 3);
+//     $theiraddr = $contact['addr'];
 
+       $body = $item['body'];
+       $text = html_entity_decode(bb2diaspora($body));
 
-       $p = q("select guid from item where parent = %d limit 1",
-               $item['parent']
-       );
+       // Diaspora doesn't support threaded comments
+       /*if($item['thr-parent']) {
+               $p = q("select guid, type, uri, `parent-uri` from item where uri = '%s' limit 1",
+                       dbesc($item['thr-parent'])
+                     );
+       }
+       else {*/
+               // The first item in the `item` table with the parent id is the parent. However, MySQL doesn't always
+               // return the items ordered by `item`.`id`, in which case the wrong item is chosen as the parent.
+               // The only item with `parent` and `id` as the parent id is the parent item.
+               $p = q("select guid, type, uri, `parent-uri` from item where parent = %d and id = %d limit 1",
+                      intval($item['parent']),
+                      intval($item['parent'])
+                     );
+       //}
        if(count($p))
-               $parent_guid = $p[0]['guid'];
+               $parent = $p[0];
        else
                return;
 
-       if($item['verb'] === ACTIVITY_LIKE) {
-               $tpl = get_markup_template('diaspora_like_relay.tpl');
+       $like = false;
+       $relay_retract = false;
+       $sql_sign_id = 'iid';
+       if( $item['deleted']) {
+               $relay_retract = true;
+
+               $target_type = ( ($item['verb'] === ACTIVITY_LIKE) ? 'Like' : 'Comment');
+
+               $sql_sign_id = 'retract_iid';
+               $tpl = get_markup_template('diaspora_relayable_retraction.tpl');
+       }
+       elseif($item['verb'] === ACTIVITY_LIKE) {
                $like = true;
-               $target_type = 'Post';
-               $positive = (($item['deleted']) ? 'false' : 'true');
+
+               $target_type = ( $parent['uri'] === $parent['parent-uri']  ? 'Post' : 'Comment');
+//             $positive = (($item['deleted']) ? 'false' : 'true');
+               $positive = 'true';
+
+               $tpl = get_markup_template('diaspora_like_relay.tpl');
        }
-       else {
+       else { // item is a comment
                $tpl = get_markup_template('diaspora_comment_relay.tpl');
-               $like = false;
        }
 
-       $body = $item['body'];
 
-       $text = html_entity_decode(bb2diaspora($body));
+       // fetch the original signature if the relayable was created by a Diaspora
+       // or DFRN user. Relayables for other networks are not supported.
 
-       // fetch the original signature if somebody sent the post to us to relay
-       // If we are relaying for a reply originating on our own account, there wasn't a 'send to relay'
-       // action. It wasn't needed. In that case create the original signature and the 
-       // owner (parent author) signature
-       // comments from other networks will be relayed under our name, with a brief 
-       // preamble to describe what's happening and noting the real author
-
-       $r = q("select * from sign where iid = %d limit 1",
+/*     $r = q("select * from sign where " . $sql_sign_id . " = %d limit 1",
                intval($item['id'])
        );
        if(count($r)) { 
@@ -1647,54 +2417,67 @@ function diaspora_send_relay($item,$owner,$contact,$public_batch = false) {
        }
        else {
 
-               $itemcontact = q("select * from contact where `id` = %d limit 1",
-                       intval($item['contact-id'])
-               );
-               if(count($itemcontact)) {
-                       if(! $itemcontact[0]['self']) {
-                               $prefix = sprintf( t('[Relayed] Comment authored by %s from network %s'),
-                                       '['. $item['author-name'] . ']' . '(' . $item['author-link'] . ')',  
-                                       network_to_name($itemcontact['network'])) . "\n";
-                               $body = $prefix . $body;
-                       }
-               }
-               else {
-
-                       if($like)
-                               $signed_text = $item['guid'] . ';' . $target_type . ';' . $parent_guid . ';' . $positive . ';' . $myaddr;
-                       else
-                               $signed_text = $item['guid'] . ';' . $parent_guid . ';' . $text . ';' . $myaddr;
+               // Author signature information (for likes, comments, and retractions of likes or comments,
+               // whether from Diaspora or Friendica) must be placed in the `sign` table before this 
+               // function is called
+               logger('diaspora_send_relay: original author signature not found, cannot send relayable');
+               return;
+       }*/
+
+       /* Since the author signature is only checked by the parent, not by the relay recipients,
+        * I think it may not be necessary for us to do so much work to preserve all the original
+        * signatures. The important thing that Diaspora DOES need is the original creator's handle.
+        * Let's just generate that and forget about all the original author signature stuff.
+        *
+        * Note: this might be more of an problem if we want to support likes on comments for older
+        * versions of Diaspora (diaspora-pistos), but since there are a number of problems with
+        * doing that, let's ignore it for now.
+        *
+        * Currently, only DFRN contacts are supported. StatusNet shouldn't be hard, but it hasn't
+        * been done yet
+        */
+
+       $handle = diaspora_handle_from_contact($item['contact-id']);
+       if(! $handle)
+               return;
 
-                       $authorsig = base64_encode(rsa_sign($signed_text,$owner['uprvkey'],'sha256'));
 
-                       q("insert into sign (`iid`,`signed_text`,`signature`,`signer`) values (%d,'%s','%s','%s') ",
-                               intval($item['id']),
-                               dbesc($signed_text),
-                               dbesc(base64_encode($authorsig)),
-                               dbesc($myaddr)
-                       );
-                       $handle = $myaddr;
-               }
-       }
+       if($relay_retract)
+               $sender_signed_text = $item['guid'] . ';' . $target_type;
+       elseif($like)
+               $sender_signed_text = $item['guid'] . ';' . $target_type . ';' . $parent['guid'] . ';' . $positive . ';' . $handle;
+       else
+               $sender_signed_text = $item['guid'] . ';' . $parent['guid'] . ';' . $text . ';' . $handle;
 
-       // sign it
+       // Sign the relayable with the top-level owner's signature
+       //
+       // We'll use the $sender_signed_text that we just created, instead of the $signed_text
+       // stored in the database, because that provides the best chance that Diaspora will
+       // be able to reconstruct the signed text the same way we did. This is particularly a
+       // concern for the comment, whose signed text includes the text of the comment. The
+       // smallest change in the text of the comment, including removing whitespace, will
+       // make the signature verification fail. Since we translate from BB code to Diaspora's
+       // markup at the top of this function, which is AFTER we placed the original $signed_text
+       // in the database, it's hazardous to trust the original $signed_text.
 
-       $parentauthorsig = base64_encode(rsa_sign($signed_text,$owner['uprvkey'],'sha256'));
+       $parentauthorsig = base64_encode(rsa_sign($sender_signed_text,$owner['uprvkey'],'sha256'));
 
        $msg = replace_macros($tpl,array(
                '$guid' => xmlify($item['guid']),
-               '$parent_guid' => xmlify($parent_guid),
+               '$parent_guid' => xmlify($parent['guid']),
                '$target_type' =>xmlify($target_type),
-               '$authorsig' => xmlify($orig_sign['signature']),
+               '$authorsig' => xmlify($authorsig),
                '$parentsig' => xmlify($parentauthorsig),
                '$body' => xmlify($text),
                '$positive' => xmlify($positive),
                '$handle' => xmlify($handle)
        ));
 
-       logger('diaspora_relay_comment: base message: ' . $msg, LOGGER_DATA);
+       logger('diaspora_send_relay: base message: ' . $msg, LOGGER_DATA);
+
 
        $slap = 'xml=' . urlencode(urlencode(diaspora_msg_build($msg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],$public_batch)));
+       //$slap = 'xml=' . urlencode(diaspora_msg_build($msg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],$public_batch));
 
        return(diaspora_transmit($owner,$contact,$slap,$public_batch));
 
@@ -1707,24 +2490,102 @@ function diaspora_send_retraction($item,$owner,$contact,$public_batch = false) {
        $a = get_app();
        $myaddr = $owner['nickname'] . '@' .  substr($a->get_baseurl(), strpos($a->get_baseurl(),'://') + 3);
 
-       $signed_text = $item['guid'] . ';' . 'StatusMessage';
+       // Check whether the retraction is for a top-level post or whether it's a relayable
+       if( $item['uri'] !== $item['parent-uri'] ) {
+
+               $tpl = get_markup_template('diaspora_relay_retraction.tpl');
+               $target_type = (($item['verb'] === ACTIVITY_LIKE) ? 'Like' : 'Comment');
+       }
+       else {
+               
+               $tpl = get_markup_template('diaspora_signed_retract.tpl');
+               $target_type = 'StatusMessage';
+       }
+
+       $signed_text = $item['guid'] . ';' . $target_type;
 
-       $tpl = get_markup_template('diaspora_signed_retract.tpl');
        $msg = replace_macros($tpl, array(
-               '$guid'   => $item['guid'],
-               '$type'   => 'StatusMessage',
-               '$handle' => $myaddr,
-               '$signature' => base64_encode(rsa_sign($signed_text,$owner['uprvkey'],'sha256'))
+               '$guid'   => xmlify($item['guid']),
+               '$type'   => xmlify($target_type),
+               '$handle' => xmlify($myaddr),
+               '$signature' => xmlify(base64_encode(rsa_sign($signed_text,$owner['uprvkey'],'sha256')))
        ));
 
        $slap = 'xml=' . urlencode(urlencode(diaspora_msg_build($msg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],$public_batch)));
+       //$slap = 'xml=' . urlencode(diaspora_msg_build($msg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],$public_batch));
 
        return(diaspora_transmit($owner,$contact,$slap,$public_batch));
 }
 
+function diaspora_send_mail($item,$owner,$contact) {
+
+       $a = get_app();
+       $myaddr = $owner['nickname'] . '@' .  substr($a->get_baseurl(), strpos($a->get_baseurl(),'://') + 3);
+
+       $r = q("select * from conv where id = %d and uid = %d limit 1",
+               intval($item['convid']),
+               intval($item['uid'])
+       );
+
+       if(! count($r)) {
+               logger('diaspora_send_mail: conversation not found.');
+               return;
+       }
+       $cnv = $r[0];
+
+       $conv = array(
+               'guid' => xmlify($cnv['guid']),
+               'subject' => xmlify($cnv['subject']),
+               'created_at' => xmlify(datetime_convert('UTC','UTC',$cnv['created'],'Y-m-d H:i:s \U\T\C')),
+               'diaspora_handle' => xmlify($cnv['creator']),
+               'participant_handles' => xmlify($cnv['recips'])
+       );
+
+       $body = bb2diaspora($item['body']);
+       $created = datetime_convert('UTC','UTC',$item['created'],'Y-m-d H:i:s \U\T\C');
+       $signed_text =  $item['guid'] . ';' . $cnv['guid'] . ';' . $body .  ';' 
+               . $created . ';' . $myaddr . ';' . $cnv['guid'];
+
+       $sig = base64_encode(rsa_sign($signed_text,$owner['uprvkey'],'sha256'));
+
+       $msg = array(
+               'guid' => xmlify($item['guid']),
+               'parent_guid' => xmlify($cnv['guid']),
+               'parent_author_signature' => (($item['reply']) ? null : xmlify($sig)),
+               'author_signature' => xmlify($sig),
+               'text' => xmlify($body),
+               'created_at' => xmlify($created),
+               'diaspora_handle' => xmlify($myaddr),
+               'conversation_guid' => xmlify($cnv['guid'])
+       );
+
+       if($item['reply']) {
+               $tpl = get_markup_template('diaspora_message.tpl');
+               $xmsg = replace_macros($tpl, array('$msg' => $msg));
+       }
+       else {
+               $conv['messages'] = array($msg);
+               $tpl = get_markup_template('diaspora_conversation.tpl');
+               $xmsg = replace_macros($tpl, array('$conv' => $conv));
+       }
+
+       logger('diaspora_conversation: ' . print_r($xmsg,true), LOGGER_DATA);
+
+       $slap = 'xml=' . urlencode(urlencode(diaspora_msg_build($xmsg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],false)));
+       //$slap = 'xml=' . urlencode(diaspora_msg_build($xmsg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],false));
+
+       return(diaspora_transmit($owner,$contact,$slap,false));
 
 
-function diaspora_transmit($owner,$contact,$slap,$public_batch) {
+}
+
+function diaspora_transmit($owner,$contact,$slap,$public_batch,$queue_run=false) {
+
+       $enabled = intval(get_config('system','diaspora_enabled'));
+       if(! $enabled) {
+               return 200;
+       }
 
        $a = get_app();
        $logid = random_string(4);
@@ -1736,9 +2597,20 @@ function diaspora_transmit($owner,$contact,$slap,$public_batch) {
 
        logger('diaspora_transmit: ' . $logid . ' ' . $dest_url);
 
-       post_url($dest_url . '/', $slap);
-
-       $return_code = $a->get_curl_code();
+       if( (! $queue_run) && (was_recently_delayed($contact['id'])) ) {
+               $return_code = 0;
+       }
+       else {
+               if(! intval(get_config('system','diaspora_test'))) {
+                       post_url($dest_url . '/', $slap);
+                       $return_code = $a->get_curl_code();
+               }
+               else {
+                       logger('diaspora_transmit: test_mode');
+                       return 200;
+               }
+       }
+       
        logger('diaspora_transmit: ' . $logid . ' returns: ' . $return_code);
 
        if((! $return_code) || (($return_code == 503) && (stristr($a->get_curl_headers(),'retry-after')))) {
@@ -1762,3 +2634,5 @@ function diaspora_transmit($owner,$contact,$slap,$public_batch) {
 
        return(($return_code) ? $return_code : (-1));
 }
+
+