]> git.mxchange.org Git - friendica.git/blobdiff - include/diaspora.php
bug in check for private email comment to public conversation prevents authenticated...
[friendica.git] / include / diaspora.php
old mode 100644 (file)
new mode 100755 (executable)
index 3645765..dca857a
@@ -41,6 +41,9 @@ function diaspora_dispatch($importer,$msg) {
 
        $xmlbase = $parsed_xml->post;
 
+       logger('diaspora_dispatch: ' . print_r($xmlbase,true), LOGGER_DEBUG);
+
+
        if($xmlbase->request) {
                $ret = diaspora_request($importer,$xmlbase->request);
        }
@@ -66,11 +69,17 @@ function diaspora_dispatch($importer,$msg) {
                $ret = diaspora_retraction($importer,$xmlbase->retraction,$msg);
        }
        elseif($xmlbase->signed_retraction) {
-               $ret = diaspora_signed_retraction($importer,$xmlbase->retraction,$msg);
+               $ret = diaspora_signed_retraction($importer,$xmlbase->signed_retraction,$msg);
        }
        elseif($xmlbase->photo) {
                $ret = diaspora_photo($importer,$xmlbase->photo,$msg);
        }
+       elseif($xmlbase->conversation) {
+               $ret = diaspora_conversation($importer,$xmlbase->conversation,$msg);
+       }
+       elseif($xmlbase->message) {
+               $ret = diaspora_message($importer,$xmlbase->message,$msg);
+       }
        else {
                logger('diaspora_dispatch: unknown message type: ' . print_r($xmlbase,true));
        }
@@ -179,6 +188,13 @@ function diaspora_msg_build($msg,$user,$contact,$prvkey,$pubkey,$public = false)
 
        logger('diaspora_msg_build: ' . $msg, LOGGER_DATA);
 
+       // without a public key nothing will work
+
+       if(! $pubkey) {
+               logger('diaspora_msg_build: pubkey missing: contact id: ' . $contact['id']);
+               return '';
+       }
+
        $inner_aes_key = random_string(32);
        $b_inner_aes_key = base64_encode($inner_aes_key);
        $inner_iv = random_string(16);
@@ -435,7 +451,7 @@ function diaspora_request($importer,$xml) {
                // perhaps we were already sharing with this person. Now they're sharing with us.
                // That makes us friends.
 
-               if($contact['rel'] == CONTACT_IS_FOLLOWER) {
+               if($contact['rel'] == CONTACT_IS_FOLLOWER && $importer['page-flags'] != PAGE_COMMUNITY) {
                        q("UPDATE `contact` SET `rel` = %d, `writable` = 1 WHERE `id` = %d AND `uid` = %d LIMIT 1",
                                intval(CONTACT_IS_FRIEND),
                                intval($contact['id']),
@@ -448,7 +464,7 @@ function diaspora_request($importer,$xml) {
                        intval($importer['uid'])
                );
 
-               if((count($r)) && ($r[0]['hide-friends'] == 0)) {
+               if((count($r)) && (! $r[0]['hide-friends']) && (! $contact['hidden'])) {
                        require_once('include/items.php');
 
                        $self = q("SELECT * FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1",
@@ -511,6 +527,8 @@ function diaspora_request($importer,$xml) {
 
        $batch = (($ret['batch']) ? $ret['batch'] : implode('/', array_slice(explode('/',$ret['url']),0,3)) . '/receive/public');
 
+
+
        $r = q("INSERT INTO `contact` (`uid`, `network`,`addr`,`created`,`url`,`nurl`,`batch`,`name`,`nick`,`photo`,`pubkey`,`notify`,`poll`,`blocked`,`priority`)
                VALUES ( %d, '%s', '%s', '%s', '%s','%s','%s','%s','%s','%s','%s','%s','%s',%d,%d) ",
                intval($importer['uid']),
@@ -534,9 +552,15 @@ function diaspora_request($importer,$xml) {
 
        $contact_record = diaspora_get_contact_by_handle($importer['uid'],$sender_handle);
 
-       $hash = random_string() . (string) time();   // Generate a confirm_key
+       if(! $contact_record) {
+               logger('diaspora_request: unable to locate newly created contact record.');
+               return;
+       }
+
+       if($importer['page-flags'] == PAGE_NORMAL) {
+
+               $hash = random_string() . (string) time();   // Generate a confirm_key
        
-       if($contact_record) {
                $ret = q("INSERT INTO `intro` ( `uid`, `contact-id`, `blocked`, `knowyou`, `note`, `hash`, `datetime` )
                        VALUES ( %d, %d, %d, %d, '%s', '%s', '%s' )",
                        intval($importer['uid']),
@@ -548,10 +572,65 @@ function diaspora_request($importer,$xml) {
                        dbesc(datetime_convert())
                );
        }
+       else {
+
+               // automatic friend approval
+
+               require_once('include/Photo.php');
+
+               $photos = import_profile_photo($contact_record['photo'],$importer['uid'],$contact_record['id']);
+               
+               // technically they are sharing with us (CONTACT_IS_SHARING), 
+               // but if our page-type is PAGE_COMMUNITY or PAGE_SOAPBOX
+               // we are going to change the relationship and make them a follower.
+
+               if($importer['page-flags'] == PAGE_FREELOVE)
+                       $new_relation = CONTACT_IS_FRIEND;
+               else
+                       $new_relation = CONTACT_IS_FOLLOWER;
+
+               $r = q("UPDATE `contact` SET 
+                       `photo` = '%s', 
+                       `thumb` = '%s',
+                       `micro` = '%s', 
+                       `rel` = %d, 
+                       `name-date` = '%s', 
+                       `uri-date` = '%s', 
+                       `avatar-date` = '%s', 
+                       `blocked` = 0, 
+                       `pending` = 0
+                       WHERE `id` = %d LIMIT 1
+                       ",
+                       dbesc($photos[0]),
+                       dbesc($photos[1]),
+                       dbesc($photos[2]),
+                       intval($new_relation),
+                       dbesc(datetime_convert()),
+                       dbesc(datetime_convert()),
+                       dbesc(datetime_convert()),
+                       intval($contact_record['id'])
+               );
+
+               $u = q("select * from user where uid = %d limit 1",intval($importer['uid']));
+               if($u)
+                       $ret = diaspora_share($u[0],$contact_record);
+       }
 
        return;
 }
 
+function diaspora_post_allow($importer,$contact) {
+       if(($contact['blocked']) || ($contact['readonly']))
+               return false;
+       if($contact['rel'] == CONTACT_IS_SHARING || $contact['rel'] == CONTACT_IS_FRIEND)
+               return true;
+       if($contact['rel'] == CONTACT_IS_FOLLOWER)
+               if($importer['page-flags'] == PAGE_COMMUNITY)
+                       return true;
+       return false;
+}
+
+
 function diaspora_post($importer,$xml) {
 
        $a = get_app();
@@ -562,7 +641,7 @@ function diaspora_post($importer,$xml) {
        if(! $contact)
                return;
 
-       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+       if(! diaspora_post_allow($importer,$contact)) {
                logger('diaspora_post: Ignoring this author.');
                return 202;
        }
@@ -606,6 +685,14 @@ function diaspora_post($importer,$xml) {
                        if(strpos($tag,'#') === 0) {
                                if(strpos($tag,'[url='))
                                        continue;
+
+                               // don't link tags that are already embedded in links
+
+                               if(preg_match('/\[(.*?)' . preg_quote($tag) . '(.*?)\]/',$body))
+                                       continue;
+                               if(preg_match('/\[(.*?)\]\((.*?)' . preg_quote($tag) . '(.*?)\)/',$body))
+                                       continue;
+
                                $basetag = str_replace('_',' ',substr($tag,1));
                                $body = str_replace($tag,'#[url=' . $a->get_baseurl() . '/search?search=' . rawurlencode($basetag) . ']' . $basetag . '[/url]',$body);
                                if(strlen($str_tags))
@@ -615,7 +702,16 @@ function diaspora_post($importer,$xml) {
                        }
                }
        }
-       
+
+       $cnt = preg_match_all('/@\[url=(.*?)\[\/url\]/ism',$body,$matches,PREG_SET_ORDER);
+       if($cnt) {
+               foreach($matches as $mtch) {
+                       if(strlen($str_tags))
+                               $str_tags .= ',';
+                       $str_tags .= '@[url=' . $mtch[1] . '[/url]';    
+               }
+       }
+
        $datarray['uid'] = $importer['uid'];
        $datarray['contact-id'] = $contact['id'];
        $datarray['wall'] = 0;
@@ -664,7 +760,7 @@ function diaspora_reshare($importer,$xml) {
        if(! $contact)
                return;
 
-       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+       if(! diaspora_post_allow($importer,$contact)) {
                logger('diaspora_reshare: Ignoring this author: ' . $diaspora_handle . ' ' . print_r($xml,true));
                return 202;
        }
@@ -698,15 +794,15 @@ function diaspora_reshare($importer,$xml) {
 
        if(strlen($source_xml->post->asphoto->objectId) && ($source_xml->post->asphoto->objectId != 0) && ($source_xml->post->asphoto->image_url)) {
                $body = '[url=' . notags(unxmlify($source_xml->post->asphoto->image_url)) . '][img]' . notags(unxmlify($source_xml->post->asphoto->objectId)) . '[/img][/url]' . "\n";
-               $body = scale_diaspora_images($body,false);
+               $body = scale_external_images($body,false);
        }
        elseif($source_xml->post->asphoto->image_url) {
                $body = '[img]' . notags(unxmlify($source_xml->post->asphoto->image_url)) . '[/img]' . "\n";
-               $body = scale_diaspora_images($body);
+               $body = scale_external_images($body);
        }
        elseif($source_xml->post->status_message) {
                $body = diaspora2bb($source_xml->post->status_message->raw_message);
-               $body = scale_diaspora_images($body);
+               $body = scale_external_images($body);
 
        }
        else {
@@ -754,6 +850,15 @@ function diaspora_reshare($importer,$xml) {
                        if(strpos($tag,'#') === 0) {
                                if(strpos($tag,'[url='))
                                        continue;
+
+                               // don't link tags that are already embedded in links
+
+                               if(preg_match('/\[(.*?)' . preg_quote($tag) . '(.*?)\]/',$body))
+                                       continue;
+                               if(preg_match('/\[(.*?)\]\((.*?)' . preg_quote($tag) . '(.*?)\)/',$body))
+                                       continue;
+
+
                                $basetag = str_replace('_',' ',substr($tag,1));
                                $body = str_replace($tag,'#[url=' . $a->get_baseurl() . '/search?search=' . rawurlencode($basetag) . ']' . $basetag . '[/url]',$body);
                                if(strlen($str_tags))
@@ -807,7 +912,7 @@ function diaspora_asphoto($importer,$xml) {
        if(! $contact)
                return;
 
-       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+       if(! diaspora_post_allow($importer,$contact)) {
                logger('diaspora_asphoto: Ignoring this author.');
                return 202;
        }
@@ -840,11 +945,11 @@ function diaspora_asphoto($importer,$xml) {
 
        if(strlen($xml->objectId) && ($xml->objectId != 0) && ($xml->image_url)) {
                $body = '[url=' . notags(unxmlify($xml->image_url)) . '][img]' . notags(unxmlify($xml->objectId)) . '[/img][/url]' . "\n";
-               $body = scale_diaspora_images($body,false);
+               $body = scale_external_images($body,false);
        }
        elseif($xml->image_url) {
                $body = '[img]' . notags(unxmlify($xml->image_url)) . '[/img]' . "\n";
-               $body = scale_diaspora_images($body);
+               $body = scale_external_images($body);
        }
        else {
                logger('diaspora_asphoto: no photo url found.');
@@ -902,15 +1007,13 @@ function diaspora_comment($importer,$xml,$msg) {
 
        $parent_author_signature = (($xml->parent_author_signature) ? notags(unxmlify($xml->parent_author_signature)) : '');
 
-       $text = $xml->text;
-
        $contact = diaspora_get_contact_by_handle($importer['uid'],$msg['author']);
        if(! $contact) {
                logger('diaspora_comment: cannot find contact: ' . $msg['author']);
                return;
        }
 
-       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+       if(! diaspora_post_allow($importer,$contact)) {
                logger('diaspora_comment: Ignoring this author.');
                return 202;
        }
@@ -988,6 +1091,15 @@ function diaspora_comment($importer,$xml,$msg) {
                        if(strpos($tag,'#') === 0) {
                                if(strpos($tag,'[url='))
                                        continue;
+
+                               // don't link tags that are already embedded in links
+
+                               if(preg_match('/\[(.*?)' . preg_quote($tag) . '(.*?)\]/',$body))
+                                       continue;
+                               if(preg_match('/\[(.*?)\]\((.*?)' . preg_quote($tag) . '(.*?)\)/',$body))
+                                       continue;
+
+
                                $basetag = str_replace('_',' ',substr($tag,1));
                                $body = str_replace($tag,'#[url=' . $a->get_baseurl() . '/search?search=' . rawurlencode($basetag) . ']' . $basetag . '[/url]',$body);
                                if(strlen($str_tags))
@@ -1050,9 +1162,280 @@ function diaspora_comment($importer,$xml,$msg) {
        return;
 }
 
+
+
+
+function diaspora_conversation($importer,$xml,$msg) {
+
+       $a = get_app();
+
+       $guid = notags(unxmlify($xml->guid));
+       $subject = notags(unxmlify($xml->subject));
+       $diaspora_handle = notags(unxmlify($xml->diaspora_handle));
+       $participant_handles = notags(unxmlify($xml->participant_handles));
+       $created_at = datetime_convert('UTC','UTC',notags(unxmlify($xml->created_at)));
+
+       $parent_uri = $diaspora_handle . ':' . $guid;
+       $messages = $xml->message;
+
+       if(! count($messages)) {
+               logger('diaspora_conversation: empty conversation');
+               return;
+       }
+
+       $contact = diaspora_get_contact_by_handle($importer['uid'],$msg['author']);
+       if(! $contact) {
+               logger('diaspora_conversation: cannot find contact: ' . $msg['author']);
+               return;
+       }
+
+       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+               logger('diaspora_conversation: Ignoring this author.');
+               return 202;
+       }
+
+       $conversation = null;
+
+       $c = q("select * from conv where uid = %d and guid = '%s' limit 1",
+               intval($importer['uid']),
+               dbesc($guid)
+       );
+       if(count($c))
+               $conversation = $c[0];
+       else {
+               $r = q("insert into conv (uid,guid,creator,created,updated,subject,recips) values(%d, '%s', '%s', '%s', '%s', '%s', '%s') ",
+                       intval($importer['uid']),
+                       dbesc($guid),
+                       dbesc($diaspora_handle),
+                       dbesc(datetime_convert('UTC','UTC',$created_at)),
+                       dbesc(datetime_convert()),
+                       dbesc($subject),
+                       dbesc($participant_handles)
+               );
+               if($r)
+                       $c = q("select * from conv where uid = %d and guid = '%s' limit 1",
+               intval($importer['uid']),
+           dbesc($guid)
+       );
+           if(count($c))
+           $conversation = $c[0];
+       }
+       if(! $conversation) {
+               logger('diaspora_conversation: unable to create conversation.');
+               return;
+       }
+
+       foreach($messages as $mesg) {
+
+               $reply = 0;
+
+               $msg_guid = notags(unxmlify($mesg->guid));
+               $msg_parent_guid = notags(unxmlify($mesg->parent_guid));
+               $msg_parent_author_signature = notags(unxmlify($mesg->parent_author_signature));
+               $msg_author_signature = notags(unxmlify($mesg->author_signature));
+               $msg_text = unxmlify($mesg->text);
+               $msg_created_at = datetime_convert('UTC','UTC',notags(unxmlify($mesg->created_at)));
+               $msg_diaspora_handle = notags(unxmlify($mesg->diaspora_handle));
+               $msg_conversation_guid = notags(unxmlify($mesg->conversation_guid));
+               if($msg_conversation_guid != $guid) {
+                       logger('diaspora_conversation: message conversation guid does not belong to the current conversation. ' . $xml);
+                       continue;
+               }
+
+               $body = diaspora2bb($msg_text);
+               $message_id = $msg_diaspora_handle . ':' . $msg_guid;
+
+               $author_signed_data = $msg_guid . ';' . $msg_parent_guid . ';' . $msg_text . ';' . unxmlify($mesg->created_at) . ';' . $msg_diaspora_handle . ';' . $msg_conversation_guid;
+
+               $author_signature = base64_decode($msg_author_signature);
+
+               if(strcasecmp($msg_diaspora_handle,$msg['author']) == 0) {
+                       $person = $contact;
+                       $key = $msg['key'];
+               }
+               else {
+                       $person = find_diaspora_person_by_handle($msg_diaspora_handle); 
+
+                       if(is_array($person) && x($person,'pubkey'))
+                               $key = $person['pubkey'];
+                       else {
+                               logger('diaspora_conversation: unable to find author details');
+                               continue;
+                       }
+               }
+
+               if(! rsa_verify($author_signed_data,$author_signature,$key,'sha256')) {
+                       logger('diaspora_conversation: verification failed.');
+                       continue;
+               }
+
+               if($msg_parent_author_signature) {
+                       $owner_signed_data = $msg_guid . ';' . $msg_parent_guid . ';' . $msg_text . ';' . unxmlify($mesg->created_at) . ';' . $msg_diaspora_handle . ';' . $msg_conversation_guid;
+
+                       $parent_author_signature = base64_decode($msg_parent_author_signature);
+
+                       $key = $msg['key'];
+
+                       if(! rsa_verify($owner_signed_data,$parent_author_signature,$key,'sha256')) {
+                               logger('diaspora_conversation: owner verification failed.');
+                               continue;
+                       }
+               }
+
+               $r = q("select id from mail where `uri` = '%s' limit 1",
+                       dbesc($message_id)
+               );
+               if(count($r)) {
+                       logger('diaspora_conversation: duplicate message already delivered.', LOGGER_DEBUG);
+                       continue;
+               }
+
+               q("insert into mail ( `uid`, `guid`, `convid`, `from-name`,`from-photo`,`from-url`,`contact-id`,`title`,`body`,`seen`,`reply`,`uri`,`parent-uri`,`created`) values ( %d, '%s', %d, '%s', '%s', '%s', %d, '%s', '%s', %d, %d, '%s','%s','%s')",
+                       intval($importer['uid']),
+                       dbesc($msg_guid),
+                       intval($conversation['id']),
+                       dbesc($person['name']),
+                       dbesc($person['photo']),
+                       dbesc($person['url']),
+                       intval($contact['id']),  
+                       dbesc($subject),
+                       dbesc($body),
+                       0,
+                       0,
+                       dbesc($message_id),
+                       dbesc($parent_uri),
+                       dbesc($msg_created_at)
+               );                      
+
+               q("update conv set updated = '%s' where id = %d limit 1",
+                       dbesc(datetime_convert()),
+                       intval($conversation['id'])
+               );              
+
+               require_once('include/enotify.php');
+               notification(array(                     
+                       'type' => NOTIFY_MAIL,
+                       'notify_flags' => $importer['notify-flags'],
+                       'language' => $importer['language'],
+                       'to_name' => $importer['username'],
+                       'to_email' => $importer['email'],
+                       'uid' =>$importer['importer_uid'],
+                       'item' => array('subject' => $subject, 'body' => $body),
+                       'source_name' => $person['name'],
+                       'source_link' => $person['url'],
+                       'source_photo' => $person['thumb'],
+                       'verb' => ACTIVITY_POST,
+                       'otype' => 'mail'
+               ));
+       }       
+
+       return;
+}
+
+function diaspora_message($importer,$xml,$msg) {
+
+       $a = get_app();
+
+       $msg_guid = notags(unxmlify($xml->guid));
+       $msg_parent_guid = notags(unxmlify($xml->parent_guid));
+       $msg_parent_author_signature = notags(unxmlify($xml->parent_author_signature));
+       $msg_author_signature = notags(unxmlify($xml->author_signature));
+       $msg_text = unxmlify($xml->text);
+       $msg_created_at = datetime_convert('UTC','UTC',notags(unxmlify($xml->created_at)));
+       $msg_diaspora_handle = notags(unxmlify($xml->diaspora_handle));
+       $msg_conversation_guid = notags(unxmlify($xml->conversation_guid));
+
+       $parent_uri = $diaspora_handle . ':' . $msg_parent_guid;
+       $contact = diaspora_get_contact_by_handle($importer['uid'],$msg_diaspora_handle);
+       if(! $contact) {
+               logger('diaspora_message: cannot find contact: ' . $msg_diaspora_handle);
+               return;
+       }
+
+       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+               logger('diaspora_message: Ignoring this author.');
+               return 202;
+       }
+
+       $conversation = null;
+
+       $c = q("select * from conv where uid = %d and guid = '%s' limit 1",
+               intval($importer['uid']),
+               dbesc($msg_conversation_guid)
+       );
+       if(count($c))
+               $conversation = $c[0];
+       else {
+               logger('diaspora_message: conversation not available.');
+               return;
+       }
+
+       $reply = 0;
+                       
+       $body = diaspora2bb($msg_text);
+       $message_id = $msg_diaspora_handle . ':' . $msg_guid;
+
+       $author_signed_data = $msg_guid . ';' . $msg_parent_guid . ';' . $msg_text . ';' . unxmlify($xml->created_at) . ';' . $msg_diaspora_handle . ';' . $msg_conversation_guid;
+
+
+       $author_signature = base64_decode($msg_author_signature);
+
+       $person = find_diaspora_person_by_handle($msg_diaspora_handle); 
+       if(is_array($person) && x($person,'pubkey'))
+               $key = $person['pubkey'];
+       else {
+               logger('diaspora_message: unable to find author details');
+               return;
+       }
+
+       if(! rsa_verify($author_signed_data,$author_signature,$key,'sha256')) {
+               logger('diaspora_message: verification failed.');
+               return;
+       }
+
+       $r = q("select id from mail where `uri` = '%s' and uid = %d limit 1",
+               dbesc($message_id),
+               intval($importer['uid'])
+       );
+       if(count($r)) {
+               logger('diaspora_message: duplicate message already delivered.', LOGGER_DEBUG);
+               return;
+       }
+
+       q("insert into mail ( `uid`, `guid`, `convid`, `from-name`,`from-photo`,`from-url`,`contact-id`,`title`,`body`,`seen`,`reply`,`uri`,`parent-uri`,`created`) values ( %d, '%s', %d, '%s', '%s', '%s', %d, '%s', '%s', %d, %d, '%s','%s','%s')",
+               intval($importer['uid']),
+               dbesc($msg_guid),
+               intval($conversation['id']),
+               dbesc($person['name']),
+               dbesc($person['photo']),
+               dbesc($person['url']),
+               intval($contact['id']),  
+               dbesc($conversation['subject']),
+               dbesc($body),
+               0,
+               1,
+               dbesc($message_id),
+               dbesc($parent_uri),
+               dbesc($msg_created_at)
+       );                      
+
+       q("update conv set updated = '%s' where id = %d limit 1",
+               dbesc(datetime_convert()),
+               intval($conversation['id'])
+       );              
+       
+       return;
+}
+
+
 function diaspora_photo($importer,$xml,$msg) {
 
        $a = get_app();
+
+       logger('diaspora_photo: init',LOGGER_DEBUG);
+
        $remote_photo_path = notags(unxmlify($xml->remote_photo_path));
 
        $remote_photo_name = notags(unxmlify($xml->remote_photo_name));
@@ -1067,12 +1450,15 @@ function diaspora_photo($importer,$xml,$msg) {
 
        $created_at = notags(unxmlify($xml_created_at));
 
+       logger('diaspora_photo: status_message_guid: ' . $status_message_guid, LOGGER_DEBUG);
 
        $contact = diaspora_get_contact_by_handle($importer['uid'],$msg['author']);
-       if(! $contact)
+       if(! $contact) {
+               logger('diaspora_photo: contact record not found: ' . $msg['author'] . ' handle: ' . $diaspora_handle);
                return;
+       }
 
-       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+       if(! diaspora_post_allow($importer,$contact)) {
                logger('diaspora_photo: Ignoring this author.');
                return 202;
        }
@@ -1085,11 +1471,12 @@ function diaspora_photo($importer,$xml,$msg) {
                logger('diaspora_photo: parent item not found: parent: ' . $parent_guid . ' item: ' . $guid);
                return;
        }
+
        $parent_item = $r[0];
 
        $link_text = '[img]' . $remote_photo_path . $remote_photo_name . '[/img]' . "\n";
 
-       $link_text = scale_diaspora_images($link_text);
+       $link_text = scale_external_images($link_text);
 
        if(strpos($parent_item['body'],$link_text) === false) {
                $r = q("update item set `body` = '%s', `visible` = 1 where `id` = %d and `uid` = %d limit 1",
@@ -1128,7 +1515,7 @@ function diaspora_like($importer,$xml,$msg) {
                return;
        }
 
-       if(($contact['rel'] == CONTACT_IS_FOLLOWER) || ($contact['blocked']) || ($contact['readonly'])) { 
+       if(! diaspora_post_allow($importer,$contact)) {
                logger('diaspora_like: Ignoring this author.');
                return 202;
        }
@@ -1294,6 +1681,7 @@ EOT;
 
 function diaspora_retraction($importer,$xml) {
 
+
        $guid = notags(unxmlify($xml->guid));
        $diaspora_handle = notags(unxmlify($xml->diaspora_handle));
        $type = notags(unxmlify($xml->type));
@@ -1303,6 +1691,7 @@ function diaspora_retraction($importer,$xml) {
                return;
 
        if($type === 'Person') {
+               require_once('include/Contact.php');
                contact_remove($contact['id']);
        }
        elseif($type === 'Post') {
@@ -1324,7 +1713,8 @@ function diaspora_retraction($importer,$xml) {
        // NOTREACHED
 }
 
-function diaspora_signed_retraction($importer,$xml) {
+function diaspora_signed_retraction($importer,$xml,$msg) {
+
 
        $guid = notags(unxmlify($xml->target_guid));
        $diaspora_handle = notags(unxmlify($xml->sender_handle));
@@ -1332,8 +1722,10 @@ function diaspora_signed_retraction($importer,$xml) {
        $sig = notags(unxmlify($xml->target_author_signature));
 
        $contact = diaspora_get_contact_by_handle($importer['uid'],$diaspora_handle);
-       if(! $contact)
+       if(! $contact) {
+               logger('diaspora_signed_retraction: no contact');
                return;
+       }
 
        // this may not yet work for comments. Need to see how the relaying works
        // and figure out who signs it.
@@ -1352,7 +1744,7 @@ function diaspora_signed_retraction($importer,$xml) {
 
        if($type === 'StatusMessage') {
                $r = q("select * from item where guid = '%s' and uid = %d limit 1",
-                       dbesc('guid'),
+                       dbesc($guid),
                        intval($importer['uid'])
                );
                if(count($r)) {
@@ -1364,6 +1756,8 @@ function diaspora_signed_retraction($importer,$xml) {
                        }
                }
        }
+       else
+               logger('diaspora_signed_retraction: unknown type: ' . $type);
 
        return 202;
        // NOTREACHED
@@ -1403,6 +1797,15 @@ function diaspora_profile($importer,$xml) {
 
        $birthday = datetime_convert('UTC','UTC',$birthday,'Y-m-d');
 
+       // this is to prevent multiple birthday notifications in a single year
+       // if we already have a stored birthday and the 'm-d' part hasn't changed, preserve the entry, which will preserve the notify year
+
+       if(substr($birthday,5) === substr($contact['bd'],5))
+               $birthday = $contact['bd'];
+
+       // TODO: update name on item['author-name'] if the name changed. See consume_feed()
+       // Not doing this currently because D* protocol is scheduled for revision soon. 
+
        $r = q("UPDATE `contact` SET `name` = '%s', `name-date` = '%s', `photo` = '%s', `thumb` = '%s', `micro` = '%s', `avatar-date` = '%s' , `bd` = '%s' WHERE `id` = %d AND `uid` = %d LIMIT 1",
                dbesc($name),
                dbesc(datetime_convert()),
@@ -1431,27 +1834,6 @@ function diaspora_profile($importer,$xml) {
 
 }
 
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
-
 function diaspora_share($me,$contact) {
        $a = get_app();
        $myaddr = $me['nickname'] . '@' .  substr($a->get_baseurl(), strpos($a->get_baseurl(),'://') + 3);
@@ -1779,7 +2161,67 @@ function diaspora_send_retraction($item,$owner,$contact,$public_batch = false) {
        return(diaspora_transmit($owner,$contact,$slap,$public_batch));
 }
 
+function diaspora_send_mail($item,$owner,$contact) {
 
+       $a = get_app();
+       $myaddr = $owner['nickname'] . '@' .  substr($a->get_baseurl(), strpos($a->get_baseurl(),'://') + 3);
+
+       $r = q("select * from conv where id = %d and uid = %d limit 1",
+               intval($item['convid']),
+               intval($item['uid'])
+       );
+
+       if(! count($r)) {
+               logger('diaspora_send_mail: conversation not found.');
+               return;
+       }
+       $cnv = $r[0];
+
+       $conv = array(
+               'guid' => xmlify($cnv['guid']),
+               'subject' => xmlify($cnv['subject']),
+               'created_at' => xmlify(datetime_convert('UTC','UTC',$cnv['created'],'Y-m-d H:i:s \U\T\C')),
+               'diaspora_handle' => xmlify($cnv['creator']),
+               'participant_handles' => xmlify($cnv['recips'])
+       );
+
+       $body = bb2diaspora($item['body']);
+       $created = datetime_convert('UTC','UTC',$item['created'],'Y-m-d H:i:s \U\T\C');
+       $signed_text =  $item['guid'] . ';' . $cnv['guid'] . ';' . $body .  ';' 
+               . $created . ';' . $myaddr . ';' . $cnv['guid'];
+
+       $sig = base64_encode(rsa_sign($signed_text,$owner['uprvkey'],'sha256'));
+
+       $msg = array(
+               'guid' => xmlify($item['guid']),
+               'parent_guid' => xmlify($cnv['guid']),
+               'parent_author_signature' => (($item['reply']) ? null : xmlify($sig)),
+               'author_signature' => xmlify($sig),
+               'text' => xmlify($body),
+               'created_at' => xmlify($created),
+               'diaspora_handle' => xmlify($myaddr),
+               'conversation_guid' => xmlify($cnv['guid'])
+       );
+
+       if($item['reply']) {
+               $tpl = get_markup_template('diaspora_message.tpl');
+               $xmsg = replace_macros($tpl, array('$msg' => $msg));
+       }
+       else {
+               $conv['messages'] = array($msg);
+               $tpl = get_markup_template('diaspora_conversation.tpl');
+               $xmsg = replace_macros($tpl, array('$conv' => $conv));
+       }
+
+       logger('diaspora_conversation: ' . print_r($xmsg,true), LOGGER_DATA);
+
+       $slap = 'xml=' . urlencode(urlencode(diaspora_msg_build($xmsg,$owner,$contact,$owner['uprvkey'],$contact['pubkey'],false)));
+
+       return(diaspora_transmit($owner,$contact,$slap,false));
+
+
+}
 
 function diaspora_transmit($owner,$contact,$slap,$public_batch) {
 
@@ -1793,7 +2235,12 @@ function diaspora_transmit($owner,$contact,$slap,$public_batch) {
 
        logger('diaspora_transmit: ' . $logid . ' ' . $dest_url);
 
-       post_url($dest_url . '/', $slap);
+       if(! intval(get_config('system','diaspora_test')))
+               post_url($dest_url . '/', $slap);
+       else {
+               logger('diaspora_transmit: test_mode');
+               return 200;
+       }
 
        $return_code = $a->get_curl_code();
        logger('diaspora_transmit: ' . $logid . ' returns: ' . $return_code);