]> git.mxchange.org Git - friendica.git/blobdiff - include/enotify.php
Merge pull request #4283 from MrPetovan/bug/2487-fix-autolink-regex
[friendica.git] / include / enotify.php
index 13298ce76ca684b8396a261a6a00ed4a871aaf72..286a372e9cb6ea5c1d2fa342e582c35e88f7e05b 100644 (file)
@@ -50,11 +50,11 @@ function notification($params)
        }
 
        if ($params['type'] != SYSTEM_EMAIL) {
-               $user = dba::select('user', array('nickname', 'page-flags'),
-                       array('uid' => $params['uid']), array('limit' => 1));
+               $user = dba::selectFirst('user', ['nickname', 'page-flags'],
+                       ['uid' => $params['uid']]);
 
                // There is no need to create notifications for forum accounts
-               if (!DBM::is_result($user) || in_array($user["page-flags"], array(PAGE_COMMUNITY, PAGE_PRVGROUP))) {
+               if (!DBM::is_result($user) || in_array($user["page-flags"], [PAGE_COMMUNITY, PAGE_PRVGROUP])) {
                        return;
                }
        }
@@ -106,10 +106,8 @@ function notification($params)
        }
 
        if ($params['type'] == NOTIFY_COMMENT) {
-               $p = q("SELECT `ignored` FROM `thread` WHERE `iid` = %d LIMIT 1",
-                       intval($parent_id)
-               );
-               if ($p && count($p) && ($p[0]["ignored"])) {
+               $thread = dba::selectFirst('thread', ['ignored'], ['iid' => $parent_id]);
+               if (DBM::is_result($thread) && $thread["ignored"]) {
                        logger("Thread ".$parent_id." will be ignored", LOGGER_DEBUG);
                        return;
                }
@@ -130,15 +128,13 @@ function notification($params)
 
                // if it's a post figure out who's post it is.
 
-               $p = null;
+               $item = null;
 
                if ($params['otype'] === 'item' && $parent_id) {
-                       $p = q("SELECT * FROM `item` WHERE `id` = %d LIMIT 1",
-                               intval($parent_id)
-                       );
+                       $item = dba::selectFirst('item', [], ['id' => $parent_id]);
                }
 
-               $item_post_type = item_post_type($p[0]);
+               $item_post_type = item_post_type($item);
 
                // "a post"
                $dest_str = sprintf(t('%1$s commented on [url=%2$s]a %3$s[/url]'),
@@ -147,16 +143,16 @@ function notification($params)
                                                                $item_post_type);
 
                // "George Bull's post"
-               if ($p) {
+               if ($item) {
                        $dest_str = sprintf(t('%1$s commented on [url=%2$s]%3$s\'s %4$s[/url]'),
                                                '[url='.$params['source_link'].']'.$params['source_name'].'[/url]',
                                                $itemlink,
-                                               $p[0]['author-name'],
+                                               $item['author-name'],
                                                $item_post_type);
                }
 
                // "your post"
-               if ($p[0]['owner-name'] == $p[0]['author-name'] && $p[0]['wall']) {
+               if (DBM::is_result($item) && $item['owner-name'] == $item['author-name'] && $item['wall']) {
                        $dest_str = sprintf(t('%1$s commented on [url=%2$s]your %3$s[/url]'),
                                                                '[url='.$params['source_link'].']'.$params['source_name'].'[/url]',
                                                                $itemlink,
@@ -390,7 +386,7 @@ function notification($params)
 
        $subject .= " (".$nickname."@".$hostname.")";
 
-       $h = array(
+       $h = [
                'params'    => $params,
                'subject'   => $subject,
                'preamble'  => $preamble,
@@ -400,7 +396,7 @@ function notification($params)
                'tsitelink' => $tsitelink,
                'hsitelink' => $hsitelink,
                'itemlink'  => $itemlink
-       );
+       ];
 
        call_hooks('enotify', $h);
 
@@ -428,7 +424,7 @@ function notification($params)
                } while ($dups == true);
 
                /// @TODO One statement is enough
-               $datarray = array();
+               $datarray = [];
                $datarray['hash']  = $hash;
                $datarray['name']  = $params['source_name'];
                $datarray['name_cache'] = strip_tags(bbcode($params['source_name']));
@@ -490,7 +486,7 @@ function notification($params)
                );
                if ($p && (count($p) > 1)) {
                        for ($d = 1; $d < count($p); $d ++) {
-                               dba::delete('notify', array('id' => $p[$d]['id']));
+                               dba::delete('notify', ['id' => $p[$d]['id']]);
                        }
 
                        // only continue on if we stored the first one
@@ -501,7 +497,7 @@ function notification($params)
                }
 
                $itemlink = System::baseUrl().'/notify/view/'.$notify_id;
-               $msg = replace_macros($epreamble, array('$itemlink' => $itemlink));
+               $msg = replace_macros($epreamble, ['$itemlink' => $itemlink]);
                $msg_cache = format_notification_message($datarray['name_cache'], strip_tags(bbcode($msg)));
                q("UPDATE `notify` SET `msg` = '%s', `msg_cache` = '%s' WHERE `id` = %d AND `uid` = %d",
                        dbesc($msg),
@@ -550,12 +546,12 @@ function notification($params)
                }
 
                // textversion keeps linebreaks
-               $textversion = strip_tags(str_replace("<br>", "\n", html_entity_decode(bbcode(stripslashes(str_replace(array("\\r\\n", "\\r", "\\n"), "\n",
+               $textversion = strip_tags(str_replace("<br>", "\n", html_entity_decode(bbcode(stripslashes(str_replace(["\\r\\n", "\\r", "\\n"], "\n",
                        $body))),ENT_QUOTES, 'UTF-8')));
-               $htmlversion = html_entity_decode(bbcode(stripslashes(str_replace(array("\\r\\n", "\\r", "\\n\\n", "\\n"),
+               $htmlversion = html_entity_decode(bbcode(stripslashes(str_replace(["\\r\\n", "\\r", "\\n\\n", "\\n"],
                        "<br />\n", $body))), ENT_QUOTES, 'UTF-8');
 
-               $datarray = array();
+               $datarray = [];
                $datarray['banner'] = $banner;
                $datarray['product'] = $product;
                $datarray['preamble'] = $preamble;
@@ -588,7 +584,7 @@ function notification($params)
 
                // load the template for private message notifications
                $tpl = get_markup_template('email_notify_html.tpl');
-               $email_html_body = replace_macros($tpl, array(
+               $email_html_body = replace_macros($tpl, [
                        '$banner'       => $datarray['banner'],
                        '$product'      => $datarray['product'],
                        '$preamble'     => str_replace("\n", "<br>\n", $datarray['preamble']),
@@ -605,11 +601,11 @@ function notification($params)
                        '$title'        => $datarray['title'],
                        '$htmlversion'  => $datarray['htmlversion'],
                        '$content_allowed'      => $content_allowed,
-               ));
+               ]);
 
                // load the template for private message notifications
                $tpl = get_markup_template('email_notify_text.tpl');
-               $email_text_body = replace_macros($tpl, array(
+               $email_text_body = replace_macros($tpl, [
                        '$banner'       => $datarray['banner'],
                        '$product'      => $datarray['product'],
                        '$preamble'     => $datarray['preamble'],
@@ -626,11 +622,11 @@ function notification($params)
                        '$title'        => $datarray['title'],
                        '$textversion'  => $datarray['textversion'],
                        '$content_allowed'      => $content_allowed,
-               ));
+               ]);
 
                // use the Emailer class to send the message
                return Emailer::send(
-                       array(
+                       [
                        'uid' => $params['uid'],
                        'fromName' => $sender_name,
                        'fromEmail' => $sender_email,
@@ -639,7 +635,7 @@ function notification($params)
                        'messageSubject' => $datarray['subject'],
                        'htmlVersion' => $email_html_body,
                        'textVersion' => $email_text_body,
-                       'additionalMailHeader' => $datarray['headers'])
+                       'additionalMailHeader' => $datarray['headers']]
                );
        }
 
@@ -670,26 +666,29 @@ function check_user_notification($itemid) {
  * @param str $defaulttype (Optional) Forces a notification with this type.
  */
 function check_item_notification($itemid, $uid, $defaulttype = "") {
-       $notification_data = array("uid" => $uid, "profiles" => array());
+       $notification_data = ["uid" => $uid, "profiles" => []];
        call_hooks('check_item_notification', $notification_data);
 
        $profiles = $notification_data["profiles"];
 
-       $user = q("SELECT `notify-flags`, `language`, `username`, `email`, `nickname` FROM `user` WHERE `uid` = %d", intval($uid));
-       if (!$user)
+       $fields = ['notify-flags', 'language', 'username', 'email', 'nickname'];
+       $user = dba::selectFirst('user', $fields, ['uid' => $uid]);
+       if (!DBM::is_result($user)) {
                return false;
+       }
 
-       $owner = q("SELECT `id`, `url` FROM `contact` WHERE `self` AND `uid` = %d LIMIT 1", intval($uid));
-       if (!$owner)
+       $owner = dba::selectFirst('contact', ['url'], ['self' => true, 'uid' => $uid]);
+       if (!DBM::is_result($owner)) {
                return false;
+       }
 
        // This is our regular URL format
-       $profiles[] = $owner[0]["url"];
+       $profiles[] = $owner["url"];
 
        // Notifications from Diaspora are often with an URL in the Diaspora format
-       $profiles[] = System::baseUrl()."/u/".$user[0]["nickname"];
+       $profiles[] = System::baseUrl()."/u/".$user["nickname"];
 
-       $profiles2 = array();
+       $profiles2 = [];
 
        foreach ($profiles AS $profile) {
                // Check for invalid profile urls. 13 should be the shortest possible profile length:
@@ -733,12 +732,12 @@ function check_item_notification($itemid, $uid, $defaulttype = "") {
                return false;
 
        // Generate the notification array
-       $params = array();
+       $params = [];
        $params["uid"] = $uid;
-       $params["notify_flags"] = $user[0]["notify-flags"];
-       $params["language"] = $user[0]["language"];
-       $params["to_name"] = $user[0]["username"];
-       $params["to_email"] = $user[0]["email"];
+       $params["notify_flags"] = $user["notify-flags"];
+       $params["language"] = $user["language"];
+       $params["to_name"] = $user["username"];
+       $params["to_email"] = $user["email"];
        $params["item"] = $item[0];
        $params["parent"] = $item[0]["parent"];
        $params["link"] = System::baseUrl().'/display/'.urlencode($item[0]["guid"]);
@@ -749,10 +748,7 @@ function check_item_notification($itemid, $uid, $defaulttype = "") {
 
        if ($item[0]["parent-uri"] === $item[0]["uri"]) {
                // Send a notification for every new post?
-               $r = q("SELECT `notify_new_posts` FROM `contact` WHERE `id` = %d AND `notify_new_posts` LIMIT 1",
-                       intval($item[0]['contact-id'])
-               );
-               $send_notification = DBM::is_result($r);
+               $send_notification = dba::exists('contact', ['id' => $item[0]['contact-id'], 'notify_new_posts' => true]);
 
                if (!$send_notification) {
                        $tags = q("SELECT `url` FROM `term` WHERE `otype` = %d AND `oid` = %d AND `type` = %d AND `uid` = %d",
@@ -760,10 +756,11 @@ function check_item_notification($itemid, $uid, $defaulttype = "") {
 
                        if (DBM::is_result($tags)) {
                                foreach ($tags AS $tag) {
-                                       $r = q("SELECT `id` FROM `contact` WHERE `nurl` = '%s' AND `uid` = %d AND `notify_new_posts`",
-                                               normalise_link($tag["url"]), intval($uid));
-                                       if (DBM::is_result($r))
+                                       $condition = ['nurl' => normalise_link($tag["url"]), 'uid' => $uid, 'notify_new_posts' => true];
+                                       $r = dba::exists('contact', $condition);
+                                       if ($r) {
                                                $send_notification = true;
+                                       }
                                }
                        }
                }