]> git.mxchange.org Git - friendica.git/blobdiff - include/enotify.php
The url detection in BBCode is too greedy
[friendica.git] / include / enotify.php
index dc030fa8b8985b77ed7a446dafcf864c6869586d..ab4bbc6db249c1fb84ebd85fd16f8a8ae1212e85 100644 (file)
@@ -3,12 +3,12 @@
  * @file include/enotify.php
  */
 use Friendica\App;
+use Friendica\Core\Addon;
 use Friendica\Core\Config;
 use Friendica\Core\System;
 use Friendica\Database\DBM;
 use Friendica\Util\Emailer;
 
-require_once 'include/email.php';
 require_once 'include/bbcode.php';
 require_once 'include/html2bbcode.php';
 
@@ -21,12 +21,11 @@ require_once 'include/html2bbcode.php';
                        source_link, activity, preamble, notify_flags,
                        language, show_in_notification_page
  */
-function notification($params) {
-
+function notification($params)
+{
        $a = get_app();
 
        // from here on everything is in the recipients language
-
        push_lang($params['language']);
 
        $banner = t('Friendica Notification');
@@ -34,28 +33,29 @@ function notification($params) {
        $siteurl = System::baseUrl(true);
        $thanks = t('Thank You,');
        $sitename = $a->config['sitename'];
-       if (!x($a->config['admin_name']))
+       if (!x($a->config['admin_name'])) {
            $site_admin = sprintf(t('%s Administrator'), $sitename);
-       else
+       } else {
            $site_admin = sprintf(t('%1$s, %2$s Administrator'), $a->config['admin_name'], $sitename);
-
-       $nickname = "";
+       }
 
        $sender_name = $sitename;
        $hostname = $a->get_hostname();
-       if (strpos($hostname, ':'))
+       if (strpos($hostname, ':')) {
                $hostname = substr($hostname, 0, strpos($hostname, ':'));
+       }
 
        $sender_email = $a->config['sender_email'];
-       if (empty($sender_email))
+       if (empty($sender_email)) {
                $sender_email = t('noreply').'@'.$hostname;
+       }
 
        if ($params['type'] != SYSTEM_EMAIL) {
-               $user = dba::select('user', array('nickname', 'page-flags'),
-                       array('uid' => $params['uid']), array('limit' => 1));
+               $user = dba::selectFirst('user', ['nickname', 'page-flags'],
+                       ['uid' => $params['uid']]);
 
                // There is no need to create notifications for forum accounts
-               if (!DBM::is_result($user) || in_array($user["page-flags"], array(PAGE_COMMUNITY, PAGE_PRVGROUP))) {
+               if (!DBM::is_result($user) || in_array($user["page-flags"], [PAGE_COMMUNITY, PAGE_PRVGROUP])) {
                        return;
                }
        }
@@ -78,21 +78,21 @@ function notification($params) {
        if (array_key_exists('item', $params)) {
                $title = $params['item']['title'];
                $body = $params['item']['body'];
-       } else
+       } else {
                $title = $body = '';
+       }
 
-       // e.g. "your post", "David's photo", etc.
-       $possess_desc = t('%s <!item_type!>');
-
-       if (isset($params['item']['id']))
+       if (isset($params['item']['id'])) {
                $item_id = $params['item']['id'];
-       else
+       } else {
                $item_id = 0;
+       }
 
-       if (isset($params['parent']))
+       if (isset($params['parent'])) {
                $parent_id = $params['parent'];
-       else
+       } else {
                $parent_id = 0;
+       }
 
        if ($params['type'] == NOTIFY_MAIL) {
                $subject = sprintf(t('[Friendica:Notify] New mail received at %s'), $sitename);
@@ -107,19 +107,14 @@ function notification($params) {
        }
 
        if ($params['type'] == NOTIFY_COMMENT) {
-               $p = q("SELECT `ignored` FROM `thread` WHERE `iid` = %d AND `uid` = %d LIMIT 1",
-                       intval($parent_id),
-                       intval($params['uid'])
-               );
-               if ($p && count($p) && ($p[0]["ignored"])) {
+               $thread = dba::selectFirst('thread', ['ignored'], ['iid' => $parent_id]);
+               if (DBM::is_result($thread) && $thread["ignored"]) {
                        logger("Thread ".$parent_id." will be ignored", LOGGER_DEBUG);
                        return;
                }
 
                // Check to see if there was already a tag notify or comment notify for this post.
                // If so don't create a second notification
-
-               $p = null;
                $p = q("SELECT `id` FROM `notify` WHERE `type` IN (%d, %d, %d) AND `link` = '%s' AND `uid` = %d LIMIT 1",
                        intval(NOTIFY_TAGSELF),
                        intval(NOTIFY_COMMENT),
@@ -134,16 +129,13 @@ function notification($params) {
 
                // if it's a post figure out who's post it is.
 
-               $p = null;
+               $item = null;
 
                if ($params['otype'] === 'item' && $parent_id) {
-                       $p = q("SELECT * FROM `item` WHERE `id` = %d AND `uid` = %d LIMIT 1",
-                               intval($parent_id),
-                               intval($params['uid'])
-                       );
+                       $item = dba::selectFirst('item', [], ['id' => $parent_id]);
                }
 
-               $item_post_type = item_post_type($p[0]);
+               $item_post_type = item_post_type($item);
 
                // "a post"
                $dest_str = sprintf(t('%1$s commented on [url=%2$s]a %3$s[/url]'),
@@ -152,19 +144,21 @@ function notification($params) {
                                                                $item_post_type);
 
                // "George Bull's post"
-               if ($p)
+               if ($item) {
                        $dest_str = sprintf(t('%1$s commented on [url=%2$s]%3$s\'s %4$s[/url]'),
                                                '[url='.$params['source_link'].']'.$params['source_name'].'[/url]',
                                                $itemlink,
-                                               $p[0]['author-name'],
+                                               $item['author-name'],
                                                $item_post_type);
+               }
 
                // "your post"
-               if ($p[0]['owner-name'] == $p[0]['author-name'] && $p[0]['wall'])
+               if (DBM::is_result($item) && $item['owner-name'] == $item['author-name'] && $item['wall']) {
                        $dest_str = sprintf(t('%1$s commented on [url=%2$s]your %3$s[/url]'),
                                                                '[url='.$params['source_link'].']'.$params['source_name'].'[/url]',
                                                                $itemlink,
                                                                $item_post_type);
+               }
 
                // Some mail softwares relies on subject field for threading.
                // So, we cannot have different subjects for notifications of the same thread.
@@ -393,7 +387,7 @@ function notification($params) {
 
        $subject .= " (".$nickname."@".$hostname.")";
 
-       $h = array(
+       $h = [
                'params'    => $params,
                'subject'   => $subject,
                'preamble'  => $preamble,
@@ -403,9 +397,9 @@ function notification($params) {
                'tsitelink' => $tsitelink,
                'hsitelink' => $hsitelink,
                'itemlink'  => $itemlink
-       );
+       ];
 
-       call_hooks('enotify', $h);
+       Addon::callHooks('enotify', $h);
 
        $subject   = $h['subject'];
 
@@ -414,7 +408,6 @@ function notification($params) {
 
        $body      = $h['body'];
 
-       $sitelink  = $h['sitelink'];
        $tsitelink = $h['tsitelink'];
        $hsitelink = $h['hsitelink'];
        $itemlink  = $h['itemlink'];
@@ -432,7 +425,7 @@ function notification($params) {
                } while ($dups == true);
 
                /// @TODO One statement is enough
-               $datarray = array();
+               $datarray = [];
                $datarray['hash']  = $hash;
                $datarray['name']  = $params['source_name'];
                $datarray['name_cache'] = strip_tags(bbcode($params['source_name']));
@@ -448,7 +441,7 @@ function notification($params) {
                $datarray['otype'] = $params['otype'];
                $datarray['abort'] = false;
 
-               call_hooks('enotify_store', $datarray);
+               Addon::callHooks('enotify_store', $datarray);
 
                if ($datarray['abort']) {
                        pop_lang();
@@ -456,8 +449,7 @@ function notification($params) {
                }
 
                // create notification entry in DB
-
-               $r = q("INSERT INTO `notify` (`hash`, `name`, `url`, `photo`, `date`, `uid`, `link`, `iid`, `parent`, `type`, `verb`, `otype`, `name_cache`)
+               q("INSERT INTO `notify` (`hash`, `name`, `url`, `photo`, `date`, `uid`, `link`, `iid`, `parent`, `type`, `verb`, `otype`, `name_cache`)
                        values('%s', '%s', '%s', '%s', '%s', %d, '%s', %d, %d, %d, '%s', '%s', '%s')",
                        dbesc($datarray['hash']),
                        dbesc($datarray['name']),
@@ -478,17 +470,15 @@ function notification($params) {
                        dbesc($hash),
                        intval($params['uid'])
                );
-               if ($r)
+               if ($r) {
                        $notify_id = $r[0]['id'];
-               else {
+               else {
                        pop_lang();
                        return False;
                }
 
                // we seem to have a lot of duplicate comment notifications due to race conditions, mostly from forums
                // After we've stored everything, look again to see if there are any duplicates and if so remove them
-
-               $p = null;
                $p = q("SELECT `id` FROM `notify` WHERE `type` IN (%d, %d) AND `link` = '%s' AND `uid` = %d ORDER BY `id`",
                        intval(NOTIFY_TAGSELF),
                        intval(NOTIFY_COMMENT),
@@ -497,22 +487,20 @@ function notification($params) {
                );
                if ($p && (count($p) > 1)) {
                        for ($d = 1; $d < count($p); $d ++) {
-                               dba::delete('notify', array('id' => $p[$d]['id']));
+                               dba::delete('notify', ['id' => $p[$d]['id']]);
                        }
 
                        // only continue on if we stored the first one
-
                        if ($notify_id != $p[0]['id']) {
                                pop_lang();
                                return False;
                        }
                }
 
-
                $itemlink = System::baseUrl().'/notify/view/'.$notify_id;
-               $msg = replace_macros($epreamble, array('$itemlink' => $itemlink));
+               $msg = replace_macros($epreamble, ['$itemlink' => $itemlink]);
                $msg_cache = format_notification_message($datarray['name_cache'], strip_tags(bbcode($msg)));
-               $r = q("UPDATE `notify` SET `msg` = '%s', `msg_cache` = '%s' WHERE `id` = %d AND `uid` = %d",
+               q("UPDATE `notify` SET `msg` = '%s', `msg_cache` = '%s' WHERE `id` = %d AND `uid` = %d",
                        dbesc($msg),
                        dbesc($msg_cache),
                        intval($notify_id),
@@ -540,7 +528,7 @@ function notification($params) {
 
                        if (!$r) {
                                logger("notify_id:".intval($notify_id).", parent: ".intval($params['parent'])."uid: ".intval($params['uid']), LOGGER_DEBUG);
-                               $r = q("INSERT INTO `notify-threads` (`notify-id`, `master-parent-item`, `receiver-uid`, `parent-item`)
+                               q("INSERT INTO `notify-threads` (`notify-id`, `master-parent-item`, `receiver-uid`, `parent-item`)
                                        values(%d, %d, %d, %d)",
                                        intval($notify_id),
                                        intval($params['parent']),
@@ -559,12 +547,12 @@ function notification($params) {
                }
 
                // textversion keeps linebreaks
-               $textversion = strip_tags(str_replace("<br>", "\n", html_entity_decode(bbcode(stripslashes(str_replace(array("\\r\\n", "\\r", "\\n"), "\n",
+               $textversion = strip_tags(str_replace("<br>", "\n", html_entity_decode(bbcode(stripslashes(str_replace(["\\r\\n", "\\r", "\\n"], "\n",
                        $body))),ENT_QUOTES, 'UTF-8')));
-               $htmlversion = html_entity_decode(bbcode(stripslashes(str_replace(array("\\r\\n", "\\r", "\\n\\n", "\\n"),
+               $htmlversion = html_entity_decode(bbcode(stripslashes(str_replace(["\\r\\n", "\\r", "\\n\\n", "\\n"],
                        "<br />\n", $body))), ENT_QUOTES, 'UTF-8');
 
-               $datarray = array();
+               $datarray = [];
                $datarray['banner'] = $banner;
                $datarray['product'] = $product;
                $datarray['preamble'] = $preamble;
@@ -589,7 +577,7 @@ function notification($params) {
                $datarray['subject'] = $subject;
                $datarray['headers'] = $additional_mail_header;
 
-               call_hooks('enotify_mail', $datarray);
+               Addon::callHooks('enotify_mail', $datarray);
 
                // check whether sending post content in email notifications is allowed
                // always true for SYSTEM_EMAIL
@@ -597,7 +585,7 @@ function notification($params) {
 
                // load the template for private message notifications
                $tpl = get_markup_template('email_notify_html.tpl');
-               $email_html_body = replace_macros($tpl, array(
+               $email_html_body = replace_macros($tpl, [
                        '$banner'       => $datarray['banner'],
                        '$product'      => $datarray['product'],
                        '$preamble'     => str_replace("\n", "<br>\n", $datarray['preamble']),
@@ -614,11 +602,11 @@ function notification($params) {
                        '$title'        => $datarray['title'],
                        '$htmlversion'  => $datarray['htmlversion'],
                        '$content_allowed'      => $content_allowed,
-               ));
+               ]);
 
                // load the template for private message notifications
                $tpl = get_markup_template('email_notify_text.tpl');
-               $email_text_body = replace_macros($tpl, array(
+               $email_text_body = replace_macros($tpl, [
                        '$banner'       => $datarray['banner'],
                        '$product'      => $datarray['product'],
                        '$preamble'     => $datarray['preamble'],
@@ -635,12 +623,11 @@ function notification($params) {
                        '$title'        => $datarray['title'],
                        '$textversion'  => $datarray['textversion'],
                        '$content_allowed'      => $content_allowed,
-               ));
+               ]);
 
                // use the Emailer class to send the message
-
                return Emailer::send(
-                       array(
+                       [
                        'uid' => $params['uid'],
                        'fromName' => $sender_name,
                        'fromEmail' => $sender_email,
@@ -649,13 +636,29 @@ function notification($params) {
                        'messageSubject' => $datarray['subject'],
                        'htmlVersion' => $email_html_body,
                        'textVersion' => $email_text_body,
-                       'additionalMailHeader' => $datarray['headers'])
+                       'additionalMailHeader' => $datarray['headers']]
                );
        }
 
        return false;
 }
 
+/**
+ * @brief Checks for users who should be notified
+ *
+ * @param int $itemid ID of the item for which the check should be done
+ */
+function check_user_notification($itemid) {
+       // fetch all users in the thread
+       $users = dba::p("SELECT DISTINCT(`contact`.`uid`) FROM `item`
+                       INNER JOIN `contact` ON `contact`.`id` = `item`.`contact-id` AND `contact`.`uid` != 0
+                       WHERE `parent` IN (SELECT `parent` FROM `item` WHERE `id`=?)", $itemid);
+       while ($user = dba::fetch($users)) {
+               check_item_notification($itemid, $user['uid']);
+       }
+       dba::close($users);
+}
+
 /**
  * @brief Checks for item related notifications and sends them
  *
@@ -664,26 +667,29 @@ function notification($params) {
  * @param str $defaulttype (Optional) Forces a notification with this type.
  */
 function check_item_notification($itemid, $uid, $defaulttype = "") {
-       $notification_data = array("uid" => $uid, "profiles" => array());
-       call_hooks('check_item_notification', $notification_data);
+       $notification_data = ["uid" => $uid, "profiles" => []];
+       Addon::callHooks('check_item_notification', $notification_data);
 
        $profiles = $notification_data["profiles"];
 
-       $user = q("SELECT `notify-flags`, `language`, `username`, `email`, `nickname` FROM `user` WHERE `uid` = %d", intval($uid));
-       if (!$user)
+       $fields = ['notify-flags', 'language', 'username', 'email', 'nickname'];
+       $user = dba::selectFirst('user', $fields, ['uid' => $uid]);
+       if (!DBM::is_result($user)) {
                return false;
+       }
 
-       $owner = q("SELECT `id`, `url` FROM `contact` WHERE `self` AND `uid` = %d LIMIT 1", intval($uid));
-       if (!$owner)
+       $owner = dba::selectFirst('contact', ['url'], ['self' => true, 'uid' => $uid]);
+       if (!DBM::is_result($owner)) {
                return false;
+       }
 
        // This is our regular URL format
-       $profiles[] = $owner[0]["url"];
+       $profiles[] = $owner["url"];
 
        // Notifications from Diaspora are often with an URL in the Diaspora format
-       $profiles[] = System::baseUrl()."/u/".$user[0]["nickname"];
+       $profiles[] = System::baseUrl()."/u/".$user["nickname"];
 
-       $profiles2 = array();
+       $profiles2 = [];
 
        foreach ($profiles AS $profile) {
                // Check for invalid profile urls. 13 should be the shortest possible profile length:
@@ -727,12 +733,12 @@ function check_item_notification($itemid, $uid, $defaulttype = "") {
                return false;
 
        // Generate the notification array
-       $params = array();
+       $params = [];
        $params["uid"] = $uid;
-       $params["notify_flags"] = $user[0]["notify-flags"];
-       $params["language"] = $user[0]["language"];
-       $params["to_name"] = $user[0]["username"];
-       $params["to_email"] = $user[0]["email"];
+       $params["notify_flags"] = $user["notify-flags"];
+       $params["language"] = $user["language"];
+       $params["to_name"] = $user["username"];
+       $params["to_email"] = $user["email"];
        $params["item"] = $item[0];
        $params["parent"] = $item[0]["parent"];
        $params["link"] = System::baseUrl().'/display/'.urlencode($item[0]["guid"]);
@@ -743,11 +749,7 @@ function check_item_notification($itemid, $uid, $defaulttype = "") {
 
        if ($item[0]["parent-uri"] === $item[0]["uri"]) {
                // Send a notification for every new post?
-               $r = q("SELECT `notify_new_posts` FROM `contact` WHERE `id` = %d AND `uid` = %d AND `notify_new_posts` LIMIT 1",
-                       intval($item[0]['contact-id']),
-                       intval($uid)
-               );
-               $send_notification = DBM::is_result($r);
+               $send_notification = dba::exists('contact', ['id' => $item[0]['contact-id'], 'notify_new_posts' => true]);
 
                if (!$send_notification) {
                        $tags = q("SELECT `url` FROM `term` WHERE `otype` = %d AND `oid` = %d AND `type` = %d AND `uid` = %d",
@@ -755,10 +757,11 @@ function check_item_notification($itemid, $uid, $defaulttype = "") {
 
                        if (DBM::is_result($tags)) {
                                foreach ($tags AS $tag) {
-                                       $r = q("SELECT `id` FROM `contact` WHERE `nurl` = '%s' AND `uid` = %d AND `notify_new_posts`",
-                                               normalise_link($tag["url"]), intval($uid));
-                                       if (DBM::is_result($r))
+                                       $condition = ['nurl' => normalise_link($tag["url"]), 'uid' => $uid, 'notify_new_posts' => true];
+                                       $r = dba::exists('contact', $condition);
+                                       if ($r) {
                                                $send_notification = true;
+                                       }
                                }
                        }
                }
@@ -784,10 +787,10 @@ function check_item_notification($itemid, $uid, $defaulttype = "") {
 
        // Is it a post that the user had started or where he interacted?
        $parent = q("SELECT `thread`.`iid` FROM `thread` INNER JOIN `item` ON `item`.`parent` = `thread`.`iid`
-                       WHERE `thread`.`iid` = %d AND `thread`.`uid` = %d AND NOT `thread`.`ignored` AND
+                       WHERE `thread`.`iid` = %d AND NOT `thread`.`ignored` AND
                                (`thread`.`mention` OR `item`.`author-link` IN ($profile_list))
                        LIMIT 1",
-                       intval($item[0]["parent"]), intval($uid));
+                       intval($item[0]["parent"]));
 
        if ($parent && !isset($params["type"])) {
                $params["type"] = NOTIFY_COMMENT;