Continued with code convention:

[friendica.git] / include / feed.php

diff --git a/include/feed.php b/include/feed.php
index 184b784c72abdbf1dcdcef52fb3d691a6a36a07e..579ff7caae3652cce6c9fcb714720886bd32334f 100644 (file)
--- a/include/feed.php
+++ b/include/feed.php
@@ -2,14 +2,30 @@
 require_once("include/html2bbcode.php");
 require_once("include/items.php");
 
+/**
+ * @brief Read a RSS/RDF/Atom feed and create an item entry for it
+ *
+ * @param string $xml The feed data
+ * @param array $importer The user record of the importer
+ * @param array $contact The contact record of the feed
+ * @param string $hub Unused dummy value for compatibility reasons
+ * @param bool $simulate If enabled, no data is imported
+ *
+ * @return array In simulation mode it returns the header and the first item
+ */
 function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
 
        $a = get_app();
 
-       logger("Import Atom/RSS feed", LOGGER_DEBUG);
+       if (!$simulate)
+               logger("Import Atom/RSS feed '".$contact["name"]."' (Contact ".$contact["id"].") for user ".$importer["uid"], LOGGER_DEBUG);
+       else
+               logger("Test Atom/RSS feed", LOGGER_DEBUG);
 
-       if ($xml == "")
+       if ($xml == "") {
+               logger('XML is empty.', LOGGER_DEBUG);
                return;
+       }
 
        $doc = new DOMDocument();
        @$doc->loadXML($xml);
@@ -36,7 +52,7 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
        }
 
        // Is it Atom?
-       if ($xpath->query('/atom:feed/atom:entry')->length > 0) {
+       if ($xpath->query('/atom:feed')->length > 0) {
                $alternate = $xpath->query("atom:link[@rel='alternate']")->item(0)->attributes;
                if (is_object($alternate))
                        foreach($alternate AS $attributes)
@@ -44,7 +60,7 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
                                        $author["author-link"] = $attributes->textContent;
 
                if ($author["author-link"] == "")
-                       $author["author-link"] = $xpath->evaluate('/atom:feed/atom:author/atom:uri/text()')->item(0)->nodeValue;
+                       $author["author-link"] = $author["author-id"];
 
                if ($author["author-link"] == "") {
                        $self = $xpath->query("atom:link[@rel='self']")->item(0)->attributes;
@@ -71,9 +87,22 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
                if ($value != "")
                        $author["author-name"] = $value;
 
-               $value = $xpath->evaluate('atom:author/poco:preferredUsername/text()')->item(0)->nodeValue;
-               if ($value != "")
-                       $author["author-nick"] = $value;
+               if ($simulate) {
+                       $author["author-id"] = $xpath->evaluate('/atom:feed/atom:author/atom:uri/text()')->item(0)->nodeValue;
+
+                       $value = $xpath->evaluate('atom:author/poco:preferredUsername/text()')->item(0)->nodeValue;
+                       if ($value != "")
+                               $author["author-nick"] = $value;
+
+                       $value = $xpath->evaluate('atom:author/poco:address/poco:formatted/text()', $context)->item(0)->nodeValue;
+                       if ($value != "")
+                               $author["author-location"] = $value;
+
+                       $value = $xpath->evaluate('atom:author/poco:note/text()')->item(0)->nodeValue;
+                       if ($value != "")
+                               $author["author-about"] = $value;
+
+               }
 
                $author["edited"] = $author["created"] = $xpath->query('/atom:feed/atom:updated/text()')->item(0)->nodeValue;
 
@@ -102,7 +131,7 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
                $entries = $xpath->query('/rss/channel/item');
        }
 
-       if (is_array($contact)) {
+       if (!$simulate) {
                $author["author-link"] = $contact["url"];
 
                if ($author["author-name"] == "")
@@ -133,8 +162,10 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
                $header["last-child"] = 0;
        }
 
-       if (!is_object($entries))
+       if (!is_object($entries)) {
+               logger("There are no entries in this feed.", LOGGER_DEBUG);
                return;
+       }
 
        $items = array();
 
@@ -294,6 +325,14 @@ function feed_import($xml,$importer,&$contact, &$hub, $simulate = false) {
                        logger("Stored feed: ".print_r($item, true), LOGGER_DEBUG);
 
                        $notify = item_is_remote_self($contact, $item);
+
+                       // Distributed items should have a well formatted URI.
+                       // Additionally we have to avoid conflicts with identical URI between imported feeds and these items.
+                       if ($notify) {
+                               unset($item['uri']);
+                               unset($item['parent-uri']);
+                       }
+
                        $id = item_store($item, false, $notify);
 
                        logger("Feed for contact ".$contact["url"]." stored under id ".$id);