]> git.mxchange.org Git - friendica.git/blobdiff - include/identity.php
Issue 3857: There is the possibility of a bad handling of dislikes
[friendica.git] / include / identity.php
index 1fea5b25d659880ed1e07cb4c501f53c364b4d62..3686b23d2d312473a9ffe19cad04f100aee67184 100644 (file)
@@ -3,10 +3,13 @@
  * @file include/identity.php
  */
 
-require_once('include/ForumManager.php');
-require_once('include/bbcode.php');
-require_once("mod/proxy.php");
-require_once('include/cache.php');
+use Friendica\App;
+use Friendica\Core\System;
+
+require_once 'include/ForumManager.php';
+require_once 'include/bbcode.php';
+require_once 'mod/proxy.php';
+require_once 'include/cache.php';
 
 /**
  *
@@ -47,7 +50,7 @@ function profile_load(App $a, $nickname, $profile = 0, $profiledata = array()) {
 
        $pdata = get_profiledata_by_nick($nickname, $user[0]['uid'], $profile);
 
-       if (($pdata === false) || (!count($pdata)) && !count($profiledata)) {
+       if (empty($pdata) && empty($profiledata)) {
                logger('profile error: ' . $a->query_string, LOGGER_DEBUG);
                notice( t('Requested profile is not available.') . EOL );
                $a->error = 404;
@@ -83,9 +86,9 @@ function profile_load(App $a, $nickname, $profile = 0, $profiledata = array()) {
 
        $a->set_template_engine(); // reset the template engine to the default in case the user's theme doesn't specify one
 
-       $theme_info_file = "view/theme/".current_theme()."/theme.php";
-       if (file_exists($theme_info_file)){
-               require_once($theme_info_file);
+       $theme_info_file = "view/theme/" . current_theme() . "/theme.php";
+       if (file_exists($theme_info_file)) {
+               require_once $theme_info_file;
        }
 
        if (! (x($a->page,'aside')))
@@ -134,45 +137,47 @@ function profile_load(App $a, $nickname, $profile = 0, $profiledata = array()) {
  */
 function get_profiledata_by_nick($nickname, $uid = 0, $profile = 0) {
        if (remote_user() && count($_SESSION['remote'])) {
-                       foreach ($_SESSION['remote'] as $visitor) {
-                               if ($visitor['uid'] == $uid) {
-                                       $r = q("SELECT `profile-id` FROM `contact` WHERE `id` = %d LIMIT 1",
-                                               intval($visitor['cid'])
-                                       );
-                                       if (dbm::is_result($r))
-                                               $profile = $r[0]['profile-id'];
-                                       break;
+               foreach ($_SESSION['remote'] as $visitor) {
+                       if ($visitor['uid'] == $uid) {
+                               $r = dba::select('contact', array('profile-id'), array('id' => $visitor['cid']), array('limit' => 1));
+                               if (dbm::is_result($r)) {
+                                       $profile = $r['profile-id'];
                                }
+                               break;
                        }
                }
+       }
 
        $r = null;
 
        if ($profile) {
                $profile_int = intval($profile);
-               $r = q("SELECT `contact`.`id` AS `contact_id`, `profile`.`uid` AS `profile_uid`, `profile`.*,
+               $r = dba::fetch_first("SELECT `contact`.`id` AS `contact_id`, `contact`.`photo` AS `contact_photo`,
+                               `contact`.`thumb` AS `contact_thumb`, `contact`.`micro` AS `contact_micro`,
+                               `profile`.`uid` AS `profile_uid`, `profile`.*,
                                `contact`.`avatar-date` AS picdate, `contact`.`addr`, `user`.*
                        FROM `profile`
                        INNER JOIN `contact` on `contact`.`uid` = `profile`.`uid` AND `contact`.`self`
                        INNER JOIN `user` ON `profile`.`uid` = `user`.`uid`
-                       WHERE `user`.`nickname` = '%s' AND `profile`.`id` = %d LIMIT 1",
-                               dbesc($nickname),
-                               intval($profile_int)
+                       WHERE `user`.`nickname` = ? AND `profile`.`id` = ? LIMIT 1",
+                               $nickname,
+                               $profile_int
                );
        }
        if (!dbm::is_result($r)) {
-               $r = q("SELECT `contact`.`id` AS `contact_id`, `profile`.`uid` AS `profile_uid`, `profile`.*,
+               $r = dba::fetch_first("SELECT `contact`.`id` AS `contact_id`, `contact`.`photo` as `contact_photo`,
+                               `contact`.`thumb` AS `contact_thumb`, `contact`.`micro` AS `contact_micro`,
+                               `profile`.`uid` AS `profile_uid`, `profile`.*,
                                `contact`.`avatar-date` AS picdate, `contact`.`addr`, `user`.*
                        FROM `profile`
                        INNER JOIN `contact` ON `contact`.`uid` = `profile`.`uid` AND `contact`.`self`
                        INNER JOIN `user` ON `profile`.`uid` = `user`.`uid`
-                       WHERE `user`.`nickname` = '%s' AND `profile`.`is-default` LIMIT 1",
-                               dbesc($nickname)
+                       WHERE `user`.`nickname` = ? AND `profile`.`is-default` LIMIT 1",
+                               $nickname
                );
        }
 
-       return $r[0];
-
+       return $r;
 }
 
 
@@ -211,7 +216,7 @@ function profile_sidebar($profile, $block = 0) {
 
        $profile['picdate'] = urlencode($profile['picdate']);
 
-       if (($profile['network'] != "") AND ($profile['network'] != NETWORK_DFRN)) {
+       if (($profile['network'] != "") && ($profile['network'] != NETWORK_DFRN)) {
                $profile['network_name'] = format_network_name($profile['network'], $profile['url']);
        } else {
                $profile['network_name'] = "";
@@ -234,33 +239,31 @@ function profile_sidebar($profile, $block = 0) {
        }
 
        // Is the local user already connected to that user?
-       if ($connect AND local_user()) {
+       if ($connect && local_user()) {
                if (isset($profile["url"])) {
                        $profile_url = normalise_link($profile["url"]);
                } else {
-                       $profile_url = normalise_link(App::get_baseurl()."/profile/".$profile["nickname"]);
+                       $profile_url = normalise_link(System::baseUrl()."/profile/".$profile["nickname"]);
                }
 
-               $r = q("SELECT * FROM `contact` WHERE NOT `pending` AND `uid` = %d AND `nurl` = '%s'",
-                       local_user(), $profile_url);
-
-               if (dbm::is_result($r))
+               if (dba::exists('contact', array('pending' => false, 'uid' => local_user(), 'nurl' => $profile_url))) {
                        $connect = false;
+               }
        }
 
-       if ($connect AND ($profile['network'] != NETWORK_DFRN) AND !isset($profile['remoteconnect']))
+       if ($connect && ($profile['network'] != NETWORK_DFRN) && !isset($profile['remoteconnect']))
                $connect = false;
 
        $remoteconnect = NULL;
        if (isset($profile['remoteconnect']))
                $remoteconnect = $profile['remoteconnect'];
 
-       if ($connect AND ($profile['network'] == NETWORK_DFRN) AND !isset($remoteconnect))
+       if ($connect && ($profile['network'] == NETWORK_DFRN) && !isset($remoteconnect))
                $subscribe_feed = t("Atom feed");
        else
                $subscribe_feed = false;
 
-       if (remote_user() OR (get_my_url() && $profile['unkmail'] && ($profile['uid'] != local_user()))) {
+       if (remote_user() || (get_my_url() && $profile['unkmail'] && ($profile['uid'] != local_user()))) {
                $wallmessage = t('Message');
                $wallmessage_link = "wallmessage/".$profile["nickname"];
 
@@ -287,7 +290,7 @@ function profile_sidebar($profile, $block = 0) {
 
        // show edit profile to yourself
        if (!$is_contact && $profile['uid'] == local_user() && feature_enabled(local_user(),'multi_profiles')) {
-               $profile['edit'] = array(App::get_baseurl(). '/profiles', t('Profiles'),"", t('Manage/edit profiles'));
+               $profile['edit'] = array(System::baseUrl(). '/profiles', t('Profiles'),"", t('Manage/edit profiles'));
                $r = q("SELECT * FROM `profile` WHERE `uid` = %d",
                                local_user());
 
@@ -316,7 +319,7 @@ function profile_sidebar($profile, $block = 0) {
                }
        }
        if (!$is_contact && $profile['uid'] == local_user() && !feature_enabled(local_user(),'multi_profiles')) {
-               $profile['edit'] = array(App::get_baseurl(). '/profiles/'.$profile['id'], t('Edit profile'),"", t('Edit profile'));
+               $profile['edit'] = array(System::baseUrl(). '/profiles/'.$profile['id'], t('Edit profile'),"", t('Edit profile'));
                $profile['menu'] = array(
                        'chg_photo' => t('Change profile photo'),
                        'cr_new' => null,
@@ -357,23 +360,23 @@ function profile_sidebar($profile, $block = 0) {
        if ($profile['guid'] != "")
                $diaspora = array(
                        'guid' => $profile['guid'],
-                       'podloc' => App::get_baseurl(),
+                       'podloc' => System::baseUrl(),
                        'searchable' => (($profile['publish'] && $profile['net-publish']) ? 'true' : 'false' ),
                        'nickname' => $profile['nickname'],
                        'fullname' => $profile['name'],
                        'firstname' => $firstname,
                        'lastname' => $lastname,
-                       'photo300' => App::get_baseurl() . '/photo/custom/300/' . $profile['uid'] . '.jpg',
-                       'photo100' => App::get_baseurl() . '/photo/custom/100/' . $profile['uid'] . '.jpg',
-                       'photo50' => App::get_baseurl() . '/photo/custom/50/'  . $profile['uid'] . '.jpg',
+                       'photo300' => $profile['contact_photo'],
+                       'photo100' => $profile['contact_thumb'],
+                       'photo50' => $profile['contact_micro'],
                );
        else
                $diaspora = false;
 
-       if (!$block){
+       if (!$block) {
                $contact_block = contact_block();
 
-               if (is_array($a->profile) AND !$a->profile['hide-friends']) {
+               if (is_array($a->profile) && !$a->profile['hide-friends']) {
                        $r = q("SELECT `gcontact`.`updated` FROM `contact` INNER JOIN `gcontact` WHERE `gcontact`.`nurl` = `contact`.`nurl` AND `self` AND `uid` = %d LIMIT 1",
                                intval($a->profile['uid']));
                        if (dbm::is_result($r))
@@ -408,9 +411,9 @@ function profile_sidebar($profile, $block = 0) {
        else
                $p["address"] = bbcode($p["location"]);
 
-       if (isset($p["photo"]))
+       if (isset($p["photo"])) {
                $p["photo"] = proxy_url($p["photo"], false, PROXY_SIZE_SMALL);
-
+       }
        if ($a->theme['template_engine'] === 'internal')
                $location = template_escape($location);
 
@@ -465,15 +468,16 @@ function get_birthdays() {
        $cachekey = "get_birthdays:".local_user();
        $r = Cache::get($cachekey);
        if (is_null($r)) {
-               $r = q("SELECT `event`.*, `event`.`id` AS `eid`, `contact`.* FROM `event`
+               $s = dba::p("SELECT `event`.*, `event`.`id` AS `eid`, `contact`.* FROM `event`
                                INNER JOIN `contact` ON `contact`.`id` = `event`.`cid`
-                               WHERE `event`.`uid` = %d AND `type` = 'birthday' AND `start` < '%s' AND `finish` > '%s'
+                               WHERE `event`.`uid` = ? AND `type` = 'birthday' AND `start` < ? AND `finish` > ?
                                ORDER BY `start` ASC ",
-                               intval(local_user()),
-                               dbesc(datetime_convert('UTC','UTC','now + 6 days')),
-                               dbesc(datetime_convert('UTC','UTC','now'))
+                               local_user(),
+                               datetime_convert('UTC','UTC','now + 6 days'),
+                               datetime_convert('UTC','UTC','now')
                );
-               if (dbm::is_result($r)) {
+               if (dbm::is_result($s)) {
+                       $r = dba::inArray($s);
                        Cache::set($cachekey, $r, CACHE_HOUR);
                }
        }
@@ -506,7 +510,7 @@ function get_birthdays() {
                                $url = $rr['url'];
                                if ($rr['network'] === NETWORK_DFRN) {
                                        $sparkle = " sparkle";
-                                       $url = App::get_baseurl() . '/redir/'  . $rr['cid'];
+                                       $url = System::baseUrl() . '/redir/'  . $rr['cid'];
                                }
 
                                $rr['link'] = $url;
@@ -520,7 +524,7 @@ function get_birthdays() {
        }
        $tpl = get_markup_template("birthdays_reminder.tpl");
        return replace_macros($tpl, array(
-               '$baseurl' => App::get_baseurl(),
+               '$baseurl' => System::baseUrl(),
                '$classtoday' => $classtoday,
                '$count' => $total,
                '$event_reminders' => t('Birthday Reminders'),
@@ -535,13 +539,13 @@ function get_birthdays() {
 
 function get_events() {
 
-       require_once('include/bbcode.php');
+       require_once 'include/bbcode.php';
 
        $a = get_app();
 
-       if (! local_user() || $a->is_mobile || $a->is_tablet)
+       if (! local_user() || $a->is_mobile || $a->is_tablet) {
                return $o;
-
+       }
 
 //             $mobile_detect = new Mobile_Detect();
 //             $is_mobile = $mobile_detect->isMobile() || $mobile_detect->isTablet();
@@ -552,43 +556,44 @@ function get_events() {
        $bd_format = t('g A l F d') ; // 8 AM Friday January 18
        $bd_short = t('F d');
 
-       $r = q("SELECT `event`.* FROM `event`
-                       WHERE `event`.`uid` = %d AND `type` != 'birthday' AND `start` < '%s' AND `start` >= '%s'
+       $s = dba::p("SELECT `event`.* FROM `event`
+                       WHERE `event`.`uid` = ? AND `type` != 'birthday' AND `start` < ? AND `start` >= ?
                        ORDER BY `start` ASC ",
-                       intval(local_user()),
-                       dbesc(datetime_convert('UTC','UTC','now + 7 days')),
-                       dbesc(datetime_convert('UTC','UTC','now - 1 days'))
+                       local_user(),
+                       datetime_convert('UTC','UTC','now + 7 days'),
+                       datetime_convert('UTC','UTC','now - 1 days')
        );
 
-       if (dbm::is_result($r)) {
+       $r = array();
+
+       if (dbm::is_result($s)) {
                $now = strtotime('now');
                $istoday = false;
-               foreach ($r as $rr) {
-                       if (strlen($rr['name']))
+
+               while ($rr = dba::fetch($s)) {
+                       if (strlen($rr['name'])) {
                                $total ++;
+                       }
 
                        $strt = datetime_convert('UTC',$rr['convert'] ? $a->timezone : 'UTC',$rr['start'],'Y-m-d');
-                       if ($strt === datetime_convert('UTC',$a->timezone,'now','Y-m-d'))
+                       if ($strt === datetime_convert('UTC',$a->timezone,'now','Y-m-d')) {
                                $istoday = true;
-               }
-               $classtoday = (($istoday) ? 'event-today' : '');
-
-               $skip = 0;
+                       }
 
-               foreach ($r as &$rr) {
                        $title = strip_tags(html_entity_decode(bbcode($rr['summary']),ENT_QUOTES,'UTF-8'));
 
-                       if (strlen($title) > 35)
+                       if (strlen($title) > 35) {
                                $title = substr($title,0,32) . '... ';
+                       }
 
                        $description = substr(strip_tags(bbcode($rr['desc'])),0,32) . '... ';
-                       if (! $description)
+                       if (! $description) {
                                $description = t('[No description]');
+                       }
 
                        $strt = datetime_convert('UTC',$rr['convert'] ? $a->timezone : 'UTC',$rr['start']);
 
                        if (substr($strt,0,10) < datetime_convert('UTC',$a->timezone,'now','Y-m-d')) {
-                               $skip++;
                                continue;
                        }
 
@@ -599,14 +604,17 @@ function get_events() {
                        $rr['date'] = day_translate(datetime_convert('UTC', $rr['adjust'] ? $a->timezone : 'UTC', $rr['start'], $bd_format)) . (($today) ?  ' ' . t('[today]') : '');
                        $rr['startime'] = $strt;
                        $rr['today'] = $today;
+
+                       $r[] = $rr;
                }
+               dba::close($s);
+               $classtoday = (($istoday) ? 'event-today' : '');
        }
-
        $tpl = get_markup_template("events_reminder.tpl");
        return replace_macros($tpl, array(
-               '$baseurl' => App::get_baseurl(),
+               '$baseurl' => System::baseUrl(),
                '$classtoday' => $classtoday,
-               '$count' => count($r) - $skip,
+               '$count' => count($r),
                '$event_reminders' => t('Event Reminders'),
                '$event_title' => t('Events this week:'),
                '$events' => $r,
@@ -630,7 +638,9 @@ function advanced_profile(App $a) {
 
                $profile['fullname'] = array( t('Full Name:'), $a->profile['name'] ) ;
 
-               if ($a->profile['gender']) $profile['gender'] = array( t('Gender:'),  $a->profile['gender'] );
+               if ($a->profile['gender']) {
+                       $profile['gender'] = array( t('Gender:'),  $a->profile['gender'] );
+               }
 
                if (($a->profile['dob']) && ($a->profile['dob'] > '0001-01-01')) {
                        $year_bd_format = t('j F, Y');
@@ -644,11 +654,16 @@ function advanced_profile(App $a) {
                        $profile['birthday'] = array( t('Birthday:'), $val);
 
                }
+               if (!empty($a->profile['dob'])
+                       && $a->profile['dob'] > '0001-01-01'
+                       && $age = age($a->profile['dob'], $a->profile['timezone'], '')
+               ) {
+                       $profile['age'] = array( t('Age:'), $age );
+               }
 
-               if ($age = age($a->profile['dob'],$a->profile['timezone'],''))  $profile['age'] = array( t('Age:'), $age );
-
-
-               if ($a->profile['marital']) $profile['marital'] = array( t('Status:'), $a->profile['marital']);
+               if ($a->profile['marital']) {
+                       $profile['marital'] = array( t('Status:'), $a->profile['marital']);
+               }
 
                /// @TODO Maybe use x() here, plus below?
                if ($a->profile['with']) {
@@ -737,7 +752,7 @@ function advanced_profile(App $a) {
                }
 
                if ($a->profile['uid'] == local_user()) {
-                       $profile['edit'] = array(App::get_baseurl(). '/profiles/'.$a->profile['id'], t('Edit profile'),"", t('Edit profile'));
+                       $profile['edit'] = array(System::baseUrl(). '/profiles/'.$a->profile['id'], t('Edit profile'),"", t('Edit profile'));
                }
 
                return replace_macros($tpl, array(
@@ -751,7 +766,7 @@ function advanced_profile(App $a) {
        return '';
 }
 
-function profile_tabs($a, $is_owner=False, $nickname=Null){
+function profile_tabs($a, $is_owner=False, $nickname=Null) {
        //echo "<pre>"; var_dump($a->user); killme();
 
        if (is_null($nickname)) {
@@ -762,13 +777,13 @@ function profile_tabs($a, $is_owner=False, $nickname=Null){
                $tab = notags(trim($_GET['tab']));
        }
 
-       $url = App::get_baseurl() . '/profile/' . $nickname;
+       $url = System::baseUrl() . '/profile/' . $nickname;
 
        $tabs = array(
                array(
                        'label'=>t('Status'),
                        'url' => $url,
-                       'sel' => ((!isset($tab) && $a->argv[0]=='profile')?'active':''),
+                       'sel' => ((!isset($tab) && $a->argv[0]=='profile') ? 'active' : ''),
                        'title' => t('Status Messages and Posts'),
                        'id' => 'status-tab',
                        'accesskey' => 'm',
@@ -776,23 +791,23 @@ function profile_tabs($a, $is_owner=False, $nickname=Null){
                array(
                        'label' => t('Profile'),
                        'url'   => $url.'/?tab=profile',
-                       'sel'   => ((isset($tab) && $tab=='profile')?'active':''),
+                       'sel'   => ((isset($tab) && $tab=='profile') ? 'active' : ''),
                        'title' => t('Profile Details'),
                        'id' => 'profile-tab',
                        'accesskey' => 'r',
                ),
                array(
                        'label' => t('Photos'),
-                       'url'   => App::get_baseurl() . '/photos/' . $nickname,
-                       'sel'   => ((!isset($tab) && $a->argv[0]=='photos')?'active':''),
+                       'url'   => System::baseUrl() . '/photos/' . $nickname,
+                       'sel'   => ((!isset($tab) && $a->argv[0]=='photos') ? 'active' : ''),
                        'title' => t('Photo Albums'),
                        'id' => 'photo-tab',
                        'accesskey' => 'h',
                ),
                array(
                        'label' => t('Videos'),
-                       'url'   => App::get_baseurl() . '/videos/' . $nickname,
-                       'sel'   => ((!isset($tab) && $a->argv[0]=='videos')?'active':''),
+                       'url'   => System::baseUrl() . '/videos/' . $nickname,
+                       'sel'   => ((!isset($tab) && $a->argv[0]=='videos') ? 'active' : ''),
                        'title' => t('Videos'),
                        'id' => 'video-tab',
                        'accesskey' => 'v',
@@ -803,8 +818,8 @@ function profile_tabs($a, $is_owner=False, $nickname=Null){
        if ($is_owner && $a->theme_events_in_profile) {
                        $tabs[] = array(
                                'label' => t('Events'),
-                               'url'   => App::get_baseurl() . '/events',
-                               'sel'   =>((!isset($tab) && $a->argv[0]=='events')?'active':''),
+                               'url'   => System::baseUrl() . '/events',
+                               'sel'   =>((!isset($tab) && $a->argv[0]=='events') ? 'active' : ''),
                                'title' => t('Events and Calendar'),
                                'id' => 'events-tab',
                                'accesskey' => 'e',
@@ -814,19 +829,19 @@ function profile_tabs($a, $is_owner=False, $nickname=Null){
        } elseif (! $is_owner) {
                $tabs[] = array(
                                'label' => t('Events'),
-                               'url'   => App::get_baseurl() . '/cal/' . $nickname,
-                               'sel'   =>((!isset($tab) && $a->argv[0]=='cal')?'active':''),
+                               'url'   => System::baseUrl() . '/cal/' . $nickname,
+                               'sel'   =>((!isset($tab) && $a->argv[0]=='cal') ? 'active' : ''),
                                'title' => t('Events and Calendar'),
                                'id' => 'events-tab',
                                'accesskey' => 'e',
                        );
        }
 
-       if ($is_owner){
+       if ($is_owner) {
                $tabs[] = array(
                        'label' => t('Personal Notes'),
-                       'url'   => App::get_baseurl() . '/notes',
-                       'sel'   =>((!isset($tab) && $a->argv[0]=='notes')?'active':''),
+                       'url'   => System::baseUrl() . '/notes',
+                       'sel'   =>((!isset($tab) && $a->argv[0]=='notes') ? 'active' : ''),
                        'title' => t('Only You Can See This'),
                        'id' => 'notes-tab',
                        'accesskey' => 't',
@@ -836,8 +851,8 @@ function profile_tabs($a, $is_owner=False, $nickname=Null){
        if ((! $is_owner) && ((count($a->profile)) || (! $a->profile['hide-friends']))) {
                $tabs[] = array(
                        'label' => t('Contacts'),
-                       'url'   => App::get_baseurl() . '/viewcontacts/' . $nickname,
-                       'sel'   => ((!isset($tab) && $a->argv[0]=='viewcontacts')?'active':''),
+                       'url'   => System::baseUrl() . '/viewcontacts/' . $nickname,
+                       'sel'   => ((!isset($tab) && $a->argv[0]=='viewcontacts') ? 'active' : ''),
                        'title' => t('Contacts'),
                        'id' => 'viewcontacts-tab',
                        'accesskey' => 'k',
@@ -853,8 +868,9 @@ function profile_tabs($a, $is_owner=False, $nickname=Null){
 }
 
 function get_my_url() {
-       if (x($_SESSION,'my_url'))
+       if (x($_SESSION, 'my_url')) {
                return $_SESSION['my_url'];
+       }
        return false;
 }
 
@@ -866,33 +882,31 @@ function zrl_init(App $a) {
                // The check fetches the cached value from gprobe to reduce the load for this system
                $urlparts = parse_url($tmp_str);
 
-               $result = Cache::get("gprobe:".$urlparts["host"]);
-               if (!is_null($result)) {
-                       if (in_array($result["network"], array(NETWORK_FEED, NETWORK_PHANTOM))) {
-                               logger("DDoS attempt detected for ".$urlparts["host"]." by ".$_SERVER["REMOTE_ADDR"].". server data: ".print_r($_SERVER, true), LOGGER_DEBUG);
-                               return;
-                       }
+               $result = Cache::get("gprobe:" . $urlparts["host"]);
+               if ((!is_null($result)) && (in_array($result["network"], array(NETWORK_FEED, NETWORK_PHANTOM)))) {
+                       logger("DDoS attempt detected for " . $urlparts["host"] . " by " . $_SERVER["REMOTE_ADDR"] . ". server data: " . print_r($_SERVER, true), LOGGER_DEBUG);
+                       return;
                }
 
-               proc_run(PRIORITY_LOW, 'include/gprobe.php',bin2hex($tmp_str));
+               proc_run(PRIORITY_LOW, 'include/gprobe.php', $tmp_str);
                $arr = array('zrl' => $tmp_str, 'url' => $a->cmd);
-               call_hooks('zrl_init',$arr);
+               call_hooks('zrl_init', $arr);
        }
 }
 
-function zrl($s,$force = false) {
+function zrl($s, $force = false) {
        if (! strlen($s)) {
                return $s;
        }
-       if ((! strpos($s,'/profile/')) && (! $force)) {
+       if ((! strpos($s, '/profile/')) && (! $force)) {
                return $s;
        }
-       if ($force && substr($s,-1,1) !== '/') {
+       if ($force && substr($s, -1, 1) !== '/') {
                $s = $s . '/';
        }
-       $achar = strpos($s,'?') ? '&' : '?';
+       $achar = strpos($s, '?') ? '&' : '?';
        $mine = get_my_url();
-       if ($mine and ! link_compare($mine,$s)) {
+       if ($mine && ! link_compare($mine, $s)) {
                return $s . $achar . 'zrl=' . urlencode($mine);
        }
        return $s;
@@ -913,11 +927,9 @@ function zrl($s,$force = false) {
  *      is set to true
  */
 function get_theme_uid() {
-       $uid = (($_REQUEST['puid']) ? intval($_REQUEST['puid']) : 0);
-       if (local_user()) {
-               if ((get_pconfig(local_user(),'system','always_my_theme')) || (! $uid)) {
-                       return local_user();
-               }
+       $uid = ((!empty($_REQUEST['puid'])) ? intval($_REQUEST['puid']) : 0);
+       if ((local_user()) && ((get_pconfig(local_user(), 'system', 'always_my_theme')) || (! $uid))) {
+               return local_user();
        }
 
        return $uid;