<?php
-require_once('include/bbcode.php');
-require_once('include/oembed.php');
-require_once('include/salmon.php');
-require_once('include/crypto.php');
-require_once('include/Photo.php');
-require_once('include/tags.php');
-require_once('include/files.php');
-require_once('include/text.php');
-require_once('include/email.php');
-require_once('include/threads.php');
-require_once('include/socgraph.php');
-require_once('include/plaintext.php');
-require_once('include/ostatus.php');
-require_once('include/feed.php');
-require_once('include/Contact.php');
-require_once('mod/share.php');
-require_once('include/enotify.php');
-require_once('include/dfrn.php');
-require_once('include/group.php');
-
-require_once('library/defuse/php-encryption-1.2.1/Crypto.php');
+/**
+ * @file include/items.php
+ */
+
+use Friendica\App;
+use Friendica\ParseUrl;
+
+require_once 'include/bbcode.php';
+require_once 'include/oembed.php';
+require_once 'include/salmon.php';
+require_once 'include/crypto.php';
+require_once 'include/Photo.php';
+require_once 'include/tags.php';
+require_once 'include/files.php';
+require_once 'include/text.php';
+require_once 'include/email.php';
+require_once 'include/threads.php';
+require_once 'include/socgraph.php';
+require_once 'include/plaintext.php';
+require_once 'include/ostatus.php';
+require_once 'include/feed.php';
+require_once 'include/Contact.php';
+require_once 'mod/share.php';
+require_once 'include/enotify.php';
+require_once 'include/dfrn.php';
+require_once 'include/group.php';
+
+/// @TODO one day with composer autoloader no more needed
+require_once 'library/defuse/php-encryption-1.2.1/Crypto.php';
function construct_verb($item) {
- if($item['verb'])
+ if ($item['verb']) {
return $item['verb'];
+ }
return ACTIVITY_POST;
}
* The purpose of this function is to apply system message length limits to
* imported messages without including any embedded photos in the length
*/
-if(! function_exists('limit_body_size')) {
+if (! function_exists('limit_body_size')) {
function limit_body_size($body) {
// logger('limit_body_size: start', LOGGER_DEBUG);
// If the length of the body, including the embedded images, is smaller
// than the maximum, then don't waste time looking for the images
- if($maxlen && (strlen($body) > $maxlen)) {
+ if ($maxlen && (strlen($body) > $maxlen)) {
logger('limit_body_size: the total body length exceeds the limit', LOGGER_DEBUG);
$img_start = strpos($orig_body, '[img');
$img_st_close = ($img_start !== false ? strpos(substr($orig_body, $img_start), ']') : false);
$img_end = ($img_start !== false ? strpos(substr($orig_body, $img_start), '[/img]') : false);
- while(($img_st_close !== false) && ($img_end !== false)) {
+ while (($img_st_close !== false) && ($img_end !== false)) {
$img_st_close++; // make it point to AFTER the closing bracket
$img_end += $img_start;
$img_end += strlen('[/img]');
- if(! strcmp(substr($orig_body, $img_start + $img_st_close, 5), 'data:')) {
+ if (! strcmp(substr($orig_body, $img_start + $img_st_close, 5), 'data:')) {
// This is an embedded image
- if( ($textlen + $img_start) > $maxlen ) {
- if($textlen < $maxlen) {
+ if (($textlen + $img_start) > $maxlen ) {
+ if ($textlen < $maxlen) {
logger('limit_body_size: the limit happens before an embedded image', LOGGER_DEBUG);
$new_body = $new_body . substr($orig_body, 0, $maxlen - $textlen);
$textlen = $maxlen;
}
- }
- else {
+ } else {
$new_body = $new_body . substr($orig_body, 0, $img_start);
$textlen += $img_start;
}
$new_body = $new_body . substr($orig_body, $img_start, $img_end - $img_start);
- }
- else {
+ } else {
- if( ($textlen + $img_end) > $maxlen ) {
- if($textlen < $maxlen) {
+ if (($textlen + $img_end) > $maxlen ) {
+ if ($textlen < $maxlen) {
logger('limit_body_size: the limit happens before the end of a non-embedded image', LOGGER_DEBUG);
$new_body = $new_body . substr($orig_body, 0, $maxlen - $textlen);
$textlen = $maxlen;
}
- }
- else {
+ } else {
$new_body = $new_body . substr($orig_body, 0, $img_end);
$textlen += $img_end;
}
}
$orig_body = substr($orig_body, $img_end);
- if($orig_body === false) // in case the body ends on a closing image tag
+ if ($orig_body === false) {
+ // in case the body ends on a closing image tag
$orig_body = '';
+ }
$img_start = strpos($orig_body, '[img');
$img_st_close = ($img_start !== false ? strpos(substr($orig_body, $img_start), ']') : false);
$img_end = ($img_start !== false ? strpos(substr($orig_body, $img_start), '[/img]') : false);
}
- if( ($textlen + strlen($orig_body)) > $maxlen) {
- if($textlen < $maxlen) {
+ if (($textlen + strlen($orig_body)) > $maxlen) {
+ if ($textlen < $maxlen) {
logger('limit_body_size: the limit happens after the end of the last image', LOGGER_DEBUG);
$new_body = $new_body . substr($orig_body, 0, $maxlen - $textlen);
$textlen = $maxlen;
}
- }
- else {
+ } else {
logger('limit_body_size: the text size with embedded images extracted did not violate the limit', LOGGER_DEBUG);
$new_body = $new_body . $orig_body;
$textlen += strlen($orig_body);
}
return $new_body;
- }
- else
+ } else {
return $body;
+ }
}}
function title_is_body($title, $body) {
$title = strip_tags($title);
$title = trim($title);
$title = html_entity_decode($title, ENT_QUOTES, 'UTF-8');
- $title = str_replace(array("\n", "\r", "\t", " "), array("","","",""), $title);
+ $title = str_replace(array("\n", "\r", "\t", " "), array("", "", "", ""), $title);
$body = strip_tags($body);
$body = trim($body);
$body = html_entity_decode($body, ENT_QUOTES, 'UTF-8');
- $body = str_replace(array("\n", "\r", "\t", " "), array("","","",""), $body);
+ $body = str_replace(array("\n", "\r", "\t", " "), array("", "", "", ""), $body);
- if (strlen($title) < strlen($body))
+ if (strlen($title) < strlen($body)) {
$body = substr($body, 0, strlen($title));
+ }
if (($title != $body) and (substr($title, -3) == "...")) {
$pos = strrpos($title, "...");
}
}
- return($title == $body);
+ return ($title == $body);
}
function add_page_info_data($data) {
// It maybe is a rich content, but if it does have everything that a link has,
// then treat it that way
if (($data["type"] == "rich") AND is_string($data["title"]) AND
- is_string($data["text"]) AND (sizeof($data["images"]) > 0))
+ is_string($data["text"]) AND (sizeof($data["images"]) > 0)) {
$data["type"] = "link";
+ }
- if ((($data["type"] != "link") AND ($data["type"] != "video") AND ($data["type"] != "photo")) OR ($data["title"] == $url))
- return("");
+ if ((($data["type"] != "link") AND ($data["type"] != "video") AND ($data["type"] != "photo")) OR ($data["title"] == $data["url"])) {
+ return "";
+ }
- if ($no_photos AND ($data["type"] == "photo"))
- return("");
+ if ($no_photos AND ($data["type"] == "photo")) {
+ return "";
+ }
- if (sizeof($data["images"]) > 0)
+ if (sizeof($data["images"]) > 0) {
$preview = $data["images"][0];
- else
+ } else {
$preview = "";
+ }
// Escape some bad characters
$data["url"] = str_replace(array("[", "]"), array("[", "]"), htmlentities($data["url"], ENT_QUOTES, 'UTF-8', false));
$text = "[attachment type='".$data["type"]."'";
- if ($data["url"] != "")
+ if ($data["text"] == "") {
+ $data["text"] = $data["title"];
+ }
+
+ if ($data["text"] == "") {
+ $data["text"] = $data["url"];
+ }
+
+ if ($data["url"] != "") {
$text .= " url='".$data["url"]."'";
- if ($data["title"] != "")
+ }
+
+ if ($data["title"] != "") {
$text .= " title='".$data["title"]."'";
+ }
+
if (sizeof($data["images"]) > 0) {
$preview = str_replace(array("[", "]"), array("[", "]"), htmlentities($data["images"][0]["src"], ENT_QUOTES, 'UTF-8', false));
// if the preview picture is larger than 500 pixels then show it in a larger mode
// But only, if the picture isn't higher than large (To prevent huge posts)
- if (($data["images"][0]["width"] >= 500) AND ($data["images"][0]["width"] >= $data["images"][0]["height"]))
+ if (($data["images"][0]["width"] >= 500) AND ($data["images"][0]["width"] >= $data["images"][0]["height"])) {
$text .= " image='".$preview."'";
- else
+ } else {
$text .= " preview='".$preview."'";
+ }
}
+
$text .= "]".$data["text"]."[/attachment]";
$hashtags = "";
if (isset($data["keywords"]) AND count($data["keywords"])) {
- $a = get_app();
$hashtags = "\n";
foreach ($data["keywords"] AS $keyword) {
/// @todo make a positive list of allowed characters
$hashtag = str_replace(array(" ", "+", "/", ".", "#", "'", "’", "`", "(", ")", "„", "“"),
- array("","", "", "", "", "", "", "", "", "", "", ""), $keyword);
- $hashtags .= "#[url=".$a->get_baseurl()."/search?tag=".rawurlencode($hashtag)."]".$hashtag."[/url] ";
+ array("", "", "", "", "", "", "", "", "", "", "", ""), $keyword);
+ $hashtags .= "#[url=" . App::get_baseurl() . "/search?tag=" . rawurlencode($hashtag) . "]" . $hashtag . "[/url] ";
}
}
}
function query_page_info($url, $no_photos = false, $photo = "", $keywords = false, $keyword_blacklist = "") {
- require_once("mod/parse_url.php");
- $data = parseurl_getsiteinfo_cached($url, true);
+ $data = ParseUrl::getSiteinfoCached($url, true);
- if ($photo != "")
+ if ($photo != "") {
$data["images"][0]["src"] = $photo;
+ }
- logger('fetch page info for '.$url.' '.print_r($data, true), LOGGER_DEBUG);
+ logger('fetch page info for ' . $url . ' ' . print_r($data, true), LOGGER_DEBUG);
- if (!$keywords AND isset($data["keywords"]))
+ if (!$keywords AND isset($data["keywords"])) {
unset($data["keywords"]);
+ }
if (($keyword_blacklist != "") AND isset($data["keywords"])) {
- $list = explode(",", $keyword_blacklist);
+ $list = explode(", ", $keyword_blacklist);
foreach ($list AS $keyword) {
$keyword = trim($keyword);
$index = array_search($keyword, $data["keywords"]);
- if ($index !== false)
+ if ($index !== false) {
unset($data["keywords"][$index]);
+ }
}
}
- return($data);
+ return $data;
}
function add_page_keywords($url, $no_photos = false, $photo = "", $keywords = false, $keyword_blacklist = "") {
$tags = "";
if (isset($data["keywords"]) AND count($data["keywords"])) {
- $a = get_app();
foreach ($data["keywords"] AS $keyword) {
$hashtag = str_replace(array(" ", "+", "/", ".", "#", "'"),
- array("","", "", "", "", ""), $keyword);
+ array("", "", "", "", "", ""), $keyword);
- if ($tags != "")
- $tags .= ",";
+ if ($tags != "") {
+ $tags .= ", ";
+ }
- $tags .= "#[url=".$a->get_baseurl()."/search?tag=".rawurlencode($hashtag)."]".$hashtag."[/url]";
+ $tags .= "#[url=" . App::get_baseurl() . "/search?tag=" . rawurlencode($hashtag) . "]" . $hashtag . "[/url]";
}
}
- return($tags);
+ return $tags;
}
function add_page_info($url, $no_photos = false, $photo = "", $keywords = false, $keyword_blacklist = "") {
$text = add_page_info_data($data);
- return($text);
+ return $text;
}
function add_page_info_to_body($body, $texturl = false, $no_photos = false) {
- logger('add_page_info_to_body: fetch page info for body '.$body, LOGGER_DEBUG);
+ logger('add_page_info_to_body: fetch page info for body ' . $body, LOGGER_DEBUG);
$URLSearchString = "^\[\]";
+ // Fix for Mastodon where the mentions are in a different format
+ $body = preg_replace("/\[url\=([$URLSearchString]*)\]([#!@])(.*?)\[\/url\]/ism",
+ '$2[url=$1]$3[/url]', $body);
+
// Adding these spaces is a quick hack due to my problems with regular expressions :)
- preg_match("/[^!#@]\[url\]([$URLSearchString]*)\[\/url\]/ism", " ".$body, $matches);
+ preg_match("/[^!#@]\[url\]([$URLSearchString]*)\[\/url\]/ism", " " . $body, $matches);
- if (!$matches)
- preg_match("/[^!#@]\[url\=([$URLSearchString]*)\](.*?)\[\/url\]/ism", " ".$body, $matches);
+ if (!$matches) {
+ preg_match("/[^!#@]\[url\=([$URLSearchString]*)\](.*?)\[\/url\]/ism", " " . $body, $matches);
+ }
// Convert urls without bbcode elements
if (!$matches AND $texturl) {
preg_match("/([^\]\='".'"'."]|^)(https?\:\/\/[a-zA-Z0-9\:\/\-\?\&\;\.\=\_\~\#\%\$\!\+\,]+)/ism", " ".$body, $matches);
// Yeah, a hack. I really hate regular expressions :)
- if ($matches)
+ if ($matches) {
$matches[1] = $matches[2];
+ }
}
- if ($matches)
+ if ($matches) {
$footer = add_page_info($matches[1], $no_photos);
+ }
// Remove the link from the body if the link is attached at the end of the post
if (isset($footer) AND (trim($footer) != "") AND (strpos($footer, $matches[1]))) {
$removedlink = trim(str_replace($matches[1], "", $body));
- if (($removedlink == "") OR strstr($body, $removedlink))
+ if (($removedlink == "") OR strstr($body, $removedlink)) {
$body = $removedlink;
+ }
$url = str_replace(array('/', '.'), array('\/', '\.'), $matches[1]);
- $removedlink = preg_replace("/\[url\=".$url."\](.*?)\[\/url\]/ism", '', $body);
- if (($removedlink == "") OR strstr($body, $removedlink))
+ $removedlink = preg_replace("/\[url\=" . $url . "\](.*?)\[\/url\]/ism", '', $body);
+ if (($removedlink == "") OR strstr($body, $removedlink)) {
$body = $removedlink;
+ }
}
// Add the page information to the bottom
- if (isset($footer) AND (trim($footer) != ""))
+ if (isset($footer) AND (trim($footer) != "")) {
$body .= $footer;
+ }
return $body;
}
* Adds a "lang" specification in a "postopts" element of given $arr,
* if possible and not already present.
* Expects "body" element to exist in $arr.
- *
+ *
* @todo Add a parameter to request forcing override
*/
function item_add_language_opt(&$arr) {
- if (version_compare(PHP_VERSION, '5.3.0', '<')) return; // LanguageDetect.php not available ?
+ if (version_compare(PHP_VERSION, '5.3.0', '<')) {
+ // LanguageDetect.php not available ?
+ return;
+ }
- if ( x($arr, 'postopts') )
- {
- if ( strstr($arr['postopts'], 'lang=') )
- {
+ if (x($arr, 'postopts') ) {
+ if (strstr($arr['postopts'], 'lang=') ) {
// do not override
/// @TODO Add parameter to request overriding
return;
}
$postopts = $arr['postopts'];
- }
- else
- {
+ } else {
$postopts = "";
}
require_once('library/langdet/Text/LanguageDetect.php');
- $naked_body = preg_replace('/\[(.+?)\]/','',$arr['body']);
- $l = new Text_LanguageDetect;
+
+ $naked_body = preg_replace('/\[(.+?)\]/','', $arr['body']);
+ $l = new Text_LanguageDetect();
//$lng = $l->detectConfidence($naked_body);
//$arr['postopts'] = (($lng['language']) ? 'lang=' . $lng['language'] . ';' . $lng['confidence'] : '');
$lng = $l->detect($naked_body, 3);
$postopts .= 'lang=';
$sep = "";
foreach ($lng as $language => $score) {
- $postopts .= $sep . $language.";".$score;
+ $postopts .= $sep . $language . ";" . $score;
$sep = ':';
}
$arr['postopts'] = $postopts;
* @brief Creates an unique guid out of a given uri
*
* @param string $uri uri of an item entry
+ * @param string $host (Optional) hostname for the GUID prefix
* @return string unique guid
*/
-function uri_to_guid($uri) {
+function uri_to_guid($uri, $host = "") {
// Our regular guid routine is using this kind of prefix as well
// We have to avoid that different routines could accidentally create the same value
$parsed = parse_url($uri);
- $guid_prefix = hash("crc32", $parsed["host"]);
+
+ if ($host == "") {
+ $host = $parsed["host"];
+ }
+
+ $guid_prefix = hash("crc32", $host);
// Remove the scheme to make sure that "https" and "http" doesn't make a difference
unset($parsed["scheme"]);
return $guid_prefix.$host_hash;
}
-function item_store($arr,$force_parent = false, $notify = false, $dontcache = false) {
+/**
+ * @brief Store the conversation data
+ *
+ * @param array $arr Item array with conversation data
+ * @return array Item array with removed conversation data
+ */
+function store_conversation($arr) {
+ if (in_array($arr['network'], array(NETWORK_DFRN, NETWORK_DIASPORA, NETWORK_OSTATUS))) {
+ $conversation = array('item-uri' => $arr['uri'], 'received' => dbm::date());
+
+ if (isset($arr['parent-uri']) AND ($arr['parent-uri'] != $arr['uri'])) {
+ $conversation['reply-to-uri'] = $arr['parent-uri'];
+ }
+ if (isset($arr['thr-parent']) AND ($arr['thr-parent'] != $arr['uri'])) {
+ $conversation['reply-to-uri'] = $arr['thr-parent'];
+ }
+
+ if (isset($arr['conversation-uri'])) {
+ $conversation['conversation-uri'] = $arr['conversation-uri'];
+ }
+
+ if (isset($arr['conversation-href'])) {
+ $conversation['conversation-href'] = $arr['conversation-href'];
+ }
+
+ if (isset($arr['protocol'])) {
+ $conversation['protocol'] = $arr['protocol'];
+ }
+
+ if (isset($arr['source'])) {
+ $conversation['source'] = $arr['source'];
+ }
+
+ $old_conv = dba::fetch_first("SELECT `item-uri`, `reply-to-uri`, `conversation-uri`, `conversation-href`, `protocol`, `source`
+ FROM `conversation` WHERE `item-uri` = ?", $conversation['item-uri']);
+ if (dbm::is_result($old_conv)) {
+ // Don't update when only the source has changed.
+ // Only do this when there had been no source before.
+ if ($old_conv['source'] != '') {
+ unset($old_conv['source']);
+ }
+ // Update structure data all the time but the source only when its from a better protocol.
+ if (($old_conv['protocol'] < $conversation['protocol']) AND ($old_conv['protocol'] != 0)) {
+ unset($conversation['protocol']);
+ unset($conversation['source']);
+ }
+ if (!dba::update('conversation', $conversation, array('item-uri' => $conversation['item-uri']), $old_conv)) {
+ logger('Conversation: update for '.$conversation['item-uri'].' from '.$conv['protocol'].' to '.$conversation['protocol'].' failed', LOGGER_DEBUG);
+ }
+ } else {
+ if (!dba::insert('conversation', $conversation)) {
+ logger('Conversation: insert for '.$conversation['item-uri'].' (protocol '.$conversation['protocol'].') failed', LOGGER_DEBUG);
+ }
+ }
+ }
+
+ unset($arr['conversation-uri']);
+ unset($arr['conversation-href']);
+ unset($arr['protocol']);
+ unset($arr['source']);
+
+ return $arr;
+}
- $perfdb = $a->performance["database"];
- $perfdbw = $a->performance["database_write"];
- $perfnet = $a->performance["network"];
- $perffile = $a->performance["file"];
+/// @TODO add type-hint array
+function item_store($arr, $force_parent = false, $notify = false, $dontcache = false) {
- logger("Performance: Start", LOGGER_DEBUG);
+ $a = get_app();
// If it is a posting where users should get notifications, then define it as wall posting
if ($notify) {
$arr['origin'] = 1;
$arr['last-child'] = 1;
$arr['network'] = NETWORK_DFRN;
+ $arr['protocol'] = PROTOCOL_DFRN;
+
+ // We have to avoid duplicates. So we create the GUID in form of a hash of the plink or uri.
+ // In difference to the call to "uri_to_guid" several lines below we add the hash of our own host.
+ // This is done because our host is the original creator of the post.
+ if (!isset($arr['guid'])) {
+ if (isset($arr['plink'])) {
+ $arr['guid'] = uri_to_guid($arr['plink'], $a->get_hostname());
+ } elseif (isset($arr['uri'])) {
+ $arr['guid'] = uri_to_guid($arr['uri'], $a->get_hostname());
+ }
+ }
}
- // If a Diaspora signature structure was passed in, pull it out of the
- // item array and set it aside for later storage.
+ // Store conversation data
+ $arr = store_conversation($arr);
+
+ /*
+ * If a Diaspora signature structure was passed in, pull it out of the
+ * item array and set it aside for later storage.
+ */
$dsprsig = null;
- if(x($arr,'dsprsig')) {
+ if (x($arr, 'dsprsig')) {
+ $encoded_signature = $arr['dsprsig'];
$dsprsig = json_decode(base64_decode($arr['dsprsig']));
unset($arr['dsprsig']);
}
// Converting the plink
if ($arr['network'] == NETWORK_OSTATUS) {
- if (isset($arr['plink']))
+ if (isset($arr['plink'])) {
$arr['plink'] = ostatus::convert_href($arr['plink']);
- elseif (isset($arr['uri']))
+ } elseif (isset($arr['uri'])) {
$arr['plink'] = ostatus::convert_href($arr['uri']);
+ }
}
- if(x($arr, 'gravity'))
+ if (x($arr, 'gravity')) {
$arr['gravity'] = intval($arr['gravity']);
- elseif($arr['parent-uri'] === $arr['uri'])
+ } elseif ($arr['parent-uri'] === $arr['uri']) {
$arr['gravity'] = 0;
- elseif(activity_match($arr['verb'],ACTIVITY_POST))
+ } elseif (activity_match($arr['verb'],ACTIVITY_POST)) {
$arr['gravity'] = 6;
- else
+ } else {
$arr['gravity'] = 6; // extensible catchall
+ }
- if(! x($arr,'type'))
+ if (! x($arr, 'type')) {
$arr['type'] = 'remote';
+ }
-
-
- /* check for create date and expire time */
+ // check for create date and expire time
$uid = intval($arr['uid']);
$r = q("SELECT expire FROM user WHERE uid = %d", intval($uid));
- if(count($r)) {
+ if (dbm::is_result($r)) {
$expire_interval = $r[0]['expire'];
if ($expire_interval>0) {
$expire_date = new DateTime( '- '.$expire_interval.' days', new DateTimeZone('UTC'));
}
}
- // Do we already have this item?
- // We have to check several networks since Friendica posts could be repeated via OStatus (maybe Diasporsa as well)
+ /*
+ * Do we already have this item?
+ * We have to check several networks since Friendica posts could be repeated
+ * via OStatus (maybe Diasporsa as well)
+ */
if (in_array(trim($arr['network']), array(NETWORK_DIASPORA, NETWORK_DFRN, NETWORK_OSTATUS, ""))) {
$r = q("SELECT `id`, `network` FROM `item` WHERE `uri` = '%s' AND `uid` = %d AND `network` IN ('%s', '%s', '%s') LIMIT 1",
dbesc(trim($arr['uri'])),
dbesc(NETWORK_DFRN),
dbesc(NETWORK_OSTATUS)
);
- if ($r) {
+ if (dbm::is_result($r)) {
// We only log the entries with a different user id than 0. Otherwise we would have too many false positives
- if ($uid != 0)
+ if ($uid != 0) {
logger("Item with uri ".$arr['uri']." already existed for user ".$uid." with id ".$r[0]["id"]." target network ".$r[0]["network"]." - new network: ".$arr['network']);
- return($r[0]["id"]);
+ }
+
+ return $r[0]["id"];
}
}
+ /// @TODO old-lost code?
// Shouldn't happen but we want to make absolutely sure it doesn't leak from a plugin.
// Deactivated, since the bbcode parser can handle with it - and it destroys posts with some smileys that contain "<"
- //if((strpos($arr['body'],'<') !== false) || (strpos($arr['body'],'>') !== false))
+ //if ((strpos($arr['body'],'<') !== false) || (strpos($arr['body'],'>') !== false))
// $arr['body'] = strip_tags($arr['body']);
item_add_language_opt($arr);
- if ($notify)
+ if ($notify) {
$guid_prefix = "";
- elseif ((trim($arr['guid']) == "") AND (trim($arr['plink']) != ""))
+ } elseif ((trim($arr['guid']) == "") AND (trim($arr['plink']) != "")) {
$arr['guid'] = uri_to_guid($arr['plink']);
- elseif ((trim($arr['guid']) == "") AND (trim($arr['uri']) != ""))
+ } elseif ((trim($arr['guid']) == "") AND (trim($arr['uri']) != "")) {
$arr['guid'] = uri_to_guid($arr['uri']);
- else {
+ } else {
$parsed = parse_url($arr["author-link"]);
$guid_prefix = hash("crc32", $parsed["host"]);
}
- $arr['wall'] = ((x($arr,'wall')) ? intval($arr['wall']) : 0);
- $arr['guid'] = ((x($arr,'guid')) ? notags(trim($arr['guid'])) : get_guid(32, $guid_prefix));
- $arr['uri'] = ((x($arr,'uri')) ? notags(trim($arr['uri'])) : $arr['guid']);
- $arr['extid'] = ((x($arr,'extid')) ? notags(trim($arr['extid'])) : '');
- $arr['author-name'] = ((x($arr,'author-name')) ? trim($arr['author-name']) : '');
- $arr['author-link'] = ((x($arr,'author-link')) ? notags(trim($arr['author-link'])) : '');
- $arr['author-avatar'] = ((x($arr,'author-avatar')) ? notags(trim($arr['author-avatar'])) : '');
- $arr['owner-name'] = ((x($arr,'owner-name')) ? trim($arr['owner-name']) : '');
- $arr['owner-link'] = ((x($arr,'owner-link')) ? notags(trim($arr['owner-link'])) : '');
- $arr['owner-avatar'] = ((x($arr,'owner-avatar')) ? notags(trim($arr['owner-avatar'])) : '');
- $arr['created'] = ((x($arr,'created') !== false) ? datetime_convert('UTC','UTC',$arr['created']) : datetime_convert());
- $arr['edited'] = ((x($arr,'edited') !== false) ? datetime_convert('UTC','UTC',$arr['edited']) : datetime_convert());
- $arr['commented'] = ((x($arr,'commented') !== false) ? datetime_convert('UTC','UTC',$arr['commented']) : datetime_convert());
- $arr['received'] = ((x($arr,'received') !== false) ? datetime_convert('UTC','UTC',$arr['received']) : datetime_convert());
- $arr['changed'] = ((x($arr,'changed') !== false) ? datetime_convert('UTC','UTC',$arr['changed']) : datetime_convert());
- $arr['title'] = ((x($arr,'title')) ? trim($arr['title']) : '');
- $arr['location'] = ((x($arr,'location')) ? trim($arr['location']) : '');
- $arr['coord'] = ((x($arr,'coord')) ? notags(trim($arr['coord'])) : '');
- $arr['last-child'] = ((x($arr,'last-child')) ? intval($arr['last-child']) : 0 );
- $arr['visible'] = ((x($arr,'visible') !== false) ? intval($arr['visible']) : 1 );
+ $arr['wall'] = ((x($arr, 'wall')) ? intval($arr['wall']) : 0);
+ $arr['guid'] = ((x($arr, 'guid')) ? notags(trim($arr['guid'])) : get_guid(32, $guid_prefix));
+ $arr['uri'] = ((x($arr, 'uri')) ? notags(trim($arr['uri'])) : item_new_uri($a->get_hostname(), $uid, $arr['guid']));
+ $arr['extid'] = ((x($arr, 'extid')) ? notags(trim($arr['extid'])) : '');
+ $arr['author-name'] = ((x($arr, 'author-name')) ? trim($arr['author-name']) : '');
+ $arr['author-link'] = ((x($arr, 'author-link')) ? notags(trim($arr['author-link'])) : '');
+ $arr['author-avatar'] = ((x($arr, 'author-avatar')) ? notags(trim($arr['author-avatar'])) : '');
+ $arr['owner-name'] = ((x($arr, 'owner-name')) ? trim($arr['owner-name']) : '');
+ $arr['owner-link'] = ((x($arr, 'owner-link')) ? notags(trim($arr['owner-link'])) : '');
+ $arr['owner-avatar'] = ((x($arr, 'owner-avatar')) ? notags(trim($arr['owner-avatar'])) : '');
+ $arr['created'] = ((x($arr, 'created') !== false) ? datetime_convert('UTC','UTC', $arr['created']) : datetime_convert());
+ $arr['edited'] = ((x($arr, 'edited') !== false) ? datetime_convert('UTC','UTC', $arr['edited']) : datetime_convert());
+ $arr['commented'] = ((x($arr, 'commented') !== false) ? datetime_convert('UTC','UTC', $arr['commented']) : datetime_convert());
+ $arr['received'] = ((x($arr, 'received') !== false) ? datetime_convert('UTC','UTC', $arr['received']) : datetime_convert());
+ $arr['changed'] = ((x($arr, 'changed') !== false) ? datetime_convert('UTC','UTC', $arr['changed']) : datetime_convert());
+ $arr['title'] = ((x($arr, 'title')) ? trim($arr['title']) : '');
+ $arr['location'] = ((x($arr, 'location')) ? trim($arr['location']) : '');
+ $arr['coord'] = ((x($arr, 'coord')) ? notags(trim($arr['coord'])) : '');
+ $arr['last-child'] = ((x($arr, 'last-child')) ? intval($arr['last-child']) : 0 );
+ $arr['visible'] = ((x($arr, 'visible') !== false) ? intval($arr['visible']) : 1 );
$arr['deleted'] = 0;
- $arr['parent-uri'] = ((x($arr,'parent-uri')) ? notags(trim($arr['parent-uri'])) : '');
- $arr['verb'] = ((x($arr,'verb')) ? notags(trim($arr['verb'])) : '');
- $arr['object-type'] = ((x($arr,'object-type')) ? notags(trim($arr['object-type'])) : '');
- $arr['object'] = ((x($arr,'object')) ? trim($arr['object']) : '');
- $arr['target-type'] = ((x($arr,'target-type')) ? notags(trim($arr['target-type'])) : '');
- $arr['target'] = ((x($arr,'target')) ? trim($arr['target']) : '');
- $arr['plink'] = ((x($arr,'plink')) ? notags(trim($arr['plink'])) : '');
- $arr['allow_cid'] = ((x($arr,'allow_cid')) ? trim($arr['allow_cid']) : '');
- $arr['allow_gid'] = ((x($arr,'allow_gid')) ? trim($arr['allow_gid']) : '');
- $arr['deny_cid'] = ((x($arr,'deny_cid')) ? trim($arr['deny_cid']) : '');
- $arr['deny_gid'] = ((x($arr,'deny_gid')) ? trim($arr['deny_gid']) : '');
- $arr['private'] = ((x($arr,'private')) ? intval($arr['private']) : 0 );
- $arr['bookmark'] = ((x($arr,'bookmark')) ? intval($arr['bookmark']) : 0 );
- $arr['body'] = ((x($arr,'body')) ? trim($arr['body']) : '');
- $arr['tag'] = ((x($arr,'tag')) ? notags(trim($arr['tag'])) : '');
- $arr['attach'] = ((x($arr,'attach')) ? notags(trim($arr['attach'])) : '');
- $arr['app'] = ((x($arr,'app')) ? notags(trim($arr['app'])) : '');
- $arr['origin'] = ((x($arr,'origin')) ? intval($arr['origin']) : 0 );
- $arr['network'] = ((x($arr,'network')) ? trim($arr['network']) : '');
- $arr['postopts'] = ((x($arr,'postopts')) ? trim($arr['postopts']) : '');
- $arr['resource-id'] = ((x($arr,'resource-id')) ? trim($arr['resource-id']) : '');
- $arr['event-id'] = ((x($arr,'event-id')) ? intval($arr['event-id']) : 0 );
- $arr['inform'] = ((x($arr,'inform')) ? trim($arr['inform']) : '');
- $arr['file'] = ((x($arr,'file')) ? trim($arr['file']) : '');
+ $arr['parent-uri'] = ((x($arr, 'parent-uri')) ? notags(trim($arr['parent-uri'])) : $arr['uri']);
+ $arr['verb'] = ((x($arr, 'verb')) ? notags(trim($arr['verb'])) : '');
+ $arr['object-type'] = ((x($arr, 'object-type')) ? notags(trim($arr['object-type'])) : '');
+ $arr['object'] = ((x($arr, 'object')) ? trim($arr['object']) : '');
+ $arr['target-type'] = ((x($arr, 'target-type')) ? notags(trim($arr['target-type'])) : '');
+ $arr['target'] = ((x($arr, 'target')) ? trim($arr['target']) : '');
+ $arr['plink'] = ((x($arr, 'plink')) ? notags(trim($arr['plink'])) : '');
+ $arr['allow_cid'] = ((x($arr, 'allow_cid')) ? trim($arr['allow_cid']) : '');
+ $arr['allow_gid'] = ((x($arr, 'allow_gid')) ? trim($arr['allow_gid']) : '');
+ $arr['deny_cid'] = ((x($arr, 'deny_cid')) ? trim($arr['deny_cid']) : '');
+ $arr['deny_gid'] = ((x($arr, 'deny_gid')) ? trim($arr['deny_gid']) : '');
+ $arr['private'] = ((x($arr, 'private')) ? intval($arr['private']) : 0 );
+ $arr['bookmark'] = ((x($arr, 'bookmark')) ? intval($arr['bookmark']) : 0 );
+ $arr['body'] = ((x($arr, 'body')) ? trim($arr['body']) : '');
+ $arr['tag'] = ((x($arr, 'tag')) ? notags(trim($arr['tag'])) : '');
+ $arr['attach'] = ((x($arr, 'attach')) ? notags(trim($arr['attach'])) : '');
+ $arr['app'] = ((x($arr, 'app')) ? notags(trim($arr['app'])) : '');
+ $arr['origin'] = ((x($arr, 'origin')) ? intval($arr['origin']) : 0 );
+ $arr['network'] = ((x($arr, 'network')) ? trim($arr['network']) : '');
+ $arr['postopts'] = ((x($arr, 'postopts')) ? trim($arr['postopts']) : '');
+ $arr['resource-id'] = ((x($arr, 'resource-id')) ? trim($arr['resource-id']) : '');
+ $arr['event-id'] = ((x($arr, 'event-id')) ? intval($arr['event-id']) : 0 );
+ $arr['inform'] = ((x($arr, 'inform')) ? trim($arr['inform']) : '');
+ $arr['file'] = ((x($arr, 'file')) ? trim($arr['file']) : '');
// Items cannot be stored before they happen ...
- if ($arr['created'] > datetime_convert())
+ if ($arr['created'] > datetime_convert()) {
$arr['created'] = datetime_convert();
+ }
// We haven't invented time travel by now.
- if ($arr['edited'] > datetime_convert())
+ if ($arr['edited'] > datetime_convert()) {
$arr['edited'] = datetime_convert();
+ }
- if (($arr['author-link'] == "") AND ($arr['owner-link'] == ""))
- logger("Both author-link and owner-link are empty. Called by: ".App::callstack(), LOGGER_DEBUG);
+ if (($arr['author-link'] == "") AND ($arr['owner-link'] == "")) {
+ logger("Both author-link and owner-link are empty. Called by: " . App::callstack(), LOGGER_DEBUG);
+ }
if ($arr['plink'] == "") {
- $a = get_app();
- $arr['plink'] = $a->get_baseurl().'/display/'.urlencode($arr['guid']);
+ $arr['plink'] = App::get_baseurl() . '/display/' . urlencode($arr['guid']);
}
if ($arr['network'] == "") {
intval($arr['uid'])
);
- if(!count($r))
+ if (!dbm::is_result($r))
$r = q("SELECT `network` FROM `gcontact` WHERE `network` IN ('%s', '%s', '%s') AND `nurl` = '%s' LIMIT 1",
dbesc(NETWORK_DFRN), dbesc(NETWORK_DIASPORA), dbesc(NETWORK_OSTATUS),
dbesc(normalise_link($arr['author-link']))
);
- if(!count($r))
+ if (!dbm::is_result($r)) {
$r = q("SELECT `network` FROM `contact` WHERE `id` = %d AND `uid` = %d LIMIT 1",
intval($arr['contact-id']),
intval($arr['uid'])
);
+ }
- if(count($r))
+ if (dbm::is_result($r)) {
$arr['network'] = $r[0]["network"];
+ }
// Fallback to friendica (why is it empty in some cases?)
- if ($arr['network'] == "")
+ if ($arr['network'] == "") {
$arr['network'] = NETWORK_DFRN;
+ }
- logger("item_store: Set network to ".$arr["network"]." for ".$arr["uri"], LOGGER_DEBUG);
+ logger("item_store: Set network to " . $arr["network"] . " for " . $arr["uri"], LOGGER_DEBUG);
}
// The contact-id should be set before "item_store" was called - but there seems to be some issues
if ($arr["contact-id"] == 0) {
- // First we are looking for a suitable contact that matches with the author of the post
- // This is done only for comments (See below explanation at "gcontact-id")
- if($arr['parent-uri'] != $arr['uri'])
+ /*
+ * First we are looking for a suitable contact that matches with the author of the post
+ * This is done only for comments (See below explanation at "gcontact-id")
+ */
+ if ($arr['parent-uri'] != $arr['uri']) {
$arr["contact-id"] = get_contact($arr['author-link'], $uid);
+ }
// If not present then maybe the owner was found
- if ($arr["contact-id"] == 0)
+ if ($arr["contact-id"] == 0) {
$arr["contact-id"] = get_contact($arr['owner-link'], $uid);
+ }
// Still missing? Then use the "self" contact of the current user
if ($arr["contact-id"] == 0) {
$r = q("SELECT `id` FROM `contact` WHERE `self` AND `uid` = %d", intval($uid));
- if ($r)
+
+ if (dbm::is_result($r)) {
$arr["contact-id"] = $r[0]["id"];
+ }
}
+
logger("Contact-id was missing for post ".$arr["guid"]." from user id ".$uid." - now set to ".$arr["contact-id"], LOGGER_DEBUG);
}
if ($arr["gcontact-id"] == 0) {
- // The gcontact should mostly behave like the contact. But is is supposed to be global for the system.
- // This means that wall posts, repeated posts, etc. should have the gcontact id of the owner.
- // On comments the author is the better choice.
- if($arr['parent-uri'] === $arr['uri'])
+ /*
+ * The gcontact should mostly behave like the contact. But is is supposed to be global for the system.
+ * This means that wall posts, repeated posts, etc. should have the gcontact id of the owner.
+ * On comments the author is the better choice.
+ */
+ if ($arr['parent-uri'] === $arr['uri']) {
$arr["gcontact-id"] = get_gcontact_id(array("url" => $arr['owner-link'], "network" => $arr['network'],
"photo" => $arr['owner-avatar'], "name" => $arr['owner-name']));
- else
+ } else {
$arr["gcontact-id"] = get_gcontact_id(array("url" => $arr['author-link'], "network" => $arr['network'],
"photo" => $arr['author-avatar'], "name" => $arr['author-name']));
+ }
}
- if ($arr["author-id"] == 0)
+ if ($arr["author-id"] == 0) {
$arr["author-id"] = get_contact($arr["author-link"], 0);
+ }
- if ($arr["owner-id"] == 0)
+ if ($arr["owner-id"] == 0) {
$arr["owner-id"] = get_contact($arr["owner-link"], 0);
+ }
if ($arr['guid'] != "") {
// Checking if there is already an item with the same guid
$r = q("SELECT `guid` FROM `item` WHERE `guid` = '%s' AND `network` = '%s' AND `uid` = '%d' LIMIT 1",
dbesc($arr['guid']), dbesc($arr['network']), intval($arr['uid']));
- if(count($r)) {
+ if (dbm::is_result($r)) {
logger('found item with guid '.$arr['guid'].' for user '.$arr['uid'].' on network '.$arr['network'], LOGGER_DEBUG);
return 0;
}
item_body_set_hashtags($arr);
$arr['thr-parent'] = $arr['parent-uri'];
- if($arr['parent-uri'] === $arr['uri']) {
+
+ if ($arr['parent-uri'] === $arr['uri']) {
$parent_id = 0;
$parent_deleted = 0;
$allow_cid = $arr['allow_cid'];
$deny_cid = $arr['deny_cid'];
$deny_gid = $arr['deny_gid'];
$notify_type = 'wall-new';
- }
- else {
+ } else {
// find the parent and snarf the item id and ACLs
// and anything else we need to inherit
intval($arr['uid'])
);
- if(count($r)) {
+ if (dbm::is_result($r)) {
// is the new message multi-level threaded?
// even though we don't support it now, preserve the info
// and re-attach to the conversation parent.
- if($r[0]['uri'] != $r[0]['parent-uri']) {
+ if ($r[0]['uri'] != $r[0]['parent-uri']) {
$arr['parent-uri'] = $r[0]['parent-uri'];
$z = q("SELECT * FROM `item` WHERE `uri` = '%s' AND `parent-uri` = '%s' AND `uid` = %d
ORDER BY `id` ASC LIMIT 1",
dbesc($r[0]['parent-uri']),
intval($arr['uid'])
);
- if($z && count($z))
+
+ if (dbm::is_result($z)) {
$r = $z;
+ }
}
$parent_id = $r[0]['id'];
$arr['wall'] = $r[0]['wall'];
$notify_type = 'comment-new';
- // if the parent is private, force privacy for the entire conversation
- // This differs from the above settings as it subtly allows comments from
- // email correspondents to be private even if the overall thread is not.
-
- if($r[0]['private'])
+ /*
+ * If the parent is private, force privacy for the entire conversation
+ * This differs from the above settings as it subtly allows comments from
+ * email correspondents to be private even if the overall thread is not.
+ */
+ if ($r[0]['private']) {
$arr['private'] = $r[0]['private'];
+ }
- // Edge case. We host a public forum that was originally posted to privately.
- // The original author commented, but as this is a comment, the permissions
- // weren't fixed up so it will still show the comment as private unless we fix it here.
-
- if((intval($r[0]['forum_mode']) == 1) && (! $r[0]['private']))
+ /*
+ * Edge case. We host a public forum that was originally posted to privately.
+ * The original author commented, but as this is a comment, the permissions
+ * weren't fixed up so it will still show the comment as private unless we fix it here.
+ */
+ if ((intval($r[0]['forum_mode']) == 1) && (! $r[0]['private'])) {
$arr['private'] = 0;
-
+ }
// If its a post from myself then tag the thread as "mention"
logger("item_store: Checking if parent ".$parent_id." has to be tagged as mention for user ".$arr['uid'], LOGGER_DEBUG);
- $u = q("select * from user where uid = %d limit 1", intval($arr['uid']));
- if(count($u)) {
+ $u = q("SELECT `nickname` FROM `user` WHERE `uid` = %d", intval($arr['uid']));
+ if (dbm::is_result($u)) {
$a = get_app();
- $self = normalise_link($a->get_baseurl() . '/profile/' . $u[0]['nickname']);
+ $self = normalise_link(App::get_baseurl() . '/profile/' . $u[0]['nickname']);
logger("item_store: 'myself' is ".$self." for parent ".$parent_id." checking against ".$arr['author-link']." and ".$arr['owner-link'], LOGGER_DEBUG);
if ((normalise_link($arr['author-link']) == $self) OR (normalise_link($arr['owner-link']) == $self)) {
q("UPDATE `thread` SET `mention` = 1 WHERE `iid` = %d", intval($parent_id));
logger("item_store: tagged thread ".$parent_id." as mention for user ".$self, LOGGER_DEBUG);
}
}
- }
- else {
-
- // Allow one to see reply tweets from status.net even when
- // we don't have or can't see the original post.
-
- if($force_parent) {
+ } else {
+ /*
+ * Allow one to see reply tweets from status.net even when
+ * we don't have or can't see the original post.
+ */
+ if ($force_parent) {
logger('item_store: $force_parent=true, reply converted to top-level post.');
$parent_id = 0;
$arr['parent-uri'] = $arr['uri'];
$arr['gravity'] = 0;
- }
- else {
+ } else {
logger('item_store: item parent '.$arr['parent-uri'].' for '.$arr['uid'].' was not found - ignoring item');
return 0;
}
dbesc(NETWORK_DFRN),
intval($arr['uid'])
);
- if($r && count($r)) {
- logger('duplicated item with the same uri found. ' . print_r($arr,true));
+ if (dbm::is_result($r)) {
+ logger('duplicated item with the same uri found. '.print_r($arr,true));
return 0;
}
- // Check for an existing post with the same content. There seems to be a problem with OStatus.
- $r = q("SELECT `id` FROM `item` WHERE `body` = '%s' AND `network` = '%s' AND `created` = '%s' AND `contact-id` = %d AND `uid` = %d LIMIT 1",
- dbesc($arr['body']),
- dbesc($arr['network']),
- dbesc($arr['created']),
- intval($arr['contact-id']),
- intval($arr['uid'])
- );
- if($r && count($r)) {
- logger('duplicated item with the same body found. ' . print_r($arr,true));
- return 0;
+ // On Friendica and Diaspora the GUID is unique
+ if (in_array($arr['network'], array(NETWORK_DFRN, NETWORK_DIASPORA))) {
+ $r = q("SELECT `id` FROM `item` WHERE `guid` = '%s' AND `uid` = %d LIMIT 1",
+ dbesc($arr['guid']),
+ intval($arr['uid'])
+ );
+ if (dbm::is_result($r)) {
+ logger('duplicated item with the same guid found. '.print_r($arr,true));
+ return 0;
+ }
+ } else {
+ // Check for an existing post with the same content. There seems to be a problem with OStatus.
+ $r = q("SELECT `id` FROM `item` WHERE `body` = '%s' AND `network` = '%s' AND `created` = '%s' AND `contact-id` = %d AND `uid` = %d LIMIT 1",
+ dbesc($arr['body']),
+ dbesc($arr['network']),
+ dbesc($arr['created']),
+ intval($arr['contact-id']),
+ intval($arr['uid'])
+ );
+ if (dbm::is_result($r)) {
+ logger('duplicated item with the same body found. '.print_r($arr,true));
+ return 0;
+ }
}
// Is this item available in the global items (with uid=0)?
if ($arr["uid"] == 0) {
$arr["global"] = true;
+ // Set the global flag on all items if this was a global item entry
q("UPDATE `item` SET `global` = 1 WHERE `uri` = '%s'", dbesc($arr["uri"]));
- } else {
+ } else {
$isglobal = q("SELECT `global` FROM `item` WHERE `uid` = 0 AND `uri` = '%s'", dbesc($arr["uri"]));
- $arr["global"] = (count($isglobal) > 0);
+ $arr["global"] = (dbm::is_result($isglobal) && count($isglobal) > 0);
+ }
+
+ // ACL settings
+ if (strlen($allow_cid) || strlen($allow_gid) || strlen($deny_cid) || strlen($deny_gid)) {
+ $private = 1;
+ } else {
+ $private = $arr['private'];
}
+ $arr["allow_cid"] = $allow_cid;
+ $arr["allow_gid"] = $allow_gid;
+ $arr["deny_cid"] = $deny_cid;
+ $arr["deny_gid"] = $deny_gid;
+ $arr["private"] = $private;
+ $arr["deleted"] = $parent_deleted;
+
// Fill the cache field
put_item_in_cache($arr);
- if ($notify)
- call_hooks('post_local',$arr);
- else
- call_hooks('post_remote',$arr);
+ if ($notify) {
+ call_hooks('post_local', $arr);
+ } else {
+ call_hooks('post_remote', $arr);
+ }
- if(x($arr,'cancel')) {
+ if (x($arr, 'cancel')) {
logger('item_store: post cancelled by plugin.');
return 0;
}
+ /*
+ * Check for already added items.
+ * There is a timing issue here that sometimes creates double postings.
+ * An unique index would help - but the limitations of MySQL (maximum size of index values) prevent this.
+ */
+ if ($arr["uid"] == 0) {
+ $r = qu("SELECT `id` FROM `item` WHERE `uri` = '%s' AND `uid` = 0 LIMIT 1", dbesc(trim($arr['uri'])));
+ if (dbm::is_result($r)) {
+ logger('Global item already stored. URI: '.$arr['uri'].' on network '.$arr['network'], LOGGER_DEBUG);
+ return 0;
+ }
+ }
+
// Store the unescaped version
$unescaped = $arr;
- dbesc_array($arr);
+ dbm::esc_array($arr, true);
logger('item_store: ' . print_r($arr,true), LOGGER_DATA);
+ q("COMMIT");
+ q("START TRANSACTION;");
+
$r = dbq("INSERT INTO `item` (`"
. implode("`, `", array_keys($arr))
- . "`) VALUES ('"
- . implode("', '", array_values($arr))
- . "')" );
+ . "`) VALUES ("
+ . implode(", ", array_values($arr))
+ . ")");
// And restore it
$arr = $unescaped;
- // find the item that we just created
- $r = q("SELECT `id` FROM `item` WHERE `uri` = '%s' AND `uid` = %d AND `network` = '%s' ORDER BY `id` ASC",
+ // When the item was successfully stored we fetch the ID of the item.
+ if (dbm::is_result($r)) {
+ $r = q("SELECT LAST_INSERT_ID() AS `item-id`");
+ if (dbm::is_result($r)) {
+ $current_post = $r[0]['item-id'];
+ } else {
+ // This shouldn't happen
+ $current_post = 0;
+ }
+ } else {
+ // This can happen - for example - if there are locking timeouts.
+ q("ROLLBACK");
+
+ // Store the data into a spool file so that we can try again later.
+
+ // At first we restore the Diaspora signature that we removed above.
+ if (isset($encoded_signature)) {
+ $arr['dsprsig'] = $encoded_signature;
+ }
+
+ // Now we store the data in the spool directory
+ // We use "microtime" to keep the arrival order and "mt_rand" to avoid duplicates
+ $file = 'item-'.round(microtime(true) * 10000).'-'.mt_rand().'.msg';
+
+ $spoolpath = get_spoolpath();
+ if ($spoolpath != "") {
+ $spool = $spoolpath.'/'.$file;
+ file_put_contents($spool, json_encode($arr));
+ logger("Item wasn't stored - Item was spooled into file ".$file, LOGGER_DEBUG);
+ }
+ return 0;
+ }
+
+ if ($current_post == 0) {
+ // This is one of these error messages that never should occur.
+ logger("couldn't find created item - we better quit now.");
+ q("ROLLBACK");
+ return 0;
+ }
+
+ // How much entries have we created?
+ // We wouldn't need this query when we could use an unique index - but MySQL has length problems with them.
+ $r = q("SELECT COUNT(*) AS `entries` FROM `item` WHERE `uri` = '%s' AND `uid` = %d AND `network` = '%s'",
dbesc($arr['uri']),
intval($arr['uid']),
dbesc($arr['network'])
);
- if(count($r) > 1) {
- // There are duplicates. Keep the oldest one, delete the others
- logger('item_store: duplicated post occurred. Removing newer duplicates. uri = '.$arr['uri'].' uid = '.$arr['uid']);
- q("DELETE FROM `item` WHERE `uri` = '%s' AND `uid` = %d AND `network` = '%s' AND `id` > %d",
- dbesc($arr['uri']),
- intval($arr['uid']),
- dbesc($arr['network']),
- intval($r[0]["id"])
- );
+ if (!dbm::is_result($r)) {
+ // This shouldn't happen, since COUNT always works when the database connection is there.
+ logger("We couldn't count the stored entries. Very strange ...");
+ q("ROLLBACK");
return 0;
- } elseif(count($r)) {
-
- $current_post = $r[0]['id'];
- logger('item_store: created item ' . $current_post);
-
- // Set "success_update" and "last-item" to the date of the last time we heard from this contact
- // This can be used to filter for inactive contacts.
- // Only do this for public postings to avoid privacy problems, since poco data is public.
- // Don't set this value if it isn't from the owner (could be an author that we don't know)
-
- $update = (!$arr['private'] AND (($arr["author-link"] === $arr["owner-link"]) OR ($arr["parent-uri"] === $arr["uri"])));
+ }
- // Is it a forum? Then we don't care about the rules from above
- if (!$update AND ($arr["network"] == NETWORK_DFRN) AND ($arr["parent-uri"] === $arr["uri"])) {
- $isforum = q("SELECT `forum` FROM `contact` WHERE `id` = %d AND `forum`",
- intval($arr['contact-id']));
- if ($isforum)
- $update = true;
- }
+ if ($r[0]["entries"] > 1) {
+ // There are duplicates. We delete our just created entry.
+ logger('Duplicated post occurred. uri = ' . $arr['uri'] . ' uid = ' . $arr['uid']);
- if ($update)
- q("UPDATE `contact` SET `success_update` = '%s', `last-item` = '%s' WHERE `id` = %d",
- dbesc($arr['received']),
- dbesc($arr['received']),
- intval($arr['contact-id'])
- );
- } else {
- logger('item_store: could not locate created item');
+ // Yes, we could do a rollback here - but we are having many users with MyISAM.
+ q("DELETE FROM `item` WHERE `id` = %d", intval($current_post));
+ q("COMMIT");
+ return 0;
+ } elseif ($r[0]["entries"] == 0) {
+ // This really should never happen since we quit earlier if there were problems.
+ logger("Something is terribly wrong. We haven't found our created entry.");
+ q("ROLLBACK");
return 0;
}
- if((! $parent_id) || ($arr['parent-uri'] === $arr['uri']))
- $parent_id = $current_post;
+ logger('item_store: created item '.$current_post);
+ item_set_last_item($arr);
- if(strlen($allow_cid) || strlen($allow_gid) || strlen($deny_cid) || strlen($deny_gid))
- $private = 1;
- else
- $private = $arr['private'];
-
- // Set parent id - and also make sure to inherit the parent's ACLs.
+ if (!$parent_id || ($arr['parent-uri'] === $arr['uri'])) {
+ $parent_id = $current_post;
+ }
- $r = q("UPDATE `item` SET `parent` = %d, `allow_cid` = '%s', `allow_gid` = '%s',
- `deny_cid` = '%s', `deny_gid` = '%s', `private` = %d, `deleted` = %d WHERE `id` = %d",
+ // Set parent id
+ $r = q("UPDATE `item` SET `parent` = %d WHERE `id` = %d",
intval($parent_id),
- dbesc($allow_cid),
- dbesc($allow_gid),
- dbesc($deny_cid),
- dbesc($deny_gid),
- intval($private),
- intval($parent_deleted),
intval($current_post)
);
$arr['id'] = $current_post;
$arr['parent'] = $parent_id;
- $arr['allow_cid'] = $allow_cid;
- $arr['allow_gid'] = $allow_gid;
- $arr['deny_cid'] = $deny_cid;
- $arr['deny_gid'] = $deny_gid;
- $arr['private'] = $private;
- $arr['deleted'] = $parent_deleted;
// update the commented timestamp on the parent
// Only update "commented" if it is really a comment
- if (($arr['verb'] == ACTIVITY_POST) OR !get_config("system", "like_no_comment"))
+ if (($arr['verb'] == ACTIVITY_POST) OR !get_config("system", "like_no_comment")) {
q("UPDATE `item` SET `commented` = '%s', `changed` = '%s' WHERE `id` = %d",
dbesc(datetime_convert()),
dbesc(datetime_convert()),
intval($parent_id)
);
- else
+ } else {
q("UPDATE `item` SET `changed` = '%s' WHERE `id` = %d",
dbesc(datetime_convert()),
intval($parent_id)
);
+ }
- if($dsprsig) {
+ if ($dsprsig) {
- // Friendica servers lower than 3.4.3-2 had double encoded the signature ...
- // We can check for this condition when we decode and encode the stuff again.
+ /*
+ * Friendica servers lower than 3.4.3-2 had double encoded the signature ...
+ * We can check for this condition when we decode and encode the stuff again.
+ */
if (base64_encode(base64_decode(base64_decode($dsprsig->signature))) == base64_decode($dsprsig->signature)) {
$dsprsig->signature = base64_decode($dsprsig->signature);
logger("Repaired double encoded signature from handle ".$dsprsig->signer, LOGGER_DEBUG);
}
- q("insert into sign (`iid`,`signed_text`,`signature`,`signer`) values (%d,'%s','%s','%s') ",
+ q("INSERT INTO `sign` (`iid`,`signed_text`,`signature`,`signer`) values (%d,'%s','%s','%s') ",
intval($current_post),
dbesc($dsprsig->signed_text),
dbesc($dsprsig->signature),
);
}
+ $deleted = tag_deliver($arr['uid'], $current_post);
- /**
- * If this is now the last-child, force all _other_ children of this parent to *not* be last-child
+ /*
+ * current post can be deleted if is for a community page and no mention are
+ * in it.
*/
-
- if($arr['last-child']) {
- $r = q("UPDATE `item` SET `last-child` = 0 WHERE `parent-uri` = '%s' AND `uid` = %d AND `id` != %d",
- dbesc($arr['uri']),
- intval($arr['uid']),
- intval($current_post)
- );
- }
-
- $deleted = tag_deliver($arr['uid'],$current_post);
-
- // current post can be deleted if is for a community page and no mention are
- // in it.
if (!$deleted AND !$dontcache) {
- $r = q('SELECT * FROM `item` WHERE id = %d', intval($current_post));
- if (count($r) == 1) {
- if ($notify)
+ $r = q('SELECT * FROM `item` WHERE `id` = %d', intval($current_post));
+ if ((dbm::is_result($r)) && (count($r) == 1)) {
+ if ($notify) {
call_hooks('post_local_end', $r[0]);
- else
+ } else {
call_hooks('post_remote_end', $r[0]);
- } else
+ }
+ } else {
logger('item_store: new item not found in DB, id ' . $current_post);
+ }
}
- create_tags_from_item($current_post);
- create_files_from_item($current_post);
-
- // Only check for notifications on start posts
- if ($arr['parent-uri'] === $arr['uri'])
+ if ($arr['parent-uri'] === $arr['uri']) {
add_thread($current_post);
- else {
+ } else {
update_thread($parent_id);
- add_shadow_entry($arr);
}
- $perfdb = $a->performance["database"] - $perfdb;
- $perfdbw = $a->performance["database_write"] - $perfdbw;
- $perfnet = $a->performance["network"] - $perfnet;
- $perffile = $a->performance["file"] - $perffile;
+ q("COMMIT");
- logger("Performance: DB-R: ".round($perfdb - $perfdbw, 2)." - DB-W: ".round($perfdbw, 2)." - Net: ".round($perfnet, 2)." - File: ".round($perffile, 2), LOGGER_DEBUG);
- //logger("Performance: DB-R: ".round($perfdb - $perfdbw, 2)." - DB-W: ".round($perfdbw, 2)." - Net: ".round($perfnet, 2), LOGGER_DEBUG);
+ /*
+ * Due to deadlock issues with the "term" table we are doing these steps after the commit.
+ * This is not perfect - but a workable solution until we found the reason for the problem.
+ */
+ create_tags_from_item($current_post);
+ create_files_from_item($current_post);
+
+ /*
+ * If this is now the last-child, force all _other_ children of this parent to *not* be last-child
+ * It is done after the transaction to avoid dead locks.
+ */
+ if ($arr['last-child']) {
+ $r = q("UPDATE `item` SET `last-child` = 0 WHERE `parent-uri` = '%s' AND `uid` = %d AND `id` != %d",
+ dbesc($arr['uri']),
+ intval($arr['uid']),
+ intval($current_post)
+ );
+ }
+
+ if ($arr['parent-uri'] === $arr['uri']) {
+ add_shadow_thread($current_post);
+ } else {
+ add_shadow_entry($current_post);
+ }
check_item_notification($current_post, $uid);
- if ($notify)
+ if ($notify) {
proc_run(PRIORITY_HIGH, "include/notifier.php", $notify_type, $current_post);
+ }
return $current_post;
}
+/**
+ * @brief Set "success_update" and "last-item" to the date of the last time we heard from this contact
+ *
+ * This can be used to filter for inactive contacts.
+ * Only do this for public postings to avoid privacy problems, since poco data is public.
+ * Don't set this value if it isn't from the owner (could be an author that we don't know)
+ *
+ * @param array $arr Contains the just posted item record
+ */
+function item_set_last_item($arr) {
+
+ $update = (!$arr['private'] AND (($arr["author-link"] === $arr["owner-link"]) OR ($arr["parent-uri"] === $arr["uri"])));
+
+ // Is it a forum? Then we don't care about the rules from above
+ if (!$update AND ($arr["network"] == NETWORK_DFRN) AND ($arr["parent-uri"] === $arr["uri"])) {
+ $isforum = q("SELECT `forum` FROM `contact` WHERE `id` = %d AND `forum`",
+ intval($arr['contact-id']));
+ if (dbm::is_result($isforum)) {
+ $update = true;
+ }
+ }
+
+ if ($update) {
+ q("UPDATE `contact` SET `success_update` = '%s', `last-item` = '%s' WHERE `id` = %d",
+ dbesc($arr['received']),
+ dbesc($arr['received']),
+ intval($arr['contact-id'])
+ );
+ }
+ // Now do the same for the system wide contacts with uid=0
+ if (!$arr['private']) {
+ q("UPDATE `contact` SET `success_update` = '%s', `last-item` = '%s' WHERE `id` = %d",
+ dbesc($arr['received']),
+ dbesc($arr['received']),
+ intval($arr['owner-id'])
+ );
+
+ if ($arr['owner-id'] != $arr['author-id']) {
+ q("UPDATE `contact` SET `success_update` = '%s', `last-item` = '%s' WHERE `id` = %d",
+ dbesc($arr['received']),
+ dbesc($arr['received']),
+ intval($arr['author-id'])
+ );
+ }
+ }
+}
+
function item_body_set_hashtags(&$item) {
$tags = get_tags($item["body"]);
// No hashtags?
- if(!count($tags))
- return(false);
+ if (!count($tags)) {
+ return false;
+ }
// This sorting is important when there are hashtags that are part of other hashtags
// Otherwise there could be problems with hashtags like #test and #test2
$URLSearchString = "^\[\]";
+ /// @TODO old-lost code?
// All hashtags should point to the home server
//$item["body"] = preg_replace("/#\[url\=([$URLSearchString]*)\](.*?)\[\/url\]/ism",
- // "#[url=".$a->get_baseurl()."/search?tag=$2]$2[/url]", $item["body"]);
+ // "#[url=".App::get_baseurl()."/search?tag=$2]$2[/url]", $item["body"]);
//$item["tag"] = preg_replace("/#\[url\=([$URLSearchString]*)\](.*?)\[\/url\]/ism",
- // "#[url=".$a->get_baseurl()."/search?tag=$2]$2[/url]", $item["tag"]);
+ // "#[url=".App::get_baseurl()."/search?tag=$2]$2[/url]", $item["tag"]);
// mask hashtags inside of url, bookmarks and attachments to avoid urls in urls
$item["body"] = preg_replace_callback("/\[url\=([$URLSearchString]*)\](.*?)\[\/url\]/ism",
- function ($match){
- return("[url=".str_replace("#", "#", $match[1])."]".str_replace("#", "#", $match[2])."[/url]");
- },$item["body"]);
+ function ($match) {
+ return ("[url=" . str_replace("#", "#", $match[1]) . "]" . str_replace("#", "#", $match[2]) . "[/url]");
+ }, $item["body"]);
$item["body"] = preg_replace_callback("/\[bookmark\=([$URLSearchString]*)\](.*?)\[\/bookmark\]/ism",
- function ($match){
- return("[bookmark=".str_replace("#", "#", $match[1])."]".str_replace("#", "#", $match[2])."[/bookmark]");
- },$item["body"]);
+ function ($match) {
+ return ("[bookmark=" . str_replace("#", "#", $match[1]) . "]" . str_replace("#", "#", $match[2]) . "[/bookmark]");
+ }, $item["body"]);
$item["body"] = preg_replace_callback("/\[attachment (.*)\](.*?)\[\/attachment\]/ism",
- function ($match){
- return("[attachment ".str_replace("#", "#", $match[1])."]".$match[2]."[/attachment]");
- },$item["body"]);
+ function ($match) {
+ return ("[attachment " . str_replace("#", "#", $match[1]) . "]" . $match[2] . "[/attachment]");
+ }, $item["body"]);
// Repair recursive urls
$item["body"] = preg_replace("/#\[url\=([$URLSearchString]*)\](.*?)\[\/url\]/ism",
"#$2", $item["body"]);
-
- foreach($tags as $tag) {
- if(strpos($tag,'#') !== 0)
- continue;
-
- if(strpos($tag,'[url='))
+ foreach ($tags as $tag) {
+ if ((strpos($tag, '#') !== 0) || (strpos($tag, '[url='))) {
continue;
+ }
$basetag = str_replace('_',' ',substr($tag,1));
- $newtag = '#[url='.$a->get_baseurl().'/search?tag='.rawurlencode($basetag).']'.$basetag.'[/url]';
+ $newtag = '#[url=' . App::get_baseurl() . '/search?tag=' . rawurlencode($basetag) . ']' . $basetag . '[/url]';
$item["body"] = str_replace($tag, $newtag, $item["body"]);
- if(!stristr($item["tag"],"/search?tag=".$basetag."]".$basetag."[/url]")) {
- if(strlen($item["tag"]))
+ if (!stristr($item["tag"], "/search?tag=" . $basetag . "]" . $basetag . "[/url]")) {
+ if (strlen($item["tag"])) {
$item["tag"] = ','.$item["tag"];
+ }
$item["tag"] = $newtag.$item["tag"];
}
}
function get_item_guid($id) {
$r = q("SELECT `guid` FROM `item` WHERE `id` = %d LIMIT 1", intval($id));
- if (count($r))
- return($r[0]["guid"]);
- else
- return("");
+ if (dbm::is_result($r)) {
+ return $r[0]["guid"];
+ } else {
+ /// @TODO This else-block can be elimited again
+ return "";
+ }
}
function get_item_id($guid, $uid = 0) {
$nick = "";
$id = 0;
- if ($uid == 0)
+ if ($uid == 0) {
$uid == local_user();
+ }
// Does the given user have this item?
if ($uid) {
$r = q("SELECT `item`.`id`, `user`.`nickname` FROM `item` INNER JOIN `user` ON `user`.`uid` = `item`.`uid`
WHERE `item`.`visible` = 1 AND `item`.`deleted` = 0 and `item`.`moderated` = 0
AND `item`.`guid` = '%s' AND `item`.`uid` = %d", dbesc($guid), intval($uid));
- if (count($r)) {
+ if (dbm::is_result($r)) {
$id = $r[0]["id"];
$nick = $r[0]["nickname"];
}
AND `item`.`deny_cid` = '' AND `item`.`deny_gid` = ''
AND `item`.`private` = 0 AND `item`.`wall` = 1
AND `item`.`guid` = '%s'", dbesc($guid));
- if (count($r)) {
+ if (dbm::is_result($r)) {
$id = $r[0]["id"];
$nick = $r[0]["nickname"];
}
}
- return(array("nick" => $nick, "id" => $id));
+ return array("nick" => $nick, "id" => $id);
}
// return - test
-function get_item_contact($item,$contacts) {
- if(! count($contacts) || (! is_array($item)))
+function get_item_contact($item, $contacts) {
+ if (! count($contacts) || (! is_array($item))) {
return false;
- foreach($contacts as $contact) {
- if($contact['id'] == $item['contact-id']) {
+ }
+ foreach ($contacts as $contact) {
+ if ($contact['id'] == $item['contact-id']) {
return $contact;
break; // NOTREACHED
}
* @param int $item_id
* @return bool true if item was deleted, else false
*/
-function tag_deliver($uid,$item_id) {
-
- //
+function tag_deliver($uid, $item_id) {
$a = get_app();
$mention = false;
- $u = q("select * from user where uid = %d limit 1",
+ $u = q("SELECT * FROM `user` WHERE `uid` = %d LIMIT 1",
intval($uid)
);
- if(! count($u))
+
+ if (! dbm::is_result($u)) {
return;
+ }
$community_page = (($u[0]['page-flags'] == PAGE_COMMUNITY) ? true : false);
$prvgroup = (($u[0]['page-flags'] == PAGE_PRVGROUP) ? true : false);
- $i = q("select * from item where id = %d and uid = %d limit 1",
+ $i = q("SELECT * FROM `item` WHERE `id` = %d AND `uid` = %d LIMIT 1",
intval($item_id),
intval($uid)
);
- if(! count($i))
+ if (! dbm::is_result($i)) {
return;
+ }
$item = $i[0];
- $link = normalise_link($a->get_baseurl() . '/profile/' . $u[0]['nickname']);
+ $link = normalise_link(App::get_baseurl() . '/profile/' . $u[0]['nickname']);
- // Diaspora uses their own hardwired link URL in @-tags
- // instead of the one we supply with webfinger
-
- $dlink = normalise_link($a->get_baseurl() . '/u/' . $u[0]['nickname']);
+ /*
+ * Diaspora uses their own hardwired link URL in @-tags
+ * instead of the one we supply with webfinger
+ */
+ $dlink = normalise_link(App::get_baseurl() . '/u/' . $u[0]['nickname']);
- $cnt = preg_match_all('/[\@\!]\[url\=(.*?)\](.*?)\[\/url\]/ism',$item['body'],$matches,PREG_SET_ORDER);
- if($cnt) {
- foreach($matches as $mtch) {
- if(link_compare($link,$mtch[1]) || link_compare($dlink,$mtch[1])) {
+ $cnt = preg_match_all('/[\@\!]\[url\=(.*?)\](.*?)\[\/url\]/ism', $item['body'], $matches, PREG_SET_ORDER);
+ if ($cnt) {
+ foreach ($matches as $mtch) {
+ if (link_compare($link, $mtch[1]) || link_compare($dlink, $mtch[1])) {
$mention = true;
logger('tag_deliver: mention found: ' . $mtch[2]);
}
}
}
- if(! $mention){
- if ( ($community_page || $prvgroup) &&
- (!$item['wall']) && (!$item['origin']) && ($item['id'] == $item['parent'])){
+ if (! $mention) {
+ if (($community_page || $prvgroup) &&
+ (!$item['wall']) && (!$item['origin']) && ($item['id'] == $item['parent'])) {
// mmh.. no mention.. community page or private group... no wall.. no origin.. top-post (not a comment)
// delete it!
logger("tag_deliver: no-mention top-level post to communuty or private group. delete.");
call_hooks('tagged', $arr);
- if((! $community_page) && (! $prvgroup))
+ if ((! $community_page) && (! $prvgroup)) {
return;
+ }
-
- // tgroup delivery - setup a second delivery chain
- // prevent delivery looping - only proceed
- // if the message originated elsewhere and is a top-level post
-
- if(($item['wall']) || ($item['origin']) || ($item['id'] != $item['parent']))
+ /*
+ * tgroup delivery - setup a second delivery chain
+ * prevent delivery looping - only proceed
+ * if the message originated elsewhere and is a top-level post
+ */
+ if (($item['wall']) || ($item['origin']) || ($item['id'] != $item['parent'])) {
return;
+ }
// now change this copy of the post to a forum head message and deliver to all the tgroup members
-
-
- $c = q("select name, url, thumb from contact where self = 1 and uid = %d limit 1",
+ $c = q("SELECT `name`, `url`, `thumb` FROM `contact` WHERE `self` = 1 AND `uid` = %d LIMIT 1",
intval($u[0]['uid'])
);
- if(! count($c))
+ if (! dbm::is_result($c)) {
return;
+ }
// also reset all the privacy bits to the forum default permissions
$forum_mode = (($prvgroup) ? 2 : 1);
- q("update item set wall = 1, origin = 1, forum_mode = %d, `owner-name` = '%s', `owner-link` = '%s', `owner-avatar` = '%s',
- `private` = %d, `allow_cid` = '%s', `allow_gid` = '%s', `deny_cid` = '%s', `deny_gid` = '%s' where id = %d",
+ q("UPDATE `item` SET `wall` = 1, `origin` = 1, `forum_mode` = %d, `owner-name` = '%s', `owner-link` = '%s', `owner-avatar` = '%s',
+ `private` = %d, `allow_cid` = '%s', `allow_gid` = '%s', `deny_cid` = '%s', `deny_gid` = '%s' WHERE `id` = %d",
intval($forum_mode),
dbesc($c[0]['name']),
dbesc($c[0]['url']),
-function tgroup_check($uid,$item) {
-
- $a = get_app();
+function tgroup_check($uid, $item) {
$mention = false;
// check that the message originated elsewhere and is a top-level post
- if(($item['wall']) || ($item['origin']) || ($item['uri'] != $item['parent-uri']))
+ if (($item['wall']) || ($item['origin']) || ($item['uri'] != $item['parent-uri'])) {
return false;
+ }
-
- $u = q("select * from user where uid = %d limit 1",
+ /// @TODO Encapsulate this or find it encapsulated and replace all occurrances
+ $u = q("SELECT * FROM `user` WHERE `uid` = %d LIMIT 1",
intval($uid)
);
- if(! count($u))
+ if (! dbm::is_result($u)) {
return false;
+ }
$community_page = (($u[0]['page-flags'] == PAGE_COMMUNITY) ? true : false);
$prvgroup = (($u[0]['page-flags'] == PAGE_PRVGROUP) ? true : false);
+ $link = normalise_link(App::get_baseurl() . '/profile/' . $u[0]['nickname']);
- $link = normalise_link($a->get_baseurl() . '/profile/' . $u[0]['nickname']);
-
- // Diaspora uses their own hardwired link URL in @-tags
- // instead of the one we supply with webfinger
-
- $dlink = normalise_link($a->get_baseurl() . '/u/' . $u[0]['nickname']);
+ /*
+ * Diaspora uses their own hardwired link URL in @-tags
+ * instead of the one we supply with webfinger
+ */
+ $dlink = normalise_link(App::get_baseurl() . '/u/' . $u[0]['nickname']);
- $cnt = preg_match_all('/[\@\!]\[url\=(.*?)\](.*?)\[\/url\]/ism',$item['body'],$matches,PREG_SET_ORDER);
- if($cnt) {
- foreach($matches as $mtch) {
- if(link_compare($link,$mtch[1]) || link_compare($dlink,$mtch[1])) {
+ $cnt = preg_match_all('/[\@\!]\[url\=(.*?)\](.*?)\[\/url\]/ism', $item['body'], $matches, PREG_SET_ORDER);
+ if ($cnt) {
+ foreach ($matches as $mtch) {
+ if (link_compare($link, $mtch[1]) || link_compare($dlink, $mtch[1])) {
$mention = true;
logger('tgroup_check: mention found: ' . $mtch[2]);
}
}
}
- if(! $mention)
- return false;
-
- if((! $community_page) && (! $prvgroup))
+ if (! $mention) {
return false;
+ }
- return true;
+ /// @TODO Combine both return statements into one
+ return (($community_page) || ($prvgroup));
}
-/*
- This function returns true if $update has an edited timestamp newer
- than $existing, i.e. $update contains new data which should override
- what's already there. If there is no timestamp yet, the update is
- assumed to be newer. If the update has no timestamp, the existing
- item is assumed to be up-to-date. If the timestamps are equal it
- assumes the update has been seen before and should be ignored.
- */
-function edited_timestamp_is_newer($existing, $update) {
- if (!x($existing,'edited') || !$existing['edited']) {
- return true;
- }
- if (!x($update,'edited') || !$update['edited']) {
- return false;
- }
- $existing_edited = datetime_convert('UTC', 'UTC', $existing['edited']);
- $update_edited = datetime_convert('UTC', 'UTC', $update['edited']);
- return (strcmp($existing_edited, $update_edited) < 0);
+/**
+ * This function returns true if $update has an edited timestamp newer
+ * than $existing, i.e. $update contains new data which should override
+ * what's already there. If there is no timestamp yet, the update is
+ * assumed to be newer. If the update has no timestamp, the existing
+ * item is assumed to be up-to-date. If the timestamps are equal it
+ * assumes the update has been seen before and should be ignored.
+ *
+ * @todo fix type-hints (both array)
+ */
+function edited_timestamp_is_newer ($existing, $update) {
+ if (!x($existing, 'edited') || !$existing['edited']) {
+ return true;
+ }
+ if (!x($update, 'edited') || !$update['edited']) {
+ return false;
+ }
+
+ $existing_edited = datetime_convert('UTC', 'UTC', $existing['edited']);
+ $update_edited = datetime_convert('UTC', 'UTC', $update['edited']);
+ return (strcmp($existing_edited, $update_edited) < 0);
}
/**
* model where comments can have sub-threads. That would require some massive sorting
* to get all the feed items into a mostly linear ordering, and might still require
* recursion.
+ *
+ * @todo find proper type-hints
*/
-
-function consume_feed($xml,$importer,&$contact, &$hub, $datedir = 0, $pass = 0) {
+function consume_feed($xml, $importer, &$contact, &$hub, $datedir = 0, $pass = 0) {
if ($contact['network'] === NETWORK_OSTATUS) {
if ($pass < 2) {
// Test - remove before flight
//$tempfile = tempnam(get_temppath(), "ostatus2");
//file_put_contents($tempfile, $xml);
logger("Consume OStatus messages ", LOGGER_DEBUG);
- ostatus::import($xml,$importer,$contact, $hub);
+ ostatus::import($xml, $importer, $contact, $hub);
}
return;
}
if ($contact['network'] === NETWORK_FEED) {
if ($pass < 2) {
logger("Consume feeds", LOGGER_DEBUG);
- feed_import($xml,$importer,$contact, $hub);
+ feed_import($xml, $importer, $contact, $hub);
}
return;
}
if ($contact['network'] === NETWORK_DFRN) {
logger("Consume DFRN messages", LOGGER_DEBUG);
- $r = q("SELECT `contact`.*, `contact`.`uid` AS `importer_uid`,
+ $r = q("SELECT `contact`.*, `contact`.`uid` AS `importer_uid`,
`contact`.`pubkey` AS `cpubkey`,
`contact`.`prvkey` AS `cprvkey`,
`contact`.`thumb` AS `thumb`,
WHERE `contact`.`id` = %d AND `user`.`uid` = %d",
dbesc($contact["id"]), dbesc($importer["uid"])
);
- if ($r) {
+ if (dbm::is_result($r)) {
logger("Now import the DFRN feed");
- dfrn::import($xml,$r[0], true);
+ dfrn::import($xml, $r[0], true);
return;
}
}
}
+/// @TODO type-hint is array
function item_is_remote_self($contact, &$datarray) {
$a = get_app();
- if (!$contact['remote_self'])
+ if (!$contact['remote_self']) {
return false;
+ }
// Prevent the forwarding of posts that are forwarded
- if ($datarray["extid"] == NETWORK_DFRN)
+ if ($datarray["extid"] == NETWORK_DFRN) {
return false;
+ }
// Prevent to forward already forwarded posts
- if ($datarray["app"] == $a->get_hostname())
+ if ($datarray["app"] == $a->get_hostname()) {
return false;
+ }
// Only forward posts
- if ($datarray["verb"] != ACTIVITY_POST)
+ if ($datarray["verb"] != ACTIVITY_POST) {
return false;
+ }
- if (($contact['network'] != NETWORK_FEED) AND $datarray['private'])
+ if (($contact['network'] != NETWORK_FEED) AND $datarray['private']) {
return false;
+ }
$datarray2 = $datarray;
logger('remote-self start - Contact '.$contact['url'].' - '.$contact['remote_self'].' Item '.print_r($datarray, true), LOGGER_DEBUG);
if ($contact['remote_self'] == 2) {
$r = q("SELECT `id`,`url`,`name`,`thumb` FROM `contact` WHERE `uid` = %d AND `self`",
intval($contact['uid']));
- if (count($r)) {
+ if (dbm::is_result($r)) {
$datarray['contact-id'] = $r[0]["id"];
$datarray['owner-name'] = $r[0]["name"];
if ($contact['network'] != NETWORK_FEED) {
$datarray["guid"] = get_guid(32);
unset($datarray["plink"]);
- $datarray["uri"] = item_new_uri($a->get_hostname(),$contact['uid'], $datarray["guid"]);
+ $datarray["uri"] = item_new_uri($a->get_hostname(), $contact['uid'], $datarray["guid"]);
$datarray["parent-uri"] = $datarray["uri"];
$datarray["extid"] = $contact['network'];
$urlpart = parse_url($datarray2['author-link']);
$datarray["app"] = $urlpart["host"];
- } else
+ } else {
$datarray['private'] = 0;
+ }
}
if ($contact['network'] != NETWORK_FEED) {
// Store the original post
$r = item_store($datarray2, false, false);
logger('remote-self post original item - Contact '.$contact['url'].' return '.$r.' Item '.print_r($datarray2, true), LOGGER_DEBUG);
- } else
+ } else {
$datarray["app"] = "Feed";
+ }
return true;
}
-function new_follower($importer,$contact,$datarray,$item,$sharing = false) {
+/// @TODO find proper type-hints
+function new_follower($importer, $contact, $datarray, $item, $sharing = false) {
$url = notags(trim($datarray['author-link']));
$name = notags(trim($datarray['author-name']));
$photo = notags(trim($datarray['author-avatar']));
if (is_object($item)) {
$rawtag = $item->get_item_tags(NAMESPACE_ACTIVITY,'actor');
- if($rawtag && $rawtag[0]['child'][NAMESPACE_POCO]['preferredUsername'][0]['data'])
+ if ($rawtag && $rawtag[0]['child'][NAMESPACE_POCO]['preferredUsername'][0]['data']) {
$nick = $rawtag[0]['child'][NAMESPACE_POCO]['preferredUsername'][0]['data'];
- } else
+ }
+ } else {
$nick = $item;
+ }
- if(is_array($contact)) {
- if(($contact['network'] == NETWORK_OSTATUS && $contact['rel'] == CONTACT_IS_SHARING)
+ if (is_array($contact)) {
+ if (($contact['network'] == NETWORK_OSTATUS && $contact['rel'] == CONTACT_IS_SHARING)
|| ($sharing && $contact['rel'] == CONTACT_IS_FOLLOWER)) {
$r = q("UPDATE `contact` SET `rel` = %d, `writable` = 1 WHERE `id` = %d AND `uid` = %d",
intval(CONTACT_IS_FRIEND),
intval($importer['uid']),
dbesc($url)
);
- if(count($r)) {
+ if (dbm::is_result($r)) {
$contact_record = $r[0];
update_contact_avatar($photo, $importer["uid"], $contact_record["id"], true);
}
-
+ /// @TODO Encapsulate this into a function/method
$r = q("SELECT * FROM `user` WHERE `uid` = %d LIMIT 1",
intval($importer['uid'])
);
- $a = get_app();
- if(count($r) AND !in_array($r[0]['page-flags'], array(PAGE_SOAPBOX, PAGE_FREELOVE))) {
+
+ if (dbm::is_result($r) AND !in_array($r[0]['page-flags'], array(PAGE_SOAPBOX, PAGE_FREELOVE))) {
// create notification
$hash = random_string();
- if(is_array($contact_record)) {
+ if (is_array($contact_record)) {
$ret = q("INSERT INTO `intro` ( `uid`, `contact-id`, `blocked`, `knowyou`, `hash`, `datetime`)
VALUES ( %d, %d, 0, 0, '%s', '%s' )",
intval($importer['uid']),
$def_gid = get_default_group($importer['uid'], $contact_record["network"]);
- if(intval($def_gid))
- group_add_member($importer['uid'],'',$contact_record['id'],$def_gid);
+ if (intval($def_gid)) {
+ group_add_member($importer['uid'], '', $contact_record['id'], $def_gid);
+ }
- if(($r[0]['notify-flags'] & NOTIFY_INTRO) &&
+ if (($r[0]['notify-flags'] & NOTIFY_INTRO) &&
in_array($r[0]['page-flags'], array(PAGE_NORMAL))) {
notification(array(
'to_name' => $r[0]['username'],
'to_email' => $r[0]['email'],
'uid' => $r[0]['uid'],
- 'link' => $a->get_baseurl() . '/notifications/intro',
+ 'link' => App::get_baseurl() . '/notifications/intro',
'source_name' => ((strlen(stripslashes($contact_record['name']))) ? stripslashes($contact_record['name']) : t('[Name Withheld]')),
'source_link' => $contact_record['url'],
'source_photo' => $contact_record['photo'],
));
}
- } elseif (count($r) AND in_array($r[0]['page-flags'], array(PAGE_SOAPBOX, PAGE_FREELOVE))) {
+ } elseif (dbm::is_result($r) AND in_array($r[0]['page-flags'], array(PAGE_SOAPBOX, PAGE_FREELOVE))) {
$r = q("UPDATE `contact` SET `pending` = 0 WHERE `uid` = %d AND `url` = '%s' AND `pending` LIMIT 1",
intval($importer['uid']),
dbesc($url)
}
}
-function lose_follower($importer,$contact,$datarray = array(),$item = "") {
+function lose_follower($importer, $contact, array $datarray = array(), $item = "") {
- if(($contact['rel'] == CONTACT_IS_FRIEND) || ($contact['rel'] == CONTACT_IS_SHARING)) {
+ if (($contact['rel'] == CONTACT_IS_FRIEND) || ($contact['rel'] == CONTACT_IS_SHARING)) {
q("UPDATE `contact` SET `rel` = %d WHERE `id` = %d",
intval(CONTACT_IS_SHARING),
intval($contact['id'])
);
- }
- else {
+ } else {
contact_remove($contact['id']);
}
}
-function lose_sharer($importer,$contact,$datarray = array(),$item = "") {
+function lose_sharer($importer, $contact, array $datarray = array(), $item = "") {
- if(($contact['rel'] == CONTACT_IS_FRIEND) || ($contact['rel'] == CONTACT_IS_FOLLOWER)) {
+ if (($contact['rel'] == CONTACT_IS_FRIEND) || ($contact['rel'] == CONTACT_IS_FOLLOWER)) {
q("UPDATE `contact` SET `rel` = %d WHERE `id` = %d",
intval(CONTACT_IS_FOLLOWER),
intval($contact['id'])
);
- }
- else {
+ } else {
contact_remove($contact['id']);
}
}
-function subscribe_to_hub($url,$importer,$contact,$hubmode = 'subscribe') {
+function subscribe_to_hub($url, $importer, $contact, $hubmode = 'subscribe') {
$a = get_app();
- if(is_array($importer)) {
+ if (is_array($importer)) {
$r = q("SELECT `nickname` FROM `user` WHERE `uid` = %d LIMIT 1",
intval($importer['uid'])
);
}
- // Diaspora has different message-ids in feeds than they do
- // through the direct Diaspora protocol. If we try and use
- // the feed, we'll get duplicates. So don't.
-
- if((! count($r)) || $contact['network'] === NETWORK_DIASPORA)
+ /*
+ * Diaspora has different message-ids in feeds than they do
+ * through the direct Diaspora protocol. If we try and use
+ * the feed, we'll get duplicates. So don't.
+ */
+ if ((! dbm::is_result($r)) || $contact['network'] === NETWORK_DIASPORA) {
return;
+ }
$push_url = get_config('system','url') . '/pubsub/' . $r[0]['nickname'] . '/' . $contact['id'];
// Use a single verify token, even if multiple hubs
-
$verify_token = ((strlen($contact['hub-verify'])) ? $contact['hub-verify'] : random_string());
$params= 'hub.mode=' . $hubmode . '&hub.callback=' . urlencode($push_url) . '&hub.topic=' . urlencode($contact['poll']) . '&hub.verify=async&hub.verify_token=' . $verify_token;
logger('subscribe_to_hub: ' . $hubmode . ' ' . $contact['name'] . ' to hub ' . $url . ' endpoint: ' . $push_url . ' with verifier ' . $verify_token);
- if(!strlen($contact['hub-verify']) OR ($contact['hub-verify'] != $verify_token)) {
+ if (!strlen($contact['hub-verify']) OR ($contact['hub-verify'] != $verify_token)) {
$r = q("UPDATE `contact` SET `hub-verify` = '%s' WHERE `id` = %d",
dbesc($verify_token),
intval($contact['id'])
);
}
- post_url($url,$params);
+ post_url($url, $params);
logger('subscribe_to_hub: returns: ' . $a->get_curl_code(), LOGGER_DEBUG);
function fix_private_photos($s, $uid, $item = null, $cid = 0) {
- if(get_config('system','disable_embedded'))
+ if (get_config('system','disable_embedded')) {
return $s;
+ }
$a = get_app();
logger('fix_private_photos: check for photos', LOGGER_DEBUG);
- $site = substr($a->get_baseurl(),strpos($a->get_baseurl(),'://'));
+ $site = substr(App::get_baseurl(),strpos(App::get_baseurl(),'://'));
$orig_body = $s;
$new_body = '';
$img_start = strpos($orig_body, '[img');
$img_st_close = ($img_start !== false ? strpos(substr($orig_body, $img_start), ']') : false);
$img_len = ($img_start !== false ? strpos(substr($orig_body, $img_start + $img_st_close + 1), '[/img]') : false);
- while( ($img_st_close !== false) && ($img_len !== false) ) {
+ while ( ($img_st_close !== false) && ($img_len !== false) ) {
$img_st_close++; // make it point to AFTER the closing bracket
$image = substr($orig_body, $img_start + $img_st_close, $img_len);
logger('fix_private_photos: found photo ' . $image, LOGGER_DEBUG);
- if(stristr($image , $site . '/photo/')) {
+ if (stristr($image , $site . '/photo/')) {
// Only embed locally hosted photos
$replace = false;
$i = basename($image);
- $i = str_replace(array('.jpg','.png','.gif'),array('','',''),$i);
- $x = strpos($i,'-');
+ $i = str_replace(array('.jpg', '.png', '.gif'),array('', '',''), $i);
+ $x = strpos($i, '-');
- if($x) {
- $res = substr($i,$x+1);
- $i = substr($i,0,$x);
+ if ($x) {
+ $res = substr($i, $x + 1);
+ $i = substr($i, 0, $x);
$r = q("SELECT * FROM `photo` WHERE `resource-id` = '%s' AND `scale` = %d AND `uid` = %d",
dbesc($i),
intval($res),
intval($uid)
+
);
- if($r) {
-
- // Check to see if we should replace this photo link with an embedded image
- // 1. No need to do so if the photo is public
- // 2. If there's a contact-id provided, see if they're in the access list
- // for the photo. If so, embed it.
- // 3. Otherwise, if we have an item, see if the item permissions match the photo
- // permissions, regardless of order but first check to see if they're an exact
- // match to save some processing overhead.
-
- if(has_permissions($r[0])) {
- if($cid) {
+ if (dbm::is_result($r)) {
+ /*
+ * Check to see if we should replace this photo link with an embedded image
+ * 1. No need to do so if the photo is public
+ * 2. If there's a contact-id provided, see if they're in the access list
+ * for the photo. If so, embed it.
+ * 3. Otherwise, if we have an item, see if the item permissions match the photo
+ * permissions, regardless of order but first check to see if they're an exact
+ * match to save some processing overhead.
+ */
+ if (has_permissions($r[0])) {
+ if ($cid) {
$recips = enumerate_permissions($r[0]);
- if(in_array($cid, $recips)) {
+ if (in_array($cid, $recips)) {
$replace = true;
}
- }
- elseif($item) {
- if(compare_permissions($item,$r[0]))
+ } elseif ($item) {
+ if (compare_permissions($item, $r[0])) {
$replace = true;
+ }
}
}
- if($replace) {
+ if ($replace) {
$data = $r[0]['data'];
$type = $r[0]['type'];
// If a custom width and height were specified, apply before embedding
- if(preg_match("/\[img\=([0-9]*)x([0-9]*)\]/is", substr($orig_body, $img_start, $img_st_close), $match)) {
+ if (preg_match("/\[img\=([0-9]*)x([0-9]*)\]/is", substr($orig_body, $img_start, $img_st_close), $match)) {
logger('fix_private_photos: scaling photo', LOGGER_DEBUG);
$width = intval($match[1]);
$height = intval($match[2]);
$ph = new Photo($data, $type);
- if($ph->is_valid()) {
+ if ($ph->is_valid()) {
$ph->scaleImage(max($width, $height));
$data = $ph->imageString();
$type = $ph->getType();
$new_body = $new_body . substr($orig_body, 0, $img_start + $img_st_close) . $image . '[/img]';
$orig_body = substr($orig_body, $img_start + $img_st_close + $img_len + strlen('[/img]'));
- if($orig_body === false)
+ if ($orig_body === false) {
$orig_body = '';
+ }
$img_start = strpos($orig_body, '[img');
$img_st_close = ($img_start !== false ? strpos(substr($orig_body, $img_start), ']') : false);
$new_body = $new_body . $orig_body;
- return($new_body);
+ return $new_body;
}
+/// @TODO type-hint is array
function has_permissions($obj) {
- if(($obj['allow_cid'] != '') || ($obj['allow_gid'] != '') || ($obj['deny_cid'] != '') || ($obj['deny_gid'] != ''))
- return true;
- return false;
+ return (
+ (
+ x($obj, 'allow_cid')
+ ) || (
+ x($obj, 'allow_gid')
+ ) || (
+ x($obj, 'deny_cid')
+ ) || (
+ x($obj, 'deny_gid')
+ )
+ );
}
-function compare_permissions($obj1,$obj2) {
+/// @TODO type-hint is array
+function compare_permissions($obj1, $obj2) {
// first part is easy. Check that these are exactly the same.
- if(($obj1['allow_cid'] == $obj2['allow_cid'])
+ if (($obj1['allow_cid'] == $obj2['allow_cid'])
&& ($obj1['allow_gid'] == $obj2['allow_gid'])
&& ($obj1['deny_cid'] == $obj2['deny_cid'])
- && ($obj1['deny_gid'] == $obj2['deny_gid']))
+ && ($obj1['deny_gid'] == $obj2['deny_gid'])) {
return true;
+ }
// This is harder. Parse all the permissions and compare the resulting set.
-
$recipients1 = enumerate_permissions($obj1);
$recipients2 = enumerate_permissions($obj2);
sort($recipients1);
sort($recipients2);
- if($recipients1 == $recipients2)
- return true;
- return false;
+
+ /// @TODO Comparison of arrays, maybe use array_diff_assoc() here?
+ return ($recipients1 == $recipients2);
}
// returns an array of contact-ids that are allowed to see this object
-
+/// @TODO type-hint is array
function enumerate_permissions($obj) {
$allow_people = expand_acl($obj['allow_cid']);
$allow_groups = expand_groups(expand_acl($obj['allow_gid']));
$deny_people = expand_acl($obj['deny_cid']);
$deny_groups = expand_groups(expand_acl($obj['deny_gid']));
- $recipients = array_unique(array_merge($allow_people,$allow_groups));
- $deny = array_unique(array_merge($deny_people,$deny_groups));
- $recipients = array_diff($recipients,$deny);
+ $recipients = array_unique(array_merge($allow_people, $allow_groups));
+ $deny = array_unique(array_merge($deny_people, $deny_groups));
+ $recipients = array_diff($recipients, $deny);
return $recipients;
}
function item_getfeedtags($item) {
$ret = array();
$matches = false;
- $cnt = preg_match_all('|\#\[url\=(.*?)\](.*?)\[\/url\]|',$item['tag'],$matches);
- if($cnt) {
- for($x = 0; $x < $cnt; $x ++) {
- if($matches[1][$x])
- $ret[$matches[2][$x]] = array('#',$matches[1][$x], $matches[2][$x]);
+ $cnt = preg_match_all('|\#\[url\=(.*?)\](.*?)\[\/url\]|', $item['tag'], $matches);
+ if ($cnt) {
+ for ($x = 0; $x < $cnt; $x ++) {
+ if ($matches[1][$x]) {
+ $ret[$matches[2][$x]] = array('#', $matches[1][$x], $matches[2][$x]);
+ }
}
}
$matches = false;
- $cnt = preg_match_all('|\@\[url\=(.*?)\](.*?)\[\/url\]|',$item['tag'],$matches);
- if($cnt) {
- for($x = 0; $x < $cnt; $x ++) {
- if($matches[1][$x])
- $ret[] = array('@',$matches[1][$x], $matches[2][$x]);
+ $cnt = preg_match_all('|\@\[url\=(.*?)\](.*?)\[\/url\]|', $item['tag'], $matches);
+ if ($cnt) {
+ for ($x = 0; $x < $cnt; $x ++) {
+ if ($matches[1][$x]) {
+ $ret[] = array('@', $matches[1][$x], $matches[2][$x]);
+ }
}
}
return $ret;
function item_expire($uid, $days, $network = "", $force = false) {
- if((! $uid) || ($days < 1))
+ if ((! $uid) || ($days < 1)) {
return;
+ }
- // $expire_network_only = save your own wall posts
- // and just expire conversations started by others
-
- $expire_network_only = get_pconfig($uid,'expire','network_only');
+ /*
+ * $expire_network_only = save your own wall posts
+ * and just expire conversations started by others
+ */
+ $expire_network_only = get_pconfig($uid,'expire', 'network_only');
$sql_extra = ((intval($expire_network_only)) ? " AND wall = 0 " : "");
if ($network != "") {
$sql_extra .= sprintf(" AND network = '%s' ", dbesc($network));
- // There is an index "uid_network_received" but not "uid_network_created"
- // This avoids the creation of another index just for one purpose.
- // And it doesn't really matter wether to look at "received" or "created"
+
+ /*
+ * There is an index "uid_network_received" but not "uid_network_created"
+ * This avoids the creation of another index just for one purpose.
+ * And it doesn't really matter wether to look at "received" or "created"
+ */
$range = "AND `received` < UTC_TIMESTAMP() - INTERVAL %d DAY ";
- } else
+ } else {
$range = "AND `created` < UTC_TIMESTAMP() - INTERVAL %d DAY ";
+ }
$r = q("SELECT `file`, `resource-id`, `starred`, `type`, `id` FROM `item`
WHERE `uid` = %d $range
intval($days)
);
- if(! count($r))
+ if (! dbm::is_result($r)) {
return;
+ }
- $expire_items = get_pconfig($uid, 'expire','items');
- $expire_items = (($expire_items===false)?1:intval($expire_items)); // default if not set: 1
+ $expire_items = get_pconfig($uid, 'expire', 'items');
+ $expire_items = (($expire_items === false) ? 1 : intval($expire_items)); // default if not set: 1
// Forcing expiring of items - but not notes and marked items
- if ($force)
+ if ($force) {
$expire_items = true;
+ }
- $expire_notes = get_pconfig($uid, 'expire','notes');
- $expire_notes = (($expire_notes===false)?1:intval($expire_notes)); // default if not set: 1
+ $expire_notes = get_pconfig($uid, 'expire', 'notes');
+ $expire_notes = (($expire_notes === false) ? 1 : intval($expire_notes)); // default if not set: 1
- $expire_starred = get_pconfig($uid, 'expire','starred');
- $expire_starred = (($expire_starred===false)?1:intval($expire_starred)); // default if not set: 1
+ $expire_starred = get_pconfig($uid, 'expire', 'starred');
+ $expire_starred = (($expire_starred === false) ? 1 : intval($expire_starred)); // default if not set: 1
- $expire_photos = get_pconfig($uid, 'expire','photos');
- $expire_photos = (($expire_photos===false)?0:intval($expire_photos)); // default if not set: 0
+ $expire_photos = get_pconfig($uid, 'expire', 'photos');
+ $expire_photos = (($expire_photos === false) ? 0 : intval($expire_photos)); // default if not set: 0
logger('expire: # items=' . count($r). "; expire items: $expire_items, expire notes: $expire_notes, expire starred: $expire_starred, expire photos: $expire_photos");
- foreach($r as $item) {
+ foreach ($r as $item) {
// don't expire filed items
- if(strpos($item['file'],'[') !== false)
+ if (strpos($item['file'],'[') !== false) {
continue;
+ }
// Only expire posts, not photos and photo comments
- if($expire_photos==0 && strlen($item['resource-id']))
+ if ($expire_photos == 0 && strlen($item['resource-id'])) {
continue;
- if($expire_starred==0 && intval($item['starred']))
+ } elseif ($expire_starred == 0 && intval($item['starred'])) {
continue;
- if($expire_notes==0 && $item['type']=='note')
+ } elseif ($expire_notes == 0 && $item['type'] == 'note') {
continue;
- if($expire_items==0 && $item['type']!='note')
+ } elseif ($expire_items == 0 && $item['type'] != 'note') {
continue;
+ }
- drop_item($item['id'],false);
+ drop_item($item['id'], false);
}
- proc_run(PRIORITY_HIGH,"include/notifier.php", "expire", $uid);
+ proc_run(PRIORITY_HIGH, "include/notifier.php", "expire", $uid);
}
-
+/// @TODO type-hint is array
function drop_items($items) {
$uid = 0;
- if(! local_user() && ! remote_user())
+ if (! local_user() && ! remote_user()) {
return;
+ }
- if(count($items)) {
- foreach($items as $item) {
+ if (count($items)) {
+ foreach ($items as $item) {
$owner = drop_item($item,false);
- if($owner && ! $uid)
+ if ($owner && ! $uid)
$uid = $owner;
}
}
// multiple threads may have been deleted, send an expire notification
- if($uid)
- proc_run(PRIORITY_HIGH,"include/notifier.php", "expire", $uid);
+ if ($uid) {
+ proc_run(PRIORITY_HIGH, "include/notifier.php", "expire", $uid);
+ }
}
-function drop_item($id,$interactive = true) {
+function drop_item($id, $interactive = true) {
$a = get_app();
intval($id)
);
- if(! count($r)) {
- if(! $interactive)
+ if (! dbm::is_result($r)) {
+ if (! $interactive) {
return 0;
+ }
notice( t('Item not found.') . EOL);
- goaway($a->get_baseurl() . '/' . $_SESSION['return_url']);
+ goaway(App::get_baseurl() . '/' . $_SESSION['return_url']);
}
$item = $r[0];
$owner = $item['uid'];
- $cid = 0;
+ $contact_id = 0;
// check if logged in user is either the author or owner of this item
- if(is_array($_SESSION['remote'])) {
- foreach($_SESSION['remote'] as $visitor) {
- if($visitor['uid'] == $item['uid'] && $visitor['cid'] == $item['contact-id']) {
- $cid = $visitor['cid'];
+ if (is_array($_SESSION['remote'])) {
+ foreach ($_SESSION['remote'] as $visitor) {
+ if ($visitor['uid'] == $item['uid'] && $visitor['cid'] == $item['contact-id']) {
+ $contact_id = $visitor['cid'];
break;
}
}
}
- if((local_user() == $item['uid']) || ($cid) || (! $interactive)) {
+ if ((local_user() == $item['uid']) || ($contact_id) || (! $interactive)) {
// Check if we should do HTML-based delete confirmation
- if($_REQUEST['confirm']) {
+ if ($_REQUEST['confirm']) {
// <form> can't take arguments in its "action" parameter
// so add any arguments as hidden inputs
$query = explode_querystring($a->query_string);
$inputs = array();
- foreach($query['args'] as $arg) {
- if(strpos($arg, 'confirm=') === false) {
+ foreach ($query['args'] as $arg) {
+ if (strpos($arg, 'confirm=') === false) {
$arg_parts = explode('=', $arg);
$inputs[] = array('name' => $arg_parts[0], 'value' => $arg_parts[1]);
}
));
}
// Now check how the user responded to the confirmation query
- if($_REQUEST['canceled']) {
- goaway($a->get_baseurl() . '/' . $_SESSION['return_url']);
+ if ($_REQUEST['canceled']) {
+ goaway(App::get_baseurl() . '/' . $_SESSION['return_url']);
}
logger('delete item: ' . $item['id'], LOGGER_DEBUG);
// clean up categories and tags so they don't end up as orphans
$matches = false;
- $cnt = preg_match_all('/<(.*?)>/',$item['file'],$matches,PREG_SET_ORDER);
- if($cnt) {
- foreach($matches as $mtch) {
- file_tag_unsave_file($item['uid'],$item['id'],$mtch[1],true);
+ $cnt = preg_match_all('/<(.*?)>/', $item['file'], $matches, PREG_SET_ORDER);
+ if ($cnt) {
+ foreach ($matches as $mtch) {
+ file_tag_unsave_file($item['uid'], $item['id'], $mtch[1],true);
}
}
$matches = false;
- $cnt = preg_match_all('/\[(.*?)\]/',$item['file'],$matches,PREG_SET_ORDER);
- if($cnt) {
- foreach($matches as $mtch) {
- file_tag_unsave_file($item['uid'],$item['id'],$mtch[1],false);
+ $cnt = preg_match_all('/\[(.*?)\]/', $item['file'], $matches, PREG_SET_ORDER);
+ if ($cnt) {
+ foreach ($matches as $mtch) {
+ file_tag_unsave_file($item['uid'], $item['id'], $mtch[1],false);
}
}
- // If item is a link to a photo resource, nuke all the associated photos
- // (visitors will not have photo resources)
- // This only applies to photos uploaded from the photos page. Photos inserted into a post do not
- // generate a resource-id and therefore aren't intimately linked to the item.
-
- if(strlen($item['resource-id'])) {
+ /*
+ * If item is a link to a photo resource, nuke all the associated photos
+ * (visitors will not have photo resources)
+ * This only applies to photos uploaded from the photos page. Photos inserted into a post do not
+ * generate a resource-id and therefore aren't intimately linked to the item.
+ */
+ if (strlen($item['resource-id'])) {
q("DELETE FROM `photo` WHERE `resource-id` = '%s' AND `uid` = %d ",
dbesc($item['resource-id']),
intval($item['uid'])
}
// If item is a link to an event, nuke the event record.
-
- if(intval($item['event-id'])) {
+ if (intval($item['event-id'])) {
q("DELETE FROM `event` WHERE `id` = %d AND `uid` = %d",
intval($item['event-id']),
intval($item['uid'])
}
// If item has attachments, drop them
-
- foreach(explode(",",$item['attach']) as $attach){
+ foreach (explode(", ", $item['attach']) as $attach) {
preg_match("|attach/(\d+)|", $attach, $matches);
q("DELETE FROM `attach` WHERE `id` = %d AND `uid` = %d",
intval($matches[1]),
// clean up item_id and sign meta-data tables
/*
- // Old code - caused very long queries and warning entries in the mysql logfiles:
+ /// @TODO Old code - caused very long queries and warning entries in the mysql logfiles:
$r = q("DELETE FROM item_id where iid in (select id from item where parent = %d and uid = %d)",
intval($item['id']),
// The new code splits the queries since the mysql optimizer really has bad problems with subqueries
// Creating list of parents
- $r = q("select id from item where parent = %d and uid = %d",
+ $r = q("SELECT `id` FROM `item` WHERE `parent` = %d AND `uid` = %d",
intval($item['id']),
intval($item['uid'])
);
$parentid = "";
- foreach ($r AS $row) {
- if ($parentid != "")
+ foreach ($r as $row) {
+ if ($parentid != "") {
$parentid .= ", ";
+ }
$parentid .= $row["id"];
}
// Now delete them
if ($parentid != "") {
- $r = q("DELETE FROM item_id where iid in (%s)", dbesc($parentid));
-
- $r = q("DELETE FROM sign where iid in (%s)", dbesc($parentid));
+ $r = q("DELETE FROM `item_id` WHERE `iid` IN (%s)", dbesc($parentid));
+ $r = q("DELETE FROM `sign` WHERE `iid` IN (%s)", dbesc($parentid));
}
// If it's the parent of a comment thread, kill all the kids
-
- if($item['uri'] == $item['parent-uri']) {
+ if ($item['uri'] == $item['parent-uri']) {
$r = q("UPDATE `item` SET `deleted` = 1, `edited` = '%s', `changed` = '%s', `body` = '' , `title` = ''
WHERE `parent-uri` = '%s' AND `uid` = %d ",
dbesc(datetime_convert()),
create_files_from_itemuri($item['parent-uri'], $item['uid']);
delete_thread_uri($item['parent-uri'], $item['uid']);
// ignore the result
- }
- else {
+ } else {
// ensure that last-child is set in case the comment that had it just got wiped.
q("UPDATE `item` SET `last-child` = 0, `changed` = '%s' WHERE `parent-uri` = '%s' AND `uid` = %d ",
dbesc(datetime_convert()),
dbesc($item['parent-uri']),
intval($item['uid'])
);
- if(count($r)) {
+ if (dbm::is_result($r)) {
q("UPDATE `item` SET `last-child` = 1 WHERE `id` = %d",
intval($r[0]['id'])
);
// send the notification upstream/downstream as the case may be
- proc_run(PRIORITY_HIGH,"include/notifier.php", "drop", $drop_id);
+ proc_run(PRIORITY_HIGH, "include/notifier.php", "drop", $drop_id);
- if(! $interactive)
+ if (! $interactive) {
return $owner;
- goaway($a->get_baseurl() . '/' . $_SESSION['return_url']);
+ }
+ goaway(App::get_baseurl() . '/' . $_SESSION['return_url']);
//NOTREACHED
- }
- else {
- if(! $interactive)
+ } else {
+ if (! $interactive) {
return 0;
+ }
notice( t('Permission denied.') . EOL);
- goaway($a->get_baseurl() . '/' . $_SESSION['return_url']);
+ goaway(App::get_baseurl() . '/' . $_SESSION['return_url']);
//NOTREACHED
}
}
-function first_post_date($uid,$wall = false) {
- $r = q("select id, created from item
- where uid = %d and wall = %d and deleted = 0 and visible = 1 AND moderated = 0
- and id = parent
- order by created asc limit 1",
+function first_post_date($uid, $wall = false) {
+ $r = q("SELECT `id`, `created` FROM `item`
+ WHERE `uid` = %d AND `wall` = %d AND `deleted` = 0 AND `visible` = 1 AND `moderated` = 0
+ AND `id` = `parent`
+ ORDER BY `created` ASC LIMIT 1",
intval($uid),
intval($wall ? 1 : 0)
);
- if(count($r)) {
-// logger('first_post_date: ' . $r[0]['id'] . ' ' . $r[0]['created'], LOGGER_DATA);
- return substr(datetime_convert('',date_default_timezone_get(),$r[0]['created']),0,10);
+ if (dbm::is_result($r)) {
+ // logger('first_post_date: ' . $r[0]['id'] . ' ' . $r[0]['created'], LOGGER_DATA);
+ return substr(datetime_convert('',date_default_timezone_get(), $r[0]['created']),0,10);
}
return false;
}
/* modified posted_dates() {below} to arrange the list in years */
function list_post_dates($uid, $wall) {
- $dnow = datetime_convert('',date_default_timezone_get(),'now','Y-m-d');
+ $dnow = datetime_convert('',date_default_timezone_get(), 'now','Y-m-d');
$dthen = first_post_date($uid, $wall);
- if(! $dthen)
+ if (! $dthen) {
return array();
+ }
// Set the start and end date to the beginning of the month
- $dnow = substr($dnow,0,8).'01';
- $dthen = substr($dthen,0,8).'01';
+ $dnow = substr($dnow, 0, 8) . '01';
+ $dthen = substr($dthen, 0, 8) . '01';
$ret = array();
- // Starting with the current month, get the first and last days of every
- // month down to and including the month of the first post
- while(substr($dnow, 0, 7) >= substr($dthen, 0, 7)) {
- $dyear = intval(substr($dnow,0,4));
- $dstart = substr($dnow,0,8) . '01';
- $dend = substr($dnow,0,8) . get_dim(intval($dnow),intval(substr($dnow,5)));
- $start_month = datetime_convert('','',$dstart,'Y-m-d');
- $end_month = datetime_convert('','',$dend,'Y-m-d');
- $str = day_translate(datetime_convert('','',$dnow,'F'));
- if(! $ret[$dyear])
+ /*
+ * Starting with the current month, get the first and last days of every
+ * month down to and including the month of the first post
+ */
+ while (substr($dnow, 0, 7) >= substr($dthen, 0, 7)) {
+ $dyear = intval(substr($dnow, 0, 4));
+ $dstart = substr($dnow, 0, 8) . '01';
+ $dend = substr($dnow, 0, 8) . get_dim(intval($dnow), intval(substr($dnow, 5)));
+ $start_month = datetime_convert('', '', $dstart, 'Y-m-d');
+ $end_month = datetime_convert('', '', $dend, 'Y-m-d');
+ $str = day_translate(datetime_convert('', '', $dnow, 'F'));
+ if (!$ret[$dyear]) {
$ret[$dyear] = array();
- $ret[$dyear][] = array($str,$end_month,$start_month);
- $dnow = datetime_convert('','',$dnow . ' -1 month', 'Y-m-d');
+ }
+ $ret[$dyear][] = array($str, $end_month, $start_month);
+ $dnow = datetime_convert('', '', $dnow . ' -1 month', 'Y-m-d');
}
return $ret;
}
-function posted_dates($uid,$wall) {
- $dnow = datetime_convert('',date_default_timezone_get(),'now','Y-m-d');
+function posted_dates($uid, $wall) {
+ $dnow = datetime_convert('', date_default_timezone_get(), 'now', 'Y-m-d');
- $dthen = first_post_date($uid,$wall);
- if(! $dthen)
+ $dthen = first_post_date($uid, $wall);
+ if (! $dthen) {
return array();
+ }
// Set the start and end date to the beginning of the month
- $dnow = substr($dnow,0,8).'01';
- $dthen = substr($dthen,0,8).'01';
+ $dnow = substr($dnow, 0, 8) . '01';
+ $dthen = substr($dthen, 0, 8) . '01';
$ret = array();
- // Starting with the current month, get the first and last days of every
- // month down to and including the month of the first post
- while(substr($dnow, 0, 7) >= substr($dthen, 0, 7)) {
- $dstart = substr($dnow,0,8) . '01';
- $dend = substr($dnow,0,8) . get_dim(intval($dnow),intval(substr($dnow,5)));
- $start_month = datetime_convert('','',$dstart,'Y-m-d');
- $end_month = datetime_convert('','',$dend,'Y-m-d');
- $str = day_translate(datetime_convert('','',$dnow,'F Y'));
- $ret[] = array($str,$end_month,$start_month);
- $dnow = datetime_convert('','',$dnow . ' -1 month', 'Y-m-d');
+ /*
+ * Starting with the current month, get the first and last days of every
+ * month down to and including the month of the first post
+ */
+ while (substr($dnow, 0, 7) >= substr($dthen, 0, 7)) {
+ $dstart = substr($dnow, 0, 8) . '01';
+ $dend = substr($dnow, 0, 8) . get_dim(intval($dnow), intval(substr($dnow, 5)));
+ $start_month = datetime_convert('', '', $dstart, 'Y-m-d');
+ $end_month = datetime_convert('', '', $dend, 'Y-m-d');
+ $str = day_translate(datetime_convert('', '', $dnow, 'F Y'));
+ $ret[] = array($str, $end_month, $start_month);
+ $dnow = datetime_convert('', '', $dnow . ' -1 month', 'Y-m-d');
}
return $ret;
}
-function posted_date_widget($url,$uid,$wall) {
+function posted_date_widget($url, $uid, $wall) {
$o = '';
- if(! feature_enabled($uid,'archives'))
+ if (! feature_enabled($uid, 'archives')) {
return $o;
+ }
// For former Facebook folks that left because of "timeline"
-
-/* if($wall && intval(get_pconfig($uid,'system','no_wall_archive_widget')))
- return $o;*/
+ /*
+ * @TODO old-lost code?
+ if ($wall && intval(get_pconfig($uid, 'system', 'no_wall_archive_widget')))
+ return $o;
+ */
$visible_years = get_pconfig($uid,'system','archive_visible_years');
- if(! $visible_years)
+ if (! $visible_years) {
$visible_years = 5;
+ }
- $ret = list_post_dates($uid,$wall);
+ $ret = list_post_dates($uid, $wall);
- if(! count($ret))
+ if (! dbm::is_result($ret)) {
return $o;
+ }
- $cutoff_year = intval(datetime_convert('',date_default_timezone_get(),'now','Y')) - $visible_years;
- $cutoff = ((array_key_exists($cutoff_year,$ret))? true : false);
+ $cutoff_year = intval(datetime_convert('',date_default_timezone_get(), 'now', 'Y')) - $visible_years;
+ $cutoff = ((array_key_exists($cutoff_year, $ret))? true : false);
$o = replace_macros(get_markup_template('posted_date_widget.tpl'),array(
'$title' => t('Archives'),