// It maybe is a rich content, but if it does have everything that a link has,
// then treat it that way
if (($data["type"] == "rich") AND is_string($data["title"]) AND
- is_string($data["text"]) AND (sizeof($data["images"]) > 0))
+ is_string($data["text"]) AND (sizeof($data["images"]) > 0)) {
$data["type"] = "link";
+ }
- if ((($data["type"] != "link") AND ($data["type"] != "video") AND ($data["type"] != "photo")) OR ($data["title"] == $url))
- return("");
+ if ((($data["type"] != "link") AND ($data["type"] != "video") AND ($data["type"] != "photo")) OR ($data["title"] == $data["url"])) {
+ return "";
+ }
- if ($no_photos AND ($data["type"] == "photo"))
- return("");
+ if ($no_photos AND ($data["type"] == "photo")) {
+ return "";
+ }
- if (sizeof($data["images"]) > 0)
+ if (sizeof($data["images"]) > 0) {
$preview = $data["images"][0];
- else
+ } else {
$preview = "";
+ }
// Escape some bad characters
$data["url"] = str_replace(array("[", "]"), array("[", "]"), htmlentities($data["url"], ENT_QUOTES, 'UTF-8', false));
$text = "[attachment type='".$data["type"]."'";
- if ($data["url"] != "")
+ if ($data["text"] == "") {
+ $data["text"] = $data["title"];
+ }
+
+ if ($data["text"] == "") {
+ $data["text"] = $data["url"];
+ }
+
+ if ($data["url"] != "") {
$text .= " url='".$data["url"]."'";
- if ($data["title"] != "")
+ }
+
+ if ($data["title"] != "") {
$text .= " title='".$data["title"]."'";
+ }
+
if (sizeof($data["images"]) > 0) {
$preview = str_replace(array("[", "]"), array("[", "]"), htmlentities($data["images"][0]["src"], ENT_QUOTES, 'UTF-8', false));
// if the preview picture is larger than 500 pixels then show it in a larger mode
// But only, if the picture isn't higher than large (To prevent huge posts)
- if (($data["images"][0]["width"] >= 500) AND ($data["images"][0]["width"] >= $data["images"][0]["height"]))
+ if (($data["images"][0]["width"] >= 500) AND ($data["images"][0]["width"] >= $data["images"][0]["height"])) {
$text .= " image='".$preview."'";
- else
+ } else {
$text .= " preview='".$preview."'";
+ }
}
+
$text .= "]".$data["text"]."[/attachment]";
$hashtags = "";
* @brief Creates an unique guid out of a given uri
*
* @param string $uri uri of an item entry
+ * @param string $host (Optional) hostname for the GUID prefix
* @return string unique guid
*/
-function uri_to_guid($uri) {
+function uri_to_guid($uri, $host = "") {
// Our regular guid routine is using this kind of prefix as well
// We have to avoid that different routines could accidentally create the same value
$parsed = parse_url($uri);
- $guid_prefix = hash("crc32", $parsed["host"]);
+
+ if ($host == "") {
+ $host = $parsed["host"];
+ }
+
+ $guid_prefix = hash("crc32", $host);
// Remove the scheme to make sure that "https" and "http" doesn't make a difference
unset($parsed["scheme"]);
function item_store($arr,$force_parent = false, $notify = false, $dontcache = false) {
+ $a = get_app();
+
// If it is a posting where users should get notifications, then define it as wall posting
if ($notify) {
$arr['wall'] = 1;
$arr['origin'] = 1;
$arr['last-child'] = 1;
$arr['network'] = NETWORK_DFRN;
+
+ // We have to avoid duplicates. So we create the GUID in form of a hash of the plink or uri.
+ // In difference to the call to "uri_to_guid" several lines below we add the hash of our own host.
+ // This is done because our host is the original creator of the post.
+ if (isset($arr['plink'])) {
+ $arr['guid'] = uri_to_guid($arr['plink'], $a->get_hostname());
+ } elseif (isset($arr['uri'])) {
+ $arr['guid'] = uri_to_guid($arr['uri'], $a->get_hostname());
+ }
}
// If a Diaspora signature structure was passed in, pull it out of the
$arr['wall'] = ((x($arr,'wall')) ? intval($arr['wall']) : 0);
$arr['guid'] = ((x($arr,'guid')) ? notags(trim($arr['guid'])) : get_guid(32, $guid_prefix));
- $arr['uri'] = ((x($arr,'uri')) ? notags(trim($arr['uri'])) : $arr['guid']);
+ $arr['uri'] = ((x($arr,'uri')) ? notags(trim($arr['uri'])) : item_new_uri($a->get_hostname(), $uid, $arr['guid']));
$arr['extid'] = ((x($arr,'extid')) ? notags(trim($arr['extid'])) : '');
$arr['author-name'] = ((x($arr,'author-name')) ? trim($arr['author-name']) : '');
$arr['author-link'] = ((x($arr,'author-link')) ? notags(trim($arr['author-link'])) : '');
$arr['last-child'] = ((x($arr,'last-child')) ? intval($arr['last-child']) : 0 );
$arr['visible'] = ((x($arr,'visible') !== false) ? intval($arr['visible']) : 1 );
$arr['deleted'] = 0;
- $arr['parent-uri'] = ((x($arr,'parent-uri')) ? notags(trim($arr['parent-uri'])) : '');
+ $arr['parent-uri'] = ((x($arr,'parent-uri')) ? notags(trim($arr['parent-uri'])) : $arr['uri']);
$arr['verb'] = ((x($arr,'verb')) ? notags(trim($arr['verb'])) : '');
$arr['object-type'] = ((x($arr,'object-type')) ? notags(trim($arr['object-type'])) : '');
$arr['object'] = ((x($arr,'object')) ? trim($arr['object']) : '');
if ($arr["uid"] == 0) {
$arr["global"] = true;
+ // Set the global flag on all items if this was a global item entry
q("UPDATE `item` SET `global` = 1 WHERE `uri` = '%s'", dbesc($arr["uri"]));
} else {
$isglobal = q("SELECT `global` FROM `item` WHERE `uid` = 0 AND `uri` = '%s'", dbesc($arr["uri"]));
return 0;
}
+ // Check for already added items.
+ // There is a timing issue here that sometimes creates double postings.
+ // An unique index would help - but the limitations of MySQL (maximum size of index values) prevent this.
+ if ($arr["uid"] == 0) {
+ $r = qu("SELECT `id` FROM `item` WHERE `uri` = '%s' AND `uid` = 0 LIMIT 1", dbesc(trim($arr['uri'])));
+ if (dbm::is_result($r)) {
+ logger('Global item already stored. URI: '.$arr['uri'].' on network '.$arr['network'], LOGGER_DEBUG);
+ return 0;
+ }
+ }
+
// Store the unescaped version
$unescaped = $arr;
. implode("`, `", array_keys($arr))
. "`) VALUES ('"
. implode("', '", array_values($arr))
- . "')" );
+ . "')");
// And restore it
$arr = $unescaped;
- // find the item that we just created
- $r = q("SELECT `id` FROM `item` WHERE `uri` = '%s' AND `uid` = %d AND `network` = '%s' ORDER BY `id` ASC",
+ // When the item was successfully stored we fetch the ID of the item.
+ if (dbm::is_result($r)) {
+ $r = q("SELECT LAST_INSERT_ID() AS `item-id`");
+ if (dbm::is_result($r)) {
+ $current_post = $r[0]['item-id'];
+ } else {
+ // This shouldn't happen
+ $current_post = 0;
+ }
+ } else {
+ // This can happen - for example - if there are locking timeouts.
+ logger("Item wasn't stored - we quit here.");
+ q("COMMIT");
+ return 0;
+ }
+
+ if ($current_post == 0) {
+ // This is one of these error messages that never should occur.
+ logger("couldn't find created item - we better quit now.");
+ q("COMMIT");
+ return 0;
+ }
+
+ // How much entries have we created?
+ // We wouldn't need this query when we could use an unique index - but MySQL has length problems with them.
+ $r = q("SELECT COUNT(*) AS `entries` FROM `item` WHERE `uri` = '%s' AND `uid` = %d AND `network` = '%s'",
dbesc($arr['uri']),
intval($arr['uid']),
dbesc($arr['network'])
);
- if (count($r) > 1) {
- // There are duplicates. Keep the oldest one, delete the others
- logger('item_store: duplicated post occurred. Removing newer duplicates. uri = '.$arr['uri'].' uid = '.$arr['uid']);
- q("DELETE FROM `item` WHERE `uri` = '%s' AND `uid` = %d AND `network` = '%s' AND `id` > %d",
- dbesc($arr['uri']),
- intval($arr['uid']),
- dbesc($arr['network']),
- intval($r[0]["id"])
- );
+ if (!dbm::is_result($r)) {
+ // This shouldn't happen, since COUNT always works when the database connection is there.
+ logger("We couldn't count the stored entries. Very strange ...");
q("COMMIT");
return 0;
- } elseif (count($r)) {
+ }
- $current_post = $r[0]['id'];
- logger('item_store: created item ' . $current_post);
+ if ($r[0]["entries"] > 1) {
+ // There are duplicates. We delete our just created entry.
+ logger('Duplicated post occurred. uri = '.$arr['uri'].' uid = '.$arr['uid']);
- item_set_last_item($arr);
- } else {
- logger('item_store: could not locate created item');
+ // Yes, we could do a rollback here - but we are having many users with MyISAM.
+ q("DELETE FROM `item` WHERE `id` = %d", intval($current_post));
+ q("COMMIT");
+ return 0;
+ } elseif ($r[0]["entries"] == 0) {
+ // This really should never happen since we quit earlier if there were problems.
+ logger("Something is terribly wrong. We haven't found our created entry.");
q("COMMIT");
return 0;
}
+ logger('item_store: created item '.$current_post);
+ item_set_last_item($arr);
+
if (!$parent_id || ($arr['parent-uri'] === $arr['uri']))
$parent_id = $current_post;
);
}
-
- /**
- * If this is now the last-child, force all _other_ children of this parent to *not* be last-child
- */
-
- if ($arr['last-child']) {
- $r = q("UPDATE `item` SET `last-child` = 0 WHERE `parent-uri` = '%s' AND `uid` = %d AND `id` != %d",
- dbesc($arr['uri']),
- intval($arr['uid']),
- intval($current_post)
- );
- }
-
$deleted = tag_deliver($arr['uid'],$current_post);
// current post can be deleted if is for a community page and no mention are
logger('item_store: new item not found in DB, id ' . $current_post);
}
+ if ($arr['parent-uri'] === $arr['uri']) {
+ add_thread($current_post);
+ } else {
+ update_thread($parent_id);
+ }
+
+ q("COMMIT");
+
+ // Due to deadlock issues with the "term" table we are doing these steps after the commit.
+ // This is not perfect - but a workable solution until we found the reason for the problem.
create_tags_from_item($current_post);
create_files_from_item($current_post);
- // Only check for notifications on start posts
- if ($arr['parent-uri'] === $arr['uri']) {
- add_thread($current_post);
- q("COMMIT");
+ // If this is now the last-child, force all _other_ children of this parent to *not* be last-child
+ // It is done after the transaction to avoid dead locks.
+ if ($arr['last-child']) {
+ $r = q("UPDATE `item` SET `last-child` = 0 WHERE `parent-uri` = '%s' AND `uid` = %d AND `id` != %d",
+ dbesc($arr['uri']),
+ intval($arr['uid']),
+ intval($current_post)
+ );
+ }
+ if ($arr['parent-uri'] === $arr['uri']) {
add_shadow_thread($current_post);
} else {
- update_thread($parent_id);
- q("COMMIT");
-
- add_shadow_entry($arr);
+ add_shadow_entry($current_post);
}
check_item_notification($current_post, $uid);
$owner = $item['uid'];
- $cid = 0;
+ $contact_id = 0;
// check if logged in user is either the author or owner of this item
if (is_array($_SESSION['remote'])) {
foreach($_SESSION['remote'] as $visitor) {
if ($visitor['uid'] == $item['uid'] && $visitor['cid'] == $item['contact-id']) {
- $cid = $visitor['cid'];
+ $contact_id = $visitor['cid'];
break;
}
}
}
- if ((local_user() == $item['uid']) || ($cid) || (! $interactive)) {
+ if ((local_user() == $item['uid']) || ($contact_id) || (! $interactive)) {
// Check if we should do HTML-based delete confirmation
if ($_REQUEST['confirm']) {