]> git.mxchange.org Git - friendica.git/blobdiff - include/notifier.php
Merge branch 'master' into notify
[friendica.git] / include / notifier.php
index 9c194d962cfbbc5e419d94a354a7f391612244c0..2562f09eb05bb53f64187268a54d3ba1c72afe86 100644 (file)
@@ -1,5 +1,21 @@
 <?php
+
 require_once("boot.php");
+require_once('include/queue_fn.php');
+
+/*
+ * This file was at one time responsible for doing all deliveries, but this caused
+ * big problems on shared hosting systems, where the process might get killed by the 
+ * hosting provider and nothing would get delivered. 
+ * It now only delivers one message under certain cases, and invokes a queued
+ * delivery mechanism (include/deliver.php) to deliver individual contacts at 
+ * controlled intervals.
+ * This has a much better chance of surviving random processes getting killed
+ * by the hosting provider. 
+ * A lot of this code is duplicated in include/deliver.php until we have time to go back
+ * and re-structure the delivery procedure based on the obstacles that have been thrown at 
+ * us by hosting providers. 
+ */
 
 function notifier_run($argv, $argc){
        global $a, $db;
@@ -35,7 +51,6 @@ function notifier_run($argv, $argc){
        $cmd = $argv[1];
 
        switch($cmd) {
-
                case 'mail':
                default:
                        $item_id = intval($argv[2]);
@@ -46,12 +61,17 @@ function notifier_run($argv, $argc){
        }
 
        $expire = false;
+       $mail = false;
+       $fsuggest = false;
        $top_level = false;
        $recipients = array();
        $url_recipients = array();
 
-       if($cmd === 'mail') {
+       $normal_mode = true;
 
+       if($cmd === 'mail') {
+               $normal_mode = false;
+               $mail = true;
                $message = q("SELECT * FROM `mail` WHERE `id` = %d LIMIT 1",
                                intval($item_id)
                );
@@ -64,9 +84,10 @@ function notifier_run($argv, $argc){
 
        }
        elseif($cmd === 'expire') {
+               $normal_mode = false;
                $expire = true;
                $items = q("SELECT * FROM `item` WHERE `uid` = %d AND `wall` = 1 
-                       AND `deleted` = 1 AND `changed` > UTC_TIMESTAMP - INTERVAL 10 MINUTE",
+                       AND `deleted` = 1 AND `changed` > UTC_TIMESTAMP() - INTERVAL 10 MINUTE",
                        intval($item_id)
                );
                $uid = $item_id;
@@ -75,6 +96,9 @@ function notifier_run($argv, $argc){
                        return;
        }
        elseif($cmd === 'suggest') {
+               $normal_mode = false;
+               $fsuggest = true;
+
                $suggest = q("SELECT * FROM `fsuggest` WHERE `id` = %d LIMIT 1",
                        intval($item_id)
                );
@@ -95,12 +119,16 @@ function notifier_run($argv, $argc){
                        return;
                }
 
-               $parent_item = $r[0];
+               $target_item = $r[0];
                $parent_id = intval($r[0]['parent']);
                $uid = $r[0]['uid'];
                $updated = $r[0]['edited'];
 
-               $items = q("SELECT * FROM `item` WHERE `parent` = %d ORDER BY `id` ASC",
+               if(! $parent_id)
+                       return;
+
+               $items = q("SELECT `item`.*, `sign`.`signed_text`,`sign`.`signature`,`sign`.`signer` 
+                       FROM `item` LEFT JOIN `sign` ON `sign`.`iid` = `item`.`id` WHERE `parent` = %d ORDER BY `id` ASC",
                        intval($parent_id)
                );
 
@@ -115,11 +143,15 @@ function notifier_run($argv, $argc){
                                $item['deleted'] = 1;
                }
 
-               if(count($items) == 1 && $items[0]['uri'] === $items[0]['parent-uri'])
+               if((count($items) == 1) && ($items[0]['id'] === $target_item['id']) && ($items[0]['uri'] === $items[0]['parent-uri'])) {
+                       logger('notifier: top level post');
                        $top_level = true;
+               }
+
        }
 
-       $r = q("SELECT `contact`.*, `user`.`timezone`, `user`.`nickname`, `user`.`sprvkey`, `user`.`spubkey`, 
+       $r = q("SELECT `contact`.*, `user`.`pubkey` AS `upubkey`, `user`.`prvkey` AS `uprvkey`, 
+               `user`.`timezone`, `user`.`nickname`, `user`.`sprvkey`, `user`.`spubkey`, 
                `user`.`page-flags`, `user`.`prvnets`
                FROM `contact` LEFT JOIN `user` ON `user`.`uid` = `contact`.`uid` 
                WHERE `contact`.`uid` = %d AND `contact`.`self` = 1 LIMIT 1",
@@ -131,34 +163,100 @@ function notifier_run($argv, $argc){
 
        $owner = $r[0];
 
+       $walltowall = ((($top_level) && ($owner['id'] != $items[0]['contact-id'])) ? true : false);
+
        $hub = get_config('system','huburl');
 
        // If this is a public conversation, notify the feed hub
-       $notify_hub = true;
+       $public_message = true;
 
        // fill this in with a single salmon slap if applicable
        $slap = '';
 
-       if($cmd != 'mail' && $cmd != 'suggest') {
+       if(! ($mail || $fsuggest)) {
 
                require_once('include/group.php');
 
                $parent = $items[0];
 
-               if($parent['type'] === 'remote' && (! $expire)) {
+               // This is IMPORTANT!!!!
+
+               // We will only send a "notify owner to relay" or followup message if the referenced post
+               // originated on our system by virtue of having our hostname somewhere
+               // in the URI, AND it was a comment (not top_level) AND the parent originated elsewhere.
+
+               // if $parent['wall'] == 1 we will already have the parent message in our array
+               // and we will relay the whole lot.
+               // expire sends an entire group of expire messages and cannot be forwarded.
+               // However the conversation owner will be a part of the conversation and will 
+               // be notified during this run.
+               // Other DFRN conversation members will be alerted during polled updates.
+
+
+
+               // Diaspora members currently are not notified of expirations, and other networks have
+               // either limited or no ability to process deletions. We should at least fix Diaspora 
+               // by stringing togther an array of retractions and sending them onward.
+                
+       
+               $localhost = $a->get_hostname();
+               if(strpos($localhost,':'))
+                       $localhost = substr($localhost,0,strpos($localhost,':'));
+
+               /**
+                *
+                * Be VERY CAREFUL if you make any changes to the following several lines. Seemingly innocuous changes 
+                * have been known to cause runaway conditions which affected several servers, along with 
+                * permissions issues. 
+                *
+                */
+               $relay_to_owner = false;
+
+               if((! $top_level) && ($parent['wall'] == 0) && (! $expire) && (stristr($target_item['uri'],$localhost))) {
+                       $relay_to_owner = true;
+               }
+
+
+               if(($cmd === 'uplink') && (intval($parent['forum_mode'])) && (! $top_level)) {
+                       $relay_to_owner = true;                 
+               } 
+
+               // until the 'origin' flag has been in use for several months
+               // we will just use it as a fallback test
+               // later we will be able to use it as the primary test of whether or not to relay.
+
+               if(! $target_item['origin'])
+                       $relay_to_owner = false;
+
+               if($parent['origin'])
+                       $relay_to_owner = false;
+
+
+
+               if($relay_to_owner) {
+                       logger('notifier: followup', LOGGER_DEBUG);
                        // local followup to remote post
                        $followup = true;
-                       $notify_hub = false; // not public
+                       $public_message = false; // not public
                        $conversant_str = dbesc($parent['contact-id']);
                }
                else {
                        $followup = false;
 
+                       // don't send deletions onward for other people's stuff
+
+                       if($target_item['deleted'] && (! intval($target_item['wall']))) {
+                               logger('notifier: ignoring delete notification for non-wall item');
+                               return;
+                       }
+
                        if((strlen($parent['allow_cid'])) 
                                || (strlen($parent['allow_gid'])) 
                                || (strlen($parent['deny_cid'])) 
                                || (strlen($parent['deny_gid']))) {
-                               $notify_hub = false; // private recipients, not public
+                               $public_message = false; // private recipients, not public
                        }
 
                        $allow_people = expand_acl($parent['allow_cid']);
@@ -166,13 +264,20 @@ function notifier_run($argv, $argc){
                        $deny_people  = expand_acl($parent['deny_cid']);
                        $deny_groups  = expand_groups(expand_acl($parent['deny_gid']));
 
+                       // if our parent is a forum, uplink to the origonal author causing
+                       // a delivery fork
+
+                       if(intval($parent['forum_mode']) && (! $top_level) && ($cmd !== 'uplink')) {
+                               proc_run('php','include/notifier','uplink',$item_id);
+                       }
+
                        $conversants = array();
 
                        foreach($items as $item) {
                                $recipients[] = $item['contact-id'];
                                $conversants[] = $item['contact-id'];
                                // pull out additional tagged people to notify (if public message)
-                               if($notify_hub && strlen($item['inform'])) {
+                               if($public_message && strlen($item['inform'])) {
                                        $people = explode(',',$item['inform']);
                                        foreach($people as $person) {
                                                if(substr($person,0,4) === 'cid:') {
@@ -200,7 +305,6 @@ function notifier_run($argv, $argc){
 
                $r = q("SELECT * FROM `contact` WHERE `id` IN ( $conversant_str ) AND `blocked` = 0 AND `pending` = 0");
 
-
                if(count($r))
                        $contacts = $r;
        }
@@ -219,7 +323,7 @@ function notifier_run($argv, $argc){
                $birthday = '<dfrn:birthday>' . xmlify($birthday) . '</dfrn:birthday>';
 
        $atom .= replace_macros($feed_template, array(
-                       '$version'      => xmlify(FRIENDIKA_VERSION),
+                       '$version'      => xmlify(FRIENDICA_VERSION),
                        '$feed_id'      => xmlify($a->get_baseurl() . '/profile/' . $owner['nickname'] ),
                        '$feed_title'   => xmlify($owner['name']),
                        '$feed_updated' => xmlify(datetime_convert('UTC', 'UTC', $updated . '+00:00' , ATOM_TIME)) ,
@@ -235,8 +339,8 @@ function notifier_run($argv, $argc){
                        '$birthday'     => $birthday
        ));
 
-       if($cmd === 'mail') {
-               $notify_hub = false;  // mail is  not public
+       if($mail) {
+               $public_message = false;  // mail is  not public
 
                $body = fix_private_photos($item['body'],$owner['uid']);
 
@@ -251,8 +355,8 @@ function notifier_run($argv, $argc){
                        '$parent_id'    => xmlify($item['parent-uri'])
                ));
        }
-       elseif($cmd === 'suggest') {
-               $notify_hub = false;  // suggestions are not public
+       elseif($fsuggest) {
+               $public_message = false;  // suggestions are not public
 
                $sugg_template = get_markup_template('atom_suggest.tpl');
 
@@ -289,13 +393,29 @@ function notifier_run($argv, $argc){
                                if(! $item['parent'])
                                        continue;
 
+                               // private emails may be in included in public conversations. Filter them.
+
+                               if(($public_message) && $item['private'])
+                                       continue;
+
+
                                $contact = get_item_contact($item,$contacts);
+
                                if(! $contact)
                                        continue;
 
-                               $atom .= atom_entry($item,'text',$contact,$owner,true);
+                               if($normal_mode) {
+
+                                       // we only need the current item, but include the parent because without it
+                                       // older sites without a corresponding dfrn_notify change may do the wrong thing.
 
-                               if(($top_level) && ($notify_hub) && ($item['author-link'] === $item['owner-link']) && (! $expire)) 
+                                   if($item_id == $item['id'] || $item['id'] == $item['parent'])
+                                               $atom .= atom_entry($item,'text',$contact,$owner,true);
+                               }
+                               else
+                                       $atom .= atom_entry($item,'text',$contact,$owner,true);
+
+                               if(($top_level) && ($public_message) && ($item['author-link'] === $item['owner-link']) && (! $expire)) 
                                        $slaps[] = atom_entry($item,'html',$contact,$owner,true);
                        }
                }
@@ -311,9 +431,9 @@ function notifier_run($argv, $argc){
        $mail_disabled = ((function_exists('imap_open') && (! get_config('system','imap_disabled'))) ? 0 : 1);
 
        if(! $mail_disabled) {
-               if((! strlen($parent_item['allow_cid'])) && (! strlen($parent_item['allow_gid'])) 
-                       && (! strlen($parent_item['deny_cid'])) && (! strlen($parent_item['deny_gid'])) 
-                       && (intval($parent_item['pubmail']))) {
+               if((! strlen($target_item['allow_cid'])) && (! strlen($target_item['allow_gid'])) 
+                       && (! strlen($target_item['deny_cid'])) && (! strlen($target_item['deny_gid'])) 
+                       && (intval($target_item['pubmail']))) {
                        $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `network` = '%s'",
                                intval($uid),
                                dbesc(NETWORK_MAIL)
@@ -334,19 +454,87 @@ function notifier_run($argv, $argc){
                dbesc($recip_str)
        );
 
-       // delivery loop
 
        require_once('include/salmon.php');
 
+       $interval = ((get_config('system','delivery_interval') === false) ? 2 : intval(get_config('system','delivery_interval')));
+
+       // delivery loop
+
        if(count($r)) {
+
+               foreach($r as $contact) {
+                       if((! $mail) && (! $fsuggest) && (! $followup) && (! $contact['self'])) {
+                               if(($contact['network'] === NETWORK_DIASPORA) && ($public_message))
+                                       continue;
+                               q("insert into deliverq ( `cmd`,`item`,`contact` ) values ('%s', %d, %d )",
+                                       dbesc($cmd),
+                                       intval($item_id),
+                                       intval($contact['id'])
+                               );
+                       }
+               }
+
                foreach($r as $contact) {
                        if($contact['self'])
                                continue;
 
+                       // potentially more than one recipient. Start a new process and space them out a bit.
+                       // we will deliver single recipient types of message and email receipients here. 
+
+                       if((! $mail) && (! $fsuggest) && (! $followup)) {
+                               proc_run('php','include/delivery.php',$cmd,$item_id,$contact['id']);
+                               if($interval)
+                                       @time_sleep_until(microtime(true) + (float) $interval);
+                               continue;
+                       }
+
                        $deliver_status = 0;
 
+                       logger("main delivery by notifier: followup=$followup mail=$mail fsuggest=$fsuggest");
+
                        switch($contact['network']) {
-                               case 'dfrn':
+                               case NETWORK_DFRN:
+
+                                       // perform local delivery if we are on the same site
+
+                                       $basepath =  implode('/', array_slice(explode('/',$contact['url']),0,3));
+
+                                       if(link_compare($basepath,$a->get_baseurl())) {
+
+                                               $nickname = basename($contact['url']);
+                                               if($contact['issued-id'])
+                                                       $sql_extra = sprintf(" AND `dfrn-id` = '%s' ", dbesc($contact['issued-id']));
+                                               else
+                                                       $sql_extra = sprintf(" AND `issued-id` = '%s' ", dbesc($contact['dfrn-id']));
+
+                                               $x = q("SELECT  `contact`.*, `contact`.`uid` AS `importer_uid`, 
+                                                       `contact`.`pubkey` AS `cpubkey`, 
+                                                       `contact`.`prvkey` AS `cprvkey`, 
+                                                       `contact`.`thumb` AS `thumb`, 
+                                                       `contact`.`url` as `url`,
+                                                       `contact`.`name` as `senderName`,
+                                                       `user`.* 
+                                                       FROM `contact` 
+                                                       LEFT JOIN `user` ON `contact`.`uid` = `user`.`uid` 
+                                                       WHERE `contact`.`blocked` = 0 AND `contact`.`pending` = 0
+                                                       AND `contact`.`network` = '%s' AND `user`.`nickname` = '%s'
+                                                       $sql_extra
+                                                       AND `user`.`account_expired` = 0 LIMIT 1",
+                                                       dbesc(NETWORK_DFRN),
+                                                       dbesc($nickname)
+                                               );
+
+                                               if(count($x)) {
+                                                       require_once('library/simplepie/simplepie.inc');
+                                                       logger('mod-delivery: local delivery');
+                                                       local_delivery($x[0],$atom);
+                                                       break;                                  
+                                               }
+                                       }
+
+
+
                                        logger('notifier: dfrndelivery: ' . $contact['name']);
                                        $deliver_status = dfrn_deliver($owner,$contact,$atom);
 
@@ -355,55 +543,39 @@ function notifier_run($argv, $argc){
                                        if($deliver_status == (-1)) {
                                                logger('notifier: delivery failed: queuing message');
                                                // queue message for redelivery
-                                               q("INSERT INTO `queue` ( `cid`, `created`, `last`, `content`)
-                                                       VALUES ( %d, '%s', '%s', '%s') ",
-                                                       intval($contact['id']),
-                                                       dbesc(datetime_convert()),
-                                                       dbesc(datetime_convert()),
-                                                       dbesc($atom)
-                                               );
+                                               add_to_queue($contact['id'],NETWORK_DFRN,$atom);
                                        }
                                        break;
-                               case 'stat':
+                               case NETWORK_OSTATUS:
+
+                                       // Do not send to otatus if we are not configured to send to public networks
                                        if($owner['prvnets'])
                                                break;
+                                       if(get_config('system','ostatus_disabled') || get_config('system','dfrn_only'))
+                                               break;
+
                                        if($followup && $contact['notify']) {
                                                logger('notifier: slapdelivery: ' . $contact['name']);
                                                $deliver_status = slapper($owner,$contact['notify'],$slap);
 
                                                if($deliver_status == (-1)) {
                                                        // queue message for redelivery
-                                                       q("INSERT INTO `queue` ( `cid`, `created`, `last`, `content`)
-                                                               VALUES ( %d, '%s', '%s', '%s') ",
-                                                               intval($contact['id']),
-                                                               dbesc(datetime_convert()),
-                                                               dbesc(datetime_convert()),
-                                                               dbesc($slap)
-                                                       );
-
+                                                       add_to_queue($contact['id'],NETWORK_OSTATUS,$slap);
                                                }
-       
-
                                        }
                                        else {
 
                                                // only send salmon if public - e.g. if it's ok to notify
                                                // a public hub, it's ok to send a salmon
 
-                                               if((count($slaps)) && ($notify_hub) && (! $expire)) {
+                                               if((count($slaps)) && ($public_message) && (! $expire)) {
                                                        logger('notifier: slapdelivery: ' . $contact['name']);
                                                        foreach($slaps as $slappy) {
                                                                if($contact['notify']) {
                                                                        $deliver_status = slapper($owner,$contact['notify'],$slappy);
                                                                        if($deliver_status == (-1)) {
                                                                                // queue message for redelivery
-                                                                               q("INSERT INTO `queue` ( `cid`, `created`, `last`, `content`)
-                                                                                       VALUES ( %d, '%s', '%s', '%s') ",
-                                                                                       intval($contact['id']),
-                                                                                       dbesc(datetime_convert()),
-                                                                                       dbesc(datetime_convert()),
-                                                                                       dbesc($slappy)
-                                                                               );                                                              
+                                                                               add_to_queue($contact['id'],NETWORK_OSTATUS,$slappy);
                                                                        }
                                                                }
                                                        }
@@ -411,8 +583,11 @@ function notifier_run($argv, $argc){
                                        }
                                        break;
 
-                               case 'mail':
+                               case NETWORK_MAIL:
                                                
+                                       if(get_config('system','dfrn_only'))
+                                               break;
+
                                        // WARNING: does not currently convert to RFC2047 header encodings, etc.
 
                                        $addr = $contact['addr'];
@@ -485,9 +660,63 @@ function notifier_run($argv, $argc){
                                                mail($addr, $subject, $message, $headers);
                                        }
                                        break;
-                               case 'feed':
-                               case 'face':
-                               case 'dspr':
+                               case NETWORK_DIASPORA:
+                                       require_once('include/diaspora.php');
+
+                                       if(get_config('system','dfrn_only') || (! get_config('system','diaspora_enabled')))
+                                               break;
+
+                                       if($mail) {
+                                               diaspora_send_mail($item,$owner,$contact);
+                                               break;
+                                       }
+
+                                       if(! $normal_mode)
+                                               break;
+
+                                       // special handling for followup to public post
+                                       // all other public posts processed as public batches further below
+
+                                       if($public_message) {
+                                               if($followup)
+                                                       diaspora_send_followup($target_item,$owner,$contact, true);
+                                               break;
+                                       }
+
+                                       if(! $contact['pubkey'])
+                                               break;
+                                       
+                                       if($target_item['verb'] === ACTIVITY_DISLIKE) {
+                                               // unsupported
+                                               break;
+                                       }
+                                       elseif(($target_item['deleted']) && ($target_item['verb'] !== ACTIVITY_LIKE)) {
+                                               // diaspora delete, 
+                                               diaspora_send_retraction($target_item,$owner,$contact);
+                                               break;
+                                       }
+                                       elseif($followup) {
+                                               // send comments, likes and retractions of likes to owner to relay
+                                               diaspora_send_followup($target_item,$owner,$contact);
+                                               break;
+                                       }
+                                       elseif($target_item['parent'] != $target_item['id']) {
+                                               // we are the relay - send comments, likes and unlikes to our conversants
+                                               diaspora_send_relay($target_item,$owner,$contact);
+                                               break;
+                                       }               
+                                       elseif(($top_level) && (! $walltowall)) {
+                                               // currently no workable solution for sending walltowall
+                                               diaspora_send_status($target_item,$owner,$contact);
+                                               break;
+                                       }
+
+                                       break;
+
+                               case NETWORK_FEED:
+                               case NETWORK_FACEBOOK:
+                                       if(get_config('system','dfrn_only'))
+                                               break;
                                default:
                                        break;
                        }
@@ -496,88 +725,100 @@ function notifier_run($argv, $argc){
                
        // send additional slaps to mentioned remote tags (@foo@example.com)
 
-       if($slap && count($url_recipients) && $followup && $notify_hub && (! $expire)) {
-               foreach($url_recipients as $url) {
-                       if($url) {
-                               logger('notifier: urldelivery: ' . $url);
-                               $deliver_status = slapper($owner,$url,$slap);
-                               // TODO: redeliver/queue these items on failure, though there is no contact record
-                       }
-               }
-       }
-
-       if((strlen($hub)) && ($notify_hub)) {
-               $hubs = explode(',', $hub);
-               if(count($hubs)) {
-                       foreach($hubs as $h) {
-                               $h = trim($h);
-                               if(! strlen($h))
-                                       continue;
-                               $params = 'hub.mode=publish&hub.url=' . urlencode($a->get_baseurl() . '/dfrn_poll/' . $owner['nickname'] );
-                               post_url($h,$params);
-                               logger('pubsub: publish: ' . $h . ' ' . $params . ' returned ' . $a->get_curl_code());
-                               if(count($hubs) > 1)
-                                       sleep(7);                               // try and avoid multiple hubs responding at precisely the same time
+       if($slap && count($url_recipients) && ($followup || $top_level) && $public_message && (! $expire)) {
+               if(! get_config('system','dfrn_only')) {
+                       foreach($url_recipients as $url) {
+                               if($url) {
+                                       logger('notifier: urldelivery: ' . $url);
+                                       $deliver_status = slapper($owner,$url,$slap);
+                                       // TODO: redeliver/queue these items on failure, though there is no contact record
+                               }
                        }
                }
        }
 
-       if($notify_hub) {
-
-               /**
-                *
-                * If you have less than 150 dfrn friends and it's a public message,
-                * we'll just go ahead and push them out securely with dfrn/rino.
-                * If you've got more than that, you'll have to rely on PuSH delivery.
-                *
-                */
 
-               $max_allowed = ((get_config('system','maxpubdeliver') === false) ? 150 : intval(get_config('system','maxpubdeliver')));
-                               
-               /**
-                *
-                * Only get the bare essentials and go back for the full record. 
-                * If you've got a lot of friends and we grab all the details at once it could exhaust memory. 
-                *
-                */
+       if($public_message) {
 
-               $r = q("SELECT `id`, `name` FROM `contact` 
-                       WHERE `network` = 'dfrn' AND `uid` = %d AND `blocked` = 0 AND `pending` = 0
-                       AND `rel` != %d ",
+               $r1 = q("SELECT DISTINCT(`batch`), `id`, `name`,`network` FROM `contact` WHERE `network` = '%s' 
+                       AND `uid` = %d AND `rel` != %d group by `batch` ORDER BY rand() ",
+                       dbesc(NETWORK_DIASPORA),
                        intval($owner['uid']),
-                       intval(REL_FAN)
+                       intval(CONTACT_IS_SHARING)
                );
+                       
+               $r2 = q("SELECT `id`, `name`,`network` FROM `contact` 
+                       WHERE `network` = '%s' AND `uid` = %d AND `blocked` = 0 AND `pending` = 0
+                       AND `rel` != %d order by rand() ",
+                       dbesc(NETWORK_DFRN),
+                       intval($owner['uid']),
+                       intval(CONTACT_IS_SHARING)
+               );
+
+               $r = array_merge($r2,$r1);
+
+               if(count($r)) {
+                       logger('pubdeliver: ' . print_r($r,true), LOGGER_DEBUG);
 
-               if((count($r)) && (($max_allowed == 0) || (count($r) < $max_allowed))) {
+                       // throw everything into the queue in case we get killed
 
-                       logger('pubdeliver: ' . print_r($r,true));
+                       foreach($r as $rr) {
+                               if((! $mail) && (! $fsuggest) && (! $followup)) {
+                                       q("insert into deliverq ( `cmd`,`item`,`contact` ) values ('%s', %d, %d )",
+                                               dbesc($cmd),
+                                               intval($item_id),
+                                               intval($rr['id'])
+                                       );
+                               }
+                       }
 
                        foreach($r as $rr) {
 
-                               /* Don't deliver to folks who have already been delivered to */
+                               // except for Diaspora batch jobs
+                               // Don't deliver to folks who have already been delivered to
 
-                               if(! in_array($rr['id'], $conversants)) {
-                                       $n = q("SELECT * FROM `contact` WHERE `id` = %d LIMIT 1",
-                                                       intval($rr['id'])
-                                       );
+                               if(($rr['network'] !== NETWORK_DIASPORA) && (in_array($rr['id'],$conversants))) {
+                                       logger('notifier: already delivered id=' . $rr['id']);
+                                       continue;
+                               }
 
-                                       if(count($n)) {
-                                       
-                                               logger('notifier: dfrnpubdelivery: ' . $n[0]['name']);
-                                               $deliver_status = dfrn_deliver($owner,$n[0],$atom);
-                                       }
+                               if((! $mail) && (! $fsuggest) && (! $followup)) {
+                                       logger('notifier: delivery agent: ' . $rr['name'] . ' ' . $rr['id']); 
+                                       proc_run('php','include/delivery.php',$cmd,$item_id,$rr['id']);
+                                       if($interval)
+                                               @time_sleep_until(microtime(true) + (float) $interval);
                                }
-                               else
-                                       logger('notifier: dfrnpubdelivery: ignoring ' . $rr['name']);
                        }
                }
+
+
+               if(strlen($hub)) {
+                       $hubs = explode(',', $hub);
+                       if(count($hubs)) {
+                               foreach($hubs as $h) {
+                                       $h = trim($h);
+                                       if(! strlen($h))
+                                               continue;
+                                       $params = 'hub.mode=publish&hub.url=' . urlencode($a->get_baseurl() . '/dfrn_poll/' . $owner['nickname'] );
+                                       post_url($h,$params);
+                                       logger('pubsub: publish: ' . $h . ' ' . $params . ' returned ' . $a->get_curl_code());
+                                       if(count($hubs) > 1)
+                                               sleep(7);                               // try and avoid multiple hubs responding at precisely the same time
+                               }
+                       }
+               }
+
        }
 
+       if($normal_mode)
+               call_hooks('notifier_normal',$target_item);
+
+       call_hooks('notifier_end',$target_item);
+
        return;
 }
 
 if (array_search(__file__,get_included_files())===0){
-  echo "run!";
   notifier_run($argv,$argc);
   killme();
 }