]> git.mxchange.org Git - friendica.git/blobdiff - include/notifier.php
Merge pull request #3034 from annando/1612-no-archive
[friendica.git] / include / notifier.php
index 4adb159f758aff1404859494768e31cb87acd737..7221fa376db154eba4656d2e4f1049cade18ab36 100644 (file)
@@ -5,25 +5,18 @@ require_once('include/html2plain.php');
 require_once("include/Scrape.php");
 require_once('include/diaspora.php');
 require_once("include/ostatus.php");
+require_once('include/salmon.php');
 
 /*
  * This file was at one time responsible for doing all deliveries, but this caused
- * big problems on shared hosting systems, where the process might get killed by the
- * hosting provider and nothing would get delivered.
- * It now only delivers one message under certain cases, and invokes a queued
- * delivery mechanism (include/deliver.php) to deliver individual contacts at
- * controlled intervals.
- * This has a much better chance of surviving random processes getting killed
- * by the hosting provider.
- * A lot of this code is duplicated in include/deliver.php until we have time to go back
- * and re-structure the delivery procedure based on the obstacles that have been thrown at
- * us by hosting providers.
+ * big problems when the process was killed or stalled during the delivery process.
+ * It now invokes separate queues that are delivering via delivery.php and pubsubpublish.php.
  */
 
 /*
  * The notifier is typically called with:
  *
- *             proc_run('php', "include/notifier.php", COMMAND, ITEM_ID);
+ *             proc_run(PRIORITY_HIGH, "include/notifier.php", COMMAND, ITEM_ID);
  *
  * where COMMAND is one of the following:
  *
@@ -139,18 +132,25 @@ function notifier_run(&$argv, &$argc){
                $recipients[] = $suggest[0]['cid'];
                $item = $suggest[0];
        } elseif($cmd === 'removeme') {
-               $r = q("SELECT * FROM `user` WHERE `uid` = %d LIMIT 1", intval($item_id));
-               if (! $r)
+               $r = q("SELECT `contact`.*, `user`.`pubkey` AS `upubkey`, `user`.`prvkey` AS `uprvkey`,
+                               `user`.`timezone`, `user`.`nickname`, `user`.`sprvkey`, `user`.`spubkey`,
+                               `user`.`page-flags`, `user`.`prvnets`, `user`.`account-type`, `user`.`guid`
+                       FROM `contact` INNER JOIN `user` ON `user`.`uid` = `contact`.`uid`
+                               WHERE `contact`.`uid` = %d AND `contact`.`self` LIMIT 1",
+                               intval($item_id));
+               if (!$r)
                        return;
 
                $user = $r[0];
-               $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `self` = 1 LIMIT 1", intval($item_id));
-               if (! $r)
+
+               $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `self` LIMIT 1", intval($item_id));
+               if (!$r)
                        return;
 
                $self = $r[0];
-               $r = q("SELECT * FROM `contact` WHERE `self` = 0 AND `uid` = %d", intval($item_id));
-               if(! $r)
+
+               $r = q("SELECT * FROM `contact` WHERE NOT `self` AND `uid` = %d", intval($item_id));
+               if(!$r)
                        return;
 
                require_once('include/Contact.php');
@@ -162,13 +162,15 @@ function notifier_run(&$argv, &$argc){
                $normal_mode = false;
                $relocate = true;
                $uid = $item_id;
+
+               $recipients_relocate = q("SELECT * FROM contact WHERE uid = %d  AND self = 0 AND network = '%s'" , intval($uid), NETWORK_DFRN);
        } else {
                // find ancestors
                $r = q("SELECT * FROM `item` WHERE `id` = %d and visible = 1 and moderated = 0 LIMIT 1",
                        intval($item_id)
                );
 
-               if((! count($r)) || (! intval($r[0]['parent']))) {
+               if((! dbm::is_result($r)) || (! intval($r[0]['parent']))) {
                        return;
                }
 
@@ -177,10 +179,6 @@ function notifier_run(&$argv, &$argc){
                $uid = $r[0]['uid'];
                $updated = $r[0]['edited'];
 
-               // POSSIBLE CLEANUP --> The following seems superfluous. We've already checked for "if (! intval($r[0]['parent']))" a few lines up
-               if(! $parent_id)
-                       return;
-
                $items = q("SELECT `item`.*, `sign`.`signed_text`,`sign`.`signature`,`sign`.`signer`
                        FROM `item` LEFT JOIN `sign` ON `sign`.`iid` = `item`.`id` WHERE `parent` = %d and visible = 1 and moderated = 0 ORDER BY `id` ASC",
                        intval($parent_id)
@@ -206,13 +204,13 @@ function notifier_run(&$argv, &$argc){
 
        $r = q("SELECT `contact`.*, `user`.`pubkey` AS `upubkey`, `user`.`prvkey` AS `uprvkey`,
                `user`.`timezone`, `user`.`nickname`, `user`.`sprvkey`, `user`.`spubkey`,
-               `user`.`page-flags`, `user`.`prvnets`
+               `user`.`page-flags`, `user`.`prvnets`, `user`.`account-type`
                FROM `contact` INNER JOIN `user` ON `user`.`uid` = `contact`.`uid`
                WHERE `contact`.`uid` = %d AND `contact`.`self` = 1 LIMIT 1",
                intval($uid)
        );
 
-       if(! count($r))
+       if(! dbm::is_result($r))
                return;
 
        $owner = $r[0];
@@ -232,11 +230,13 @@ function notifier_run(&$argv, &$argc){
 
        if(! ($mail || $fsuggest || $relocate)) {
 
+               $slap = ostatus::salmon($target_item,$owner);
+
                require_once('include/group.php');
 
                $parent = $items[0];
 
-               $thr_parent = q("SELECT `network` FROM `item` WHERE `uri` = '%s' AND `uid` = %d",
+               $thr_parent = q("SELECT `network`, `author-link`, `owner-link` FROM `item` WHERE `uri` = '%s' AND `uid` = %d",
                        dbesc($target_item["thr-parent"]), intval($target_item["uid"]));
 
                logger('Parent is '.$parent['network'].'. Thread parent is '.$thr_parent[0]['network'], LOGGER_DEBUG);
@@ -276,12 +276,12 @@ function notifier_run(&$argv, &$argc){
 
                $relay_to_owner = false;
 
-               if((! $top_level) && ($parent['wall'] == 0) && (! $expire) && (stristr($target_item['uri'],$localhost))) {
+               if(!$top_level && ($parent['wall'] == 0) && !$expire && (stristr($target_item['uri'],$localhost))) {
                        $relay_to_owner = true;
                }
 
 
-               if(($cmd === 'uplink') && (intval($parent['forum_mode']) == 1) && (! $top_level)) {
+               if(($cmd === 'uplink') && (intval($parent['forum_mode']) == 1) && !$top_level) {
                        $relay_to_owner = true;
                }
 
@@ -302,33 +302,31 @@ function notifier_run(&$argv, &$argc){
                        $public_message = false; // not public
                        $conversant_str = dbesc($parent['contact-id']);
                        $recipients = array($parent['contact-id']);
+                       $recipients_followup  = array($parent['contact-id']);
 
-                       if (!$target_item['private'] AND $target_item['wall'] AND
+                       //if (!$target_item['private'] AND $target_item['wall'] AND
+                       if (!$target_item['private'] AND
                                (strlen($target_item['allow_cid'].$target_item['allow_gid'].
                                        $target_item['deny_cid'].$target_item['deny_gid']) == 0))
                                $push_notify = true;
 
-                       // We notify Friendica users in the thread when it is an OStatus thread.
-                       // Hopefully this transfers the messages to the other Friendica servers. (Untested)
                        if (($thr_parent AND ($thr_parent[0]['network'] == NETWORK_OSTATUS)) OR ($parent['network'] == NETWORK_OSTATUS)) {
 
                                $push_notify = true;
 
                                if ($parent["network"] == NETWORK_OSTATUS) {
-                                       $r = q("SELECT `author-link` FROM `item` WHERE `parent` = %d AND `author-link` != '%s'",
-                                               intval($target_item["parent"]), dbesc($owner['url']));
-                                       foreach($r as $parent_item) {
-                                               $probed_contact = probe_url($parent_item["author-link"]);
-                                               if (($probed_contact["notify"] != "") AND ($probed_contact["network"] == NETWORK_DFRN)) {
-                                                       logger('Notify Friendica user '.$probed_contact["url"].': '.$probed_contact["notify"]);
-                                                       $url_recipients[$probed_contact["notify"]] = $probed_contact["notify"];
-                                               }
-                                       }
+                                       // Distribute the message to the DFRN contacts as if this wasn't a followup since OStatus can't relay comments
+                                       // Currently it is work at progress
+                                       $r = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND `network` = '%s' AND NOT `blocked` AND NOT `pending` AND NOT `archive`",
+                                               intval($uid),
+                                               dbesc(NETWORK_DFRN)
+                                       );
+                                       if (dbm::is_result($r))
+                                               foreach($r as $rr)
+                                                       $recipients_followup[] = $rr['id'];
                                }
-
-                               if (count($url_recipients))
-                                       logger("url_recipients ".print_r($url_recipients,true));
                        }
+                       logger("Notify ".$target_item["guid"]." via PuSH: ".($push_notify?"Yes":"No"), LOGGER_DEBUG);
                } else {
                        $followup = false;
 
@@ -357,7 +355,7 @@ function notifier_run(&$argv, &$argc){
                        // a delivery fork. private groups (forum_mode == 2) do not uplink
 
                        if((intval($parent['forum_mode']) == 1) && (! $top_level) && ($cmd !== 'uplink')) {
-                               proc_run('php','include/notifier.php','uplink',$item_id);
+                               proc_run(PRIORITY_HIGH,'include/notifier.php','uplink',$item_id);
                        }
 
                        $conversants = array();
@@ -397,7 +395,34 @@ function notifier_run(&$argv, &$argc){
                // We have not only to look at the parent, since it could be a Friendica thread.
                if (($thr_parent AND ($thr_parent[0]['network'] == NETWORK_OSTATUS)) OR ($parent['network'] == NETWORK_OSTATUS)) {
 
-                       logger('Some parent is OStatus for '.$target_item["guid"], LOGGER_DEBUG);
+                       logger('Some parent is OStatus for '.$target_item["guid"]." - Author: ".$thr_parent[0]['author-link']." - Owner: ".$thr_parent[0]['owner-link'], LOGGER_DEBUG);
+
+                       // Send a salmon to the parent author
+                       $r = q("SELECT `notify` FROM `contact` WHERE `nurl`='%s' AND `uid` IN (0, %d) AND `notify` != ''",
+                               dbesc(normalise_link($thr_parent[0]['author-link'])),
+                               intval($uid));
+                       if ($r)
+                               $probed_contact = $r[0];
+                       else
+                               $probed_contact = probe_url($thr_parent[0]['author-link']);
+
+                       if ($probed_contact["notify"] != "") {
+                               logger('Notify parent author '.$probed_contact["url"].': '.$probed_contact["notify"]);
+                               $url_recipients[$probed_contact["notify"]] = $probed_contact["notify"];
+                       }
+
+                       // Send a salmon to the parent owner
+                       $r = q("SELECT `notify` FROM `contact` WHERE `nurl`='%s' AND `uid` IN (0, %d) AND `notify` != ''",
+                               dbesc(normalise_link($thr_parent[0]['owner-link'])),
+                               intval($uid));
+                       if ($r)
+                               $probed_contact = $r[0];
+                       else
+                               $probed_contact = probe_url($thr_parent[0]['owner-link']);
+                       if ($probed_contact["notify"] != "") {
+                               logger('Notify parent owner '.$probed_contact["url"].': '.$probed_contact["notify"]);
+                               $url_recipients[$probed_contact["notify"]] = $probed_contact["notify"];
+                       }
 
                        // Send a salmon notification to every person we mentioned in the post
                        $arr = explode(',',$target_item['tag']);
@@ -416,171 +441,15 @@ function notifier_run(&$argv, &$argc){
                        // It only makes sense to distribute answers to OStatus messages to Friendica and OStatus - but not Diaspora
                        $sql_extra = " AND `network` IN ('".NETWORK_OSTATUS."', '".NETWORK_DFRN."')";
                } else
-                       $sql_extra = "";
+                       $sql_extra = " AND `network` IN ('".NETWORK_OSTATUS."', '".NETWORK_DFRN."', '".NETWORK_DIASPORA."', '".NETWORK_MAIL."', '".NETWORK_MAIL2."')";
 
-               $r = q("SELECT * FROM `contact` WHERE `id` IN ($conversant_str) AND `blocked` = 0 AND `pending` = 0 AND `archive` = 0".$sql_extra);
+               $r = q("SELECT * FROM `contact` WHERE `id` IN ($conversant_str) AND NOT `blocked` AND NOT `pending` AND NOT `archive`".$sql_extra);
 
-               if(count($r))
+               if (dbm::is_result($r))
                        $contacts = $r;
-       }
-
-       $feed_template = get_markup_template('atom_feed.tpl');
-       $mail_template = get_markup_template('atom_mail.tpl');
-
-       $atom = '';
-       $slaps = array();
-
-       $hubxml = feed_hublinks();
-
-       $birthday = feed_birthday($owner['uid'],$owner['timezone']);
-
-       if(strlen($birthday))
-               $birthday = '<dfrn:birthday>' . xmlify($birthday) . '</dfrn:birthday>';
-
-       $atom .= replace_macros($feed_template, array(
-                       '$version'      => xmlify(FRIENDICA_VERSION),
-                       '$feed_id'      => xmlify($a->get_baseurl() . '/profile/' . $owner['nickname'] ),
-                       '$feed_title'   => xmlify($owner['name']),
-                       '$feed_updated' => xmlify(datetime_convert('UTC', 'UTC', $updated . '+00:00' , ATOM_TIME)) ,
-                       '$hub'          => $hubxml,
-                       '$salmon'       => '',  // private feed, we don't use salmon here
-                       '$name'         => xmlify($owner['name']),
-                       '$profile_page' => xmlify($owner['url']),
-                       '$photo'        => xmlify($owner['photo']),
-                       '$thumb'        => xmlify($owner['thumb']),
-                       '$picdate'      => xmlify(datetime_convert('UTC','UTC',$owner['avatar-date'] . '+00:00' , ATOM_TIME)) ,
-                       '$uridate'      => xmlify(datetime_convert('UTC','UTC',$owner['uri-date']    . '+00:00' , ATOM_TIME)) ,
-                       '$namdate'      => xmlify(datetime_convert('UTC','UTC',$owner['name-date']   . '+00:00' , ATOM_TIME)) ,
-                       '$birthday'     => $birthday,
-                       '$community'    => (($owner['page-flags'] == PAGE_COMMUNITY) ? '<dfrn:community>1</dfrn:community>' : '')
-
-       ));
-
-       if($mail) {
-               $public_message = false;  // mail is  not public
-
-               $body = fix_private_photos($item['body'],$owner['uid'],null,$message[0]['contact-id']);
-
-               $atom .= replace_macros($mail_template, array(
-                       '$name'         => xmlify($owner['name']),
-                       '$profile_page' => xmlify($owner['url']),
-                       '$thumb'        => xmlify($owner['thumb']),
-                       '$item_id'      => xmlify($item['uri']),
-                       '$subject'      => xmlify($item['title']),
-                       '$created'      => xmlify(datetime_convert('UTC', 'UTC', $item['created'] . '+00:00' , ATOM_TIME)),
-                       '$content'      => xmlify($body),
-                       '$parent_id'    => xmlify($item['parent-uri'])
-               ));
-       } elseif($fsuggest) {
-               $public_message = false;  // suggestions are not public
-
-               $sugg_template = get_markup_template('atom_suggest.tpl');
-
-               $atom .= replace_macros($sugg_template, array(
-                       '$name'         => xmlify($item['name']),
-                       '$url'          => xmlify($item['url']),
-                       '$photo'        => xmlify($item['photo']),
-                       '$request'      => xmlify($item['request']),
-                       '$note'         => xmlify($item['note'])
-               ));
-
-               // We don't need this any more
-
-               q("DELETE FROM `fsuggest` WHERE `id` = %d LIMIT 1",
-                       intval($item['id'])
-               );
-
-       } elseif($relocate) {
-               $public_message = false;  // suggestions are not public
-
-               $sugg_template = get_markup_template('atom_relocate.tpl');
-
-               /* get site pubkey. this could be a new installation with no site keys*/
-               $pubkey = get_config('system','site_pubkey');
-               if(! $pubkey) {
-                       $res = new_keypair(1024);
-                       set_config('system','site_prvkey', $res['prvkey']);
-                       set_config('system','site_pubkey', $res['pubkey']);
-               }
-
-               $rp = q("SELECT `resource-id` , `scale`, type FROM `photo` 
-                                               WHERE `profile` = 1 AND `uid` = %d ORDER BY scale;", $uid);
-               $photos = array();
-               $ext = Photo::supportedTypes();
-               foreach($rp as $p){
-                       $photos[$p['scale']] = $a->get_baseurl().'/photo/'.$p['resource-id'].'-'.$p['scale'].'.'.$ext[$p['type']];
-               }
-               unset($rp, $ext);
-
-               $atom .= replace_macros($sugg_template, array(
-                                       '$name' => xmlify($owner['name']),
-                                       '$photo' => xmlify($photos[4]),
-                                       '$thumb' => xmlify($photos[5]),
-                                       '$micro' => xmlify($photos[6]),
-                                       '$url' => xmlify($owner['url']),
-                                       '$request' => xmlify($owner['request']),
-                                       '$confirm' => xmlify($owner['confirm']),
-                                       '$notify' => xmlify($owner['notify']),
-                                       '$poll' => xmlify($owner['poll']),
-                                       '$sitepubkey' => xmlify(get_config('system','site_pubkey')),
-                                       //'$pubkey' => xmlify($owner['pubkey']),
-                                       //'$prvkey' => xmlify($owner['prvkey']),
-                       ));
-               $recipients_relocate = q("SELECT * FROM contact WHERE uid = %d  AND self = 0 AND network = '%s'" , intval($uid), NETWORK_DFRN);
-               unset($photos);
-       } else {
-
-               $slap = ostatus_salmon($target_item,$owner);
-               //$slap = atom_entry($target_item,'html',null,$owner,false);
-
-               if($followup) {
-                       foreach($items as $item) {  // there is only one item
-                               if(! $item['parent'])
-                                       continue;
-                               if($item['id'] == $item_id) {
-                                       logger('notifier: followup: item: ' . print_r($item,true), LOGGER_DATA);
-                                       //$slap  = atom_entry($item,'html',null,$owner,false);
-                                       $atom .= atom_entry($item,'text',null,$owner,false);
-                               }
-                       }
-               } else {
-                       foreach($items as $item) {
-
-                               if(! $item['parent'])
-                                       continue;
-
-                               // private emails may be in included in public conversations. Filter them.
-
-                               if(($public_message) && $item['private'] == 1)
-                                       continue;
-
-
-                               $contact = get_item_contact($item,$contacts);
-
-                               if(! $contact)
-                                       continue;
-
-                               if($normal_mode) {
-
-                                       // we only need the current item, but include the parent because without it
-                                       // older sites without a corresponding dfrn_notify change may do the wrong thing.
-
-                                   if($item_id == $item['id'] || $item['id'] == $item['parent'])
-                                               $atom .= atom_entry($item,'text',null,$owner,true);
-                               } else
-                                       $atom .= atom_entry($item,'text',null,$owner,true);
-
-                               if(($top_level) && ($public_message) && ($item['author-link'] === $item['owner-link']) && (! $expire))
-                                       $slaps[] = ostatus_salmon($item,$owner);
-                                       //$slaps[] = atom_entry($item,'html',null,$owner,true);
-                       }
-               }
-       }
-       $atom .= '</feed>' . "\r\n";
-
-       logger('notifier: ' . $atom, LOGGER_DATA);
 
-       logger('notifier: slaps: ' . print_r($slaps,true), LOGGER_DATA);
+       } else
+               $public_message = false;
 
        // If this is a public message and pubmail is set on the parent, include all your email contacts
 
@@ -590,11 +459,11 @@ function notifier_run(&$argv, &$argc){
                if((! strlen($target_item['allow_cid'])) && (! strlen($target_item['allow_gid']))
                        && (! strlen($target_item['deny_cid'])) && (! strlen($target_item['deny_gid']))
                        && (intval($target_item['pubmail']))) {
-                       $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `network` = '%s'",
+                       $r = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND `network` = '%s'",
                                intval($uid),
                                dbesc(NETWORK_MAIL)
                        );
-                       if(count($r)) {
+                       if (dbm::is_result($r)) {
                                foreach($r as $rr)
                                        $recipients[] = $rr['id'];
                        }
@@ -602,20 +471,18 @@ function notifier_run(&$argv, &$argc){
        }
 
        if($followup)
-               $recip_str = $parent['contact-id'];
+               $recip_str = implode(', ', $recipients_followup);
        else
                $recip_str = implode(', ', $recipients);
 
        if ($relocate)
                $r = $recipients_relocate;
        else
-               $r = q("SELECT * FROM `contact` WHERE `id` IN ( %s ) AND `blocked` = 0 AND `pending` = 0 ",
+               $r = q("SELECT * FROM `contact` WHERE `id` IN (%s) AND NOT `blocked` AND NOT `pending` AND NOT `archive`",
                        dbesc($recip_str)
                );
 
 
-       require_once('include/salmon.php');
-
        $interval = ((get_config('system','delivery_interval') === false) ? 2 : intval(get_config('system','delivery_interval')));
 
        // If we are using the worker we don't need a delivery interval
@@ -624,13 +491,13 @@ function notifier_run(&$argv, &$argc){
 
        // delivery loop
 
-       if(count($r)) {
+       if (dbm::is_result($r)) {
 
                foreach($r as $contact) {
-                       if((! $mail) && (! $fsuggest) && (! $followup) && (!$relocate) && (! $contact['self'])) {
+                       if(!$contact['self']) {
                                if(($contact['network'] === NETWORK_DIASPORA) && ($public_message))
                                        continue;
-                               q("insert into deliverq ( `cmd`,`item`,`contact` ) values ('%s', %d, %d )",
+                               q("INSERT INTO `deliverq` (`cmd`,`item`,`contact`) VALUES ('%s', %d, %d)",
                                        dbesc($cmd),
                                        intval($item_id),
                                        intval($contact['id'])
@@ -663,310 +530,37 @@ function notifier_run(&$argv, &$argc){
                        if($contact['self'])
                                continue;
 
-                       logger("Deliver ".$target_item["guid"]." to ".$contact['url'], LOGGER_DEBUG);
+                       logger("Deliver ".$target_item["guid"]." to ".$contact['url']." via network ".$contact['network'], LOGGER_DEBUG);
 
                        // potentially more than one recipient. Start a new process and space them out a bit.
                        // we will deliver single recipient types of message and email recipients here.
 
-                       if((! $mail) && (! $fsuggest) && (!$relocate) && (! $followup)) {
-
-                               $this_batch[] = $contact['id'];
+                       $this_batch[] = $contact['id'];
 
-                               if(count($this_batch) == $deliveries_per_process) {
-                                       proc_run('php','include/delivery.php',$cmd,$item_id,$this_batch);
-                                       $this_batch = array();
-                                       if($interval)
-                                               @time_sleep_until(microtime(true) + (float) $interval);
-                               }
-                               continue;
-                       }
-                       // be sure to pick up any stragglers
-                       if(count($this_batch))
-                               proc_run('php','include/delivery.php',$cmd,$item_id,$this_batch);
-
-
-                       $deliver_status = 0;
-
-                       logger("main delivery by notifier: followup=$followup mail=$mail fsuggest=$fsuggest relocate=$relocate");
-
-                       switch($contact['network']) {
-                               case NETWORK_DFRN:
-
-                                       // perform local delivery if we are on the same site
-
-                                       $basepath =  implode('/', array_slice(explode('/',$contact['url']),0,3));
-
-                                       if(link_compare($basepath,$a->get_baseurl())) {
-
-                                               $nickname = basename($contact['url']);
-                                               if($contact['issued-id'])
-                                                       $sql_extra = sprintf(" AND `dfrn-id` = '%s' ", dbesc($contact['issued-id']));
-                                               else
-                                                       $sql_extra = sprintf(" AND `issued-id` = '%s' ", dbesc($contact['dfrn-id']));
-
-                                               $x = q("SELECT  `contact`.*, `contact`.`uid` AS `importer_uid`,
-                                                       `contact`.`pubkey` AS `cpubkey`,
-                                                       `contact`.`prvkey` AS `cprvkey`,
-                                                       `contact`.`thumb` AS `thumb`,
-                                                       `contact`.`url` as `url`,
-                                                       `contact`.`name` as `senderName`,
-                                                       `user`.*
-                                                       FROM `contact`
-                                                       INNER JOIN `user` ON `contact`.`uid` = `user`.`uid`
-                                                       WHERE `contact`.`blocked` = 0 AND `contact`.`archive` = 0
-                                                       AND `contact`.`pending` = 0
-                                                       AND `contact`.`network` = '%s' AND `user`.`nickname` = '%s'
-                                                       $sql_extra
-                                                       AND `user`.`account_expired` = 0 AND `user`.`account_removed` = 0 LIMIT 1",
-                                                       dbesc(NETWORK_DFRN),
-                                                       dbesc($nickname)
-                                               );
-
-                                               if($x && count($x)) {
-                                                       $write_flag = ((($x[0]['rel']) && ($x[0]['rel'] != CONTACT_IS_SHARING)) ? true : false);
-                                                       if((($owner['page-flags'] == PAGE_COMMUNITY) || ($write_flag)) && (! $x[0]['writable'])) {
-                                                               q("update contact set writable = 1 where id = %d",
-                                                                       intval($x[0]['id'])
-                                                               );
-                                                               $x[0]['writable'] = 1;
-                                                       }
-
-                                                       // if contact's ssl policy changed, which we just determined
-                                                       // is on our own server, update our contact links
-
-                                                       $ssl_policy = get_config('system','ssl_policy');
-                                                       fix_contact_ssl_policy($x[0],$ssl_policy);
-
-                                                       // If we are setup as a soapbox we aren't accepting top level posts from this person
-
-                                                       if (($x[0]['page-flags'] == PAGE_SOAPBOX) AND $top_level)
-                                                               break;
-
-                                                       require_once('library/simplepie/simplepie.inc');
-                                                       logger('mod-delivery: local delivery');
-                                                       local_delivery($x[0],$atom);
-                                                       break;
-                                               }
-                                       }
-
-                                       logger('notifier: dfrndelivery: ' . $contact['name']);
-                                       $deliver_status = dfrn_deliver($owner,$contact,$atom);
-
-                                       logger('notifier: dfrn_delivery returns ' . $deliver_status);
-
-                                       if($deliver_status == (-1)) {
-                                               logger('notifier: delivery failed: queuing message');
-                                               // queue message for redelivery
-                                               add_to_queue($contact['id'],NETWORK_DFRN,$atom);
-                                       }
-                                       break;
-                               case NETWORK_OSTATUS:
-
-                                       // Do not send to ostatus if we are not configured to send to public networks
-                                       if($owner['prvnets'])
-                                               break;
-
-                                       if(get_config('system','ostatus_disabled') || get_config('system','dfrn_only'))
-                                               break;
-
-                                       if($followup && $contact['notify']) {
-                                               logger('slapdelivery followup item '.$item_id.' to ' . $contact['name']);
-                                               $deliver_status = slapper($owner,$contact['notify'],$slap);
-
-                                               if($deliver_status == (-1)) {
-                                                       // queue message for redelivery
-                                                       add_to_queue($contact['id'],NETWORK_OSTATUS,$slap);
-                                               }
-                                       } else {
-
-                                               // only send salmon if public - e.g. if it's ok to notify
-                                               // a public hub, it's ok to send a salmon
-
-                                               if((count($slaps)) && ($public_message) && (! $expire)) {
-                                                       logger('slapdelivery item '.$item_id.' to ' . $contact['name']);
-                                                       foreach($slaps as $slappy) {
-                                                               if($contact['notify']) {
-                                                                       $deliver_status = slapper($owner,$contact['notify'],$slappy);
-                                                                       if($deliver_status == (-1)) {
-                                                                               // queue message for redelivery
-                                                                               add_to_queue($contact['id'],NETWORK_OSTATUS,$slappy);
-                                                                       }
-                                                               }
-                                                       }
-                                               }
-                                       }
-                                       break;
-
-                               case NETWORK_MAIL:
-                               case NETWORK_MAIL2:
-
-                                       if(get_config('system','dfrn_only'))
-                                               break;
-
-                                       // WARNING: does not currently convert to RFC2047 header encodings, etc.
-
-                                       $addr = $contact['addr'];
-                                       if(! strlen($addr))
-                                               break;
-
-                                       if($cmd === 'wall-new' || $cmd === 'comment-new') {
-
-                                               $it = null;
-                                               if($cmd === 'wall-new') 
-                                                       $it = $items[0];
-                                               else {
-                                                       $r = q("SELECT * FROM `item` WHERE `id` = %d AND `uid` = %d LIMIT 1", 
-                                                               intval($argv[2]),
-                                                               intval($uid)
-                                                       );
-                                                       if(count($r))
-                                                               $it = $r[0];
-                                               }
-                                               if(! $it)
-                                                       break;
-
-
-
-                                               $local_user = q("SELECT * FROM `user` WHERE `uid` = %d LIMIT 1",
-                                                       intval($uid)
-                                               );
-                                               if(! count($local_user))
-                                                       break;
-
-                                               $reply_to = '';
-                                               $r1 = q("SELECT * FROM `mailacct` WHERE `uid` = %d LIMIT 1",
-                                                       intval($uid)
-                                               );
-                                               if($r1 && $r1[0]['reply_to'])
-                                                       $reply_to = $r1[0]['reply_to'];
-
-                                               $subject  = (($it['title']) ? email_header_encode($it['title'],'UTF-8') : t("\x28no subject\x29")) ;
-
-                                               // only expose our real email address to true friends
-                                               if(($contact['rel'] == CONTACT_IS_FRIEND) && (! $contact['blocked']))
-                                                       if($reply_to) {
-                                                               $headers  = 'From: ' . email_header_encode($local_user[0]['username'],'UTF-8') . ' <' . $reply_to . '>' . "\n";
-                                                               $headers .= 'Sender: '.$local_user[0]['email']."\n";
-                                                       } else
-                                                               $headers  = 'From: ' . email_header_encode($local_user[0]['username'],'UTF-8') . ' <' . $local_user[0]['email'] . '>' . "\n";
-                                               else
-                                                       $headers  = 'From: ' . email_header_encode($local_user[0]['username'],'UTF-8') . ' <' . t('noreply') . '@' . $a->get_hostname() . '>' . "\n";
-
-                                               //if($reply_to)
-                                               //      $headers .= 'Reply-to: ' . $reply_to . "\n";
-
-                                               $headers .= 'Message-Id: <' . iri2msgid($it['uri']) . '>' . "\n";
-
-                                               if($it['uri'] !== $it['parent-uri']) {
-                                                       $headers .= "References: <".iri2msgid($it["parent-uri"]).">";
-
-                                                       // If Threading is enabled, write down the correct parent
-                                                       if (($it["thr-parent"] != "") and ($it["thr-parent"] != $it["parent-uri"]))
-                                                               $headers .= " <".iri2msgid($it["thr-parent"]).">";
-                                                       $headers .= "\n";
-
-                                                       if(!$it['title']) {
-                                                               $r = q("SELECT `title` FROM `item` WHERE `uri` = '%s' AND `uid` = %d LIMIT 1",
-                                                                       dbesc($it['parent-uri']),
-                                                                       intval($uid));
-
-                                                               if(count($r) AND ($r[0]['title'] != ''))
-                                                                       $subject = $r[0]['title'];
-                                                               else {
-                                                                       $r = q("SELECT `title` FROM `item` WHERE `parent-uri` = '%s' AND `uid` = %d LIMIT 1",
-                                                                               dbesc($it['parent-uri']),
-                                                                               intval($uid));
-
-                                                                       if(count($r) AND ($r[0]['title'] != ''))
-                                                                               $subject = $r[0]['title'];
-                                                               }
-                                                       }
-                                                       if(strncasecmp($subject,'RE:',3))
-                                                               $subject = 'Re: '.$subject;
-                                               }
-                                               email_send($addr, $subject, $headers, $it);
-                                       }
-                                       break;
-                               case NETWORK_DIASPORA:
-                                       if(get_config('system','dfrn_only') || (! get_config('system','diaspora_enabled')))
-                                               break;
-
-                                       if($mail) {
-                                               diaspora_send_mail($item,$owner,$contact);
-                                               break;
-                                       }
-
-                                       if(! $normal_mode)
-                                               break;
-
-                                       // special handling for followup to public post
-                                       // all other public posts processed as public batches further below
-
-                                       if($public_message) {
-                                               if($followup)
-                                                       diaspora_send_followup($target_item,$owner,$contact, true);
-                                               break;
-                                       }
-
-                                       if(! $contact['pubkey'])
-                                               break;
-
-                                       $unsupported_activities = array(ACTIVITY_DISLIKE, ACTIVITY_ATTEND, ACTIVITY_ATTENDNO, ACTIVITY_ATTENDMAYBE);
-
-                                       //don't transmit activities which are not supported by diaspora
-                                       foreach($unsupported_activities as $act) {
-                                               if(activity_match($target_item['verb'],$act)) {
-                                                       break 2;
-                                               }
-                                       }
-
-                                       if(($target_item['deleted']) && (($target_item['uri'] === $target_item['parent-uri']) || $followup)) {
-                                               // send both top-level retractions and relayable retractions for owner to relay
-                                               diaspora_send_retraction($target_item,$owner,$contact);
-                                               break;
-                                       }
-                                       elseif($followup) {
-                                               // send comments and likes to owner to relay
-                                               diaspora_send_followup($target_item,$owner,$contact);
-                                               break;
-                                       }
-                                       elseif($target_item['uri'] !== $target_item['parent-uri']) {
-                                               // we are the relay - send comments, likes and relayable_retractions
-                                               // (of comments and likes) to our conversants
-                                               diaspora_send_relay($target_item,$owner,$contact);
-                                               break;
-                                       }
-                                       elseif(($top_level) && (! $walltowall)) {
-                                               // currently no workable solution for sending walltowall
-                                               diaspora_send_status($target_item,$owner,$contact);
-                                               break;
-                                       }
-
-                                       break;
-
-                               case NETWORK_FEED:
-                               case NETWORK_FACEBOOK:
-                                       if(get_config('system','dfrn_only'))
-                                               break;
-                               case NETWORK_PUMPIO:
-                                       if(get_config('system','dfrn_only'))
-                                               break;
-                               default:
-                                       break;
+                       if(count($this_batch) >= $deliveries_per_process) {
+                               proc_run(PRIORITY_HIGH,'include/delivery.php',$cmd,$item_id,$this_batch);
+                               $this_batch = array();
+                               if($interval)
+                                       @time_sleep_until(microtime(true) + (float) $interval);
                        }
+                       continue;
                }
+
+               // be sure to pick up any stragglers
+               if(count($this_batch))
+                       proc_run(PRIORITY_HIGH,'include/delivery.php',$cmd,$item_id,$this_batch);
        }
 
-       // send additional slaps to mentioned remote tags (@foo@example.com)
+       // send salmon slaps to mentioned remote tags (@foo@example.com) in OStatus posts
+       // They are especially used for notifications to OStatus users that don't follow us.
 
-       //if($slap && count($url_recipients) && ($followup || $top_level) && ($public_message || $push_notify) && (! $expire)) {
-       if($slap && count($url_recipients) && ($public_message || $push_notify) && (!$expire)) {
-               if(! get_config('system','dfrn_only')) {
+       if($slap && count($url_recipients) && ($public_message || $push_notify) && $normal_mode) {
+               if(!get_config('system','dfrn_only')) {
                        foreach($url_recipients as $url) {
                                if($url) {
                                        logger('notifier: urldelivery: ' . $url);
                                        $deliver_status = slapper($owner,$url,$slap);
-                                       // TODO: redeliver/queue these items on failure, though there is no contact record
+                                       /// @TODO Redeliver/queue these items on failure, though there is no contact record
                                }
                        }
                }
@@ -975,20 +569,20 @@ function notifier_run(&$argv, &$argc){
 
        if($public_message) {
 
-               if (!$followup AND $top_level)
-                       $r0 = diaspora_fetch_relay();
+               if (!$followup)
+                       $r0 = diaspora::relay_list();
                else
                        $r0 = array();
 
                $r1 = q("SELECT DISTINCT(`batch`), `id`, `name`,`network` FROM `contact` WHERE `network` = '%s'
-                       AND `uid` = %d AND `rel` != %d group by `batch` ORDER BY rand() ",
+                       AND `uid` = %d AND `rel` != %d AND NOT `blocked` AND NOT `pending` AND NOT `archive` GROUP BY `batch` ORDER BY rand()",
                        dbesc(NETWORK_DIASPORA),
                        intval($owner['uid']),
                        intval(CONTACT_IS_SHARING)
                );
 
                $r2 = q("SELECT `id`, `name`,`network` FROM `contact`
-                       WHERE `network` in ( '%s', '%s')  AND `uid` = %d AND `blocked` = 0 AND `pending` = 0 AND `archive` = 0
+                       WHERE `network` in ( '%s', '%s')  AND `uid` = %d AND NOT `blocked` AND NOT `pending` AND NOT `archive`
                        AND `rel` != %d order by rand() ",
                        dbesc(NETWORK_DFRN),
                        dbesc(NETWORK_MAIL2),
@@ -998,17 +592,17 @@ function notifier_run(&$argv, &$argc){
 
                $r = array_merge($r2,$r1,$r0);
 
-               if(count($r)) {
-                       logger('pubdeliver: ' . print_r($r,true), LOGGER_DEBUG);
+               if (dbm::is_result($r)) {
+                       logger('pubdeliver '.$target_item["guid"].': '.print_r($r,true), LOGGER_DEBUG);
 
                        // throw everything into the queue in case we get killed
 
                        foreach($r as $rr) {
                                if((! $mail) && (! $fsuggest) && (! $followup)) {
-                                       q("insert into deliverq ( `cmd`,`item`,`contact` ) values ('%s', %d, %d )",
-                                               dbesc($cmd),
-                                               intval($item_id),
-                                               intval($rr['id'])
+                                       q("INSERT INTO `deliverq` (`cmd`,`item`,`contact`) VALUES ('%s', %d, %d)
+                                               ON DUPLICATE KEY UPDATE `cmd` = '%s', `item` = %d, `contact` = %d",
+                                               dbesc($cmd), intval($item_id), intval($rr['id']),
+                                               dbesc($cmd), intval($item_id), intval($rr['id'])
                                        );
                                }
                        }
@@ -1024,8 +618,8 @@ function notifier_run(&$argv, &$argc){
                                }
 
                                if((! $mail) && (! $fsuggest) && (! $followup)) {
-                                       logger('notifier: delivery agent: ' . $rr['name'] . ' ' . $rr['id']);
-                                       proc_run('php','include/delivery.php',$cmd,$item_id,$rr['id']);
+                                       logger('notifier: delivery agent: '.$rr['name'].' '.$rr['id'].' '.$rr['network'].' '.$target_item["guid"]);
+                                       proc_run(PRIORITY_HIGH,'include/delivery.php',$cmd,$item_id,$rr['id']);
                                        if($interval)
                                                @time_sleep_until(microtime(true) + (float) $interval);
                                }
@@ -1036,7 +630,7 @@ function notifier_run(&$argv, &$argc){
 
        }
 
-
+       // Notify PuSH subscribers (Used for OStatus distribution of regular posts)
        if($push_notify AND strlen($hub)) {
                $hubs = explode(',', $hub);
                if(count($hubs)) {
@@ -1048,8 +642,8 @@ function notifier_run(&$argv, &$argc){
                                if ($h === '[internal]') {
                                        // Set push flag for PuSH subscribers to this topic,
                                        // they will be notified in queue.php
-                                       q("UPDATE `push_subscriber` SET `push` = 1 " .
-                                         "WHERE `nickname` = '%s'", dbesc($owner['nickname']));
+                                       q("UPDATE `push_subscriber` SET `push` = 1 ".
+                                         "WHERE `nickname` = '%s' AND `push` = 0", dbesc($owner['nickname']));
 
                                        logger('Activating internal PuSH for item '.$item_id, LOGGER_DEBUG);
 
@@ -1065,14 +659,7 @@ function notifier_run(&$argv, &$argc){
                }
 
                // Handling the pubsubhubbub requests
-               proc_run('php','include/pubsubpublish.php');
-       }
-
-       // If the item was deleted, clean up the `sign` table
-       if($target_item['deleted']) {
-               $r = q("DELETE FROM sign where `retract_iid` = %d",
-                       intval($target_item['id'])
-               );
+               proc_run(PRIORITY_HIGH,'include/pubsubpublish.php');
        }
 
        logger('notifier: calling hooks', LOGGER_DEBUG);