starting the big delivery shakeup

[friendica.git] / include / notifier.php

diff --git a/include/notifier.php b/include/notifier.php
index 0bb82b7bf802015401567c74d5faae102cd035bd..748d15743ad219bf7e9226198ecdcdf4166abfed 100644 (file)
--- a/include/notifier.php
+++ b/include/notifier.php
@@ -2,6 +2,20 @@
 
 require_once("boot.php");
 
+/*
+ * This file was at one time responsible for doing all deliveries, but this caused
+ * big problems on shared hosting systems, where the process might get killed by the 
+ * hosting provider and nothing would get delivered. 
+ * It now only delivers one message under certain cases, and invokes a queued
+ * delivery mechanism (include/deliver.php) to deliver individual contacts at 
+ * controlled intervals.
+ * This has a much better chance of surviving random processes getting killed
+ * by the hosting provider. 
+ * A lot of this code is duplicated in include/deliver.php until we have time to go back
+ * and re-structure the delivery procedure based on the obstacles that have been thrown at 
+ * us by hosting providers. 
+ */
+
 function notifier_run($argv, $argc){
        global $a, $db;
 
@@ -395,6 +409,8 @@ function notifier_run($argv, $argc){
 
                foreach($r as $contact) {
                        if((! $mail) && (! $fsuggest) && (! $followup) && (! $contact['self'])) {
+                               if(($contact['network'] === NETWORK_DIASPORA) && ($public_message))
+                                       continue;
                                q("insert into deliverq ( `cmd`,`item`,`contact` ) values ('%s', %d, %d )",
                                        dbesc($cmd),
                                        intval($item_id),
@@ -569,9 +585,19 @@ function notifier_run($argv, $argc){
                                        break;
                                case NETWORK_DIASPORA:
                                        require_once('include/diaspora.php');
+
                                        if(get_config('system','dfrn_only') || (! get_config('system','diaspora_enabled')) || (! $normal_mode))
                                                break;
 
+                                       // special handling for followup to public post
+                                       // all other public posts processed as public batches further below
+
+                                       if($public_message) {
+                                               if($followup)
+                                                       diaspora_send_followup($target_item,$owner,$contact, true);
+                                               break;
+                                       }
+
                                        if(! $contact['pubkey'])
                                                break;
                                        
@@ -594,7 +620,8 @@ function notifier_run($argv, $argc){
                                                diaspora_send_relay($target_item,$owner,$contact);
                                                break;
                                        }               
-                                       elseif($top_level) {
+                                       elseif(($top_level) && (! $walltowall)) {
+                                               // currently no workable solution for sending walltowall
                                                diaspora_send_status($target_item,$owner,$contact);
                                                break;
                                        }
@@ -628,17 +655,25 @@ function notifier_run($argv, $argc){
 
        if($public_message) {
 
-               $r = q("SELECT `id`, `name` FROM `contact` 
-                       WHERE `network` in ('%s','%s') AND `uid` = %d AND `blocked` = 0 AND `pending` = 0
+               $r1 = q("SELECT DISTINCT(`batch`), `id`, `name`,`network` FROM `contact` WHERE `network` = '%s' 
+                       AND `uid` = %d AND `rel` != %d ORDER BY rand() ",
+                       dbesc(NETWORK_DIASPORA),
+                       intval($owner['uid']),
+                       intval(CONTACT_IS_SHARING)
+               );
+                       
+               $r2 = q("SELECT `id`, `name`,`network` FROM `contact` 
+                       WHERE `network` = '%s' AND `uid` = %d AND `blocked` = 0 AND `pending` = 0
                        AND `rel` != %d order by rand() ",
                        dbesc(NETWORK_DFRN),
-                       dbesc(NETWORK_DIASPORA),
                        intval($owner['uid']),
                        intval(CONTACT_IS_SHARING)
                );
 
+               $r = array_merge($r2,$r1);
+
                if(count($r)) {
-                       logger('pubdeliver: ' . print_r($r,true));
+                       logger('pubdeliver: ' . print_r($r,true), LOGGER_DEBUG);
 
                        // throw everything into the queue in case we get killed
 
@@ -654,9 +689,10 @@ function notifier_run($argv, $argc){
 
                        foreach($r as $rr) {
 
-                               /* Don't deliver to folks who have already been delivered to */
+                               // except for Diaspora batch jobs
+                               // Don't deliver to folks who have already been delivered to
 
-                               if(in_array($rr['id'],$conversants)) {
+                               if(($rr['network'] !== NETWORK_DIASPORA) && (in_array($rr['id'],$conversants))) {
                                        logger('notifier: already delivered id=' . $rr['id']);
                                        continue;
                                }