]> git.mxchange.org Git - friendica.git/blobdiff - include/ostatus.php
Bugfix: A parameter was missing for the OStatus author check
[friendica.git] / include / ostatus.php
index d4c5d1617cc33b4b67c7dddd20750843c80d2381..5ba9f0e83c777ad103afd76b2420eef18de921a9 100644 (file)
@@ -17,15 +17,6 @@ define('OSTATUS_DEFAULT_POLL_INTERVAL', 30); // given in minutes
 define('OSTATUS_DEFAULT_POLL_TIMEFRAME', 1440); // given in minutes
 define('OSTATUS_DEFAULT_POLL_TIMEFRAME_MENTIONS', 14400); // given in minutes
 
-define("NS_ATOM", "http://www.w3.org/2005/Atom");
-define("NS_THR", "http://purl.org/syndication/thread/1.0");
-define("NS_GEORSS", "http://www.georss.org/georss");
-define("NS_ACTIVITY", "http://activitystrea.ms/spec/1.0/");
-define("NS_MEDIA", "http://purl.org/syndication/atommedia");
-define("NS_POCO", "http://portablecontacts.net/spec/1.0");
-define("NS_OSTATUS", "http://ostatus.org/schema/1.0");
-define("NS_STATUSNET", "http://status.net/schema/api/1/");
-
 function ostatus_check_follow_friends() {
        $r = q("SELECT `uid`,`v` FROM `pconfig` WHERE `cat`='system' AND `k`='ostatus_legacy_contact' AND `v` != ''");
 
@@ -173,8 +164,6 @@ function ostatus_fetchauthor($xpath, $context, $importer, &$contact, $onlyfetch)
                        update_contact_avatar($author["author-avatar"], $importer["uid"], $contact["id"]);
                }
 
-
-               /// @todo Add the "addr" field
                $contact["generation"] = 2;
                $contact["photo"] = $author["author-avatar"];
                update_gcontact($contact);
@@ -193,14 +182,14 @@ function ostatus_salmon_author($xml, $importer) {
        @$doc->loadXML($xml);
 
        $xpath = new DomXPath($doc);
-       $xpath->registerNamespace('atom', "http://www.w3.org/2005/Atom");
-       $xpath->registerNamespace('thr', "http://purl.org/syndication/thread/1.0");
-       $xpath->registerNamespace('georss', "http://www.georss.org/georss");
-       $xpath->registerNamespace('activity', "http://activitystrea.ms/spec/1.0/");
-       $xpath->registerNamespace('media', "http://purl.org/syndication/atommedia");
-       $xpath->registerNamespace('poco', "http://portablecontacts.net/spec/1.0");
-       $xpath->registerNamespace('ostatus', "http://ostatus.org/schema/1.0");
-       $xpath->registerNamespace('statusnet', "http://status.net/schema/api/1/");
+       $xpath->registerNamespace('atom', NAMESPACE_ATOM1);
+       $xpath->registerNamespace('thr', NAMESPACE_THREAD);
+       $xpath->registerNamespace('georss', NAMESPACE_GEORSS);
+       $xpath->registerNamespace('activity', NAMESPACE_ACTIVITY);
+       $xpath->registerNamespace('media', NAMESPACE_MEDIA);
+       $xpath->registerNamespace('poco', NAMESPACE_POCO);
+       $xpath->registerNamespace('ostatus', NAMESPACE_OSTATUS);
+       $xpath->registerNamespace('statusnet', NAMESPACE_STATUSNET);
 
        $entries = $xpath->query('/atom:entry');
 
@@ -224,14 +213,14 @@ function ostatus_import($xml,$importer,&$contact, &$hub) {
        @$doc->loadXML($xml);
 
        $xpath = new DomXPath($doc);
-       $xpath->registerNamespace('atom', "http://www.w3.org/2005/Atom");
-       $xpath->registerNamespace('thr', "http://purl.org/syndication/thread/1.0");
-       $xpath->registerNamespace('georss', "http://www.georss.org/georss");
-       $xpath->registerNamespace('activity', "http://activitystrea.ms/spec/1.0/");
-       $xpath->registerNamespace('media', "http://purl.org/syndication/atommedia");
-       $xpath->registerNamespace('poco', "http://portablecontacts.net/spec/1.0");
-       $xpath->registerNamespace('ostatus', "http://ostatus.org/schema/1.0");
-       $xpath->registerNamespace('statusnet', "http://status.net/schema/api/1/");
+       $xpath->registerNamespace('atom', NAMESPACE_ATOM1);
+       $xpath->registerNamespace('thr', NAMESPACE_THREAD);
+       $xpath->registerNamespace('georss', NAMESPACE_GEORSS);
+       $xpath->registerNamespace('activity', NAMESPACE_ACTIVITY);
+       $xpath->registerNamespace('media', NAMESPACE_MEDIA);
+       $xpath->registerNamespace('poco', NAMESPACE_POCO);
+       $xpath->registerNamespace('ostatus', NAMESPACE_OSTATUS);
+       $xpath->registerNamespace('statusnet', NAMESPACE_STATUSNET);
 
        $gub = "";
        $hub_attributes = $xpath->query("/atom:feed/atom:link[@rel='hub']")->item(0)->attributes;
@@ -548,7 +537,7 @@ function ostatus_import($xml,$importer,&$contact, &$hub) {
                } else
                        $item["parent-uri"] = $item["uri"];
 
-               $item_id = ostatus_completion($conversation, $importer["uid"], $item);
+               $item_id = ostatus_completion($conversation, $importer["uid"], $item, $self);
 
                if (!$item_id) {
                        logger("Error storing item", LOGGER_DEBUG);
@@ -556,29 +545,6 @@ function ostatus_import($xml,$importer,&$contact, &$hub) {
                }
 
                logger("Item was stored with id ".$item_id, LOGGER_DEBUG);
-               $item["id"] = $item_id;
-
-               if ($mention AND in_array($item["verb"], array(ACTIVITY_POST, ACTIVITY_SHARE))) {
-                       $u = q("SELECT `notify-flags`, `language`, `username`, `email` FROM user WHERE uid = %d LIMIT 1", intval($item['uid']));
-                       $r = q("SELECT `parent` FROM `item` WHERE `id` = %d", intval($item_id));
-
-                       notification(array(
-                               'type'         => NOTIFY_TAGSELF,
-                               'notify_flags' => $u[0]["notify-flags"],
-                               'language'     => $u[0]["language"],
-                               'to_name'      => $u[0]["username"],
-                               'to_email'     => $u[0]["email"],
-                               'uid'          => $item["uid"],
-                               'item'         => $item,
-                               'link'         => $a->get_baseurl().'/display/'.urlencode(get_item_guid($item_id)),
-                               'source_name'  => $item["author-name"],
-                               'source_link'  => $item["author-link"],
-                               'source_photo' => $item["author-avatar"],
-                               'verb'         => ACTIVITY_TAG,
-                               'otype'        => 'item',
-                               'parent'       => $r[0]["parent"]
-                       ));
-               }
        }
 }
 
@@ -658,16 +624,153 @@ function check_conversations($mentions = false, $override = false) {
        set_config('system','ostatus_last_poll', time());
 }
 
-function ostatus_completion($conversation_url, $uid, $item = array()) {
+/**
+ * @brief Updates the gcontact table with actor data from the conversation
+ *
+ * @param object $actor The actor object that contains the contact data
+ */
+function ostatus_conv_fetch_actor($actor) {
+
+       // We set the generation to "3" since the data here is not as reliable as the data we get on other occasions
+       $contact = array("network" => NETWORK_OSTATUS, "generation" => 3);
+
+       if (isset($actor->url))
+               $contact["url"] = $actor->url;
+
+       if (isset($actor->displayName))
+               $contact["name"] = $actor->displayName;
+
+       if (isset($actor->portablecontacts_net->displayName))
+               $contact["name"] = $actor->portablecontacts_net->displayName;
+
+       if (isset($actor->portablecontacts_net->preferredUsername))
+               $contact["nick"] = $actor->portablecontacts_net->preferredUsername;
+
+       if (isset($actor->id))
+               $contact["alias"] = $actor->id;
+
+       if (isset($actor->summary))
+               $contact["about"] = $actor->summary;
+
+       if (isset($actor->portablecontacts_net->note))
+               $contact["about"] = $actor->portablecontacts_net->note;
+
+       if (isset($actor->portablecontacts_net->addresses->formatted))
+               $contact["location"] = $actor->portablecontacts_net->addresses->formatted;
+
+
+       if (isset($actor->image->url))
+               $contact["photo"] = $actor->image->url;
+
+       if (isset($actor->image->width))
+               $avatarwidth = $actor->image->width;
+
+       if (is_array($actor->status_net->avatarLinks))
+               foreach ($actor->status_net->avatarLinks AS $avatar) {
+                       if ($avatarsize < $avatar->width) {
+                               $contact["photo"] = $avatar->url;
+                               $avatarsize = $avatar->width;
+                       }
+               }
+
+       update_gcontact($contact);
+}
+
+/**
+ * @brief Fetches the conversation url for a given item link or conversation id
+ *
+ * @param string $self The link to the posting
+ * @param string $conversation_id The conversation id
+ *
+ * @return string The conversation url
+ */
+function ostatus_fetch_conversation($self, $conversation_id = "") {
+
+       if ($conversation_id != "") {
+               $elements = explode(":", $conversation_id);
+
+               if ((count($elements) <= 2) OR ($elements[0] != "tag"))
+                       return $conversation_id;
+       }
+
+       if ($self == "")
+               return "";
+
+       $json = str_replace(".atom", ".json", $self);
+
+       $raw = fetch_url($json);
+       if ($raw == "")
+               return "";
+
+       $data = json_decode($raw);
+       if (!is_object($data))
+               return "";
+
+       $conversation_id = $data->statusnet_conversation_id;
+
+       $pos = strpos($self, "/api/statuses/show/");
+       $base_url = substr($self, 0, $pos);
+
+       return $base_url."/conversation/".$conversation_id;
+}
+
+/**
+ * @brief Fetches actor details of a given actor and user id
+ *
+ * @param string $actor The actor url
+ * @param int $uid The user id
+ * @param int $contact_id The default contact-id
+ *
+ * @return array Array with actor details
+ */
+function ostatus_get_actor_details($actor, $uid, $contact_id) {
+
+       $details = array();
+
+       $contact = q("SELECT `id`, `rel`, `network` FROM `contact` WHERE `uid` = %d AND `nurl` = '%s' AND `network` != '%s'",
+                               $uid, normalise_link($actor), NETWORK_STATUSNET);
+
+       if (!$contact)
+               $contact = q("SELECT `id`, `rel`, `network` FROM `contact` WHERE `uid` = %d AND `alias` IN ('%s', '%s') AND `network` != '%s'",
+                               $uid, $actor, normalise_link($actor), NETWORK_STATUSNET);
+
+       if ($contact) {
+               logger("Found contact for url ".$actor, LOGGER_DEBUG);
+               $details["contact_id"] = $contact[0]["id"];
+               $details["network"] = $contact[0]["network"];
+
+               $details["not_following"] = !in_array($contact[0]["rel"], array(CONTACT_IS_SHARING, CONTACT_IS_FRIEND));
+       } else {
+               logger("No contact found for user ".$uid." and url ".$actor, LOGGER_DEBUG);
+
+               // Adding a global contact
+               /// @TODO Use this data for the post
+               $details["global_contact_id"] = get_contact($actor, 0);
+
+               logger("Global contact ".$global_contact_id." found for url ".$actor, LOGGER_DEBUG);
+
+               $details["contact_id"] = $contact_id;
+               $details["network"] = NETWORK_OSTATUS;
+
+               $details["not_following"] = true;
+       }
+
+       return $details;
+}
+
+function ostatus_completion($conversation_url, $uid, $item = array(), $self = "") {
 
        $a = get_app();
 
        $item_stored = -1;
 
-       $conversation_url = ostatus_convert_href($conversation_url);
+       //$conversation_url = ostatus_convert_href($conversation_url);
+       $conversation_url = ostatus_fetch_conversation($self, $conversation_url);
 
        // If the thread shouldn't be completed then store the item and go away
-       if ((intval(get_config('system','ostatus_poll_interval')) == -2) AND (count($item) > 0)) {
+       // Don't do a completion on liked content
+       if (((intval(get_config('system','ostatus_poll_interval')) == -2) AND (count($item) > 0)) OR
+               ($item["verb"] == ACTIVITY_LIKE) OR ($conversation_url == "")) {
                //$arr["app"] .= " (OStatus-NoCompletion)";
                $item_stored = item_store($item, true);
                return($item_stored);
@@ -706,7 +809,7 @@ function ostatus_completion($conversation_url, $uid, $item = array()) {
        $pageno = 1;
        $items = array();
 
-       logger('fetching conversation url '.$conv.' for user '.$uid);
+       logger('fetching conversation url '.$conv.' (Self: '.$self.') for user '.$uid);
 
        do {
                $conv_arr = z_fetch_url($conv."?page=".$pageno);
@@ -759,8 +862,13 @@ function ostatus_completion($conversation_url, $uid, $item = array()) {
        $r = q("SELECT `nurl` FROM `contact` WHERE `uid` = %d AND `self`", intval($uid));
        $importer = $r[0];
 
+       $new_parent = true;
+
        foreach ($items as $single_conv) {
 
+               // Update the gcontact table
+               ostatus_conv_fetch_actor($single_conv->actor);
+
                // Test - remove before flight
                //$tempfile = tempnam(get_temppath(), "conversation");
                //file_put_contents($tempfile, json_encode($single_conv));
@@ -787,6 +895,9 @@ function ostatus_completion($conversation_url, $uid, $item = array()) {
                        // 2. This first post is a post inside our thread
                        // 3. This first post is a post inside another thread
                        if (($first_id != $parent["uri"]) AND ($parent["uri"] != "")) {
+
+                               $new_parent = true;
+
                                $new_parents = q("SELECT `id`, `parent`, `uri`, `contact-id`, `type`, `verb`, `visible` FROM `item` WHERE `id` IN
                                                        (SELECT `parent` FROM `item`
                                                                WHERE `uid` = %d AND `uri` = '%s' AND `network` IN ('%s','%s')) LIMIT 1",
@@ -887,30 +998,20 @@ function ostatus_completion($conversation_url, $uid, $item = array()) {
                if (isset($single_conv->actor->url))
                        $actor = $single_conv->actor->url;
 
-               $contact = q("SELECT `id` FROM `contact` WHERE `uid` = %d AND `nurl` = '%s' AND `network` != '%s'",
-                               $uid, normalise_link($actor), NETWORK_STATUSNET);
-
-               if (count($contact)) {
-                       logger("Found contact for url ".$actor, LOGGER_DEBUG);
-                       $contact_id = $contact[0]["id"];
-               } else {
-                       logger("No contact found for url ".$actor, LOGGER_DEBUG);
-
-                       // Adding a global contact
-                       /// @TODO Use this data for the post
-                       $global_contact_id = get_contact($actor, 0);
+               $details = ostatus_get_actor_details($actor, $uid, $parent["contact-id"]);
 
-                       logger("Global contact ".$global_contact_id." found for url ".$actor, LOGGER_DEBUG);
-
-                       $contact_id = $parent["contact-id"];
+               // Do we only want to import threads that were started by our contacts?
+               if ($details["not_following"] AND $new_parent AND get_config('system','ostatus_full_threads')) {
+                       logger("Don't import uri ".$first_id." because user ".$uid." doesn't follow the person ".$actor, LOGGER_DEBUG);
+                       continue;
                }
 
                $arr = array();
-               $arr["network"] = NETWORK_OSTATUS;
+               $arr["network"] = $details["network"];
                $arr["uri"] = $single_conv->id;
                $arr["plink"] = $plink;
                $arr["uid"] = $uid;
-               $arr["contact-id"] = $contact_id;
+               $arr["contact-id"] = $details["contact_id"];
                $arr["parent-uri"] = $parent_uri;
                $arr["created"] = $single_conv->published;
                $arr["edited"] = $single_conv->published;
@@ -1023,28 +1124,6 @@ function ostatus_completion($conversation_url, $uid, $item = array()) {
                // Add the conversation entry (but don't fetch the whole conversation)
                ostatus_store_conversation($newitem, $conversation_url);
 
-               if ($mention) {
-                       $u = q("SELECT `notify-flags`, `language`, `username`, `email` FROM user WHERE uid = %d LIMIT 1", intval($uid));
-                       $r = q("SELECT `parent` FROM `item` WHERE `id` = %d", intval($newitem));
-
-                       notification(array(
-                               'type'         => NOTIFY_TAGSELF,
-                               'notify_flags' => $u[0]["notify-flags"],
-                               'language'     => $u[0]["language"],
-                               'to_name'      => $u[0]["username"],
-                               'to_email'     => $u[0]["email"],
-                               'uid'          => $uid,
-                               'item'         => $arr,
-                               'link'         => $a->get_baseurl().'/display/'.urlencode(get_item_guid($newitem)),
-                               'source_name'  => $arr["author-name"],
-                               'source_link'  => $arr["author-link"],
-                               'source_photo' => $arr["author-avatar"],
-                               'verb'         => ACTIVITY_TAG,
-                               'otype'        => 'item',
-                               'parent'       => $r[0]["parent"]
-                       ));
-               }
-
                // If the newly created item is the top item then change the parent settings of the thread
                // This shouldn't happen anymore. This is supposed to be absolote.
                if ($arr["uri"] == $first_id) {
@@ -1058,6 +1137,15 @@ function ostatus_completion($conversation_url, $uid, $item = array()) {
 
        if (($item_stored < 0) AND (count($item) > 0)) {
                //$arr["app"] .= " (OStatus-NoConvFound)";
+
+               if (get_config('system','ostatus_full_threads')) {
+                       $details = ostatus_get_actor_details($item["owner-link"], $uid, $item["contact-id"]);
+                       if ($details["not_following"]) {
+                               logger("Don't import uri ".$item["uri"]." because user ".$uid." doesn't follow the person ".$item["owner-link"], LOGGER_DEBUG);
+                               return false;
+                       }
+               }
+
                $item_stored = item_store($item, true);
                if ($item_stored) {
                        logger("Uri ".$item["uri"]." wasn't found in conversation ".$conversation_url, LOGGER_DEBUG);
@@ -1165,16 +1253,16 @@ function ostatus_format_picture_post($body) {
 function ostatus_add_header($doc, $owner) {
        $a = get_app();
 
-       $root = $doc->createElementNS(NS_ATOM, 'feed');
+       $root = $doc->createElementNS(NAMESPACE_ATOM1, 'feed');
        $doc->appendChild($root);
 
-       $root->setAttribute("xmlns:thr", NS_THR);
-       $root->setAttribute("xmlns:georss", NS_GEORSS);
-       $root->setAttribute("xmlns:activity", NS_ACTIVITY);
-       $root->setAttribute("xmlns:media", NS_MEDIA);
-       $root->setAttribute("xmlns:poco", NS_POCO);
-       $root->setAttribute("xmlns:ostatus", NS_OSTATUS);
-       $root->setAttribute("xmlns:statusnet", NS_STATUSNET);
+       $root->setAttribute("xmlns:thr", NAMESPACE_THREAD);
+       $root->setAttribute("xmlns:georss", NAMESPACE_GEORSS);
+       $root->setAttribute("xmlns:activity", NAMESPACE_ACTIVITY);
+       $root->setAttribute("xmlns:media", NAMESPACE_MEDIA);
+       $root->setAttribute("xmlns:poco", NAMESPACE_POCO);
+       $root->setAttribute("xmlns:ostatus", NAMESPACE_OSTATUS);
+       $root->setAttribute("xmlns:statusnet", NAMESPACE_STATUSNET);
 
        $attributes = array("uri" => "https://friendi.ca", "version" => FRIENDICA_VERSION."-".DB_UPDATE_VERSION);
        xml_add_element($doc, $root, "generator", FRIENDICA_PLATFORM, $attributes);
@@ -1366,6 +1454,10 @@ function ostatus_add_author($doc, $owner) {
 function ostatus_entry($doc, $item, $owner, $toplevel = false, $repeat = false) {
        $a = get_app();
 
+       if (($item["id"] != $item["parent"]) AND (normalise_link($item["author-link"]) != normalise_link($owner["url"]))) {
+               logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
+       }
+
        $is_repeat = false;
 
 /*     if (!$repeat) {
@@ -1388,15 +1480,15 @@ function ostatus_entry($doc, $item, $owner, $toplevel = false, $repeat = false)
                $entry = $doc->createElement("activity:object");
                $title = sprintf("New note by %s", $owner["nick"]);
        } else {
-               $entry = $doc->createElementNS(NS_ATOM, "entry");
-
-               $entry->setAttribute("xmlns:thr", NS_THR);
-               $entry->setAttribute("xmlns:georss", NS_GEORSS);
-               $entry->setAttribute("xmlns:activity", NS_ACTIVITY);
-               $entry->setAttribute("xmlns:media", NS_MEDIA);
-               $entry->setAttribute("xmlns:poco", NS_POCO);
-               $entry->setAttribute("xmlns:ostatus", NS_OSTATUS);
-               $entry->setAttribute("xmlns:statusnet", NS_STATUSNET);
+               $entry = $doc->createElementNS(NAMESPACE_ATOM1, "entry");
+
+               $entry->setAttribute("xmlns:thr", NAMESPACE_THREAD);
+               $entry->setAttribute("xmlns:georss", NAMESPACE_GEORSS);
+               $entry->setAttribute("xmlns:activity", NAMESPACE_ACTIVITY);
+               $entry->setAttribute("xmlns:media", NAMESPACE_MEDIA);
+               $entry->setAttribute("xmlns:poco", NAMESPACE_POCO);
+               $entry->setAttribute("xmlns:ostatus", NAMESPACE_OSTATUS);
+               $entry->setAttribute("xmlns:statusnet", NAMESPACE_STATUSNET);
 
                $author = ostatus_add_author($doc, $owner);
                $entry->appendChild($author);