]> git.mxchange.org Git - friendica.git/blobdiff - include/ostatus.php
App::get_baseurl is now replaced with System::baseUrl
[friendica.git] / include / ostatus.php
index 3b5ca3f813fb47fc620aac9583778a11a01c203f..cd626201fcde4e0d04065445290b3285cea2bc3c 100644 (file)
@@ -3,20 +3,26 @@
  * @file include/ostatus.php
  */
 
-require_once("include/Contact.php");
-require_once("include/threads.php");
-require_once("include/html2bbcode.php");
-require_once("include/bbcode.php");
-require_once("include/items.php");
-require_once("mod/share.php");
-require_once("include/enotify.php");
-require_once("include/socgraph.php");
-require_once("include/Photo.php");
-require_once("include/Scrape.php");
-require_once("include/follow.php");
-require_once("include/api.php");
-require_once("mod/proxy.php");
-require_once("include/xml.php");
+use Friendica\App;
+use Friendica\Core\System;
+use Friendica\Core\Config;
+use Friendica\Network\Probe;
+
+require_once 'include/Contact.php';
+require_once 'include/threads.php';
+require_once 'include/html2bbcode.php';
+require_once 'include/bbcode.php';
+require_once 'include/items.php';
+require_once 'mod/share.php';
+require_once 'include/enotify.php';
+require_once 'include/socgraph.php';
+require_once 'include/Photo.php';
+require_once 'include/probe.php';
+require_once 'include/follow.php';
+require_once 'include/api.php';
+require_once 'mod/proxy.php';
+require_once 'include/xml.php';
+require_once 'include/cache.php';
 
 /**
  * @brief This class contain functions for the OStatus protocol
@@ -27,42 +33,6 @@ class ostatus {
        const OSTATUS_DEFAULT_POLL_TIMEFRAME = 1440; // given in minutes
        const OSTATUS_DEFAULT_POLL_TIMEFRAME_MENTIONS = 14400; // given in minutes
 
-       /**
-        * @brief Mix two paths together to possibly fix missing parts
-        *
-        * @param string $avatar Path to the avatar
-        * @param string $base Another path that is hopefully complete
-        *
-        * @return string fixed avatar path
-        */
-       public static function fix_avatar($avatar, $base) {
-               $base_parts = parse_url($base);
-
-               // Remove all parts that could create a problem
-               unset($base_parts['path']);
-               unset($base_parts['query']);
-               unset($base_parts['fragment']);
-
-               $avatar_parts = parse_url($avatar);
-
-               // Now we mix them
-               $parts = array_merge($base_parts, $avatar_parts);
-
-               // And put them together again
-               $scheme   = isset($parts['scheme']) ? $parts['scheme'] . '://' : '';
-               $host     = isset($parts['host']) ? $parts['host'] : '';
-               $port     = isset($parts['port']) ? ':' . $parts['port'] : '';
-               $path     = isset($parts['path']) ? $parts['path'] : '';
-               $query    = isset($parts['query']) ? '?' . $parts['query'] : '';
-               $fragment = isset($parts['fragment']) ? '#' . $parts['fragment'] : '';
-
-               $fixed = $scheme.$host.$port.$path.$query.$fragment;
-
-               logger('Base: '.$base.' - Avatar: '.$avatar.' - Fixed: '.$fixed, LOGGER_DATA);
-
-               return $fixed;
-       }
-
        /**
         * @brief Fetches author data
         *
@@ -74,58 +44,84 @@ class ostatus {
         *
         * @return array Array of author related entries for the item
         */
-       private function fetchauthor($xpath, $context, $importer, &$contact, $onlyfetch) {
+       private static function fetchauthor($xpath, $context, $importer, &$contact, $onlyfetch) {
 
                $author = array();
                $author["author-link"] = $xpath->evaluate('atom:author/atom:uri/text()', $context)->item(0)->nodeValue;
                $author["author-name"] = $xpath->evaluate('atom:author/atom:name/text()', $context)->item(0)->nodeValue;
+               $addr = $xpath->evaluate('atom:author/atom:email/text()', $context)->item(0)->nodeValue;
 
                $aliaslink = $author["author-link"];
 
                $alternate = $xpath->query("atom:author/atom:link[@rel='alternate']", $context)->item(0)->attributes;
-               if (is_object($alternate))
-                       foreach($alternate AS $attributes)
-                               if ($attributes->name == "href")
+               if (is_object($alternate)) {
+                       foreach ($alternate AS $attributes) {
+                               if (($attributes->name == "href") && ($attributes->textContent != "")) {
                                        $author["author-link"] = $attributes->textContent;
+                               }
+                       }
+               }
 
-               $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `nurl` IN ('%s', '%s') AND `network` != '%s'",
-                       intval($importer["uid"]), dbesc(normalise_link($author["author-link"])),
-                       dbesc(normalise_link($aliaslink)), dbesc(NETWORK_STATUSNET));
-               if ($r) {
-                       $contact = $r[0];
-                       $author["contact-id"] = $r[0]["id"];
-               } else
-                       $author["contact-id"] = $contact["id"];
+               $author["contact-id"] = $contact["id"];
+
+               if ($author["author-link"] != "") {
+                       if ($aliaslink == "") {
+                               $aliaslink = $author["author-link"];
+                       }
+
+                       $r = q("SELECT * FROM `contact` WHERE `uid` = %d AND `nurl` IN ('%s', '%s') AND `network` != '%s'",
+                               intval($importer["uid"]), dbesc(normalise_link($author["author-link"])),
+                               dbesc(normalise_link($aliaslink)), dbesc(NETWORK_STATUSNET));
+
+                       if (dbm::is_result($r)) {
+                               $contact = $r[0];
+                               $author["contact-id"] = $r[0]["id"];
+                               $author["author-link"] = $r[0]["url"];
+                       }
+               } elseif ($addr != "") {
+                       // Should not happen
+                       $contact = dba::fetch_first("SELECT * FROM `contact` WHERE `uid` = ? AND `addr` = ? AND `network` != ?",
+                                       $importer["uid"], $addr, NETWORK_STATUSNET);
+
+                       if (dbm::is_result($contact)) {
+                               $author["contact-id"] = $contact["id"];
+                               $author["author-link"] = $contact["url"];
+                       }
+               }
 
                $avatarlist = array();
                $avatars = $xpath->query("atom:author/atom:link[@rel='avatar']", $context);
-               foreach($avatars AS $avatar) {
+               foreach ($avatars AS $avatar) {
                        $href = "";
                        $width = 0;
-                       foreach($avatar->attributes AS $attributes) {
-                               if ($attributes->name == "href")
+                       foreach ($avatar->attributes AS $attributes) {
+                               if ($attributes->name == "href") {
                                        $href = $attributes->textContent;
-                               if ($attributes->name == "width")
+                               }
+                               if ($attributes->name == "width") {
                                        $width = $attributes->textContent;
+                               }
                        }
-                       if (($width > 0) AND ($href != ""))
+                       if ($href != "") {
                                $avatarlist[$width] = $href;
+                       }
                }
                if (count($avatarlist) > 0) {
                        krsort($avatarlist);
-                       $author["author-avatar"] = self::fix_avatar(current($avatarlist), $author["author-link"]);
+                       $author["author-avatar"] = Probe::fixAvatar(current($avatarlist), $author["author-link"]);
                }
 
                $displayname = $xpath->evaluate('atom:author/poco:displayName/text()', $context)->item(0)->nodeValue;
-               if ($displayname != "")
+               if ($displayname != "") {
                        $author["author-name"] = $displayname;
+               }
 
                $author["owner-name"] = $author["author-name"];
                $author["owner-link"] = $author["author-link"];
                $author["owner-avatar"] = $author["author-avatar"];
 
                // Only update the contacts if it is an OStatus contact
-               if ($r AND !$onlyfetch AND ($contact["network"] == NETWORK_OSTATUS)) {
+               if ($r && !$onlyfetch && ($contact["network"] == NETWORK_OSTATUS)) {
 
                        // Update contact data
 
@@ -159,8 +155,8 @@ class ostatus {
                        if ($value != "")
                                $contact["location"] = $value;
 
-                       if (($contact["name"] != $r[0]["name"]) OR ($contact["nick"] != $r[0]["nick"]) OR ($contact["about"] != $r[0]["about"]) OR
-                               ($contact["alias"] != $r[0]["alias"]) OR ($contact["location"] != $r[0]["location"])) {
+                       if (($contact["name"] != $r[0]["name"]) || ($contact["nick"] != $r[0]["nick"]) || ($contact["about"] != $r[0]["about"]) ||
+                               ($contact["alias"] != $r[0]["alias"]) || ($contact["location"] != $r[0]["location"])) {
 
                                logger("Update contact data for contact ".$contact["id"], LOGGER_DEBUG);
 
@@ -170,7 +166,7 @@ class ostatus {
                                        dbesc(datetime_convert()), intval($contact["id"]));
                        }
 
-                       if (isset($author["author-avatar"]) AND ($author["author-avatar"] != $r[0]['avatar'])) {
+                       if (isset($author["author-avatar"]) && ($author["author-avatar"] != $r[0]['avatar'])) {
                                logger("Update profile picture for contact ".$contact["id"], LOGGER_DEBUG);
 
                                update_contact_avatar($author["author-avatar"], $importer["uid"], $contact["id"]);
@@ -201,7 +197,7 @@ class ostatus {
                        link_gcontact($gcid, $contact["uid"], $contact["id"]);
                }
 
-               return($author);
+               return $author;
        }
 
        /**
@@ -312,8 +308,10 @@ class ostatus {
 
                if ($first_child == "feed") {
                        $entries = $xpath->query('/atom:feed/atom:entry');
+                       $header["protocol"] = PROTOCOL_OSTATUS_FEED;
                } else {
                        $entries = $xpath->query('/atom:entry');
+                       $header["protocol"] = PROTOCOL_OSTATUS_SALMON;
                }
                $conversation = "";
                $conversationlist = array();
@@ -358,19 +356,19 @@ class ostatus {
                        $item["verb"] = $xpath->query('activity:verb/text()', $entry)->item(0)->nodeValue;
 
                        // Mastodon Content Warning
-                       if (($item["verb"] == ACTIVITY_POST) AND $xpath->evaluate('boolean(atom:summary)', $entry)) {
+                       if (($item["verb"] == ACTIVITY_POST) && $xpath->evaluate('boolean(atom:summary)', $entry)) {
                                $clear_text = $xpath->query('atom:summary/text()', $entry)->item(0)->nodeValue;
 
                                $item["body"] = html2bbcode($clear_text) . '[spoiler]' . $item["body"] . '[/spoiler]';
                        }
 
-                       if (($item["object-type"] == ACTIVITY_OBJ_BOOKMARK) OR ($item["object-type"] == ACTIVITY_OBJ_EVENT)) {
+                       if (($item["object-type"] == ACTIVITY_OBJ_BOOKMARK) || ($item["object-type"] == ACTIVITY_OBJ_EVENT)) {
                                $item["title"] = $xpath->query('atom:title/text()', $entry)->item(0)->nodeValue;
                                $item["body"] = $xpath->query('atom:summary/text()', $entry)->item(0)->nodeValue;
                        } elseif ($item["object-type"] == ACTIVITY_OBJ_QUESTION) {
                                $item["title"] = $xpath->query('atom:title/text()', $entry)->item(0)->nodeValue;
                        }
-                       $item["object"] = $xml;
+                       $item["source"] = $xml;
 
                        /// @TODO
                        /// Delete a message
@@ -418,6 +416,19 @@ class ostatus {
                        $item["created"] = $xpath->query('atom:published/text()', $entry)->item(0)->nodeValue;
                        $item["edited"] = $xpath->query('atom:updated/text()', $entry)->item(0)->nodeValue;
                        $conversation = $xpath->query('ostatus:conversation/text()', $entry)->item(0)->nodeValue;
+                       $item['conversation-uri'] = $conversation;
+
+                       $conv = $xpath->query('ostatus:conversation', $entry);
+                       if (is_object($conv->item(0))) {
+                               foreach ($conv->item(0)->attributes AS $attributes) {
+                                       if ($attributes->name == "ref") {
+                                               $item['conversation-uri'] = $attributes->textContent;
+                                       }
+                                       if ($attributes->name == "href") {
+                                               $item['conversation-href'] = $attributes->textContent;
+                                       }
+                               }
+                       }
 
                        $related = "";
 
@@ -443,10 +454,10 @@ class ostatus {
                                        foreach ($category->attributes AS $attributes) {
                                                if ($attributes->name == "term") {
                                                        $term = $attributes->textContent;
-                                                       if(strlen($item["tag"])) {
+                                                       if (strlen($item["tag"])) {
                                                                $item["tag"] .= ',';
                                                        }
-                                                       $item["tag"] .= "#[url=".App::get_baseurl()."/search?tag=".$term."]".$term."[/url]";
+                                                       $item["tag"] .= "#[url=".System::baseUrl()."/search?tag=".$term."]".$term."[/url]";
                                                }
                                        }
                                }
@@ -460,17 +471,21 @@ class ostatus {
                                foreach ($links AS $link) {
                                        $attribute = self::read_attributes($link);
 
-                                       if (($attribute['rel'] != "") AND ($attribute['href'] != "")) {
+                                       if (($attribute['rel'] != "") && ($attribute['href'] != "")) {
                                                switch ($attribute['rel']) {
                                                        case "alternate":
                                                                $item["plink"] = $attribute['href'];
-                                                               if (($item["object-type"] == ACTIVITY_OBJ_QUESTION) OR
+                                                               if (($item["object-type"] == ACTIVITY_OBJ_QUESTION) ||
                                                                        ($item["object-type"] == ACTIVITY_OBJ_EVENT)) {
                                                                        $item["body"] .= add_page_info($attribute['href']);
                                                                }
                                                                break;
                                                        case "ostatus:conversation":
                                                                $conversation = $attribute['href'];
+                                                               $item['conversation-href'] = $conversation;
+                                                               if (!isset($item['conversation-uri'])) {
+                                                                       $item['conversation-uri'] = $item['conversation-href'];
+                                                               }
                                                                break;
                                                        case "enclosure":
                                                                $enclosure = $attribute['href'];
@@ -512,7 +527,7 @@ class ostatus {
                        $repeat_of = "";
 
                        $notice_info = $xpath->query('statusnet:notice_info', $entry);
-                       if ($notice_info AND ($notice_info->length > 0)) {
+                       if ($notice_info && ($notice_info->length > 0)) {
                                foreach ($notice_info->item(0)->attributes AS $attributes) {
                                        if ($attributes->name == "source") {
                                                $item["app"] = strip_tags($attributes->textContent);
@@ -527,7 +542,7 @@ class ostatus {
                        }
 
                        // Is it a repeated post?
-                       if (($repeat_of != "") OR ($item["verb"] == ACTIVITY_SHARE)) {
+                       if (($repeat_of != "") || ($item["verb"] == ACTIVITY_SHARE)) {
                                $activityobjects = $xpath->query('activity:object', $entry)->item(0);
 
                                if (is_object($activityobjects)) {
@@ -537,7 +552,7 @@ class ostatus {
                                                $orig_uri = $xpath->query('atom:id/text()', $activityobjects)->item(0)->nodeValue;
                                        }
                                        $orig_links = $xpath->query("activity:object/atom:link[@rel='alternate']", $activityobjects);
-                                       if ($orig_links AND ($orig_links->length > 0)) {
+                                       if ($orig_links && ($orig_links->length > 0)) {
                                                foreach ($orig_links->item(0)->attributes AS $attributes) {
                                                        if ($attributes->name == "href") {
                                                                $orig_link = $attributes->textContent;
@@ -608,8 +623,8 @@ class ostatus {
                                        intval($importer["uid"]), dbesc($item["parent-uri"]));
 
                                // Only fetch missing stuff if it is a comment or reshare.
-                               if (in_array($item["verb"], array(ACTIVITY_POST, ACTIVITY_SHARE)) AND
-                                       !dbm::is_result($r) AND ($related != "")) {
+                               if (in_array($item["verb"], array(ACTIVITY_POST, ACTIVITY_SHARE)) &&
+                                       !dbm::is_result($r) && ($related != "")) {
                                        $reply_path = str_replace("/notice/", "/api/statuses/show/", $related).".atom";
 
                                        if ($reply_path != $related) {
@@ -634,6 +649,9 @@ class ostatus {
                        $item_id = self::completion($conversation, $importer["uid"], $item, $self);
 
                        if (!$item_id) {
+                               // Store the conversation data. This is normally done in "item_store"
+                               // but since something went wrong, we want to be sure to save the data.
+                               store_conversation($item);
                                logger("Error storing item", LOGGER_DEBUG);
                                continue;
                        }
@@ -652,23 +670,23 @@ class ostatus {
        public static function convert_href($href) {
                $elements = explode(":",$href);
 
-               if ((count($elements) <= 2) OR ($elements[0] != "tag"))
+               if ((count($elements) <= 2) || ($elements[0] != "tag"))
                        return $href;
 
                $server = explode(",", $elements[1]);
                $conversation = explode("=", $elements[2]);
 
-               if ((count($elements) == 4) AND ($elements[2] == "post"))
+               if ((count($elements) == 4) && ($elements[2] == "post"))
                        return "http://".$server[0]."/notice/".$elements[3];
 
-               if ((count($conversation) != 2) OR ($conversation[1] ==""))
+               if ((count($conversation) != 2) || ($conversation[1] =="")) {
                        return $href;
-
-               if ($elements[3] == "objectType=thread")
+               }
+               if ($elements[3] == "objectType=thread") {
                        return "http://".$server[0]."/conversation/".$conversation[1];
-               else
+               } else {
                        return "http://".$server[0]."/notice/".$conversation[1];
-
+               }
                return $href;
        }
 
@@ -687,7 +705,7 @@ class ostatus {
                }
 
                // Don't poll if the interval is set negative
-               if (($poll_interval < 0) AND !$override) {
+               if (($poll_interval < 0) && !$override) {
                        return;
                }
 
@@ -704,7 +722,7 @@ class ostatus {
                }
 
 
-               if ($last AND !$override) {
+               if ($last && !$override) {
                        $next = $last + ($poll_interval * 60);
                        if ($next > time()) {
                                logger('poll interval not reached');
@@ -720,11 +738,11 @@ class ostatus {
                        $conversations = q("SELECT `term`.`oid`, `term`.`url`, `term`.`uid` FROM `term`
                                                STRAIGHT_JOIN `thread` ON `thread`.`iid` = `term`.`oid` AND `thread`.`uid` = `term`.`uid`
                                                WHERE `term`.`type` = 7 AND `term`.`term` > '%s' AND `thread`.`mention`
-                                               GROUP BY `term`.`url`, `term`.`uid` ORDER BY `term`.`term` DESC", dbesc($start));
+                                               GROUP BY `term`.`url`, `term`.`uid`, `term`.`oid`, `term`.`term` ORDER BY `term`.`term` DESC", dbesc($start));
                } else {
                        $conversations = q("SELECT `oid`, `url`, `uid` FROM `term`
                                                WHERE `type` = 7 AND `term` > '%s'
-                                               GROUP BY `url`, `uid` ORDER BY `term` DESC", dbesc($start));
+                                               GROUP BY `url`, `uid`, `oid`, `term` ORDER BY `term` DESC", dbesc($start));
                }
 
                foreach ($conversations AS $conversation) {
@@ -741,7 +759,7 @@ class ostatus {
         *
         * @param object $actor The actor object that contains the contact data
         */
-       private function conv_fetch_actor($actor) {
+       private static function conv_fetch_actor($actor) {
 
                // We set the generation to "3" since the data here is not as reliable as the data we get on other occasions
                $contact = array("network" => NETWORK_OSTATUS, "generation" => 3);
@@ -797,12 +815,12 @@ class ostatus {
         *
         * @return string The conversation url
         */
-       private function fetch_conversation($self, $conversation_id = "") {
+       private static function fetch_conversation($self, $conversation_id = "") {
 
                if ($conversation_id != "") {
                        $elements = explode(":", $conversation_id);
 
-                       if ((count($elements) <= 2) OR ($elements[0] != "tag"))
+                       if ((count($elements) <= 2) || ($elements[0] != "tag"))
                                return $conversation_id;
                }
 
@@ -827,6 +845,30 @@ class ostatus {
                return $base_url."/conversation/".$conversation_id;
        }
 
+       /**
+        * @brief Fetches a shared object from a given conversation object
+        *
+        * Sometimes GNU Social seems to fail when returning shared objects.
+        * Then they don't contains all needed data.
+        * We then try to find this object in the conversation
+        *
+        * @param string $id Message id
+        * @param object $conversation Conversation object
+        *
+        * @return object The shared object
+        */
+       private static function shared_object($id, $conversation) {
+               if (!is_array($conversation->items)) {
+                       return false;
+               }
+               foreach ($conversation->items AS $single_conv) {
+                       if ($single_conv->id == $id) {
+                               return $single_conv;
+                       }
+               }
+               return false;
+       }
+
        /**
         * @brief Fetches actor details of a given actor and user id
         *
@@ -836,7 +878,7 @@ class ostatus {
         *
         * @return array Array with actor details
         */
-       private function get_actor_details($actor, $uid, $contact_id) {
+       private static function get_actor_details($actor, $uid, $contact_id) {
 
                $details = array();
 
@@ -880,7 +922,7 @@ class ostatus {
         *
         * @return integer The item id of the posted item array
         */
-       private function completion($conversation_url, $uid, $item = array(), $self = "") {
+       private static function completion($conversation_url, $uid, $item = array(), $self = "") {
 
                /// @todo This function is totally ugly and has to be rewritten totally
 
@@ -893,8 +935,8 @@ class ostatus {
 
                // If the thread shouldn't be completed then store the item and go away
                // Don't do a completion on liked content
-               if (((intval(get_config('system','ostatus_poll_interval')) == -2) AND (count($item) > 0)) OR
-                       ($item["verb"] == ACTIVITY_LIKE) OR ($conversation_url == "")) {
+               if (((intval(get_config('system','ostatus_poll_interval')) == -2) && (count($item) > 0)) ||
+                       ($item["verb"] == ACTIVITY_LIKE) || ($conversation_url == "")) {
                        $item_stored = item_store($item, $all_threads);
                        return $item_stored;
                }
@@ -906,17 +948,9 @@ class ostatus {
                                STRAIGHT_JOIN `item` ON `item`.`parent` = `thritem`.`parent`
                                WHERE `term`.`uid` = %d AND `term`.`otype` = %d AND `term`.`type` = %d AND `term`.`url` = '%s'",
                                intval($uid), intval(TERM_OBJ_POST), intval(TERM_CONVERSATION), dbesc($conversation_url));
-
-/*             2016-10-23: The old query will be kept until we are sure that the query above is a good and fast replacement
-
-               $parents = q("SELECT `id`, `parent`, `uri`, `contact-id`, `type`, `verb`, `visible` FROM `item` WHERE `id` IN
-                               (SELECT `parent` FROM `item` WHERE `id` IN
-                                       (SELECT `oid` FROM `term` WHERE `uid` = %d AND `otype` = %d AND `type` = %d AND `url` = '%s'))",
-                               intval($uid), intval(TERM_OBJ_POST), intval(TERM_CONVERSATION), dbesc($conversation_url));
-*/
-               if ($parents)
+               if ($parents) {
                        $parent = $parents[0];
-               elseif (count($item) > 0) {
+               elseif (count($item) > 0) {
                        $parent = $item;
                        $parent["type"] = "remote";
                        $parent["verb"] = ACTIVITY_POST;
@@ -924,9 +958,9 @@ class ostatus {
                } else {
                        // Preset the parent
                        $r = q("SELECT `id` FROM `contact` WHERE `self` AND `uid`=%d", $uid);
-                       if (!$r)
-                               return(-2);
-
+                       if (!dbm::is_result($r)) {
+                               return -2;
+                       }
                        $parent = array();
                        $parent["id"] = 0;
                        $parent["parent"] = 0;
@@ -947,15 +981,15 @@ class ostatus {
                        $conv_arr = z_fetch_url($conv."?page=".$pageno);
 
                        // If it is a non-ssl site and there is an error, then try ssl or vice versa
-                       if (!$conv_arr["success"] AND (substr($conv, 0, 7) == "http://")) {
+                       if (!$conv_arr["success"] && (substr($conv, 0, 7) == "http://")) {
                                $conv = str_replace("http://", "https://", $conv);
                                $conv_as = fetch_url($conv."?page=".$pageno);
-                       } elseif (!$conv_arr["success"] AND (substr($conv, 0, 8) == "https://")) {
+                       } elseif (!$conv_arr["success"] && (substr($conv, 0, 8) == "https://")) {
                                $conv = str_replace("https://", "http://", $conv);
                                $conv_as = fetch_url($conv."?page=".$pageno);
-                       } else
+                       } else {
                                $conv_as = $conv_arr["body"];
-
+                       }
                        $conv_as = str_replace(',"statusnet:notice_info":', ',"statusnet_notice_info":', $conv_as);
                        $conv_as = json_decode($conv_as);
 
@@ -983,9 +1017,10 @@ class ostatus {
                                        self::store_conversation($item_id, $conversation_url);
                                }
 
-                               return($item_stored);
-                       } else
-                               return(-3);
+                               return $item_stored;
+                       } else {
+                               return -3;
+                       }
                }
 
                $items = array_reverse($items);
@@ -1025,7 +1060,7 @@ class ostatus {
                                // 1. Our conversation hasn't the "real" thread starter
                                // 2. This first post is a post inside our thread
                                // 3. This first post is a post inside another thread
-                               if (($first_id != $parent["uri"]) AND ($parent["uri"] != "")) {
+                               if (($first_id != $parent["uri"]) && ($parent["uri"] != "")) {
 
                                        $new_parent = true;
 
@@ -1112,7 +1147,7 @@ class ostatus {
                                }
 
                                // The item we are having on the system is the one that we wanted to store via the item array
-                               if (isset($item["uri"]) AND ($item["uri"] == $existing_message["uri"])) {
+                               if (isset($item["uri"]) && ($item["uri"] == $existing_message["uri"])) {
                                        $item = array();
                                        $item_stored = 0;
                                }
@@ -1121,7 +1156,7 @@ class ostatus {
                        }
 
                        if (is_array($single_conv->to))
-                               foreach($single_conv->to AS $to)
+                               foreach ($single_conv->to AS $to)
                                        if ($importer["nurl"] == normalise_link($to->id))
                                                $mention = true;
 
@@ -1132,11 +1167,12 @@ class ostatus {
                        $details = self::get_actor_details($actor, $uid, $parent["contact-id"]);
 
                        // Do we only want to import threads that were started by our contacts?
-                       if ($details["not_following"] AND $new_parent AND get_config('system','ostatus_full_threads')) {
+                       if ($details["not_following"] && $new_parent && get_config('system','ostatus_full_threads')) {
                                logger("Don't import uri ".$first_id." because user ".$uid." doesn't follow the person ".$actor, LOGGER_DEBUG);
                                continue;
                        }
 
+                       /// @TODO One statment is okay (until if () )
                        $arr = array();
                        $arr["network"] = $details["network"];
                        $arr["uri"] = $single_conv->id;
@@ -1153,72 +1189,88 @@ class ostatus {
                                $arr["owner-name"] = $single_conv->actor->portablecontacts_net->displayName;
 
                        $arr["owner-link"] = $actor;
-                       $arr["owner-avatar"] = self::fix_avatar($single_conv->actor->image->url, $arr["owner-link"]);
+                       $arr["owner-avatar"] = Probe::fixAvatar($single_conv->actor->image->url, $arr["owner-link"]);
 
                        $arr["author-name"] = $arr["owner-name"];
                        $arr["author-link"] = $arr["owner-link"];
                        $arr["author-avatar"] = $arr["owner-avatar"];
                        $arr["body"] = add_page_info_to_body(html2bbcode($single_conv->content));
 
-                       if (isset($single_conv->status_net->notice_info->source))
+                       if (isset($single_conv->status_net->conversation)) {
+                               $arr['conversation-uri'] = $single_conv->status_net->conversation;
+                       }
+
+                       if (isset($single_conv->status_net->notice_info->source)) {
                                $arr["app"] = strip_tags($single_conv->status_net->notice_info->source);
-                       elseif (isset($single_conv->statusnet->notice_info->source))
+                       } elseif (isset($single_conv->statusnet->notice_info->source)) {
                                $arr["app"] = strip_tags($single_conv->statusnet->notice_info->source);
-                       elseif (isset($single_conv->statusnet_notice_info->source))
+                       } elseif (isset($single_conv->statusnet_notice_info->source)) {
                                $arr["app"] = strip_tags($single_conv->statusnet_notice_info->source);
-                       elseif (isset($single_conv->provider->displayName))
+                       } elseif (isset($single_conv->provider->displayName)) {
                                $arr["app"] = $single_conv->provider->displayName;
-                       else
+                       } else {
                                $arr["app"] = "OStatus";
+                       }
 
+                       $arr["source"] = json_encode($single_conv);
+                       $arr["protocol"] = PROTOCOL_GS_CONVERSATION;
 
-                       $arr["object"] = json_encode($single_conv);
                        $arr["verb"] = $parent["verb"];
                        $arr["visible"] = $parent["visible"];
                        $arr["location"] = $single_conv->location->displayName;
                        $arr["coord"] = trim($single_conv->location->lat." ".$single_conv->location->lon);
 
                        // Is it a reshared item?
-                       if (isset($single_conv->verb) AND ($single_conv->verb == "share") AND isset($single_conv->object)) {
+                       if (isset($single_conv->verb) && ($single_conv->verb == "share") && isset($single_conv->object)) {
                                if (is_array($single_conv->object))
                                        $single_conv->object = $single_conv->object[0];
 
-                               logger("Found reshared item ".$single_conv->object->id);
+                               // Sometimes GNU Social doesn't returns a complete object
+                               if (!isset($single_conv->object->actor->url)) {
+                                       $object = self::shared_object($single_conv->object->id, $conversation);
+                                       if (is_object($object)) {
+                                               $single_conv->object = $object;
+                                       }
+                               }
 
-                               // $single_conv->object->context->conversation;
+                               if (isset($single_conv->object->actor->url)) {
+                                       logger("Found reshared item ".$single_conv->object->id);
 
-                               if (isset($single_conv->object->object->id))
-                                       $arr["uri"] = $single_conv->object->object->id;
-                               else
-                                       $arr["uri"] = $single_conv->object->id;
+                                       // $single_conv->object->context->conversation;
 
-                               if (isset($single_conv->object->object->url))
-                                       $plink = self::convert_href($single_conv->object->object->url);
-                               else
-                                       $plink = self::convert_href($single_conv->object->url);
+                                       if (isset($single_conv->object->object->id)) {
+                                               $arr["uri"] = $single_conv->object->object->id;
+                                       } else {
+                                               $arr["uri"] = $single_conv->object->id;
+                                       }
+                                       if (isset($single_conv->object->object->url)) {
+                                               $plink = self::convert_href($single_conv->object->object->url);
+                                       } else {
+                                               $plink = self::convert_href($single_conv->object->url);
+                                       }
+                                       if (isset($single_conv->object->object->content)) {
+                                               $arr["body"] = add_page_info_to_body(html2bbcode($single_conv->object->object->content));
+                                       } else {
+                                               $arr["body"] = add_page_info_to_body(html2bbcode($single_conv->object->content));
+                                       }
+                                       $arr["plink"] = $plink;
 
-                               if (isset($single_conv->object->object->content))
-                                       $arr["body"] = add_page_info_to_body(html2bbcode($single_conv->object->object->content));
-                               else
-                                       $arr["body"] = add_page_info_to_body(html2bbcode($single_conv->object->content));
+                                       $arr["created"] = $single_conv->object->published;
+                                       $arr["edited"] = $single_conv->object->published;
 
-                               $arr["plink"] = $plink;
+                                       $arr["author-name"] = $single_conv->object->actor->displayName;
+                                       if ($arr["owner-name"] == '') {
+                                               $arr["author-name"] = $single_conv->object->actor->contact->displayName;
+                                       }
+                                       $arr["author-link"] = $single_conv->object->actor->url;
+                                       $arr["author-avatar"] = Probe::fixAvatar($single_conv->object->actor->image->url, $arr["author-link"]);
 
-                               $arr["created"] = $single_conv->object->published;
-                               $arr["edited"] = $single_conv->object->published;
+                                       $arr["app"] = $single_conv->object->provider->displayName."#";
+                                       //$arr["verb"] = $single_conv->object->verb;
 
-                               $arr["author-name"] = $single_conv->object->actor->displayName;
-                               if ($arr["owner-name"] == '') {
-                                       $arr["author-name"] = $single_conv->object->actor->contact->displayName;
+                                       $arr["location"] = $single_conv->object->location->displayName;
+                                       $arr["coord"] = trim($single_conv->object->location->lat." ".$single_conv->object->location->lon);
                                }
-                               $arr["author-link"] = $single_conv->object->actor->url;
-                               $arr["author-avatar"] = self::fix_avatar($single_conv->object->actor->image->url, $arr["author-link"]);
-
-                               $arr["app"] = $single_conv->object->provider->displayName."#";
-                               //$arr["verb"] = $single_conv->object->verb;
-
-                               $arr["location"] = $single_conv->object->location->displayName;
-                               $arr["coord"] = trim($single_conv->object->location->lat." ".$single_conv->object->location->lon);
                        }
 
                        if ($arr["location"] == "")
@@ -1228,27 +1280,20 @@ class ostatus {
                                unset($arr["coord"]);
 
                        // Copy fields from given item array
-                       if (isset($item["uri"]) AND (($item["uri"] == $arr["uri"]) OR ($item["uri"] ==  $single_conv->id))) {
-                               $copy_fields = array("owner-name", "owner-link", "owner-avatar", "author-name", "author-link", "author-avatar",
-                                                       "gravity", "body", "object-type", "object", "verb", "created", "edited", "coord", "tag",
-                                                       "title", "attach", "app", "type", "location", "contact-id", "uri");
-                               foreach ($copy_fields AS $field)
-                                       if (isset($item[$field]))
-                                               $arr[$field] = $item[$field];
-
+                       if (isset($item["uri"]) && (($item["uri"] == $arr["uri"]) || ($item["uri"] ==  $single_conv->id))) {
+                               logger('Use stored item array for item with URI '.$item["uri"], LOGGER_DEBUG);
+                               $newitem = item_store($item);
+                               $item = array();
+                               $item_stored = $newitem;
+                       } else {
+                               $newitem = item_store($arr);
                        }
 
-                       $newitem = item_store($arr);
                        if (!$newitem) {
                                logger("Item wasn't stored ".print_r($arr, true), LOGGER_DEBUG);
                                continue;
                        }
 
-                       if (isset($item["uri"]) AND ($item["uri"] == $arr["uri"])) {
-                               $item = array();
-                               $item_stored = $newitem;
-                       }
-
                        logger('Stored new item '.$plink.' for parent '.$arr["parent-uri"].' under id '.$newitem, LOGGER_DEBUG);
 
                        // Add the conversation entry (but don't fetch the whole conversation)
@@ -1265,7 +1310,7 @@ class ostatus {
                        }
                }
 
-               if (($item_stored < 0) AND (count($item) > 0)) {
+               if (($item_stored < 0) && (count($item) > 0)) {
 
                        if (get_config('system','ostatus_full_threads')) {
                                $details = self::get_actor_details($item["owner-link"], $uid, $item["contact-id"]);
@@ -1282,7 +1327,7 @@ class ostatus {
                        }
                }
 
-               return($item_stored);
+               return $item_stored;
        }
 
        /**
@@ -1291,7 +1336,7 @@ class ostatus {
         * @param integer $itemid The id of the item
         * @param string $conversation_url The uri of the conversation
         */
-       private function store_conversation($itemid, $conversation_url) {
+       private static function store_conversation($itemid, $conversation_url) {
 
                $conversation_url = self::convert_href($conversation_url);
 
@@ -1319,22 +1364,22 @@ class ostatus {
         *
         * @return string The guid if the post is a reshare
         */
-       private function get_reshared_guid($item) {
+       private static function get_reshared_guid($item) {
                $body = trim($item["body"]);
 
                // Skip if it isn't a pure repeated messages
                // Does it start with a share?
                if (strpos($body, "[share") > 0)
-                       return("");
+                       return "";
 
                // Does it end with a share?
                if (strlen($body) > (strrpos($body, "[/share]") + 8))
-                       return("");
+                       return "";
 
                $attributes = preg_replace("/\[share(.*?)\]\s?(.*?)\s?\[\/share\]\s?/ism","$1",$body);
                // Skip if there is no shared message in there
                if ($body == $attributes)
-                       return(false);
+                       return false;
 
                $guid = "";
                preg_match("/guid='(.*?)'/ism", $attributes, $matches);
@@ -1355,7 +1400,7 @@ class ostatus {
         *
         * @return string The cleaned body
         */
-       private function format_picture_post($body) {
+       private static function format_picture_post($body) {
                $siteinfo = get_attached_data($body);
 
                if (($siteinfo["type"] == "photo")) {
@@ -1390,7 +1435,7 @@ class ostatus {
         *
         * @return object header root element
         */
-       private function add_header($doc, $owner) {
+       private static function add_header($doc, $owner) {
 
                $a = get_app();
 
@@ -1404,10 +1449,11 @@ class ostatus {
                $root->setAttribute("xmlns:poco", NAMESPACE_POCO);
                $root->setAttribute("xmlns:ostatus", NAMESPACE_OSTATUS);
                $root->setAttribute("xmlns:statusnet", NAMESPACE_STATUSNET);
+               $root->setAttribute("xmlns:mastodon", NAMESPACE_MASTODON);
 
                $attributes = array("uri" => "https://friendi.ca", "version" => FRIENDICA_VERSION."-".DB_UPDATE_VERSION);
                xml::add_element($doc, $root, "generator", FRIENDICA_PLATFORM, $attributes);
-               xml::add_element($doc, $root, "id", App::get_baseurl()."/profile/".$owner["nick"]);
+               xml::add_element($doc, $root, "id", System::baseUrl()."/profile/".$owner["nick"]);
                xml::add_element($doc, $root, "title", sprintf("%s timeline", $owner["name"]));
                xml::add_element($doc, $root, "subtitle", sprintf("Updates from %s on %s", $owner["name"], $a->config["sitename"]));
                xml::add_element($doc, $root, "logo", $owner["photo"]);
@@ -1420,23 +1466,23 @@ class ostatus {
                xml::add_element($doc, $root, "link", "", $attributes);
 
                /// @TODO We have to find out what this is
-               /// $attributes = array("href" => App::get_baseurl()."/sup",
+               /// $attributes = array("href" => System::baseUrl()."/sup",
                ///             "rel" => "http://api.friendfeed.com/2008/03#sup",
                ///             "type" => "application/json");
                /// xml::add_element($doc, $root, "link", "", $attributes);
 
-               self::hublinks($doc, $root);
+               self::hublinks($doc, $root, $owner["nick"]);
 
-               $attributes = array("href" => App::get_baseurl()."/salmon/".$owner["nick"], "rel" => "salmon");
+               $attributes = array("href" => System::baseUrl()."/salmon/".$owner["nick"], "rel" => "salmon");
                xml::add_element($doc, $root, "link", "", $attributes);
 
-               $attributes = array("href" => App::get_baseurl()."/salmon/".$owner["nick"], "rel" => "http://salmon-protocol.org/ns/salmon-replies");
+               $attributes = array("href" => System::baseUrl()."/salmon/".$owner["nick"], "rel" => "http://salmon-protocol.org/ns/salmon-replies");
                xml::add_element($doc, $root, "link", "", $attributes);
 
-               $attributes = array("href" => App::get_baseurl()."/salmon/".$owner["nick"], "rel" => "http://salmon-protocol.org/ns/salmon-mention");
+               $attributes = array("href" => System::baseUrl()."/salmon/".$owner["nick"], "rel" => "http://salmon-protocol.org/ns/salmon-mention");
                xml::add_element($doc, $root, "link", "", $attributes);
 
-               $attributes = array("href" => App::get_baseurl()."/api/statuses/user_timeline/".$owner["nick"].".atom",
+               $attributes = array("href" => System::baseUrl()."/api/statuses/user_timeline/".$owner["nick"].".atom",
                                "rel" => "self", "type" => "application/atom+xml");
                xml::add_element($doc, $root, "link", "", $attributes);
 
@@ -1449,23 +1495,9 @@ class ostatus {
         * @param object $doc XML document
         * @param object $root XML root element where the hub links are added
         */
-       public static function hublinks($doc, $root) {
-               $hub = get_config('system','huburl');
-
-               $hubxml = '';
-               if(strlen($hub)) {
-                       $hubs = explode(',', $hub);
-                       if(count($hubs)) {
-                               foreach($hubs as $h) {
-                                       $h = trim($h);
-                                       if(! strlen($h))
-                                               continue;
-                                       if ($h === '[internal]')
-                                               $h = App::get_baseurl() . '/pubsubhubbub';
-                                       xml::add_element($doc, $root, "link", "", array("href" => $h, "rel" => "hub"));
-                               }
-                       }
-               }
+       public static function hublinks($doc, $root, $nick) {
+               $h = System::baseUrl() . '/pubsubhubbub/'.$nick;
+               xml::add_element($doc, $root, "link", "", array("href" => $h, "rel" => "hub"));
        }
 
        /**
@@ -1475,7 +1507,7 @@ class ostatus {
         * @param object $root XML root element where the hub links are added
         * @param array $item Data of the item that is to be posted
         */
-       private function get_attachment($doc, $root, $item) {
+       private static function get_attachment($doc, $root, $item) {
                $o = "";
                $siteinfo = get_attached_data($item["body"]);
 
@@ -1500,7 +1532,7 @@ class ostatus {
                                break;
                }
 
-               if (($siteinfo["type"] != "photo") AND isset($siteinfo["image"])) {
+               if (!Config::get('system', 'ostatus_not_attach_preview') && ($siteinfo["type"] != "photo") && isset($siteinfo["image"])) {
                        $imgdata = get_photo_info($siteinfo["image"]);
                        $attributes = array("rel" => "enclosure",
                                        "href" => $siteinfo["image"],
@@ -1540,16 +1572,18 @@ class ostatus {
         *
         * @return object author element
         */
-       private function add_author($doc, $owner) {
+       private static function add_author($doc, $owner) {
 
-               $r = q("SELECT `homepage` FROM `profile` WHERE `uid` = %d AND `is-default` LIMIT 1", intval($owner["uid"]));
-               if ($r)
+               $r = q("SELECT `homepage`, `publish` FROM `profile` WHERE `uid` = %d AND `is-default` LIMIT 1", intval($owner["uid"]));
+               if (dbm::is_result($r)) {
                        $profile = $r[0];
-
+               }
                $author = $doc->createElement("author");
+               xml::add_element($doc, $author, "id", $owner["url"]);
                xml::add_element($doc, $author, "activity:object-type", ACTIVITY_OBJ_PERSON);
                xml::add_element($doc, $author, "uri", $owner["url"]);
-               xml::add_element($doc, $author, "name", $owner["name"]);
+               xml::add_element($doc, $author, "name", $owner["nick"]);
+               xml::add_element($doc, $author, "email", $owner["addr"]);
                xml::add_element($doc, $author, "summary", bbcode($owner["about"], false, false, 7));
 
                $attributes = array("rel" => "alternate", "type" => "text/html", "href" => $owner["url"]);
@@ -1592,10 +1626,13 @@ class ostatus {
                }
 
                if (count($profile)) {
-                       xml::add_element($doc, $author, "followers", "", array("url" => App::get_baseurl()."/viewcontacts/".$owner["nick"]));
+                       xml::add_element($doc, $author, "followers", "", array("url" => System::baseUrl()."/viewcontacts/".$owner["nick"]));
                        xml::add_element($doc, $author, "statusnet:profile_info", "", array("local_id" => $owner["uid"]));
                }
 
+               if ($profile["publish"]) {
+                       xml::add_element($doc, $author, "mastodon:scope", "public");
+               }
                return $author;
        }
 
@@ -1642,7 +1679,7 @@ class ostatus {
         *
         * @return object Entry element
         */
-       private function entry($doc, $item, $owner, $toplevel = false) {
+       private static function entry($doc, $item, $owner, $toplevel = false) {
                $repeated_guid = self::get_reshared_guid($item);
                if ($repeated_guid != "")
                        $xml = self::reshare_entry($doc, $item, $owner, $repeated_guid, $toplevel);
@@ -1667,7 +1704,7 @@ class ostatus {
         *
         * @return object Source element
         */
-       private function source_entry($doc, $contact) {
+       private static function source_entry($doc, $contact) {
                $source = $doc->createElement("source");
                xml::add_element($doc, $source, "id", $contact["poll"]);
                xml::add_element($doc, $source, "title", $contact["name"]);
@@ -1691,26 +1728,26 @@ class ostatus {
         *
         * @return array Contact array
         */
-       private function contact_entry($url, $owner) {
+       private static function contact_entry($url, $owner) {
 
                $r = q("SELECT * FROM `contact` WHERE `nurl` = '%s' AND `uid` IN (0, %d) ORDER BY `uid` DESC LIMIT 1",
                        dbesc(normalise_link($url)), intval($owner["uid"]));
-               if ($r) {
+               if (dbm::is_result($r)) {
                        $contact = $r[0];
                        $contact["uid"] = -1;
                }
 
-               if (!$r) {
+               if (!dbm::is_result($r)) {
                        $r = q("SELECT * FROM `gcontact` WHERE `nurl` = '%s' LIMIT 1",
                                dbesc(normalise_link($url)));
-                       if ($r) {
+                       if (dbm::is_result($r)) {
                                $contact = $r[0];
                                $contact["uid"] = -1;
                                $contact["success_update"] = $contact["updated"];
                        }
                }
 
-               if (!$r)
+               if (!dbm::is_result($r))
                        $contact = owner;
 
                if (!isset($contact["poll"])) {
@@ -1738,9 +1775,9 @@ class ostatus {
         *
         * @return object Entry element
         */
-       private function reshare_entry($doc, $item, $owner, $repeated_guid, $toplevel) {
+       private static function reshare_entry($doc, $item, $owner, $repeated_guid, $toplevel) {
 
-               if (($item["id"] != $item["parent"]) AND (normalise_link($item["author-link"]) != normalise_link($owner["url"]))) {
+               if (($item["id"] != $item["parent"]) && (normalise_link($item["author-link"]) != normalise_link($owner["url"]))) {
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
                }
 
@@ -1749,11 +1786,11 @@ class ostatus {
                $r = q("SELECT * FROM `item` WHERE `uid` = %d AND `guid` = '%s' AND NOT `private` AND `network` IN ('%s', '%s', '%s') LIMIT 1",
                        intval($owner["uid"]), dbesc($repeated_guid),
                        dbesc(NETWORK_DFRN), dbesc(NETWORK_DIASPORA), dbesc(NETWORK_OSTATUS));
-               if ($r)
+               if (dbm::is_result($r)) {
                        $repeated_item = $r[0];
-               else
+               } else {
                        return false;
-
+               }
                $contact = self::contact_entry($repeated_item['author-link'], $owner);
 
                $parent_item = (($item['thr-parent']) ? $item['thr-parent'] : $item['parent-uri']);
@@ -1769,7 +1806,7 @@ class ostatus {
                self::entry_content($doc, $as_object, $repeated_item, $owner, "", "", false);
 
                $author = self::add_author($doc, $contact);
-                $as_object->appendChild($author);
+               $as_object->appendChild($author);
 
                $as_object2 = $doc->createElement("activity:object");
 
@@ -1804,9 +1841,9 @@ class ostatus {
         *
         * @return object Entry element with "like"
         */
-       private function like_entry($doc, $item, $owner, $toplevel) {
+       private static function like_entry($doc, $item, $owner, $toplevel) {
 
-               if (($item["id"] != $item["parent"]) AND (normalise_link($item["author-link"]) != normalise_link($owner["url"]))) {
+               if (($item["id"] != $item["parent"]) && (normalise_link($item["author-link"]) != normalise_link($owner["url"]))) {
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
                }
 
@@ -1841,7 +1878,7 @@ class ostatus {
         *
         * @return object author element
         */
-       private function add_person_object($doc, $owner, $contact) {
+       private static function add_person_object($doc, $owner, $contact) {
 
                $object = $doc->createElement("activity:object");
                xml::add_element($doc, $object, "activity:object-type", ACTIVITY_OBJ_PERSON);
@@ -1887,7 +1924,7 @@ class ostatus {
         *
         * @return object Entry element
         */
-       private function follow_entry($doc, $item, $owner, $toplevel) {
+       private static function follow_entry($doc, $item, $owner, $toplevel) {
 
                $item["id"] = $item["parent"] = 0;
                $item["created"] = $item["edited"] = date("c");
@@ -1949,9 +1986,9 @@ class ostatus {
         *
         * @return object Entry element
         */
-       private function note_entry($doc, $item, $owner, $toplevel) {
+       private static function note_entry($doc, $item, $owner, $toplevel) {
 
-               if (($item["id"] != $item["parent"]) AND (normalise_link($item["author-link"]) != normalise_link($owner["url"]))) {
+               if (($item["id"] != $item["parent"]) && (normalise_link($item["author-link"]) != normalise_link($owner["url"]))) {
                        logger("OStatus entry is from author ".$owner["url"]." - not from ".$item["author-link"].". Quitting.", LOGGER_DEBUG);
                }
 
@@ -1976,7 +2013,7 @@ class ostatus {
         *
         * @return string The title for the element
         */
-       private function entry_header($doc, &$entry, $owner, $toplevel) {
+       private static function entry_header($doc, &$entry, $owner, $toplevel) {
                /// @todo Check if this title stuff is really needed (I guess not)
                if (!$toplevel) {
                        $entry = $doc->createElement("entry");
@@ -1991,6 +2028,7 @@ class ostatus {
                        $entry->setAttribute("xmlns:poco", NAMESPACE_POCO);
                        $entry->setAttribute("xmlns:ostatus", NAMESPACE_OSTATUS);
                        $entry->setAttribute("xmlns:statusnet", NAMESPACE_STATUSNET);
+                       $entry->setAttribute("xmlns:mastodon", NAMESPACE_MASTODON);
 
                        $author = self::add_author($doc, $owner);
                        $entry->appendChild($author);
@@ -2011,7 +2049,7 @@ class ostatus {
         * @param string $verb The activity verb
         * @param bool $complete Add the "status_net" element?
         */
-       private function entry_content($doc, $entry, $item, $owner, $title, $verb = "", $complete = true) {
+       private static function entry_content($doc, $entry, $item, $owner, $title, $verb = "", $complete = true) {
 
                if ($verb == "")
                        $verb = self::construct_verb($item);
@@ -2029,9 +2067,9 @@ class ostatus {
                xml::add_element($doc, $entry, "content", $body, array("type" => "html"));
 
                xml::add_element($doc, $entry, "link", "", array("rel" => "alternate", "type" => "text/html",
-                                                               "href" => App::get_baseurl()."/display/".$item["guid"]));
+                                                               "href" => System::baseUrl()."/display/".$item["guid"]));
 
-               if ($complete AND ($item["id"] > 0))
+               if ($complete && ($item["id"] > 0))
                        xml::add_element($doc, $entry, "status_net", "", array("notice_id" => $item["id"]));
 
                xml::add_element($doc, $entry, "activity:verb", $verb);
@@ -2049,53 +2087,68 @@ class ostatus {
         * @param array $owner Contact data of the poster
         * @param $complete
         */
-       private function entry_footer($doc, $entry, $item, $owner, $complete = true) {
+       private static function entry_footer($doc, $entry, $item, $owner, $complete = true) {
 
                $mentioned = array();
 
-               if (($item['parent'] != $item['id']) OR ($item['parent-uri'] !== $item['uri']) OR (($item['thr-parent'] !== '') AND ($item['thr-parent'] !== $item['uri']))) {
+               if (($item['parent'] != $item['id']) || ($item['parent-uri'] !== $item['uri']) || (($item['thr-parent'] !== '') && ($item['thr-parent'] !== $item['uri']))) {
                        $parent = q("SELECT `guid`, `author-link`, `owner-link` FROM `item` WHERE `id` = %d", intval($item["parent"]));
                        $parent_item = (($item['thr-parent']) ? $item['thr-parent'] : $item['parent-uri']);
 
+                       $thrparent = q("SELECT `guid`, `author-link`, `owner-link`, `plink` FROM `item` WHERE `uid` = %d AND `uri` = '%s'",
+                                       intval($owner["uid"]),
+                                       dbesc($parent_item));
+                       if ($thrparent) {
+                               $mentioned[$thrparent[0]["author-link"]] = $thrparent[0]["author-link"];
+                               $mentioned[$thrparent[0]["owner-link"]] = $thrparent[0]["owner-link"];
+                               $parent_plink = $thrparent[0]["plink"];
+                       } else {
+                               $mentioned[$parent[0]["author-link"]] = $parent[0]["author-link"];
+                               $mentioned[$parent[0]["owner-link"]] = $parent[0]["owner-link"];
+                               $parent_plink = System::baseUrl()."/display/".$parent[0]["guid"];
+                       }
+
                        $attributes = array(
                                        "ref" => $parent_item,
-                                       "type" => "text/html",
-                                       "href" => App::get_baseurl()."/display/".$parent[0]["guid"]);
+                                       "href" => $parent_plink);
                        xml::add_element($doc, $entry, "thr:in-reply-to", "", $attributes);
 
                        $attributes = array(
                                        "rel" => "related",
-                                       "href" => App::get_baseurl()."/display/".$parent[0]["guid"]);
+                                       "href" => $parent_plink);
                        xml::add_element($doc, $entry, "link", "", $attributes);
+               }
 
-                       $mentioned[$parent[0]["author-link"]] = $parent[0]["author-link"];
-                       $mentioned[$parent[0]["owner-link"]] = $parent[0]["owner-link"];
+               if (intval($item["parent"]) > 0) {
+                       $conversation_href = System::baseUrl()."/display/".$owner["nick"]."/".$item["parent"];
+                       $conversation_uri = $conversation_href;
 
-                       $thrparent = q("SELECT `guid`, `author-link`, `owner-link` FROM `item` WHERE `uid` = %d AND `uri` = '%s'",
-                                       intval($owner["uid"]),
-                                       dbesc($parent_item));
-                       if ($thrparent) {
-                               $mentioned[$thrparent[0]["author-link"]] = $thrparent[0]["author-link"];
-                               $mentioned[$thrparent[0]["owner-link"]] = $thrparent[0]["owner-link"];
+                       if (isset($parent_item)) {
+                               $r = dba::fetch_first("SELECT `conversation-uri`, `conversation-href` FROM `conversation` WHERE `item-uri` = ?", $parent_item);
+                               if (dbm::is_result($r)) {
+                                       if ($r['conversation-uri'] != '') {
+                                               $conversation_uri = $r['conversation-uri'];
+                                       }
+                                       if ($r['conversation-href'] != '') {
+                                               $conversation_href = $r['conversation-href'];
+                                       }
+                               }
                        }
-               }
 
-               if (intval($item["parent"]) > 0) {
-                       $conversation = App::get_baseurl()."/display/".$owner["nick"]."/".$item["parent"];
-                       xml::add_element($doc, $entry, "link", "", array("rel" => "ostatus:conversation", "href" => $conversation));
+                       xml::add_element($doc, $entry, "link", "", array("rel" => "ostatus:conversation", "href" => $conversation_href));
 
                        $attributes = array(
-                                       "href" => $conversation,
+                                       "href" => $conversation_href,
                                        "local_id" => $item["parent"],
-                                       "ref" => $conversation);
+                                       "ref" => $conversation_uri);
 
-                       xml::add_element($doc, $entry, "ostatus:conversation", $conversation, $attributes);
+                       xml::add_element($doc, $entry, "ostatus:conversation", $conversation_uri, $attributes);
                }
 
                $tags = item_getfeedtags($item);
 
-               if(count($tags))
-                       foreach($tags as $t)
+               if (count($tags))
+                       foreach ($tags as $t)
                                if ($t[0] == "@")
                                        $mentioned[$t[1]] = $t[1];
 
@@ -2111,7 +2164,7 @@ class ostatus {
                        $r = q("SELECT `forum`, `prv` FROM `contact` WHERE `uid` = %d AND `nurl` = '%s'",
                                intval($owner["uid"]),
                                dbesc(normalise_link($mention)));
-                       if ($r[0]["forum"] OR $r[0]["prv"])
+                       if ($r[0]["forum"] || $r[0]["prv"])
                                xml::add_element($doc, $entry, "link", "", array("rel" => "mentioned",
                                                                                        "ostatus:object-type" => ACTIVITY_OBJ_GROUP,
                                                                                        "href" => $mention));
@@ -2127,16 +2180,17 @@ class ostatus {
                        xml::add_element($doc, $entry, "link", "", array("rel" => "mentioned",
                                                                        "ostatus:object-type" => "http://activitystrea.ms/schema/1.0/collection",
                                                                        "href" => "http://activityschema.org/collection/public"));
+                       xml::add_element($doc, $entry, "mastodon:scope", "public");
                }
 
-               if(count($tags))
-                       foreach($tags as $t)
+               if (count($tags))
+                       foreach ($tags as $t)
                                if ($t[0] != "@")
                                        xml::add_element($doc, $entry, "category", "", array("term" => $t[2]));
 
                self::get_attachment($doc, $entry, $item);
 
-               if ($complete AND ($item["id"] > 0)) {
+               if ($complete && ($item["id"] > 0)) {
                        $app = $item["app"];
                        if ($app == "")
                                $app = "web";
@@ -2156,25 +2210,40 @@ class ostatus {
        /**
         * @brief Creates the XML feed for a given nickname
         *
-        * @param app $a The application class
+        * @param App $a The application class
         * @param string $owner_nick Nickname of the feed owner
         * @param string $last_update Date of the last update
+        * @param integer $max_items Number of maximum items to fetch
         *
         * @return string XML feed
         */
-       public static function feed(App $a, $owner_nick, $last_update) {
+       public static function feed(App $a, $owner_nick, &$last_update, $max_items = 300) {
+               $stamp = microtime(true);
+
+               $cachekey = "ostatus:feed:".$owner_nick.":".$last_update;
+
+               $previous_created = $last_update;
+
+               $result = Cache::get($cachekey);
+               if (!is_null($result)) {
+                       logger('Feed duration: '.number_format(microtime(true) - $stamp, 3).' - '.$owner_nick.' - '.$previous_created.' (cached)', LOGGER_DEBUG);
+                       $last_update = $result['last_update'];
+                       return $result['feed'];
+               }
 
                $r = q("SELECT `contact`.*, `user`.`nickname`, `user`.`timezone`, `user`.`page-flags`
                                FROM `contact` INNER JOIN `user` ON `user`.`uid` = `contact`.`uid`
                                WHERE `contact`.`self` AND `user`.`nickname` = '%s' LIMIT 1",
                                dbesc($owner_nick));
-               if (!$r)
+               if (!dbm::is_result($r)) {
                        return;
+               }
 
                $owner = $r[0];
 
-               if(!strlen($last_update))
+               if (!strlen($last_update)) {
                        $last_update = 'now -30 days';
+               }
 
                $check_date = datetime_convert('UTC','UTC',$last_update,'Y-m-d H:i:s');
                $authorid = get_contact($owner["url"], 0);
@@ -2185,44 +2254,36 @@ class ostatus {
                                        `item`.`author-id` = %d AND `item`.`created` > '%s' AND
                                        NOT `item`.`deleted` AND NOT `item`.`private` AND
                                        `thread`.`network` IN ('%s', '%s')
-                               ORDER BY `item`.`created` DESC LIMIT 300",
+                               ORDER BY `item`.`created` DESC LIMIT %d",
                                intval($owner["uid"]), intval($owner["id"]),
                                intval($authorid), dbesc($check_date),
-                               dbesc(NETWORK_OSTATUS), dbesc(NETWORK_DFRN));
+                               dbesc(NETWORK_OSTATUS), dbesc(NETWORK_DFRN), intval($max_items));
 
-/*             2016-10-23: The old query will be kept until we are sure that the query above is a good and fast replacement
-
-               $items = q("SELECT `item`.*, `item`.`id` AS `item_id` FROM `item`
-                               STRAIGHT_JOIN `thread` ON `thread`.`iid` = `item`.`parent`
-                               LEFT JOIN `item` AS `thritem` ON `thritem`.`uri`=`item`.`thr-parent` AND `thritem`.`uid`=`item`.`uid`
-                               WHERE `item`.`uid` = %d AND `item`.`received` > '%s' AND NOT `item`.`private` AND NOT `item`.`deleted`
-                                       AND `item`.`allow_cid` = '' AND `item`.`allow_gid` = '' AND `item`.`deny_cid`  = '' AND `item`.`deny_gid`  = ''
-                                       AND ((`item`.`wall` AND (`item`.`parent` = `item`.`id`))
-                                               OR (`item`.`network` = '%s' AND ((`thread`.`network` IN ('%s', '%s')) OR (`thritem`.`network` IN ('%s', '%s')))) AND `thread`.`mention`)
-                                       AND ((`item`.`owner-link` IN ('%s', '%s') AND (`item`.`parent` = `item`.`id`))
-                                               OR (`item`.`author-link` IN ('%s', '%s')))
-                               ORDER BY `item`.`id` DESC
-                               LIMIT 0, 300",
-                               intval($owner["uid"]), dbesc($check_date), dbesc(NETWORK_DFRN),
-                               //dbesc(NETWORK_OSTATUS), dbesc(NETWORK_OSTATUS),
-                               //dbesc(NETWORK_OSTATUS), dbesc(NETWORK_OSTATUS),
-                               dbesc(NETWORK_OSTATUS), dbesc(NETWORK_DFRN),
-                               dbesc(NETWORK_OSTATUS), dbesc(NETWORK_DFRN),
-                               dbesc($owner["nurl"]), dbesc(str_replace("http://", "https://", $owner["nurl"])),
-                               dbesc($owner["nurl"]), dbesc(str_replace("http://", "https://", $owner["nurl"]))
-                       );
-*/
                $doc = new DOMDocument('1.0', 'utf-8');
                $doc->formatOutput = true;
 
                $root = self::add_header($doc, $owner);
 
                foreach ($items AS $item) {
+                       if (Config::get('system', 'ostatus_debug')) {
+                               $item['body'] .= '🍼';
+                       }
                        $entry = self::entry($doc, $item, $owner);
                        $root->appendChild($entry);
+
+                       if ($last_update < $item['created']) {
+                               $last_update = $item['created'];
+                       }
                }
 
-               return(trim($doc->saveXML()));
+               $feeddata = trim($doc->saveXML());
+
+               $msg = array('feed' => $feeddata, 'last_update' => $last_update);
+               Cache::set($cachekey, $msg, CACHE_QUARTER_HOUR);
+
+               logger('Feed duration: '.number_format(microtime(true) - $stamp, 3).' - '.$owner_nick.' - '.$previous_created, LOGGER_DEBUG);
+
+               return $feeddata;
        }
 
        /**
@@ -2238,11 +2299,14 @@ class ostatus {
                $doc = new DOMDocument('1.0', 'utf-8');
                $doc->formatOutput = true;
 
+               if (Config::get('system', 'ostatus_debug')) {
+                       $item['body'] .= '🐟';
+               }
+
                $entry = self::entry($doc, $item, $owner, true);
 
                $doc->appendChild($entry);
 
-               return(trim($doc->saveXML()));
+               return trim($doc->saveXML());
        }
 }
-?>