]> git.mxchange.org Git - friendica.git/blobdiff - include/poller.php
Merge pull request #2855 from annando/1610-worker-passing-slow
[friendica.git] / include / poller.php
index 805e0fd5e92b3cb5db5409274fde410b04d35c00..c1761e302db6814dbb7c26d34068d0ef02dc03e6 100644 (file)
@@ -10,8 +10,10 @@ if (!file_exists("boot.php") AND (sizeof($_SERVER["argv"]) != 0)) {
        chdir($directory);
 }
 
+use \Friendica\Core\Config;
+use \Friendica\Core\PConfig;
+
 require_once("boot.php");
-require_once("dbm.php");
 
 function poller_run(&$argv, &$argc){
        global $a, $db;
@@ -27,19 +29,16 @@ function poller_run(&$argv, &$argc){
                unset($db_host, $db_user, $db_pass, $db_data);
        };
 
-       $max_processes = get_config('system', 'max_processes_backend');
-       if (intval($max_processes) == 0)
-               $max_processes = 5;
+       // Quit when in maintenance
+       if (get_config('system', 'maintenance', true))
+               return;
 
-       $processlist = dbm::processlist();
-       if ($processlist["list"] != "") {
-               logger("Processcheck: Processes: ".$processlist["amount"]." - Processlist: ".$processlist["list"], LOGGER_DEBUG);
+       $a->start_process();
 
-               if ($processlist["amount"] > $max_processes) {
-                       logger("Processcheck: Maximum number of processes for backend tasks (".$max_processes.") reached.", LOGGER_DEBUG);
-                       return;
-               }
-       }
+       $mypid = getmypid();
+
+       if ($a->max_processes_reached())
+               return;
 
        if (poller_max_connections_reached())
                return;
@@ -48,17 +47,17 @@ function poller_run(&$argv, &$argc){
                return;
 
        // Checking the number of workers
-       if (poller_too_much_workers(1)) {
+       if (poller_too_much_workers()) {
                poller_kill_stale_workers();
                return;
        }
 
        if(($argc <= 1) OR ($argv[1] != "no_cron")) {
                // Run the cron job that calls all other jobs
-               proc_run("php","include/cron.php");
+               proc_run(PRIORITY_MEDIUM, "include/cron.php");
 
                // Run the cronhooks job separately from cron for being able to use a different timing
-               proc_run("php","include/cronhooks.php");
+               proc_run(PRIORITY_MEDIUM, "include/cronhooks.php");
 
                // Cleaning dead processes
                poller_kill_stale_workers();
@@ -67,43 +66,46 @@ function poller_run(&$argv, &$argc){
                sleep(4);
 
        // Checking number of workers
-       if (poller_too_much_workers(2))
+       if (poller_too_much_workers())
                return;
 
+       $cooldown = Config::get("system", "worker_cooldown", 0);
+
        $starttime = time();
 
-       while ($r = q("SELECT * FROM `workerqueue` WHERE `executed` = '0000-00-00 00:00:00' ORDER BY `created` LIMIT 1")) {
+       while ($r = poller_worker_process()) {
 
-               // Log the type of database processes
-               $processlist = dbm::processlist();
-               if ($processlist["amount"] != "") {
-                       logger("Processcheck: Processes: ".$processlist["amount"]." - Processlist: ".$processlist["list"], LOGGER_DEBUG);
+               // Quit when in maintenance
+               if (get_config('system', 'maintenance', true))
+                       return;
 
-                       if ($processlist["amount"] > $max_processes) {
-                               logger("Processcheck: Maximum number of processes for backend tasks (".$max_processes.") reached.", LOGGER_DEBUG);
-                               return;
-                       }
-               }
+               // Constantly check the number of parallel database processes
+               if ($a->max_processes_reached())
+                       return;
 
                // Constantly check the number of available database connections to let the frontend be accessible at any time
                if (poller_max_connections_reached())
                        return;
 
                // Count active workers and compare them with a maximum value that depends on the load
-               if (poller_too_much_workers(3))
+               if (poller_too_much_workers())
                        return;
 
                q("UPDATE `workerqueue` SET `executed` = '%s', `pid` = %d WHERE `id` = %d AND `executed` = '0000-00-00 00:00:00'",
                        dbesc(datetime_convert()),
-                       intval(getmypid()),
+                       intval($mypid),
                        intval($r[0]["id"]));
 
                // Assure that there are no tasks executed twice
-               $id = q("SELECT `id` FROM `workerqueue` WHERE `id` = %d AND `pid` = %d",
-                       intval($r[0]["id"]),
-                       intval(getmypid()));
+               $id = q("SELECT `pid`, `executed` FROM `workerqueue` WHERE `id` = %d", intval($r[0]["id"]));
                if (!$id) {
-                       logger("Queue item ".$r[0]["id"]." was executed multiple times - skip this execution", LOGGER_DEBUG);
+                       logger("Queue item ".$r[0]["id"]." vanished - skip this execution", LOGGER_DEBUG);
+                       continue;
+               } elseif ((strtotime($id[0]["executed"]) <= 0) OR ($id[0]["pid"] == 0)) {
+                       logger("Entry for queue item ".$r[0]["id"]." wasn't stored - we better stop here", LOGGER_DEBUG);
+                       return;
+               } elseif ($id[0]["pid"] != $mypid) {
+                       logger("Queue item ".$r[0]["id"]." is to be executed by process ".$id[0]["pid"]." and not by me (".$mypid.") - skip this execution", LOGGER_DEBUG);
                        continue;
                }
 
@@ -122,13 +124,26 @@ function poller_run(&$argv, &$argc){
 
                require_once($include);
 
-               $funcname=str_replace(".php", "", basename($argv[0]))."_run";
+               $funcname = str_replace(".php", "", basename($argv[0]))."_run";
 
                if (function_exists($funcname)) {
-                       logger("Process ".getmypid()." - ID ".$r[0]["id"].": ".$funcname." ".$r[0]["parameter"]);
+                       logger("Process ".$mypid." - Prio ".$r[0]["priority"]." - ID ".$r[0]["id"].": ".$funcname." ".$r[0]["parameter"]);
+
+                       // For better logging create a new process id for every worker call
+                       // But preserve the old one for the worker
+                       $old_process_id = $a->process_id;
+                       $a->process_id = uniqid("wrk", true);
+
                        $funcname($argv, $argc);
 
-                       logger("Process ".getmypid()." - ID ".$r[0]["id"].": ".$funcname." - done");
+                       $a->process_id = $old_process_id;
+
+                       if ($cooldown > 0) {
+                               logger("Process ".$mypid." - Prio ".$r[0]["priority"]." - ID ".$r[0]["id"].": ".$funcname." - in cooldown for ".$cooldown." seconds");
+                               sleep($cooldown);
+                       }
+
+                       logger("Process ".$mypid." - Prio ".$r[0]["priority"]." - ID ".$r[0]["id"].": ".$funcname." - done");
 
                        q("DELETE FROM `workerqueue` WHERE `id` = %d", intval($r[0]["id"]));
                } else
@@ -226,7 +241,7 @@ function poller_max_connections_reached() {
  *
  */
 function poller_kill_stale_workers() {
-       $r = q("SELECT `pid`, `executed` FROM `workerqueue` WHERE `executed` != '0000-00-00 00:00:00'");
+       $r = q("SELECT `pid`, `executed`, `priority`, `parameter` FROM `workerqueue` WHERE `executed` != '0000-00-00 00:00:00'");
 
        if (!dbm::is_result($r)) {
                // No processing here needed
@@ -239,27 +254,47 @@ function poller_kill_stale_workers() {
                                intval($pid["pid"]));
                else {
                        // Kill long running processes
+
+                       // Check if the priority is in a valid range
+                       if (!in_array($pid["priority"], array(PRIORITY_CRITICAL, PRIORITY_HIGH, PRIORITY_MEDIUM, PRIORITY_LOW, PRIORITY_NEGLIGIBLE)))
+                               $pid["priority"] = PRIORITY_MEDIUM;
+
+                       // Define the maximum durations
+                       $max_duration_defaults = array(PRIORITY_CRITICAL => 360, PRIORITY_HIGH => 10, PRIORITY_MEDIUM => 60, PRIORITY_LOW => 180, PRIORITY_NEGLIGIBLE => 360);
+                       $max_duration = $max_duration_defaults[$pid["priority"]];
+
+                       $argv = json_decode($pid["parameter"]);
+                       $argv[0] = basename($argv[0]);
+
+                       // How long is the process already running?
                        $duration = (time() - strtotime($pid["executed"])) / 60;
-                       if ($duration > 180) {
-                               logger("Worker process ".$pid["pid"]." took more than 3 hours. It will be killed now.");
+                       if ($duration > $max_duration) {
+                               logger("Worker process ".$pid["pid"]." (".implode(" ", $argv).") took more than ".$max_duration." minutes. It will be killed now.");
                                posix_kill($pid["pid"], SIGTERM);
 
-                               // Question: If a process is stale: Should we remove it or should we reschedule it?
-                               // By now we rescheduling it. It's maybe not the wisest decision?
-                               q("UPDATE `workerqueue` SET `executed` = '0000-00-00 00:00:00', `pid` = 0 WHERE `pid` = %d",
+                               // We killed the stale process.
+                               // To avoid a blocking situation we reschedule the process at the beginning of the queue.
+                               // Additionally we are lowering the priority.
+                               q("UPDATE `workerqueue` SET `executed` = '0000-00-00 00:00:00', `created` = '%s',
+                                                       `priority` = %d, `pid` = 0 WHERE `pid` = %d",
+                                       dbesc(datetime_convert()),
+                                       intval(PRIORITY_NEGLIGIBLE),
                                        intval($pid["pid"]));
                        } else
-                               logger("Worker process ".$pid["pid"]." now runs for ".round($duration)." minutes. That's okay.", LOGGER_DEBUG);
+                               logger("Worker process ".$pid["pid"]." (".implode(" ", $argv).") now runs for ".round($duration)." of ".$max_duration." allowed minutes. That's okay.", LOGGER_DEBUG);
                }
 }
 
-function poller_too_much_workers($stage) {
+function poller_too_much_workers() {
+
 
        $queues = get_config("system", "worker_queues");
 
        if ($queues == 0)
                $queues = 4;
 
+       $maxqueues = $queues;
+
        $active = poller_active_workers();
 
        // Decrease the number of workers at higher load
@@ -276,21 +311,152 @@ function poller_too_much_workers($stage) {
                $slope = $maxworkers / pow($maxsysload, $exponent);
                $queues = ceil($slope * pow(max(0, $maxsysload - $load), $exponent));
 
-               logger("Current load stage ".$stage.": ".$load." - maximum: ".$maxsysload." - current queues: ".$active." - maximum: ".$queues, LOGGER_DEBUG);
+               $s = q("SELECT COUNT(*) AS `total` FROM `workerqueue` WHERE `executed` = '0000-00-00 00:00:00'");
+               $entries = $s[0]["total"];
+
+               if (Config::get("system", "worker_fastlane", false) AND ($queues > 0) AND ($entries > 0) AND ($active >= $queues)) {
+                       $s = q("SELECT `priority` FROM `workerqueue` WHERE `executed` = '0000-00-00 00:00:00' ORDER BY `priority` LIMIT 1");
+                       $top_priority = $s[0]["priority"];
+
+                       $s = q("SELECT `id` FROM `workerqueue` WHERE `priority` <= %d AND `executed` != '0000-00-00 00:00:00' LIMIT 1",
+                               intval($top_priority));
+                       $high_running = dbm::is_result($s);
+
+                       if (!$high_running AND ($top_priority > PRIORITY_UNDEFINED) AND ($top_priority < PRIORITY_NEGLIGIBLE)) {
+                               logger("There are jobs with priority ".$top_priority." waiting but none is executed. Open a fastlane.", LOGGER_DEBUG);
+                               $queues = $active + 1;
+                       }
+               }
+
+               // Create a list of queue entries grouped by their priority
+               $running = array(PRIORITY_CRITICAL => 0,
+                               PRIORITY_HIGH => 0,
+                               PRIORITY_MEDIUM => 0,
+                               PRIORITY_LOW => 0,
+                               PRIORITY_NEGLIGIBLE => 0);
+
+               $r = q("SELECT COUNT(*) AS `running`, `priority` FROM `process` INNER JOIN `workerqueue` ON `workerqueue`.`pid` = `process`.`pid` GROUP BY `priority`");
+               if (dbm::is_result($r))
+                       foreach ($r AS $process)
+                               $running[$process["priority"]] = $process["running"];
+
+               $processlist = "";
+               $r = q("SELECT COUNT(*) AS `entries`, `priority` FROM `workerqueue` GROUP BY `priority`");
+               if (dbm::is_result($r))
+                       foreach ($r as $entry) {
+                               if ($processlist != "")
+                                       $processlist .= ", ";
+                               $processlist .= $entry["priority"].":".$running[$entry["priority"]]."/".$entry["entries"];
+                       }
+
+               logger("Load: ".$load."/".$maxsysload." - processes: ".$active."/".$entries." (".$processlist.") - maximum: ".$queues."/".$maxqueues, LOGGER_DEBUG);
 
+               // Are there fewer workers running as possible? Then fork a new one.
+               if (!get_config("system", "worker_dont_fork") AND ($queues > ($active + 1)) AND ($entries > 1)) {
+                       logger("Active workers: ".$active."/".$queues." Fork a new worker.", LOGGER_DEBUG);
+                       $args = array("php", "include/poller.php", "no_cron");
+                       $a = get_app();
+                       $a->proc_run($args);
+               }
        }
 
        return($active >= $queues);
 }
 
 function poller_active_workers() {
-       $workers = q("SELECT COUNT(*) AS `workers` FROM `workerqueue` WHERE `executed` != '0000-00-00 00:00:00'");
+       $workers = q("SELECT COUNT(*) AS `processes` FROM `process` WHERE `command` = 'poller.php'");
+
+       return($workers[0]["processes"]);
+}
+
+/**
+ * @brief Check if we should pass some slow processes
+ *
+ * When the active processes of the highest priority are using more than 2/3
+ * of all processes, we let pass slower processes.
+ *
+ * @param string $highest_priority Returns the currently highest priority
+ * @return bool We let pass a slower process than $highest_priority
+ */
+function poller_passing_slow(&$highest_priority) {
+
+       $highest_priority = 0;
+
+       $r = q("SELECT `priority`
+               FROM `process`
+               INNER JOIN `workerqueue` ON `workerqueue`.`pid` = `process`.`pid`
+               WHERE `process`.`command` = 'poller.php'");
+
+       // No active processes at all? Fine
+       if (!dbm::is_result($r))
+               return(false);
+
+       $priorities = array();
+       foreach ($r AS $line)
+               $priorities[] = $line["priority"];
+
+       // Should not happen
+       if (count($priorities) == 0)
+               return(false);
+
+       $highest_priority = min($priorities);
+
+       // The highest process is already the slowest one?
+       // Then we quit
+       if ($highest_priority == PRIORITY_NEGLIGIBLE)
+               return(false);
+
+       $high = 0;
+       foreach ($priorities AS $priority)
+               if ($priority == $highest_priority)
+                       ++$high;
 
-       return($workers[0]["workers"]);
+       logger("Highest priority: ".$highest_priority." Total processes: ".count($priorities)." Count high priority processes: ".$high, LOGGER_DEBUG);
+       $passing_slow = (($high/count($priorities)) > (2/3));
+
+       if ($passing_slow)
+               logger("Passing slower processes than priority ".$highest_priority, LOGGER_DEBUG);
+
+       return($passing_slow);
+}
+
+/**
+ * @brief Returns the next worker process
+ *
+ * @return string SQL statement
+ */
+
+function poller_worker_process() {
+
+       // Check if we should pass some low priority process
+       $highest_priority = 0;
+
+       if (poller_passing_slow($highest_priority)) {
+               // Are there waiting processes with a higher priority than the currently highest?
+               $r = q("SELECT * FROM `workerqueue`
+                               WHERE `executed` = '0000-00-00 00:00:00' AND `priority` < %d
+                               ORDER BY `priority`, `created` LIMIT 1", dbesc($highest_priority));
+               if (dbm::is_result($r))
+                       return $r;
+
+               // Give slower processes some processing time
+               $r = q("SELECT * FROM `workerqueue`
+                               WHERE `executed` = '0000-00-00 00:00:00' AND `priority` > %d
+                               ORDER BY `priority`, `created` LIMIT 1", dbesc($highest_priority));
+       }
+
+       // If there is no result (or we shouldn't pass lower processes) we check without priority limit
+       if (($highest_priority == 0) OR !dbm::is_result($r))
+               $r = q("SELECT * FROM `workerqueue` WHERE `executed` = '0000-00-00 00:00:00' ORDER BY `priority`, `created` LIMIT 1");
+
+       return $r;
 }
 
 if (array_search(__file__,get_included_files())===0){
-  poller_run($_SERVER["argv"],$_SERVER["argc"]);
-  killme();
+       poller_run($_SERVER["argv"],$_SERVER["argc"]);
+
+       get_app()->end_process();
+
+       killme();
 }
 ?>