fix some linebreak issues

[friendica.git] / include / salmon.php

diff --git a/include/salmon.php b/include/salmon.php
index 872dcd5f313a8ed1200441c337a58b21ebc0792a..49384efea76d80009e6036a48669d625bc896ee6 100644 (file)
--- a/include/salmon.php
+++ b/include/salmon.php
@@ -19,10 +19,35 @@ function salmon_key($pubkey) {
 
 
 function base64url_encode($s) {
-       return strtr(base64_encode($s),'+/','-_');
+       $s = strtr(base64_encode($s),'+/','-_');
+/*
+ *  // placeholder for un-padded base64url_encode 
+ *  // per latest salmon rev
+ *
+ *  $s = str_replace('=','',$s);
+ *
+ */
+       return $s;
 }
 
 function base64url_decode($s) {
+
+/*
+ *  // Placeholder for new rev of salmon which strips base64 padding.
+ *  // PHP base64_decode handles the un-padded input without requiring this step
+ *  // Uncomment if you find you need it.
+ *
+ *     $l = strlen($s);
+ *     if(! strpos($s,'=')) {
+ *             $m = $l % 4;
+ *             if($m == 2)
+ *                     $s .= '==';
+ *             if($m == 3)
+ *                     $s .= '=';
+ *     }
+ *
+ */
+
        return base64_decode(strtr($s,'-_','+/'));
 }
 
@@ -86,13 +111,13 @@ function get_salmon_key($uri,$keyhash) {
 
        
                
-function slapper($owner,$contact,$slap) {
+function slapper($owner,$url,$slap) {
 
        logger('slapper called. Data: ' . $slap);
 
        // does contact have a salmon endpoint? 
 
-       if(! strlen($contact['notify']))
+       if(! strlen($url))
                return;
 
        // add all namespaces to item
@@ -147,17 +172,19 @@ EOT;
        ));
 
        // slap them 
-       post_url($contact['notify'],$salmon, array(
+       post_url($url,$salmon, array(
                'Content-type: application/magic-envelope+xml',
                'Content-length: ' . strlen($salmon)
        ));
 
        $a = get_app();
-       $return_code = trim($a->get_curl_code());
+       $return_code = $a->get_curl_code();
 
        // check for success, e.g. 2xx
 
-       if(substr($return_code,0,1) !== '2') {
+       if($return_code > 299) {
+
+               logger('slapper: compliant salmon failed. Falling back to status.net hack');
 
                // Entirely likely that their salmon implementation is
                // non-compliant. Let's try once more, this time only signing
@@ -172,14 +199,16 @@ EOT;
                ));
 
                // slap them 
-               post_url($contact['notify'],$salmon, array(
+               post_url($url,$salmon, array(
                        'Content-type: application/magic-envelope+xml',
                        'Content-length: ' . strlen($salmon)
                ));
-               $return_code = trim($a->get_curl_code());
+               $return_code = $a->get_curl_code();
 
        }
        logger('slapper returned ' . $return_code); 
-       return;
+       if(! $return_code)
+               return(-1);
+       return ((($return_code >= 200) && ($return_code < 300)) ? 0 : 1);
 }