Using object value instead of inline string

[quix0rs-gnu-social.git] / js / util.js

diff --git a/js/util.js b/js/util.js
index 7354a24ca5b5a9f723d779e408417eb789168879..048d3f1eb146752a443916570baaffe52e438ab4 100644 (file)
--- a/js/util.js
+++ b/js/util.js
@@ -435,6 +435,8 @@ var SN = { // StatusNet
                 $('#'+SN.C.S.NoticeDataAttachSelected+' button').click(function(){
                     $('#'+SN.C.S.NoticeDataAttachSelected).remove();
                     NDA.val('');
+
+                    return false;
                 });
             });
         },
@@ -442,36 +444,13 @@ var SN = { // StatusNet
         NoticeLocationAttach: function() {
             var NDG = $('#'+SN.C.S.NoticeDataGeo);
             if (NDG.length > 0) {
-                NDG.attr('title', NDG.text());
                 var NLE = $('#notice_data-location_wrap');
                 var geocodeURL = NLE.attr('title');
 
-                var S = '<div id="'+SN.C.S.NoticeDataGeoSelected+'" class="'+SN.C.S.Success+'"> <button class="minimize">&#95;</button> <button class="close">&#215;</button></div>';
-                var NDGS = $('#'+SN.C.S.NoticeDataGeoSelected);
-
-                if (NDGS.length > 0) {
-                    NDGS.replaceWith(S);
-                }
-                else {
-                    $('#'+SN.C.S.FormNotice).append(S);
-                }
-                NDGS = $('#'+SN.C.S.NoticeDataGeoSelected);
-
-                $('#'+SN.C.S.NoticeDataGeoSelected+' button.close').click(function(){
-                    $('#'+SN.C.S.NoticeDataGeoSelected).remove();
-                    $('#'+SN.C.S.NoticeDataGeo).attr('checked', false);
-
-                    return false;
-                });
-
-                $('#'+SN.C.S.NoticeDataGeoSelected+' button.minimize').click(function(){
-                    $('#'+SN.C.S.NoticeDataGeoSelected).hide();
-
-                    return false;
-                });
+                $('label[for='+SN.C.S.NoticeDataGeo+']').attr('title', NLE.text());
 
                 if (navigator.geolocation) {
-                    NLE.change(function() {
+                    NDG.change(function() {
                         NLE.removeAttr('title');
 
                         $.cookie(SN.C.S.NoticeLocationCookieName, $('#'+SN.C.S.NoticeDataGeo).attr('checked'));
@@ -481,13 +460,38 @@ var SN = { // StatusNet
                             NLN.remove();
                         }
 
+                        var S = '<div id="'+SN.C.S.NoticeDataGeoSelected+'" class="'+SN.C.S.Success+'"/>';
+                        NDGS = $('#'+SN.C.S.NoticeDataGeoSelected);
+                        if (NDGS.length > 0) {
+                            NDGS.replaceWith(S);
+                        }
+                        else {
+                            $('#'+SN.C.S.FormNotice).append(S);
+                        }
+                        NDGS = $('#'+SN.C.S.NoticeDataGeoSelected);
                         NDGS.prepend('<span id="'+SN.C.S.NoticeLocationName+'">Geo</span>');
+
                         NLN = $('#'+SN.C.S.NoticeLocationName);
 
                         if ($('#'+SN.C.S.NoticeDataGeo).attr('checked') === true) {
-                            NDGS.show();
                             NLN.addClass('processing');
-                            $('label[for=notice_data-geo]').addClass('checked');
+                            $('label[for='+SN.C.S.NoticeDataGeo+']').addClass('checked');
+
+                            NDGS.append('<button class="minimize">&#95;</button> <button class="close">&#215;</button>');
+
+                            $('#'+SN.C.S.NoticeDataGeoSelected+' button.close').click(function(){
+                                $('#'+SN.C.S.NoticeDataGeoSelected).remove();
+                                $('#'+SN.C.S.NoticeDataGeo).attr('checked', false);
+                                $('label[for='+SN.C.S.NoticeDataGeo+']').removeClass('checked');
+
+                                return false;
+                            });
+
+                            $('#'+SN.C.S.NoticeDataGeoSelected+' button.minimize').click(function(){
+                                $('#'+SN.C.S.NoticeDataGeoSelected).hide();
+
+                                return false;
+                            });
 
                             navigator.geolocation.getCurrentPosition(function(position) {
                                 $('#'+SN.C.S.NoticeLat).val(position.coords.latitude);
@@ -520,11 +524,16 @@ var SN = { // StatusNet
 
                                     NLN.attr('href', location.url);
                                     NLN.text(NLN_text);
+                                    NLN.click(function() {
+                                        window.open(location.url);
+
+                                        return false;
+                                    });
                                 });
                             });
                         }
                         else {
-                            $('label[for=notice_data-geo]').removeClass('checked');
+                            $('label[for='+SN.C.S.NoticeDataGeo+']').removeClass('checked');
                             NDGS.hide();
                             $('#'+SN.C.S.NoticeLat).val('');
                             $('#'+SN.C.S.NoticeLon).val('');
@@ -534,8 +543,8 @@ var SN = { // StatusNet
                     });
 
                     var cookieVal = $.cookie(SN.C.S.NoticeLocationCookieName);
-                    $('#'+SN.C.S.NoticeDataGeo).attr('checked', (cookieVal == null || cookieVal == 'true'));
-                    NLE.change();
+                    NDG.attr('checked', (cookieVal == null || cookieVal == 'true'));
+                    NDG.change();
                 }
             }
         },