if (!empty($targetEl)) {
$this->target = new ActivityObject($targetEl);
+ } elseif (ActivityUtils::compareVerbs($this->verb, array(ActivityVerb::FAVORITE))) {
+ // StatusNet didn't send a 'target' for their Favorite atom entries
+ $this->target = clone($this->objects[0]);
}
$this->summary = ActivityUtils::childContent($entry, 'summary');
if (!empty($this->link)) {
$xs->element('link', array('rel' => 'alternate',
- 'type' => 'text/html'),
- $this->link);
+ 'type' => 'text/html',
+ 'href' => $this->link));
}
}
}
if (!empty($this->context->conversation)) {
- $xs->element('link', array('rel' => ActivityContext::CONVERSATION,
- 'href' => $this->context->conversation));
- }
-
- foreach ($this->context->attention as $attnURI) {
- $xs->element('link', array('rel' => ActivityContext::ATTENTION,
- 'href' => $attnURI));
- $xs->element('link', array('rel' => ActivityContext::MENTIONED,
- 'href' => $attnURI));
- }
-
- // XXX: shoulda used ActivityVerb::SHARE
-
- if (!empty($this->context->forwardID)) {
- if (!empty($this->context->forwardUrl)) {
- $xs->element('ostatus:forward',
- array('ref' => $this->context->forwardID,
- 'href' => $this->context->forwardUrl));
+ $convattr = [];
+ $conv = Conversation::getKV('uri', $this->context->conversation);
+ if ($conv instanceof Conversation) {
+ $convattr['href'] = $conv->getUrl();
+ $convattr['local_id'] = $conv->getID();
+ $convattr['ref'] = $conv->getUri();
+ $xs->element('link', array('rel' => ActivityContext::CONVERSATION,
+ 'href' => $convattr['href']));
} else {
- $xs->element('ostatus:forward',
- array('ref' => $this->context->forwardID));
+ $convattr['ref'] = $this->context->conversation;
}
+ $xs->element(ActivityContext::CONVERSATION,
+ $convattr,
+ $this->context->conversation);
+ /* Since we use XMLWriter we just use the previously hardcoded prefix for ostatus,
+ otherwise we should use something like this:
+ $xs->elementNS(array(ActivityContext::OSTATUS => 'ostatus'), // namespace
+ 'conversation', // tag (or the element name from ActivityContext::CONVERSATION)
+ null, // attributes
+ $this->context->conversation); // content
+ */
+ }
+
+ foreach ($this->context->attention as $attnURI=>$type) {
+ $xs->element('link', array('rel' => ActivityContext::MENTIONED,
+ ActivityContext::OBJECTTYPE => $type, // FIXME: undocumented
+ 'href' => $attnURI));
}
if (!empty($this->context->location)) {