abstract function filter($notice);
- function getNotices($offset, $limit, $sinceId, $maxId)
+ function getNoticeIds($offset, $limit, $since_id, $max_id)
{
// "offset" is virtual; we have to get a lot
$total = $offset + $limit;
// or we get nothing from upstream.
$results = null;
+ $round = 0;
do {
-
- $raw = $this->upstream->getNotices($startAt, $askFor, $sinceId, $maxId);
+ $raw = $this->upstream->getNotices($startAt, $askFor, $since_id, $max_id);
$results = $raw->N;
-
if ($results == 0) {
break;
}
- while ($raw->fetch()) {
- if ($this->filter($raw)) {
- $filtered[] = clone($raw);
- if (count($filtered >= $total)) {
+ $notices = $raw->fetchAll();
+ $this->prefill($notices);
+ foreach ($notices as $notice) {
+ if ($this->filter($notice)) {
+ $filtered[] = $notice->id;
+ if (count($filtered) >= $total) {
break;
}
}
}
// XXX: make these smarter; factor hit rate into $askFor
-
$startAt += $askFor;
- $askFor = max($total - count($filtered), NOTICES_PER_PAGE);
+ $hits = count($filtered);
+ $lastAsk = $askFor;
+
+ if ($hits === 0) {
+ $askFor = max(min(2 * $askFor, NOTICES_PER_PAGE * 50), NOTICES_PER_PAGE);
+ } else {
+ $askFor = max(min(intval(ceil(($total - $hits)*$startAt/$hits)), NOTICES_PER_PAGE * 50), NOTICES_PER_PAGE);
+ }
- } while (count($filtered) < $total && $results !== 0);
+ $round++;
+ } while (count($filtered) < $total && $results >= $lastAsk);
- return new ArrayWrapper(array_slice($filtered, $offset, $limit));
+ return array_slice(array_values($filtered), $offset, $limit);
}
- function getNoticeIds($offset, $limit, $sinceId, $maxId)
+ function prefill($notices)
{
- $notices = $this->getNotices($offset, $limit, $sinceId, $maxId);
-
- $ids = array();
-
- while ($notices->fetch()) {
- $ids[] = $notice->id;
- }
-
- return $ids;
+ return;
}
}