de-IDifying labels in notice form to fix issue with geo pin activating the wrong...

[quix0rs-gnu-social.git] / lib / noticeform.php

diff --git a/lib/noticeform.php b/lib/noticeform.php
index ace8e5582b43095f50f2af9b469362b7e96c8d04..271a37449c318dfac55c95650dfb5e6febbe2e43 100644 (file)
--- a/lib/noticeform.php
+++ b/lib/noticeform.php
@@ -187,12 +187,14 @@ class NoticeForm extends Form
             if (common_config('attachments', 'uploads')) {
                 $this->out->hidden('MAX_FILE_SIZE', common_config('attachments', 'file_quota'));
                 // TRANS: Input label in notice form for adding an attachment.
-                $this->out->element('label', array('for' => 'notice_data-attach'),_('Attach'));
-                $this->out->element('input', array('id' => 'notice_data-attach',
+                $this->out->elementStart('label', array('class' => 'notice_data-attach'));
+                $this->out->text(_('Attach'));
+                $this->out->element('input', array('class' => 'notice_data-attach',
                                                    'type' => 'file',
                                                    'name' => 'attach',
                                                    // TRANS: Title for input field to attach a file to a notice.
                                                    'title' => _('Attach a file.')));
+                $this->out->elementEnd('label');
             }
             if ($this->action) {
                 $this->out->hidden('notice_return-to', $this->action, 'returnto');
@@ -210,6 +212,7 @@ class NoticeForm extends Form
 
                 // @fixme checkbox method allows no way to change the id without changing the name
                 //$this->out->checkbox('notice_data-geo', _('Share my location'), true);
+                $this->out->elementStart('label', 'notice_data-geo');
                 $this->out->element('input', array(
                     'name' => 'notice_data-geo',
                     'type' => 'checkbox',
@@ -218,11 +221,10 @@ class NoticeForm extends Form
                     'checked' => true, // ?
                 ));
                 $this->out->text(' ');
-                $this->out->element('label', array('class' => 'notice_data-geo',
-                                              'for' => $this->id() . '-notice_data-geo'),
-                               // TRANS: Field label to add location to a notice.
-                               _('Share my location'));
-
+                // TRANS: Field label to add location to a notice.
+                $this->out->text(_('Share my location'));
+                $this->out->elementEnd('label');
+                               
                 $this->out->elementEnd('div');
                 // TRANS: Text to not share location for a notice in notice form.
                 $share_disable_text = _('Do not share my location');