Possible hack for tags from private dents in public profile or wrong scope (both...

[quix0rs-gnu-social.git] / lib / replynoticestream.php

diff --git a/lib/replynoticestream.php b/lib/replynoticestream.php
index 9de8d4efaf9c49ca62b17e48e819537c2f7b4dba..9fea5cac1e5accdc62a77b65526d468c2ae7d8ea 100644 (file)
--- a/lib/replynoticestream.php
+++ b/lib/replynoticestream.php
@@ -47,10 +47,14 @@ if (!defined('STATUSNET')) {
 
 class ReplyNoticeStream extends ScopingNoticeStream
 {
-    function __construct($userId)
+    function __construct($userId, $profile=-1)
     {
+        if (is_int($profile) && $profile == -1) {
+            $profile = Profile::current();
+        }
         parent::__construct(new CachingNoticeStream(new RawReplyNoticeStream($userId),
-                                                    'reply:stream:' . $userId));
+                                                    'reply:stream:' . $userId),
+                            $profile);
     }
 }
 
@@ -71,18 +75,28 @@ class RawReplyNoticeStream extends NoticeStream
 
     function __construct($userId)
     {
+        parent::__construct();
         $this->userId = $userId;
     }
 
     function getNoticeIds($offset, $limit, $since_id, $max_id)
     {
         $reply = new Reply();
-        $reply->profile_id = $this->userId;
 
-        Notice::addWhereSinceId($reply, $since_id, 'notice_id', 'modified');
-        Notice::addWhereMaxId($reply, $max_id, 'notice_id', 'modified');
+        $reply->selectAdd();
+        $reply->selectAdd('notice_id');
 
-        $reply->orderBy('modified DESC, notice_id DESC');
+        $reply->whereAdd(sprintf('reply.profile_id = %u', $this->userId));
+
+        Notice::addWhereSinceId($reply, $since_id, 'notice_id', 'reply.modified');
+        Notice::addWhereMaxId($reply, $max_id, 'notice_id', 'reply.modified');
+
+        if (!empty($this->selectVerbs)) {
+            $reply->joinAdd(array('notice_id', 'notice:id'));
+            $reply->whereAddIn('notice.verb', $this->selectVerbs, 'string');
+        }
+
+        $reply->orderBy('reply.modified DESC, reply.notice_id DESC');
 
         if (!is_null($offset)) {
             $reply->limit($offset, $limit);
@@ -98,4 +112,4 @@ class RawReplyNoticeStream extends NoticeStream
 
         return $ids;
     }
-}
\ No newline at end of file
+}