*/
public function buildCreateTable($name, $def)
{
+ $def = $this->filterDef($def);
$sql = array();
foreach ($def['fields'] as $col => $colDef) {
*/
function appendUniqueKeyDef(array &$sql, $name, array $def)
{
- $sql[] = "UNIQUE $key " . $this->buildIndexList($def);
+ $sql[] = "UNIQUE $name " . $this->buildIndexList($def);
}
/**
}
}
- $cur = array_keys($old['fields']);
- $new = array_keys($def['fields']);
+ $old = $this->filterDef($old);
+ $def = $this->filterDef($def);
- $toadd = array_diff($new, $cur);
- $todrop = array_diff($cur, $new);
- $same = array_intersect($new, $cur);
- $tomod = array();
-
- // Find which fields have actually changed definition
- // in a way that we need to tweak them for this DB type.
- foreach ($same as $name) {
- $curCol = $old['fields'][$name];
- $newCol = $cur['fields'][$name];
+ // @fixme check if not present
+ $fields = $this->diffArrays($old, $def, 'fields', array($this, 'columnsEqual'));
+ $uniques = $this->diffArrays($old, $def, 'unique keys');
+ $indexes = $this->diffArrays($old, $def, 'indexes');
- if (!$this->columnsEqual($curCol, $newCol)) {
- $tomod[] = $name;
- }
- }
-
- if (count($toadd) + count($todrop) + count($tomod) == 0) {
+ $total = $fields['count'] + $uniques['count'] + $indexes['count'];
+ if ($total == 0) {
// nothing to do
- return true;
+ return array();
}
// For efficiency, we want this all in one
$phrase = array();
- foreach ($toadd as $columnName) {
+ foreach ($uniques['del'] + $uniques['mod'] as $keyName) {
+ $this->appendAlterDropUnique($phrase, $keyName);
+ }
+
+ foreach ($fields['add'] as $columnName) {
$this->appendAlterAddColumn($phrase, $columnName,
$def['fields'][$columnName]);
}
- foreach ($todrop as $columnName) {
+ foreach ($fields['mod'] as $columnName) {
$this->appendAlterModifyColumn($phrase, $columnName,
$old['fields'][$columnName],
$def['fields'][$columnName]);
}
- foreach ($tomod as $columnName) {
+ foreach ($fields['del'] as $columnName) {
$this->appendAlterDropColumn($phrase, $columnName);
}
- $sql = 'ALTER TABLE ' . $tableName . ' ' . implode(', ', $phrase);
+ foreach ($uniques['mod'] + $uniques['add'] as $keyName) {
+ $this->appendAlterAddUnique($phrase, $keyName, $def['unique keys'][$keyName]);
+ }
+
+ $sql = 'ALTER TABLE ' . $tableName . ' ' . implode(",\n", $phrase);
- $res = $this->conn->query($sql);
+ return array($sql);
+ }
- if (PEAR::isError($res)) {
- throw new Exception($res->getMessage());
- }
+ function diffArrays($oldDef, $newDef, $section, $compareCallback=null)
+ {
+ $old = isset($oldDef[$section]) ? $oldDef[$section] : array();
+ $new = isset($newDef[$section]) ? $newDef[$section] : array();
- return true;
+ $oldKeys = array_keys($old);
+ $newKeys = array_keys($new);
+
+ $toadd = array_diff($newKeys, $oldKeys);
+ $todrop = array_diff($oldKeys, $newKeys);
+ $same = array_intersect($newKeys, $oldKeys);
+ $tomod = array();
+ $tokeep = array();
+
+ // Find which fields have actually changed definition
+ // in a way that we need to tweak them for this DB type.
+ foreach ($same as $name) {
+ if ($compareCallback) {
+ $same = call_user_func($compareCallback, $old[$name], $new[$name]);
+ } else {
+ $same = ($old[$name] == $new[$name]);
+ }
+ if ($same) {
+ $tokeep[] = $name;
+ continue;
+ }
+ $tomod[] = $name;
+ }
+ return array('add' => $toadd,
+ 'del' => $todrop,
+ 'mod' => $tomod,
+ 'keep' => $tokeep,
+ 'count' => count($toadd) + count($todrop) + count($tomod));
}
/**
$phrase[] = 'DROP COLUMN ' . $this->quoteIdentifier($columnName);
}
+ function appendAlterAddUnique(array &$phrase, $keyName, array $def)
+ {
+ $sql = array();
+ $sql[] = 'ADD';
+ $this->appendUniqueKeyDef($sql, $keyName, $def);
+ $phrase[] = implode(' ', $sql);'ADD CONSTRAINT ' . $keyName;
+ }
+
+ function appendAlterDropUnique(array &$phrase, $keyName)
+ {
+ $phrase[] = 'DROP CONSTRAINT ' . $keyName;
+ }
+
/**
* Quote a db/table/column identifier if necessary.
*
return $table;
}
+ /**
+ * Filter the given table definition array to match features available
+ * in this database.
+ *
+ * This lets us strip out unsupported things like comments, foreign keys,
+ * or type variants that we wouldn't get back from getTableDef().
+ *
+ * @param array $tableDef
+ */
+ function filterDef(array $tableDef)
+ {
+ return $tableDef;
+ }
+
function isNumericType($type)
{
$type = strtolower($type);