BBCode - fixed syntax error

[friendica.git] / mod / admin.php

diff --git a/mod/admin.php b/mod/admin.php
index a0cc207e8decb8412bb891d6b0c23ef9e8d9903a..cc2256b73dd37ba36585f1cb78c4a16e0fa0e963 100644 (file)
--- a/mod/admin.php
+++ b/mod/admin.php
@@ -26,6 +26,7 @@ use Friendica\Model\Contact;
 use Friendica\Model\Item;
 use Friendica\Model\Register;
 use Friendica\Model\User;
+use Friendica\Module;
 use Friendica\Module\Login;
 use Friendica\Module\Tos;
 use Friendica\Util\Arrays;
@@ -33,6 +34,7 @@ use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
 use Friendica\Util\Strings;
 use Friendica\Util\Temporal;
+use Psr\Log\LogLevel;
 
 /**
  * Sets the current theme for theme settings pages.
@@ -62,7 +64,8 @@ function admin_init(App $a)
  * return the HTML for the pages of the admin panel.
  *
  * @param App $a
- *
+ * @throws ImagickException
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_post(App $a)
 {
@@ -161,6 +164,7 @@ function admin_post(App $a)
  *
  * @param App $a
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_content(App $a)
 {
@@ -301,8 +305,7 @@ function admin_content(App $a)
 
        if ($a->isAjax()) {
                echo $o;
-               killme();
-               return '';
+               exit();
        } else {
                return $o;
        }
@@ -313,6 +316,7 @@ function admin_content(App $a)
  *
  * @param App $a
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_tos(App $a)
 {
@@ -335,6 +339,7 @@ function admin_page_tos(App $a)
  * @brief Process send data from Admin TOS Page
  *
  * @param App $a
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_tos_post(App $a)
 {
@@ -367,6 +372,7 @@ function admin_page_tos_post(App $a)
  *
  * @param App $a
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_blocklist(App $a)
 {
@@ -407,6 +413,7 @@ function admin_page_blocklist(App $a)
  * @brief Process send data from Admin Blocklist Page
  *
  * @param App $a
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_blocklist_post(App $a)
 {
@@ -451,6 +458,8 @@ function admin_page_blocklist_post(App $a)
  * @brief Process data send by the contact block admin page
  *
  * @param App $a
+ * @throws ImagickException
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_contactblock_post(App $a)
 {
@@ -483,6 +492,7 @@ function admin_page_contactblock_post(App $a)
  *
  * @param App $a
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_contactblock(App $a)
 {
@@ -535,6 +545,7 @@ function admin_page_contactblock(App $a)
  *
  * @param App $a
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_deleteitem(App $a)
 {
@@ -559,6 +570,7 @@ function admin_page_deleteitem(App $a)
  * URLs like the full /display URL to make the process more easy for the admin.
  *
  * @param App $a
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_deleteitem_post(App $a)
 {
@@ -598,6 +610,7 @@ function admin_page_deleteitem_post(App $a)
  *
  * @param App $a
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_federation(App $a)
 {
@@ -784,6 +797,7 @@ function admin_page_federation(App $a)
  *
  * @param App $a
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_queue(App $a)
 {
@@ -826,7 +840,9 @@ function admin_page_queue(App $a)
  * The returned string holds the content of the page.
  *
  * @param App $a
+ * @param     $deferred
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_workerqueue(App $a, $deferred)
 {
@@ -876,6 +892,7 @@ function admin_page_workerqueue(App $a, $deferred)
  *
  * @param App $a
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_summary(App $a)
 {
@@ -994,6 +1011,7 @@ function admin_page_summary(App $a)
  * @brief Process send data from Admin Site Page
  *
  * @param App $a
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_site_post(App $a)
 {
@@ -1171,10 +1189,13 @@ function admin_page_site_post(App $a)
        $relay_server_tags = (!empty($_POST['relay_server_tags']) ? Strings::escapeTags(trim($_POST['relay_server_tags']))  : '');
        $relay_user_tags   = !empty($_POST['relay_user_tags']);
        $active_panel      = (!empty($_POST['active_panel'])      ? "#" . Strings::escapeTags(trim($_POST['active_panel'])) : '');
-       
+
+       /**
+        * @var $storagebackend \Friendica\Model\Storage\IStorage
+        */
        $storagebackend    = Strings::escapeTags(trim(defaults($_POST, 'storagebackend', '')));
        StorageManager::setBackend($storagebackend);
-       
+
        // save storage backend form
        if (!is_null($storagebackend) && $storagebackend != "") {
                $storage_opts = $storagebackend::getOptions();
@@ -1279,7 +1300,7 @@ function admin_page_site_post(App $a)
                Config::set('system', 'banner', $banner);
        }
 
-       if ($info == "") {
+       if (empty($info)) {
                Config::delete('config', 'info');
        } else {
                Config::set('config', 'info', $info);
@@ -1398,6 +1419,7 @@ function admin_page_site_post(App $a)
  *
  * @param  App $a
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_site(App $a)
 {
@@ -1489,9 +1511,9 @@ function admin_page_site(App $a)
 
        /* Register policy */
        $register_choices = [
-               REGISTER_CLOSED => L10n::t("Closed"),
-               REGISTER_APPROVE => L10n::t("Requires approval"),
-               REGISTER_OPEN => L10n::t("Open")
+               Module\Register::CLOSED => L10n::t("Closed"),
+               Module\Register::APPROVE => L10n::t("Requires approval"),
+               Module\Register::OPEN => L10n::t("Open")
        ];
 
        $ssl_choices = [
@@ -1519,6 +1541,9 @@ function admin_page_site(App $a)
 
        /* storage backend */
        $storage_backends = StorageManager::listBackends();
+       /**
+        * @var $storage_current_backend \Friendica\Model\Storage\IStorage
+        */
        $storage_current_backend = StorageManager::getBackend();
 
        $storage_backends_choices = [
@@ -1678,7 +1703,8 @@ function admin_page_site(App $a)
  *
  * @param App $a
  * @return string
- * */
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
+ */
 function admin_page_dbsync(App $a)
 {
        $o = '';
@@ -1768,6 +1794,7 @@ function admin_page_dbsync(App $a)
  * @brief Process data send by Users admin page
  *
  * @param App $a
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_users_post(App $a)
 {
@@ -1885,6 +1912,7 @@ function admin_page_users_post(App $a)
  *
  * @param App $a
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_users(App $a)
 {
@@ -1962,17 +1990,18 @@ function admin_page_users(App $a)
        $adminlist = explode(",", str_replace(" ", "", Config::get('config', 'admin_email')));
        $_setup_users = function ($e) use ($adminlist) {
                $page_types = [
-                       Contact::PAGE_NORMAL    => L10n::t('Normal Account Page'),
-                       Contact::PAGE_SOAPBOX   => L10n::t('Soapbox Page'),
-                       Contact::PAGE_COMMUNITY => L10n::t('Public Forum'),
-                       Contact::PAGE_FREELOVE  => L10n::t('Automatic Friend Page'),
-                       Contact::PAGE_PRVGROUP  => L10n::t('Private Forum')
+                       User::PAGE_FLAGS_NORMAL    => L10n::t('Normal Account Page'),
+                       User::PAGE_FLAGS_SOAPBOX   => L10n::t('Soapbox Page'),
+                       User::PAGE_FLAGS_COMMUNITY => L10n::t('Public Forum'),
+                       User::PAGE_FLAGS_FREELOVE  => L10n::t('Automatic Friend Page'),
+                       User::PAGE_FLAGS_PRVGROUP  => L10n::t('Private Forum')
                ];
                $account_types = [
-                       Contact::ACCOUNT_TYPE_PERSON       => L10n::t('Personal Page'),
-                       Contact::ACCOUNT_TYPE_ORGANISATION => L10n::t('Organisation Page'),
-                       Contact::ACCOUNT_TYPE_NEWS         => L10n::t('News Page'),
-                       Contact::ACCOUNT_TYPE_COMMUNITY    => L10n::t('Community Forum')
+                       User::ACCOUNT_TYPE_PERSON       => L10n::t('Personal Page'),
+                       User::ACCOUNT_TYPE_ORGANISATION => L10n::t('Organisation Page'),
+                       User::ACCOUNT_TYPE_NEWS         => L10n::t('News Page'),
+                       User::ACCOUNT_TYPE_COMMUNITY    => L10n::t('Community Forum'),
+                       User::ACCOUNT_TYPE_RELAY        => L10n::t('Relay'),
                ];
 
                $e['page_flags_raw'] = $e['page-flags'];
@@ -2083,6 +2112,7 @@ function admin_page_users(App $a)
  * @param App   $a
  * @param array $addons_admin A list of admin addon names
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_addons(App $a, array $addons_admin)
 {
@@ -2288,6 +2318,7 @@ function rebuild_theme_table($themes)
  *
  * @param App $a
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_themes(App $a)
 {
@@ -2458,6 +2489,7 @@ function admin_page_themes(App $a)
  * @brief Prosesses data send by Logs admin page
  *
  * @param App $a
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_logs_post(App $a)
 {
@@ -2466,7 +2498,7 @@ function admin_page_logs_post(App $a)
 
                $logfile   = (!empty($_POST['logfile']) ? Strings::escapeTags(trim($_POST['logfile'])) : '');
                $debugging = !empty($_POST['debugging']);
-               $loglevel  = (!empty($_POST['loglevel']) ? intval(trim($_POST['loglevel'])) : 0);
+               $loglevel  = defaults($_POST, 'loglevel', LogLevel::ERROR);
 
                Config::set('system', 'logfile', $logfile);
                Config::set('system', 'debugging', $debugging);
@@ -2493,16 +2525,16 @@ function admin_page_logs_post(App $a)
  *
  * @param App $a
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_logs(App $a)
 {
        $log_choices = [
-               Logger::WARNING => 'Warning',
-               Logger::INFO    => 'Info',
-               Logger::TRACE   => 'Trace',
-               Logger::DEBUG   => 'Debug',
-               Logger::DATA    => 'Data',
-               Logger::ALL     => 'All'
+               LogLevel::ERROR   => 'Error',
+               LogLevel::WARNING => 'Warning',
+               LogLevel::NOTICE  => 'Notice',
+               LogLevel::INFO    => 'Info',
+               LogLevel::DEBUG   => 'Debug',
        ];
 
        if (ini_get('log_errors')) {
@@ -2549,6 +2581,7 @@ function admin_page_logs(App $a)
  *
  * @param App $a
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_viewlogs(App $a)
 {
@@ -2592,6 +2625,7 @@ function admin_page_viewlogs(App $a)
  * @brief Prosesses data send by the features admin page
  *
  * @param App $a
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_features_post(App $a)
 {
@@ -2639,6 +2673,7 @@ function admin_page_features_post(App $a)
  *
  * @param App $a
  * @return string
+ * @throws \Friendica\Network\HTTPException\InternalServerErrorException
  */
 function admin_page_features(App $a)
 {