]> git.mxchange.org Git - friendica.git/blobdiff - mod/dfrn_confirm.php
Renamed System::redirect() to $a->redirect()
[friendica.git] / mod / dfrn_confirm.php
index 9a46d463b7f85a1efb9c6e17d946b0aa019de482..3345bca61193e713c1f999bc33b5b49f017a9056 100644 (file)
 use Friendica\App;
 use Friendica\Core\Config;
 use Friendica\Core\L10n;
-use Friendica\Core\PConfig;
+use Friendica\Core\Protocol;
 use Friendica\Core\System;
-use Friendica\Core\Worker;
-use Friendica\Database\DBM;
+use Friendica\Database\DBA;
 use Friendica\Model\Contact;
 use Friendica\Model\Group;
-use Friendica\Model\Item;
 use Friendica\Model\User;
 use Friendica\Network\Probe;
 use Friendica\Protocol\Diaspora;
+use Friendica\Protocol\ActivityPub;
 use Friendica\Util\Crypto;
+use Friendica\Util\DateTimeFormat;
 use Friendica\Util\Network;
-use Friendica\Util\Temporal;
 use Friendica\Util\XML;
 
 require_once 'include/enotify.php';
@@ -69,8 +68,8 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                        return;
                }
 
-               $user = dba::selectFirst('user', [], ['uid' => $uid]);
-               if (!DBM::is_result($user)) {
+               $user = DBA::selectFirst('user', [], ['uid' => $uid]);
+               if (!DBA::isResult($user)) {
                        notice(L10n::t('Profile not found.') . EOL);
                        return;
                }
@@ -83,14 +82,12 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                        $duplex   = $handsfree['duplex'];
                        $cid      = 0;
                        $hidden   = intval(defaults($handsfree, 'hidden'  , 0));
-                       $activity = intval(defaults($handsfree, 'activity', 0));
                } else {
                        $dfrn_id  = notags(trim(defaults($_POST, 'dfrn_id'   , '')));
                        $intro_id =      intval(defaults($_POST, 'intro_id'  , 0));
                        $duplex   =      intval(defaults($_POST, 'duplex'    , 0));
                        $cid      =      intval(defaults($_POST, 'contact_id', 0));
                        $hidden   =      intval(defaults($_POST, 'hidden'    , 0));
-                       $activity =      intval(defaults($_POST, 'activity'  , 0));
                }
 
                /*
@@ -122,11 +119,11 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                        AND `uid` = %d
                        AND `duplex` = 0
                        LIMIT 1",
-                       dbesc($dfrn_id),
+                       DBA::escape($dfrn_id),
                        intval($cid),
                        intval($uid)
                );
-               if (!DBM::is_result($r)) {
+               if (!DBA::isResult($r)) {
                        logger('Contact not found in DB.');
                        notice(L10n::t('Contact not found.') . EOL);
                        notice(L10n::t('This may occasionally happen if contact was requested by both persons and it has already been approved.') . EOL);
@@ -141,13 +138,13 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                $dfrn_confirm = $contact['confirm'];
                $aes_allow    = $contact['aes_allow'];
 
-               $network = ((strlen($contact['issued-id'])) ? NETWORK_DFRN : NETWORK_OSTATUS);
+               $network = ((strlen($contact['issued-id'])) ? Protocol::DFRN : Protocol::OSTATUS);
 
                if ($contact['network']) {
                        $network = $contact['network'];
                }
 
-               if ($network === NETWORK_DFRN) {
+               if ($network === Protocol::DFRN) {
                        /*
                         * Generate a key pair for all further communications with this person.
                         * We have a keypair for every contact, and a site key for unknown people.
@@ -162,7 +159,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
 
                        // Save the private key. Send them the public key.
                        q("UPDATE `contact` SET `prvkey` = '%s' WHERE `id` = %d AND `uid` = %d",
-                               dbesc($private_key),
+                               DBA::escape($private_key),
                                intval($contact_id),
                                intval($uid)
                        );
@@ -206,11 +203,11 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                                $params['duplex'] = 1;
                        }
 
-                       if ($user['page-flags'] == PAGE_COMMUNITY) {
+                       if ($user['page-flags'] == Contact::PAGE_COMMUNITY) {
                                $params['page'] = 1;
                        }
 
-                       if ($user['page-flags'] == PAGE_PRVGROUP) {
+                       if ($user['page-flags'] == Contact::PAGE_PRVGROUP) {
                                $params['page'] = 2;
                        }
 
@@ -224,7 +221,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                         *
                         */
 
-                       $res = Network::post($dfrn_confirm, $params, null, $redirects, 120);
+                       $res = Network::post($dfrn_confirm, $params, null, $redirects, 120)->getBody();
 
                        logger(' Confirm: received data: ' . $res, LOGGER_DATA);
 
@@ -251,6 +248,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
 
                        if (stristr($res, "<status") === false) {
                                // wrong xml! stop here!
+                               logger('Unexpected response posting to ' . $dfrn_confirm);
                                notice(L10n::t('Unexpected response from remote site: ') . EOL . htmlspecialchars($res) . EOL);
                                return;
                        }
@@ -266,7 +264,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                                        // birthday paradox - generate new dfrn-id and fall through.
                                        $new_dfrn_id = random_string();
                                        q("UPDATE contact SET `issued-id` = '%s' WHERE `id` = %d AND `uid` = %d",
-                                               dbesc($new_dfrn_id),
+                                               DBA::escape($new_dfrn_id),
                                                intval($contact_id),
                                                intval($uid)
                                        );
@@ -283,12 +281,14 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                                notice(L10n::t('Remote site reported: ') . $message . EOL);
                        }
 
-                       if (($status == 0) && ($intro_id)) {
+                       if (($status == 0) && $intro_id) {
+                               $intro = DBA::selectFirst('intro', ['note'], ['id' => $intro_id]);
+                               if (DBA::isResult($intro)) {
+                                       DBA::update('contact', ['reason' => $intro['note']], ['id' => $contact_id]);
+                               }
+
                                // Success. Delete the notification.
-                               q("DELETE FROM `intro` WHERE `id` = %d AND `uid` = %d",
-                                       intval($intro_id),
-                                       intval($uid)
-                               );
+                               DBA::delete('intro', ['id' => $intro_id]);
                        }
 
                        if ($status != 0) {
@@ -307,13 +307,14 @@ function dfrn_confirm_post(App $a, $handsfree = null)
 
                logger('dfrn_confirm: confirm - imported photos');
 
-               if ($network === NETWORK_DFRN) {
-                       $new_relation = CONTACT_IS_FOLLOWER;
-                       if (($relation == CONTACT_IS_SHARING) || ($duplex)) {
-                               $new_relation = CONTACT_IS_FRIEND;
+               if ($network === Protocol::DFRN) {
+                       $new_relation = Contact::FOLLOWER;
+
+                       if (($relation == Contact::SHARING) || ($duplex)) {
+                               $new_relation = Contact::FRIEND;
                        }
 
-                       if (($relation == CONTACT_IS_SHARING) && ($duplex)) {
+                       if (($relation == Contact::SHARING) && ($duplex)) {
                                $duplex = 0;
                        }
 
@@ -327,18 +328,25 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                                `network` = '%s' WHERE `id` = %d
                        ",
                                intval($new_relation),
-                               dbesc(Temporal::utcNow()),
-                               dbesc(Temporal::utcNow()),
+                               DBA::escape(DateTimeFormat::utcNow()),
+                               DBA::escape(DateTimeFormat::utcNow()),
                                intval($duplex),
                                intval($hidden),
-                               dbesc(NETWORK_DFRN),
+                               DBA::escape(Protocol::DFRN),
                                intval($contact_id)
                        );
                } else {
-                       // $network !== NETWORK_DFRN
-                       $network = defaults($contact, 'network', NETWORK_OSTATUS);
+                       if ($network == Protocol::ACTIVITYPUB) {
+                               ActivityPub\Transmitter::sendContactAccept($contact['url'], $contact['hub-verify'], $uid);
+                               $pending = true;
+                       } else {
+                               $pending = false;
+                       }
+
+                       // $network !== Protocol::DFRN
+                       $network = defaults($contact, 'network', Protocol::OSTATUS);
 
-                       $arr = Probe::uri($contact['url']);
+                       $arr = Probe::uri($contact['url'], $network);
 
                        $notify  = defaults($contact, 'notify' , $arr['notify']);
                        $poll    = defaults($contact, 'poll'   , $arr['poll']);
@@ -348,113 +356,51 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                        $new_relation = $contact['rel'];
                        $writable = $contact['writable'];
 
-                       if ($network === NETWORK_DIASPORA) {
+                       if (in_array($network, [Protocol::DIASPORA, Protocol::ACTIVITYPUB])) {
                                if ($duplex) {
-                                       $new_relation = CONTACT_IS_FRIEND;
+                                       $new_relation = Contact::FRIEND;
                                } else {
-                                       $new_relation = CONTACT_IS_FOLLOWER;
+                                       $new_relation = Contact::FOLLOWER;
                                }
 
-                               if ($new_relation != CONTACT_IS_FOLLOWER) {
+                               if ($new_relation != Contact::FOLLOWER) {
                                        $writable = 1;
                                }
                        }
 
-                       q("DELETE FROM `intro` WHERE `id` = %d AND `uid` = %d",
-                               intval($intro_id),
-                               intval($uid)
-                       );
+                       DBA::delete('intro', ['id' => $intro_id]);
 
-                       $r = q("UPDATE `contact` SET `name-date` = '%s',
-                               `uri-date` = '%s',
-                               `addr` = '%s',
-                               `notify` = '%s',
-                               `poll` = '%s',
-                               `blocked` = 0,
-                               `pending` = 0,
-                               `network` = '%s',
-                               `writable` = %d,
-                               `hidden` = %d,
-                               `rel` = %d
-                               WHERE `id` = %d
-                       ",
-                               dbesc(Temporal::utcNow()),
-                               dbesc(Temporal::utcNow()),
-                               dbesc($addr),
-                               dbesc($notify),
-                               dbesc($poll),
-                               dbesc($network),
-                               intval($writable),
-                               intval($hidden),
-                               intval($new_relation),
-                               intval($contact_id)
-                       );
+                       $fields = ['name-date' => DateTimeFormat::utcNow(),
+                               'uri-date' => DateTimeFormat::utcNow(), 'addr' => $addr,
+                               'notify' => $notify, 'poll' => $poll, 'blocked' => false,
+                               'pending' => $pending, 'network' => $network,
+                               'writable' => $writable, 'hidden' => $hidden, 'rel' => $new_relation];
+                       DBA::update('contact', $fields, ['id' => $contact_id]);
                }
 
-               /// @TODO is DBM::is_result() working here?
-               if (!DBM::is_result($r)) {
+               if (!DBA::isResult($r)) {
                        notice(L10n::t('Unable to set contact photo.') . EOL);
                }
 
                // reload contact info
-               $contact = dba::selectFirst('contact', [], ['id' => $contact_id]);
-               if ((isset($new_relation) && $new_relation == CONTACT_IS_FRIEND)) {
-                       if (DBM::is_result($contact) && ($contact['network'] === NETWORK_DIASPORA)) {
+               $contact = DBA::selectFirst('contact', [], ['id' => $contact_id]);
+               if ((isset($new_relation) && $new_relation == Contact::FRIEND)) {
+                       if (DBA::isResult($contact) && ($contact['network'] === Protocol::DIASPORA)) {
                                $ret = Diaspora::sendShare($user, $contact);
                                logger('share returns: ' . $ret);
                        }
-
-                       // Send a new friend post if we are allowed to...
-                       $profile = dba::selectFirst('profile', ['hide-friends'], ['is-default' => true, 'uid' => $uid]);
-                       if (x($profile, 'hide-friends') === 0 && $activity && !$hidden) {
-                               $self = dba::selectFirst('contact', [], ['self' => true, 'uid' => $uid]);
-                               if (DBM::is_result($self)) {
-                                       $arr = [];
-                                       $arr['guid'] = get_guid(32);
-                                       $arr['uri'] = $arr['parent-uri'] = item_new_uri($a->get_hostname(), $uid);
-                                       $arr['uid'] = $uid;
-                                       $arr['contact-id'] = $self['id'];
-                                       $arr['wall'] = 1;
-                                       $arr['type'] = 'wall';
-                                       $arr['gravity'] = 0;
-                                       $arr['origin'] = 1;
-                                       $arr['author-name']   = $arr['owner-name']   = $self['name'];
-                                       $arr['author-link']   = $arr['owner-link']   = $self['url'];
-                                       $arr['author-avatar'] = $arr['owner-avatar'] = $self['thumb'];
-
-                                       $A = '[url=' . $self['url'] . ']' . $self['name'] . '[/url]';
-                                       $B = '[url=' . $contact['url'] . ']' . $contact['name'] . '[/url]';
-                                       $BPhoto = '[url=' . $contact['url'] . ']' . '[img]' . $contact['thumb'] . '[/img][/url]';
-
-                                       $arr['verb'] = ACTIVITY_FRIEND;
-                                       $arr['object-type'] = ACTIVITY_OBJ_PERSON;
-                                       $arr['body'] = L10n::t('%1$s is now friends with %2$s', $A, $B) . "\n\n\n" . $BPhoto;
-
-                                       $arr['object'] = '<object><type>' . ACTIVITY_OBJ_PERSON . '</type><title>' . $contact['name'] . '</title>'
-                                               . '<id>' . $contact['url'] . '/' . $contact['name'] . '</id>';
-                                       $arr['object'] .= '<link>' . xmlify('<link rel="alternate" type="text/html" href="' . $contact['url'] . '" />' . "\n");
-                                       $arr['object'] .= xmlify('<link rel="photo" type="image/jpeg" href="' . $contact['thumb'] . '" />' . "\n");
-                                       $arr['object'] .= '</link></object>' . "\n";
-
-                                       $arr['allow_cid'] = $user['allow_cid'];
-                                       $arr['allow_gid'] = $user['allow_gid'];
-                                       $arr['deny_cid']  = $user['deny_cid'];
-                                       $arr['deny_gid']  = $user['deny_gid'];
-
-                                       $i = Item::insert($arr);
-                                       if ($i) {
-                                               Worker::add(PRIORITY_HIGH, "Notifier", "activity", $i);
-                                       }
-                               }
-                       }
                }
 
                Group::addMember(User::getDefaultGroup($uid, $contact["network"]), $contact['id']);
 
+               if ($network == Protocol::ACTIVITYPUB && $duplex) {
+                       ActivityPub\Transmitter::sendActivity('Follow', $contact['url'], $uid);
+               }
+
                // Let's send our user to the contact editor in case they want to
                // do anything special with this new friend.
                if ($handsfree === null) {
-                       goaway(System::baseUrl() . '/contacts/' . intval($contact_id));
+                       $a->redirect('contact/' . intval($contact_id));
                } else {
                        return;
                }
@@ -493,8 +439,8 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                }
 
                // Find our user's account
-               $user = dba::selectFirst('user', [], ['nickname' => $node]);
-               if (!DBM::is_result($user)) {
+               $user = DBA::selectFirst('user', [], ['nickname' => $node]);
+               if (!DBA::isResult($user)) {
                        $message = L10n::t('No user record found for \'%s\' ', $node);
                        System::xmlExit(3, $message); // failure
                        // NOTREACHED
@@ -521,16 +467,16 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                        // NOTREACHED
                }
 
-               $contact = dba::selectFirst('contact', [], ['url' => $decrypted_source_url, 'uid' => $local_uid]);
-               if (!DBM::is_result($contact)) {
+               $contact = DBA::selectFirst('contact', [], ['url' => $decrypted_source_url, 'uid' => $local_uid]);
+               if (!DBA::isResult($contact)) {
                        if (strstr($decrypted_source_url, 'http:')) {
                                $newurl = str_replace('http:', 'https:', $decrypted_source_url);
                        } else {
                                $newurl = str_replace('https:', 'http:', $decrypted_source_url);
                        }
 
-                       $contact = dba::selectFirst('contact', [], ['url' => $newurl, 'uid' => $local_uid]);
-                       if (!DBM::is_result($contact)) {
+                       $contact = DBA::selectFirst('contact', [], ['url' => $newurl, 'uid' => $local_uid]);
+                       if (!DBA::isResult($contact)) {
                                // this is either a bogus confirmation (?) or we deleted the original introduction.
                                $message = L10n::t('Contact record was not found for you on our site.');
                                System::xmlExit(3, $message);
@@ -561,18 +507,18 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                        $dfrn_pubkey = $public_key;
                }
 
-               if (dba::exists('contact', ['dfrn-id' => $decrypted_dfrn_id])) {
+               if (DBA::exists('contact', ['dfrn-id' => $decrypted_dfrn_id])) {
                        $message = L10n::t('The ID provided by your system is a duplicate on our system. It should work if you try again.');
                        System::xmlExit(1, $message); // Birthday paradox - duplicate dfrn-id
                        // NOTREACHED
                }
 
                $r = q("UPDATE `contact` SET `dfrn-id` = '%s', `pubkey` = '%s' WHERE `id` = %d",
-                       dbesc($decrypted_dfrn_id),
-                       dbesc($dfrn_pubkey),
+                       DBA::escape($decrypted_dfrn_id),
+                       DBA::escape($dfrn_pubkey),
                        intval($dfrn_record)
                );
-               if (!DBM::is_result($r)) {
+               if (!DBA::isResult($r)) {
                        $message = L10n::t('Unable to set your contact credentials on our system.');
                        System::xmlExit(3, $message);
                }
@@ -587,8 +533,8 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                }
 
                // We're good but now we have to scrape the profile photo and send notifications.
-               $contact = dba::selectFirst('contact', ['photo'], ['id' => $dfrn_record]);
-               if (DBM::is_result($contact)) {
+               $contact = DBA::selectFirst('contact', ['photo'], ['id' => $dfrn_record]);
+               if (DBA::isResult($contact)) {
                        $photo = $contact['photo'];
                } else {
                        $photo = System::baseUrl() . '/images/person-175.jpg';
@@ -598,12 +544,13 @@ function dfrn_confirm_post(App $a, $handsfree = null)
 
                logger('dfrn_confirm: request - photos imported');
 
-               $new_relation = CONTACT_IS_SHARING;
-               if (($relation == CONTACT_IS_FOLLOWER) || ($duplex)) {
-                       $new_relation = CONTACT_IS_FRIEND;
+               $new_relation = Contact::SHARING;
+
+               if (($relation == Contact::FOLLOWER) || ($duplex)) {
+                       $new_relation = Contact::FRIEND;
                }
 
-               if (($relation == CONTACT_IS_FOLLOWER) && ($duplex)) {
+               if (($relation == Contact::FOLLOWER) && ($duplex)) {
                        $duplex = 0;
                }
 
@@ -619,15 +566,15 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                        `network` = '%s' WHERE `id` = %d
                ",
                        intval($new_relation),
-                       dbesc(Temporal::utcNow()),
-                       dbesc(Temporal::utcNow()),
+                       DBA::escape(DateTimeFormat::utcNow()),
+                       DBA::escape(DateTimeFormat::utcNow()),
                        intval($duplex),
                        intval($forum),
                        intval($prv),
-                       dbesc(NETWORK_DFRN),
+                       DBA::escape(Protocol::DFRN),
                        intval($dfrn_record)
                );
-               if (!DBM::is_result($r)) {      // indicates schema is messed up or total db failure
+               if (!DBA::isResult($r)) {       // indicates schema is messed up or total db failure
                        $message = L10n::t('Unable to update your contact profile details on our system');
                        System::xmlExit(3, $message);
                }
@@ -645,11 +592,11 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                        LIMIT 1",
                        intval($dfrn_record)
                );
-               if (DBM::is_result($r)) {
+               if (DBA::isResult($r)) {
                        $combined = $r[0];
 
                        if ($combined['notify-flags'] & NOTIFY_CONFIRM) {
-                               $mutual = ($new_relation == CONTACT_IS_FRIEND);
+                               $mutual = ($new_relation == Contact::FRIEND);
                                notification([
                                        'type'         => NOTIFY_CONFIRM,
                                        'notify_flags' => $combined['notify-flags'],
@@ -657,7 +604,7 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                                        'to_name'      => $combined['username'],
                                        'to_email'     => $combined['email'],
                                        'uid'          => $combined['uid'],
-                                       'link'         => System::baseUrl() . '/contacts/' . $dfrn_record,
+                                       'link'         => System::baseUrl() . '/contact/' . $dfrn_record,
                                        'source_name'  => ((strlen(stripslashes($combined['name']))) ? stripslashes($combined['name']) : L10n::t('[Name Withheld]')),
                                        'source_link'  => $combined['url'],
                                        'source_photo' => $combined['photo'],
@@ -667,55 +614,12 @@ function dfrn_confirm_post(App $a, $handsfree = null)
                        }
                }
 
-               // Send a new friend post if we are allowed to...
-               if ($page && intval(PConfig::get($local_uid, 'system', 'post_joingroup'))) {
-                       $profile = dba::selectFirst('profile', ['hide-friends'], ['is-default' => true, 'uid' => $local_uid]);
-                       if (x($profile, 'hide-friends') === 0) {
-                               $self = dba::selectFirst('contact', [], ['self' => true, 'uid' => $local_uid]);
-                               if (DBM::is_result($self)) {
-                                       $arr = [];
-                                       $arr['uri'] = $arr['parent-uri'] = item_new_uri($a->get_hostname(), $local_uid);
-                                       $arr['uid'] = $local_uid;
-                                       $arr['contact-id'] = $self['id'];
-                                       $arr['wall'] = 1;
-                                       $arr['type'] = 'wall';
-                                       $arr['gravity'] = 0;
-                                       $arr['origin'] = 1;
-                                       $arr['author-name']   = $arr['owner-name']   = $self['name'];
-                                       $arr['author-link']   = $arr['owner-link']   = $self['url'];
-                                       $arr['author-avatar'] = $arr['owner-avatar'] = $self['thumb'];
-
-                                       $A = '[url=' . $self['url'] . ']' . $self['name'] . '[/url]';
-                                       $B = '[url=' . $combined['url'] . ']' . $combined['name'] . '[/url]';
-                                       $BPhoto = '[url=' . $combined['url'] . ']' . '[img]' . $combined['thumb'] . '[/img][/url]';
-
-                                       $arr['verb'] = ACTIVITY_JOIN;
-                                       $arr['object-type'] = ACTIVITY_OBJ_GROUP;
-                                       $arr['body'] = L10n::t('%1$s has joined %2$s', $A, $B) . "\n\n\n" . $BPhoto;
-                                       $arr['object'] = '<object><type>' . ACTIVITY_OBJ_GROUP . '</type><title>' . $combined['name'] . '</title>'
-                                               . '<id>' . $combined['url'] . '/' . $combined['name'] . '</id>';
-                                       $arr['object'] .= '<link>' . xmlify('<link rel="alternate" type="text/html" href="' . $combined['url'] . '" />' . "\n");
-                                       $arr['object'] .= xmlify('<link rel="photo" type="image/jpeg" href="' . $combined['thumb'] . '" />' . "\n");
-                                       $arr['object'] .= '</link></object>' . "\n";
-
-                                       $arr['allow_cid'] = $user['allow_cid'];
-                                       $arr['allow_gid'] = $user['allow_gid'];
-                                       $arr['deny_cid']  = $user['deny_cid'];
-                                       $arr['deny_gid']  = $user['deny_gid'];
-
-                                       $i = Item::insert($arr);
-                                       if ($i) {
-                                               Worker::add(PRIORITY_HIGH, "Notifier", "activity", $i);
-                                       }
-                               }
-                       }
-               }
                System::xmlExit(0); // Success
                return; // NOTREACHED
                ////////////////////// End of this scenario ///////////////////////////////////////////////
        }
 
        // somebody arrived here by mistake or they are fishing. Send them to the homepage.
-       goaway(System::baseUrl());
+       $a->redirect();
        // NOTREACHED
 }